[PATCH] target/arm: kvm: use RCU_READ_LOCK_GUARD() in kvm_arch_fixup_msi_route()

2021-07-27 Thread Hamza Mahfooz
As per commit 5626f8c6d468 ("rcu: Add automatically released rcu_read_lock variants"), RCU_READ_LOCK_GUARD() should be used instead of rcu_read_{un}lock(). Signed-off-by: Hamza Mahfooz --- target/arm/kvm.c | 17 - 1 file changed, 8 insertions(+), 9 deletions(-) di

Re: [PATCH] linux-user: make process_pending_signals thread-safe

2021-05-27 Thread Hamza Mahfooz
On Thu, May 27 2021 at 11:45:26 AM +0100, Peter Maydell wrote: What issue are we trying to fix by making this change ? I suppose that it wouldn't fix any issues in the current state of affairs, maybe it is something to reconsider if glibc ever changes such that, sigprocmask is no longer MT

Re: [PATCH] linux-user: make process_pending_signals thread-safe

2021-05-27 Thread Hamza Mahfooz
On Thu, May 27 2021 at 11:16:56 AM +0100, Peter Maydell wrote: If we do want to change from sigprocmask() to pthread_sigmask(), we should be consistent about doing that, not just change this call only.) On that note, do you think it would worthwhile to have a Coccinelle script replace all

[PATCH] linux-user: make process_pending_signals thread-safe

2021-05-23 Thread Hamza Mahfooz
Use pthread_sigmask instead of sigprocmask inside process_pending_signals to ensure that race conditions aren't possible. Signed-off-by: Hamza Mahfooz --- linux-user/signal.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/linux-user/signal.c b/linux-user/signal.c