Re: [Qemu-devel] [PATCH 1/5] nvme: PCI/e configuration from specification

Hi Daniel, Sorry for the long round-trips, we had a busy month. We have implemented all the changes. Waiting for a final clarification. Should the new patches be posted on this thread or a new one? Thanks for you time. Gersner. On Thu, Aug 30, 2018 at 6:45 PM Daniel Verkamp wrote: >

Re: [Qemu-devel] [PATCH 1/5] nvme: PCI/e configuration from specification

Hi Daniel, Thanks for taking a look. Comments are inline. Gersner. On Sun, Jul 15, 2018 at 9:21 AM Daniel Verkamp wrote: > On Fri, Jun 22, 2018 at 4:22 AM, Shimi Gersner wrote: > > PCI/e configuration currently does not meets specifications. > > > > Patch includes

[Qemu-devel] [PATCH 5/5] nvme: Missing MSI message upon partial CQ read

fails to re-send a new MSI message stating buffer still has unread data. The fix ensures a new message will be sent. Change-Id: I10190be127b8dcbd89732cfb95ea37faf8c5779b Signed-off-by: Shimi Gersner --- hw/block/nvme.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/block/nvme.c b/hw

[Qemu-devel] [PATCH 1/5] nvme: PCI/e configuration from specification

Reset. - Disable QEMUs default use of PCIe Link Status (DLLLA). - PCIe missing AOC compliance flag. - Mask PCIe End-to-End TLP as RO (Unspecified by specification). Change-Id: I9057f56266db16b013fa194730c998d4779cede3 Signed-off-by: Shimi Gersner --- hw/block/nvme.c | 59

[Qemu-devel] [PATCH 3/5] nvme: Proper state handling on enable/disable

and only notify on shutdown completion. Change-Id: Ia0bc29775b12586c3aab2ca217603051062c3efe Signed-off-by: Shimi Gersner --- hw/block/nvme.c | 67 ++-- include/block/nvme.h | 5 2 files changed, 44 insertions(+), 28 deletions(-) diff --git a

[Qemu-devel] [PATCH 4/5] nvme: Fix phantom irq raise

hence no need to raise the irq. Change-Id: Ib7af6c1bcb63d03022d9b57e079fdb2cf954e7dc Signed-off-by: Shimi Gersner --- hw/block/nvme.c | 14 +- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 206d8428fd..f639d7ae73 100644 --- a/hw

[Qemu-devel] [PATCH 2/5] nvme: CQ/SQ proper validation & status code

as defined by the sepecification. Additionally, CQ creation failed to properly check irq vector number. Change-Id: I3b6d8179ce567be4cd064c0be0ed69a740708096 Signed-off-by: Shimi Gersner --- hw/block/nvme.c | 40 +--- 1 file changed, 25 insertions(+), 15

[Qemu-devel] [Bug 1777236] [NEW] NVME is missing support for mandatory features through "Get/Set Feature" command

Public bug reported: The following are features which are marked as mandatory by the 1.2 specification (NVMe 1.2, Section 5.14.1, Figure 108) as currently not implemented - 0x1 Arbitration - 0x2 Power Management - 0x4 Temperature Threshold - 0x5 Error Recovery - 0x6 Interrupt Coalescing -

[Qemu-devel] [Bug 1777235] [NEW] NVME is missing support for Get Log Page command

Public bug reported: "Get Log Page" is a mandatory admin command by the specification (NVMe 1.2, Section 5, Figure 40) currently not implemented by device. ** Affects: qemu Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- de

[Qemu-devel] [Bug 1777232] [NEW] NVME fails on big writes

Public bug reported: NVME Compliance test 8:3.3.0 tries to write and read back big chunks of pages. Currently, on the latest QEMU operation of size 1024 blocks will fail when device is backed by a file. NVME specification has several types of data transfers from guests, one of the is the PRP list