[Qemu-devel] [PATCH v7] lsi: Reselection needed to remove pending commands from queue

2018-11-09 Thread George Kennedy
current command, check for a pending command on the queue and if one exists call lsi_reselect(). Signed-off-by: George Kennedy --- Thanks again Paolo, Your latest suggested fix reduces the patch even further. Now there's no need for a "pending" flag. (Will try to find the intermedi

[Qemu-devel] [PATCH v6] lsi: Reselection needed to remove pending commands from queue

2018-11-07 Thread George Kennedy
-off-by: George Kennedy --- Thanks Paolo, Your latest suggestion was the "missing link". Calling lsi_wait_reselect() after a WAIT DISCONNECT Script instruction when there are commands on the pending queue is all the is needed. The patch has been greatly reduced in size and complexity.

[Qemu-devel] [PATCH v5] lsi: Reselection needed to remove pending commands from queue

2018-11-07 Thread George Kennedy
instead with the pointer to the Reselection Scripts. When Reselection has completed, restore the original DSP contents. Signed-off-by: George Kennedy --- Thanks Paolo, Sorry for missing your suggested fix. I believe the Script intercept is now being done as you had suggested. hw/scsi

Re: [Qemu-devel] [PATCH v4] lsi_scsi: Reselection needed to remove pending commands from queue

2018-11-06 Thread george kennedy
On 11/6/2018 1:58 PM, Paolo Bonzini wrote: On 31/10/2018 22:03, George Kennedy wrote: +#define SCRIPTS_LOAD_AND_STORE 0xe2340004 I'm very confused. Why did this constant reappear? Ok. Me too. What are you proposing instead and I'll change it to that? Did I have what you

[Qemu-devel] [PATCH v4] lsi_scsi: Reselection needed to remove pending commands from queue

2018-10-31 Thread George Kennedy
. When Reselection has completed, restore the original DSP contents. Signed-off-by: George Kennedy --- Thanks Paolo, For the question about why the "- 8" in "s->resel_dsp = s->dsp - 8". Notice that at the beginning of lsi_execute_script() just before the "switch

Re: [Qemu-devel] [PATCH v3] lsi_scsi: Reselection needed to remove pending commands from queue

2018-10-31 Thread George Kennedy
On 10/31/2018 5:21 AM, Paolo Bonzini wrote: On 30/10/2018 22:42, George Kennedy wrote: Under heavy IO (e.g. fio) the queue is not checked frequently enough for pending commands. As a result some pending commands are timed out by the linux sym53c8xx driver, which sends SCSI Abort messages for

[Qemu-devel] [PATCH v3] lsi_scsi: Reselection needed to remove pending commands from queue

2018-10-30 Thread George Kennedy
. When Reselection has completed, restore the original DSP contents. Signed-off-by: George Kennedy --- hw/scsi/lsi53c895a.c | 51 --- 1 file changed, 40 insertions(+), 11 deletions(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi/lsi53c895a.c index

Re: [Qemu-devel] [PATCH v2] lsi: Reselection needed to remove pending commands from queue

2018-10-24 Thread George Kennedy
On 10/23/2018 6:31 PM, Paolo Bonzini wrote: On 24/10/2018 00:11, George Kennedy wrote: What about "req->hba_private != s->current"?  That should cause a call to lsi_queue_req, and then you can check s->want_resel in lsi_queue_req. For the extended period of time where lsi

Re: [Qemu-devel] [PATCH v2] lsi: Reselection needed to remove pending commands from queue

2018-10-23 Thread George Kennedy
On 10/23/2018 5:50 PM, Paolo Bonzini wrote: On 23/10/2018 23:36, George Kennedy wrote: On 10/23/2018 10:33 AM, Paolo Bonzini wrote: On 22/10/2018 23:28, George Kennedy wrote: As you suggested I moved the loading of "s->resel_dsp" down to the "Wait Reselect" c

Re: [Qemu-devel] [PATCH v2] lsi: Reselection needed to remove pending commands from queue

2018-10-23 Thread George Kennedy
On 10/23/2018 10:33 AM, Paolo Bonzini wrote: On 22/10/2018 23:28, George Kennedy wrote: As you suggested I moved the loading of "s->resel_dsp" down to the "Wait Reselect" case. The address of the Reselection Scripts, though, is contained in "s->dsp - 8&quo

[Qemu-devel] [PATCH v2] lsi: Reselection needed to remove pending commands from queue

2018-10-22 Thread George Kennedy
Reselection Scripts. When Reselection has completed, restore the original DSP contents. Signed-off-by: George Kennedy --- Thank you for reviewing, Paolo, As you suggested I moved the loading of "s->resel_dsp" down to the "Wait Reselect" case. The address of the Reselect

[Qemu-devel] [PATCH] lsi: Reselection needed to remove pending commands from queue

2018-10-01 Thread George Kennedy
Reselection Scripts. When Reselection has completed, restore the original DSP contents. Signed-off-by: George Kennedy --- hw/scsi/lsi53c895a.c | 94 ++-- 1 file changed, 91 insertions(+), 3 deletions(-) diff --git a/hw/scsi/lsi53c895a.c b/hw/scsi

Re: [Qemu-devel] [Qemu-trivial] [PATCH] lsi_scsi: add support for PPR Extended Message

2017-12-11 Thread George Kennedy
Thank you Paolo, "Signed-off-by: George Kennedy" George On 12/11/2017 11:55 AM, Paolo Bonzini wrote: On 11/12/2017 17:45, George Kennedy wrote: The LSI 53c895a code does not handle the PPR Extended Message. Add support to handle PPR Extended Message like SDTR and WDTR are handle

[Qemu-devel] [Qemu-trivial] [PATCH] lsi_scsi: add support for PPR Extended Message

2017-12-11 Thread George Kennedy
The LSI 53c895a code does not handle the PPR Extended Message. Add support to handle PPR Extended Message like SDTR and WDTR are handled. That is, to skip past the message bytes and ignore the message. --- hw/scsi/lsi53c895a.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/scsi/lsi

[Qemu-devel] [Qemu-trivial] [PATCH] lsi_scsi: add support for PPR Extended Message

2017-12-07 Thread George Kennedy
The LSI 53c895a code does not handle the PPR Extended Message. Add support to handle PPR Extended Message like SDTR and WDTR are handled. That is, to skip past the message bytes and ignore the message. --- hw/scsi/lsi53c895a.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/scsi/lsi