things working.
On 2023-04-19 14:39, Geoffrey McRae wrote:
Since OVMF 202211 the bios maps BAR2 to an upper address which has the
undesirable effect of making it impossible to map the memory under
Linux
due to it exceeding the maximum permissible range for hotplug memory
(see
configuring the BAR as 32-bit.
Signed-off-by: Geoffrey McRae
---
hw/misc/ivshmem.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/misc/ivshmem.c b/hw/misc/ivshmem.c
index d66d912172..2f8f7e2030 100644
--- a/hw/misc/ivshmem.c
+++ b/hw/misc/ivshmem.c
@@ -913,7 +913,7
On 2022-05-24 01:28, Gerd Hoffmann wrote:
On Tue, May 24, 2022 at 12:35:49AM +1000, Geoffrey McRae wrote:
Hi Gerd,
Over the past few weeks I have been adding spice display support to
Looking
Glass as a fallback mechanism for during system boot (or diags) before
our
application is loaded in
fine
until you load the QXL display driver.
The issue is that once the driver is loaded windows removes the option
to duplicate the output. Is this something that needs to be tweaked in
the driver to allow this? or is there a technical reason why this can't
be done?
Kind Regards,
Geoffrey McRae
Signed-off-by: Geoffrey McRae
---
audio/spiceaudio.c | 19 ---
1 file changed, 16 insertions(+), 3 deletions(-)
diff --git a/audio/spiceaudio.c b/audio/spiceaudio.c
index a8d370fe6f..0c44bbe836 100644
--- a/audio/spiceaudio.c
+++ b/audio/spiceaudio.c
@@ -76,7 +76,7 @@ static void
uides/documentation on how to use a generic jack client. IMO the better
solution here is simply better documentation, perhaps even a known
working sample setup.
On 2021-02-25 09:33, Christian Schoenebeck wrote:
On Mittwoch, 24. Februar 2021 23:04:47 CET Geoffrey McRae wrote:
This goes against ho
This goes against how all standard jack clients work, a new jack client
should not auto-connect at all unless explicitly configured to as if
there is an existing audio diagram configured (which is 99% of the time)
it will cause unexpected/undesired behavior.
Jack is not supposed to be an 'auto
v10:
* fixed typo in commit message
* qjack_shutdown_lock is now static
Geoffrey McRae (1):
audio/jack: fix use after free segfault
audio/jackaudio.c | 50 +++
1 file changed, 37 insertions(+), 13 deletions(-)
--
2.20.1
This change registers a bottom handler to close the JACK client
connection when a server shutdown signal is received. Without this
libjack2 attempts to "clean up" old clients and causes a use after free
segfault.
Signed-off-by: Geoffrey McRae
---
audio/jackau
This change registers a bottom handler to close the JACK client
connection when a server shutdown signal is recieved. Without this
libjack2 attempts to "clean up" old clients and causes a use after free
segfault.
Signed-off-by: Geoffrey McRae
---
audio/jackau
v9:
* switch to using a global shutdown mutex
Geoffrey McRae (1):
audio/jack: fix use after free segfault
audio/jackaudio.c | 50 +++
1 file changed, 37 insertions(+), 13 deletions(-)
--
2.20.1
the original maximum value of 0xff
Signed-off-by: Geoffrey McRae
---
hw/core/qdev-properties-system.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/core/qdev-properties-system.c b/hw/core/qdev-properties-system.c
index b81a4e8d14..e62644bc69 100644
--- a/hw/core/qdev
On 2020-08-22 03:47, Paolo Bonzini wrote:
On 21/08/20 19:34, Christian Schoenebeck wrote:
static void qjack_fini_out(HWVoiceOut *hw)
{
QJackOut *jo = (QJackOut *)hw;
qjack_client_fini(&jo->c);
+
+qemu_bh_delete(jo->c.shutdown_bh);
Paolo wrapped that qemu_bh_delete() call insi
This change registers a bottom handler to close the JACK client
connection when a server shutdown signal is recieved. Without this
libjack2 attempts to "clean up" old clients and causes a use after free
segfault.
Signed-off-by: Geoffrey McRae
---
audio/jackau
v8:
* use a local mutex instead of the BQL
Geoffrey McRae (1):
audio/jack: fix use after free segfault
audio/jackaudio.c | 55 ---
1 file changed, 42 insertions(+), 13 deletions(-)
--
2.20.1
My suggestion is to work towards protecting the audio code with its own
mutex(es) and ignore the existence of the BQL for subsystems that can
do
so (audio is a prime candidate). Also please add comments to
audio_int.h about which functions are called from other threads than
the
QEMU main t
Forgot to update this cover letter too, sorry for the spam, there are no
changes to spice-input.c anymore
On 2020-08-20 10:27, Geoffrey McRae wrote:
v7:
* removed accidental inclusion of spice-input changes
Geoffrey McRae (1):
audio/jack: fix use after free segfault
audio/jackaudio.c
v6:
* delete the QEMUBH when finished
* fix possible race by taking the iothread mutex
* removed whitespace changes
Geoffrey McRae (1):
audio/jack: fix use after free segfault
audio/jackaudio.c | 51 +--
ui/spice-input.c | 2 ++
2 files
This change registers a bottom handler to close the JACK client
connection when a server shutdown signal is recieved. Without this
libjack2 attempts to "clean up" old clients and causes a use after free
segfault.
Signed-off-by: Geoffrey McRae
---
audio/jackau
This change registers a bottom handler to close the JACK client
connection when a server shutdown signal is recieved. Without this
libjack2 attempts to "clean up" old clients and causes a use after free
segfault.
Signed-off-by: Geoffrey McRae
---
audio/jackau
v7:
* removed accidental inclusion of spice-input changes
Geoffrey McRae (1):
audio/jack: fix use after free segfault
audio/jackaudio.c | 51 +--
ui/spice-input.c | 2 ++
2 files changed, 38 insertions(+), 15 deletions(-)
--
2.20.1
On 2020-08-20 01:51, Christian Schoenebeck wrote:
On Mittwoch, 19. August 2020 14:51:52 CEST Geoffrey McRae wrote:
>> > What latencies do you achieve BTW with Windows guests?
>>
>> Never tested, it's not the reason why I use jack.
>
> Surpring that you never ch
On 2020-08-20 01:21, Christian Schoenebeck wrote:
On Mittwoch, 19. August 2020 08:29:39 CEST Geoffrey McRae wrote:
This change registers a bottom handler to close the JACK client
connection when a server shutdown signal is recieved. Without this
libjack2 attempts to "clean up" o
On 2020-08-19 22:41, Christian Schoenebeck wrote:
On Mittwoch, 19. August 2020 13:45:33 CEST Geoffrey McRae wrote:
> I still don't quite get how this correlates. So you are forcing a
> restart of
> jackd on host side in between, for what purpose? To simulate the
> Windo
On 2020-08-19 21:30, Christian Schoenebeck wrote:
On Mittwoch, 19. August 2020 00:20:07 CEST Geoffrey McRae wrote:
> Could you please describe in more detail how you ran into this
> situation with
> your 2nd audio device?
Sure. Run a Windows guest with two audio devices, let it boot
This change registers a bottom handler to close the JACK client
connection when a server shutdown signal is recieved. Without this
libjack2 attempts to "clean up" old clients and causes a use after free
segfault.
Signed-off-by: Geoffrey McRae
---
audio/jackau
v5:
* removed hanging dlfcn include from v3
Geoffrey McRae (1):
audio/jack: fix use after free segfault
audio/jackaudio.c | 29 -
1 file changed, 20 insertions(+), 9 deletions(-)
--
2.20.1
v4:
Use a bottom handler for shutdown as suggested by Gerd Hoffman
Geoffrey McRae (1):
audio/jack: fix use after free segfault
audio/jackaudio.c | 30 +-
configure | 4 +++-
2 files changed, 24 insertions(+), 10 deletions(-)
--
2.20.1
This change registers a bottom handler to close the JACK client
connection when a server shutdown signal is recieved. Without this
libjack2 attempts to "clean up" old clients and causes a use after free
segfault.
Signed-off-by: Geoffrey McRae
---
audio/jackau
On 2020-08-19 15:28, Geoffrey McRae wrote:
On 2020-08-19 15:04, Gerd Hoffmann wrote:
Hi,
As JACK1 and JACK2 are interchangeable and JACK2 has "cleanup"
routine
that JACK1 does not have, we need to determine which version is in
use
at runtime. Unfortunatly there is no way to deter
On 2020-08-19 15:04, Gerd Hoffmann wrote:
Hi,
As JACK1 and JACK2 are interchangeable and JACK2 has "cleanup" routine
that JACK1 does not have, we need to determine which version is in use
at runtime. Unfortunatly there is no way to determine which is in use
other then to look for symbols that a
On 2020-08-19 14:46, Philippe Mathieu-Daudé wrote:
On 8/19/20 5:36 AM, Geoffrey McRae wrote:
On 2020-08-19 13:32, Philippe Mathieu-Daudé wrote:
Hi Geoffrey,
On 8/19/20 3:18 AM, Geoffrey McRae wrote:
The client may have been freed already by a secondary audio device
recovering its
On 2020-08-19 13:32, Philippe Mathieu-Daudé wrote:
Hi Geoffrey,
On 8/19/20 3:18 AM, Geoffrey McRae wrote:
The client may have been freed already by a secondary audio device
recovering its session as JACK2 has some cleanup code to work around
broken clients, which doesn't account for
Fixed accidental eof newline strip from `configure`
Geoffrey McRae (1):
audio/jack: fix use after free segfault
audio/jackaudio.c | 37 -
configure | 4 +++-
2 files changed, 39 insertions(+), 2 deletions(-)
--
2.20.1
all
memory leak if the jack server is restarted. This however is better then
the alternative which would be a use after free segfault.
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 37 -
configure | 4 +++-
2 files changed, 39 insertions(
all
memory leak if the jack server is restarted. This however is better then
the alternative which would be a use after free segfault.
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 37 -
configure | 5 +++--
2 files changed, 39 insertions(
On 2020-08-19 04:11, Christian Schoenebeck wrote:
On Dienstag, 18. August 2020 14:40:36 CEST Geoffrey McRae wrote:
Due to a ridiculous commit in the Jack library, the client may have
been
freed already by a secondary audio device recovering its session.
https://github.com/jackaudio/jack2
ted in the jack library this will need to be revisited.
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 17 -
1 file changed, 16 insertions(+), 1 deletion(-)
diff --git a/audio/jackaudio.c b/audio/jackaudio.c
index 72ed7c4929..e8faf1bb89 100644
--- a/audio/jackaudio.c
+
On 2020-06-22 19:05, Gerd Hoffmann wrote:
On Sun, Jun 21, 2020 at 02:06:25PM +1000, Geoffrey McRae wrote:
> Can you stop the stream without closing the connection?
Not as far as I can tell, it seems the JACK API doesn't allow for this
in a
way that is useful to us.
What happen
On 2020-06-19 19:29, Gerd Hoffmann wrote:
Hi,
> Hmm, I guess feeding silence into jack needs some cpu cycles?
> Maybe add a timer to close the jack server connection? Keep the
> connection open for re-use for a while, but in case the guest stops
> playing sound altogether close the jack con
On 2020-06-17 22:44, Gerd Hoffmann wrote:
On Sat, Jun 13, 2020 at 02:05:17PM +1000, Geoffrey McRae wrote:
When the guest closes the audio device we must start dropping input
samples from JACK and zeroing the output buffer samples. Failure to do
so causes sound artifacts during operations
breakdown with the server the client library waits
forever for a response to the unregister request.
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/audio/jackaudio.c b/audio/jackaudio.c
index 58c7344497..249cbd3265 100644
--- a/audio
what this was for when the audodev was initially
developed.
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/audio/jackaudio.c b/audio/jackaudio.c
index fb8efd7af7..58c7344497 100644
--- a/audio/jackaudio.c
+++ b/audio/jackaudio.c
@@ -607,9
d-off-by: Geoffrey McRae
---
audio/jackaudio.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/audio/jackaudio.c b/audio/jackaudio.c
index 722ddb1dfe..d0b6f748f2 100644
--- a/audio/jackaudio.c
+++ b/audio/jackaudio.c
@@ -434,17 +434,6 @@ stati
Instead of checking for the audodev state in each code path, centralize
the check into the initialize function itself to make it safe to call it
at any time.
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a
This patch set addresses several issues that cause inconsistent
behaviour in the guest when the sound device is stopped and started or
the JACK server stops responding on the host.
Geoffrey McRae (6):
audio/jack: fix invalid minimum buffer size check
audio/jack: remove unused stopped state
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 4
1 file changed, 4 deletions(-)
diff --git a/audio/jackaudio.c b/audio/jackaudio.c
index d0b6f748f2..fb8efd7af7 100644
--- a/audio/jackaudio.c
+++ b/audio/jackaudio.c
@@ -38,7 +38,6 @@ struct QJack;
typedef enum QJackState
disabled.
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 29 +
1 file changed, 21 insertions(+), 8 deletions(-)
diff --git a/audio/jackaudio.c b/audio/jackaudio.c
index 249cbd3265..b2b53985ae 100644
--- a/audio/jackaudio.c
+++ b/audio/jackaudio.c
@@ -56,7 +56,7
Thanks, still learning how best to submit these things :)
Is it worth re-sending this again as per the below?
On 2020-06-12 17:11, Gerd Hoffmann wrote:
On Fri, Jun 12, 2020 at 10:12:37AM +1000, Geoffrey McRae wrote:
Sorry for the spam, resubmitted due to missing subject on this cover
letter
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 29 +
1 file changed, 21 insertions(+), 8 deletions(-)
diff --git a/audio/jackaudio.c b/audio/jackaudio.c
index 249cbd3265..b2b53985ae 100644
--- a/audio/jackaudio.c
+++ b/audio/jackaudio.c
@@ -56,7 +56,7
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/audio/jackaudio.c b/audio/jackaudio.c
index b2b53985ae..72ed7c4929 100644
--- a/audio/jackaudio.c
+++ b/audio/jackaudio.c
@@ -395,6 +395,10 @@ static int
This fixes a hang when there is a communications issue with the JACK
server. Simply closing the connection is enough to completely clean up
and as such we do not need to remove the ports first.
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 3 ---
1 file changed, 3 deletions(-)
diff
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/audio/jackaudio.c b/audio/jackaudio.c
index fb8efd7af7..58c7344497 100644
--- a/audio/jackaudio.c
+++ b/audio/jackaudio.c
@@ -607,9 +607,6 @@ static int qjack_thread_creator
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 4
1 file changed, 4 deletions(-)
diff --git a/audio/jackaudio.c b/audio/jackaudio.c
index d0b6f748f2..fb8efd7af7 100644
--- a/audio/jackaudio.c
+++ b/audio/jackaudio.c
@@ -38,7 +38,6 @@ struct QJack;
typedef enum QJackState
stops responding on the host.
Geoffrey McRae (6):
audio/jack: fix invalid minimum buffer size check
audio/jack: remove unused stopped state
audio/jack: remove invalid set of input support bool
audio/jack: do not remove ports when finishing
audio/jack: honour the enable state of the
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/audio/jackaudio.c b/audio/jackaudio.c
index 722ddb1dfe..d0b6f748f2 100644
--- a/audio/jackaudio.c
+++ b/audio/jackaudio.c
@@ -434,17 +434,6 @@ static
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/audio/jackaudio.c b/audio/jackaudio.c
index fb8efd7af7..58c7344497 100644
--- a/audio/jackaudio.c
+++ b/audio/jackaudio.c
@@ -607,9 +607,6 @@ static int qjack_thread_creator
This fixes a hang when there is a communications issue with the JACK
server. Simply closing the connection is enough to completely clean up
and as such we do not need to remove the ports first.
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 3 ---
1 file changed, 3 deletions(-)
diff
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 4
1 file changed, 4 deletions(-)
diff --git a/audio/jackaudio.c b/audio/jackaudio.c
index d0b6f748f2..fb8efd7af7 100644
--- a/audio/jackaudio.c
+++ b/audio/jackaudio.c
@@ -38,7 +38,6 @@ struct QJack;
typedef enum QJackState
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 29 +
1 file changed, 21 insertions(+), 8 deletions(-)
diff --git a/audio/jackaudio.c b/audio/jackaudio.c
index 249cbd3265..b2b53985ae 100644
--- a/audio/jackaudio.c
+++ b/audio/jackaudio.c
@@ -56,7 +56,7
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 22 +++---
1 file changed, 11 insertions(+), 11 deletions(-)
diff --git a/audio/jackaudio.c b/audio/jackaudio.c
index 722ddb1dfe..d0b6f748f2 100644
--- a/audio/jackaudio.c
+++ b/audio/jackaudio.c
@@ -434,17 +434,6 @@ static
Signed-off-by: Geoffrey McRae
---
audio/jackaudio.c | 12 ++--
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/audio/jackaudio.c b/audio/jackaudio.c
index b2b53985ae..72ed7c4929 100644
--- a/audio/jackaudio.c
+++ b/audio/jackaudio.c
@@ -395,6 +395,10 @@ static int
This patch set addresses several issues that cause inconsistent
behaviour in the guest when the sound device is stopped and started or
the JACK server stops responding on the host.
Geoffrey McRae (6):
audio/jack: fix invalid minimum buffer size check
audio/jack: remove unused stopped state
This commit adds a new audiodev backend to allow QEMU to use JACK as
both an audio sink and source.
Signed-off-by: Geoffrey McRae
---
audio/Makefile.objs| 5 +
audio/audio.c | 1 +
audio/audio_template.h | 2 +
audio/jackaudio.c | 667
On 2020-05-12 00:53, Stefan Hajnoczi wrote:
On Wed, Apr 29, 2020 at 03:53:58PM +1000, Geoffrey McRae wrote:
This commit adds a new audiodev backend to allow QEMU to use JACK as
both an audio sink and source.
Signed-off-by: Geoffrey McRae
---
audio/Makefile.objs| 5 +
audio/audio.c
This commit adds a new audiodev backend to allow QEMU to use JACK as
both an audio sink and source.
Signed-off-by: Geoffrey McRae
---
audio/Makefile.objs| 5 +
audio/audio.c | 1 +
audio/audio_template.h | 2 +
audio/jackaudio.c | 677
On 2020-05-06 16:06, Markus Armbruster wrote:
You neglected to cc: the audio maintainer. Doing that for you now.
You
can use scripts/get_maintainer.pl to find maintainers.
Thanks, I was unaware.
Find my QAPI schema review inline.
Ditto
Geoffrey McRae writes:
This commit adds a
This commit adds a new audiodev backend to allow QEMU to use JACK as
both an audio sink and source.
Signed-off-by: Geoffrey McRae
---
audio/Makefile.objs| 5 +
audio/audio.c | 1 +
audio/audio_template.h | 2 +
audio/jackaudio.c | 677
This commit adds a new audiodev backend to allow QEMU to use JACK as
both an audio sink and source.
Signed-off-by: Geoffrey McRae
---
audio/Makefile.objs| 5 +
audio/audio.c | 1 +
audio/audio_template.h | 2 +
audio/jackaudio.c | 677
This commit adds a new audiodev backend to allow QEMU to use JACK as
both an audio sink and source.
Signed-off-by: Geoffrey McRae
---
audio/Makefile.objs| 5 +
audio/audio.c | 1 +
audio/audio_template.h | 2 +
audio/jackaudio.c | 707
This commit adds a new audiodev backend to allow QEMU to use JACK as
both an audio sink and source.
Signed-off-by: Geoffrey McRae
---
audio/Makefile.objs| 5 +
audio/audio.c | 1 +
audio/audio_template.h | 2 +
audio/jackaudio.c | 615
On 2020-04-29 22:59, Eric Blake wrote:
On 4/29/20 12:53 AM, Geoffrey McRae wrote:
This commit adds a new audiodev backend to allow QEMU to use JACK as
both an audio sink and source.
Signed-off-by: Geoffrey McRae
---
audio/Makefile.objs| 5 +
audio/audio.c | 1 +
audio
This commit adds a new audiodev backend to allow QEMU to use JACK as
both an audio sink and source.
Signed-off-by: Geoffrey McRae
---
audio/Makefile.objs| 5 +
audio/audio.c | 1 +
audio/audio_template.h | 2 +
audio/jackaudio.c | 615
This commit adds a new audiodev backend to allow QEMU to use JACK as
both an audio sink and source.
Signed-off-by: Geoffrey McRae
---
audio/Makefile.objs| 5 +
audio/audio.c | 1 +
audio/audio_template.h | 2 +
audio/jackaudio.c | 583
This commit adds a new audiodev backend to allow QEMU to use JACK as
both an audio sink and source.
Signed-off-by: Geoffrey McRae
---
audio/Makefile.objs| 5 +
audio/audio.c | 1 +
audio/audio_template.h | 2 +
audio/jackaudio.c | 583
I tracked this down and fixed it last year, your issue is unrelated.
https://github.com/qemu/qemu/commit/143c04c7e0639e53086519592ead15d2556bfbf2
#diff-3b5bd599c018d558b135bd19647a00c6
https://github.com/qemu/qemu/commit/7abe7eb29494b4e4a11ec99ae5623083409a2f1e
#diff-3b5bd599c018d558b135bd19647a0
timer,hv_spinlocks=0x1fff,hv_vendor_id=lakeuv283713,kvm=off,l3-cache=on,-hypervisor,migratable=no,+invtsc,topoext
If further details are required please advise.
Kind Regards,
Geoffrey McRae
HostFission
https://hostfission.com
== TRACE ==
Thread 12 (Thread 0x7f3ceb5fe700 (LWP 77094)
On 2019-11-20 23:13, Tomasz Figa wrote:
Hi Geoffrey,
On Thu, Nov 7, 2019 at 7:28 AM Geoffrey McRae
wrote:
On 2019-11-06 23:41, Gerd Hoffmann wrote:
> On Wed, Nov 06, 2019 at 05:36:22PM +0900, David Stevens wrote:
>> > (1) The virtio device
>> >
On 2019-11-06 23:41, Gerd Hoffmann wrote:
On Wed, Nov 06, 2019 at 05:36:22PM +0900, David Stevens wrote:
> (1) The virtio device
> =
>
> Has a single virtio queue, so the guest can send commands to register
> and unregister buffers. Buffers are allocated in guest ram. Ea
Hi Gerd.
On 2019-11-05 21:54, Gerd Hoffmann wrote:
Hi folks,
The issue of sharing buffers between guests and hosts keeps poping
up again and again in different contexts. Most recently here:
https://www.mail-archive.com/qemu-devel@nongnu.org/msg656685.html
So, I'm grabbing the recipient list
Hi,
I am trying to dig into this issue, can you please provide the verb
debug trace from the working version of windows.
--
You received this bug notification because you are a member of qemu-
devel-ml, which is subscribed to QEMU.
https://bugs.launchpad.net/bugs/1839060
Title:
HDA device non
where windows guests drop the mouse device
entirely requring the guest to be restarted.
Signed-off-by: Geoffrey McRae
---
hw/input/ps2.c | 124 +
include/hw/input/ps2.h | 5 ++
2 files changed, 100 insertions(+), 29 deletions(-)
diff
nse from
the command amongst other streaming data, such as mouse or keyboard
events. Standard practice is for the guest to disable the device and
then issue the identify command, so this must be obeyed.
Signed-off-by: Geoffrey McRae
---
hw/input/ps2.c | 11 +++
1 file changed, 11 insertions
where windows guests drop the mouse device
entirely requring the guest to be restarted.
Signed-off-by: Geoffrey McRae
---
hw/input/ps2.c | 120 +
include/hw/input/ps2.h | 5 +++
2 files changed, 96 insertions(+), 29 deletions(-)
diff
nse from
the command amongst other streaming data, such as mouse or keyboard
events. Standard practice is for the guest to disable the device and
then issue the identify command, so this must be obeyed.
Signed-off-by: Geoffrey McRae
---
hw/input/ps2.c | 7 +++
1 file changed, 7 insertions(+)
diff
where windows guests drop the mouse device
entirely requring the guest to be restarted.
Signed-off-by: Geoffrey McRae
---
hw/input/pckbd.c | 6 +--
hw/input/ps2.c | 160 +--
2 files changed, 110 insertions(+), 56 deletions(-)
diff --git a
This allows guest's to correctly reinitialize and identify the mouse
should the guest decide to re-scan or reset during mouse input events.
Signed-off-by: Geoffrey McRae
---
hw/input/ps2.c | 4
1 file changed, 4 insertions(+)
diff --git a/hw/input/ps2.c b/hw/input/ps2.c
index 06f5d
This bug needs some attention, we just released Looking Glass which
relies heavily on the relative input mode of SPICE which in turn relies
heavily on the virtual i8042 controller. This project has the ability to
completely eliminate the need to dual boot a Linux machine with windows
and is gaining
I believe I am onto the cause of this issue, because the input events
are coming from a multi threaded source (in my instance spice) keyboard
and mouse input share common code paths without any thread interlocking.
Since keyboard input takes priority over mouse, when more mouse events
are being ha
On 2017-10-17 02:20, Eric Blake wrote:
On 10/15/2017 04:32 AM, geoff--- via Qemu-devel wrote:
Hi All,
I am writing some code that needs to share a block of ram between a
Windows guest and Linux host. For this I am using the ivshmem device
and
I have written a very primitive driver for windows
On 2017-10-15 23:24, Yan Vugenfirer wrote:
On 15 Oct 2017, at 15:21, ge...@hostfission.com wrote:
Hi Yan,
Thank you for the information. I am rather new to Windows Driver
development and learning as I go, so this may take some time, but
since the driver only needs to perform very basic functi
Hi Yan,
Thank you for the information. I am rather new to Windows Driver
development and learning as I go, so this may take some time, but since
the driver only needs to perform very basic functions I do not see this
as being too much of a challenge.
-Geoff
On 2017-10-15 22:14, Yan Vugenfir
Further to this, it appears to be a race condition with reading from the
i8042 controller. I have turned on debugging of PS2 and KBD and filtered
out the event that causes the issue. I have split the below up to show
the valid reads for the mouse and then the sequence that triggers a
reset when the
Public bug reported:
When QEMU is getting a ton of mouse input events if keys are pressed on
the keyboard the scan code will be corrupted causing erroneous behavior.
I have confirmed this problem in the latest version in git
(530049bc1dcc24c1178a29d99ca08b6dd08413e0).
After the erroneous behavior
Here is a backtrace of the PS2 reset event:
#0 ps2_write_mouse (opaque=0x55804518ae30, val=255) at
/home/geoff/Projects/qemu/qemu/hw/input/ps2.c:1033
#1 0x5580420e1dd9 in kbd_write_data (opaque=0x558045147aa0, addr=0,
val=255, size=1) at /home/geoff/Projects/qemu/qemu/hw/input/pckbd.c:357
95 matches
Mail list logo
