[PATCH v4] arm/kvm: add support for MTE

2024-10-08 Thread Ganapatrao Kulkarni
st then tried to use MTE QEMU would segfault accessing the non-existent tag RAM.] Signed-off-by: Cornelia Huck Reviewed-by: Gustavo Romero Signed-off-by: Ganapatrao Kulkarni --- Changes since V3: Updated with review comments[1]. Changes since V2: Updated with review comment

Re: [PATCH V3] arm/kvm: add support for MTE

2024-09-27 Thread Ganapatrao Kulkarni
On 26-09-2024 09:41 pm, Gustavo Romero wrote: Hi Cornelia and Ganapatrao, On 9/25/24 14:54, Cornelia Huck wrote: On Fri, Sep 20 2024, Ganapatrao Kulkarni wrote: Mostly nit-picking below, otherwise LGTM. Extend the 'mte' property for the virt machine to cover KVM as well. F

Re: [PATCH V3] arm/kvm: add support for MTE

2024-09-25 Thread Ganapatrao Kulkarni
Hi Gustavo, On 25-09-2024 09:17 pm, Gustavo Romero wrote: Hi Ganapatrao, Sorry for the delay on replying it. I was attending KVM Forum and commuting. On 9/20/24 09:37, Ganapatrao Kulkarni wrote: Extend the 'mte' property for the virt machine to cover KVM as well. For KVM

[PATCH V3] arm/kvm: add support for MTE

2024-09-20 Thread Ganapatrao Kulkarni
hen tried to use MTE QEMU would segfault accessing the non-existent tag RAM. Signed-off-by: Cornelia Huck Signed-off-by: Ganapatrao Kulkarni --- Changes since V2: Updated with review comments. Changes since V1: Added code to enable MTE before reading register id_aa64pfr1 (unmas

Re: [PATCH V2] arm/kvm: add support for MTE

2024-09-19 Thread Ganapatrao Kulkarni
On 19-09-2024 08:35 pm, Cornelia Huck wrote: On Thu, Sep 19 2024, Ganapatrao Kulkarni wrote: I have modified as below diff to keep TCG if loop as it is and adding if for KVM case to clear/mask the MTE bits if MTE in KVM mode is not enabled by user command(if no mte=on). Is below diff

Re: [PATCH V2] arm/kvm: add support for MTE

2024-09-19 Thread Ganapatrao Kulkarni
Hi Gustavo, On 19-09-2024 08:31 am, Gustavo Romero wrote: Hi Cornelia and Ganapatrao, On 9/17/24 11:13, Cornelia Huck wrote: On Thu, Sep 12 2024, Ganapatrao Kulkarni wrote: Extend the 'mte' property for the virt machine to cover KVM as well. For KVM, we don't allocate

Re: [PATCH V2] arm/kvm: add support for MTE

2024-09-19 Thread Ganapatrao Kulkarni
On 19-09-2024 08:52 am, Gustavo Romero wrote: Hi Ganapatrao, On 9/12/24 06:16, Ganapatrao Kulkarni wrote: Extend the 'mte' property for the virt machine to cover KVM as well. For KVM, we don't allocate tag memory, but instead enable the capability. If MTE has been enab

[PATCH V2] arm/kvm: add support for MTE

2024-09-12 Thread Ganapatrao Kulkarni
hen tried to use MTE QEMU would segfault accessing the non-existent tag RAM. Signed-off-by: Cornelia Huck Signed-off-by: Ganapatrao Kulkarni --- Changes since V1: Added code to enable MTE before reading register id_aa64pfr1 (unmasked MTE bits). This patch is boot tested on ARM64 with KVM

Re: [PATCH] arm/kvm: add support for MTE

2024-09-10 Thread Ganapatrao Kulkarni
On 10-09-2024 05:53 pm, Peter Maydell wrote: On Tue, 10 Sept 2024 at 12:57, Ganapatrao Kulkarni wrote: On 16-07-2024 09:15 pm, Peter Maydell wrote: Since Cornelia first wrote the patch this is based on, we've landed gdbstub support for MTE (so gdb can find out which addresses in the m

Re: [PATCH] arm/kvm: add support for MTE

2024-09-10 Thread Ganapatrao Kulkarni
Hi Peter, On 16-07-2024 09:15 pm, Peter Maydell wrote: In target/arm/cpu.c:arm_cpu_realizefn() there is this code: if (cpu_isar_feature(aa64_mte, cpu)) { /* * The architectural range of GM blocksize is 2-6, however qemu * doesn't support blocksize of 2 (see

Re: [PATCH] arm/kvm: add support for MTE

2024-08-02 Thread Ganapatrao Kulkarni
Hi Peter, On 16-07-2024 09:15 pm, Peter Maydell wrote: On Tue, 9 Jul 2024 at 07:05, Ganapatrao Kulkarni wrote: Extend the 'mte' property for the virt machine to cover KVM as well. For KVM, we don't allocate tag memory, but instead enable the capability. If MTE has been enab

Re: [PATCH] arm/kvm: add support for MTE

2024-07-31 Thread Ganapatrao Kulkarni
On 29-07-2024 04:10 pm, Ganapatrao Kulkarni wrote: On 29-07-2024 03:44 pm, Alex Bennée wrote: Ganapatrao Kulkarni writes: Hi Peter, [Apologies for the delayed response] On 16-07-2024 09:15 pm, Peter Maydell wrote: On Tue, 9 Jul 2024 at 07:05, Ganapatrao Kulkarni wrote: Extend the

Re: [PATCH] arm/kvm: add support for MTE

2024-07-29 Thread Ganapatrao Kulkarni
On 29-07-2024 03:44 pm, Alex Bennée wrote: Ganapatrao Kulkarni writes: Hi Peter, [Apologies for the delayed response] On 16-07-2024 09:15 pm, Peter Maydell wrote: On Tue, 9 Jul 2024 at 07:05, Ganapatrao Kulkarni wrote: Extend the 'mte' property for the virt machine to co

Re: [PATCH] arm/kvm: add support for MTE

2024-07-29 Thread Ganapatrao Kulkarni
Hi Peter, [Apologies for the delayed response] On 16-07-2024 09:15 pm, Peter Maydell wrote: On Tue, 9 Jul 2024 at 07:05, Ganapatrao Kulkarni wrote: Extend the 'mte' property for the virt machine to cover KVM as well. For KVM, we don't allocate tag memory, but ins

Re: [PATCH] arm/kvm: add support for MTE

2024-07-15 Thread Ganapatrao Kulkarni
Hi Peter/Richard, On 09-07-2024 11:34 am, Ganapatrao Kulkarni wrote: Extend the 'mte' property for the virt machine to cover KVM as well. For KVM, we don't allocate tag memory, but instead enable the capability. If MTE has been enabled, we need to disable migration, as we do

Re: [PATCH] arm/kvm: add support for MTE

2024-07-11 Thread Ganapatrao Kulkarni
On 10-07-2024 09:12 pm, Cornelia Huck wrote: On Mon, Jul 08 2024, Ganapatrao Kulkarni wrote: Extend the 'mte' property for the virt machine to cover KVM as well. For KVM, we don't allocate tag memory, but instead enable the capability. If MTE has been enabled, we

[PATCH] arm/kvm: add support for MTE

2024-07-09 Thread Ganapatrao Kulkarni
hen tried to use MTE QEMU would segfault accessing the non-existent tag RAM. Signed-off-by: Cornelia Huck Signed-off-by: Ganapatrao Kulkarni --- This patch is boot tested on ARM64 with KVM and on X86 with TCG for mte=on and default case(no mte). hw/ar