[Qemu-devel] [RFC PATCH] firmware: qemu_fw_cfg.c: default to listing user-facing items only

2016-05-03 Thread Gabriel Somlo
g analogous to bit 2 in ACPI's _STA object return value (i.e., "show in UI"). A full listing of all fw_cfg items can still be made available by enabling the 'list_all' module parameter, also introduced by this patch. Suggested-by: Michael S. Tsirkin Signed-off-by:

[Qemu-devel] [PATCH v2] firmware: qemu_fw_cfg.c: hold ACPI global lock during device access

2016-03-08 Thread Gabriel Somlo
Signed-off-by: Gabriel Somlo --- Changes since v1: - no more "#ifdef CONFIG_ACPI"; instead we proceed if acpi_acquire_global_lock() returns either OK or NOT_CONFIGURED, and only throw a warning/error message otherwise. - didn't get any *negative

[Qemu-devel] [RFC PATCH] firmware: qemu_fw_cfg.c: hold ACPI global lock during device access

2016-03-07 Thread Gabriel Somlo
Signed-off-by: Gabriel Somlo --- Turns out, there *is* a way to acquire a global ACPI lock from within a "random" kernel driver after all. Luckily I have a healthy dose of respect for Michael's opinions :) so I kept circling back through existing kernel sources for an example I can u

[Qemu-devel] [PATCH] firmware: fw_cfg register offsets on supported architectures only

2016-02-22 Thread Gabriel Somlo
register offsets in drivers/firmware/qemu_fw_cfg.c at that time. Suggested-by: Michael S. Tsirkin Signed-off-by: Gabriel Somlo --- drivers/firmware/qemu_fw_cfg.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/firmware/qemu_fw_cfg.c b/drivers/firmware/qemu_fw_cfg.c index

Re: [Qemu-devel] [PATCH RFC] e1000: defer packets until BM enabled

2014-12-01 Thread Gabriel Somlo
DeviceState *dev = DEVICE(pci_dev); > @@ -1539,6 +1555,8 @@ static int pci_e1000_init(PCIDevice *pci_dev) > int i; > uint8_t *macaddr; > > +pci_dev->config_write = e1000_write_config; > + > pci_conf = pci_dev->config; > > /* TODO: RST# value should be 0, PCI spec 6.2.4 */ > -- With this, I can confirm everything still works fine on both Mavericks and F21-beta-live. So: Tested-by: Gabriel Somlo Regards, --Gabriel

Re: [Qemu-devel] SMBIOS vs. NUMA (was: Build full type 19 tables)

2014-03-14 Thread Gabriel Somlo
On Fri, Mar 14, 2014 at 06:51:05PM +0100, Igor Mammedov wrote: > > 1. is it safe to assume that E820_RAM (start_addr, size) entries are > > non-overlapping and sorted by increasing start_addr ? > They might overlap, grep for e820_add_entry(). If you interested in > what kernel does with such table

Re: [Qemu-devel] SMBIOS vs. NUMA (was: Build full type 19 tables)

2014-03-14 Thread Gabriel Somlo
On Fri, Mar 14, 2014 at 10:28:30AM +0100, Igor Mammedov wrote: > On Thu, 13 Mar 2014 15:01:16 -0400 > "Gabriel L. Somlo" wrote: > > > On Thu, Mar 13, 2014 at 04:36:12PM +0100, Igor Mammedov wrote: > > > > > > After memory hotplug is in I might add e820 entries after above_4g > > > for present at