Re: [PATCH v2 07/20] hw/net/can: Fix type conflict of GLib function pointers

2025-04-25 Thread Francisco Iglesias
t are not > supported by Emscripten. To avoid these issues, g_list_sort_with_data and > g_slist_sort_with_data should be used instead, as they do not rely on > function pointer casting. > > Signed-off-by: Kohei Tokunaga Acked-by: Francisco Iglesias > --- > hw/net/can/xlnx-ver

Re: [PATCH] MAINTAINERS: Add correct email address for Vikram Garhwal

2024-12-07 Thread Francisco Iglesias
On Wed, Dec 04, 2024 at 10:42:05AM -0800, Vikram Garhwal wrote: > Previously, maintainer role was paused due to inactive email id. Commit id: > c009d715721861984c4987bcc78b7ee183e86d75. > > Signed-off-by: Vikram Garhwal Reviewed-by: Francisco Iglesias > --- > MAINTAINER

Re: [PATCH v4] hw/riscv: Add Microblaze V generic board

2024-11-22 Thread Francisco Iglesias
40c0) > 8 - axi dma (0x41e0) > 9 - axi dma > 10 - gpio (0x4000) > 11 - gpio2 (0x4001) > 12 - gpio3 (0x4002) > > Signed-off-by: Sai Pavan Boddu > Signed-off-by: Michal Simek Reviewed-by: Francisco Iglesias > --- > Changes for V2: > Make ch

Re: [PATCH v2] hw/riscv: Add Microblaze V 32bit virt board

2024-10-29 Thread Francisco Iglesias
t; 8 - axi dma (0x41e0) > 9 - axi dma > 10 - gpio (0x4000) > 11 - gpio2 (0x4001) > 12 - gpio3 (0x4002) > > Signed-off-by: Sai Pavan Boddu > Signed-off-by: Michal Simek Reviewed-by: Francisco Iglesias > --- > Changes for V2: > Make changes to supp

Re: [PATCH 1/1] hw/ssi/xilinx_spips: Fix flash earse assert in dual parallel configuration

2024-09-30 Thread Francisco Iglesias
native english speaking but I think "from the FIFO" sounds better to me! > could cause an assertion failure: > ../util/fifo8.c:67: fifo8_pop: Assertion `fifo->num > 0 > > Signed-off-by: Shiva sagar Myana With above changes: Reviewed-by: Francisco Iglesias

Re: [PATCH v2 1/1] m25p80: Add SFDP table for mt35xu01g flash

2024-09-06 Thread Francisco Iglesias
On Thu, Aug 29, 2024 at 05:31:17PM +0530, Shiva sagar Myana wrote: > Add the SFDP table for the Micron Xccela mt35xu01g flash. > > Signed-off-by: Shiva sagar Myana Reviewed-by: Francisco Iglesias > --- > V1->V2: Change subject and commit message > > hw/block/m25p

[PATCH v1 1/3] MAINTAINERS: Remove Vikram Garhwal as maintainer

2024-09-06 Thread Francisco Iglesias
Vikram's email is bouncing, pause his maintainership until a new email is provided. Signed-off-by: Francisco Iglesias --- MAINTAINERS | 2 -- 1 file changed, 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 0c1bc69828..ad957ca5e8 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1

[PATCH v1 0/3] CAN & Xilinx OSPI maintainer updates

2024-09-06 Thread Francisco Iglesias
amd.com one on the Xilinx Versal OSPI maintaintership section. In the third I volunteer to replace Vikram as maintainer for the CAN bus subsystem. Best regards, Francisco Francisco Iglesias (3): MAINTAINERS: Remove Vikram Garhwal as maintainer MAINTAINERS: Update Xilinx Versal OSPI mai

[PATCH v1 3/3] MAINTAINERS: Add my-self as CAN maintainer

2024-09-06 Thread Francisco Iglesias
Signed-off-by: Francisco Iglesias --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index b03952f43e..a320ce759c 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -2701,6 +2701,7 @@ F: include/hw/rx/ CAN bus subsystem and hardware M: Pavel Pisa +M

[PATCH v1 2/3] MAINTAINERS: Update Xilinx Versal OSPI maintainer's email address

2024-09-06 Thread Francisco Iglesias
Update my xilinx.com email address to my amd.com address. Signed-off-by: Francisco Iglesias --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index ad957ca5e8..b03952f43e 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1055,7 +1055,7

Re: [PATCH v2 7/7] hw/net/can/xlnx-versal-canfd: Fix FIFO issues

2024-09-06 Thread Francisco Iglesias
-off-by: Doug Brown Reviewed-by: Francisco Iglesias Thanks a lot for the fixes and sorry for the delayed review! Best regards, Francisco > --- > hw/net/can/xlnx-versal-canfd.c | 36 +++--- > 1 file changed, 3 insertions(+), 33 deletions(-) > > dif

Re: [PATCH v2 0/7] hw/net/can/xlnx-versal-canfd: Miscellaneous fixes

2024-09-06 Thread Francisco Iglesias
Hi Peter, On Fri, Sep 06, 2024 at 03:36:10PM +0100, Peter Maydell wrote: > On Tue, 27 Aug 2024 at 04:51, Doug Brown wrote: > > > > This series fixes several problems I ran into while trying to simulate > > the AMD/Xilinx Versal CANFD controller in the xlnx-versal-virt machine > > using Xilinx's v

Re: [PATCH v2 6/7] hw/net/can/xlnx-versal-canfd: Simplify DLC conversions

2024-09-04 Thread Francisco Iglesias
with a DLC of 0-8, which was broken previously. > > Signed-off-by: Doug Brown Reviewed-by: Francisco Iglesias > --- > hw/net/can/xlnx-versal-canfd.c | 67 ++ > 1 file changed, 4 insertions(+), 63 deletions(-) > > diff --git a/hw/net/can/xlnx-v

Re: [PATCH 5/5] hw/net/can/xlnx-versal-canfd: Handle RX of short FD frames

2024-08-23 Thread Francisco Iglesias
On Fri, Aug 16, 2024 at 09:35:05AM -0700, Doug Brown wrote: > There was no case for handling received CAN FD frames with a DLC of 0-8. > This was already handled properly with TX. Add similar code for RX. > > Signed-off-by: Doug Brown Reviewed-by: Francisco Iglesias > --- >

Re: [PATCH 4/5] hw/net/can/xlnx-versal-canfd: Fix byte ordering

2024-08-23 Thread Francisco Iglesias
both the TX and RX code to put the data in the correct order. > > Signed-off-by: Doug Brown Reviewed-by: Francisco Iglesias > --- > hw/net/can/xlnx-versal-canfd.c | 10 +- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/hw/net/can/xlnx-vers

Re: [PATCH 3/5] hw/net/can/xlnx-versal-canfd: Translate CAN ID registers

2024-08-23 Thread Francisco Iglesias
_frame for all of its ID registers. Correct this problem for > both RX and TX, including RX filtering. > > Signed-off-by: Doug Brown Reviewed-by: Francisco Iglesias > --- > hw/net/can/xlnx-versal-canfd.c | 53 -- > 1 file changed, 50 insertions

Re: [PATCH for-9.2 6/6] hm/nvram/xlnx-versal-efuse-ctrl: Call register_finalize_block

2024-08-23 Thread Francisco Iglesias
55f225b0bfe1 in object_new qom/object.c:797:12 > #9 0x55f226309e0d in qmp_device_list_properties qom/qom-qmp-cmds.c:144:11 > > Signed-off-by: Peter Maydell Reviewed-by: Francisco Iglesias > --- > include/hw/nvram/xlnx-versal-efuse.h | 1 + > hw/nvram/xlnx-versal-efuse-ct

Re: [PATCH for-9.2 5/6] hw/misc/xlnx-versal-trng: Call register_finalize_block

2024-08-23 Thread Francisco Iglesias
df1 in object_new qom/object.c:797:12 > #9 0x558432427c1d in qmp_device_list_properties qom/qom-qmp-cmds.c:144:11 > > Signed-off-by: Peter Maydell Reviewed-by: Francisco Iglesias > --- > include/hw/misc/xlnx-versal-trng.h | 1 + > hw/misc/xlnx-versal-trng.c | 6 +++--- > 2 files c

Re: [PATCH for-9.2 3/6] hw/nvram/xlnx-bbram: Call register_finalize_block

2024-08-23 Thread Francisco Iglesias
87aa11 in object_new qom/object.c:797:12 > #9 0x56415507883d in qmp_device_list_properties qom/qom-qmp-cmds.c:144:11 > > Signed-off-by: Peter Maydell Reviewed-by: Francisco Iglesias > --- > include/hw/nvram/xlnx-bbram.h | 1 + > hw/nvram/xlnx-bbram.c | 13 ++--- > 2 files cha

Re: [PATCH for-9.2 4/6] hw/nvram/xlnx-zynqmp-efuse: Call register_finalize_block

2024-08-23 Thread Francisco Iglesias
533c01 in object_new qom/object.c:797:12 > #9 0x55f402d31a2d in qmp_device_list_properties qom/qom-qmp-cmds.c:144:11 > > Signed-off-by: Peter Maydell Reviewed-by: Francisco Iglesias > --- > include/hw/nvram/xlnx-zynqmp-efuse.h | 1 + > hw/nvram/xlnx-zynqmp-efuse.c |

Re: [PATCH for-9.2 6/6] hm/nvram/xlnx-versal-efuse-ctrl: Call register_finalize_block

2024-08-23 Thread Francisco Iglesias
55f225b0bfe1 in object_new qom/object.c:797:12 > #9 0x55f226309e0d in qmp_device_list_properties qom/qom-qmp-cmds.c:144:11 > > Signed-off-by: Peter Maydell Reviewed-by: Francisco Iglesias > --- > include/hw/nvram/xlnx-versal-efuse.h | 1 + > hw/nvram/xlnx-versal-efuse-ct

Re: [PATCH for-9.2 1/6] hw/misc/xlnx-versal-cfu: destroy fifo in finalize

2024-08-23 Thread Francisco Iglesias
gt; #9 0x55ec8d65c81d in qmp_device_list_properties qom/qom-qmp-cmds.c:144:11 > > Signed-off-by: Peter Maydell Reviewed-by: Francisco Iglesias > --- > hw/misc/xlnx-versal-cfu.c | 8 > 1 file changed, 8 insertions(+) > > diff --git a/hw/misc/xlnx-versal-cfu.c

Re: [PATCH 1/5] hw/net/can/xlnx-versal-canfd: Fix interrupt level

2024-08-21 Thread Francisco Iglesias
; bit 0 when applying it, resulting in the IRQ never being delivered. > > Signed-off-by: Doug Brown Reviewed-by: Francisco Iglesias > --- > hw/net/can/xlnx-versal-canfd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/hw/net/can/xlnx-versal-canfd.c

Re: [PATCH 2/5] hw/net/can/xlnx-versal-canfd: Fix CAN FD flag check

2024-08-21 Thread Francisco Iglesias
Brown Reviewed-by: Francisco Iglesias > --- > hw/net/can/xlnx-versal-canfd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/hw/net/can/xlnx-versal-canfd.c b/hw/net/can/xlnx-versal-canfd.c > index ad0c4da3c8..8968672b84 100644 > --- a/hw/net/can/xl

Re: [PATCH v3 2/3] hw/arm/xilinx_zynq: Add boot-mode property

2024-06-21 Thread Francisco Iglesias
mc = MACHINE_CLASS(oc); > +ObjectProperty *prop; > mc->desc = "Xilinx Zynq Platform Baseboard for Cortex-A9"; > mc->init = zynq_init; > mc->max_cpus = ZYNQ_MAX_CPUS; > @@ -379,6 +404,12 @@ static void zynq_machine_class_init(ObjectCla

Re: [PATCH v3 3/3] docs/system/arm: Add a doc for zynq board

2024-06-21 Thread Francisco Iglesias
On Thu, Jun 20, 2024 at 04:11:39PM +0530, Sai Pavan Boddu wrote: > Added the supported device list and an example command. > > Signed-off-by: Sai Pavan Boddu Reviewed-by: Francisco Iglesias > Reviewed-by: Edgar E. Iglesias > --- > MAINTAINERS | 1 + >

Re: [PATCH v3 1/3] hw/misc/zynq_slcr: Add boot-mode property

2024-06-21 Thread Francisco Iglesias
On Thu, Jun 20, 2024 at 04:11:37PM +0530, Sai Pavan Boddu wrote: > boot-mode property sets user values into BOOT_MODE register, on hardware > these are derived from board switches. > > Signed-off-by: Sai Pavan Boddu Reviewed-by: Francisco Iglesias > Reviewed-by: Edgar E. Iglesi

Re: [QEMU][PATCH 1/1] hw/net/can: Fix sorting of the tx queue

2024-05-30 Thread Francisco Iglesias
the tx queue" Reviewed-by: Francisco Iglesias BR, F > --- > hw/net/can/xlnx-versal-canfd.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/hw/net/can/xlnx-versal-canfd.c b/hw/net/can/xlnx-versal-canfd.c > index 47a14cfe63..5f083c21e9 100644 >

Re: [PATCH 16/21] hw/net/can/versal: Prefer object_initialize_child over object_initialize

2024-02-23 Thread Francisco Iglesias
On 2024-02-16 12:03, Philippe Mathieu-Daudé wrote: When the QOM parent is available, prefer object_initialize_child() over object_initialize(), since it create the parent relationship. Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Francisco Iglesias --- hw/net/can/xlnx-versal

Re: [PATCH 1/2] block: m25p80: Add support of mt35xu02gbba

2023-12-05 Thread Francisco Iglesias
On [2023 Dec 05] Tue 15:22:25, Sai Pavan Boddu wrote: > Add Micro 2Gb OSPI flash part with sfdp data. > > Signed-off-by: Sai Pavan Boddu Reviewed-by: Francisco Iglesias > --- > hw/block/m25p80_sfdp.h | 1 + > hw/block/m25p80.c | 3 +++ > hw/blo

Re: [PATCH 2/2] arm: xlnx-versal-virt: Add machine property ospi-flash

2023-12-05 Thread Francisco Iglesias
On [2023 Dec 05] Tue 15:22:26, Sai Pavan Boddu wrote: > This property allows users to change flash model on command line as > below. > >ex: "-M xlnx-versal-virt,ospi-flash=mt35xu02gbba" > > Signed-off-by: Sai Pavan Boddu Reviewed-by: Francisco Iglesias > -

Re: [PATCH 1/1] xlnx-versal-ospi: disable reentrancy detection for iomem_dac

2023-12-05 Thread Francisco Iglesias
> the memory region. > > Signed-off-by: Sai Pavan Boddu Reviewed-by: Francisco Iglesias Tested-by: Francisco Iglesias > --- > hw/ssi/xlnx-versal-ospi.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/hw/ssi/xlnx-versal-ospi.c b/hw/ssi/xlnx-versal-ospi.c >

Re: [PATCH v1 3/3] hw/dma/xlnx_csu_dma: don't throw guest errors when stopping the SRC DMA

2023-11-24 Thread Francisco Iglesias
SIZE register, so remove the LOG_GUEST_ERROR in that case. While at it remove the comment marking the SIZE register as write-only. See: https://docs.xilinx.com/r/en-US/ug1087-zynq-ultrascale-registers/CSUDMA_SRC_SIZE-CSUDMA-Register Signed-off-by: Frederic Konrad Reviewed-by: Francisco Iglesias

Re: [PATCH v1 2/3] fix some url for amd / xilinx models

2023-11-24 Thread Francisco Iglesias
On 2023-11-24 15:35, Frederic Konrad wrote: It seems that the url changed a bit, and it triggers an error. Fix the URLs so the documentation can be reached again. Signed-off-by: Frederic Konrad Reviewed-by: Francisco Iglesias --- hw/dma/xlnx_csu_dma.c | 2

Re: [PATCH v1 1/3] hw/ssi/xilinx_spips: fix an out of bound access

2023-11-24 Thread Francisco Iglesias
bytes for zynqmp-qspips) thus it is possible to write out of s->regs[addr] in xilinx_spips_write for spips and qspips. This fixes that wrong behavior. Reviewed-by: Luc Michel Signed-off-by: Frederic Konrad Reviewed-by: Francisco Iglesias --- hw/ssi/xilinx_spips.c

Re: [PATCH-for-8.2 v2 2/2] hw/net/can/xlnx-zynqmp: Avoid underflow while popping RX FIFO

2023-11-22 Thread Francisco Iglesias
tps://gitlab.com/qemu-project/qemu/-/issues/1427 > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Francisco Iglesias > --- > hw/net/can/xlnx-zynqmp-can.c | 17 + > 1 file changed, 9 insertions(+), 8 deletions(-) > > diff --git a/hw/net/can/xlnx-zynqmp-can.c b

Re: [PATCH-for-8.2 v2 1/2] hw/net/can/xlnx-zynqmp: Avoid underflow while popping TX FIFOs

2023-11-22 Thread Francisco Iglesias
g Liu > Fixes: 98e5d7a2b7 ("hw/net/can: Introduce Xilinx ZynqMP CAN controller") > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/1425 > Signed-off-by: Philippe Mathieu-Daudé > Francisco Iglesias -above line +below line Reviewed-by: Francisco Iglesias > --- &

Re: [PATCH-for-8.2] hw/net/can/xlnx-zynqmp: Avoid underflow while popping TX FIFO

2023-11-16 Thread Francisco Iglesias
Hi Philippe, On 2023-11-16 16:44, Philippe Mathieu-Daudé wrote: Hi Francisco, On 16/11/23 15:17, Francisco Iglesias wrote: Hi Philippe, good catch! Well this was fuzzed by Qiang Liu. On 2023-11-15 16:17, Philippe Mathieu-Daudé wrote: Per https://docs.xilinx.com/r/en-US/ug1085-zynq

Re: [PATCH-for-8.2] hw/net/can/xlnx-zynqmp: Avoid underflow while popping TX FIFO

2023-11-16 Thread Francisco Iglesias
bove minor modification: Reviewed-by: Francisco Iglesias Best regards, Francisco +bool is_txhpb = fifo == &s->txhpb_fifo; + +assert(used > 0); +used %= CAN_FRAME_SIZE; + +/* + * Frame Message Format + * + * Each frame includes four words (16 bytes). Software mus

Re: [PATCH 2/2] hw: Replace anti-social QOM type names (again)

2023-11-13 Thread Francisco Iglesias
x-FOO", like commit e178113ff64 did. Reported-by: Thomas Huth Signed-off-by: Markus Armbruster Reviewed-by: Francisco Iglesias --- docs/system/arm/xlnx-versal-virt.rst | 2 +- include/hw/misc/xlnx-versal-cframe-reg.h | 2 +- include/hw/misc/xlnx-versal-cfu.h| 6 +++--- incl

Re: [PATCH 1/2] docs/system/arm: Fix for rename of type "xlnx.bbram-ctrl"

2023-11-13 Thread Francisco Iglesias
On 2023-11-13 14:43, Markus Armbruster wrote: Fixes: b65b4b7ae3c8 (xlnx-bbram: hw/nvram: Use dot in device type name) Signed-off-by: Markus Armbruster Reviewed-by: Francisco Iglesias --- docs/system/arm/xlnx-versal-virt.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff

Re: [PATCH] xlnx-bbram: hw/nvram: Use dot in device type name

2023-10-04 Thread Francisco Iglesias
On [2023 Oct 02] Mon 22:21:39, Tong Ho wrote: > This replaces the comma (,) to dot (.) in the device type name > so the name can be used with the 'driver=' command line option. > > Signed-off-by: Tong Ho Reviewed-by: Francisco Iglesias > --- > include/hw/nvram/x

Re: [PATCH] xlnx-zynqmp-efuse: hw/nvram: Remove deprecated device reset

2023-10-04 Thread Francisco Iglesias
On [2023 Oct 03] Tue 22:57:13, Tong Ho wrote: > This change implements the ResettableClass interface for the device. > > Signed-off-by: Tong Ho Reviewed-by: Francisco Iglesias > --- > hw/nvram/xlnx-zynqmp-efuse.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(

Re: [PATCH] xlnx-versal-efuse: hw/nvram: Remove deprecated device reset

2023-10-04 Thread Francisco Iglesias
On [2023 Oct 03] Tue 22:53:39, Tong Ho wrote: > This change implements the ResettableClass interface for the device. > > Signed-off-by: Tong Ho Reviewed-by: Francisco Iglesias > --- > hw/nvram/xlnx-versal-efuse-ctrl.c | 8 +--- > 1 file changed, 5 insertions(+), 3 dele

Re: [PATCH v3 2/3] hw/arm: xlnx-versal-virt: Add AMD/Xilinx TRNG device

2023-10-04 Thread Francisco Iglesias
s not intended for use cases when > cryptograpically strong TRNG is needed. > > Signed-off-by: Tong Ho Reviewed-by: Francisco Iglesias > --- > hw/arm/Kconfig | 1 + > hw/arm/xlnx-versal.c | 16 > include/hw/arm/xlnx-versal.h | 5

Re: [PATCH v3 3/3] tests/qtest: Introduce tests for AMD/Xilinx Versal TRNG device

2023-10-04 Thread Francisco Iglesias
On [2023 Oct 04] Wed 07:27:46, Tong Ho wrote: > Signed-off-by: Tong Ho Reviewed-by: Francisco Iglesias > --- > tests/qtest/meson.build | 2 +- > tests/qtest/xlnx-versal-trng-test.c | 490 > 2 files changed, 491 insertions(+), 1 deleti

Re: [PATCH v2 3/3] tests/qtest: Introduce tests for AMD/Xilinx Versal TRNG device

2023-09-26 Thread Francisco Iglesias
trng_generate(true); > +n = trng_collect(prng, cnt); > +g_assert_cmpuint(n, ==, cnt); > + > +/* #2: zero string should match personalization disabled */ > +trng_load(R_TRNG_PER_STRNG_0, NULL); > +trng_reseed(prng_seed); > + > +trng_generate(tr

Re: [PATCH] hw/intc/arm_gicv3: Simplify gicv3_class_name() logic

2023-09-06 Thread Francisco Iglesias
On [2023 Sep 05] Tue 16:56:51, Philippe Mathieu-Daudé wrote: > Simplify gicv3_class_name() logic. No functional change intended. > > Signed-off-by: Philippe Mathieu-Daudé Reviewed-by: Francisco Iglesias > --- > hw/intc/arm_gicv3_common.c | 9 - > 1 file changed,

[PATCH v5 7/8] hw/arm/xlnx-versal: Connect the CFU_APB, CFU_FDRO and CFU_SFR

2023-08-31 Thread Francisco Iglesias
Connect the Configuration Frame Unit (CFU_APB, CFU_FDRO and CFU_SFR) to the Versal machine. Signed-off-by: Francisco Iglesias Acked-by: Edgar E. Iglesias Reviewed-by: Peter Maydell --- hw/arm/xlnx-versal.c | 42 include/hw/arm/xlnx-versal.h | 16

[PATCH v5 4/8] hw/misc/xlnx-versal-cfu: Introduce a model of Xilinx Versal's CFU_SFR

2023-08-31 Thread Francisco Iglesias
Introduce a model of Xilinx Versal's Configuration Frame Unit's Single Frame Read port (CFU_SFR). Signed-off-by: Francisco Iglesias Reviewed-by: Peter Maydell --- hw/misc/xlnx-versal-cfu.c | 87 +++ include/hw/misc/xlnx-versal-cfu.h | 15 +

[PATCH v5 2/8] hw/misc: Introduce a model of Xilinx Versal's CFU_APB

2023-08-31 Thread Francisco Iglesias
Introduce a model of the software programming interface (CFU_APB) of Xilinx Versal's Configuration Frame Unit. Signed-off-by: Francisco Iglesias Reviewed-by: Peter Maydell --- MAINTAINERS | 2 + hw/misc/meson.build | 1 + hw/misc/xlnx-versal-

[PATCH v5 6/8] hw/misc: Introduce a model of Xilinx Versal's CFRAME_BCAST_REG

2023-08-31 Thread Francisco Iglesias
Introduce a model of Xilinx Versal's Configuration Frame broadcast controller (CFRAME_BCAST_REG). Signed-off-by: Francisco Iglesias Reviewed-by: Peter Maydell --- hw/misc/xlnx-versal-cframe-reg.c | 161 +++ include/hw/misc/xlnx-versal-cframe-reg.h | 17 +++ 2

[PATCH v5 5/8] hw/misc: Introduce a model of Xilinx Versal's CFRAME_REG

2023-08-31 Thread Francisco Iglesias
Introduce a model of Xilinx Versal's Configuration Frame controller (CFRAME_REG). Signed-off-by: Francisco Iglesias --- MAINTAINERS | 2 + hw/misc/meson.build | 1 + hw/misc/xlnx-versal-cframe-reg.c

[PATCH v5 8/8] hw/arm/versal: Connect the CFRAME_REG and CFRAME_BCAST_REG

2023-08-31 Thread Francisco Iglesias
Connect the Configuration Frame controller (CFRAME_REG) and the Configuration Frame broadcast controller (CFRAME_BCAST_REG) to the Versal machine. Signed-off-by: Francisco Iglesias Reviewed-by: Peter Maydell --- hw/arm/xlnx-versal.c | 113 ++- include/hw

[PATCH v5 3/8] hw/misc/xlnx-versal-cfu: Introduce a model of Xilinx Versal CFU_FDRO

2023-08-31 Thread Francisco Iglesias
Introduce a model of Xilinx Versal's Configuration Frame Unit's data out port (CFU_FDRO). Signed-off-by: Francisco Iglesias Reviewed-by: Peter Maydell --- hw/misc/xlnx-versal-cfu.c | 96 +++ include/hw/misc/xlnx-versal-cfu.h | 12 2 files ch

[PATCH v5 1/8] hw/misc: Introduce the Xilinx CFI interface

2023-08-31 Thread Francisco Iglesias
emulating bitstream programming and readback). Signed-off-by: Francisco Iglesias Reviewed-by: Sai Pavan Boddu Acked-by: Edgar E. Iglesias --- MAINTAINERS | 6 hw/misc/meson.build | 1 + hw/misc/xlnx-cfi-if.c | 34 include/hw/misc/xlnx

[PATCH v5 0/8] Xilinx Versal CFI support

2023-08-31 Thread Francisco Iglesias
with connecting the models to Xilinx Versal machine. Best regards, Francisco Iglesias References: [1] https://docs.xilinx.com/r/en-US/am011-versal-acap-trm/PSM-Local-Registers Changelog: v4->v5: * Identical to v4 (resend of v4 due to an smtp problem) v3->v4: [PATCH 5] * Swap to pop o

[PATCH v4 6/8] hw/misc: Introduce a model of Xilinx Versal's CFRAME_BCAST_REG

2023-08-31 Thread Francisco Iglesias
Introduce a model of Xilinx Versal's Configuration Frame broadcast controller (CFRAME_BCAST_REG). Signed-off-by: Francisco Iglesias Reviewed-by: Peter Maydell --- hw/misc/xlnx-versal-cframe-reg.c | 161 +++ include/hw/misc/xlnx-versal-cframe-reg.h | 17 +++ 2

[PATCH v4 8/8] hw/arm/versal: Connect the CFRAME_REG and CFRAME_BCAST_REG

2023-08-31 Thread Francisco Iglesias
Connect the Configuration Frame controller (CFRAME_REG) and the Configuration Frame broadcast controller (CFRAME_BCAST_REG) to the Versal machine. Signed-off-by: Francisco Iglesias Reviewed-by: Peter Maydell --- hw/arm/xlnx-versal.c | 113 ++- include/hw

[PATCH v4 5/8] hw/misc: Introduce a model of Xilinx Versal's CFRAME_REG

2023-08-31 Thread Francisco Iglesias
Introduce a model of Xilinx Versal's Configuration Frame controller (CFRAME_REG). Signed-off-by: Francisco Iglesias --- MAINTAINERS | 2 + hw/misc/meson.build | 1 + hw/misc/xlnx-versal-cframe-reg.c

[PATCH v4 7/8] hw/arm/xlnx-versal: Connect the CFU_APB, CFU_FDRO and CFU_SFR

2023-08-31 Thread Francisco Iglesias
Connect the Configuration Frame Unit (CFU_APB, CFU_FDRO and CFU_SFR) to the Versal machine. Signed-off-by: Francisco Iglesias Acked-by: Edgar E. Iglesias Reviewed-by: Peter Maydell --- hw/arm/xlnx-versal.c | 42 include/hw/arm/xlnx-versal.h | 16

[PATCH v4 1/8] hw/misc: Introduce the Xilinx CFI interface

2023-08-31 Thread Francisco Iglesias
emulating bitstream programming and readback). Signed-off-by: Francisco Iglesias Reviewed-by: Sai Pavan Boddu Acked-by: Edgar E. Iglesias --- MAINTAINERS | 6 hw/misc/meson.build | 1 + hw/misc/xlnx-cfi-if.c | 34 include/hw/misc/xlnx

[PATCH v4 2/8] hw/misc: Introduce a model of Xilinx Versal's CFU_APB

2023-08-31 Thread Francisco Iglesias
Introduce a model of the software programming interface (CFU_APB) of Xilinx Versal's Configuration Frame Unit. Signed-off-by: Francisco Iglesias Reviewed-by: Peter Maydell --- MAINTAINERS | 2 + hw/misc/meson.build | 1 + hw/misc/xlnx-versal-

[PATCH v4 3/8] hw/misc/xlnx-versal-cfu: Introduce a model of Xilinx Versal CFU_FDRO

2023-08-31 Thread Francisco Iglesias
Introduce a model of Xilinx Versal's Configuration Frame Unit's data out port (CFU_FDRO). Signed-off-by: Francisco Iglesias Reviewed-by: Peter Maydell --- hw/misc/xlnx-versal-cfu.c | 96 +++ include/hw/misc/xlnx-versal-cfu.h | 12 2 files ch

[PATCH v4 4/8] hw/misc/xlnx-versal-cfu: Introduce a model of Xilinx Versal's CFU_SFR

2023-08-31 Thread Francisco Iglesias
Introduce a model of Xilinx Versal's Configuration Frame Unit's Single Frame Read port (CFU_SFR). Signed-off-by: Francisco Iglesias Reviewed-by: Peter Maydell --- hw/misc/xlnx-versal-cfu.c | 87 +++ include/hw/misc/xlnx-versal-cfu.h | 15 +

[PATCH v4 0/8] Xilinx Versal CFI support

2023-08-31 Thread Francisco Iglesias
with connecting the models to Xilinx Versal machine. Best regards, Francisco Iglesias References: [1] https://docs.xilinx.com/r/en-US/am011-versal-acap-trm/PSM-Local-Registers Changelog: v3->v4: [PATCH 5] * Swap to pop out the fifo32 data instead of using memcpy * Use g_tree_nnodes inst

Re: [PATCH v3 5/8] hw/misc: Introduce a model of Xilinx Versal's CFRAME_REG

2023-08-31 Thread Francisco Iglesias
Hi Peter, On 2023-08-29 18:44, Peter Maydell wrote: On Thu, 24 Aug 2023 at 19:35, Francisco Iglesias wrote: Introduce a model of Xilinx Versal's Configuration Frame controller (CFRAME_REG). Signed-off-by: Francisco Iglesias +static void cfrm_fdri_post_write(RegisterInfo *reg, uin

Re: [PATCH 3/4] net/dump: Avoid variable length array

2023-08-25 Thread Francisco Iglesias
is a defensive > measure against security bugs where an on-stack dynamic allocation > isn't correctly size-checked (e.g. CVE-2021-3527). > > Signed-off-by: Peter Maydell Reviewed-by: Francisco Iglesias > --- > net/dump.c | 2 +- > 1 file changed, 1 insertion(+), 1 delet

Re: [PATCH 4/4] net/tap: Avoid variable-length array

2023-08-25 Thread Francisco Iglesias
t; measure against security bugs where an on-stack dynamic allocation > isn't correctly size-checked (e.g. CVE-2021-3527). > > Signed-off-by: Peter Maydell Reviewed-by: Francisco Iglesias > --- > net/tap.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) >

Re: [PATCH 2/4] hw/net/rocker: Avoid variable length array

2023-08-25 Thread Francisco Iglesias
is a defensive > measure against security bugs where an on-stack dynamic allocation > isn't correctly size-checked (e.g. CVE-2021-3527). > > Signed-off-by: Peter Maydell Reviewed-by: Francisco Iglesias > --- > hw/net/rocker/rocker_of_dpa.c | 2 +- > 1 file changed, 1 inse

[PATCH v3 4/8] hw/misc/xlnx-versal-cfu: Introduce a model of Xilinx Versal's CFU_SFR

2023-08-24 Thread Francisco Iglesias
Introduce a model of Xilinx Versal's Configuration Frame Unit's Single Frame Read port (CFU_SFR). Signed-off-by: Francisco Iglesias Reviewed-by: Peter Maydell --- hw/misc/xlnx-versal-cfu.c | 87 +++ include/hw/misc/xlnx-versal-cfu.h | 15 +

[PATCH v3 7/8] hw/arm/xlnx-versal: Connect the CFU_APB, CFU_FDRO and CFU_SFR

2023-08-24 Thread Francisco Iglesias
Connect the Configuration Frame Unit (CFU_APB, CFU_FDRO and CFU_SFR) to the Versal machine. Signed-off-by: Francisco Iglesias Acked-by: Edgar E. Iglesias Reviewed-by: Peter Maydell --- hw/arm/xlnx-versal.c | 42 include/hw/arm/xlnx-versal.h | 16

[PATCH v3 1/8] hw/misc: Introduce the Xilinx CFI interface

2023-08-24 Thread Francisco Iglesias
emulating bitstream programming and readback). Signed-off-by: Francisco Iglesias Reviewed-by: Sai Pavan Boddu Acked-by: Edgar E. Iglesias --- MAINTAINERS | 6 hw/misc/meson.build | 1 + hw/misc/xlnx-cfi-if.c | 34 include/hw/misc/xlnx

[PATCH v3 5/8] hw/misc: Introduce a model of Xilinx Versal's CFRAME_REG

2023-08-24 Thread Francisco Iglesias
Introduce a model of Xilinx Versal's Configuration Frame controller (CFRAME_REG). Signed-off-by: Francisco Iglesias --- MAINTAINERS | 2 + hw/misc/meson.build | 1 + hw/misc/xlnx-versal-cframe-reg.c

Re: [PATCH v2 5/8] hw/misc: Introduce a model of Xilinx Versal's CFRAME_REG

2023-08-24 Thread Francisco Iglesias
Hi Peter, On 2023-08-21 15:34, Peter Maydell wrote: On Thu, 10 Aug 2023 at 20:16, Francisco Iglesias wrote: Introduce a model of Xilinx Versal's Configuration Frame controller (CFRAME_REG). Signed-off-by: Francisco Iglesias --- MAINTAINERS | 2 + hw

[PATCH v3 6/8] hw/misc: Introduce a model of Xilinx Versal's CFRAME_BCAST_REG

2023-08-24 Thread Francisco Iglesias
Introduce a model of Xilinx Versal's Configuration Frame broadcast controller (CFRAME_BCAST_REG). Signed-off-by: Francisco Iglesias Reviewed-by: Peter Maydell --- hw/misc/xlnx-versal-cframe-reg.c | 161 +++ include/hw/misc/xlnx-versal-cframe-reg.h | 17 +++ 2

[PATCH v3 0/8] Xilinx Versal CFI support

2023-08-24 Thread Francisco Iglesias
with connecting the models to Xilinx Versal machine. Best regards, Francisco Iglesias References: [1] https://docs.xilinx.com/r/en-US/am011-versal-acap-trm/PSM-Local-Registers Changelog: v2->v3: [PATCH 5] * Swap to store the CFrames in a GTree instead of GArray * Rename new_f to new_f_d

[PATCH v3 2/8] hw/misc: Introduce a model of Xilinx Versal's CFU_APB

2023-08-24 Thread Francisco Iglesias
Introduce a model of the software programming interface (CFU_APB) of Xilinx Versal's Configuration Frame Unit. Signed-off-by: Francisco Iglesias Reviewed-by: Peter Maydell --- MAINTAINERS | 2 + hw/misc/meson.build | 1 + hw/misc/xlnx-versal-

[PATCH v3 3/8] hw/misc/xlnx-versal-cfu: Introduce a model of Xilinx Versal CFU_FDRO

2023-08-24 Thread Francisco Iglesias
Introduce a model of Xilinx Versal's Configuration Frame Unit's data out port (CFU_FDRO). Signed-off-by: Francisco Iglesias Reviewed-by: Peter Maydell --- hw/misc/xlnx-versal-cfu.c | 96 +++ include/hw/misc/xlnx-versal-cfu.h | 12 2 files ch

[PATCH v3 8/8] hw/arm/versal: Connect the CFRAME_REG and CFRAME_BCAST_REG

2023-08-24 Thread Francisco Iglesias
Connect the Configuration Frame controller (CFRAME_REG) and the Configuration Frame broadcast controller (CFRAME_BCAST_REG) to the Versal machine. Signed-off-by: Francisco Iglesias Reviewed-by: Peter Maydell --- hw/arm/xlnx-versal.c | 113 ++- include/hw

Re: [PATCH 2/2] audio/jackaudio: Avoid dynamic stack allocation in qjack_process()

2023-08-21 Thread Francisco Iglesias
s very few VLAs, and if we can get rid of them all we > can make the compiler error on new additions. This is a defensive > measure against security bugs where an on-stack dynamic allocation > isn't correctly size-checked (e.g. CVE-2021-3527). > > Signed-off-by: Peter Maydel

Re: [PATCH 3/3] ui/vnc-enc-tight: Avoid dynamic stack allocation

2023-08-21 Thread Francisco Iglesias
w additions. This is a defensive > measure against security bugs where an on-stack dynamic allocation > isn't correctly size-checked (e.g. CVE-2021-3527). > > Signed-off-by: Philippe Mathieu-Daudé > [PMM: expanded commit message] > Signed-off-by: Peter Maydell Reviewed-

Re: [PATCH 1/2] audio/jackaudio: Avoid dynamic stack allocation in qjack_client_init

2023-08-21 Thread Francisco Iglesias
27;t correctly size-checked (e.g. CVE-2021-3527). > > Signed-off-by: Peter Maydell Reviewed-by: Francisco Iglesias > --- > audio/jackaudio.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/audio/jackaudio.c b/audio/jackaudio.c > index 5bd

Re: [PATCH] block/vpc: Avoid dynamic stack allocation

2023-08-18 Thread Francisco Iglesias
size-checked (e.g. CVE-2021-3527). > > Signed-off-by: Philippe Mathieu-Daudé > [PMM: expanded commit message] > Signed-off-by: Peter Maydell Reviewed-by: Francisco Iglesias > --- > block/vpc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > dif

Re: [PATCH v1 3/8] hw/misc/xlnx-versal-cfu: Introduce a model of Xilinx Versal CFU_FDRO

2023-08-10 Thread Francisco Iglesias
Hi Peter, On 2023-08-03 15:48, Peter Maydell wrote: On Mon, 10 Jul 2023 at 15:03, Francisco Iglesias wrote: Introduce a model of Xilinx Versal's Configuration Frame Unit's data out port (CFU_FDRO). Signed-off-by: Francisco Iglesias --- hw/misc/xlnx-versal-cfu.c

[PATCH v2 5/8] hw/misc: Introduce a model of Xilinx Versal's CFRAME_REG

2023-08-10 Thread Francisco Iglesias
Introduce a model of Xilinx Versal's Configuration Frame controller (CFRAME_REG). Signed-off-by: Francisco Iglesias --- MAINTAINERS | 2 + hw/misc/meson.build | 1 + hw/misc/xlnx-versal-cframe-reg.c

[PATCH v2 3/8] hw/misc/xlnx-versal-cfu: Introduce a model of Xilinx Versal CFU_FDRO

2023-08-10 Thread Francisco Iglesias
Introduce a model of Xilinx Versal's Configuration Frame Unit's data out port (CFU_FDRO). Signed-off-by: Francisco Iglesias --- hw/misc/xlnx-versal-cfu.c | 96 +++ include/hw/misc/xlnx-versal-cfu.h | 12 2 files changed, 108 insertions(+) di

[PATCH v2 8/8] hw/arm/versal: Connect the CFRAME_REG and CFRAME_BCAST_REG

2023-08-10 Thread Francisco Iglesias
Connect the Configuration Frame controller (CFRAME_REG) and the Configuration Frame broadcast controller (CFRAME_BCAST_REG) to the Versal machine. Signed-off-by: Francisco Iglesias --- hw/arm/xlnx-versal.c | 113 ++- include/hw/arm/xlnx-versal.h | 69

[PATCH v2 7/8] hw/arm/xlnx-versal: Connect the CFU_APB, CFU_FDRO and CFU_SFR

2023-08-10 Thread Francisco Iglesias
Connect the Configuration Frame Unit (CFU_APB, CFU_FDRO and CFU_SFR) to the Versal machine. Signed-off-by: Francisco Iglesias Acked-by: Edgar E. Iglesias Reviewed-by: Peter Maydell --- hw/arm/xlnx-versal.c | 42 include/hw/arm/xlnx-versal.h | 16

[PATCH v2 6/8] hw/misc: Introduce a model of Xilinx Versal's CFRAME_BCAST_REG

2023-08-10 Thread Francisco Iglesias
Introduce a model of Xilinx Versal's Configuration Frame broadcast controller (CFRAME_BCAST_REG). Signed-off-by: Francisco Iglesias --- hw/misc/xlnx-versal-cframe-reg.c | 161 +++ include/hw/misc/xlnx-versal-cframe-reg.h | 17 +++ 2 files changed, 178 inser

[PATCH v2 2/8] hw/misc: Introduce a model of Xilinx Versal's CFU_APB

2023-08-10 Thread Francisco Iglesias
Introduce a model of the software programming interface (CFU_APB) of Xilinx Versal's Configuration Frame Unit. Signed-off-by: Francisco Iglesias --- MAINTAINERS | 2 + hw/misc/meson.build | 1 + hw/misc/xlnx-versal-cfu.c

[PATCH v2 4/8] hw/misc/xlnx-versal-cfu: Introduce a model of Xilinx Versal's CFU_SFR

2023-08-10 Thread Francisco Iglesias
Introduce a model of Xilinx Versal's Configuration Frame Unit's Single Frame Read port (CFU_SFR). Signed-off-by: Francisco Iglesias --- hw/misc/xlnx-versal-cfu.c | 87 +++ include/hw/misc/xlnx-versal-cfu.h | 15 ++ 2 files changed, 102 insertion

[PATCH v2 1/8] hw/misc: Introduce the Xilinx CFI interface

2023-08-10 Thread Francisco Iglesias
emulating bitstream programming and readback). Signed-off-by: Francisco Iglesias Reviewed-by: Sai Pavan Boddu Acked-by: Edgar E. Iglesias --- MAINTAINERS | 6 hw/misc/meson.build | 1 + hw/misc/xlnx-cfi-if.c | 34 include/hw/misc/xlnx

[PATCH v2 0/8] Xilinx Versal CFI support

2023-08-10 Thread Francisco Iglesias
with connecting the models to Xilinx Versal machine. Best regards, Francisco Iglesias References: [1] https://docs.xilinx.com/r/en-US/am011-versal-acap-trm/PSM-Local-Registers Changelog: v1->v2: [PATCH 2] * Use KiB when defining KEYHOLE_STREAM_4K/KEYHOLE_STREAM_256K * Updated to be able

Re: [PATCH v2] hw/arm/xlnx: Connect secondary CGEM IRQs

2023-07-10 Thread Francisco Iglesias
+PMM (I think this one might have fallen throught the cracks) Best regards, Francisco Iglesias On [2023 Jun 18] Sun 00:50:47, Philippe Mathieu-Daudé wrote: > On 16/6/23 16:38, Kinsey Moore wrote: > > The Cadence GEM peripherals as configured for Zynq MPSoC and Versal > > pla

[PATCH v1 0/8] Xilinx Versal CFI support

2023-07-10 Thread Francisco Iglesias
with connecting the models to Xilinx Versal machine. Best regards, Francisco Iglesias References: [1] https://docs.xilinx.com/r/en-US/am011-versal-acap-trm/PSM-Local-Registers Francisco Iglesias (8): hw/misc: Introduce the Xilinx CFI interface hw/misc: Introduce a model of Xilinx Versal&#

[PATCH v1 3/8] hw/misc/xlnx-versal-cfu: Introduce a model of Xilinx Versal CFU_FDRO

2023-07-10 Thread Francisco Iglesias
Introduce a model of Xilinx Versal's Configuration Frame Unit's data out port (CFU_FDRO). Signed-off-by: Francisco Iglesias --- hw/misc/xlnx-versal-cfu.c | 105 ++ include/hw/misc/xlnx-versal-cfu.h | 11 2 files changed, 116 insertions(+) di

[PATCH v1 7/8] hw/arm/xlnx-versal: Connect the CFU_APB, CFU_FDRO and CFU_SFR

2023-07-10 Thread Francisco Iglesias
Connect the Configuration Frame Unit (CFU_APB, CFU_FDRO and CFU_SFR) to the Versal machine. Signed-off-by: Francisco Iglesias --- hw/arm/xlnx-versal.c | 42 include/hw/arm/xlnx-versal.h | 16 ++ 2 files changed, 58 insertions(+) diff

[PATCH v1 5/8] hw/misc: Introduce a model of Xilinx Versal's CFRAME_REG

2023-07-10 Thread Francisco Iglesias
Introduce a model of Xilinx Versal's Configuration Frame controller (CFRAME_REG). Signed-off-by: Francisco Iglesias --- MAINTAINERS | 2 + hw/misc/meson.build | 1 + hw/misc/xlnx-versal-cframe-reg.c

[PATCH v1 1/8] hw/misc: Introduce the Xilinx CFI interface

2023-07-10 Thread Francisco Iglesias
emulating bitstream programming and readback). Signed-off-by: Francisco Iglesias --- MAINTAINERS | 6 hw/misc/meson.build | 1 + hw/misc/xlnx-cfi-if.c | 34 include/hw/misc/xlnx-cfi-if.h | 59 +++ 4 files

  1   2   3   4   5   6   >