Re: [Qemu-devel] [PATCH 3/3] [v2] ide: Adds wwn=hex qdev option allowing the user to specify a disk's World Wide Name

2012-03-13 Thread Floris Bos / Maxnet
84 and 87 are currently not set at all in ide_atapi_identify. Yours sincerely, Floris Bos

[Qemu-devel] [PATCH 3/3] [v2] ide: Adds wwn=hex qdev option allowing the user to specify a disk's World Wide Name

2012-03-13 Thread Floris Bos
Linux guests can address disks by their unique World Wide Name number (e.g. /dev/disk/by-id/wwn-0x5001517959123522) This patch adds support for assigning a World Wide Name number to a virtual IDE disk. Cc: kw...@redhat.com Signed-off-by: Floris Bos --- hw/ide/core.c | 29

Re: [Qemu-devel] [PATCH 3/3] ide: Adds wwn=hex qdev option allowing the user to specify a disk's World Wide Name

2012-03-13 Thread Floris Bos / Maxnet
On 03/13/2012 01:06 PM, Kevin Wolf wrote: Am 13.03.2012 11:29, schrieb Stefan Hajnoczi: On Mon, Mar 12, 2012 at 8:05 PM, Floris Bos wrote: diff --git a/hw/ide/core.c b/hw/ide/core.c index 3e50c52..b48e5c2 100644 --- a/hw/ide/core.c +++ b/hw/ide/core.c @@ -166,6 +166,13 @@ static void

[Qemu-devel] [PATCH 2/3] Disk serial number string copy function: change strncpy() to pstrcpy()

2012-03-12 Thread Floris Bos
Cc: kw...@redhat.com Signed-off-by: Floris Bos --- blockdev.c|5 +++-- hw/ide/core.c |2 +- 2 files changed, 4 insertions(+), 3 deletions(-) diff --git a/blockdev.c b/blockdev.c index d78aa51..e52449e 100644 --- a/blockdev.c +++ b/blockdev.c @@ -532,8 +532,9 @@ DriveInfo *drive_init

[Qemu-devel] [PATCH 3/3] ide: Adds wwn=hex qdev option allowing the user to specify a disk's World Wide Name

2012-03-12 Thread Floris Bos
Linux guests can address disks by their unique World Wide Name number (e.g. /dev/disk/by-id/wwn-0x5001517959123522) This patch adds support for assigning a World Wide Name number to a virtual IDE disk. Cc: kw...@redhat.com Signed-off-by: Floris Bos --- hw/ide/core.c | 13

[Qemu-devel] [PATCH 1/3] ide: Adds "model=s" qdev option, allowing the user to override the default disk model name "QEMU HARDDISK"

2012-03-12 Thread Floris Bos
-of-disk-model is always "QEMU HARDDISK" This patch introduces a model=s option which in combination with the existing serial=s option can be used to fake the disk the operating system was previously on, allowing the OS to boot properly. Cc: kw...@redhat.com Signed-off-by: Floris Bos -

Re: [Qemu-devel] [PATCH v2] ide: Adds "model=s" option, allowing the user to override the default disk model name "QEMU HARDDISK"

2012-03-12 Thread Floris Bos / Maxnet
On 03/12/2012 05:08 PM, Paolo Bonzini wrote: Il 12/03/2012 16:27, Floris Bos / Maxnet ha scritto: 1. IDE only, scsi-disk is missing. Correct. IDE support is easy. Adding SCSI support is more complicated, because "model" and "serial" are not the only factors that can mak

Re: [Qemu-devel] [PATCH v2] ide: Adds "model=s" option, allowing the user to override the default disk model name "QEMU HARDDISK"

2012-03-12 Thread Floris Bos / Maxnet
On 03/12/2012 02:48 PM, Markus Armbruster wrote: Floris Bos writes: Some Linux distributions use the /dev/disk/by-id/scsi-SATA_name-of-disk-model_serial addressing scheme when refering to partitions in /etc/fstab and elsewhere. This causes problems when starting a disk image taken from an

Re: [Qemu-devel] [PATCH] ide: Adds "model=s" option, allowing the user to override the default disk model name "QEMU HARDDISK"

2012-03-12 Thread Floris Bos / Maxnet
On 03/12/2012 12:57 PM, Kevin Wolf wrote: Am 10.03.2012 20:56, schrieb Floris Bos: Some Linux distributions use the /dev/disk/by-id/scsi-SATA_name-of-disk-model_serial addressing scheme when refering to partitions in /etc/fstab and elsewhere. This causes problems when starting a disk image

[Qemu-devel] [PATCH v2] ide: Adds "model=s" option, allowing the user to override the default disk model name "QEMU HARDDISK"

2012-03-12 Thread Floris Bos
-of-disk-model is always "QEMU HARDDISK" This patch introduces a model=s option which in combination with the existing serial=s option can be used to fake the disk the operating system was previously on, allowing the OS to boot properly. Cc: kw...@redhat.com Signed-off-by:

Re: [Qemu-devel] [PATCH] ide: Adds "model=s" option, allowing the user to override the default disk model name "QEMU HARDDISK"

2012-03-12 Thread Floris Bos / Maxnet
On 03/12/2012 11:26 AM, Stefan Hajnoczi wrote: On Sat, Mar 10, 2012 at 7:56 PM, Floris Bos wrote: @@ -1885,6 +1885,22 @@ int ide_init_drive(IDEState *s, BlockDriverState *bs, IDEDriveKind kind, snprintf(s->drive_serial_str, sizeof(s->drive_serial_str), "

[Qemu-devel] [PATCH] ide: Adds "model=s" option, allowing the user to override the default disk model name "QEMU HARDDISK"

2012-03-11 Thread Floris Bos
-of-disk-model is always "QEMU HARDDISK" This patch introduces a model=s option which in combination with the existing serial=s option can be used to fake the disk the operating system was previously on, allowing the OS to boot properly. Cc: kw...@redhat.com Signed-off-by: