Re: [PATCH] MAINTAINERS: add reviewers for some s390 areas

2025-06-23 Thread Farhan Ali
Acked-by: Farhan Ali On 6/23/2025 9:00 AM, Matthew Rosato wrote: To improve review coverage, assign additional people as reviewers for multiple s390 sections. Signed-off-by: Matthew Rosato --- MAINTAINERS | 12 1 file changed, 12 insertions(+) diff --git a/MAINTAINERS b

Re: [PATCH v6 2/3] include: Add a header to define host PCI MMIO functions

2025-05-07 Thread Farhan Ali
On 5/5/2025 2:38 AM, Thomas Huth wrote: On 30/04/2025 20.50, Farhan Ali wrote: Add a generic API for host PCI MMIO reads/writes (e.g. Linux VFIO BAR accesses). The functions access little endian memory and returns the result in host cpu endianness. Reviewed-by: Stefan Hajnoczi Signed-off-by

[PATCH v6 1/3] util: Add functions for s390x mmio read/write

2025-04-30 Thread Farhan Ali
s390x. Reviewed-by: Stefan Hajnoczi Reviewed-by: Niklas Schnelle Signed-off-by: Farhan Ali --- include/qemu/s390x_pci_mmio.h | 24 ++ util/meson.build | 2 + util/s390x_pci_mmio.c | 146 ++ 3 files changed, 172 insertions(+) create mode 1

[PATCH v6 3/3] block/nvme: Use host PCI MMIO API

2025-04-30 Thread Farhan Ali
Use the host PCI MMIO functions to read/write to NVMe registers, rather than directly accessing them. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Reviewed-by: Thomas Huth Signed-off-by: Farhan Ali --- block/nvme.c | 41 +++-- 1 file

[PATCH v6 2/3] include: Add a header to define host PCI MMIO functions

2025-04-30 Thread Farhan Ali
Add a generic API for host PCI MMIO reads/writes (e.g. Linux VFIO BAR accesses). The functions access little endian memory and returns the result in host cpu endianness. Reviewed-by: Stefan Hajnoczi Signed-off-by: Farhan Ali --- include/qemu/host-pci-mmio.h | 136

[PATCH v6 0/3] Enable QEMU NVMe userspace driver on s390x

2025-04-30 Thread Farhan Ali
emu-devel/2025-03/msg06596.html v1 -> v2 - Add 8 and 16 bit reads/writes for completeness (patch 1) - Introduce new QEMU PCI MMIO read/write API as suggested by Stefan (patch 2) - Update NVMe userspace driver to use QEMU PCI MMIO functions (patch 3) Farhan Ali (3): util: Add functions

Re: [PATCH v5 2/3] include: Add a header to define host PCI MMIO functions

2025-04-30 Thread Farhan Ali
On 4/30/2025 10:52 AM, Thomas Huth wrote: On 30/04/2025 18.47, Farhan Ali wrote: ..snip... +static inline uint32_t host_pci_ldl_le_p(const void *ioaddr) +{ +    uint32_t ret = 0; +#ifdef __s390x__ +    ret = le32_to_cpu(s390x_pci_mmio_read_32(ioaddr)); +#else +    ret = (uint32_t)ldl_le_p

Re: [PATCH v5 2/3] include: Add a header to define host PCI MMIO functions

2025-04-30 Thread Farhan Ali
..snip... +static inline uint32_t host_pci_ldl_le_p(const void *ioaddr) +{ +    uint32_t ret = 0; +#ifdef __s390x__ +    ret = le32_to_cpu(s390x_pci_mmio_read_32(ioaddr)); +#else +    ret = (uint32_t)ldl_le_p(ioaddr); This is the only spot where you used a cast. Is it necessary, or could it

Re: [PATCH v5 1/3] util: Add functions for s390x mmio read/write

2025-04-30 Thread Farhan Ali
On 4/25/2025 7:09 AM, Heiko Carstens wrote: On Fri, Apr 25, 2025 at 12:29:35PM +0200, Niklas Schnelle wrote: On Fri, 2025-04-25 at 11:00 +0200, Thomas Huth wrote: On 17/04/2025 19.37, Farhan Ali wrote: +asm volatile( +/* pcilgi */ +".insn rre,0xb9d6,

Re: [PATCH v5 0/3] Enable QEMU NVMe userspace driver on s390x

2025-04-24 Thread Farhan Ali
Hi Alex, Polite ping. Please let me know if there are any concerns with this version of the patches. Thanks Farhan On 4/17/2025 10:37 AM, Farhan Ali wrote: Hi, Recently on s390x we have enabled mmap support for vfio-pci devices [1]. This allows us to take advantage and use userspace

[PATCH v5 1/3] util: Add functions for s390x mmio read/write

2025-04-17 Thread Farhan Ali
s390x. Reviewed-by: Stefan Hajnoczi Reviewed-by: Niklas Schnelle Signed-off-by: Farhan Ali --- include/qemu/s390x_pci_mmio.h | 24 ++ util/meson.build | 2 + util/s390x_pci_mmio.c | 148 ++ 3 files changed, 174 insertions(+) create mode 1

[PATCH v5 2/3] include: Add a header to define host PCI MMIO functions

2025-04-17 Thread Farhan Ali
Add a generic API for host PCI MMIO reads/writes (e.g. Linux VFIO BAR accesses). The functions access little endian memory and returns the result in host cpu endianness. Signed-off-by: Farhan Ali --- include/qemu/host-pci-mmio.h | 141 +++ 1 file changed, 141

[PATCH v5 0/3] Enable QEMU NVMe userspace driver on s390x

2025-04-17 Thread Farhan Ali
ed by Stefan (patch 2) - Update NVMe userspace driver to use QEMU PCI MMIO functions (patch 3) Farhan Ali (3): util: Add functions for s390x mmio read/write include: Add a header to define host PCI MMIO functions block/nvme: Use host PCI MMIO API block/nvme.c | 41 +--

[PATCH v5 3/3] block/nvme: Use host PCI MMIO API

2025-04-17 Thread Farhan Ali
Use the host PCI MMIO functions to read/write to NVMe registers, rather than directly accessing them. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Signed-off-by: Farhan Ali --- block/nvme.c | 41 +++-- 1 file changed, 23 insertions

[PATCH v4 1/3] util: Add functions for s390x mmio read/write

2025-04-15 Thread Farhan Ali
s390x. Reviewed-by: Stefan Hajnoczi Reviewed-by: Niklas Schnelle Signed-off-by: Farhan Ali --- include/qemu/s390x_pci_mmio.h | 24 ++ util/meson.build | 2 + util/s390x_pci_mmio.c | 148 ++ 3 files changed, 174 insertions(+) create mode 1

Re: [PATCH v4 2/3] include: Add a header to define host PCI MMIO functions

2025-04-15 Thread Farhan Ali
On 4/14/2025 11:43 PM, Philippe Mathieu-Daudé wrote: Hi, On 14/4/25 23:36, Farhan Ali wrote: Add a generic API for host PCI MMIO reads/writes (e.g. Linux VFIO BAR accesses). The functions access little endian memory and returns the result in host cpu endianness. Signed-off-by: Farhan Ali

Re: [PATCH v4 2/3] include: Add a header to define host PCI MMIO functions

2025-04-14 Thread Farhan Ali
On 4/14/2025 2:36 PM, Farhan Ali wrote: Add a generic API for host PCI MMIO reads/writes (e.g. Linux VFIO BAR accesses). The functions access little endian memory and returns the result in host cpu endianness. Signed-off-by: Farhan Ali --- include/qemu/host-pci-mmio.h | 141

[PATCH v4 2/3] include: Add a header to define host PCI MMIO functions

2025-04-14 Thread Farhan Ali
Add a generic API for host PCI MMIO reads/writes (e.g. Linux VFIO BAR accesses). The functions access little endian memory and returns the result in host cpu endianness. Signed-off-by: Farhan Ali --- include/qemu/host-pci-mmio.h | 141 +++ 1 file changed, 141

[PATCH v4 3/3] block/nvme: Use host PCI MMIO API

2025-04-14 Thread Farhan Ali
Use the host PCI MMIO functions to read/write to NVMe registers, rather than directly accessing them. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Signed-off-by: Farhan Ali --- block/nvme.c | 41 +++-- 1 file changed, 23 insertions

[PATCH v4 0/3] Enable QEMU NVMe userspace driver on s390x

2025-04-14 Thread Farhan Ali
025-03/msg06596.html v1 -> v2 - Add 8 and 16 bit reads/writes for completeness (patch 1) - Introduce new QEMU PCI MMIO read/write API as suggested by Stefan (patch 2) - Update NVMe userspace driver to use QEMU PCI MMIO functions (patch 3) Farhan Ali (3): util: Add functions for s390x

Re: [PATCH v3 0/3] Enable QEMU NVMe userspace driver on s390x

2025-04-11 Thread Farhan Ali
On 4/11/2025 3:28 PM, Alex Williamson wrote: On Thu, 10 Apr 2025 09:07:51 -0700 Farhan Ali wrote: On 4/3/2025 2:24 PM, Alex Williamson wrote: On Thu, 3 Apr 2025 13:33:17 -0700 Farhan Ali wrote: On 4/3/2025 11:05 AM, Alex Williamson wrote: On Thu, 3 Apr 2025 10:33:52 -0700 Farhan Ali

Re: [PATCH v1 12/24] hw/s390x/ipl: Add IPIB flags to IPL Parameter Block

2025-04-11 Thread Farhan Ali
...snip... diff --git a/include/hw/s390x/ipl/qipl.h b/include/hw/s390x/ipl/qipl.h index b8e7d1da71..2355fcecbb 100644 --- a/include/hw/s390x/ipl/qipl.h +++ b/include/hw/s390x/ipl/qipl.h @@ -23,6 +23,9 @@ #define MAX_CERTIFICATES 64 #define CERT_MAX_SIZE (1024 * 8) +#define DIAG308_

Re: [PATCH v1 06/24] s390x/diag: Implement DIAG 320 subcode 1

2025-04-11 Thread Farhan Ali
On 4/8/2025 8:55 AM, Zhuoying Cai wrote: DIAG 320 subcode 1 provides information needed to determine the amount of storage to store one or more certificates. The subcode value is denoted by setting the left-most bit of an 8-byte field. The verification-certificate-storage-size block (VCSSB) c

Re: [PATCH v3 0/3] Enable QEMU NVMe userspace driver on s390x

2025-04-10 Thread Farhan Ali
On 4/3/2025 2:24 PM, Alex Williamson wrote: On Thu, 3 Apr 2025 13:33:17 -0700 Farhan Ali wrote: On 4/3/2025 11:05 AM, Alex Williamson wrote: On Thu, 3 Apr 2025 10:33:52 -0700 Farhan Ali wrote: On 4/3/2025 9:27 AM, Alex Williamson wrote: On Thu, 3 Apr 2025 11:44:42 -0400 Stefan

[PATCH v2 2/3] include: Add a header to define PCI MMIO functions

2025-04-05 Thread Farhan Ali
Add a generic QEMU API for PCI MMIO reads/writes. The functions access little endian memory and returns the result in host cpu endianness. Signed-off-by: Farhan Ali --- include/qemu/pci-mmio.h | 116 1 file changed, 116 insertions(+) create mode 100644

Re: [PATCH v3 0/3] Enable QEMU NVMe userspace driver on s390x

2025-04-03 Thread Farhan Ali
On 4/3/2025 11:05 AM, Alex Williamson wrote: On Thu, 3 Apr 2025 10:33:52 -0700 Farhan Ali wrote: On 4/3/2025 9:27 AM, Alex Williamson wrote: On Thu, 3 Apr 2025 11:44:42 -0400 Stefan Hajnoczi wrote: On Thu, Apr 03, 2025 at 09:47:26AM +0200, Niklas Schnelle wrote: On Wed, 2025-04-02 at

Re: [PATCH v3 0/3] Enable QEMU NVMe userspace driver on s390x

2025-04-03 Thread Farhan Ali
On 4/3/2025 9:27 AM, Alex Williamson wrote: On Thu, 3 Apr 2025 11:44:42 -0400 Stefan Hajnoczi wrote: On Thu, Apr 03, 2025 at 09:47:26AM +0200, Niklas Schnelle wrote: On Wed, 2025-04-02 at 11:51 -0400, Stefan Hajnoczi wrote: On Tue, Apr 01, 2025 at 10:22:43AM -0700, Farhan Ali wrote: Hi

[PATCH v3 2/3] include: Add a header to define host PCI MMIO functions

2025-04-01 Thread Farhan Ali
Add a generic API for host PCI MMIO reads/writes (e.g. Linux VFIO BAR accesses). The functions access little endian memory and returns the result in host cpu endianness. Reviewed-by: Philippe Mathieu-Daudé Signed-off-by: Farhan Ali --- include/qemu/host-pci-mmio.h | 116

[PATCH v3 3/3] block/nvme: Use host PCI MMIO API

2025-04-01 Thread Farhan Ali
Use the host PCI MMIO functions to read/write to NVMe registers, rather than directly accessing them. Reviewed-by: Philippe Mathieu-Daudé Reviewed-by: Stefan Hajnoczi Signed-off-by: Farhan Ali --- block/nvme.c | 37 + 1 file changed, 21 insertions(+), 16

[PATCH v3 1/3] util: Add functions for s390x mmio read/write

2025-04-01 Thread Farhan Ali
s390x. Reviewed-by: Stefan Hajnoczi Reviewed-by: Niklas Schnelle Signed-off-by: Farhan Ali --- include/qemu/s390x_pci_mmio.h | 24 ++ util/meson.build | 2 + util/s390x_pci_mmio.c | 148 ++ 3 files changed, 174 insertions(+) create mode 1

[PATCH v3 0/3] Enable QEMU NVMe userspace driver on s390x

2025-04-01 Thread Farhan Ali
gt; v2 - Add 8 and 16 bit reads/writes for completeness (patch 1) - Introduce new QEMU PCI MMIO read/write API as suggested by Stefan (patch 2) - Update NVMe userspace driver to use QEMU PCI MMIO functions (patch 3) Farhan Ali (3): util: Add functions for s390x mmio read/write i

Re: [PATCH v2 2/3] include: Add a header to define PCI MMIO functions

2025-04-01 Thread Farhan Ali
On 3/31/2025 6:46 AM, Stefan Hajnoczi wrote: On Fri, Mar 28, 2025 at 12:06:26PM -0700, Farhan Ali wrote: Add a generic QEMU API for PCI MMIO reads/writes. The functions access little endian memory and returns the result in host cpu endianness. Signed-off-by: Farhan Ali --- include/qemu

Re: [PATCH v2 3/3] block/nvme: Use QEMU PCI MMIO API

2025-03-28 Thread Farhan Ali
On 3/28/2025 1:41 PM, Philippe Mathieu-Daudé wrote: On 28/3/25 20:06, Farhan Ali wrote: Use the QEMU PCI MMIO functions to read/write to NVMe registers, rather than directly accessing them. Signed-off-by: Farhan Ali ---   block/nvme.c | 37 +   1 file

Re: [PATCH v2 2/3] include: Add a header to define PCI MMIO functions

2025-03-28 Thread Farhan Ali
On 3/28/2025 1:44 PM, Philippe Mathieu-Daudé wrote: On 28/3/25 20:06, Farhan Ali wrote: Add a generic QEMU API for PCI MMIO reads/writes. The functions access little endian memory and returns the result in host cpu endianness. Signed-off-by: Farhan Ali ---   include/qemu/pci-mmio.h | 116

Re: [PATCH v2 2/3] include: Add a header to define PCI MMIO functions

2025-03-28 Thread Farhan Ali
On 3/28/2025 1:38 PM, Philippe Mathieu-Daudé wrote: On 28/3/25 20:06, Farhan Ali wrote: Add a generic QEMU API for PCI MMIO reads/writes. The functions access little endian memory and returns the result in host cpu endianness. Signed-off-by: Farhan Ali ---   include/qemu/pci-mmio.h | 116

[PATCH v2 1/3] util: Add functions for s390x mmio read/write

2025-03-28 Thread Farhan Ali
s390x. Reviewed-by: Stefan Hajnoczi Signed-off-by: Farhan Ali --- include/qemu/s390x_pci_mmio.h | 23 ++ util/meson.build | 2 + util/s390x_pci_mmio.c | 148 ++ 3 files changed, 173 insertions(+) create mode 100644 include/qemu/s390x_pci_m

[PATCH v2 0/3] Enable QEMU NVMe userspace driver on s390x

2025-03-28 Thread Farhan Ali
bit reads/writes for completeness (patch 1) - Introduce new QEMU PCI MMIO read/write API as suggested by Stefan (patch 2) - Update NVMe userspace driver to use QEMU PCI MMIO functions (patch 3) Farhan Ali (3): util: Add functions for s390x mmio read/write include: Add a header to def

[PATCH v2 3/3] block/nvme: Use QEMU PCI MMIO API

2025-03-28 Thread Farhan Ali
Use the QEMU PCI MMIO functions to read/write to NVMe registers, rather than directly accessing them. Signed-off-by: Farhan Ali --- block/nvme.c | 37 + 1 file changed, 21 insertions(+), 16 deletions(-) diff --git a/block/nvme.c b/block/nvme.c index

Re: [PATCH v1 1/2] util: Add functions for s390x mmio read/write

2025-03-27 Thread Farhan Ali
On 3/27/2025 12:20 PM, Stefan Hajnoczi wrote: On Wed, Mar 26, 2025 at 11:10:06AM -0700, Farhan Ali wrote: Starting with z15 (or newer) we can execute mmio instructions from userspace. On older platforms where we don't have these instructions available we can fallback to using system cal

Re: [PATCH v1 2/2] block/nvme: Enable NVMe userspace driver for s390x

2025-03-27 Thread Farhan Ali
On 3/27/2025 12:26 PM, Stefan Hajnoczi wrote: On Wed, Mar 26, 2025 at 11:10:07AM -0700, Farhan Ali wrote: +static inline uint32_t nvme_mmio_read_32(const void *addr) +{ +uint32_t ret; + +#ifdef __s390x__ +ret = s390x_pci_mmio_read_32(addr); +#else +/* Prevent the compiler from

[PATCH v1 0/2] Enable QEMU NVMe userspace driver on s390x

2025-03-26 Thread Farhan Ali
. I would appreciate any review/feedback on the patches. Thanks Farhan [1] https://lore.kernel.org/linux-s390/20250226-vfio_pci_mmap-v7-0-c5c0f1d26...@linux.ibm.com/ Farhan Ali (2): util: Add functions for s390x mmio read/write block/nvme: Enable NVMe userspace driver for s390x block

[PATCH v1 1/2] util: Add functions for s390x mmio read/write

2025-03-26 Thread Farhan Ali
igned-off-by: Farhan Ali --- include/qemu/s390x_pci_mmio.h | 17 ++ util/meson.build | 2 + util/s390x_pci_mmio.c | 105 ++ 3 files changed, 124 insertions(+) create mode 100644 include/qemu/s390x_pci_mmio.h create mode 100644

[PATCH v1 2/2] block/nvme: Enable NVMe userspace driver for s390x

2025-03-26 Thread Farhan Ali
On s390x we can now support userspace mmio and mmap from vfio. This patch uses s390x mmio support to enable the NVMe userspace driver for s390x. Signed-off-by: Farhan Ali --- block/nvme.c | 95 ++-- 1 file changed, 77 insertions(+), 18 deletions

Re: QEMU Userspace NVMe driver and multiple iothreads

2025-03-21 Thread Farhan Ali
On 3/20/2025 12:17 PM, Stefan Hajnoczi wrote: On Thu, Mar 20, 2025 at 11:13:04AM -0700, Farhan Ali wrote: Hi, I have been experimenting with the QEMU Userspace NVMe driver on s390x architecture. I have noticed an issue when assigning multiple virtqueues and multiple iothreads to the block

QEMU Userspace NVMe driver and multiple iothreads

2025-03-20 Thread Farhan Ali
Hi, I have been experimenting with the QEMU Userspace NVMe driver on s390x architecture. I have noticed an issue when assigning multiple virtqueues and multiple iothreads to the block device. The driver works well with a single iothread, but when using more than one iothread we can hit a prob

Re: [Qemu-devel] [PATCH v5] vfio-ccw: support async command subregion

2019-06-12 Thread Farhan Ali
On 06/12/2019 05:38 AM, Cornelia Huck wrote: On Tue, 11 Jun 2019 15:33:59 -0400 Farhan Ali wrote: On 06/07/2019 10:53 AM, Cornelia Huck wrote: A vfio-ccw device may provide an async command subregion for issuing halt/clear subchannel requests. If it is present, use it for sending halt

Re: [Qemu-devel] [PATCH v5] vfio-ccw: support async command subregion

2019-06-11 Thread Farhan Ali
On 06/11/2019 07:37 AM, Cornelia Huck wrote: On Fri, 7 Jun 2019 11:19:09 -0400 Farhan Ali wrote: On 06/07/2019 11:09 AM, Cornelia Huck wrote: On Fri, 7 Jun 2019 11:02:36 -0400 Farhan Ali wrote: On 06/07/2019 10:53 AM, Cornelia Huck wrote: diff --git a/hw/s390x/css.c b/hw/s390x

Re: [Qemu-devel] [PATCH v5] vfio-ccw: support async command subregion

2019-06-11 Thread Farhan Ali
On 06/07/2019 10:53 AM, Cornelia Huck wrote: A vfio-ccw device may provide an async command subregion for issuing halt/clear subchannel requests. If it is present, use it for sending halt/clear request to the device; if not, fall back to emulation (as done today). Signed-off-by: Cornelia Huck

Re: [Qemu-devel] [PATCH v5] vfio-ccw: support async command subregion

2019-06-07 Thread Farhan Ali
On 06/07/2019 11:09 AM, Cornelia Huck wrote: On Fri, 7 Jun 2019 11:02:36 -0400 Farhan Ali wrote: On 06/07/2019 10:53 AM, Cornelia Huck wrote: A vfio-ccw device may provide an async command subregion for issuing halt/clear subchannel requests. If it is present, use it for sending halt

Re: [Qemu-devel] [PATCH v5] vfio-ccw: support async command subregion

2019-06-07 Thread Farhan Ali
On 06/07/2019 10:53 AM, Cornelia Huck wrote: A vfio-ccw device may provide an async command subregion for issuing halt/clear subchannel requests. If it is present, use it for sending halt/clear request to the device; if not, fall back to emulation (as done today). Signed-off-by: Cornelia Huck

Re: [Qemu-devel] [PATCH v4 2/2] vfio-ccw: support async command subregion

2019-05-22 Thread Farhan Ali
On 05/22/2019 06:17 AM, Cornelia Huck wrote: On Tue, 21 May 2019 16:50:47 -0400 Farhan Ali wrote: On 05/07/2019 11:47 AM, Cornelia Huck wrote: A vfio-ccw device may provide an async command subregion for issuing halt/clear subchannel requests. If it is present, use it for sending halt

Re: [Qemu-devel] [PATCH v4 2/2] vfio-ccw: support async command subregion

2019-05-21 Thread Farhan Ali
On 05/21/2019 12:32 PM, Cornelia Huck wrote: On Mon, 20 May 2019 12:29:56 -0400 Eric Farman wrote: On 5/7/19 11:47 AM, Cornelia Huck wrote: A vfio-ccw device may provide an async command subregion for issuing halt/clear subchannel requests. If it is present, use it for sending halt/clear r

Re: [Qemu-devel] [PATCH v4 2/2] vfio-ccw: support async command subregion

2019-05-21 Thread Farhan Ali
On 05/07/2019 11:47 AM, Cornelia Huck wrote: A vfio-ccw device may provide an async command subregion for issuing halt/clear subchannel requests. If it is present, use it for sending halt/clear request to the device; if not, fall back to emulation (as done today). Signed-off-by: Cornelia Huck

Re: [Qemu-devel] [PATCH v4 4/6] vfio-ccw: add capabilities chain

2019-04-15 Thread Farhan Ali
/vfio_ccw_private.h | 38 ++ include/uapi/linux/vfio.h | 2 + 3 files changed, 200 insertions(+), 26 deletions(-) Reviewed-by: Farhan Ali

Re: [Qemu-devel] [PATCH v4 6/6] vfio-ccw: add handling for async channel instructions

2019-04-15 Thread Farhan Ali
channels as for ssch. Signed-off-by: Cornelia Huck Reviewed-by: Farhan Ali

Re: [Qemu-devel] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs

2019-04-08 Thread Farhan Ali
On 04/08/2019 01:07 PM, Cornelia Huck wrote: On Mon, 8 Apr 2019 13:02:12 -0400 Farhan Ali wrote: On 03/01/2019 04:38 AM, Cornelia Huck wrote: When we get a solicited interrupt, the start function may have been cleared by a csch, but we still have a channel program structure allocated

Re: [Qemu-devel] [PATCH v4 1/6] vfio-ccw: make it safe to access channel programs

2019-04-08 Thread Farhan Ali
, separate from this series. And also the patch LGTM Reviewed-by: Farhan Ali Thanks Farhan

Re: [Qemu-devel] [PATCH 11/14] hw/vfio/ccw: avoid taking address members in packed structs

2019-04-02 Thread Farhan Ali
&s, &irb.scsw); +schib->scsw = s; /* If a uint check is pending, copy sense data. */ -if ((s->dstat & SCSW_DSTAT_UNIT_CHECK) && - (p->chars & PMCW_CHARS_MASK_CSENSE)) { +if ((schib->scsw.dstat & SCSW_DSTAT_UNIT_CHECK) && +(schib->pmcw.chars & PMCW_CHARS_MASK_CSENSE)) { memcpy(sch->sense_data, irb.ecw, sizeof(irb.ecw)); } Reviewed-by: Farhan Ali

Re: [Qemu-devel] [PATCH 13/14] hw/s390x/ipl: avoid taking address of fields in packed struct

2019-04-02 Thread Farhan Ali
e32(splash_time); +ipl->qipl.boot_menu_timeout = cpu_to_be32(splash_time); } static CcwDevice *s390_get_ccw_device(DeviceState *dev_st) Reviewed-by: Farhan Ali

Re: [Qemu-devel] [PATCH v5 10/15] s390-bios: Support for running format-0/1 channel programs

2019-03-14 Thread Farhan Ali
-ccw/s390-ccw.h | 1 + pc-bios/s390-ccw/start.S| 29 + 4 files changed, 301 insertions(+), 3 deletions(-) Reviewed-by: Farhan Ali

Re: [Qemu-devel] qemu-iotest 55 broken

2019-03-14 Thread Farhan Ali
On 03/14/2019 01:11 PM, Eric Blake wrote: On 3/14/19 11:33 AM, Farhan Ali wrote: Hi, I noticed qemu iotest 55 was broken on the latest master (My head commit is dbbc277 Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging). Patch has been propos

[Qemu-devel] qemu-iotest 55 broken

2019-03-14 Thread Farhan Ali
Hi, I noticed qemu iotest 55 was broken on the latest master (My head commit is dbbc277 Merge remote-tracking branch 'remotes/stefanha/tags/block-pull-request' into staging). The backtrace of the qemu process when the test fails: #0 0x7f82047cd428 in __GI_raise (sig=sig@entry=6) at ../

Re: [Qemu-devel] [PATCH v3 01/16] s390 vfio-ccw: Add bootindex property and IPLB data

2019-03-04 Thread Farhan Ali
On 03/01/2019 01:59 PM, Jason J. Herne wrote: Add bootindex property and iplb data for vfio-ccw devices. This allows us to forward boot information into the bios for vfio-ccw devices. Refactor s390_get_ccw_device() to return device type. This prevents us from having to use messy casting logic

Re: [Qemu-devel] [PATCH v2] s390x: add zPCI feature to "qemu" CPU model

2019-02-13 Thread Farhan Ali
On 02/13/2019 11:26 AM, Cornelia Huck wrote: On Wed, 13 Feb 2019 10:54:23 -0500 Farhan Ali wrote: I noticed the qemu-iotests 200 was failing due to the commit "703fef6fcf3 : s390x/pci: Warn when adding PCI devices without the 'zpci' feature". This patch fixes the fail

Re: [Qemu-devel] [PATCH v2] s390x: add zPCI feature to "qemu" CPU model

2019-02-13 Thread Farhan Ali
I noticed the qemu-iotests 200 was failing due to the commit "703fef6fcf3 : s390x/pci: Warn when adding PCI devices without the 'zpci' feature". This patch fixes the failure :). Thanks Farhan On 02/12/2019 06:23 AM, David Hildenbrand wrote: As we now always have PCI support, let's add it to

Re: [Qemu-devel] [PATCH v3 1/6] vfio-ccw: make it safe to access channel programs

2019-02-05 Thread Farhan Ali
On 02/05/2019 09:48 AM, Eric Farman wrote: On 02/05/2019 07:35 AM, Cornelia Huck wrote: On Tue, 5 Feb 2019 12:52:29 +0100 Halil Pasic wrote: On Mon, 4 Feb 2019 16:31:02 +0100 Cornelia Huck wrote: On Thu, 31 Jan 2019 13:34:55 +0100 Halil Pasic wrote: On Thu, 31 Jan 2019 12:52:20 +010

Re: [Qemu-devel] [PATCH 10/15] s390-bios: Support for running format-0/1 channel programs

2019-02-04 Thread Farhan Ali
On 02/04/2019 06:13 AM, Cornelia Huck wrote: On Thu, 31 Jan 2019 12:31:00 -0500 Farhan Ali wrote: On 01/29/2019 08:29 AM, Jason J. Herne wrote: Add struct for format-0 ccws. Support executing format-0 channel programs and waiting for their completion before continuing execution. This will

Re: [Qemu-devel] [PATCH 10/15] s390-bios: Support for running format-0/1 channel programs

2019-01-31 Thread Farhan Ali
On 01/29/2019 08:29 AM, Jason J. Herne wrote: Add struct for format-0 ccws. Support executing format-0 channel programs and waiting for their completion before continuing execution. This will be used for real dasd ipl. Add cu_type() to channel io library. This will be used to query control un

Re: [Qemu-devel] [PATCH 07/15] s390-bios: Decouple channel i/o logic from virtio

2019-01-31 Thread Farhan Ali
On 01/29/2019 08:29 AM, Jason J. Herne wrote: Create a separate library for channel i/o related code. This decouples channel i/o operations from virtio and allows us to make use of them for the real dasd boot path. Signed-off-by: Jason J. Herne --- pc-bios/s390-ccw/Makefile| 2 +-

Re: [Qemu-devel] [PATCH 06/15] s390-bios: Clean up cio.h

2019-01-31 Thread Farhan Ali
void); void consume_sclp_int(void); Reviewed-by: Farhan Ali

Re: [Qemu-devel] [PATCH 05/15] s390-bios: Factor finding boot device out of virtio code path

2019-01-31 Thread Farhan Ali
quot;UltraSPARC" }, - { "s390x", "s390-ccw-virtio", "", "virtio device" }, +{ "s390x", "s390-ccw-virtio", "", "device" }, { "m68k", "mcf5208evb", "", "TT", sizeof(kernel_mcf5208), kernel_mcf5208 }, { "microblaze", "petalogix-s3adsp1800", "", "TT", sizeof(kernel_pls3adsp1800), kernel_pls3adsp1800 }, Reviewed-by: Farhan Ali

Re: [Qemu-devel] [PATCH 01/15] s390 vfio-ccw: Add bootindex property and IPLB data

2019-01-30 Thread Farhan Ali
On 01/29/2019 08:29 AM, Jason J. Herne wrote: Add bootindex property and iplb data for vfio-ccw devices. This allows us to forward boot information into the bios for vfio-ccw devices. Signed-off-by: Jason J. Herne Acked-by: Halil Pasic --- hw/s390x/ipl.c | 14 ++ h

Re: [Qemu-devel] [PATCH 03/15] s390-bios: decouple common boot logic from virtio

2019-01-30 Thread Farhan Ali
_setup(); zipl_load(); /* no return */ Reviewed-by: Farhan Ali

Re: [Qemu-devel] [PATCH 02/15] s390-bios: decouple cio setup from virtio

2019-01-30 Thread Farhan Ali
ADPARM_LEN); sclp_print(ldp); @@ -168,6 +173,7 @@ static void virtio_setup(void) int main(void) { sclp_setup(); +css_setup(); virtio_setup(); zipl_load(); /* no return */ Reviewed-by: Farhan Ali

Re: [Qemu-devel] [PATCH v2 2/5] vfio-ccw: concurrent I/O handling

2019-01-30 Thread Farhan Ali
On 01/30/2019 08:29 AM, Cornelia Huck wrote: On Tue, 29 Jan 2019 20:39:33 +0100 Halil Pasic wrote: On Tue, 29 Jan 2019 10:58:40 +0100 Cornelia Huck wrote: The problem I see with the let the hardware sort it out is that, for that to work, we need to juggle multiple translations simultaneo

Re: [Qemu-devel] [PATCH 11/15] s390-bios: cio error handling

2018-12-13 Thread Farhan Ali
On 12/12/2018 09:11 AM, Jason J. Herne wrote: Add verbose error output for when unexpected i/o errors happen. This eases the burden of debugging and reporting i/o errors. No error information is printed in the success case, here is an example of what is output on error: vfio-ccw device I/O er

Re: [Qemu-devel] [PATCH 10/15] s390-bios: Support for running format-0/1 channel programs

2018-12-13 Thread Farhan Ali
On 12/12/2018 09:11 AM, Jason J. Herne wrote: Add struct for format-0 ccws. Support executing format-0 channel programs and waiting for their completion before continuing execution. This will be used for real dasd ipl. Add cu_type() to channel io library. This will be used to query control un

Re: [Qemu-devel] [PATCH 05/15] s390-bios: Factor finding boot device out of virtio code path

2018-12-13 Thread Farhan Ali
On 12/12/2018 09:11 AM, Jason J. Herne wrote: Make a new routine find_boot_device to locate the boot device for all cases. not just virtio. I don't think there should be a period after cases? In one case no boot device is specified and a suitable boot device can not be auto detected. The

Re: [Qemu-devel] [PATCH 03/15] s390-bios: decouple common boot logic from virtio

2018-12-13 Thread Farhan Ali
eters)); -if (store_iplb(&iplb)) { +if (have_iplb) { switch (iplb.pbt) { case S390_IPL_TYPE_CCW: dev_no = iplb.ccw.devno; @@ -174,6 +185,7 @@ int main(void) { sclp_setup(); css_setup(); +boot_setup(); virtio_setup(); zipl_load(); /* no return */ Reviewed-by: Farhan Ali

Re: [Qemu-devel] [PATCH 02/15] s390-bios: decouple cio setup from virtio

2018-12-13 Thread Farhan Ali
ADPARM_LEN); sclp_print(ldp); @@ -168,6 +173,7 @@ static void virtio_setup(void) int main(void) { sclp_setup(); +css_setup(); virtio_setup(); zipl_load(); /* no return */ Reviewed-by: Farhan Ali

Re: [Qemu-devel] [PATCH v2] hw/s390/ccw.c: Don't take address of packed members

2018-12-13 Thread Farhan Ali
py_scsw_from_guest(&dest_scsw, &src_scsw); +dest->scsw = dest_scsw; dest->mba = be64_to_cpu(src->mba); for (i = 0; i < ARRAY_SIZE(dest->mda); i++) { dest->mda[i] = src->mda[i]; Reviewed-by: Farhan Ali

Re: [Qemu-devel] [PATCH] hw/s390/ccw.c: Don't take address of packed members

2018-12-10 Thread Farhan Ali
csw; +copy_scsw_from_guest(&destscsw, &srcscsw); +dest->scsw = destscsw; dest->mba = be64_to_cpu(src->mba); for (i = 0; i < ARRAY_SIZE(dest->mda); i++) { dest->mda[i] = src->mda[i]; Reviewed-by: Farhan Ali

Re: [Qemu-devel] [PATCH 0/3] vfio-ccw: support hsch/csch (kernel part)

2018-12-06 Thread Farhan Ali
On 12/06/2018 11:21 AM, Cornelia Huck wrote: On Thu, 6 Dec 2018 10:26:12 -0500 Farhan Ali wrote: On 12/06/2018 09:39 AM, Cornelia Huck wrote: On Wed, 5 Dec 2018 13:34:11 -0500 Farhan Ali wrote: On 12/05/2018 07:54 AM, Cornelia Huck wrote: Yeah, that is perfectly clear, but it ain&#

Re: [Qemu-devel] [PATCH 0/3] vfio-ccw: support hsch/csch (kernel part)

2018-12-06 Thread Farhan Ali
On 12/06/2018 09:39 AM, Cornelia Huck wrote: On Wed, 5 Dec 2018 13:34:11 -0500 Farhan Ali wrote: On 12/05/2018 07:54 AM, Cornelia Huck wrote: Yeah, that is perfectly clear, but it ain't the complete story. E.g. are subsequent commands blocking until the preceding command finishes is

Re: [Qemu-devel] [PATCH 0/3] vfio-ccw: support hsch/csch (kernel part)

2018-12-05 Thread Farhan Ali
On 12/05/2018 07:54 AM, Cornelia Huck wrote: Yeah, that is perfectly clear, but it ain't the complete story. E.g. are subsequent commands blocking until the preceding command finishes is part of the interface. And what is good implementation depends on the answer. What I mean, I first need to

[Qemu-devel] [PATCH for 3.1? or 4 v4 1/1] qemu-iotests: Don't run the test when user is root

2018-12-03 Thread Farhan Ali
Test 232 creates image files with read-only permission and expects an error message when trying to access the image files with read-only and auto-read-only turned off. Don't run as root user, since root can open files with read/write access for read-only files. Signed-off-by: Farha

Re: [Qemu-devel] [RFC for 3.1? or 4 v3 1/1] qemu-iotests: Don't run the test when user is root

2018-11-30 Thread Farhan Ali
On 11/30/2018 03:52 PM, Eric Blake wrote: On 11/30/18 2:37 PM, Farhan Ali wrote: Test 232 creates image files with read-only permission and expects an error message when trying to access the image files with read-only and auto-read-only turned off. Don't run as root user, since roo

[Qemu-devel] [RFC for 3.1? or 4 v3 1/1] qemu-iotests: Don't run the test when user is root

2018-11-30 Thread Farhan Ali
Test 232 creates image files with read-only permission and expects an error message when trying to access the image files with read-only and auto-read-only turned off. Don't run as root user, since root can open files with read/write access for read-only files. Signed-off-by: Farha

Re: [Qemu-devel] [RFC for 3.1? or 4 v2 1/1] qemu-iotests: Don't run the test when user is root

2018-11-30 Thread Farhan Ali
On 11/30/2018 12:50 PM, Eric Blake wrote: Adding qemu-devel - all patches should go there, especially if you want to get Peter's attention that this might be a 3.1 candidate if we have other reasons to spin -rc4. On 11/30/18 10:04 AM, Farhan Ali wrote: Test 232 creates image files

Re: [Qemu-devel] qemu-iotests 232 fails when running the test as root user

2018-11-29 Thread Farhan Ali
On 11/29/2018 04:07 PM, Eric Blake wrote: On 11/29/18 3:03 PM, Farhan Ali wrote: Hi, I am seeing a failure of the qemu-iotest number 232 when running the test as a root user. Is this the expected behavior? Here is the output of the failure: -QEMU_PROG: -drive driver=file,file

[Qemu-devel] qemu-iotests 232 fails when running the test as root user

2018-11-29 Thread Farhan Ali
Hi, I am seeing a failure of the qemu-iotest number 232 when running the test as a root user. Is this the expected behavior? Here is the output of the failure: sudo ./check -qcow2 232 QEMU -- "/home/alifm/kvmdev/qemu/tests/qemu-iotests/../../x86_64-softmmu/qemu-system-x86_64" -nod

Re: [Qemu-devel] [PATCH 3/3] vfio-ccw: add handling for asnyc channel instructions

2018-11-28 Thread Farhan Ali
On 11/28/2018 10:35 AM, Cornelia Huck wrote: On Wed, 28 Nov 2018 10:00:59 -0500 Farhan Ali wrote: On 11/28/2018 09:52 AM, Cornelia Huck wrote: On Wed, 28 Nov 2018 09:31:51 -0500 Farhan Ali wrote: On 11/28/2018 04:02 AM, Cornelia Huck wrote: On Tue, 27 Nov 2018 14:09:49 -0500 Farhan

Re: [Qemu-devel] [PATCH 3/3] vfio-ccw: add handling for asnyc channel instructions

2018-11-28 Thread Farhan Ali
On 11/28/2018 09:52 AM, Cornelia Huck wrote: On Wed, 28 Nov 2018 09:31:51 -0500 Farhan Ali wrote: On 11/28/2018 04:02 AM, Cornelia Huck wrote: On Tue, 27 Nov 2018 14:09:49 -0500 Farhan Ali wrote: On 11/22/2018 11:54 AM, Cornelia Huck wrote: Add a region to the vfio-ccw device that

Re: [Qemu-devel] [PATCH 3/3] vfio-ccw: add handling for asnyc channel instructions

2018-11-28 Thread Farhan Ali
On 11/28/2018 04:02 AM, Cornelia Huck wrote: On Tue, 27 Nov 2018 14:09:49 -0500 Farhan Ali wrote: On 11/22/2018 11:54 AM, Cornelia Huck wrote: Add a region to the vfio-ccw device that can be used to submit asynchronous I/O instructions. ssch continues to be handled by the existing I/O

Re: [Qemu-devel] [PATCH 3/3] vfio-ccw: add handling for asnyc channel instructions

2018-11-27 Thread Farhan Ali
On 11/22/2018 11:54 AM, Cornelia Huck wrote: diff --git a/include/uapi/linux/vfio.h b/include/uapi/linux/vfio.h index 565669f95534..c01472ec77ea 100644 --- a/include/uapi/linux/vfio.h +++ b/include/uapi/linux/vfio.h @@ -304,6 +304,7 @@ struct vfio_region_info_cap_type { #define VFIO_REGION_S

Re: [Qemu-devel] [PATCH 3/3] vfio-ccw: add handling for asnyc channel instructions

2018-11-27 Thread Farhan Ali
On 11/22/2018 11:54 AM, Cornelia Huck wrote: Add a region to the vfio-ccw device that can be used to submit asynchronous I/O instructions. ssch continues to be handled by the existing I/O region; the new region handles hsch and csch. Interrupt status continues to be reported through the same

Re: [Qemu-devel] [PATCH 1/3] vfio-ccw: add capabilities chain

2018-11-27 Thread Farhan Ali
On 11/22/2018 11:54 AM, Cornelia Huck wrote: diff --git a/drivers/s390/cio/vfio_ccw_private.h b/drivers/s390/cio/vfio_ccw_private.h index 078e46f9623d..a6f9f84526e2 100644 --- a/drivers/s390/cio/vfio_ccw_private.h +++ b/drivers/s390/cio/vfio_ccw_private.h @@ -3,9 +3,11 @@ * Private stuff f

Re: [Qemu-devel] [PATCH 0/3] vfio-ccw: support hsch/csch (kernel part)

2018-11-26 Thread Farhan Ali
On 11/22/2018 11:54 AM, Cornelia Huck wrote: [This is the Linux kernel part, git tree is available at https://git.kernel.org/pub/scm/linux/kernel/git/kvms390/vfio-ccw.git vfio-ccw-caps The companion QEMU patches are available at https://github.com/cohuck/qemu vfio-ccw-caps] Currently, vfio-

Re: [Qemu-devel] [PATCH 1/4] MAINTAINERS: s390: more maintainers for vfio-ccw

2018-10-29 Thread Farhan Ali
+++ b/MAINTAINERS @@ -1204,6 +1204,8 @@ F: include/hw/vfio/ vfio-ccw M: Cornelia Huck +M: Eric Farman +M: Farhan Ali S: Supported F: hw/vfio/ccw.c F: hw/s390x/s390-ccw.c Acked-by: Farhan Ali

Re: [Qemu-devel] [RFC v1 1/1] qemu-iotests: Fix output for testcase 082

2018-10-16 Thread Farhan Ali
On 10/15/2018 11:45 AM, Max Reitz wrote: 082 is failing for me on master (046936ed), and this fixes it. I'm wondering if/why other people are not running into this, as 082 runs with qcow2 and is included on `make check-block`. + Max, FIY, I ran into this while reviewing/testing your Python

  1   2   >