Re: BeagleBone support, omap1, omap2, omap3, etc.

2019-12-11 Thread Esteban Bosse
Hello Niek and Philippe, Thank you very much for your support and all the information provided, I will create a new "roadmap" with all this excellent information and try again. Thank you again and best regards, Esteban Bosse El mar., 10 dic. 2019 a las 20:51, Niek Linnenbank (<

Re: BeagleBone support, omap1, omap2, omap3, etc.

2019-12-03 Thread Esteban Bosse
Ping El mié., 6 nov. 2019 16:04, Esteban Bosse escribió: > Hello! > > Some months ago I started to work trying to port the Beaglebone support > from the old qemu-linaro fork to the new QEMU mainstream. > > During my work I found that the Beaglebone have an OMAP3 mpu this mpu

BeagleBone support, omap1, omap2, omap3, etc.

2019-11-06 Thread Esteban Bosse
Hello! Some months ago I started to work trying to port the Beaglebone support from the old qemu-linaro fork to the new QEMU mainstream. During my work I found that the Beaglebone have an OMAP3 mpu this mpu has very strong relation with the OMAP2 and OMAP1 in qemu, they implement a lot of functio

Re: Wiki account

2019-11-04 Thread Esteban Bosse
Thank you very much :) Estebanb El lun., 4 nov. 2019 11:10, Daniel P. Berrangé escribió: > On Sun, Nov 03, 2019 at 11:27:33AM +0100, Esteban Bosse wrote: > > Hello, > > I would like to have an wiki account. > > > > Preferred user: estebanb > > I've

Wiki account

2019-11-03 Thread Esteban Bosse
Hello, I would like to have an wiki account. Preferred user: estebanb Thank you, Esteban Bosse

Re: [RFC PATCH 14/14] hw/arm/raspi: Add the Raspberry Pi 4B board

2019-10-24 Thread Esteban Bosse
El jue, 24-10-2019 a las 10:07 +0100, Peter Maydell escribió: > On Tue, 8 Oct 2019 at 10:04, Philippe Mathieu-Daudé > wrote: > > Hi Esteban, > > > > On 9/29/19 5:53 PM, Esteban Bosse wrote: > > > > +static void raspi4_machine_init(MachineClass *mc) > >

Re: [RFC PATCH 03/14] hw/misc/bcm2835_property: Handle the 'domain state' property

2019-10-24 Thread Esteban Bosse
El mar, 08-10-2019 a las 11:32 +0200, Philippe Mathieu-Daudé escribió: > On 9/29/19 9:01 AM, Esteban Bosse wrote: > > El mié, 04-09-2019 a las 19:13 +0200, Philippe Mathieu-Daudé > > escribió: > > > The kernel is happy with this change, so we don't need > >

Re: [PATCH 15/19] tests/boot_linux_console: Extract the gunzip() helper

2019-10-24 Thread Esteban Bosse
27;) as f_in: > -with open(initrd_path, 'wb') as f_out: > - shutil.copyfileobj(f_in, f_out) > +gunzip(initrd_path_gz, initrd_path) > > self.vm.set_machine('malta') > self.vm.set_console() Reviewed-by: Esteban Bosse

Re: [RFC PATCH 14/14] hw/arm/raspi: Add the Raspberry Pi 4B board

2019-10-24 Thread Esteban Bosse
+mc->no_parallel = 1; > +mc->no_floppy = 1; > +mc->no_cdrom = 1; > + mc->max_cpus = BCM283X_NCPUS; > +mc->min_cpus = BCM283X_NCPUS; > +mc->default_cpus = BCM283X_NCPUS; > +mc->default_ram_size = 1 * GiB; > +} > +DEFINE_MACHINE("raspi4", raspi4_machine_init) > +#endif /* TARGET_AARCH64 */ Reviewed-by: Esteban Bosse

Re: [PATCH v2 03/20] piix4: Add a i8259 Interrupt Controller as specified in datasheet

2019-10-23 Thread Esteban Bosse
El mar, 22-10-2019 a las 11:35 +0200, Philippe Mathieu-Daudé escribió: > On 10/22/19 10:44 AM, Esteban Bosse wrote: > > El vie, 18-10-2019 a las 15:47 +0200, Philippe Mathieu-Daudé > > escribió: > > > From: Hervé Poussineau > > > > > > Add ISA irqs as p

Re: [PATCH v2 03/20] piix4: Add a i8259 Interrupt Controller as specified in datasheet

2019-10-23 Thread Esteban Bosse
El mar, 22-10-2019 a las 10:42 +0100, Peter Maydell escribió: > On Tue, 22 Oct 2019 at 09:52, Esteban Bosse > wrote: > > El vie, 18-10-2019 a las 15:47 +0200, Philippe Mathieu-Daudé > > escribió: > > > +static void piix4_request_i8259_irq(void *opaqu

Re: [PATCH v2 17/20] hw/pci-host/piix: Fix code style issues

2019-10-22 Thread Esteban Bosse
t; +/* > + * Return the global irq number corresponding to a given device irq > + * pin. We could also use the bus number to have a more precise > mapping. > + */ > static int pci_slot_get_pirq(PCIDevice *pci_dev, int pci_intx) > { > int slot_addend; Reviewed-by: Esteban Bosse

Re: [PATCH v2 13/20] hw/pci-host/piix: Extract piix3_create()

2019-10-22 Thread Esteban Bosse
> -PIIX_NUM_PIRQS); > -pci_bus_set_route_irq_fn(b, piix3_route_intx_pin_to_irq); > - } > +piix3 = piix3_create(b, isa_bus); > piix3->pic = pic; > -*isa_bus = ISA_BUS(qdev_get_child_bus(DEVICE(piix3), "isa.0")); > - > *piix3_devfn = piix3->dev.devfn; > > ram_size = ram_size / 8 / 1024 / 1024; Reviewed-by: Esteban Bosse

Re: [PATCH v2 06/20] piix4: Add a i8257 DMA Controller as specified in datasheet

2019-10-22 Thread Esteban Bosse
;hw/boards.h" > @@ -1430,7 +1429,6 @@ void mips_malta_init(MachineState *machine) > smbus = piix4_pm_init(pci_bus, piix4_devfn + 3, 0x1100, >isa_get_irq(NULL, 9), NULL, 0, NULL); > pit = i8254_pit_init(isa_bus, 0x40, 0, NULL); > -i8257_dma_init(isa_bus, 0); > mc146818_rtc_init(isa_bus, 2000, NULL); > > /* generate SPD EEPROM data */ Reviewed-by: Esteban Bosse

Re: [PATCH v2 05/20] piix4: Rename PIIX4 object to piix4-isa

2019-10-22 Thread Esteban Bosse
hw/isa/isa.h > index 018ada4f6f..79f703fd6c 100644 > --- a/include/hw/isa/isa.h > +++ b/include/hw/isa/isa.h > @@ -147,4 +147,6 @@ static inline ISABus > *isa_bus_from_device(ISADevice *d) > return ISA_BUS(qdev_get_parent_bus(DEVICE(d))); > } > > +#define TYPE_PIIX4_PCI_DEVICE "piix4-isa" > + > #endif Reviewed-by: Esteban Bosse

Re: [PATCH v2 04/20] Revert "irq: introduce qemu_irq_proxy()"

2019-10-22 Thread Esteban Bosse
q irq2); > > -/* Returns a new IRQ set which connects 1:1 to another IRQ set, > which > - * may be set later. > - */ > -qemu_irq *qemu_irq_proxy(qemu_irq **target, int n); > - > /* For internal use in qtest. Similar to qemu_irq_split, but > operating > on an existing vector of qemu_irq. */ > void qemu_irq_intercept_in(qemu_irq *gpio_in, qemu_irq_handler > handler, int n); Reviewed-by: Esteban Bosse

Re: [PATCH v2 03/20] piix4: Add a i8259 Interrupt Controller as specified in datasheet

2019-10-22 Thread Esteban Bosse
El vie, 18-10-2019 a las 15:47 +0200, Philippe Mathieu-Daudé escribió: > From: Hervé Poussineau > > Add ISA irqs as piix4 gpio in, and CPU interrupt request as piix4 > gpio out. > Remove i8259 instanciated in malta board, to not have it twice. > > We can also remove the now unused piix4_init() f

Re: [PATCH v2 03/20] piix4: Add a i8259 Interrupt Controller as specified in datasheet

2019-10-22 Thread Esteban Bosse
El vie, 18-10-2019 a las 15:47 +0200, Philippe Mathieu-Daudé escribió: > From: Hervé Poussineau > > Add ISA irqs as piix4 gpio in, and CPU interrupt request as piix4 > gpio out. > Remove i8259 instanciated in malta board, to not have it twice. > > We can also remove the now unused piix4_init() f

Re: [RFC PATCH 14/14] hw/arm/raspi: Add the Raspberry Pi 4B board

2019-09-29 Thread Esteban Bosse
_parallel = 1; > +mc->no_floppy = 1; > +mc->no_cdrom = 1; > +mc->max_cpus = BCM283X_NCPUS; > +mc->min_cpus = BCM283X_NCPUS; > + mc->default_cpus = BCM283X_NCPUS; > +mc->default_ram_size = 1 * GiB; The comercial models are: 1, 2 and 4 GiB. Why do you choose 1 GiB as default? > +} > +DEFINE_MACHINE("raspi4", raspi4_machine_init) > +#endif /* TARGET_AARCH64 */ Reviewed-by: Esteban Bosse

Re: [PATCH 11/14] hw/arm/bcm2835_peripherals: Map various BCM2838 blocks

2019-09-29 Thread Esteban Bosse
0x202000 /* Legacy MMC */ > #define I2S_OFFSET 0x203000 /* PCM */ > #define SPI0_OFFSET 0x204000 /* SPI master */ > +#define SPI3_OFFSET 0x204600 > +#define SPI4_OFFSET 0x204800 > +#define SPI5_OFFSET 0x204a00 > +#define SPI6_OFFSET 0x204c00 > #define BSC0_OFFSET 0x205000 /* BSC0 I2C/TWI */ > +#define BSC3_OFFSET 0x205600 > +#define BSC4_OFFSET 0x205800 > +#define BSC5_OFFSET 0x205a00 > +#define BSC6_OFFSET 0x205c00 > #define PIXV0_OFFSET0x206000 > #define PIXV1_OFFSET0x207000 > #define DPI_OFFSET 0x208000 > @@ -84,6 +96,8 @@ > #define DBUS_OFFSET 0x90 > #define AVE0_OFFSET 0x91 > #define USB_OTG_OFFSET 0x98 /* DTC_OTG USB controller > */ > +#define USB_XHCI_OFFSET 0x9c /* generic-xhci controller > */ > +#define ARGON_OFFSET0xb0 > #define V3D_OFFSET 0xc0 > #define SDRAMC_OFFSET 0xe0 > #define L2CC_OFFSET 0xe01000 /* Level 2 Cache controller > */ Reviewed-by: Esteban Bosse

Re: [PATCH 10/14] hw/arm/raspi: Define various blocks base addresses

2019-09-29 Thread Esteban Bosse
El vie, 06-09-2019 a las 12:07 +0200, Philippe Mathieu-Daudé escribió: > On 9/4/19 7:13 PM, Philippe Mathieu-Daudé wrote: > > The Raspberry firmware is closed-source. While running it, it > > accesses various I/O registers. Logging these accesses as UNIMP > > (unimplemented) help to understand what

Re: [PATCH 08/14] hw/arm/bcm2836: Make the SoC code modular

2019-09-29 Thread Esteban Bosse
836_realize(DeviceState *dev, > Error **errp) > > /* set periphbase/CBAR value for CPU-local registers */ > object_property_set_int(OBJECT(&s->cpus[n]), > -BCM2836_PERI_BASE + MCORE_OFFSET, > +info->peri_base, > "reset-cbar", &err); > if (err) { > error_propagate(errp, err); Reviewed-by: Esteban Bosse

Re: [PATCH 07/14] hw/arm/bcm2835: Add various unimplemented peripherals

2019-09-29 Thread Esteban Bosse
> +#define OTP_OFFSET 0x20f000 > +#define AVSP_OFFSET 0x13 > +#define BSC_SL_OFFSET 0x214000 /* SPI slave */ > #define AUX_OFFSET 0x215000 /* AUX: UART1/SPI1/SPI2 */ > #define EMMC1_OFFSET0x30 > #define SMI_OFFSET 0x60 > #define BSC1_OFFSET 0x804000 /* BSC1 I2C/TWI */ > +#define BSC2_OFFSET 0x805000 /* BSC2 I2C/TWI */ > +#define DBUS_OFFSET 0x90 > +#define AVE0_OFFSET 0x91 > #define USB_OTG_OFFSET 0x98 /* DTC_OTG USB controller > */ > +#define SDRAMC_OFFSET 0xe0 > #define DMA15_OFFSET0xE05000 /* DMA controller, channel > 15 */ > > /* GPU interrupts */ Reviewed-by: Esteban Bosse

Re: [PATCH 06/14] hw/arm/bcm2835: Rename some definitions

2019-09-29 Thread Esteban Bosse
0x30 > +#define AUX_OFFSET 0x215000 /* AUX: UART1/SPI1/SPI2 */ > +#define EMMC1_OFFSET0x30 > #define SMI_OFFSET 0x60 > #define BSC1_OFFSET 0x804000 /* BSC1 I2C/TWI */ > -#define USB_OFFSET 0x98 /* DTC_OTG USB controller > */ > +#define USB_OTG_OFFSET 0x98 /* DTC_OTG USB controller > */ > #define DMA15_OFFSET0xE05000 /* DMA controller, channel > 15 */ > > /* GPU interrupts */ Reviewed-by: Esteban Bosse

Re: [PATCH 05/14] hw/arm/bcm2835_peripherals: Name various address spaces

2019-09-29 Thread Esteban Bosse
mbox_as, s->mbox_mr, NULL); > +address_space_init(&s->mbox_as, s->mbox_mr, TYPE_BCM2835_MBOX "- > memory"); > bcm2835_mbox_reset(dev); > } > > diff --git a/hw/misc/bcm2835_property.c b/hw/misc/bcm2835_property.c > index ab66d3572e..3dff5a7157 100644 > --- a/hw/misc/bcm2835_property.c > +++ b/hw/misc/bcm2835_property.c > @@ -417,7 +417,7 @@ static void bcm2835_property_realize(DeviceState > *dev, Error **errp) > } > > s->dma_mr = MEMORY_REGION(obj); > -address_space_init(&s->dma_as, s->dma_mr, NULL); > +address_space_init(&s->dma_as, s->dma_mr, TYPE_BCM2835_PROPERTY > "-memory"); > > /* TODO: connect to MAC address of USB NIC device, once we > emulate it */ > qemu_macaddr_default_if_unset(&s->macaddr); Reviewed-by: Esteban Bosse

Re: [RFC PATCH 03/14] hw/misc/bcm2835_property: Handle the 'domain state' property

2019-09-29 Thread Esteban Bosse
El mié, 04-09-2019 a las 19:13 +0200, Philippe Mathieu-Daudé escribió: > The kernel is happy with this change, so we don't need > to do anything more sophisticated. > > Reviewed-by: Peter Maydell > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/misc/bcm2835_property.c | 8 > 1 file c

Re: [PATCH 01/14] hw/arm/raspi: Use the IEC binary prefix definitions

2019-09-28 Thread Esteban Bosse
c void raspi3_machine_init(MachineClass *mc) > mc->max_cpus = BCM283X_NCPUS; > mc->min_cpus = BCM283X_NCPUS; > mc->default_cpus = BCM283X_NCPUS; > -mc->default_ram_size = 1024 * 1024 * 1024; > + mc->default_ram_size = 1 * GiB; > } > DEFINE_MACHINE("raspi3", raspi3_machine_init) > #endif Reviewed-by: Esteban Bosse

Re: [PATCH 04/14] hw/arm/bcm2835_peripherals: Improve logging

2019-09-27 Thread Esteban Bosse
El mié., 4 sept. 2019 a las 19:13, Philippe Mathieu-Daudé () escribió: > Various logging improvements as once: > - Use 0x prefix for hex numbers > - Display value written during write accesses > - Move some logs from GUEST_ERROR to UNIMP > > Signed-off-by: Philippe Mathieu-Daudé > --- > v2: Use P

Re: [RFC PATCH 03/14] hw/misc/bcm2835_property: Handle the 'domain state' property

2019-09-27 Thread Esteban Bosse
Searching this property in the kernel, I found a lot of properties not implemented. https://github.com/raspberrypi/linux/blob/rpi-4.19.y/include/soc/bcm2835/raspberrypi-firmware.h#L41 Are the properties only added when they are necessaries for the standard kernel use? Reviewed-by: EstebanB El mié

Re: [PATCH 01/14] hw/arm/raspi: Use the IEC binary prefix definitions

2019-09-27 Thread Esteban Bosse
Reviewed-by: Esteban El mié., 4 sept. 2019 a las 19:13, Philippe Mathieu-Daudé () escribió: > IEC binary prefixes ease code review: the unit is explicit. > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/arm/raspi.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a