On Tue, 2025-07-15 at 10:26 +0100, Mark Cave-Ayland wrote:
> Use QOM casts to cast to VFIOPCIDevice instead of using container_of().
>
> Signed-off-by: Mark Cave-Ayland
> ---
> hw/s390x/s390-pci-vfio.c | 14 +++---
> 1 file changed, 7 insertions(+), 7 deletions(-)
em
> unfixed in the "loadparm" device property. Fix it.
>
> Signed-off-by: Kevin Wolf
> ---
> hw/s390x/ccw-device.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Farman
On Mon, 2025-06-23 at 12:00 -0400, Matthew Rosato wrote:
> To improve review coverage, assign additional people as reviewers for
> multiple s390 sections.
>
> Signed-off-by: Matthew Rosato
Acked-by: Eric Farman
> ---
> MAINTAINERS | 12
> 1 file c
On Tue, 2025-06-10 at 08:39 -0700, Steve Sistare wrote:
> Define vfio_device_free_name to free the name created by
> vfio_device_get_name. A subsequent patch will do more there.
> No functional change.
>
> Signed-off-by: Steve Sistare
> ---
> include/hw/vfio/vfio-device.h | 1 +
> hw/vfio/ap.c
set
Ah, I was wondering about this part in particular before you'd sent this v2, so
now my question is
moot.
For the series:
Reviewed-by: Eric Farman
>
> Thomas Huth (9):
> hw/s390x/s390-virtio-ccw: Remove the deprecated 2.10 machine type
> hw/s390x/s390-virtio-ccw: Remov
On Wed, 2025-04-23 at 17:45 -0400, Rorie Reyes wrote:
> Kernel commit 8a14 changed from using ASSEMBLY to ASSEMBLER
Kernel commit 8a141be3233a ("x86/headers: Replace __ASSEMBLY__ with
__ASSEMBLER__ in UAPI headers")
> Updated the update-linux-header script to match
>
> Signed-off-by: Rorie Reye
k
> is provided.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> include/hw/s390x/storage-keys.h | 15 +++
> hw/s390x/s390-skeys.c | 5 +
> 2 files changed, 20 insertions(+)
Reviewed-by: Eric Farman
> 2 files changed, 1 insertion(+), 3 deletions(-)
Fine squashed with patch 5 or not...
Reviewed-by: Eric Farman
gt; include/hw/s390x/storage-keys.h | 1 +
> hw/s390x/s390-skeys.c | 7 ++-
> hw/s390x/s390-virtio-ccw.c | 3 +++
> 3 files changed, 10 insertions(+), 1 deletion(-)
Reviewed-by: Eric Farman
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/s390x/s390-skeys.c | 39 +--
> 1 file changed, 17 insertions(+), 22 deletions(-)
Reviewed-by: Eric Farman
t; Suggested-by: Thomas Huth
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> target/s390x/cpu.h | 4
> target/s390x/cpu_models.h | 3 +++
> hw/s390x/s390-virtio-ccw.c | 2 +-
> 3 files changed, 4 insertions(+), 5 deletions(-)
(resending with reply-all)
Reviewed-by: Eric Farman
On Fri, 2025-02-14 at 17:19 +0100, Cédric Le Goater wrote:
> Use the common helper warn_report_once() instead of implementing its
> own.
>
> Cc: Eric Farman
> Signed-off-by: Cédric Le Goater
> ---
> hw/vfio/ccw.c | 12 ++--
> 1 file changed, 2 insertions(+), 1
gt;
> Sort the properties based on the QEMU version in which they were
> introduced.
>
> Cc: Tony Krowiak
> Cc: Eric Farman
> Cc: Eric Auger
> Signed-off-by: Cédric Le Goater
> ---
>
> Should we introduce documentation for properties like the kernel has
> in D
On Fri, 2025-01-24 at 09:49 +0100, Cédric Le Goater wrote:
> On 1/14/25 20:55, Eric Farman wrote:
> > On Tue, 2025-01-14 at 13:51 -0500, Rorie Reyes wrote:
> > > On 1/8/25 2:29 AM, Cédric Le Goater wrote:
> > > > Hello Rorie,
> > > >
> > > &
irtio device
> pc-bios/s390-ccw: Fix boot problem with virtio-net devices
> pc-bios/s390-ccw/netmain: Fix error messages with regards to the TFTP
> server
Looks good to me; Thank you, Thomas! For the series:
Reviewed-by: Eric Farman
>
> pc-bios/s390-ccw/virtio.h
On Tue, 2025-01-14 at 13:51 -0500, Rorie Reyes wrote:
> On 1/8/25 2:29 AM, Cédric Le Goater wrote:
> > Hello Rorie,
> >
> > On 1/7/25 19:43, Rorie Reyes wrote:
> > > This patch adds enumeration constant VFIO_AP_CFG_CHG_IRQ_INDEX to
> > > specify
> > > an IRQ index for signaling that a change has
irtio-ccw-scsi.c| 2 +-
> hw/s390x/virtio-ccw-serial.c | 2 +-
> 20 files changed, 20 insertions(+), 20 deletions(-)
Reviewed-by: Eric Farman
On Fri, 2024-12-13 at 13:29 -0600, Richard Henderson wrote:
> Signed-off-by: Richard Henderson
> ---
> hw/vfio/ap.c | 2 +-
> hw/vfio/ccw.c | 2 +-
> hw/vfio/pci.c | 4 ++--
> hw/vfio/platform.c | 2 +-
> 4 files changed, 5 insertions(+), 5 deletions(-)
Reviewed-by: Eric Farman
gt; hw/scsi/scsi-disk.c | 43 +
> > 4 files changed, 78 insertions(+), 13 deletions(-)
>
> If there are no objections, I'll pick this up for my pull request for QEMU
> 9.2-rc1.
Hi Thomas,
Jared was out Friday so I'm hoping he can give it a look over today, but no
objections from me:
Acked-by: Eric Farman
aphic -m 1234K
> qemu-system-s390x: ram size must be multiples of 1 MiB
>
> Signed-off-by: David Hildenbrand
> ---
> hw/s390x/s390-virtio-ccw.c | 11 +++
> 1 file changed, 11 insertions(+)
TIL. Thanks David!
Reviewed-by: Eric Farman
Huth
> Signed-off-by: Pierrick Bouvier
> ---
> include/hw/s390x/cpu-topology.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Farman
On Mon, 2024-07-22 at 17:36 +0200, Cédric Le Goater wrote:
> On 7/22/24 17:09, Joao Martins wrote:
> > On 22/07/2024 15:57, Eric Farman wrote:
> > > On Mon, 2024-07-22 at 15:07 +0800, Zhenzhong Duan wrote:
> > > > mdevs aren't "physical" devices and w
On Mon, 2024-07-22 at 15:07 +0800, Zhenzhong Duan wrote:
> mdevs aren't "physical" devices and when asking for backing IOMMU info,
> it fails the entire provisioning of the guest. Fix that by setting
> vbasedev->mdev true so skipping HostIOMMUDevice initialization in the
> presence of mdevs.
Hmm,
to me over the weekend, but
all-in-all I like the looks of this. So, FWIW:
Reviewed-by: Eric Farman
>
> Thomas Huth (7):
> pc-bios/s390-ccw: Remove duplicated LDFLAGS
> hw/s390x/ipl: Provide more memory to the s390-ccw.img firmware
> pc-bios/s390-ccw: Use the libc from SLOF for
On Mon, 2024-05-27 at 14:13 +0200, Thomas Huth wrote:
> It's not used anywhere, so let's simply remove it.
>
> Signed-off-by: Thomas Huth
> ---
> include/hw/s390x/s390_flic.h | 3 ---
> 1 file changed, 3 deletions(-)
Reviewed-by: Eric Farman
gt; hw/s390x/ccw-device.c | 3 ++-
> hw/s390x/s390-ccw.c | 29 +
> hw/vfio/ap.c | 2 +-
> hw/vfio/ccw.c | 18 --
> 6 files changed, 26 insertions(+), 30 deletions(-)
>
Reviewed-by: Eric Farman
e other devices of type TYPE_SCLP_EVENT already reside.
>
> Signed-off-by: Thomas Huth
> ---
> hw/s390x/s390-virtio-ccw.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
Reviewed-by: Eric Farman
ier(vcdev,
> > VFIO_CCW_REQ_IRQ_INDEX, &err)) {
> > /*
> > * Report this error, but do not make it a failing
> > condition.
> > * Lack of this IRQ in the host does not prevent normal
> > operation.
> */
> error_report_err(err);
>
> Not this patch's problem, but here goes anyway: since this isn't an
> error, we shouldn't use error_report_err(). Would warn_report_err()
> be
> appropriate? info_report_err() doesn't exist, but it could.
>
> Preferably with errp instead of &err (two times):
> Reviewed-by: Markus Armbruster
>
Don't recall why I used error_report_err() instead of something else
(or creating info_), but probably just familiarity. There's no need for
it (or the equivalent code in -ap) to be error, and could be another
cleanup.
Reviewed-by: Eric Farman
Reviewed-by: Eric Farman
^
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/s390x/s390-virtio-hcall.h | 2 ++
> hw/s390x/s390-stattrib.c | 1 +
> 2 files changed, 3 insertions(+)
These aren't the only implicit users of cpu.h in hw/s390x/ but if this
solves one problem, then that's good.
Acked-by: Eric Farman
d to virtio-pci devices.
> >
> > Acked-by: Thomas Huth
> > Signed-off-by: Jonah Palmer
> > ---
> > hw/s390x/s390-virtio-ccw.c | 16
> > 1 file changed, 12 insertions(+), 4 deletions(-)
Acked-by: Eric Farman
(I see a v2 is coming for the ioeventfd side, but I was going through
this series today and thought that would affect the next patch rather
than this one.)
hat method
> in the hold phase of 3-phase reset.
>
> Signed-off-by: Peter Maydell
> ---
> hw/s390x/css-bridge.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
Reviewed-by: Eric Farman
i-bus.c | 26 +-
> hw/s390x/s390-virtio-ccw.c | 8
> include/hw/s390x/s390-pci-bus.h | 1 +
> 3 files changed, 26 insertions(+), 9 deletions(-)
Thanks for the reminder on ISM/interpretation in v1.
Reviewed-by: Eric Farman
On Tue, 2024-01-16 at 17:31 -0500, Matthew Rosato wrote:
> ISM devices are sensitive to manipulation of the IOMMU, so the ISM
> device
> needs to be reset before the vfio-pci device is reset (triggering a
> full
> UNMAP). In order to ensure this occurs, trigger ISM device resets
> from
> subsystem
++-
> 1 file changed, 10 insertions(+), 1 deletion(-)
Reviewed-by: Eric Farman
> struct kvm_s390_zpci_op args = {
> .fh = pbdev->fh,
> .op = KVM_S390_ZPCIOP_DEREG_AEN
> };
>
> - return kvm_vm_ioctl(kvm_state, KVM_S390_ZPCI_OP, &args);
> + if (!pbdev->aif) {
> + return -EINVAL;
lpcpu.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Reviewed-by: Eric Farman
mail.com/
>
> ---
> Zhao Liu (2):
> hw/s390x/ccw: Replace basename() with g_path_get_basename()
> hw/s390x/ccw: Replace dirname() with g_path_get_dirname()
>
> hw/s390x/s390-ccw.c | 7 +--
> 1 file changed, 5 insertions(+), 2 deletions(-)
>
Reviewed-by: Eric Farman
above caught my attention, so I kicked the tires on this series a
little bit both with an iommufd-enabled host kernel and without, so I
don't lose track of it over the holidays.
Tested-by: Eric Farman
On Tue, 2023-12-12 at 12:36 +0100, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/s390x/ipl.c | 1 -
> 1 file changed, 1 deletion(-)
>
>
Yup, this appears no longer relevant since commit 3549118b4988
Reviewed-by: Eric Farman
On Tue, 2023-12-12 at 14:08 +0100, Christian Borntraeger wrote:
>
>
> Am 12.12.23 um 12:36 schrieb Philippe Mathieu-Daudé:
> > Signed-off-by: Philippe Mathieu-Daudé
> > ---
> > hw/s390x/ipl.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c
> > in
> - void qemu_bql_unlock(void)
> - bool qemu_bql_locked(void)
>
> There are more APIs with "iothread" in their names. Subsequent
> patches
> will rename them. There are also comments and documentation that will
> be
> updated in later patches.
>
> Signed-off-by: Stefan Hajnoczi
Acked-by: Eric Farman
| 3 +++
> include/hw/i386/pc.h | 3 +++
> 10 files changed, 80 insertions(+), 9 deletions(-)
Acked-by: Eric Farman # s390x
---
> hw/vfio/ap.c | 26 +-
> 1 file changed, 13 insertions(+), 13 deletions(-)
Reviewed-by: Eric Farman
gt; ---
> hw/vfio/ccw.c | 30 +++---
> 1 file changed, 15 insertions(+), 15 deletions(-)
Reviewed-by: Eric Farman
On Tue, 2023-11-14 at 18:09 +0800, Zhenzhong Duan wrote:
> From: Cédric Le Goater
>
> Signed-off-by: Cédric Le Goater
> Signed-off-by: Zhenzhong Duan
> Reviewed-by: Matthew Rosato
> ---
> hw/s390x/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Eric Farman
ufd object id in the vfio-ccw device options:
>
> -object iommufd,id=iommufd0
> -device vfio-ccw,sysfsdev=/sys/bus/mdev/devices/XXX,iommufd=iommufd0
>
> Suggested-by: Alex Williamson
> Signed-off-by: Zhenzhong Duan
> Reviewed-by: Matthew Rosato
> ---
> hw/vfio/ccw.c | 6 ++
> 1 file changed, 6 insertions(+)
Reviewed-by: Eric Farman
uan
> Reviewed-by: Matthew Rosato
> ---
> hw/vfio/ccw.c | 25 ++---
> 1 file changed, 22 insertions(+), 3 deletions(-)
Reviewed-by: Eric Farman
s390x/pci: only limit DMA aperture if vfio DMA limit reported
>
> hw/s390x/s390-pci-vfio.c | 6 +-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
Apologies for missing v1 while I was out, but FWIW, for the series:
Reviewed-by: Eric Farman
On Tue, 2023-11-07 at 10:45 +0100, Thomas Huth wrote:
> On 02/11/2023 19.50, Eric Farman wrote:
> > (+cc qemu-devel)
> >
> > On Tue, 2023-10-24 at 12:07 +0200, Heiko Carstens wrote:
> > > Qemu's SCLP implementation incorrectly reports that it supports
> >
NFO mask, and remove the unused
> SCLP_CMDW_CONFIGURE_CPU and SCLP_CMDW_DECONFIGURE_CPU defines.
>
> Reviewed-by: Eric Farman
> Reviewed-by: Halil Pasic
> Signed-off-by: Heiko Carstens
> ---
> include/hw/s390x/sclp.h | 4 +---
> 1 file changed, 1 insertion(+), 3 deleti
> -
> hw/vfio/helpers.c | 1 -
> 7 files changed, 99 insertions(+), 110 deletions(-)
> delete mode 100644 include/hw/vfio/vfio.h
Can't speak to the code movement, but removing the header file from
those places where it's not used is fine.
Acked-by: Eric Farman
On Thu, 2023-10-19 at 09:16 +0200, Philippe Mathieu-Daudé wrote:
> qbus_new() should not be called on unrealized device.
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/s390x/css-bridge.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
Reviewed-by: Eric Farman
t call register_savevm_live() during
> instance_init()
>
> hw/s390x/s390-skeys.c | 35 ++
> hw/s390x/s390-stattrib.c | 54 +++---
> --
> 2 files changed, 28 insertions(+), 61 deletions(-)
Man, this makes it a lot easier to read too. With the amended patch 3:
Reviewed-by: Eric Farman
These are simple typos, since the directories don't exist but the
files themselves do in hw/s390x/
Fixes: 56e3483402 ("MAINTAINERS: split out s390x sections")
Signed-off-by: Eric Farman
---
MAINTAINERS | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
^
> hw/s390x/sclpquiesce.c:86:3: note: previous declaration is here
> } qn;
> ^
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/s390x/sclpquiesce.c | 8
> 1 file changed, 4 insertions(+), 4 deletions(-)
Reviewed-by: Eric Farman
On Mon, 2023-10-09 at 10:20 +0800, Zhenzhong Duan wrote:
> No functional changes.
>
> Signed-off-by: Zhenzhong Duan
I see Cedric has already queued this, but FWIW:
Reviewed-by: Eric Farman
> ---
> include/hw/s390x/vfio-ccw.h | 2 --
> 1 file changed, 2 deletions(-)
>
&
510143925.4094-4-quint...@redhat.com>
>
> pc-bios/s390-ccw/cio.h | 232 ++
> --
> pc-bios/s390-ccw/s390-ccw.h | 4 -
> 2 files changed, 116 insertions(+), 120 deletions(-)
Thanks for the based-on hint.
Reviewed-by: Eric Farman
d.
>
> Fix it by using the real start address of the .bss section instead.
>
> Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2216662
> Reported-by: Miroslav Rezanina
> Suggested-by: Nick Clifton
> Signed-off-by: Thomas Huth
> ---
> pc-bios/s390-ccw/start.S | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Eric Farman
for aligning it to page
> boundaries.
>
> Signed-off-by: Thomas Huth
> ---
> pc-bios/s390-ccw/s390-ccw.h | 1 -
> pc-bios/s390-ccw/main.c | 1 -
> pc-bios/s390-ccw/netmain.c | 1 -
> pc-bios/s390-ccw/start.S | 6 ++
> 4 files changed, 6 insertions(+), 3 deletions(-)
Reviewed-by: Eric Farman
rl %r15,stack + STACK_SIZE - 160 /* Set up stack */
> > ^^^
> > You can also add a macro
> > for this
> > - e.g. STACK_FRAME_SIZE.
>
> Yes please :) No need to respin.
>
> Reviewed-by: Philippe Mathieu-Daudé
>
> > Besides that,
> > Reviewed-by: Marc Hartmayer
> =
Ditto :)
Reviewed-by: Eric Farman
g/s390x/ folder already, so let's adjust start.S accordingly.
>
> Reviewed-by: Cédric Le Goater
> Signed-off-by: Thomas Huth
> ---
> pc-bios/s390-ccw/start.S | 136 +++--
> --
> 1 file changed, 68 insertions(+), 68 deletions(-)
Oh, that
On Fri, 2023-03-03 at 13:38 +0100, Thomas Huth wrote:
> On 21/02/2023 18.45, jro...@linux.ibm.com wrote:
> > From: Jared Rossi
> >
> > Check for a List Directed IPL Boot Record, which would supersede
> > the CCW type
> > entries. If the record is valid, proceed to use the new style
> > pointers
On Mon, 2023-02-13 at 18:01 +0100, Philippe Mathieu-Daudé wrote:
> QOM parenthood relationship is:
>
> VFIOCCWDevice -> S390CCWDevice -> CcwDevice -> DeviceState
>
> No need to double-cast, call CCW_DEVICE() on VFIOCCWDevice.
>
> Signed-off-by: Philippe Mat
On Mon, 2023-02-13 at 18:01 +0100, Philippe Mathieu-Daudé wrote:
> 'cdev' is VFIOCCWDevice's private parent object.
> Access it using the S390_CCW_DEVICE() QOM macro.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Eric Farman
> ---
> hw/vfio/ccw.c |
pe Mathieu-Daudé
Reviewed-by: Eric Farman
> ---
> hw/vfio/ccw.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c
> index 0354737666..503de94ce1 100644
> --- a/hw/vfio/ccw.c
> +++ b/hw/vfio/ccw.c
> @@ -618,7 +
On Mon, 2023-02-13 at 17:10 +0100, Philippe Mathieu-Daudé wrote:
> On 13/2/23 16:51, Philippe Mathieu-Daudé wrote:
> > On 13/2/23 16:29, Eric Farman wrote:
> > > On Mon, 2023-02-13 at 08:08 +0100, Philippe Mathieu-Daudé wrote:
> > > > Use the VFIO_CCW() QO
On Mon, 2023-02-13 at 08:08 +0100, Philippe Mathieu-Daudé wrote:
> Use the VFIO_CCW() QOM type-checking macro to avoid DO_UPCAST().
>
> Signed-off-by: Philippe Mathieu-Daudé
> ---
> hw/vfio/ccw.c | 35 ---
> 1 file changed, 16 insertions(+), 19 deletions(-)
>
> d
On Mon, 2023-02-13 at 08:08 +0100, Philippe Mathieu-Daudé wrote:
> Use the SCLP_EVENT() QOM type-checking macro to avoid DO_UPCAST().
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Eric Farman
> ---
> hw/s390x/event-facility.c | 3 +--
> 1 file changed, 1 inserti
On Mon, 2023-02-13 at 08:08 +0100, Philippe Mathieu-Daudé wrote:
> Signed-off-by: Philippe Mathieu-Daudé
Acked-by: Eric Farman
> ---
> hw/s390x/ipl.c | 7 ++-
> hw/scsi/scsi-bus.c | 2 +-
> include/hw/scsi/scsi.h | 5 -
> 3 files changed, 3 insertion
egion_ function s390 calls that isn't already
in memory.h, so makes sense to me.
Reviewed-by: Eric Farman
> ---
> hw/s390x/s390-pci-inst.c | 2 +-
> include/exec/memory-internal.h | 4
> include/exec/memory.h | 4
> 3 files changed, 5 insertions(+), 5
5d0e7942d3b ("s390x/pci: don't fence interpreted devices
> without MSI-X")
> Signed-off-by: Matthew Rosato
I realize Thomas already queued this, but for the record:
Reviewed-by: Eric Farman
> ---
> hw/s390x/s390-pci-bus.c | 28
> h
er be used anway, and
> makes exhausting the vfio DMA limit due to mismatch between guest
> aperture size and host limit far less likely and more indicitive
> of an error.
>
> Signed-off-by: Matthew Rosato
Reviewed-by: Eric Farman
> ---
> hw/s390x/s390-pci-vfio.c | 11 +
+ /* Unleash the coalesced unmap before processing a new
> map */
> + s390_pci_batch_unmap(iommu, iova, coalesce);
> + coalesce = 0;
> + }
> +
> start += entry.len;
> while (entry.iova < start && entry.iova <
UFF_RES).
>
> Link:
> https://lore.kernel.org/linux-s390/20221019144435.369902-1-schne...@linux.ibm.com/
> Fixes: 37fa32de70 ("s390x/pci: Honor DMA limits set by vfio")
> Reported-by: Niklas Schnelle
> Signed-off-by: Matthew Rosato
Reviewed-by: Eric Farman
> ---
> hw/s390
Peter Jin
We've talked previously about clearing this within the
do_subchannel_work_passthrough routine in order to keep the _virtual
paths untouched, but this seems like a reasonable approach to me.
The commit message is probably fine either way, but as far as the code
goes:
Reviewe
od medicine. :)
>
> > Fixes: 5447de2619 ("pc-bios/s390-ccw/virtio-blkdev: Remove
> > virtio_assume_scsi()")
> > Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=2112303
> > Signed-off-by: Thomas Huth
> > ---
> > pc-bios/s390-ccw/virtio-blkdev.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
>
> Looks sane to me.
>
> Reviewed-by: Cornelia Huck
>
Reviewed-by: Eric Farman
s at the device type already anyway, so it's more
> logical to separate the virtio-scsi stuff into a new function in
> virtio-scsi.c instead.
>
> Signed-off-by: Thomas Huth
I think this is a good untangling.
Reviewed-by: Eric Farman
> ---
> pc-bios/s390-ccw/virtio-scsi.
lock (i.e. network) devices, too.
>
> Signed-off-by: Thomas Huth
Reviewed-by: Eric Farman
> ---
> pc-bios/s390-ccw/virtio.c | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/pc-bios/s390-ccw/virtio.c b/pc-bios/s390-ccw/virtio.c
> index d8c2b52
a little bit
> (the code is nowadays used for non-block virtio devices, too).
>
> Signed-off-by: Thomas Huth
Reviewed-by: Eric Farman
> ---
> pc-bios/s390-ccw/virtio.c | 7 +++
> 1 file changed, 3 insertions(+), 4 deletions(-)
>
> diff --git a/pc-bios/s390-ccw/
nce there is another spot in main.c
> that does "IPL_assert(virtio_ipl_disk_is_valid(), ...)" to make
> sure that we do not try to IPL from an invalid device.
>
> Signed-off-by: Thomas Huth
Agreed.
Reviewed-by: Eric Farman
> ---
> pc-bios/s390-ccw/virtio.h|
gt; only such a limited disk geometry (like a block size of 512) for
> our boot disks. Let's relax the check and allow everything that
> remotely looks like a sane disk.
This indeed corrects that problem (thank you!), and I really don't
understand why we'd want to limit th
On Tue, 2022-06-28 at 15:10 +0200, Thomas Huth wrote:
> The logic of trying an final ISO or ECKD boot on virtio-block devices
> is
> very weird: Since the geometry hardly ever matches in
> virtio_disk_is_scsi(),
> virtio_blk_setup_device() always sets a "guessed" disk geometry via
> virtio_assume_s
ig.blk.blk_size = 4096;
> > +vdev->config.blk.blk_size = VIRTIO_DASD_BLOCK_SIZE;
> > break;
> > case VIRTIO_ID_SCSI:
> > vdev->config.blk.blk_size = vdev->scsi_block_size;
>
> Unrelated to this change, but can't dasd be formatted with other
> block
> sizes as well?
True. I'd guess it's unlikely that anyone is jumping through those
hoops, though.
This is fine.
Reviewed-by: Eric Farman
>
turn type of main() as "void".
>
> Reviewed-by: Cornelia Huck
> Signed-off-by: Thomas Huth
Reviewed-by: Eric Farman
> ---
> pc-bios/s390-ccw/s390-ccw.h | 1 +
> pc-bios/s390-ccw/main.c | 3 +--
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> d
ice. The s390-ccw bios skipped these steps so far and seems
> like QEMU never cared. Anyway, it's better to follow the spec, so
> let's set these bits now in the right spots, too.
>
> Signed-off-by: Thomas Huth
Reviewed-by: Eric Farman
> ---
> pc-bios/s390-ccw/virt
rnel.org/r/d8d2bbd5021076bdba444d31a6da74f507baede3.ca...@linux.ibm.com/
[2] https://lore.kernel.org/r/87k0c4gb9f@redhat.com/
Signed-off-by: Eric Farman
---
MAINTAINERS | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index dff0200f70..77238c9338 10
g_date_time_new_now_utc() routine to create the GDateTime object.
This fixes a userspace fault seen when messages get sent to monitor,
such as when a guest is destroyed.
Fixes: 73dab893b569 ("error-report: replace deprecated g_get_current_time()
with glib >= 2.62")
Signed-off-by: Eric Farman
--
index 00..b68d1c
> --- /dev/null
> +++ b/hw/s390x/vhost-scsi-ccw.c
Entries exist in the "virtio-ccw" section of MAINTAINERS for the two
vhost files that live in hw/s390x/ today (also covered by the wildcard
entry for vhost). I'd guess this means we should add another
| 3 +++
> include/hw/i386/pc.h | 3 +++
> 10 files changed, 79 insertions(+), 7 deletions(-)
>
For s390x:
Reviewed-by: Eric Farman
..snip...
After the recent restructuring, I'd like to volunteer to help
in some of the s390 I/O areas.
Built on "[PATCH RFC v2] MAINTAINERS: split out s390x sections"
Signed-off-by: Eric Farman
---
MAINTAINERS | 3 +++
1 file changed, 3 insertions(+)
diff --git a/MAINTAINERS b/MA
On Wed, 2022-01-12 at 11:23 +0100, Cornelia Huck wrote:
> On Wed, Jan 05 2022, Eric Farman wrote:
>
> > On Wed, 2021-12-22 at 11:55 +0100, Cornelia Huck wrote:
> > > Split out some more specialized devices etc., so that we can
> > > build
> > > smarter
rntraeger
> Acked-by: Thomas Huth
> Acked-by: Halil Pasic
> Signed-off-by: Cornelia Huck
(Late to the party, Happy New Year!) I like the rearrangement:
Acked-by: Eric Farman
Of course, you also said in v1:
"""
- The new sections have inherited the maintainers of
/2029214327.2367026-1-far...@linux.ibm.com/
Eric Farman (1):
s390x: sigp: Reorder the SIGP STOP code
target/s390x/sigp.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
--
2.32.0
Let's wait to mark the VCPU STOPPED until the possible
STORE STATUS operation is completed, so that we know the
CPU is fully stopped and done doing anything. (When we
also clear the possible sigp_order field for STOP orders.)
Suggested-by: David Hildenbrand
Signed-off-by: Eric F
On Fri, 2021-12-03 at 09:27 -0500, Matthew Rosato wrote:
> The DTSM is a mask that specifies which I/O Address Translation
> designation
> types are supported. Today QEMU only supports DT=1.
>
> Signed-off-by: Matthew Rosato
Reviewed-by: Eric Farman
> ---
> hw
rts.
>
> Signed-off-by: Matthew Rosato
Also good.
Reviewed-by: Eric Farman
> ---
> hw/s390x/s390-pci-bus.c | 1 +
> hw/s390x/s390-pci-vfio.c| 1 +
> include/hw/s390x/s390-pci-bus.h | 1 +
> include/hw/s390x/s390-pci-clp.h | 3 ++-
> 4 files changed, 5
use a PCI Group structure")
> Signed-off-by: Matthew Rosato
Reviewed-by: Eric Farman
> ---
> hw/s390x/s390-pci-inst.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c
> index 11b7f6bfa1
igned-off-by: Matthew Rosato
Reviewed-by: Eric Farman
> ---
> hw/s390x/s390-pci-inst.c | 9 +
> 1 file changed, 5 insertions(+), 4 deletions(-)
>
> diff --git a/hw/s390x/s390-pci-inst.c b/hw/s390x/s390-pci-inst.c
> index 1c8ad91175..11b7f6bfa1 100644
> --- a/hw/s390x
simulated
> devices.
>
> Fixes: 28dc86a072 ("s390x/pci: use a PCI Group structure")
> Signed-off-by: Matthew Rosato
Regardless of the question regarding virtio migration, this is good.
Reviewed-by: Eric Farman
> ---
> include/hw/s390x/s390-pci-bus.h | 2 +-
> 1 fi
1 - 100 of 330 matches
Mail list logo
