Hi,
I've noticed what I believe to be an error in the RISC-V
implementation. The RISC-V spec[1] states:
Note that load and load-reserved instructions generate load
exceptions, whereas store, storeconditional, and AMO instructions
generate store/AMO exceptions.
For an AMO operation, a transla
Thank you!
Eric
On Tuesday, May 14, 2024 at 12:19:55 AM CDT, Alistair Francis
wrote:
On Thu, Apr 4, 2024 at 5:02 AM Eric DeVolder wrote:
>
> I've been using QEMU8 to collect instruction information on U-Boot + OpenSBI.
>
> I'm running QEMU in this fashion to c
I've been using QEMU8 to collect instruction information on U-Boot + OpenSBI.
I'm running QEMU in this fashion to collect the information:
# qemu-system-riscv64 -plugin file=qemu/build/contrib/plugins/libexeclog.so
-singlestep -d plugin,nochain -D execlog.txt ...
When examining the instruction
Following the guidelines in tests/qtest/bios-tables-test.c,
set up bios-tables-test-allowed-diff.h to ignore the
imminent changes to the APIC tables, per step 2.
Signed-off-by: Eric DeVolder
---
tests/qtest/bios-tables-test-allowed-diff.h | 14 ++
1 file changed, 14 insertions
Currently i386 QEMU generates MADT revision 3, and reports
MADT revision 1. Set .revision to 3 to match reality.
Link: https://lore.kernel.org/linux-acpi/20230327191026.3454-1-eric.devolder@ora
cle.com/T/#t
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
hw/i386/acpi-common.c | 2 +-
1
D 00 02 0A 00 09 09 00 00 00 0D 00 02 0A //
0060: 00 0A 0A 00 00 00 0D 00 02 0A 00 0B 0B 00 00 00 //
0070: 0D 00 04 06 FF 00 00 01 //
Signed-off-by: Eric DeVolder
---
tests/data/acpi/microvm/APIC | Bin
ved to 3.
So, set the MADT revision to 3.
Regards,
Eric
---
v2: 17may2023
- Fix problems with the binary tables for the bios-tables-test.c
and make check.
v1: 15may2023
- initial
---
Eric DeVolder (3):
ACPI: bios-tables-test.c step 2 (allowed-diff entries)
ACPI: i386: bump to MADT to rev
On 5/16/23 07:51, Ani Sinha wrote:
On Tue, May 16, 2023 at 6:01 PM Igor Mammedov wrote:
On Mon, 15 May 2023 16:33:10 -0400
Eric DeVolder wrote:
Currently i386 QEMU generates MADT revision 3, and reports
MADT revision 1. Set .revision to 3 to match reality.
Link: https://lore.kernel.org
..
0050: 00 00 0D 00 02 0A 00 09 09 00 00 00 0D 00 02 0A //
0060: 00 0A 0A 00 00 00 0D 00 02 0A 00 0B 0B 00 00 00 //
0070: 0D 00 04 06 FF 00 00 01 //
Signed-off-by: Eric DeVolder
---
tests/data
ved to 3.
So, set the MADT revision to 3.
Regards,
Eric
---
Eric DeVolder (3):
ACPI: bios-tables-test.c step 2 (allowed-diff entries)
ACPI: i386: bump to MADT to revision 3
ACPI: bios-tables-test.c step 5 (update expected table binaries)
hw/i386/acpi-common.c
Following the guidelines in tests/qtest/bios-tables-test.c,
set up bios-tables-test-allowed-diff.h to exclude the
imminent changes to the APIC tables, per step 2.
Signed-off-by: Eric DeVolder
---
tests/qtest/bios-tables-test-allowed-diff.h | 4
1 file changed, 4 insertions(+)
diff --git a
Currently i386 QEMU generates MADT revision 3, and reports
MADT revision 1. Set .revision to 3 to match reality.
Link: https://lore.kernel.org/linux-acpi/20230327191026.3454-1-eric.devolder@ora
cle.com/T/#t
Signed-off-by: Eric DeVolder
---
hw/i386/acpi-common.c | 2 +-
1 file changed, 1
On 5/10/23 10:45, Igor Mammedov wrote:
On Wed, 10 May 2023 10:08:50 -0500
Eric DeVolder wrote:
On 5/10/23 03:14, Igor Mammedov wrote:
On Fri, 5 May 2023 16:53:22 -0500
Eric DeVolder wrote:
Thoughts?
I still don't think we need to bump x86 to rev 5 in QEMU.
Linux v6.3 has th
On 5/10/23 03:14, Igor Mammedov wrote:
On Fri, 5 May 2023 16:53:22 -0500
Eric DeVolder wrote:
Thoughts?
I still don't think we need to bump x86 to rev 5 in QEMU.
Linux v6.3 has the fix merged (so crisis averted 8).
The investigation allowed me to opportunistically provide this pat
Thoughts?
eric
On 4/21/23 16:48, Eric DeVolder wrote:
The following Linux kernel change broke CPU hotplug for MADT revision
less than 5.
e2869bd7af60 ("x86/acpi/boot: Do not register processors that cannot be onlined
for x2APIC")
Discussion on this topic can be located here:
hael Tsirkin.
- Recoded the flags to be simpler, per Michael, Ani Sinha and
Miguel Luis.
- Regenerated the binary tables, as per bios-tables-test.c
instructions.
v2: 18apr2023
https://lists.gnu.org/archive/html/qemu-devel/2023-04/msg02576.html
- Code formatting changes per Igor Mammedov
- Includ
Following the guidelines in tests/qtest/bios-tables-test.c, this
change sets-up bios-tables-test-allowed-diff.h to exclude the
imminent changes to the APIC tables, per step 2.
Signed-off-by: Eric DeVolder
---
tests/qtest/bios-tables-test-allowed-diff.h | 4
1 file changed, 4 insertions
generate and report revision 5 will solve problems with
CPU hotplug (the Online Capable flag indicates hotpluggable CPUs).
Link: https://lore.kernel.org/linux-acpi/20230327191026.3454-1-eric.devolder@ora
cle.com/T/#t
Signed-off-by: Eric DeVolder
---
hw/i386/acpi-common.c | 4 ++--
1 file changed, 2
00 C0 FE 00 00 00 00 02 0A 00 00 02 00 00 00 //
0070: 00 00 02 0A 00 05 05 00 00 00 0D 00 02 0A 00 09 //
0080: 09 00 00 00 0D 00 02 0A 00 0A 0A 00 00 00 0D 00 //
0090: 02 0A 00 0B 0B 00 00 00 0D 00 04 06 FF 00 00 01 //
**
Signe
On 4/20/23 03:05, Ani Sinha wrote:
On Tue, Apr 18, 2023 at 10:22 PM Eric DeVolder wrote:
Currently i386 QEMU generates MADT revision 3, and reports
MADT revision 1. ACPI 6.3 introduces MADT revision 5.
For MADT revision 4, that introduces ARM GIC structures, which do
not apply to i386
On 4/19/23 09:56, Michael S. Tsirkin wrote:
On Tue, Apr 18, 2023 at 12:52:18PM -0400, Eric DeVolder wrote:
Currently i386 QEMU generates MADT revision 3, and reports
MADT revision 1. ACPI 6.3 introduces MADT revision 5.
For MADT revision 4, that introduces ARM GIC structures, which do
not
On 4/19/23 00:30, Michael S. Tsirkin wrote:
On Tue, Apr 18, 2023 at 12:52:17PM -0400, Eric DeVolder wrote:
Currently ARM QEMU generates, and reports, MADT revision 4. ACPI 6.3
introduces MADT revision 5.
For MADT revision 5, the GICC structure adds an SPE Overflow Interrupt
field. This new
On 4/12/23 02:58, Igor Mammedov wrote:
On Tue, 11 Apr 2023 18:00:49 +0200
Igor Mammedov wrote:
On Tue, 28 Mar 2023 11:59:26 -0400
Eric DeVolder wrote:
Currently i386 QEMU generates MADT revision 3, and reports
MADT revision 1. ACPI 6.3 introduces MADT revision 5.
For MADT revision 4
Following the guidelines in tests/qtest/bios-tables-test.c, this
change sets-up bios-tables-test-allowed-diff.h to exclude the
imminent changes to the APIC tables, per step 2.
Signed-off-by: Eric DeVolder
---
tests/qtest/bios-tables-test-allowed-diff.h | 4
1 file changed, 4 insertions
haved as expected.
Regards,
Eric
---
v2: 18apr2023
- Code formatting changes per Igor Mammedov
- Included the steps in bios-tables-test.
v1: 28mar2023
https://lists.gnu.org/archive/html/qemu-devel/2023-03/msg06705.html
- Initial series for ARM and i386 MADT revision bump to 5.
Eric DeV
generate and report revision 5 will solve problems with
CPU hotplug (the Online Capable flag indicates hotpluggable CPUs).
Link:
https://lore.kernel.org/linux-acpi/20230327191026.3454-1-eric.devol...@oracle.com/T/#t
Signed-off-by: Eric DeVolder
---
hw/i386/acpi-common.c | 13 ++---
1 file
00 00 00 00 00 00 00 00 00 00 00 00 00 //
0090: 00 00 00 00 0D 18 00 00 00 00 00 00 00 00 02 08 // ....
00A0: 00 00 00 00 01 00 00 00 40 00 50 00 // @.P.
Signed-off-by: Eric DeVolder
---
tests/data/acpi/microvm/APIC
is
not supported, to zero the field.
Signed-off-by: Eric DeVolder
---
hw/arm/virt-acpi-build.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 4156111d49..23268dd981 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw
I'm back from travel and catching up. More info below.
eric
On 3/31/23 11:25, Igor Mammedov wrote:
On Wed, 29 Mar 2023 12:47:05 -0400
"Michael S. Tsirkin" wrote:
On Wed, Mar 29, 2023 at 08:14:37AM -0500, Eric DeVolder wrote:
On 3/29/23 00:19, Michael S. Tsirkin wrote:
Hm
On 3/29/23 08:16, Eric DeVolder wrote:
On 3/29/23 00:03, Michael S. Tsirkin wrote:
On Tue, Mar 28, 2023 at 11:59:26AM -0400, Eric DeVolder wrote:
Currently i386 QEMU generates MADT revision 3, and reports
MADT revision 1. ACPI 6.3 introduces MADT revision 5.
For MADT revision 4, that
On 3/29/23 00:03, Michael S. Tsirkin wrote:
On Tue, Mar 28, 2023 at 11:59:26AM -0400, Eric DeVolder wrote:
Currently i386 QEMU generates MADT revision 3, and reports
MADT revision 1. ACPI 6.3 introduces MADT revision 5.
For MADT revision 4, that introduces ARM GIC structures, which do
not
we want to keep old revision for old machine types.
Ok, what option name, for keeping old behavior, would you like?
On Tue, Mar 28, 2023 at 11:59:24AM -0400, Eric DeVolder wrote:
The following Linux kernel change broke CPU hotplug for MADT revision
less than 5.
commit e2869bd7af60 ("x86/a
I forgot to include the updated ACPI tables. I will do that as part of v2.
In the meantime, I appreciate any feedback...
eric
On 3/28/23 10:59, Eric DeVolder wrote:
The following Linux kernel change broke CPU hotplug for MADT revision
less than 5.
commit e2869bd7af60 ("x86/acpi/boot: D
is
not supported, to zero the field.
Signed-off-by: Eric DeVolder
---
hw/arm/virt-acpi-build.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/hw/arm/virt-acpi-build.c b/hw/arm/virt-acpi-build.c
index 4156111d49..23268dd981 100644
--- a/hw/arm/virt-acpi-build.c
+++ b/hw
5h 0293 001h] Length : 08
[126h 0294 001h]Processor ID : 1F
[127h 0295 001h] Local Apic ID : 1F
[128h 0296 004h] Flags (decoded below) : 0002
Processor Enabled : 0 <=
generate and report revision 5 will solve problems with
CPU hotplug (the Online Capable flag indicates hotpluggable CPUs).
Signed-off-by: Eric DeVolder
---
hw/i386/acpi-common.c | 13 ++---
1 file changed, 10 insertions(+), 3 deletions(-)
diff --git a/hw/i386/acpi-common.c b/hw/i386/acpi
: Eric DeVolder
Cc: qemu-sta...@nongnu.org
Fixes: f7e26ffa590 ("ACPI ERST: support for ACPI ERST feature")
Tested-by: Alexander Bulekov
Signed-off-by: Christian A. Ehrhardt
Reviewed-by: Eric DeVolder
Thanks Christian!
eric
---
hw/acpi/erst.c | 6 +++---
1 file changed, 3 insert
On 10/20/22 01:14, Markus Armbruster wrote:
"Christian A. Ehrhardt" writes:
Fix memset argument order: The second argument is
the value, the length goes last.
Impact of the bug?
Cc: Eric DeVolder
Cc: qemu-sta...@nongnu.org
Fixes: f7e26ffa590 ("ACPI ERST: support for AC
On 10/19/22 14:37, Philippe Mathieu-Daudé wrote:
On 19/10/22 21:15, Christian A. Ehrhardt wrote:
Fix memset argument order: The second argument is
the value, the length goes last.
Cc: Eric DeVolder
Cc: qemu-sta...@nongnu.org
Fixes: f7e26ffa590 ("ACPI ERST: support for ACPI ERST fe
continued with other validation checks. Hence, we should
simply return from this function upon validation failure.
CC: Peter Maydell
CC: Eric DeVolder
Signed-off-by: Ani Sinha
Reviewed-by: Eric DeVolder
My apologies, I've been away for the past week.
Thank you for taking the time to correct
Hi, just wondering when this is targeted for merge?
Thanks,
eric
On 2/7/22 01:02, Ani Sinha wrote:
From: Eric DeVolder
Information on the implementation of the ACPI ERST support.
Signed-off-by: Eric DeVolder
Acked-by: Ani Sinha
---
docs/specs/acpi_erst.rst | 200
On 2/15/22 09:31, Ani Sinha wrote:
This change is cosmetic. IS_UEFI_CPER_RECORD macro definition that was added
as a part of the ERST implementation seems to be unused. Remove it.
CC: Eric DeVolder
Signed-off-by: Ani Sinha
Thanks!
Reviewed-by: Eric DeVolder
---
hw/acpi/erst.c | 5
On 2/15/22 09:23, Ani Sinha wrote:
Adding device ID for ERST device in pci-ids.txt. It was missed when ERST
related patches were reviewed.
CC: Eric DeVolder
Signed-off-by: Ani Sinha
Thanks!
Reviewed-by: Eric DeVolder
---
docs/specs/pci-ids.txt | 1 +
1 file changed, 1 insertion
This patchset introduces support for the ACPI Error Record
Serialization Table, ERST.
For background and implementation information, please see
docs/specs/acpi_erst.rst, which is patch 2/10.
Suggested-by: Konrad Wilk
Signed-off-by: Eric DeVolder
---
v15: 28jan2022
- Changes to build_erst
This change provides a qtest that locates and then does a simple
interrogation of the ERST feature within the guest.
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
tests/qtest/erst-test.c | 172
tests/qtest/meson.build | 2 +
2 files
This change implements the test suite checks for the ERST table.
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
tests/qtest/bios-tables-test.c | 54 ++
1 file changed, 54 insertions(+)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest
This change exposes ACPI ERST support for x86 guests.
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
hw/i386/acpi-build.c | 15 +++
hw/i386/acpi-microvm.c | 15 +++
include/hw/acpi/erst.h | 5 +
3 files changed, 35 insertions(+)
diff --git a/hw/i386
This builds the ACPI ERST table to inform OSPM how to communicate
with the acpi-erst device.
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
hw/acpi/erst.c | 211 +
1 file changed, 211 insertions(+)
diff --git a/hw/acpi/erst.c b
This change introduces the public defintions for ACPI ERST.
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
include/hw/acpi/erst.h | 19 +++
1 file changed, 19 insertions(+)
create mode 100644 include/hw/acpi/erst.h
diff --git a/include/hw/acpi/erst.h b/include/hw
This implements a PCI device for ACPI ERST. This implements the
non-NVRAM "mode" of operation for ERST as it is supported by
Linux and Windows.
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
hw/acpi/Kconfig | 6 +
hw/acpi/erst.c
hotpluggable
slot on the pci root port with a non-hotplugggable device.
On q35, bsel on pcie root bus is not set (its not hotpluggable bus),
so the change basically adds the address enumeration for the device.
Signed-off-by: Eric DeVolder
Acked-by: Ani Sinha
---
tests/data/acpi/microvm/
Following the guidelines in tests/qtest/bios-tables-test.c, this
change adds empty placeholder files per step 1 for the new ERST
table, and excludes resulting changed files in bios-tables-test-allowed-diff.h
per step 2.
Signed-off-by: Eric DeVolder
Acked-by: Igor Mammedov
---
tests/data/acpi
Information on the implementation of the ACPI ERST support.
Signed-off-by: Eric DeVolder
Acked-by: Ani Sinha
---
docs/specs/acpi_erst.rst | 200 +++
1 file changed, 200 insertions(+)
create mode 100644 docs/specs/acpi_erst.rst
diff --git a/docs
This change reserves the PCI device_id for the new ACPI ERST
device.
Signed-off-by: Eric DeVolder
Acked-by: Igor Mammedov
Acked-by: Ani Sinha
---
include/hw/pci/pci.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index 023abc0..c3f3c90 100644
On 1/28/22 11:25, Ani Sinha wrote:
[snip]
On Fri, Jan 28, 2022 at 9:44 PM Michael S. Tsirkin mailto:m...@redhat.com>> wrote:
> > > OK, here is the equivalent using struct assignment, is this what you
were after?
> > >
> > > BuildSerializationInstructionEntry base = {
Michael, thanks! See inline response below, please.
eric
On 1/28/22 09:54, Michael S. Tsirkin wrote:
On Fri, Jan 28, 2022 at 09:11:41AM -0600, Eric DeVolder wrote:
Michael,
Thanks for examining this. Inline response below.
eric
On 1/27/22 18:37, Michael S. Tsirkin wrote:
On Thu, Jan 27, 2022
Michael,
Thanks for examining this. Inline response below.
eric
On 1/27/22 18:37, Michael S. Tsirkin wrote:
On Thu, Jan 27, 2022 at 04:02:07PM -0600, Eric DeVolder wrote:
Ani,
Thanks for the RB! Inline responses below.
eric
On 1/27/22 02:36, Ani Sinha wrote:
On Wed, 26 Jan 2022, Eric
Ani,
Thanks for the RB! Inline responses below.
eric
On 1/27/22 02:36, Ani Sinha wrote:
On Wed, 26 Jan 2022, Eric DeVolder wrote:
This builds the ACPI ERST table to inform OSPM how to communicate
with the acpi-erst device.
There might be more optimizations possible but I think we have
hotpluggable
slot on the pci root port with a non-hotplugggable device.
On q35, bsel on pcie root bus is not set (its not hotpluggable bus),
so the change basically adds the address enumeration for the device.
Signed-off-by: Eric DeVolder
Acked-by: Ani Sinha
---
tests/data/acpi/microvm/
This change provides a qtest that locates and then does a simple
interrogation of the ERST feature within the guest.
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
tests/qtest/erst-test.c | 172
tests/qtest/meson.build | 2 +
2 files
This implements a PCI device for ACPI ERST. This implements the
non-NVRAM "mode" of operation for ERST as it is supported by
Linux and Windows.
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
hw/acpi/Kconfig | 6 +
hw/acpi/erst.c
This builds the ACPI ERST table to inform OSPM how to communicate
with the acpi-erst device.
Signed-off-by: Eric DeVolder
---
hw/acpi/erst.c | 225 +
1 file changed, 225 insertions(+)
diff --git a/hw/acpi/erst.c b/hw/acpi/erst.c
index
This change implements the test suite checks for the ERST table.
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
tests/qtest/bios-tables-test.c | 54 ++
1 file changed, 54 insertions(+)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest
This change introduces the public defintions for ACPI ERST.
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
include/hw/acpi/erst.h | 19 +++
1 file changed, 19 insertions(+)
create mode 100644 include/hw/acpi/erst.h
diff --git a/include/hw/acpi/erst.h b/include/hw
This change exposes ACPI ERST support for x86 guests.
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
hw/i386/acpi-build.c | 15 +++
hw/i386/acpi-microvm.c | 15 +++
include/hw/acpi/erst.h | 5 +
3 files changed, 35 insertions(+)
diff --git a/hw/i386
Information on the implementation of the ACPI ERST support.
Signed-off-by: Eric DeVolder
Acked-by: Ani Sinha
---
docs/specs/acpi_erst.rst | 200 +++
1 file changed, 200 insertions(+)
create mode 100644 docs/specs/acpi_erst.rst
diff --git a/docs
Following the guidelines in tests/qtest/bios-tables-test.c, this
change adds empty placeholder files per step 1 for the new ERST
table, and excludes resulting changed files in bios-tables-test-allowed-diff.h
per step 2.
Signed-off-by: Eric DeVolder
Acked-by: Igor Mammedov
---
tests/data/acpi
This change reserves the PCI device_id for the new ACPI ERST
device.
Signed-off-by: Eric DeVolder
Acked-by: Igor Mammedov
Acked-by: Ani Sinha
---
include/hw/pci/pci.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index 023abc0..c3f3c90 100644
This patchset introduces support for the ACPI Error Record
Serialization Table, ERST.
For background and implementation information, please see
docs/specs/acpi_erst.rst, which is patch 2/10.
Suggested-by: Konrad Wilk
Signed-off-by: Eric DeVolder
---
v14: 26jan2022
- Changed build_erst() to
Ani, Michael,
An inline response at the bottom.
Thanks!
eric
On 1/26/22 01:05, Ani Sinha wrote:
On Tue, 25 Jan 2022, Eric DeVolder wrote:
Ani,
Thanks for the feedback! Inline responses below.
eric
On 1/25/22 04:53, Ani Sinha wrote:
+
+action = ACTION_BEGIN_CLEAR_OPERATION
Hi Michael,
Thanks for examining this! Inline response below.
eric
On 1/25/22 06:05, Michael S. Tsirkin wrote:
On Tue, Jan 25, 2022 at 04:23:49PM +0530, Ani Sinha wrote:
On Mon, 24 Jan 2022, Eric DeVolder wrote:
This builds the ACPI ERST table to inform OSPM how to communicate
with the
Ani,
Thanks for the feedback! Inline responses below.
eric
On 1/25/22 04:53, Ani Sinha wrote:
On Mon, 24 Jan 2022, Eric DeVolder wrote:
This builds the ACPI ERST table to inform OSPM how to communicate
with the acpi-erst device.
Signed-off-by: Eric DeVolder
---
hw/acpi/erst.c | 188
This implements a PCI device for ACPI ERST. This implements the
non-NVRAM "mode" of operation for ERST as it is supported by
Linux and Windows.
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
hw/acpi/Kconfig | 6 +
hw/acpi/erst.c
This change implements the test suite checks for the ERST table.
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
tests/qtest/bios-tables-test.c | 54 ++
1 file changed, 54 insertions(+)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest
This change provides a qtest that locates and then does a simple
interrogation of the ERST feature within the guest.
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
tests/qtest/erst-test.c | 172
tests/qtest/meson.build | 2 +
2 files
This change exposes ACPI ERST support for x86 guests.
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
hw/i386/acpi-build.c | 15 +++
hw/i386/acpi-microvm.c | 15 +++
include/hw/acpi/erst.h | 5 +
3 files changed, 35 insertions(+)
diff --git a/hw/i386
Following the guidelines in tests/qtest/bios-tables-test.c, this
change adds empty placeholder files per step 1 for the new ERST
table, and excludes resulting changed files in bios-tables-test-allowed-diff.h
per step 2.
Signed-off-by: Eric DeVolder
Acked-by: Igor Mammedov
---
tests/data/acpi
This change introduces the public defintions for ACPI ERST.
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
include/hw/acpi/erst.h | 19 +++
1 file changed, 19 insertions(+)
create mode 100644 include/hw/acpi/erst.h
diff --git a/include/hw/acpi/erst.h b/include/hw
Information on the implementation of the ACPI ERST support.
Signed-off-by: Eric DeVolder
Acked-by: Ani Sinha
---
docs/specs/acpi_erst.rst | 200 +++
1 file changed, 200 insertions(+)
create mode 100644 docs/specs/acpi_erst.rst
diff --git a/docs
hotpluggable
slot on the pci root port with a non-hotplugggable device.
On q35, bsel on pcie root bus is not set (its not hotpluggable bus),
so the change basically adds the address enumeration for the device.
Signed-off-by: Eric DeVolder
Acked-by: Ani Sinha
---
tests/data/acpi/microvm/
This change reserves the PCI device_id for the new ACPI ERST
device.
Signed-off-by: Eric DeVolder
Acked-by: Igor Mammedov
Acked-by: Ani Sinha
---
include/hw/pci/pci.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index 023abc0..c3f3c90 100644
This patchset introduces support for the ACPI Error Record
Serialization Table, ERST.
For background and implementation information, please see
docs/specs/acpi_erst.rst, which is patch 2/10.
Suggested-by: Konrad Wilk
Signed-off-by: Eric DeVolder
---
v13: 24jan2022
- v12 erroneously omitted
This builds the ACPI ERST table to inform OSPM how to communicate
with the acpi-erst device.
Signed-off-by: Eric DeVolder
---
hw/acpi/erst.c | 188 +
1 file changed, 188 insertions(+)
diff --git a/hw/acpi/erst.c b/hw/acpi/erst.c
index
1/22 02:35, Ani Sinha wrote:
On Tue, Dec 14, 2021 at 2:33 AM Eric DeVolder wrote:
Ani, an inline response below.
Thanks!
eric
On 12/10/21 08:09, Ani Sinha wrote:
On Thu, Dec 9, 2021 at 11:24 PM Eric DeVolder wrote:
Ani, inline responses below. eric
On 12/9/21 00:29, Ani Sinha wrote:
On F
Thanks for looking at this Michael, I've an inline response below.
eric
On 1/6/22 04:45, Michael S. Tsirkin wrote:
On Wed, Dec 15, 2021 at 10:38:11AM -0500, Eric DeVolder wrote:
This builds the ACPI ERST table to inform OSPM how to communicate
with the acpi-erst device.
Signed-off-by:
This builds the ACPI ERST table to inform OSPM how to communicate
with the acpi-erst device.
Signed-off-by: Eric DeVolder
---
hw/acpi/erst.c | 188 +
1 file changed, 188 insertions(+)
diff --git a/hw/acpi/erst.c b/hw/acpi/erst.c
index
This implements a PCI device for ACPI ERST. This implements the
non-NVRAM "mode" of operation for ERST as it is supported by
Linux and Windows.
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
hw/acpi/Kconfig | 6 +
hw/acpi/erst.c
This change introduces the public defintions for ACPI ERST.
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
include/hw/acpi/erst.h | 19 +++
1 file changed, 19 insertions(+)
create mode 100644 include/hw/acpi/erst.h
diff --git a/include/hw/acpi/erst.h b/include/hw
This change implements the test suite checks for the ERST table.
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
tests/qtest/bios-tables-test.c | 54 ++
1 file changed, 54 insertions(+)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest
Following the guidelines in tests/qtest/bios-tables-test.c, this
change adds empty placeholder files per step 1 for the new ERST
table, and excludes resulting changed files in bios-tables-test-allowed-diff.h
per step 2.
Signed-off-by: Eric DeVolder
Acked-by: Igor Mammedov
---
tests/data/acpi
This change exposes ACPI ERST support for x86 guests.
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
hw/i386/acpi-build.c | 15 +++
hw/i386/acpi-microvm.c | 15 +++
include/hw/acpi/erst.h | 5 +
3 files changed, 35 insertions(+)
diff --git a/hw/i386
This change provides a qtest that locates and then does a simple
interrogation of the ERST feature within the guest.
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
tests/qtest/erst-test.c | 172
tests/qtest/meson.build | 2 +
2 files
This change reserves the PCI device_id for the new ACPI ERST
device.
Signed-off-by: Eric DeVolder
Acked-by: Igor Mammedov
Acked-by: Ani Sinha
---
include/hw/pci/pci.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index 483d5c7..19db80e 100644
This patchset introduces support for the ACPI Error Record
Serialization Table, ERST.
For background and implementation information, please see
docs/specs/acpi_erst.rst, which is patch 2/10.
Suggested-by: Konrad Wilk
Signed-off-by: Eric DeVolder
---
v12: 10jan2022
- Converted macros in
Information on the implementation of the ACPI ERST support.
Signed-off-by: Eric DeVolder
Acked-by: Ani Sinha
---
docs/specs/acpi_erst.rst | 200 +++
1 file changed, 200 insertions(+)
create mode 100644 docs/specs/acpi_erst.rst
diff --git a/docs
Hi Ani,
Thanks for such quick feedback! One inline response below.
eric
On 12/15/21 10:33, Ani Sinha wrote:
On Wed, Dec 15, 2021 at 9:08 PM Eric DeVolder wrote:
This builds the ACPI ERST table to inform OSPM how to communicate
with the acpi-erst device.
Signed-off-by: Eric DeVolder
Information on the implementation of the ACPI ERST support.
Signed-off-by: Eric DeVolder
Acked-by: Ani Sinha
---
docs/specs/acpi_erst.rst | 200 +++
1 file changed, 200 insertions(+)
create mode 100644 docs/specs/acpi_erst.rst
diff --git a/docs
This change implements the test suite checks for the ERST table.
Signed-off-by: Eric DeVolder
Reviewed-by: Ani Sinha
---
tests/qtest/bios-tables-test.c | 56 ++
1 file changed, 56 insertions(+)
diff --git a/tests/qtest/bios-tables-test.c b/tests/qtest
This change reserves the PCI device_id for the new ACPI ERST
device.
Signed-off-by: Eric DeVolder
Acked-by: Igor Mammedov
Acked-by: Ani Sinha
---
include/hw/pci/pci.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/hw/pci/pci.h b/include/hw/pci/pci.h
index e7cdf2d..d3734b9 100644
Following the guidelines in tests/qtest/bios-tables-test.c, this
change adds empty placeholder files per step 1 for the new ERST
table, and excludes resulting changed files in bios-tables-test-allowed-diff.h
per step 2.
Signed-off-by: Eric DeVolder
Acked-by: Igor Mammedov
---
tests/data/acpi
1 - 100 of 258 matches
Mail list logo
