Re: [PATCH v2] util/memfd: allow allocating 0 bytes

2025-05-07 Thread Elisha Hollander
> "As I mentioned earlier": where? > Otherwise this description will be of > little relevance in 5 years from now in our history. I explained the motivation on the first revision of the patch On Wed, May 7, 2025, 14:58 Philippe Mathieu-Daudé wrote: > Hi Elisha, >

Re: [PATCH v2] util/memfd: allow allocating 0 bytes

2025-05-06 Thread Elisha Hollander
Maybe an assert is really more appropriate, but technically doing so on actual hardware should run flawlessly so I think the emu should work too... Maybe I'm wrong though On Tue, May 6, 2025, 19:48 Daniel P. Berrangé wrote: > On Tue, May 06, 2025 at 07:41:32PM +0300, Elisha Holland

[PATCH v2] util/memfd: allow allocating 0 bytes

2025-05-06 Thread Elisha Hollander
> As I mentioned earlier, let's say you don't initialize the vertical display end registers, and set the minimum scanline register, the emulation will then have to allocate some display buffer, but because the vertical display end is initilized as 0 the buffer will be empty and the program break.

Re: [PATCH v2] util/memfd: allow allocating 0 bytes

2025-05-06 Thread Elisha Hollander
l P. Berrangé wrote: > On Tue, May 06, 2025 at 07:17:25PM +0300, Elisha Hollander wrote: > > Sorry for former patch something is messed up with my email. > > The commit message needs to explain what problem is being solved by > making this change as allowing 0 bytes looks dubious o

[PATCH v2] util/memfd: allow allocating 0 bytes

2025-05-06 Thread Elisha Hollander
Sorry for former patch something is messed up with my email. Signed-off-by: donno2048 --- util/memfd.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/util/memfd.c b/util/memfd.c index 8a2e906..e96e5af 100644 --- a/util/memfd.c +++ b/util/memfd.c @@ -108,7 +108,7 @

[PATCH v2] util/memfd: allow allocating 0 bytes

2025-05-06 Thread Elisha Hollander
Signed-off-by: donno2048 --- util/memfd.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/util/memfd.c b/util/memfd.c index 8a2e906..e96e5af 100644 --- a/util/memfd.c +++ b/util/memfd.c @@ -108,7 +108,7 @@ err: void *qemu_memfd_alloc(const char *name, size_t size,

Re: [PATCH 1/1] util/memfd: allow allocating 0 bytes

2025-05-05 Thread Elisha Hollander
arc-André Lureau wrote: > Hi > > On Mon, May 5, 2025 at 9:03 PM Elisha Hollander > wrote: > > > > Not necessarily fdopen, can't remember why I chose it, we just need any > pointer as no data will be written into the buffer anyways > > > > NULL should be ac

Re: [PATCH 1/1] util/memfd: allow allocating 0 bytes

2025-05-05 Thread Elisha Hollander
Not necessarily fdopen, can't remember why I chose it, we just need any pointer as no data will be written into the buffer anyways On Mon, May 5, 2025, 19:55 Marc-André Lureau wrote: > Hi > > On Wed, Mar 26, 2025 at 8:21 PM donno2048 > wrote: > > > > This silently fixes issues resulting from tr

Re: [PATCH 1/1] util/memfd: allow allocating 0 bytes

2025-05-05 Thread Elisha Hollander
ping On Wed, Mar 26, 2025, 18:20 donno2048 wrote: > This silently fixes issues resulting from trying to allocate 0 bytes. > > Fixes error, for example, for writing byte 0x20 to port 0x3c0, then word > 0xf09 to port 0x3b4 when CPU is initiated, which shouldn't break. > > Signed-off-by: donno2048

Re: [PATCH 1/1] allow using a higher icount

2024-09-18 Thread Elisha Hollander
👍 On Fri, Sep 13, 2024, 13:06 Alex Bennée wrote: > Elisha Hollander writes: > > > weird... > > Richard has posted some patches: > > Message-ID: <20240910212351.977753-1-richard.hender...@linaro.org> > Date: Tue, 10 Sep 2024 14:23:49 -0700 > Subjec

Re: [PATCH 1/1] allow using a higher icount

2024-09-18 Thread Elisha Hollander
{ "emoji": "👍", "version": 1 }

Re: [PATCH 1/1] allow using a higher icount

2024-09-03 Thread Elisha Hollander
weird... On Tue, Sep 3, 2024, 14:13 Alex Bennée wrote: > Alex Bennée writes: > > > Elisha Hollander writes: > > > >> Sure! > >> > >> `build/qemu-system-i386 -plugin build/contrib/plugins/libips.so,ips=1 > -display curses -bios bios.raw` >

Re: [PATCH 1/1] allow using a higher icount

2024-09-03 Thread Elisha Hollander
Sure! `build/qemu-system-i386 -plugin build/contrib/plugins/libips.so,ips=1 -display curses -bios bios.raw` Also, I just tested with 9.1.0-rc4 and it resulted with `tcg.c:3167:remove_label_use: code should not be reached` On Mon, Sep 2, 2024, 16:08 Alex Bennée wrote: > Elisha Hollan

Re: [PATCH 1/1] allow using a higher icount

2024-09-02 Thread Elisha Hollander
But for qemu_plugin_update_ns On Mon, Sep 2, 2024, 15:38 Elisha Hollander wrote: > Just checked with 9.0.2 it it still gives the error... > > On Wed, Aug 28, 2024, 14:05 Alex Bennée wrote: > >> Elisha Hollander writes: >> >> > Although it gives `undefined sy

Re: [PATCH 1/1] allow using a higher icount

2024-09-02 Thread Elisha Hollander
Just checked with 9.0.2 it it still gives the error... On Wed, Aug 28, 2024, 14:05 Alex Bennée wrote: > Elisha Hollander writes: > > > Although it gives `undefined symbol: qemu_plugin_scoreboard_free`. But > > probably I messed something up... > > Are you using an older

Re: [PATCH 1/1] allow using a higher icount

2024-08-28 Thread Elisha Hollander
Although it gives `undefined symbol: qemu_plugin_scoreboard_free`. But probably I messed something up... On Tue, Aug 27, 2024, 14:59 Elisha Hollander wrote: > Oh nice, I didn't know that > > On Tue, Aug 27, 2024, 12:39 Alex Bennée wrote: > >> Elisha Hollander writes

Re: [PATCH 1/1] allow using a higher icount

2024-08-27 Thread Elisha Hollander
Oh nice, I didn't know that On Tue, Aug 27, 2024, 12:39 Alex Bennée wrote: > Elisha Hollander writes: > > > Signed-off-by: Elisha Hollander > > What is the use-case for this patch? > > If you are simply looking to slow the emulated system down please

Re: [PATCH 1/1] allow using a higher icount

2024-08-24 Thread Elisha Hollander
Just wanted to ping the patch <https://lore.kernel.org/qemu-devel/20240816162044.5764-1-just4now666...@gmail.com/> On Fri, Aug 16, 2024, 19:21 Elisha Hollander wrote: > Signed-off-by: Elisha Hollander > --- > accel/tcg/cpu-exec.c | 4 +--- > accel/tcg/icount-common.c |

[PATCH 1/1] allow using a higher icount

2024-08-16 Thread Elisha Hollander
Signed-off-by: Elisha Hollander --- accel/tcg/cpu-exec.c | 4 +--- accel/tcg/icount-common.c | 4 ++-- 2 files changed, 3 insertions(+), 5 deletions(-) diff --git a/accel/tcg/cpu-exec.c b/accel/tcg/cpu-exec.c index 8163295f34..4c2baf8ed4 100644 --- a/accel/tcg/cpu-exec.c +++ b/accel/tcg