Re: [PATCH] hw/riscv: virt: Avoid double FDT platform node

2022-05-19 Thread Dylan Reid
On Thu, May 19, 2022 at 08:34:06PM +0530, Anup Patel wrote: > On Fri, May 13, 2022 at 1:34 AM Dylan Reid wrote: > > > > When starting the virt machine with `-machine virt,aia=aplic-imsic`, > > both the imsic and aplic init code will add platform fdt

[PATCH] hw/riscv: virt: Avoid double FDT platform node

2022-05-12 Thread Dylan Reid
``` The call from `create_fdt_imsic` is not needed as an imsic is currently always combined with an aplic that will create the nodes. Fixes: 3029fab64309 ("hw/riscv: virt: Add support for generating platform FDT entries") Signed-off-by: Dylan Reid --- hw/riscv/virt.c | 5 - 1 file

[PATCH] target/riscv: Fix VS mode hypervisor CSR access

2022-05-06 Thread Dylan Reid
ction exception. Signed-off-by: Dylan Reid --- target/riscv/csr.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/target/riscv/csr.c b/target/riscv/csr.c index 3500e07f92..4ea7df02c9 100644 --- a/target/riscv/csr.c +++ b/target/riscv/csr.c @@ -3141,13 +3141,13 @@ s

Re: [Rust-VMM] vhost reply_ack negotiation (a.k.a differences in vhost-user behaviour with libvhost-user and vhost-user-backend.rs)

2021-02-24 Thread Dylan Reid
On Tue, Feb 23, 2021 at 8:20 AM Michael S. Tsirkin wrote: > > Cc: Raphael > > On Fri, Feb 19, 2021 at 04:04:34PM +, Alex Bennée wrote: > > Hi, > > > > I finally got a chance to get down into the guts of vhost-user while > > attempting to port my original C RPMB daemon to Rust using the > > vho

Re: [PATCH] vhost-user: Check vhost features for CONFIGURE_MEM_SLOTS

2020-12-23 Thread Dylan Reid
>Agreed - VHOST_USER_PROTCOL_F_CONFIGURE_MEM_SLOTS is negotiated at the >vhost-user, not virtio layer. The dev->protocol_features flags are taken >from the VHOST_USER_GET_PROTOCOL_FEATURES message, which retrieves the >supported vhost-user features from the backend. See libvhost-user for a >simple

[PATCH] vhost-user: Check vhost features for CONFIGURE_MEM_SLOTS

2020-12-22 Thread Dylan Reid
The `CONFIGURE_MEM_SLOTS` feature is specified by vhost, not by virtio. Check the vhost flags for it being set. I noticed this while testing a new vhost implementation that doesn't yet support configuring memory slots and retested with dpdk's block example as well. Signed-off-by:

Re: guest / host buffer sharing ...

2019-12-04 Thread Dylan Reid
On Thu, Nov 21, 2019 at 4:59 PM Tomasz Figa wrote: > > On Thu, Nov 21, 2019 at 6:41 AM Geoffrey McRae wrote: > > > > > > > > On 2019-11-20 23:13, Tomasz Figa wrote: > > > Hi Geoffrey, > > > > > > On Thu, Nov 7, 2019 at 7:28 AM Geoffrey McRae > > > wrote: > > >> > > >> > > >> > > >> On 2019-11-06