Re: [PATCH 1/1] hw/intc/riscv_aclint:Change the way to get CPUState from hard-base to pu_index

2023-11-08 Thread Dongxue Zhang
Reviewed-by: Dongxue Zhang On Thu, Nov 9, 2023 at 10:22 AM Leo Hou wrote: > > From: Leo Hou > > cpu_by_arch_id() uses hartid-base as the index to obtain the corresponding > CPUState structure variable. > qemu_get_cpu() uses cpu_index as the index to obtain the corresp

Re: Re: [PATCH qemu] target/riscv/cpu.c: Fix elen check

2022-12-29 Thread Dongxue Zhang
>On Thu, Dec 29, 2022 at 12:34 AM ~elta wrote: >> >> From: Dongxue Zhang >> >> Should be cpu->cfg.elen in range [8, 64]. >> >> Signed-off-by: Dongxue Zhang > >When sending a new version can you please add any previous reviewed tags. > >Alist

[Qemu-devel] [PATCH] target-mips/cpu.h: Fix spell error

2015-11-25 Thread Dongxue Zhang
CP0IntCtl_IPPC1, the last letter should be 'i', not 'one'. Signed-off-by: Dongxue Zhang --- target-mips/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-mips/cpu.h b/target-mips/cpu.h index 89c01f7..17817c3 100644 --- a/target-mips/cpu.h +++

[Qemu-devel] [PATCH] target-mips/cpu.h: Fix spell error

2015-11-24 Thread Dongxue Zhang
CP0IntCtl_IPPC1, the last letter should be 'i', not 'one'. Signed-off-by: Dongxue Zhang --- target-mips/cpu.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-mips/cpu.h b/target-mips/cpu.h index 89c01f7..17817c3 100644 --- a/target-mips/cpu.h +++

[Qemu-devel] [PATCH V2 2/2] target-mips/translate.c: Add judgement for msb and lsb

2014-07-30 Thread Dongxue Zhang
Compare the real msb and lsb, when lsb <= msb, tranlate the code. When lsb > msb, just fall through and don't raise RI exception. Signed-off-by: Dongxue Zhang --- target-mips/translate.c | 43 --- 1 file changed, 24 insertions(+), 19 deletio

Re: [Qemu-devel] [PATCH 2/2] target-mips/translate.c: Add judgement for msb and lsb

2014-07-29 Thread Dongxue Zhang
Ok, I got you. I will re-build a new patch for all the bitops. 2014-07-29 22:08 GMT+08:00 Aurelien Jarno : > On Tue, Jul 29, 2014 at 08:41:08PM +0800, Elta wrote: > > I think, debug mode shouldn't crash the qemu with an unpredictable > > operation, > > so i want to fix it. And you say there shou

[Qemu-devel] [PATCH 2/2] target-mips/translate.c: Update OPC_SYNCI

2014-07-29 Thread Dongxue Zhang
Update OPC_SYNCI with BS_STOP, in order to handle the instructions which saved in the same TB of the store instruction. Signed-off-by: Dongxue Zhang --- target-mips/translate.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target-mips/translate.c b/target-mips

[Qemu-devel] [PATCH 1/2] target-mips: Add synci instruction test

2014-07-29 Thread Dongxue Zhang
Save code with sw and raise synci. The saved code should be raise. If the code raised, log 'test passed'. If the code not raised, log 'test failed, the copied instruction not run'. Other cases, log 'unhandled'. The test should log 'test passed'. Signed-of

[Qemu-devel] [PATCH 1/2] target-mips/translate.c: Free TCG in OPC_DINSV

2014-07-28 Thread Dongxue Zhang
Free t0 and t1 in opcode OPC_DINSV. Signed-off-by: Dongxue Zhang --- target-mips/translate.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/target-mips/translate.c b/target-mips/translate.c index d7b8c4d..c381366 100644 --- a/target-mips/translate.c +++ b/target-mips/translate.c

[Qemu-devel] [PATCH 2/2] target-mips/translate.c: Add judgement for msb and lsb

2014-07-28 Thread Dongxue Zhang
Use 'if' to make sure the real msb greater than the lsb. As the compiler may not do this. Signed-off-by: Dongxue Zhang --- target-mips/translate.c | 9 + 1 file changed, 9 insertions(+) diff --git a/target-mips/translate.c b/target-mips/translate.c index c381366..e2cce31 10

[Qemu-devel] [PATCH] target-openrisc: Add typename for CPU models.

2013-07-02 Thread Dongxue Zhang
Make target-openrisc running OK by add typename in openrisc_cpu_class_by_name(). Signed-off-by: Dongxue Zhang --- target-openrisc/cpu.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/target-openrisc/cpu.c b/target-openrisc/cpu.c index fd90d37..d38c28b 100644 --- a/target

[Qemu-devel] [target-mips] How to use smp?

2013-06-24 Thread Dongxue Zhang
Hello everybody, i want to use mips target with smp support. When use command without smp, then the log stopped at "kernel panic", when -smp 2 added, it stoppted at "NR_IRQS:256". I use the git qemu at 576156ffed72ab4feb0b752979db86ff8759a2a1 qemu configed with "./configure --target-list=mips64el

Re: [Qemu-devel] [PATCH 2/3] Make-repl_ph-to-sign-extended-to-target_long

2012-12-11 Thread Dongxue Zhang
Thanks for your review, now I know this problem but don't have gcc can compile repl_ph instruction. I will build a gcc and resend this patch later. 2012/12/12 Andreas Färber > Am 11.12.2012 16:13, schrieb Markus Armbruster: > > Please-separate-words-with-spaces-in-your-subject-line-thank-you-:)

[Qemu-devel] [PATCH 3/3] Fix-gen_HILO-to-make-it-adapt-each-arch-which-use-acc

2012-12-11 Thread Dongxue Zhang
, and check_dsp. If arch is microMIPS32DSP, then a bug case. So I changed gen_HILO function for furture add other arch with dsp. MFHI MTHI MFLO MTLO of mipsdsp have been tested, they worked fun. Signed-off-by: Dongxue Zhang --- target-mips/translate.c |

[Qemu-devel] [PATCH 2/3] Make-repl_ph-to-sign-extended-to-target_long

2012-12-11 Thread Dongxue Zhang
The immediate value is 9bits, should sign-extend to 16bits. The return value to register should sign-extend to target_long, as Richard says, removing an unnecessary cast works fun. Signed-off-by: Dongxue Zhang --- target-mips/translate.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion

[Qemu-devel] [PATCH 1/3] Fix my email address

2012-12-11 Thread Dongxue Zhang
Fix my email address, last time it's wrong. Signed-off-by: Dongxue Zhang --- target-mips/dsp_helper.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/target-mips/dsp_helper.c b/target-mips/dsp_helper.c index 14daf91..536032b 100644 --- a/target-mips/dsp_helper.c