Re: [Qemu-devel] SR-IOV PF reset and QEMU VFs VFIO passthrough

2013-06-03 Thread Don Dutile
On 06/03/2013 05:58 PM, Benoît Canet wrote: When the PF does an FLR the hardware go back to its default state, the SR-IOV configuration is gone and the VFs disappears from the bus. Then the restore state function of the kernel reset code would bring the SR-IOV PF configuration back. Ok, now you

Re: [Qemu-devel] SR-IOV PF reset and QEMU VFs VFIO passthrough

2013-06-03 Thread Don Dutile
On 06/03/2013 05:27 PM, Benoît Canet wrote: I was asking this because the PF driver should reset the PF while the VF are used by VFIO/QEMU when the PF doesn't respond anymore. What your VF does while your PF is being reset is PF (& VF) dependent. A 'good design' would not impact the VF operati

Re: [Qemu-devel] SR-IOV PF reset and QEMU VFs VFIO passthrough

2013-06-03 Thread Don Dutile
On 06/03/2013 03:29 PM, Benoît Canet wrote: to a guest will the consequences of a PF FLR be handled fine by QEMU and the guest ? the reset occurs long before the device is passed to the guest. I was asking this because the PF driver should reset the PF while the VF are used by VFIO/QEMU when

Re: [Qemu-devel] SR-IOV PF reset and QEMU VFs VFIO passthrough

2013-06-03 Thread Don Dutile
On 06/01/2013 08:13 AM, Benoît Canet wrote: Hello, I may have soon the PF driver of an SR-IOV card to code and make work with QEMU/KVM so I have the following questions. In an AMD64 setup where QEMU use VFIO to passthrough the VFs of an SR-IOV card to a guest will the consequences of a PF FLR

Re: [Qemu-devel] VFIO and scheduled SR-IOV cards

2013-06-03 Thread Don Dutile
On 06/03/2013 02:02 PM, Alex Williamson wrote: On Mon, 2013-06-03 at 18:33 +0200, Benoît Canet wrote: Hello, I plan to write a PF driver for an SR-IOV card and make the VFs work with QEMU's VFIO passthrough so I am asking the following design question before trying to write and push code. Afte

Re: [Qemu-devel] [PATCH v2 09/13] vfio: x86 IOMMU implementation

2012-05-25 Thread Don Dutile
On 05/24/2012 06:46 PM, Alex Williamson wrote: On Thu, 2012-05-24 at 17:38 -0400, Don Dutile wrote: On 05/22/2012 01:05 AM, Alex Williamson wrote: x86 is probably the wrong name for this VFIO IOMMU driver, but x86 is the primary target for it. This driver support a very simple usage model

Re: [Qemu-devel] [PATCH v2 09/13] vfio: x86 IOMMU implementation

2012-05-25 Thread Don Dutile
On 05/22/2012 01:05 AM, Alex Williamson wrote: x86 is probably the wrong name for this VFIO IOMMU driver, but x86 is the primary target for it. This driver support a very simple usage model using the existing IOMMU API. The IOMMU is expected to support the full host address space with no specia

Re: [Qemu-devel] [PATCH v2 00/13] IOMMU Groups + VFIO

2012-05-25 Thread Don Dutile
On 05/22/2012 01:04 AM, Alex Williamson wrote: Version 2 incorporating acks and feedback from v1. The PCI DMA quirk and ACS check are reworked, sysfs iommu groups ABI Documentation added as well as numerous other fixes, including patches from Alexey Kardashevskiy towards supporting POWER usage o

Re: [Qemu-devel] [PATCH v2 03/13] iommu: IOMMU groups for VT-d and AMD-Vi

2012-05-25 Thread Don Dutile
On 05/22/2012 01:04 AM, Alex Williamson wrote: Add back group support for AMD& Intel. amd_iommu already tracks devices and has init and uninit routines to manage groups. intel-iommu does this on the fly, so we make use of the notifier support built into iommu groups to create and remove groups.

Re: [Qemu-devel] [PATCH v2 05/13] pci: Add ACS validation utility

2012-05-24 Thread Don Dutile
On 05/22/2012 01:05 AM, Alex Williamson wrote: In a PCI environment, transactions aren't always required to reach the root bus before being re-routed. Intermediate switches between an endpoint and the root bus can redirect DMA back downstream before things like IOMMUs have a chance to intervene.

Re: [Qemu-devel] [PATCH v2 12/13] pci: Misc pci_reg additions

2012-05-24 Thread Don Dutile
On 05/22/2012 01:05 AM, Alex Williamson wrote: Fill in many missing definitions and add sizeof fields for many sections allowing for more extensive config parsing. Signed-off-by: Alex Williamson --- overall, i'm very glad to see defines instead of hardcoded numbers in the code, but in

Re: [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled()

2012-05-21 Thread Don Dutile
On 05/21/2012 10:59 AM, Alex Williamson wrote: On Mon, 2012-05-21 at 09:31 -0400, Don Dutile wrote: On 05/18/2012 10:47 PM, Alex Williamson wrote: On Fri, 2012-05-18 at 19:00 -0400, Don Dutile wrote: On 05/18/2012 06:02 PM, Alex Williamson wrote: On Wed, 2012-05-16 at 09:29 -0400, Don Dutile

Re: [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled()

2012-05-21 Thread Don Dutile
On 05/18/2012 10:47 PM, Alex Williamson wrote: On Fri, 2012-05-18 at 19:00 -0400, Don Dutile wrote: On 05/18/2012 06:02 PM, Alex Williamson wrote: On Wed, 2012-05-16 at 09:29 -0400, Don Dutile wrote: On 05/15/2012 05:09 PM, Alex Williamson wrote: On Tue, 2012-05-15 at 13:56 -0600, Bjorn

Re: [Qemu-devel] RESEND3: Re: [PATCH 05/13] pci: New pci_acs_enabled()

2012-05-18 Thread Don Dutile
On 05/18/2012 06:02 PM, Alex Williamson wrote: On Wed, 2012-05-16 at 09:29 -0400, Don Dutile wrote: On 05/15/2012 05:09 PM, Alex Williamson wrote: On Tue, 2012-05-15 at 13:56 -0600, Bjorn Helgaas wrote: On Mon, May 14, 2012 at 4:49 PM, Alex Williamson wrote: On Mon, 2012-05-14 at 16:02

Re: [Qemu-devel] [PATCH 05/13] pci: New pci_acs_enabled()

2012-05-16 Thread Don Dutile
On 05/15/2012 05:09 PM, Alex Williamson wrote: On Tue, 2012-05-15 at 13:56 -0600, Bjorn Helgaas wrote: On Mon, May 14, 2012 at 4:49 PM, Alex Williamson wrote: On Mon, 2012-05-14 at 16:02 -0600, Bjorn Helgaas wrote: On Fri, May 11, 2012 at 4:56 PM, Alex Williamson wrote: In a PCIe environm

Re: [Qemu-devel] kvm PCI assignment & VFIO ramblings

2011-08-25 Thread Don Dutile
On 08/25/2011 06:54 AM, Roedel, Joerg wrote: Hi Alex, On Wed, Aug 24, 2011 at 05:13:49PM -0400, Alex Williamson wrote: Is this roughly what you're thinking of for the iommu_group component? Adding a dev_to_group iommu ops callback let's us consolidate the sysfs support in the iommu base. Would

Re: [Qemu-devel] [PATCH] pci: Error on PCI capability collisions

2011-08-23 Thread Don Dutile
On 08/23/2011 03:30 PM, Michael S. Tsirkin wrote: On Tue, Aug 23, 2011 at 01:12:19PM -0600, Alex Williamson wrote: On Tue, 2011-08-23 at 21:26 +0300, Michael S. Tsirkin wrote: On Tue, Aug 23, 2011 at 12:21:47PM -0600, Alex Williamson wrote: On Tue, 2011-08-23 at 21:17 +0300, Michael S. Tsirkin

[Qemu-devel] Re: [PATCH] smbios: avoid counting io hole as ram

2010-05-08 Thread Don Dutile
Alex Williamson wrote: > Avoid counting the io hole as part of ram, a vm started with 4G > should report 4G in smbios, not 4.5G. > > Signed-off-by: Alex Williamson > --- Tested on rhel5 guest assigned a variety of mem sizes (3.2, 3.4, 3.5, 3.7, 3.9, 4.0, 4.1, 4.2, 17G); crossed 16G boundary due