Re: [PATCH] hw/smbios: add an ability to set extension bytes in the type0 table

2025-07-23 Thread Daniil Tatianin
On 7/23/25 12:23 PM, Michael S. Tsirkin wrote: On Wed, Jul 23, 2025 at 12:16:08PM +0300, Daniil Tatianin wrote: On 7/23/25 12:14 PM, Michael S. Tsirkin wrote: On Wed, Jul 23, 2025 at 12:01:28PM +0300, Daniil Tatianin wrote: This is useful to be able to indicate various supported features to

Re: [PATCH] hw/smbios: add an ability to set extension bytes in the type0 table

2025-07-23 Thread Daniil Tatianin
On 7/23/25 12:14 PM, Michael S. Tsirkin wrote: On Wed, Jul 23, 2025 at 12:01:28PM +0300, Daniil Tatianin wrote: This is useful to be able to indicate various supported features to the guest, or freeze a specific version of SeaBIOS to prevent guest visible changes between BIOS updates. This is

[PATCH] hw/smbios: add an ability to set extension bytes in the type0 table

2025-07-23 Thread Daniil Tatianin
default. Signed-off-by: Daniil Tatianin --- hw/smbios/smbios.c | 66 +--- include/hw/firmware/smbios.h | 3 ++ 2 files changed, 64 insertions(+), 5 deletions(-) diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c index ad4cd6721e..73699e8a62 100644

Re: [PATCH] net/tap: drop too small packets

2025-07-03 Thread Daniil Tatianin
size < s->host_vnet_hdr_len) { +/* Invalid packet */ +break; +} + if (s->host_vnet_hdr_len && !s->using_vnet_hdr) { buf += s->host_vnet_hdr_len; size -= s->host_vnet_hdr_len; Reviewed-by: Daniil Tatianin

Re: [PATCH 0/3] vhost-user-blk: add an option to skip GET_VRING_BASE for force shutdown

2025-07-01 Thread Daniil Tatianin
Ping :) On 6/10/25 12:25 AM, Daniil Tatianin wrote: This series aims to address SIGTERM/QMP quit() being a bit too graceful in respect to devices. Both of the aforementioned ways to stop QEMU completely bypass the guest OS so in that sense they're basically equal to pulling the power plug

[PATCH 3/3] vhost-user-blk: add an option to skip GET_VRING_BASE for force shutdown

2025-06-09 Thread Daniil Tatianin
on called "skip-get-vring-base-on-force-shutdown" to allow SIGTERM/QMP quit() to actually act like a "force shutdown" at least for vhost-user-blk devices since those require the drain operation to shut down gracefully unlike, for example, network devices. Signed-off-by: Daniil

[PATCH 1/3] softmmu/runstate: add a way to detect force shutdowns

2025-06-09 Thread Daniil Tatianin
entirely and are equivalent to pulling the power plug. Signed-off-by: Daniil Tatianin --- include/system/runstate.h | 1 + system/runstate.c | 10 ++ 2 files changed, 11 insertions(+) diff --git a/include/system/runstate.h b/include/system/runstate.h index fdd5c4a517..b406a3960e

[PATCH 2/3] vhost: add a helper for force stopping a device

2025-06-09 Thread Daniil Tatianin
for whatever reason. Signed-off-by: Daniil Tatianin --- hw/virtio/vhost.c | 52 +-- include/hw/virtio/vhost.h | 15 +++ 2 files changed, 54 insertions(+), 13 deletions(-) diff --git a/hw/virtio/vhost.c b/hw/virtio/vhost.c index fc43853704

[PATCH 0/3] vhost-user-blk: add an option to skip GET_VRING_BASE for force shutdown

2025-06-09 Thread Daniil Tatianin
lk devices since those require the drain operation to shut down gracefully unlike, for example, network devices. Daniil Tatianin (3): softmmu/runstate: add a way to detect force shutdowns vhost: add a helper for force stopping a device vhost-user-blk: add an option to skip GET_VRING_BASE for force

Re: [PATCH v5 1/4] os: add an ability to lock memory on_fault

2025-02-12 Thread Daniil Tatianin
On 2/12/25 7:42 PM, Peter Xu wrote: On Wed, Feb 12, 2025 at 07:17:45PM +0300, Daniil Tatianin wrote: -static inline int os_mlock(void) +static inline int os_mlock(bool on_fault) { +(void)on_fault; Is this really needed ? Our compiler flags don't enable warnings about unused vari

Re: [PATCH v5 1/4] os: add an ability to lock memory on_fault

2025-02-12 Thread Daniil Tatianin
On 2/12/25 6:30 PM, Daniel P. Berrangé wrote: On Wed, Feb 12, 2025 at 05:39:17PM +0300, Daniil Tatianin wrote: This will be used in the following commits to make it possible to only lock memory on fault instead of right away. Signed-off-by: Daniil Tatianin --- include/system/os-posix.h

Re: [PATCH v5 1/4] os: add an ability to lock memory on_fault

2025-02-12 Thread Daniil Tatianin
On 2/12/25 6:23 PM, Peter Xu wrote: On Wed, Feb 12, 2025 at 05:39:17PM +0300, Daniil Tatianin wrote: This will be used in the following commits to make it possible to only lock memory on fault instead of right away. Signed-off-by: Daniil Tatianin --- include/system/os-posix.h | 2

Re: [PATCH v5 1/4] os: add an ability to lock memory on_fault

2025-02-12 Thread Daniil Tatianin
On 2/12/25 5:48 PM, Philippe Mathieu-Daudé wrote: Hi Daniil, On 12/2/25 15:39, Daniil Tatianin wrote: This will be used in the following commits to make it possible to only lock memory on fault instead of right away. Signed-off-by: Daniil Tatianin ---   include/system/os-posix.h |  2

[PATCH v5 3/4] system: introduce a new MlockState enum

2025-02-12 Thread Daniil Tatianin
Xu Signed-off-by: Daniil Tatianin --- hw/virtio/virtio-mem.c | 2 +- include/system/system.h | 10 +- migration/postcopy-ram.c | 2 +- system/globals.c | 7 ++- system/vl.c | 9 +++-- 5 files changed, 24 insertions(+), 6 deletions(-) diff --git a/hw

[PATCH v5 4/4] overcommit: introduce mem-lock=on-fault

2025-02-12 Thread Daniil Tatianin
lazily as they're faulted by the process by using MCL_ONFAULT if asked. Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Peter Xu Signed-off-by: Daniil Tatianin --- include/system/system.h | 2 ++ migration/postcopy-ram.c | 2 +- qemu-options.hx | 14 +- s

[PATCH v5 2/4] system/vl: extract overcommit option parsing into a helper

2025-02-12 Thread Daniil Tatianin
This will be extended in the future commits, let's move it out of line right away so that it's easier to read. Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Peter Xu Signed-off-by: Daniil Tatianin --- system/vl.c | 21 ++--- 1 file changed, 14 insert

[PATCH v5 1/4] os: add an ability to lock memory on_fault

2025-02-12 Thread Daniil Tatianin
This will be used in the following commits to make it possible to only lock memory on fault instead of right away. Signed-off-by: Daniil Tatianin --- include/system/os-posix.h | 2 +- include/system/os-win32.h | 3 ++- meson.build | 6 ++ migration/postcopy-ram.c | 2

[PATCH v5 0/4] overcommit: introduce mem-lock-onfault

2025-02-12 Thread Daniil Tatianin
ommit option parsing out of line - Make enable_mlock an enum instead Changes since v3: - Rebase to latest master due to the recent sysemu -> system renames Changes since v4: - Fix compile errors under FreeBSD and MacOS Daniil Tatianin (4): os: add an ability to lock memory on_fau

Re: [PULL 02/14] os: add an ability to lock memory on_fault

2025-02-12 Thread Daniil Tatianin
On 2/12/25 5:13 PM, Stefan Hajnoczi wrote: On Tue, Feb 11, 2025 at 5:52 PM Peter Xu wrote: From: Daniil Tatianin This will be used in the following commits to make it possible to only lock memory on fault instead of right away. Hi Peter and Daniil, Please take a look at this CI failure

Re: [PATCH v4 0/4] overcommit: introduce mem-lock-onfault

2025-02-04 Thread Daniil Tatianin
On 2/4/25 5:47 PM, Peter Xu wrote: On Tue, Feb 04, 2025 at 11:23:41AM +0300, Daniil Tatianin wrote: On 1/23/25 7:31 PM, Peter Xu wrote: On Thu, Jan 23, 2025 at 04:19:40PM +0300, Daniil Tatianin wrote: Currently, passing mem-lock=on to QEMU causes memory usage to grow by huge amounts: no

Re: [PATCH v4 0/4] overcommit: introduce mem-lock-onfault

2025-02-04 Thread Daniil Tatianin
On 1/23/25 7:31 PM, Peter Xu wrote: On Thu, Jan 23, 2025 at 04:19:40PM +0300, Daniil Tatianin wrote: Currently, passing mem-lock=on to QEMU causes memory usage to grow by huge amounts: no memlock: $ ./qemu-system-x86_64 -overcommit mem-lock=off $ ps -p $(pidof ./qemu-system-x86_64

[PATCH v4 2/4] system/vl: extract overcommit option parsing into a helper

2025-01-23 Thread Daniil Tatianin
This will be extended in the future commits, let's move it out of line right away so that it's easier to read. Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Peter Xu Signed-off-by: Daniil Tatianin --- system/vl.c | 21 ++--- 1 file changed, 14 insert

[PATCH v4 1/4] os: add an ability to lock memory on_fault

2025-01-23 Thread Daniil Tatianin
This will be used in the following commits to make it possible to only lock memory on fault instead of right away. Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Peter Xu Signed-off-by: Daniil Tatianin --- include/system/os-posix.h | 2 +- include/system/os-win32.h | 3

[PATCH v4 3/4] system: introduce a new MlockState enum

2025-01-23 Thread Daniil Tatianin
Xu Signed-off-by: Daniil Tatianin --- hw/virtio/virtio-mem.c | 2 +- include/system/system.h | 10 +- migration/postcopy-ram.c | 2 +- system/globals.c | 7 ++- system/vl.c | 9 +++-- 5 files changed, 24 insertions(+), 6 deletions(-) diff --git a/hw

[PATCH v4 4/4] overcommit: introduce mem-lock=on-fault

2025-01-23 Thread Daniil Tatianin
lazily as they're faulted by the process by using MCL_ONFAULT if asked. Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Peter Xu Signed-off-by: Daniil Tatianin --- include/system/system.h | 2 ++ migration/postcopy-ram.c | 2 +- qemu-options.hx | 14 +- s

[PATCH v4 0/4] overcommit: introduce mem-lock-onfault

2025-01-23 Thread Daniil Tatianin
ommit option parsing out of line - Make enable_mlock an enum instead Changes since v3: - Rebase to latest master due to the recent sysemu -> system renames Daniil Tatianin (4): os: add an ability to lock memory on_fault system/vl: extract overcommit option parsing into a helper

Re: [PATCH v3 4/4] overcommit: introduce mem-lock=on-fault

2025-01-21 Thread Daniil Tatianin
On 1/9/25 5:18 PM, Peter Xu wrote: On Thu, Jan 09, 2025 at 11:47:40AM +0300, Daniil Tatianin wrote: On 12/12/24 7:20 PM, Peter Xu wrote: On Thu, Dec 12, 2024 at 02:04:33AM +0300, Daniil Tatianin wrote: Locking the memory without MCL_ONFAULT instantly prefaults any mmaped anonymous memory

Re: [PATCH v3 4/4] overcommit: introduce mem-lock=on-fault

2025-01-09 Thread Daniil Tatianin
On 12/12/24 7:20 PM, Peter Xu wrote: On Thu, Dec 12, 2024 at 02:04:33AM +0300, Daniil Tatianin wrote: Locking the memory without MCL_ONFAULT instantly prefaults any mmaped anonymous memory with a write-fault, which introduces a lot of extra overhead in terms of memory usage when all you want

[PATCH v3 2/4] system/vl: extract overcommit option parsing into a helper

2024-12-11 Thread Daniil Tatianin
This will be extended in the future commits, let's move it out of line right away so that it's easier to read. Signed-off-by: Daniil Tatianin --- system/vl.c | 21 ++--- 1 file changed, 14 insertions(+), 7 deletions(-) diff --git a/system/vl.c b/system/vl.c index

[PATCH v3 0/4] overcommit: introduce mem-lock-onfault

2024-12-11 Thread Daniil Tatianin
ommit option parsing out of line - Make enable_mlock an enum instead Daniil Tatianin (4): os: add an ability to lock memory on_fault system/vl: extract overcommit option parsing into a helper sysemu: introduce a new MlockState enum overcommit: introduce mem-lock=on-fault hw/virtio/

[PATCH v3 4/4] overcommit: introduce mem-lock=on-fault

2024-12-11 Thread Daniil Tatianin
lazily as they're faulted by the process by using MCL_ONFAULT if asked. Signed-off-by: Daniil Tatianin --- include/sysemu/sysemu.h | 2 ++ migration/postcopy-ram.c | 2 +- qemu-options.hx | 14 +- system/globals.c | 7 ++- system/vl.c

[PATCH v3 1/4] os: add an ability to lock memory on_fault

2024-12-11 Thread Daniil Tatianin
This will be used in the following commits to make it possible to only lock memory on fault instead of right away. Reviewed-by: Vladimir Sementsov-Ogievskiy Reviewed-by: Peter Xu Signed-off-by: Daniil Tatianin --- include/sysemu/os-posix.h | 2 +- include/sysemu/os-win32.h | 3

[PATCH v3 3/4] sysemu: introduce a new MlockState enum

2024-12-11 Thread Daniil Tatianin
Replace the boolean value enable_mlock with an enum and add a helper to decide whether we should be calling os_mlock. This is a stepping stone towards introducing a new mlock mode, which will be the third possible state of this enum. Signed-off-by: Daniil Tatianin --- hw/virtio/virtio-mem.c

Re: [PATCH v2 2/2] overcommit: introduce mem-lock=on-fault

2024-12-11 Thread Daniil Tatianin
On 12/12/24 12:52 AM, Peter Xu wrote: On Wed, Dec 11, 2024 at 03:04:47AM +0300, Daniil Tatianin wrote: Locking the memory without MCL_ONFAULT instantly prefaults any mmaped anonymous memory with a write-fault, which introduces a lot of extra overhead in terms of memory usage when all you want

[PATCH v2 0/2] overcommit: introduce mem-lock-onfault

2024-12-10 Thread Daniil Tatianin
the early process heap (with brk(2) etc.) so it is still write-faulted in this case, but it's still way less than it was with just the mem-lock=on. Changes since v1: - Don't make a separate mem-lock-onfault, add an on-fault option to mem-lock instead Daniil Tatianin (2): os: ad

[PATCH v2 1/2] os: add an ability to lock memory on_fault

2024-12-10 Thread Daniil Tatianin
This will be used in the following commits to make it possible to only lock memory on fault instead of right away. Signed-off-by: Daniil Tatianin --- include/sysemu/os-posix.h | 2 +- include/sysemu/os-win32.h | 3 ++- migration/postcopy-ram.c | 2 +- os-posix.c| 10

[PATCH v2 2/2] overcommit: introduce mem-lock=on-fault

2024-12-10 Thread Daniil Tatianin
lazily as they're faulted by the process by using MCL_ONFAULT if asked. Signed-off-by: Daniil Tatianin --- include/sysemu/sysemu.h | 1 + migration/postcopy-ram.c | 4 ++-- qemu-options.hx | 14 +++- system/globals.c | 1 + system/vl.c

Re: [PATCH 0/2] overcommit: introduce mem-lock-onfault

2024-12-10 Thread Daniil Tatianin
On 12/10/24 8:20 PM, Peter Xu wrote: On Tue, Dec 10, 2024 at 08:01:08PM +0300, Daniil Tatianin wrote: I mentioned my use case in the cover letter. Basically we want to protect QEMU's pages from being migrated and compacted by kcompactd, which it accomplishes by modifying live page table

Re: [PATCH 0/2] overcommit: introduce mem-lock-onfault

2024-12-10 Thread Daniil Tatianin
On 12/10/24 7:48 PM, Peter Xu wrote: On Mon, Dec 09, 2024 at 10:40:51AM +0300, Daniil Tatianin wrote: On 12/6/24 4:08 AM, Peter Xu wrote: On Fri, Dec 06, 2024 at 02:19:06AM +0300, Daniil Tatianin wrote: Currently, passing mem-lock=on to QEMU causes memory usage to grow by huge amounts: no

Re: [PATCH 0/2] overcommit: introduce mem-lock-onfault

2024-12-08 Thread Daniil Tatianin
On 12/6/24 4:08 AM, Peter Xu wrote: On Fri, Dec 06, 2024 at 02:19:06AM +0300, Daniil Tatianin wrote: Currently, passing mem-lock=on to QEMU causes memory usage to grow by huge amounts: no memlock: $ qemu-system-x86_64 -overcommit mem-lock=off $ ps -p $(pidof ./qemu-system-x86_64) -o

[PATCH 1/2] os: add an ability to lock memory on_fault

2024-12-05 Thread Daniil Tatianin
This will be used in the following commits to make it possible to only lock memory on fault instead of right away. Signed-off-by: Daniil Tatianin --- include/sysemu/os-posix.h | 2 +- include/sysemu/os-win32.h | 3 ++- migration/postcopy-ram.c | 2 +- os-posix.c| 10

[PATCH 2/2] overcommit: introduce mem-lock-onfault

2024-12-05 Thread Daniil Tatianin
lazily as they're faulted by the process by using MCL_ONFAULT if asked. Signed-off-by: Daniil Tatianin --- include/sysemu/sysemu.h | 1 + migration/postcopy-ram.c | 4 ++-- qemu-options.hx | 13 ++--- system/globals.c | 1 + system/vl.c

[PATCH 0/2] overcommit: introduce mem-lock-onfault

2024-12-05 Thread Daniil Tatianin
ed for the early process heap (with brk(2) etc.) so it is still write-faulted in this case, but it's still way less than it was with just the mem-lock=on. Daniil Tatianin (2): os: add an ability to lock memory on_fault overcommit: introduce mem-lock-onfault include/sysemu/os-posix.h | 2 +-

[PATCH 0/2] finalize 'reconnect' deprecation

2024-10-25 Thread Daniil Tatianin
We've deprecated the 'reconnect' property in c8e2b6b4d7e, but all the tests, as well as the stream netdev were still left using it. This series finalizes the deprecation and replaces all local usage and docs metions of 'reconnect' with 'reconnect-ms'. Daniil Ta

[PATCH 1/2] net/stream: deprecate 'reconnect' in favor of 'reconnect-ms'

2024-10-25 Thread Daniil Tatianin
Do the same thing we already did for chardev in c8e2b6b4d7e, and introduce a new 'reconnect-ms' option to make it possible to specify sub-second timeouts. This also changes the related documentaion and tests to use reconnect-ms as well. Signed-off-by: Daniil Tatianin ---

[PATCH 2/2] chardev: finalize 'reconnect' deprecation

2024-10-25 Thread Daniil Tatianin
Change all related docs and tests to use the new 'reconnect-ms' option instead of the now deprecated 'reconnect'. Signed-off-by: Daniil Tatianin --- docs/COLO-FT.txt | 4 ++-- docs/system/ppc/powernv.rst | 2 +- qemu-options.hx | 22 +

Re: [PATCH v2] chardev: introduce 'reconnect-ms' and deprecate 'reconnect'

2024-10-10 Thread Daniil Tatianin
se as well. I'll have some time after next week. Thanks! On 13.09.24 12:46, Daniil Tatianin wrote: > The 'reconnect' option only allows to specify the time in seconds, > which is way too long for certain workflows. > > We have a lightweight disk b

[PATCH v2] chardev: introduce 'reconnect-ms' and deprecate 'reconnect'

2024-09-13 Thread Daniil Tatianin
an error. 'reconnect' is also deprecated by this commit to make it possible to remove it in the future as to not keep two options that control the same thing. Reviewed-by: Vladimir Sementsov-Ogievskiy Acked-by: Peter Krempa Signed-off-by: Daniil Tatianin --- Changes since v0: - Mention

Re: [PATCH v1] chardev: introduce 'reconnect-ms' and deprecate 'reconnect'

2024-09-13 Thread Daniil Tatianin
On 9/13/24 11:57 AM, Markus Armbruster wrote: Daniil Tatianin writes: The 'reconnect' option only allows to specify the time in seconds, which is way too long for certain workflows. We have a lightweight disk backend server, which takes about 20ms to live update, but due to this

Re: [PATCH v1] chardev: introduce 'reconnect-ms' and deprecate 'reconnect'

2024-09-11 Thread Daniil Tatianin
Ping :) I think this one should be good to go now! On 9/5/24 11:57 AM, Daniil Tatianin wrote: The 'reconnect' option only allows to specify the time in seconds, which is way too long for certain workflows. We have a lightweight disk backend server, which takes about 20ms to live u

[PATCH v1] chardev: introduce 'reconnect-ms' and deprecate 'reconnect'

2024-09-05 Thread Daniil Tatianin
an error. 'reconnect' is also deprecated by this commit to make it possible to remove it in the future as to not keep two options that control the same thing. Reviewed-by: Vladimir Sementsov-Ogievskiy Acked-by: Peter Krempa Signed-off-by: Daniil Tatianin --- Changes since v0: - Mention the d

[PATCH] chardev: introduce 'reconnect-ms' and deprecate 'reconnect'

2024-09-03 Thread Daniil Tatianin
an error. 'reconnect' is also deprecated by this commit to make it possible to remove it in the future as to not keep two options that control the same thing. Signed-off-by: Daniil Tatianin --- chardev/char-socket.c | 33 - chardev/char.c

Re: [PATCH] chardev: allow specifying finer-grained reconnect timeouts

2024-08-29 Thread Daniil Tatianin
On 8/29/24 2:56 PM, Markus Armbruster wrote: Daniil Tatianin writes: The "reconnect" option only allows to specify the time in seconds, which is way too long for certain workflows. We have a lightweight disk backend server, which takes about 20ms to live update, but due to this lim

[PATCH] chardev: allow specifying finer-grained reconnect timeouts

2024-08-16 Thread Daniil Tatianin
one second because it would take this long for QEMU to reinitialize the socket connection. Make it possible to specify a smaller timeout by treating the value in "reconnect" as milliseconds via the new "reconnect-is-ms" option. Signed-off-by: Daniil Tatianin --- chardev/char-

Re: [PATCH v4] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-08-15 Thread Daniil Tatianin
Ping:) 17.07.2024, 10:58, "Daniil Tatianin" :On 5/29/24 6:27 PM, Philippe Mathieu-Daudé wrote:  On 29/5/24 16:34, Markus Armbruster wrote: Daniil Tatianin <d-tatia...@yandex-team.ru> writes:  On 5/29/24 4:39 PM, Philippe Mathieu-Daudé wrote:  On 29/5/24 14:43, Daniil Tatianin wro

Re: [PATCH v4] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-07-22 Thread Daniil Tatianin
Ping :) Any ideas on this? On 7/17/24 10:57 AM, Daniil Tatianin wrote: On 5/29/24 6:27 PM, Philippe Mathieu-Daudé wrote: On 29/5/24 16:34, Markus Armbruster wrote: Daniil Tatianin writes: On 5/29/24 4:39 PM, Philippe Mathieu-Daudé wrote: On 29/5/24 14:43, Daniil Tatianin wrote: On 5

Re: [PATCH v4] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-07-17 Thread Daniil Tatianin
On 5/29/24 6:27 PM, Philippe Mathieu-Daudé wrote: On 29/5/24 16:34, Markus Armbruster wrote: Daniil Tatianin writes: On 5/29/24 4:39 PM, Philippe Mathieu-Daudé wrote: On 29/5/24 14:43, Daniil Tatianin wrote: On 5/29/24 3:36 PM, Philippe Mathieu-Daudé wrote: On 29/5/24 14:03, Markus

Re: [PATCH v4] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-06-17 Thread Daniil Tatianin
On 5/29/24 6:27 PM, Philippe Mathieu-Daudé wrote: On 29/5/24 16:34, Markus Armbruster wrote: Daniil Tatianin writes: On 5/29/24 4:39 PM, Philippe Mathieu-Daudé wrote: On 29/5/24 14:43, Daniil Tatianin wrote: On 5/29/24 3:36 PM, Philippe Mathieu-Daudé wrote: On 29/5/24 14:03, Markus

Re: [PATCH v4] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-05-29 Thread Daniil Tatianin
On 5/29/24 4:39 PM, Philippe Mathieu-Daudé wrote: On 29/5/24 14:43, Daniil Tatianin wrote: On 5/29/24 3:36 PM, Philippe Mathieu-Daudé wrote: On 29/5/24 14:03, Markus Armbruster wrote: Daniil Tatianin writes: This can be used to force-synchronize the time in guest after a long stop-cont

Re: [PATCH v4] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-05-29 Thread Daniil Tatianin
On 5/29/24 3:36 PM, Philippe Mathieu-Daudé wrote: On 29/5/24 14:03, Markus Armbruster wrote: Daniil Tatianin writes: This can be used to force-synchronize the time in guest after a long stop-cont pause, which can be useful for serverless-type workload. Also add a comment to highlight the

Re: [PATCH v4] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-05-29 Thread Daniil Tatianin
Thanks for the review Markus! I will fix the wording and add a "Bug:" clause for the next revision. On 5/29/24 3:03 PM, Markus Armbruster wrote: Daniil Tatianin writes: This can be used to force-synchronize the time in guest after a long stop-cont pause, which can be useful for

[PATCH v4] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-05-28 Thread Daniil Tatianin
Signed-off-by: Daniil Tatianin --- Changes since v0: - Rename to rtc-inject-irq to match other similar API - Add a comment to highlight that this only works for the I386 RTC Changes since v1: - Added a description below the QMP command to explain how it can be used and what it does. Changes since

Re: [PATCH v3] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-05-28 Thread Daniil Tatianin
On 5/27/24 8:01 PM, Philippe Mathieu-Daudé wrote: Hi Daniil, On 21/5/24 10:08, Daniil Tatianin wrote: Could you please take a look at this revision? I think I've taken everyone's feedback into account. Sorry for the delay, I missed your patch since you didn't Cc me (Markus a

Re: [PATCH v3] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-05-21 Thread Daniil Tatianin
Could you please take a look at this revision? I think I've taken everyone's feedback into account. Thank you! On 5/14/24 9:57 AM, Daniil Tatianin wrote: ping :) 06.05.2024, 11:34, "Daniil Tatianin" : This can be used to force-synchronize the time in guest after

Re: [PATCH v3] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-05-13 Thread Daniil Tatianin
ping :) 06.05.2024, 11:34, "Daniil Tatianin" :This can be used to force-synchronize the time in guest after a longstop-cont pause, which can be useful for serverless-type workload.Also add a comment to highlight the fact that this (and one other QMPcommand) only works for the MC

[PATCH v3] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-05-06 Thread Daniil Tatianin
This can be used to force-synchronize the time in guest after a long stop-cont pause, which can be useful for serverless-type workload. Also add a comment to highlight the fact that this (and one other QMP command) only works for the MC146818 RTC controller. Signed-off-by: Daniil Tatianin

Re: [PATCH] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-05-02 Thread Daniil Tatianin
On 4/29/24 4:39 PM, Philippe Mathieu-Daudé wrote: (+Peter who has more experience on such design). On 29/4/24 13:32, Markus Armbruster wrote: Philippe Mathieu-Daudé writes: Hi Daniil, Markus, On 26/4/24 10:39, Markus Armbruster wrote: Daniil Tatianin writes: This can be used to force

Re: [PATCH v1] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-04-29 Thread Daniil Tatianin
On 4/29/24 12:40 PM, Philippe Mathieu-Daudé wrote: On 29/4/24 11:34, Daniil Tatianin wrote: On 4/29/24 11:51 AM, Markus Armbruster wrote: Daniil Tatianin writes: This can be used to force-synchronize the time in guest after a long stop-cont pause, which can be useful for serverless-type

[PATCH v2] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-04-29 Thread Daniil Tatianin
This can be used to force-synchronize the time in guest after a long stop-cont pause, which can be useful for serverless-type workload. Also add a comment to highlight the fact that this (and one other QMP command) only works for the MC146818 RTC controller. Signed-off-by: Daniil Tatianin

Re: [PATCH v1] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-04-29 Thread Daniil Tatianin
On 4/29/24 11:51 AM, Markus Armbruster wrote: Daniil Tatianin writes: This can be used to force-synchronize the time in guest after a long stop-cont pause, which can be useful for serverless-type workload. Also add a comment to highlight the fact that this (and one other QMP command) only

[PATCH v1] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-04-27 Thread Daniil Tatianin
This can be used to force-synchronize the time in guest after a long stop-cont pause, which can be useful for serverless-type workload. Also add a comment to highlight the fact that this (and one other QMP command) only works for the MC146818 RTC controller. Signed-off-by: Daniil Tatianin

Re: [PATCH] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-04-26 Thread Daniil Tatianin
On 4/26/24 11:39 AM, Markus Armbruster wrote: Daniil Tatianin writes: This can be used to force-synchronize the time in guest after a long stop-cont pause, which can be useful for serverless-type workload. Signed-off-by: Daniil Tatianin --- hw/rtc/mc146818rtc.c | 15

[PATCH] mc146818rtc: add a way to generate RTC interrupts via QMP

2024-04-25 Thread Daniil Tatianin
This can be used to force-synchronize the time in guest after a long stop-cont pause, which can be useful for serverless-type workload. Signed-off-by: Daniil Tatianin --- hw/rtc/mc146818rtc.c | 15 +++ include/hw/rtc/mc146818rtc.h | 1 + qapi/misc-target.json| 16

Re: [PATCH v2 1/3] i386/a-b-bootblock: factor test memory addresses out into constants

2023-10-02 Thread Daniil Tatianin
Ping! :) 19.09.2023, 13:23, "Daniil Tatianin" :So that we have less magic numbers to deal with. This also allows us toreuse these in the following commits.Signed-off-by: Daniil Tatianin <d-tatia...@yandex-team.ru>Reviewed-by: Peter Xu <pet...@redhat.com>--- tests/migration/i3

Re: [PATCH 0/2] i386/a-b-bootblock: zero the first byte of each page on start

2023-09-26 Thread Daniil Tatianin
27.09.2023, 00:02, "Peter Xu" :On Thu, Sep 07, 2023 at 10:29:42PM +0300, Daniil Tatianin wrote: This series fixes an issue where the outcome of the migration qtest relies on the initial memory contents all being the same across the first 100MiB of RAM, which is a very fragile invarian

Re: [PATCH 2/2] i386/a-b-bootblock: zero the first byte of each page on start

2023-09-26 Thread Daniil Tatianin
26.09.2023, 23:41, "Vladimir Sementsov-Ogievskiy" :On 07.09.23 22:29, Daniil Tatianin wrote: The migration qtest all the way up to this point used to work by sheer luck relying on the contents of all pages from 1MiB to 100MiB to contain the same one value in the first byte initially.  T

Re: [PATCH 0/2] i386/a-b-bootblock: zero the first byte of each page on start

2023-09-26 Thread Daniil Tatianin
27.09.2023, 00:02, "Peter Xu" :On Thu, Sep 07, 2023 at 10:29:42PM +0300, Daniil Tatianin wrote: This series fixes an issue where the outcome of the migration qtest relies on the initial memory contents all being the same across the first 100MiB of RAM, which is a very fragile invarian

Re: [PATCH v2 0/3] migration-qtest: zero the first byte of each page on start

2023-09-26 Thread Daniil Tatianin
ping :)

[PATCH v2 0/3] migration-qtest: zero the first byte of each page on start

2023-09-19 Thread Daniil Tatianin
since v1: - Add a fix for the s390x test binary as well as suggested by Peter Xu Daniil Tatianin (3): i386/a-b-bootblock: factor test memory addresses out into constants i386/a-b-bootblock: zero the first byte of each page on start s390x/a-b-bios: zero the first byte of each page on start

[PATCH v2 2/3] i386/a-b-bootblock: zero the first byte of each page on start

2023-09-19 Thread Daniil Tatianin
test.c:300:check_guests_ram: assertion failed: (bad == 0) Fix this by always zeroing the first byte of each page in the range so that we get consistent results no matter the initial contents. Fixes: ea0c6d62391 ("test: Postcopy") Signed-off-by: Daniil Tatianin Reviewed-by: Peter Xu ---

[PATCH v2 3/3] s390x/a-b-bios: zero the first byte of each page on start

2023-09-19 Thread Daniil Tatianin
ation test on s390x, too") Signed-off-by: Daniil Tatianin --- tests/migration/s390x/a-b-bios.c | 8 + tests/migration/s390x/a-b-bios.h | 380 +-- 2 files changed, 211 insertions(+), 177 deletions(-) diff --git a/tests/migration/s390x/a-b-bios.c b/tests/migration

[PATCH v2 1/3] i386/a-b-bootblock: factor test memory addresses out into constants

2023-09-19 Thread Daniil Tatianin
So that we have less magic numbers to deal with. This also allows us to reuse these in the following commits. Signed-off-by: Daniil Tatianin Reviewed-by: Peter Xu --- tests/migration/i386/a-b-bootblock.S | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests

Re: [PATCH v1 0/2] i386/a-b-bootblock: zero the first byte of each page on start

2023-09-13 Thread Daniil Tatianin
ping 07.09.2023, 22:31, "Daniil Tatianin" :This series fixes an issue where the outcome of the migration qtestrelies on the initial memory contents all being the same across thefirst 100MiB of RAM, which is a very fragile invariant.We fix this by making sure we zero the first byt

[PATCH v1 0/2] i386/a-b-bootblock: zero the first byte of each page on start

2023-09-07 Thread Daniil Tatianin
This series fixes an issue where the outcome of the migration qtest relies on the initial memory contents all being the same across the first 100MiB of RAM, which is a very fragile invariant. We fix this by making sure we zero the first byte of every testable page in range beforehand. Daniil

[PATCH v1 2/2] i386/a-b-bootblock: zero the first byte of each page on start

2023-09-07 Thread Daniil Tatianin
test.c:300:check_guests_ram: assertion failed: (bad == 0) Fix this by always zeroing the first byte of each page in the range so that we get consistent results no matter the initial contents. Fixes: ea0c6d62391 ("test: Postcopy") Signed-off-by: Daniil Tatianin --- tests/migration/i386/

[PATCH v1 1/2] i386/a-b-bootblock: factor test memory addresses out into constants

2023-09-07 Thread Daniil Tatianin
So that we have less magic numbers to deal with. This also allows us to reuse these in the following commits. Signed-off-by: Daniil Tatianin --- tests/migration/i386/a-b-bootblock.S | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/migration/i386/a-b-bootblock.S

[PATCH 2/2] i386/a-b-bootblock: zero the first byte of each page on start

2023-09-07 Thread Daniil Tatianin
test.c:300:check_guests_ram: assertion failed: (bad == 0) Fix this by always zeroing the first byte of each page in the range so that we get consistent results no matter the initial contents. Fixes: ea0c6d62391 ("test: Postcopy") Signed-off-by: Daniil Tatianin --- tests/migration/i386/

[PATCH 1/2] i386/a-b-bootblock: factor test memory addresses out into constants

2023-09-07 Thread Daniil Tatianin
So that we have less magic numbers to deal with. This also allows us to reuse these in the following commits. Signed-off-by: Daniil Tatianin --- tests/migration/i386/a-b-bootblock.S | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/tests/migration/i386/a-b-bootblock.S

[PATCH 0/2] i386/a-b-bootblock: zero the first byte of each page on start

2023-09-07 Thread Daniil Tatianin
This series fixes an issue where the outcome of the migration qtest relies on the initial memory contents all being the same across the first 100MiB of RAM, which is a very fragile invariant. We fix this by making sure we zero the first byte of every testable page in range beforehand. Daniil

Re: [PATCH] replication: compile out some staff when replication is not configured

2023-04-13 Thread Daniil Tatianin
Just a few minor nits On 4/11/23 5:51 PM, Vladimir Sementsov-Ogievskiy wrote: Don't compile-in replication-related files when replication is disabled in config. Signed-off-by: Vladimir Sementsov-Ogievskiy --- Hi all! I'm unsure, should it be actually separate --disable-colo / --enable-colo o

Re: [PATCH 0/2] virtio-scsi: stop using aio_disable_external() during unplug

2023-04-04 Thread Daniil Tatianin
Reviewed-by: Daniil Tatianin

Re: [PATCH v0 0/4] backends/hostmem: add an ability to specify prealloc timeout

2023-01-23 Thread Daniil Tatianin
On 1/23/23 4:47 PM, Daniel P. Berrangé wrote: On Mon, Jan 23, 2023 at 04:30:03PM +0300, Daniil Tatianin wrote: On 1/23/23 11:57 AM, David Hildenbrand wrote: On 20.01.23 14:47, Daniil Tatianin wrote: This series introduces new qemu_prealloc_mem_with_timeout() api, which allows limiting the

Re: [PATCH v0 0/4] backends/hostmem: add an ability to specify prealloc timeout

2023-01-23 Thread Daniil Tatianin
On 1/23/23 11:57 AM, David Hildenbrand wrote: On 20.01.23 14:47, Daniil Tatianin wrote: This series introduces new qemu_prealloc_mem_with_timeout() api, which allows limiting the maximum amount of time to be spent on memory preallocation. It also adds prealloc statistics collection that is

[PATCH 3/4] backends/hostmem: add an ability to specify prealloc timeout

2023-01-20 Thread Daniil Tatianin
(no timeout) by default, and can be configured via the new 'prealloc-timeout' property. Signed-off-by: Daniil Tatianin --- backends/hostmem.c | 48 ++-- include/sysemu/hostmem.h | 2 ++ qapi/qom.json| 4 3 files changed, 52

[PATCH 2/4] backends/hostmem: move memory region preallocation logic into a helper

2023-01-20 Thread Daniil Tatianin
...so that we don't have to duplicate it in multiple places throughout the file. Signed-off-by: Daniil Tatianin --- backends/hostmem.c | 38 -- 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/backends/hostmem.c b/backends/hostmem.c

[PATCH v0 0/4] backends/hostmem: add an ability to specify prealloc timeout

2023-01-20 Thread Daniil Tatianin
configured to either simply emit a warning and continue VM startup without having preallocated the entire guest RAM or just abort startup entirely if that is not acceptable for a specific use case. Daniil Tatianin (4): oslib: introduce new qemu_prealloc_mem_with_timeout() api backends/hostmem

[PATCH 4/4] backends/hostmem: add an ability to make prealloc timeout fatal

2023-01-20 Thread Daniil Tatianin
This is controlled via the new 'prealloc-timeout-fatal' property and can be useful for cases when we cannot afford to not preallocate all guest pages while being time constrained. Signed-off-by: Daniil Tatianin --- backends/hostmem.c | 38 ++---

[PATCH 1/4] oslib: introduce new qemu_prealloc_mem_with_timeout() api

2023-01-20 Thread Daniil Tatianin
tion is currently a stub that just calls into the old qemu_prealloc_mem api. Signed-off-by: Daniil Tatianin --- include/qemu/osdep.h | 19 util/oslib-posix.c | 114 +++ util/oslib-win32.c | 9 3 files changed, 133 insertions(+), 9 delet

Re: [PATCH v3 0/5] vhost-user-blk: dynamically resize config space based on features

2022-10-11 Thread Daniil Tatianin
Ping :) On 9/6/22 10:31 AM, Daniil Tatianin wrote: This patch set attempts to align vhost-user-blk with virtio-blk in terms of backward compatibility and flexibility. It also improves the virtio core by introducing new common code that can be used by a virtio device to calculate its config

Re: [PATCH v3 0/5] vhost-user-blk: dynamically resize config space based on features

2022-10-11 Thread Daniil Tatianin
On 10/11/22 10:20 AM, Daniil Tatianin wrote: Ping :) Oops, didn't see the pull request. Disregard this. On 9/6/22 10:31 AM, Daniil Tatianin wrote: This patch set attempts to align vhost-user-blk with virtio-blk in terms of backward compatibility and flexibility. It also improve

  1   2   >