On Fri, Jul 11, 2025 at 05:11:02PM -0400, Zhuoying Cai wrote:
> The current approach to enabling secure boot relies on providing
> -secure-boot and -boot-certificates options, which apply to all boot
> devices.
This reference of -secure-boot and -boot-certificates presumably
is a left over from an
On Fri, Jul 11, 2025 at 05:10:47PM -0400, Zhuoying Cai wrote:
> Introduce helper functions to support signature verification required by
> DIAG 508 subcode 1:
>
> qcrypto_pkcs7_convert_sig_pem() – converts a signature from DER to PEM format
> qcrypto_x509_verify_sig() – verifies the provided data
On Fri, Jul 11, 2025 at 05:10:39PM -0400, Zhuoying Cai wrote:
> Create a certificate store for boot certificates used for secure IPL.
>
> Load certificates from the boot-certificate parameter of s390-ccw-virtio
> machine type option into the cert store.
>
> Currently, only X.509 certificates in P
On Fri, Jul 11, 2025 at 05:10:45PM -0400, Zhuoying Cai wrote:
> DIAG 320 subcode 2 provides verification-certificates (VCs) that are in the
> certificate store. Only X509 certificates in DER format and SHA-256 hash
> type are recognized.
>
> The subcode value is denoted by setting the second-left-
On Fri, Jul 11, 2025 at 05:10:44PM -0400, Zhuoying Cai wrote:
> Introduce new helper functions to extract certificate metadata needed for
> DIAG 320 subcode 2:
>
> qcrypto_x509_get_cert_version() - retrieves version of a certificate
> qcrypto_x509_check_cert_times() - validates the certificate's v
On Fri, Jul 11, 2025 at 05:10:38PM -0400, Zhuoying Cai wrote:
> Introduce new helper functions for x509 certificate, which will be used
> by the certificate store:
>
> qcrypto_x509_convert_cert_der() - converts a certificate from PEM to DER
> format
> qcrypto_x509_get_keyid_len() - returns the le
On Fri, Jul 11, 2025 at 05:10:37PM -0400, Zhuoying Cai wrote:
> Add boot-certificates as a parameter of s390-ccw-virtio machine type option.
>
> The `boot-certificates=/path/dir:/path/file` parameter is implemented
> to provide path to either a directory or a single certificate.
>
> Multiple path
On Tue, Jul 22, 2025 at 06:27:45PM +0800, Xiaoyao Li wrote:
> On 7/22/2025 5:21 PM, Mathias Krause wrote:
> > On 22.07.25 05:45, Xiaoyao Li wrote:
> > > On 6/20/2025 3:42 AM, Mathias Krause wrote:
> > > > KVM has a weird behaviour when a guest executes VMCALL on an AMD system
> > > > or VMMCALL on
On Fri, Jul 18, 2025 at 03:20:35PM +0200, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Fri, Jul 18, 2025 at 07:59:50AM +0200, Markus Armbruster wrote:
> >> Markus Armbruster writes:
> >>
> >> > Adam Williamson writes:
> >>
On Mon, Jul 21, 2025 at 02:10:51PM -0400, Stefan Hajnoczi wrote:
> From: Vladimir Sementsov-Ogievskiy
>
> So tired to parse all these timestamps, when need to compare them
> with other logs.
>
> Use iso8601 format as in warn_report() (info_report(), error_report())
> already used.
>
> Also, sta
19:39 qemu-system-x86_64
$ strip qemu-system-x86_64
$ ls -alh qemu-system-x86_64
-rwxr-xr-x. 1 berrange berrange 30M Jul 21 19:39 qemu-system-x86_64
and after:
$ ls -alh qemu-system-x86_64
-rwxr-xr-x. 1 berrange berrange 85M Jul 21 19:41 qemu-system-x86_64
$ strip qemu-system-x86_64
On Mon, Jul 21, 2025 at 12:14:51PM -0300, Fabiano Rosas wrote:
> Daniel P. Berrangé writes:
>
> > On Mon, Jul 21, 2025 at 11:56:09AM -0300, Fabiano Rosas wrote:
> >> Daniel P. Berrangé writes:
> >>
> >> > TL:DR: GNUTLS is liable to crash QEMU when liv
On Mon, Jul 21, 2025 at 11:56:09AM -0300, Fabiano Rosas wrote:
> Daniel P. Berrangé writes:
>
> > TL:DR: GNUTLS is liable to crash QEMU when live migration is run
> > with TLS enabled and a return path channel is present, if approx
> > 64 GB of data is transferred. This
On Mon, Jul 21, 2025 at 07:24:23PM +0530, Arun Menon wrote:
> Hi,
> Thank you for the review.
>
> On Mon, Jul 21, 2025 at 02:32:48PM +0100, Daniel P. Berrangé wrote:
> > On Mon, Jul 21, 2025 at 04:59:28PM +0530, Arun Menon wrote:
> > > - We need to have good error re
The 'info migrate' command only shows the error message when the
migration state is 'failed'. When postcopy is used, however,
the 'postcopy-paused' state is used instead of 'failed', so we
must show the error message there too.
Signed-off-by: Daniel P
On Mon, Jul 21, 2025 at 04:59:28PM +0530, Arun Menon wrote:
> - We need to have good error reporting in the callbacks in
> VMStateDescription struct. Specifically pre_save, post_save,
> pre_load and post_load callbacks.
> - It is not possible to change these functions everywhere in one
> patc
On Mon, Jul 21, 2025 at 10:14:30PM +0900, Akihiko Odaki wrote:
> On 2025/07/21 20:29, Arun Menon wrote:
> > - We need to have good error reporting in the callbacks in
> >VMStateDescription struct. Specifically pre_save, post_save,
> >pre_load and post_load callbacks.
> > - It is not possibl
4
> migration/migration.c | 12 ++--
> migration/qemu-file.c | 1 -
> migration/savevm.c| 4
> 4 files changed, 2 insertions(+), 19 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flick
: Daniel P. Berrangé
Signed-off-by: Henry Kleynhans
[DB: drop MAX_CERTS constant & whitespace tweaks]
Signed-off-by: Daniel P. Berrangé
---
crypto/tlscredsx509.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/crypto/tlscredsx509.c b/cr
ed-by: Daniel P. Berrangé
Signed-off-by: Daniel P. Berrangé
---
crypto/x509-utils.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/crypto/x509-utils.c b/crypto/x509-utils.c
index 8bad00a51b..39bb6d4d8c 100644
--- a/crypto/x509-utils.c
+++ b/crypto/x509-utils.c
@@ -46,
This lets us see the full flow of RFB messages received from the
client.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
Signed-off-by: Daniel P. Berrangé
---
ui/trace-events | 14 +
ui/vnc.c| 52 +
2 files
ed to any problems, but
the classical 'vncviewer' app will show the problem easily.
Fixes: 7ed96710e82c385c6cfc3d064eec7dde20f0f3fd
Reported-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
Signed-off-by: Daniel P. Berrangé
---
ui/vnc.c | 1 +
1 file changed,
* Add more trace events for VNC messages
* Fix checking of certificate loading
* Eliminate cert limit on loading CA certificates
----
Daniel P. Berrangé (2):
ui: fix setting client_endian field defaults
ui: add trace events for
patches can soon do:
https://lists.libvirt.org/archives/list/de...@lists.libvirt.org/thread/LX5KMIUFZSP5DPUXKJDFYBZI5TIE3E5N/
Daniel P. Berrangé (4):
crypto: implement workaround for GNUTLS thread safety problems
io: add support for activating TLS thread safety workaround
migration: a
rates,
the inbound direction is low volume.
Signed-off-by: Daniel P. Berrangé
---
crypto/tlssession.c | 89 +--
include/crypto/tlssession.h | 14 ++
meson.build | 9
meson_options.txt | 2 +
scripts/meson-buildoptio
Add a QIO_CHANNEL_FEATURE_CONCURRENT_IO feature flag.
If this is set on a QIOChannelTLS session object, the TLS
session will be marked as requiring thread safety, which
will activate the workaround for GNUTLS bug 1717 if needed.
Signed-off-by: Daniel P. Berrangé
---
include/io/channel.h | 1
We want some visibility on stderr when the GNUTLS thread
safety countermeasures are activated, to encourage people
to get the real fix deployed (once it exists). Some trace
points will also help if we see any further wierd crash
scenario we've not anticipated.
Reviewed-by: Daniel P. Ber
workarounds for
GNUTLS bug 1717
Closes: https://gitlab.com/qemu-project/qemu/-/issues/1937
Signed-off-by: Daniel P. Berrangé
---
migration/tls.c | 9 +
1 file changed, 9 insertions(+)
diff --git a/migration/tls.c b/migration/tls.c
index 5cbf952383..284a6194b2 100644
--- a/migration/tls.c
cy on GIO for the passt
> option.
> The existing dependency on linux is kept because passt is only available
> on this OS.
>
> Reported-by: Thomas Huth
> Signed-off-by: Laurent Vivier
> ---
> meson.build | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-
On Thu, Jul 17, 2025 at 01:34:13PM +0300, Manos Pitsidianakis wrote:
> Add argument parsing to functional tests to improve developer experience
> when running individual tests. All logs are printed to stdout
> interspersed with TAP output.
>
> Example usage, assuming current build directory with q
On Fri, Jul 18, 2025 at 07:59:50AM +0200, Markus Armbruster wrote:
> Markus Armbruster writes:
>
> > Adam Williamson writes:
> >
> >> In cfcacba an `error_report` was added to this file, but the
> >> corresponding include of `qemu/error-report.h` was missed. This
> >> only becomes apparent when
On Thu, Jul 17, 2025 at 06:07:43AM +0530, Arun Menon wrote:
> This is an incremental step in converting vmstate loading
> code to report error via Error objects instead of directly
> printing it to console/monitor.
> It is ensured that qemu_load_device_state() must report an error
> in errp, in cas
om/browse/RHEL-82826
>
> Reviewed-by: Stefan Berger
> Signed-off-by: Arun Menon
> ---
> backends/tpm/tpm_emulator.c | 39 ++++---
> 1 file changed, 20 insertions(+), 19 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
D
On Thu, Jul 17, 2025 at 06:07:45AM +0530, Arun Menon wrote:
> - We need to have good error reporting in the callbacks in
> VMStateDescription struct. Specifically pre_save, post_save,
> pre_load and post_load callbacks.
> - It is not possible to change these functions everywhere in one
> patc
On Thu, Jul 17, 2025 at 06:07:42AM +0530, Arun Menon wrote:
> This is an incremental step in converting vmstate loading
> code to report error via Error objects instead of directly
> printing it to console/monitor.
> It is ensured that qemu_loadvm_state() must report an error
> in errp, in case of
On Thu, Jul 17, 2025 at 06:07:44AM +0530, Arun Menon wrote:
> This is an incremental step in converting vmstate loading
> code to report error via Error objects instead of directly
> printing it to console/monitor.
> postcopy_ram_listen_thread() calls qemu_loadvm_state_main()
> to load the vm, and
rtions(+), 13 deletions(-)
Reviewed-by: Daniel P. Berrangé
>
> diff --git a/migration/colo.c b/migration/colo.c
> index
> e0f713c837f5da25d67afbd02ceb6c54024ca3af..ddc628cab4194b3cb82388c5e878286c820004b2
> 100644
> --- a/migration/colo.c
> +++ b/migration/colo.c
> @@ -68
gt; an error in errp, in case of failure.
>
> Signed-off-by: Arun Menon
> ---
> migration/savevm.c | 10 +++---
> 1 file changed, 3 insertions(+), 7 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.
or
> in errp, in case of failure.
>
> Signed-off-by: Arun Menon
> ---
> migration/savevm.c | 18 +++---
> 1 file changed, 7 insertions(+), 11 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://w
On Thu, Jul 17, 2025 at 05:54:41PM +0100, Daniel P. Berrangé wrote:
> On Thu, Jul 17, 2025 at 06:07:30AM +0530, Arun Menon wrote:
> > This is an incremental step in converting vmstate loading
> > code to report error via Error objects instead of directly
> > printing it to co
gt; in errp, in case of failure.
>
> Signed-off-by: Arun Menon
> ---
> migration/savevm.c | 22 ++
> 1 file changed, 10 insertions(+), 12 deletions(-)
Reviewed-by: Daniel P. Berrangé
>
> diff --git a/migration/s
> {
> if (mis->state != MIGRATION_STATUS_POSTCOPY_RECOVER) {
> error_report("%s: illegal resume received", __func__);
Pre-existing mistake, but can you change this to 'warn_report' given that
we're not treating it as an error.
Aside from that
R
or
> in errp, in case of failure.
>
> Signed-off-by: Arun Menon
> ---
> migration/savevm.c | 12
> 1 file changed, 4 insertions(+), 8 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.co
or
> in errp, in case of failure.
>
> Signed-off-by: Arun Menon
> ---
> migration/savevm.c | 39 +--
> 1 file changed, 17 insertions(+), 22 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com
On Thu, Jul 17, 2025 at 12:34:21PM +0900, Akihiko Odaki wrote:
> On 2025/07/17 9:37, Arun Menon wrote:
> > This is an incremental step in converting vmstate loading
> > code to report error via Error objects instead of directly
> > printing it to console/monitor.
> > It is ensured that ram_postcopy
or
> in errp, in case of failure.
>
> Signed-off-by: Arun Menon
> ---
> migration/savevm.c | 18 --
> 1 file changed, 8 insertions(+), 10 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://w
On Thu, Jul 17, 2025 at 06:07:29AM +0530, Arun Menon wrote:
> This is an incremental step in converting vmstate loading
> code to report error via Error objects instead of directly
> printing it to console/monitor.
> It is ensured that qemu_loadvm_section_part_end() must report an error
> in errp,
On Thu, Jul 17, 2025 at 06:07:27AM +0530, Arun Menon wrote:
> This is an incremental step in converting vmstate loading
> code to report error via Error objects instead of directly
> printing it to console/monitor.
> It is ensured that vmstate_load() must report an error
> in errp, in case of failu
On Thu, Jul 17, 2025 at 06:07:30AM +0530, Arun Menon wrote:
> This is an incremental step in converting vmstate loading
> code to report error via Error objects instead of directly
> printing it to console/monitor.
> It is ensured that loadvm_process_command() must report an error
> in errp, in cas
On Thu, Jul 17, 2025 at 06:07:25AM +0530, Arun Menon wrote:
> This is an incremental step in converting vmstate loading
> code to report error via Error objects instead of directly
> printing it to console/monitor.
> It is ensured that vmstate_load_state() must report an error
> in errp, in case of
On Thu, Jul 17, 2025 at 06:07:28AM +0530, Arun Menon wrote:
> This is an incremental step in converting vmstate loading
> code to report error via Error objects instead of directly
> printing it to console/monitor.
> It is ensured that qemu_loadvm_section_start_full() must report an error
> in errp
On Thu, Jul 17, 2025 at 06:07:26AM +0530, Arun Menon wrote:
> This is an incremental step in converting vmstate loading
> code to report error via Error objects instead of directly
> printing it to console/monitor.
> It is ensured that qemu_loadvm_state_header() must report an error
> in errp, in c
On Thu, Jul 17, 2025 at 06:07:24AM +0530, Arun Menon wrote:
> This is an incremental step in converting vmstate loading
> code to report error via Error objects instead of directly
> printing it to console/monitor.
> It is ensured that vmstate_subsection_load() must report an error
> in errp, in ca
On Thu, Jul 17, 2025 at 05:17:42PM +0200, Cornelia Huck wrote:
> On Tue, Jul 15 2025, Daniel P. Berrangé wrote:
>
> > On Tue, Jul 15, 2025 at 09:16:24AM -0700, Andrea Bolognani wrote:
> >> On Tue, Jul 15, 2025 at 05:02:54PM +0100, Daniel P. Berrangé wrote:
> >> &
On Thu, Jul 17, 2025 at 03:30:06PM +0200, Stefano Garzarella wrote:
> On Wed, 16 Jul 2025 at 13:31, Daniel P. Berrangé wrote:
> >
> > On Mon, Jul 14, 2025 at 01:03:06PM +0200, Paolo Bonzini wrote:
> > > From: Roy Hopkins
> > >
> > > The IGVM library allo
On Tue, Jul 15, 2025 at 09:45:51AM -0300, Fabiano Rosas wrote:
> Coverity has caught a bug in the formatting of time intervals for
> postcopy latency distribution display in 'info migrate'.
>
> While bounds checking the labels array, sizeof is incorrectly being
> used. ARRAY_SIZE is the correct fo
> qapi/dump.json | 2 +-
> qapi/machine.json | 2 +-
> qapi/migration.json | 4 ++--
> qapi/misc-i386.json | 2 +-
> qapi/run-state.json | 2 +-
> qapi/sockets.json | 2 +-
> 6 files changed, 7 insertions(+), 7 deletions(-)
Reviewed-by: Daniel P. Berrangé
With rega
ga/qapi-schema.json | 80 ++--
> 1 file changed, 40 insertions(+), 40 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https://www.flickr.com/photos/dberrange :|
|: https://libvirt.org -o-
On Thu, Jul 17, 2025 at 11:41:05AM +0100, Alex Bennée wrote:
> Signed-off-by: Alex Bennée
> ---
> docs/devel/testing/functional.rst | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com
89 ("i386/tdx: handle TDG.VP.VMCALL")
> Reported-by: Peter Maydell
> Signed-off-by: Xiaoyao Li
> ---
> target/i386/kvm/tdx.c | 2 --
> 1 file changed, 2 deletions(-)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-https
On Thu, Jul 17, 2025 at 12:27:08PM +0300, Manos Pitsidianakis wrote:
> On Thu, Jul 17, 2025 at 12:22 PM Daniel P. Berrangé
> wrote:
> >
> > On Wed, Jul 16, 2025 at 09:08:00AM +0300, Manos Pitsidianakis wrote:
> > > Add argument parsing to functional tests to i
On Wed, Jul 16, 2025 at 09:08:00AM +0300, Manos Pitsidianakis wrote:
> Add argument parsing to functional tests to improve developer experience
> when running individual tests. All logs are printed to stdout
> interspersed with TAP output.
>
> ./pyvenv/bin/python3 ../tests/functional/test_aarch6
ga/qapi-schema.json | 50 ++--
> 1 file changed, 25 insertions(+), 25 deletions(-)
Reviewed-by: Daniel P. Berrangé
> @@ -585,7 +585,7 @@
> # - pm-utils (via pm-hibernate)
> # - manual write into sysfs
> #
> -# IMPORTANT: guest-susp
type.
>
> We did this for qapi/ in commit f7296f8de5c (qapi: rephrase return
> docs to avoid type name).
>
> Signed-off-by: Markus Armbruster
> ---
> qga/qapi-schema.json | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
Reviewed-by: Daniel P. Berrangé
W
gt;
> The auto-generated returns all are in the exact same spot.
>
> We did this for qapi/ in commit 0462da9d6b1 (qapi: remove trivial
> "Returns:" sections).
>
> Signed-off-by: Markus Armbruster
> ---
> qga/qapi-schema.json | 25 -
> 1
ommit 8e326d36dd16 (qga/linux: Add new api 'guest-network-get-route')
> Signed-off-by: Markus Armbruster
> ---
> qga/qapi-schema.json | 1 +
> 1 file changed, 1 insertion(+)
Reviewed-by: Daniel P. Berrangé
With regards,
Daniel
--
|: https://berrange.com -o-
On Wed, Jul 16, 2025 at 06:07:31PM +0300, Michael Tokarev wrote:
> On 15.07.2025 09:32, marcandre.lur...@redhat.com wrote:
> > From: Akihiko Odaki
> >
> > vnc_worker_thread_loop() copies z_stream stored in its local VncState to
> > the persistent VncState, and the copied one is freed with deflate
On Mon, Jul 14, 2025 at 01:03:06PM +0200, Paolo Bonzini wrote:
> From: Roy Hopkins
>
> The IGVM library allows Independent Guest Virtual Machine files to be
> parsed and processed. IGVM files are used to configure guest memory
> layout, initial processor state and other configuration pertaining t
On Wed, Jul 16, 2025 at 12:41:31PM +0200, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Tue, Jul 15, 2025 at 10:35:16AM +0200, Philippe Mathieu-Daudé wrote:
> >> @errp is always NULL. Remove it, as unused.
> >>
> >> Signed-off-by: Philipp
ed to any problems, but
the classical 'vncviewer' app will show the problem easily.
Fixes: 7ed96710e82c385c6cfc3d064eec7dde20f0f3fd
Reported-by: Thomas Huth
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
Signed-off-by: Daniel P. Berrangé
---
ui/vnc.c | 1 +
1 file changed,
* Add more trace events for VNC messages
* Fix checking of certificate loading
* Eliminate cert limit on loading CA certificates
----
Daniel P. Berrangé (2):
ui: fix setting client_endian field defaults
ui: add trace events for
: Daniel P. Berrangé
Signed-off-by: Henry Kleynhans
[DB: drop MAX_CERTS constant & whitespace tweaks]
Signed-off-by: Daniel P. Berrangé
---
crypto/tlscredsx509.c | 23 +++
1 file changed, 11 insertions(+), 12 deletions(-)
diff --git a/crypto/tlscredsx509.c b/cr
ed-by: Daniel P. Berrangé
Signed-off-by: Daniel P. Berrangé
---
crypto/x509-utils.c | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/crypto/x509-utils.c b/crypto/x509-utils.c
index 8bad00a51b..39bb6d4d8c 100644
--- a/crypto/x509-utils.c
+++ b/crypto/x509-utils.c
@@ -46,
This lets us see the full flow of RFB messages received from the
client.
Reviewed-by: Philippe Mathieu-Daudé
Reviewed-by: Marc-André Lureau
Signed-off-by: Daniel P. Berrangé
---
ui/trace-events | 14 +
ui/vnc.c| 52 +
2 files
On Wed, Jul 16, 2025 at 11:36:48AM +0200, Cédric Le Goater wrote:
> On 7/16/25 11:28, Daniel P. Berrangé wrote:
> > On Wed, Jul 16, 2025 at 09:15:54AM +0200, Cédric Le Goater wrote:
> > > Recent changes broke build on 32-bit host. Since there is no 32-bit
> > > supp
ertion(+), 1 deletion(-)
Reviewed-by: Daniel P. Berrangé
Matches what we just did for TDX too.
>
> diff --git a/hw/i386/Kconfig b/hw/i386/Kconfig
> index
> 14d23e27b580b2d5ea3aa4c07ba066f21a62e348..5139d2308777114e76a789c4f850fa20f3fa754f
> 100644
> --- a/hw/i386/Kconfig
> +++
On Wed, Jul 16, 2025 at 10:23:26AM +0200, Markus Armbruster wrote:
> Philippe Mathieu-Daudé writes:
>
> > Hi Markus,
>
> I missed this one, sorry!
>
> > On 3/7/25 12:54, Philippe Mathieu-Daudé wrote:
> >> Extract TCG and KVM definitions from machine.json to accelerator.json.
> >> Signed-off-by:
On Wed, Jul 16, 2025 at 08:13:09AM +, Bernhard Beschow wrote:
>
>
> Am 15. Juli 2025 13:45:08 UTC schrieb "Daniel P. Berrangé"
> :
> >On Fri, Jul 11, 2025 at 12:00:24PM +0100, Daniel P. Berrangé wrote:
> >> On Fri, Jul 11, 2025 at 11:45:08AM +0100, Peter
On Tue, Jul 15, 2025 at 09:16:24AM -0700, Andrea Bolognani wrote:
> On Tue, Jul 15, 2025 at 05:02:54PM +0100, Daniel P. Berrangé wrote:
> > On Tue, Jul 15, 2025 at 05:44:25PM +0200, Cornelia Huck wrote:
> > > Hmm. So
> > > - request a new PCI id (probably in the P
On Tue, Jul 15, 2025 at 11:46:31AM +0200, Philippe Mathieu-Daudé wrote:
> On 15/7/25 11:29, Daniel P. Berrangé wrote:
> > From: matoro
>
> Should we use here?
I generally don't like to change the git metadata that a user
submits with unless it is clearly broken, which I don
On Tue, Jul 15, 2025 at 05:44:25PM +0200, Cornelia Huck wrote:
> On Tue, Jul 15 2025, Andrea Bolognani wrote:
>
> > On Tue, Jun 10, 2025 at 06:12:12PM +0100, Daniel P. Berrangé wrote:
> >> On Tue, Jun 10, 2025 at 04:32:59PM +0200, Cornelia Huck wrote:
> >> > The
This avoids a resource leak warning from python when the
log handler is garbage collected.
Signed-off-by: Daniel P. Berrangé
---
tests/functional/qemu_test/testcase.py | 2 ++
1 file changed, 2 insertions(+)
diff --git a/tests/functional/qemu_test/testcase.py
b/tests/functional/qemu_test
On Tue, Jul 15, 2025 at 05:03:07PM +0200, Thomas Huth wrote:
> On 15/07/2025 16.30, Daniel P. Berrangé wrote:
> > The multiprocess and virtio_gpu tests open sockets but then forget
> > to close them, which triggers resource leak warnings
> >
> > The virtio_gpu test als
Our minimum python is now 3.9, so back compat with python
3.6 is no longer required.
Signed-off-by: Daniel P. Berrangé
---
python/qemu/qmp/protocol.py | 3 +--
python/qemu/qmp/util.py | 16
2 files changed, 1 insertion(+), 18 deletions(-)
diff --git a/python/qemu/qmp
Our minimum python is now 3.9, so back compat with python
3.6 is no longer required.
Signed-off-by: Daniel P. Berrangé
---
python/qemu/qmp/protocol.py | 7 +++
python/qemu/qmp/qmp_tui.py | 8
python/qemu/qmp/util.py | 33 +
python/tests
We need to call get_event_loop but have no way of knowing ahead
of time whether the current thread has an event loop of not. We
can handle a missing event loop, but we need to hide the warning
python will emit to avoid tripping up iotests expected output.
Signed-off-by: Daniel P. Berrangé
Our minimum python is now 3.9, so back compat with python
3.6 is no longer required.
Signed-off-by: Daniel P. Berrangé
---
python/qemu/qmp/protocol.py | 3 +--
python/qemu/qmp/util.py | 29 -
2 files changed, 1 insertion(+), 31 deletions(-)
diff --git a/python
While QEMUQtestMachine closes the socket that was passed to
QEMUQtestProtocol, the python resource leak manager still
believes that the copy QEMUQtestProtocol holds is open. We
must explicitly call close to avoid this leak warnnig.
Signed-off-by: Daniel P. Berrangé
---
python/qemu/machine
.
Signed-off-by: Daniel P. Berrangé
---
tests/qemu-iotests/check | 4
1 file changed, 4 insertions(+)
diff --git a/tests/qemu-iotests/check b/tests/qemu-iotests/check
index 545f9ec7bd..d9b7c1d598 100755
--- a/tests/qemu-iotests/check
+++ b/tests/qemu-iotests/check
@@ -21,6 +21,7 @@ import sys
This avoids the python resource leak detector from issuing warnings
in the iotests.
Signed-off-by: Daniel P. Berrangé
---
tests/qemu-iotests/147 | 1 +
1 file changed, 1 insertion(+)
diff --git a/tests/qemu-iotests/147 b/tests/qemu-iotests/147
index 6d6f077a14..3e14bd389a 100755
--- a/tests
Our minimum python is now 3.9, so back compat with prior
python versions is no longer required.
Signed-off-by: Daniel P. Berrangé
---
tests/qemu-iotests/testenv.py| 7 ++-
tests/qemu-iotests/testrunner.py | 9 ++---
2 files changed, 4 insertions(+), 12 deletions(-)
diff --git a
7;
but this doesn't cover all possible iotest usage. So there
might still be some resource leaks hiding in there which will
cause failures for devs running tests with unusual config
scenarios.
Daniel P. Berrangé (13):
python: avoid deprecation warning with get_event_loop
python: drop '
Our minimum python is now 3.9, so back compat with python
3.6 is no longer required.
Signed-off-by: Daniel P. Berrangé
---
python/qemu/qmp/util.py | 19 ---
python/tests/protocol.py | 2 +-
2 files changed, 1 insertion(+), 20 deletions(-)
diff --git a/python/qemu/qmp/util.py
-by: Daniel P. Berrangé
---
tests/qemu-iotests/151 | 5 +
1 file changed, 5 insertions(+)
diff --git a/tests/qemu-iotests/151 b/tests/qemu-iotests/151
index f2ff9c5dac..06ee3585db 100755
--- a/tests/qemu-iotests/151
+++ b/tests/qemu-iotests/151
@@ -263,6 +263,11 @@ class
.
Signed-off-by: Daniel P. Berrangé
---
tests/functional/qemu_test/testcase.py | 4
1 file changed, 4 insertions(+)
diff --git a/tests/functional/qemu_test/testcase.py
b/tests/functional/qemu_test/testcase.py
index 71c7160adc..2a78e735f1 100644
--- a/tests/functional/qemu_test/testcase.py
The multiprocess and virtio_gpu tests open sockets but then forget
to close them, which triggers resource leak warnings
The virtio_gpu test also fails to close a log file it opens.
Signed-off-by: Daniel P. Berrangé
---
tests/functional/test_multiprocess.py | 3 +++
tests/functional
/3.14/whatsnew/3.14.html#id7
Thanks: Miro Hrončok, Daniel P. Berrangé
Signed-off-by: Richard W.M. Jones
---
python/qemu/qmp/legacy.py | 5 -
python/qemu/qmp/qmp_tui.py | 2 +-
python/tests/protocol.py | 2 +-
3 files changed, 6 insertions(+), 3 deletions(-)
diff --git a/python/qemu/qmp
On Fri, Jul 11, 2025 at 12:00:24PM +0100, Daniel P. Berrangé wrote:
> On Fri, Jul 11, 2025 at 11:45:08AM +0100, Peter Maydell wrote:
> > On Tue, 17 Jun 2025 at 21:35, Bernhard Beschow wrote:
> > >
> > > When compiling QEMU against fuse3-3.17.1 with --enable-we
illa.redhat.com/show_bug.cgi?id=2375004#c4
>
> See-also: https://docs.python.org/3.14/whatsnew/3.14.html#id7
> Thanks: Miro Hrončok, Daniel P. Berrangé
> Signed-off-by: Richard W.M. Jones
> ---
> python/qemu/qmp/legacy.py | 5 -
> python/qemu/qmp/qmp_tui.py | 2 +-
> pytho
On Tue, Jul 15, 2025 at 11:51:10AM +0100, Richard W.M. Jones wrote:
> In Python 3.14, no asyncio event loop gets generated automatically.
> Instead create one when we need it. This should work with Python 3.13
> as well. This is a mechanical change as suggested here:
>
> https://bugzilla.redhat.
1 - 100 of 2618 matches
Mail list logo
