[Qemu-devel] [Bug 1823458] Update Released

2019-05-13 Thread Corey Bryant
The verification of the Stable Release Update for qemu has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we c

[Qemu-devel] [Bug 1823458] Re: race condition between vhost_net_stop and CHR_EVENT_CLOSED on shutdown crashes qemu

2019-05-13 Thread Corey Bryant
This bug was fixed in the package qemu - 1:2.8+dfsg-3ubuntu2.9~cloud5.1 --- qemu (1:2.8+dfsg-3ubuntu2.9~cloud5.1) xenial-ocata; urgency=medium . * d/p/lp1823458/add-VirtIONet-vhost_stopped-flag-to-prevent-multiple.patch, d/p/lp1823458/do-not-call-vhost_net_cleanup-on-running-

[Qemu-devel] [Bug 1823458] Re: race condition between vhost_net_stop and CHR_EVENT_CLOSED on shutdown crashes qemu

2019-05-13 Thread Corey Bryant
This bug was fixed in the package qemu - 1:2.5+dfsg-5ubuntu10.37~cloud0 --- qemu (1:2.5+dfsg-5ubuntu10.37~cloud0) trusty-mitaka; urgency=medium . * New update for the Ubuntu Cloud Archive. . qemu (1:2.5+dfsg-5ubuntu10.37) xenial; urgency=medium . * d/p/lp1823458/add-VirtIONe

[Qemu-devel] [Bug 1823458] Update Released

2019-05-13 Thread Corey Bryant
The verification of the Stable Release Update for qemu has completed successfully and the package has now been released to -updates. In the event that you encounter a regression using the package from -updates please report a new bug using ubuntu-bug and tag the bug report regression-update so we c

[Qemu-devel] [Bug 1823458] Please test proposed package

2019-04-24 Thread Corey Bryant
Hello Dan, or anyone else affected, Accepted qemu into ocata-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository. Please help us by testing this new package. To enable the -proposed repository: sudo add-apt-repo

[Qemu-devel] [Bug 1823458] Please test proposed package

2019-04-24 Thread Corey Bryant
Hello Dan, or anyone else affected, Accepted qemu into mitaka-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository. Please help us by testing this new package. To enable the -proposed repository: sudo add-apt-rep

[Qemu-devel] [Bug 1823458] Re: race condition between vhost_net_stop and CHR_EVENT_CLOSED on shutdown crashes qemu

2019-04-24 Thread Corey Bryant
** Also affects: cloud-archive/ocata Importance: Undecided Status: New ** Changed in: cloud-archive/ocata Importance: Undecided => Medium ** Changed in: cloud-archive/ocata Status: New => Triaged ** Changed in: cloud-archive Status: New => Fix Released -- You receive

[Qemu-devel] [Bug 1823458] Re: race condition between vhost_net_stop and CHR_EVENT_CLOSED on shutdown crashes qemu

2019-04-24 Thread Corey Bryant
** Also affects: cloud-archive Importance: Undecided Status: New ** Also affects: cloud-archive/mitaka Importance: Undecided Status: New ** Changed in: cloud-archive/mitaka Importance: Undecided => Medium ** Changed in: cloud-archive/mitaka Status: New => Triaged -

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-12-11 Thread Corey Bryant
Regression testing has passed successfully. zesty-ocata-proposed with stable charms: == Totals == Ran: 102 tests in 1897.0150 sec. - Passed: 93 - Skipped: 9 - Expected Fail: 0 - Unexpected Success: 0 - Failed: 0 Sum of execute time for each test: 1011.5607 sec. zesty-ocata-proposed

[Qemu-devel] [Bug 1719196] Please test proposed package

2017-10-31 Thread Corey Bryant
Hello Sean, or anyone else affected, Accepted qemu into ocata-proposed. The package will build now and be available in the Ubuntu Cloud Archive in a few hours, and then in the -proposed repository. Please help us by testing this new package. To enable the -proposed repository: sudo add-apt-rep

[Qemu-devel] [Bug 1719196] Re: [arm64 ocata] newly created instances are unable to raise network interfaces

2017-10-18 Thread Corey Bryant
** Also affects: cloud-archive Importance: Undecided Status: New ** Also affects: cloud-archive/pike Importance: Undecided Status: New ** Also affects: cloud-archive/ocata Importance: Undecided Status: New ** No longer affects: cloud-archive/pike ** Changed in: clo

[Qemu-devel] [Bug 1546445] Re: support vhost user without specifying vhostforce

2016-03-19 Thread Corey Bryant
** Changed in: qemu (Ubuntu Vivid) Status: Won't Fix => In Progress ** Changed in: qemu (Ubuntu Vivid) Assignee: (unassigned) => Liang Chen (cbjchen) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.

[Qemu-devel] [Bug 1546445] Re: support vhost user without specifying vhostforce

2016-03-19 Thread Corey Bryant
** Changed in: cloud-archive/kilo Status: New => In Progress ** Changed in: cloud-archive/kilo Assignee: (unassigned) => Liang Chen (cbjchen) -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs

[Qemu-devel] [Bug 1546445] Re: support vhost user without specifying vhostforce

2016-03-18 Thread Corey Bryant
** No longer affects: cloud-archive ** Also affects: cloud-archive Importance: Undecided Status: New ** Also affects: cloud-archive/kilo Importance: Undecided Status: New -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to

[Qemu-devel] [Bug 1546445] Re: support vhost user without specifying vhostforce

2016-03-18 Thread Corey Bryant
** Changed in: qemu (Ubuntu Vivid) Status: In Progress => Invalid ** Changed in: qemu (Ubuntu Vivid) Assignee: Liang Chen (cbjchen) => (unassigned) ** No longer affects: qemu (Ubuntu Vivid) -- You received this bug notification because you are a member of qemu- devel-ml, which is su

Re: [Qemu-devel] Missing vhost=on support on -netdev bridge.

2014-01-09 Thread Corey Bryant
this: -net tap,helper="/usr/local/libexec/qemu-bridge-helper --br=br0" -- Regards, Corey Bryant

[Qemu-devel] [PATCH] seccomp: exit if seccomp_init() fails

2013-12-18 Thread Corey Bryant
This fixes a bug where we weren't exiting if seccomp_init() failed. Signed-off-by: Corey Bryant --- qemu-seccomp.c | 1 + 1 file changed, 1 insertion(+) diff --git a/qemu-seccomp.c b/qemu-seccomp.c index cf07869..b7c1253 100644 --- a/qemu-seccomp.c +++ b/qemu-seccomp.c @@ -231,6 +231,7 @

Re: [Qemu-devel] [PATCH] seccomp: "-sandbox on" won't kill Qemu when option not built in

2013-12-09 Thread Corey Bryant
dbox on" arg if the host doesn't support it. But I think this could be done on virt-test as well :) This would make sense. Although it sounds like Lucas was looking for an error message when seccomp kills qemu. Maybe virt-test could grep the audit log for the existence of a "type=SECCOMP" record within the test's time of execution, and issue a message based on that. -- Regards, Corey Bryant

Re: [Qemu-devel] [PATCH for-1.7] seccomp: setting "-sandbox on" by default

2013-12-04 Thread Corey Bryant
e is being executed sort of defeats the purpose. -- Regards, Corey Bryant The optimal goal here is to use virt-test and audit log to eliminate these sorts of things.

Re: [Qemu-devel] [PATCH 4/4] tpm: Provide libtpms software TPM backend

2013-11-26 Thread Corey Bryant
g QEMU against libtpms doesn't look like it's going to make it upstream. So it looks like we need to take a different approach. Btw, I thought Xen already had TPM support. Is that not supported in stubdom's? -- Regards, Corey Bryant I'd be really pleased if you can he

Re: [Qemu-devel] [PATCH 4/4] tpm: Provide libtpms software TPM backend

2013-11-25 Thread Corey Bryant
Intel Thanks Quan. I believe I built these on top of commit c2d30667760e3d7b81290d801e567d4f758825ca. I don't think this series is going to make it upstream though so I likely won't be submitting a v2. -- Regards, Corey Bryant

Re: [Qemu-devel] [PATCH 0/4] tpm: Provide a software vTPM

2013-11-19 Thread Corey Bryant
On 11/19/2013 02:50 PM, Anthony Liguori wrote: On Wed, Nov 6, 2013 at 6:38 AM, Corey Bryant wrote: This patch series provides support for a software Trusted Platform Module (otherwise known as a vTPM). This support is provided via a new backend that works with the existing QEMU tpm-tis front

Re: [Qemu-devel] [PATCH 3/4] tpm: QMP/HMP support for libtpms TPM backend

2013-11-06 Thread Corey Bryant
On 11/06/2013 11:13 AM, Eric Blake wrote: On 11/06/2013 07:39 AM, Corey Bryant wrote: [your git settings are odd; your messages came across as individual threads rather than in-reply to the cover letter] I wonder if that's because I sent each patch separately with git send-

[Qemu-devel] [PATCH 3/4] tpm: QMP/HMP support for libtpms TPM backend

2013-11-06 Thread Corey Bryant
This patch provides HMP 'info tpm', QMP 'query-tpm' and QMP 'query-tpm-types' support for the libtpms TPM backend. Signed-off-by: Corey Bryant --- hmp.c|5 + include/sysemu/tpm_backend.h |1 + qapi-schema.json |

[Qemu-devel] [PATCH 4/4] tpm: Provide libtpms software TPM backend

2013-11-06 Thread Corey Bryant
: Corey Bryant --- configure| 24 ++ hw/tpm/Makefile.objs |2 + hw/tpm/tpm_libtpms.c | 885 ++ qemu-options.hx | 31 ++- tpm.c|2 +- 5 files changed, 941 insertions(+), 3 deletions(-) create mode 100644 hw

[Qemu-devel] [PATCH 2/4] tpm: Share tpm_write_fatal_error_response

2013-11-06 Thread Corey Bryant
Move tpm_write_fatal_error_response to tpm.c where it can be shared by multiple backends, and change the return code from void to the size of the message. Signed-off-by: Corey Bryant --- hw/tpm/tpm_passthrough.c | 14 -- hw/tpm/tpm_tis.h |1 + include/sysemu

[Qemu-devel] [PATCH 1/4] tpm: Add TPM NVRAM implementation

2013-11-06 Thread Corey Bryant
can use to read and write data. Signed-off-by: Corey Bryant Reviewed-by: Stefan Hajnoczi --- v1 -This patch was formerly known as: "[PATCH v3 1/3] nvram: Add TPM NVRAM implementation" -Updated g_malloc to TPM_Malloc in tpm_nvram_co_read -Added tpm_nvram_bh NULL check to tpm_nvram_

[Qemu-devel] [PATCH 0/4] tpm: Provide a software vTPM

2013-11-06 Thread Corey Bryant
libtpms,id=tpm-tpm0,nvram=nvram0-0-0 Corey Bryant (4): tpm: Add TPM NVRAM implementation tpm: Share tpm_write_fatal_error_response tpm: QMP/HMP support for libtpms TPM backend tpm: Provide libtpms software TPM backend configure| 24 ++ hmp.c

Re: [Qemu-devel] [PATCHv3 1/3] seccomp: adding blacklist support

2013-10-10 Thread Corey Bryant
re enabled. -- Regards, Corey Bryant One more comment below. Adding a system call blacklist right before the vcpus starts. This filter is composed by the system calls that can't be executed after the guests are up. This list should be refined as whitelist is, with as much testing as we can do

Re: [Qemu-devel] [PATCHv3 1/3] seccomp: adding blacklist support

2013-10-09 Thread Corey Bryant
effect, and you'll need to fail nicely if they're attempted. + break; case QEMU_OPTION_net: if (net_client_parse(qemu_find_opts("net"), optarg) == -1) { -- Regards, Corey Bryant

Re: [Qemu-devel] [PATCHv2 2/3] seccomp: adding command line support for blacklist

2013-09-18 Thread Corey Bryant
vulnerability before an actual fix is available, by blacklisting a syscall or a syscall argument. -- Regards, Corey Bryant

Re: [Qemu-devel] [PATCHv2 2/3] seccomp: adding command line support for blacklist

2013-09-17 Thread Corey Bryant
escribes. The QEMU process that is exec'd by libvirt would be constrained by the filter that libvirt installed. -- Regards, Corey Bryant There are no command line arguments passed to QEMU. This work can co-exist with the QEMU seccomp filters without problem. The original goal of t

Re: [Qemu-devel] [PATCHv2 2/3] seccomp: adding command line support for blacklist

2013-09-11 Thread Corey Bryant
emu_opt_get(opts, "strict"); +if (strict_value) { +if (!strcmp(strict_value, "on")) { + enable_blacklist = true; +} +} #else qerror_report(ERROR_CLASS_GENERIC_ERROR, "sandboxing request but seccomp is not compiled into this build"); -- Regards, Corey Bryant

Re: [Qemu-devel] [PATCHv3 3/3] seccomp: general fixes

2013-09-11 Thread Corey Bryant
"enable", false)) { +if (qemu_opt_get_bool(opts, "sandbox", false)) { #ifdef CONFIG_SECCOMP if (seccomp_start(WHITELIST) < 0) { qerror_report(ERROR_CLASS_GENERIC_ERROR, -- 1.8.3.1 -- Regards, Corey Bryant

Re: [Qemu-devel] [PATCHv2 1/3] seccomp: adding blacklist support

2013-09-11 Thread Corey Bryant
s, should install_seccomp_blacklist() be called before the "if (incoming)" check in main()? resume_all_vcpus(); monitor_protocol_event(QEVENT_RESUME, NULL); } -- Regards, Corey Bryant

Re: [Qemu-devel] [PATCH] seccomp: adding times() to the whitelist

2013-09-04 Thread Corey Bryant
}, +{ SCMP_SYS(times), 245 }, { SCMP_SYS(exit), 245 }, { SCMP_SYS(clock_gettime), 245 }, { SCMP_SYS(time), 245 }, Reviewed-by: Corey Bryant -- Regards, Corey Bryant

Re: [Qemu-devel] [PATCH] seccomp: adding a second whitelist

2013-09-03 Thread Corey Bryant
On 09/03/2013 04:05 PM, Eduardo Otubo wrote: On 09/03/2013 03:02 PM, Corey Bryant wrote: On 08/30/2013 10:21 AM, Eduardo Otubo wrote: On 08/29/2013 05:34 AM, Stefan Hajnoczi wrote: On Wed, Aug 28, 2013 at 10:04:32PM -0300, Eduardo Otubo wrote: Now there's a second whitelist,

Re: [Qemu-devel] [PATCH] seccomp: adding a second whitelist

2013-09-03 Thread Corey Bryant
On 09/03/2013 02:21 PM, Paul Moore wrote: On Tuesday, September 03, 2013 02:08:28 PM Corey Bryant wrote: On 09/03/2013 02:02 PM, Corey Bryant wrote: On 08/30/2013 10:21 AM, Eduardo Otubo wrote: On 08/29/2013 05:34 AM, Stefan Hajnoczi wrote: On Wed, Aug 28, 2013 at 10:04:32PM -0300, Eduardo

Re: [Qemu-devel] [PATCH] seccomp: adding a second whitelist

2013-09-03 Thread Corey Bryant
On 09/03/2013 02:02 PM, Corey Bryant wrote: On 08/30/2013 10:21 AM, Eduardo Otubo wrote: On 08/29/2013 05:34 AM, Stefan Hajnoczi wrote: On Wed, Aug 28, 2013 at 10:04:32PM -0300, Eduardo Otubo wrote: Now there's a second whitelist, right before the vcpu starts. The second whiteli

Re: [Qemu-devel] [PATCH] seccomp: adding a second whitelist

2013-09-03 Thread Corey Bryant
e QEMU releases without regressing "-sandbox on,strict=on". By the way, are any test buckets running regularly with -sandbox on? -- Regards, Corey Bryant Stefan

Re: [Qemu-devel] [PATCH v3 0/3] TPM NVRAM persistent storage

2013-06-14 Thread Corey Bryant
On 06/14/2013 11:56 AM, Anthony Liguori wrote: Corey Bryant writes: On 06/14/2013 11:38 AM, Anthony Liguori wrote: Corey Bryant writes: On 06/14/2013 10:01 AM, Anthony Liguori wrote: Corey Bryant writes: This patch series provides persistent storage support that a TPM can use to

Re: [Qemu-devel] [PATCH v3 0/3] TPM NVRAM persistent storage

2013-06-14 Thread Corey Bryant
On 06/14/2013 11:38 AM, Anthony Liguori wrote: Corey Bryant writes: On 06/14/2013 10:01 AM, Anthony Liguori wrote: Corey Bryant writes: This patch series provides persistent storage support that a TPM can use to store NVRAM data. It uses QEMU's block driver to store data on a

Re: [Qemu-devel] [PATCH v3 0/3] TPM NVRAM persistent storage

2013-06-14 Thread Corey Bryant
On 06/14/2013 10:01 AM, Anthony Liguori wrote: Corey Bryant writes: This patch series provides persistent storage support that a TPM can use to store NVRAM data. It uses QEMU's block driver to store data on a drive image. The libtpms TPM 1.2 backend will be the initial user of

Re: [Qemu-devel] [PATCH v3 0/3] TPM NVRAM persistent storage

2013-06-07 Thread Corey Bryant
On 06/07/2013 03:41 AM, Stefan Hajnoczi wrote: On Thu, Jun 06, 2013 at 09:32:42AM -0400, Corey Bryant wrote: This patch series provides persistent storage support that a TPM can use to store NVRAM data. It uses QEMU's block driver to store data on a drive image. The libtpms TPM 1.2 ba

[Qemu-devel] [PATCH v3 0/3] TPM NVRAM persistent storage

2013-06-06 Thread Corey Bryant
n. A sample command line may look like this: qemu-system-x86_64 ... -drive file=/path/to/nvram.qcow2,id=drive-nvram0-0-0 -tpmdev libtpms,id=tpm-tpm0 -device tpm-tis,tpmdev=tpm-tpm0,id=tpm0,drive=drive-nvram0-0-0 Thanks, Corey Corey Bryant (3): nvram: Add TPM NVRAM implementation nvram: Add tp

[Qemu-devel] [PATCH v3 1/3] nvram: Add TPM NVRAM implementation

2013-06-06 Thread Corey Bryant
can use to read and write data. Signed-off-by: Corey Bryant --- v2 -Use non bit-rotting DPRINTF (stefa...@redhat.com) -Use DIV_ROUND_UP (stefa...@redhat.com) -Use bdrv_pread/bdrv_pwrite in coroutine - causes global sector to byte I/O changes (stefa...@redhat.com, kw...@redhat.com) -Add

Re: [Qemu-devel] [PATCH v2 1/3] nvram: Add TPM NVRAM implementation

2013-06-06 Thread Corey Bryant
On 06/06/2013 05:22 AM, Stefan Hajnoczi wrote: On Wed, Jun 05, 2013 at 04:47:59PM -0400, Corey Bryant wrote: +/* + * Coroutine that reads a blob from the drive asynchronously + */ +static void coroutine_fn tpm_nvram_co_read(void *opaque) +{ +TPMNvramRWRequest *rwr = opaque; + +*rwr

[Qemu-devel] [PATCH v3 2/3] nvram: Add tpm-tis drive support

2013-06-06 Thread Corey Bryant
Add a drive property to the tpm-tis device and initialize the TPM NVRAM if a drive is specified. Signed-off-by: Corey Bryant --- v2 -No changes v3 -No changes --- hw/tpm/tpm_int.h |2 ++ hw/tpm/tpm_tis.c |8 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a

[Qemu-devel] [PATCH v2 1/3] nvram: Add TPM NVRAM implementation

2013-06-05 Thread Corey Bryant
can use to read and write data. Signed-off-by: Corey Bryant --- v2 -Use non bit-rotting DPRINTF (stefa...@redhat.com) -Use DIV_ROUND_UP (stefa...@redhat.com) -Use bdrv_pread/bdrv_pwrite in coroutine - causes global sector to byte I/O changes (stefa...@redhat.com, kw...@redhat.com) -Add

[Qemu-devel] [PATCH v2 0/3] TPM NVRAM persistent storage

2013-06-05 Thread Corey Bryant
n. A sample command line may look like this: qemu-system-x86_64 ... -drive file=/path/to/nvram.qcow2,id=drive-nvram0-0-0 -tpmdev libtpms,id=tpm-tpm0 -device tpm-tis,tpmdev=tpm-tpm0,id=tpm0,drive=drive-nvram0-0-0 Thanks, Corey Corey Bryant (3): nvram: Add TPM NVRAM implementation nvram: Add tp

[Qemu-devel] [PATCH v2 2/3] nvram: Add tpm-tis drive support

2013-06-05 Thread Corey Bryant
Add a drive property to the tpm-tis device and initialize the TPM NVRAM if a drive is specified. Signed-off-by: Corey Bryant --- v2 -No changes --- hw/tpm/tpm_int.h |2 ++ hw/tpm/tpm_tis.c |8 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/hw/tpm/tpm_int.h b

Re: [Qemu-devel] [PATCH 1/2] nvram: Add TPM NVRAM implementation

2013-06-05 Thread Corey Bryant
On 06/05/2013 09:42 AM, Kevin Wolf wrote: Am 05.06.2013 um 15:28 hat Corey Bryant geschrieben: + +if (rwr->rc == 0) { +rwr->rc = rwr->num_sectors; +*rwr->blob_r = g_malloc(rwr->size); +memcpy(*rwr->blob_r, buf, rwr->size); Use bdrv_pread()/b

Re: [Qemu-devel] [PATCH 1/2] nvram: Add TPM NVRAM implementation

2013-06-05 Thread Corey Bryant
Thanks for reviewing! On 06/05/2013 05:05 AM, Stefan Hajnoczi wrote: On Tue, Jun 04, 2013 at 02:18:40PM -0400, Corey Bryant wrote: Provides TPM NVRAM implementation that enables storing of TPM NVRAM data in a persistent image file. The block driver is used to read/write the drive image. This

Re: [Qemu-devel] [PATCH 0/2] TPM NVRAM persistent storage

2013-06-04 Thread Corey Bryant
On 06/04/2013 03:23 PM, Eric Blake wrote: On 06/04/2013 12:18 PM, Corey Bryant wrote: This patch series provides persistent storage support that a TPM can use to store NVRAM data. It uses QEMU's block driver to store data on a drive image. The libtpms TPM 1.2 backend will be the in

[Qemu-devel] [PATCH 2/2] nvram: Add tpm-tis drive support

2013-06-04 Thread Corey Bryant
Add a drive property to the tpm-tis device and initialize the TPM NVRAM if a drive is specified. Signed-off-by: Corey Bryant --- hw/tpm/tpm_int.h |2 ++ hw/tpm/tpm_tis.c |8 2 files changed, 10 insertions(+), 0 deletions(-) diff --git a/hw/tpm/tpm_int.h b/hw/tpm/tpm_int.h

[Qemu-devel] [PATCH 1/2] nvram: Add TPM NVRAM implementation

2013-06-04 Thread Corey Bryant
use to read and write data. Signed-off-by: Corey Bryant --- hw/tpm/Makefile.objs |1 + hw/tpm/tpm_nvram.c | 399 ++ hw/tpm/tpm_nvram.h | 25 +++ 3 files changed, 425 insertions(+), 0 deletions(-) create mode 100644 hw/tpm/tpm_nvram.c

[Qemu-devel] [PATCH 0/2] TPM NVRAM persistent storage

2013-06-04 Thread Corey Bryant
n. A sample command line may look like this: qemu-system-x86_64 ... -drive file=/path/to/nvram.qcow2,id=drive-nvram0-0-0 -tpmdev libtpms,id=tpm-tpm0 -device tpm-tis,tpmdev=tpm-tpm0,id=tpm0,drive=drive-nvram0-0-0 Thanks, Corey Corey Bryant (2): nvram: Add TPM NVRAM implementation nvram: Add tp

Re: [Qemu-devel] [PATCH] seccomp: add the asynchronous I/O syscalls to the whitelist

2013-05-29 Thread Corey Bryant
Bryant -- Regards, Corey Bryant

Re: [Qemu-devel] [PATCH 7/7] monitor: QMP/HMP support for retrieving VNVRAM details

2013-05-29 Thread Corey Bryant
On 05/29/2013 01:15 PM, Luiz Capitulino wrote: On Thu, 23 May 2013 13:44:47 -0400 Corey Bryant wrote: Signed-off-by: Corey Bryant Looks good to me, only one small nit below. It looks like this series is going to get dropped, but thanks for the review! -- Regards, Corey Bryant

Re: [Qemu-devel] [PATCH 1/7] vnvram: VNVRAM bdrv support

2013-05-24 Thread Corey Bryant
On 05/24/2013 11:37 AM, Kevin Wolf wrote: Am 24.05.2013 um 17:33 hat Corey Bryant geschrieben: On 05/24/2013 09:06 AM, Kevin Wolf wrote: Am 23.05.2013 um 19:44 hat Corey Bryant geschrieben: Provides low-level VNVRAM functionality that reads and writes data, such as an entry's binary

Re: [Qemu-devel] [PATCH 0/7] VNVRAM persistent storage

2013-05-24 Thread Corey Bryant
On 05/24/2013 08:36 AM, Stefan Hajnoczi wrote: On Fri, May 24, 2013 at 08:13:27AM -0400, Stefan Berger wrote: On 05/24/2013 05:59 AM, Stefan Hajnoczi wrote: On Thu, May 23, 2013 at 01:44:40PM -0400, Corey Bryant wrote: This patch series provides VNVRAM persistent storage support that QEMU

Re: [Qemu-devel] [PATCH 0/7] VNVRAM persistent storage

2013-05-24 Thread Corey Bryant
On 05/23/2013 03:15 PM, Anthony Liguori wrote: Corey Bryant writes: On 05/23/2013 02:03 PM, Anthony Liguori wrote: Corey Bryant writes: One of the difficulties in virtualizing a TPM is that it doesn't support SR-IOV. So the existing passthrough vTPM can only be used by one

Re: [Qemu-devel] [PATCH 1/7] vnvram: VNVRAM bdrv support

2013-05-24 Thread Corey Bryant
On 05/24/2013 09:06 AM, Kevin Wolf wrote: Am 23.05.2013 um 19:44 hat Corey Bryant geschrieben: Provides low-level VNVRAM functionality that reads and writes data, such as an entry's binary blob, to a drive image using the block driver. Signed-off-by: Corey Bryant +/* + * Increas

Re: [Qemu-devel] [PATCH 0/7] VNVRAM persistent storage

2013-05-23 Thread Corey Bryant
On 05/23/2013 02:03 PM, Anthony Liguori wrote: Corey Bryant writes: This patch series provides VNVRAM persistent storage support that QEMU can use internally. The initial target user will be a software vTPM 1.2 backend that needs to store keys in VNVRAM and be able to reboot/migrate and

Re: [Qemu-devel] [PATCH 7/7] monitor: QMP/HMP support for retrieving VNVRAM details

2013-05-23 Thread Corey Bryant
On 05/23/2013 01:59 PM, Eric Blake wrote: On 05/23/2013 11:44 AM, Corey Bryant wrote: Signed-off-by: Corey Bryant --- Might help to list a sample HMP or QMP usage in the commit message. +++ b/qapi-schema.json @@ -3619,3 +3619,50 @@ '*cpuid-input-ecx&#

[Qemu-devel] [PATCH 1/7] vnvram: VNVRAM bdrv support

2013-05-23 Thread Corey Bryant
Provides low-level VNVRAM functionality that reads and writes data, such as an entry's binary blob, to a drive image using the block driver. Signed-off-by: Corey Bryant --- Makefile.objs |2 + vnvram.c | 487 + vnv

[Qemu-devel] [PATCH 7/7] monitor: QMP/HMP support for retrieving VNVRAM details

2013-05-23 Thread Corey Bryant
Signed-off-by: Corey Bryant --- hmp.c| 32 hmp.h|1 + monitor.c|7 + qapi-schema.json | 47 +++ qmp-commands.hx | 41 +++ vnvram.c | 71

[Qemu-devel] [PATCH 6/7] main: Initialize VNVRAM

2013-05-23 Thread Corey Bryant
Signed-off-by: Corey Bryant --- vl.c |6 ++ 1 files changed, 6 insertions(+), 0 deletions(-) diff --git a/vl.c b/vl.c index 59dc0b4..5da88e6 100644 --- a/vl.c +++ b/vl.c @@ -171,6 +171,8 @@ int main(int argc, char **argv) #include "ui/qemu-spice.h" #include "qa

[Qemu-devel] [PATCH 5/7] vnvram: VNVRAM additional debug support

2013-05-23 Thread Corey Bryant
Provides debug support that dumps the disk and in-memory VNVRAM contents to stderr. Signed-off-by: Corey Bryant --- vnvram.c | 94 ++ 1 files changed, 94 insertions(+), 0 deletions(-) diff --git a/vnvram.c b/vnvram.c index 357923d

[Qemu-devel] [PATCH 3/7] vnvram: VNVRAM bottom-half r/w scheduling support

2013-05-23 Thread Corey Bryant
Provides support that schedules and executes VNVRAM read/write requests. A bottom-half is used to perform reads/writes from the QEMU main thread. Signed-off-by: Corey Bryant --- vnvram.c | 142 ++ 1 files changed, 142 insertions

[Qemu-devel] [PATCH 0/7] VNVRAM persistent storage

2013-05-23 Thread Corey Bryant
de0-0-0", false, &errcode); strcpy((char *)entry_name, "first-entry"); vnvram_register_entry(vnvram, &entry_name, 1024); vnvram_write_entry(vnvram, &entry_name, (char *)blob_w, strlen(blob_w)+1); vnvram_read_entry(vnvram, &entry_name, &blob_r, &blob_r_size); v

[Qemu-devel] [PATCH 4/7] vnvram: VNVRAM internal APIs

2013-05-23 Thread Corey Bryant
Provides VNVRAM APIs that can be used by other areas of QEMU to provide persistent storage. Signed-off-by: Corey Bryant --- vnvram.c | 266 ++ vnvram.h | 14 +++ 2 files changed, 280 insertions(+), 0 deletions(-) diff --git a

[Qemu-devel] [PATCH 2/7] vnvram: VNVRAM in-memory support

2013-05-23 Thread Corey Bryant
Provides support for in-memory VNVRAM entries. The in-memory entries are used for fast access to entry data such as the current or max size of an entry and the disk offset where an entry's binary blob data is stored. Signed-off-by: Corey Bryant --- vnvram.c |

Re: [Qemu-devel] [RFC] Continuous work on sandboxing

2013-05-01 Thread Corey Bryant
On 05/01/2013 01:25 PM, Eduardo Otubo wrote: On 04/30/2013 12:24 PM, Paul Moore wrote: On Monday, April 29, 2013 05:52:10 PM Corey Bryant wrote: On 04/26/2013 05:07 PM, Paul Moore wrote: [snip] 3. Debugging and/or learning mode - third party libraries still have the problem of

Re: [Qemu-devel] [RFC] Continuous work on sandboxing

2013-05-01 Thread Corey Bryant
On 05/01/2013 10:13 AM, Paul Moore wrote: On Tuesday, April 30, 2013 04:28:54 PM Corey Bryant wrote: Just to be clear, I'm thinking you could launch guests in one of two different seccomp sandboxed environments: 1) Using the existing and more permissive whitelist where every QEMU fe

Re: [Qemu-devel] [RFC] Continuous work on sandboxing

2013-04-30 Thread Corey Bryant
On 04/30/2013 02:47 PM, Eduardo Otubo wrote: On 04/29/2013 07:02 PM, Corey Bryant wrote: On 04/29/2013 02:39 PM, Eduardo Otubo wrote: On 04/26/2013 06:07 PM, Paul Moore wrote: On Friday, April 26, 2013 03:39:33 PM Eduardo Otubo wrote: Hello folks, Resuming the sandboxing work, I&#

Re: [Qemu-devel] [RFC] Continuous work on sandboxing

2013-04-29 Thread Corey Bryant
e() is denied, open() is denied (once the pre-req's are in place for fd passing), and potentially other "dangerous" syscalls are denied. If the whitelist for #2 was passed from libvirt to qemu then libvirt could define the syscalls and syscall parameters that are denied. -- Regards, Corey Bryant

Re: [Qemu-devel] [RFC] Continuous work on sandboxing

2013-04-29 Thread Corey Bryant
ingle denied syscall at a time today via the audit log that the kernel issues. Eduardo, you may want to see if there's a good place to document that for QEMU so that people know where to look. -- Regards, Corey Bryant

Re: [Qemu-devel] [PATCH v2] tpm: Move TPM passthrough specific command line options to backend structure

2013-04-16 Thread Corey Bryant
ne TPM_STANDARD_CMDLINE_OPTS \ +{ \ +.name = "type", \ +.type = QEMU_OPT_STRING, \ +.help = "Type of TPM backend", \ +} + struct tpm_req_hdr { uint16_t tag; uint32_t len; Reviewed-by: Corey Bryant -- Regards, Corey Bryant

Re: [Qemu-devel] [PATCH] Move TPM passthrough specific command line options to backend structure

2013-04-10 Thread Corey Bryant
.name = "type", \ +.type = QEMU_OPT_STRING, \ +.help = "Type of TPM backend", \ +} + struct tpm_req_hdr { uint16_t tag; uint32_t len; -- Regards, Corey Bryant

Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device

2013-04-03 Thread Corey Bryant
On 04/03/2013 06:23 AM, Michael S. Tsirkin wrote: On Wed, Apr 03, 2013 at 11:54:57AM +0200, Laszlo Ersek wrote: On 04/02/13 16:34, Corey Bryant wrote: On 04/01/2013 08:11 PM, Kevin O'Connor wrote: On Mon, Apr 01, 2013 at 03:05:55PM -0400, Corey Bryant wrote: On 03/28/2013 05:03 AM,

Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device

2013-04-02 Thread Corey Bryant
On 04/01/2013 08:11 PM, Kevin O'Connor wrote: On Mon, Apr 01, 2013 at 03:05:55PM -0400, Corey Bryant wrote: On 03/28/2013 05:03 AM, Paolo Bonzini wrote: There is work on moving ACPI tables to QEMU. Please work with the other developers (Kevin of course, and Michael and Laszlo who I

Re: [Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device

2013-04-01 Thread Corey Bryant
On 03/28/2013 05:03 AM, Paolo Bonzini wrote: Il 26/03/2013 15:14, Corey Bryant ha scritto: This patch provides ACPI support for the TPM device. It probes for the TPM device and only if a TPM device is found then the TPM's SSDT and TCPA table are created. This patch also connects them t

Re: [Qemu-devel] vNVRAM / blobstore design

2013-03-27 Thread Corey Bryant
On 03/27/2013 11:17 AM, Corey Bryant wrote: On 03/25/2013 06:20 PM, Stefan Berger wrote: On 03/25/2013 06:05 PM, Anthony Liguori wrote: Stefan Berger writes: [argh, just posted this to qemu-trivial -- it's not trivial] Hello! I am posting this message to revive the pre

Re: [Qemu-devel] vNVRAM / blobstore design

2013-03-27 Thread Corey Bryant
laces within NVRAM. And the data could have various sizes. For an example of total NVRAM size, Infineon's TPM has 16K of NVRAM. -- Regards, Corey Bryant In case of TPM 1.2 there are 3 blobs that can be written at different times for different reasons. Examples: As with a real-world TPM

[Qemu-devel] [PATCH 0/2] Add TPM driver and ACPI support to SeaBIOS

2013-03-26 Thread Corey Bryant
passthrough vTPM is available in QEMU. In particular, these patches add: - a TPM driver for QEMU's TPM TIS emulation - ACPI support for the TPM device (SSDT table) - ACPI support for measurement logging (TCPA table) Corey Bryant (2): Add an implementation of a TPM TIS driver Provide ACPI SSDT

[Qemu-devel] [PATCH 1/2] Add an implementation of a TPM TIS driver

2013-03-26 Thread Corey Bryant
irtio interface for the TPM with a corresponding driver here. Signed-off-by: Stefan Berger Signed-off-by: Corey Bryant --- Version history from prior patch submission: v7: - moving declaration of tpm_drivers[] into tpm_drivers.h v6: - reworked timeouts; not hardcoded anymore v5: - introduc

[Qemu-devel] [PATCH 2/2] Provide ACPI SSDT table for TPM device

2013-03-26 Thread Corey Bryant
be found here: http://www.trustedcomputinggroup.org/resources/server_work_group_acpi_general_specification_version_10 The compiled SSDT description is also part of this patch. Signed-off-by: Stefan Berger Signed-off-by: Corey Bryant --- Version history from prior patch submission: v6:

Re: [Qemu-devel] [PATCH] qemu-bridge-helper: force usage of a very high MAC address for the bridge

2013-03-25 Thread Corey Bryant
ifindex = if_nametoindex(iface); Reviewed-by: Corey Bryant -- Regards, Corey Bryant

Re: [Qemu-devel] [PATCH] qemu-bridge-helper: force usage of a very high MAC address for the bridge

2013-03-25 Thread Corey Bryant
On 03/22/2013 06:09 PM, Paolo Bonzini wrote: Il 22/03/2013 22:37, Corey Bryant ha scritto: Is it desirable to change a mac address under the covers? This is the TAP mac address. It is unrelated to the guest's MAC address. It is a random link-local address, all this patch does is ma

Re: [Qemu-devel] [PATCH] qemu-bridge-helper: force usage of a very high MAC address for the bridge

2013-03-22 Thread Corey Bryant
net tap,helper="/usr/local/libexec/qemu-bridge-helper --br=br0" Perhaps adding a --macaddr option is a better approach? -- Regards, Corey Bryant

Re: [Qemu-devel] [PATCH] QMP: TPM QMP and man page documentation updates

2013-03-20 Thread Corey Bryant
I just resubmitted this patch as part of another series, so please ignore this one. -- Regards, Corey Bryant On 03/15/2013 01:17 PM, Corey Bryant wrote: Signed-off-by: Corey Bryant --- qemu-options.hx | 3 ++- qmp-commands.hx | 59

[Qemu-devel] [PATCH 1/2] QMP: Remove duplicate TPM type from query-tpm

2013-03-20 Thread Corey Bryant
Signed-off-by: Corey Bryant --- hmp.c|8 qapi-schema.json | 12 tpm/tpm.c|9 - 3 files changed, 12 insertions(+), 17 deletions(-) diff --git a/hmp.c b/hmp.c index b0a861c..d319897 100644 --- a/hmp.c +++ b/hmp.c @@ -631,11 +631,11

[Qemu-devel] [PATCH 2/2] QMP: TPM QMP and man page documentation updates

2013-03-20 Thread Corey Bryant
Signed-off-by: Corey Bryant --- qemu-options.hx |3 +- qmp-commands.hx | 58 +++ 2 files changed, 60 insertions(+), 1 deletions(-) diff --git a/qemu-options.hx b/qemu-options.hx index 06dd565..b4e3a2d 100644 --- a/qemu-options.hx +++ b

Re: [Qemu-devel] [PATCH 04/35] tpm: reorganize headers and split hardware part

2013-03-20 Thread Corey Bryant
de = cpu_to_be32(TPM_FAIL); +} +} I don't think moving this from tpm.c to tpm_backend.c helps anything. Maybe just renaming some of the files mentioned above might make the front-end vs back-end vs general code more intuitive. -- Regards, Corey Bryant diff --git a/tpm/tpm_int.h b/hw/

Re: [Qemu-devel] [PATCH] QMP: TPM QMP and man page documentation updates

2013-03-20 Thread Corey Bryant
On 03/20/2013 08:32 AM, Markus Armbruster wrote: Corey Bryant writes: On 03/19/2013 03:26 AM, Markus Armbruster wrote: [Note cc: Anthony for QAPI schema expertise] Stefan Berger writes: On 03/18/2013 12:16 PM, Markus Armbruster wrote: Corey Bryant writes: Signed-off-by: Corey

Re: [Qemu-devel] [PATCH] QMP: TPM QMP and man page documentation updates

2013-03-19 Thread Corey Bryant
On 03/19/2013 03:26 AM, Markus Armbruster wrote: [Note cc: Anthony for QAPI schema expertise] Stefan Berger writes: On 03/18/2013 12:16 PM, Markus Armbruster wrote: Corey Bryant writes: Signed-off-by: Corey Bryant --- qemu-options.hx | 3 ++- qmp-commands.hx | 59

Re: [Qemu-devel] [PATCH] QMP: TPM QMP and man page documentation updates

2013-03-18 Thread Corey Bryant
On 03/18/2013 01:46 PM, Stefan Berger wrote: On 03/18/2013 12:16 PM, Markus Armbruster wrote: Corey Bryant writes: Signed-off-by: Corey Bryant --- qemu-options.hx | 3 ++- qmp-commands.hx | 59 + 2 files changed, 61 insertions

[Qemu-devel] [PATCH] QMP: TPM QMP and man page documentation updates

2013-03-15 Thread Corey Bryant
Signed-off-by: Corey Bryant --- qemu-options.hx | 3 ++- qmp-commands.hx | 59 + 2 files changed, 61 insertions(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index 30fb85d..3b3cd0f 100644 --- a/qemu-options.hx +++ b

Re: [Qemu-devel] [PATCH V27 1/7] Support for TPM command line options

2013-03-15 Thread Corey Bryant
he following: (qemu) info tpm TPM devices: tpm0: model=tpm-tis \ tpm0: type=passthrough,path=/dev/tpm0,cancel-path=/sys/devices/pnp0/00:09/cancel Signed-off-by: Stefan Berger Reviewed-by: Corey Bryant --- Makefile.objs | 1 + hmp-commands.hx | 2 + hmp.c | 44 +++

  1   2   3   4   5   6   >