On 8/30/21 9:18 AM, Philippe Mathieu-Daudé wrote:
>>
>> +AMD Secure Encrypted Virtualization (SEV)
>> +R: Connor Kuehl
>
> Is this patch still valid?
Thank you for championing it, but due to recent changes, no, it is
no longer valid.
Thank you,
Connor
On Fri Jul 30, 2021 at 1:02 PM CDT, Dov Murik wrote:
>
>
> > Awesome! Unfortunately, it's looking like we'll have to wait[1] for QEMU to
> > thaw before this series goes in.
> >
>
> Thanks for explaining this. Do I need to do anything after 6.1 is
> released? Ping? Rebase and re-send?
Rebase and
On Thu Jul 29, 2021 at 2:31 PM CDT, Dov Murik wrote:
> The OVMF companion series has been reviewed by the new OVMF maintainer
> and merged to edk2 master branch as of edk2 commit 514b3aa08ece [1].
>
> [1] https://github.com/tianocore/edk2/commit/514b3aa08ece
Awesome! Unfortunately, it's looking li
On 7/7/21 7:54 PM, isaku.yamah...@gmail.com wrote:
From: Xiaoyao Li
Reuse -cpu,tsc-frequency= to get user wanted tsc frequency and pass it
to KVM_TDX_INIT_VM.
Besides, sanity check the tsc frequency to be in the legal range and
legal granularity (required by SEAM module).
Signed-off-by: Xiaoy
ood place in the series to update the comment
preceding the sev_kvm_init call since TDX is now here and otherwise
the comment seems untimely.
Reviewed-by: Connor Kuehl
On 7/7/21 7:54 PM, isaku.yamah...@gmail.com wrote:
From: Xiaoyao Li
Introduce a machine property, kvm-type, to allow the user to create a
Trusted Domain eXtensions (TDX) VM, a.k.a. a Trusted Domain (TD), e.g.:
# $QEMU \
-machine ...,kvm-type=tdx \
...
Only two types are supp
t TSC. Actually do_kvm_synchronize_tsc() hits assert due to
failure to write to guest tsc.
qemu/target/i386/kvm.c:235: kvm_get_tsc: Assertion `ret == 1' failed.
Signed-off-by: Isaku Yamahata
Reviewed-by: Connor Kuehl
On 7/7/21 7:55 PM, isaku.yamah...@gmail.com wrote:
From: Isaku Yamahata
Signed-off-by: Isaku Yamahata
---
include/sysemu/tdx.h | 1 +
target/i386/kvm/kvm.c | 5 +
2 files changed, 6 insertions(+)
diff --git a/include/sysemu/tdx.h b/include/sysemu/tdx.h
index 70eb01348f..f3eced10f9 10
On 7/7/21 7:55 PM, isaku.yamah...@gmail.com wrote:
From: Isaku Yamahata
In TDX CPU state is also protected, thus vcpu state can't be reset by VMM.
It assumes -action reboot=shutdown instead of silently ignoring vcpu reset.
TDX module spec version 344425-002US doesn't support vcpu reset by VMM.
On 7/7/21 7:54 PM, isaku.yamah...@gmail.com wrote:
From: Isaku Yamahata
Introduce a new notifier, machine_init_done_late, that is notified after
machine_init_done. This will be used by TDX to generate the HOB for its
virtual firmware, which needs to be done after all guest memory has been
adde
: Connor Kuehl
> 0);
kvm_eventfds_allowed =
(kvm_check_extension(s, KVM_CAP_IOEVENTFD) > 0);
Reviewed-by: Connor Kuehl
On 7/21/21 11:50 AM, John Snow wrote:
This does about the bare minimum, converting section headers to ReST
ones and adding an indent for code blocks.
Signed-off-by: John Snow
---
Looks like ReST! The generated document also looks good to me.
Reviewed-by: Connor Kuehl
On 7/9/21 3:55 PM, Brijesh Singh wrote:
> The KVM_SEV_SNP_LAUNCH_UPDATE command is used for encrypting the bios
> image used for booting the SEV-SNP guest.
>
> Signed-off-by: Brijesh Singh
> ---
> target/i386/sev.c| 33 -
> target/i386/trace-events | 1 +
On 7/8/21 10:03 AM, Philippe Mathieu-Daudé wrote:
> On 7/8/21 6:41 PM, Connor Kuehl wrote:
>> Hi Paolo,
>>
>> Please consider this series[1] for inclusion into your next pull request.
>>
>> Just a note that this series has a companion series that is
Hi Paolo,
Please consider this series[1] for inclusion into your next pull request.
Just a note that this series has a companion series that is getting
upstreamed into OVMF[2]
[1] Patchwork link, if convenient:
https://patchwork.kernel.org/project/qemu-devel/cover/20210624102040.2015280-1-dovmu
> - --enable-libpmem) libpmem=disabled
> + --enable-libpmem) libpmem="enabled"
> ;;
> - --disable-libpmem) libpmem=enabled
> + --disable-libpmem) libpmem="disabled"
> ;;
> --enable-xkbcommon) xkbcommon="enabled"
> ;;
> --
> 2.27.0
Good catch.
Reviewed-by: Connor Kuehl
or
Tested-by: Connor Kuehl
> hw/core/numa.c | 45 +++--
> 2 files changed, 25 insertions(+), 23 deletions(-)
>
> --
> 2.31.1
For the series:
Reviewed-by: Connor Kuehl
On 7/7/21 11:04 AM, Peter Lieven wrote:
> task->complete is a bool not an integer.
>
> Signed-off-by: Peter Lieven
> ---
> block/rbd.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/block/rbd.c b/block/rbd.c
> index 01a7b94d62..dcf82b15b8 100644
> --- a/block/rbd.c
> +
082.out | 6 --
> tests/qemu-iotests/114 | 18
> tests/qemu-iotests/114.out | 11 --
> tests/qemu-iotests/301 | 4 +---
> tests/qemu-iotests/301.out | 16 ++
> 12 files changed, 75 insertions(+), 105 deletions(-)
>
For the series + the squash attached to patch 2:
Reviewed-by: Connor Kuehl
On 6/30/21 7:01 AM, Federico Vaga wrote:
> Hello,
>
> I can't find this information on the website, so here I am.
>
> I developed a QEMU device that virtualises a PCI card that we widely use at
> CERN.
> But this card is only used at CERN.
>
> Clearly, having CERN specific devices in QEMU does
sev_encrypt_flash interface, the hashes will be accumulated by the PSP
> measurement (SEV_LAUNCH_MEASURE).
>
> Co-developed-by: James Bottomley
> Signed-off-by: James Bottomley
> Signed-off-by: Dov Murik
> ---
Reviewed-by: Connor Kuehl
On 6/21/21 2:05 PM, Dov Murik wrote:
> +static void fill_sev_hash_table_entry(SevHashTableEntry *e, const uint8_t
> *guid,
> + const uint8_t *hash, size_t hash_len)
> +{
> +memcpy(e->guid, guid, sizeof(e->guid));
> +e->len = sizeof(*e);
> +memcpy(e-
tanding: I'm guessing you didn't set
`kernel_loader_context.cmdline_size` to `cmdline_size` (defined above)
so guest owners don't have to be aware of whatever alignment precaution
QEMU takes when producing their own measurement, right?
Otherwise:
Reviewed-by: Connor Kuehl
On 6/10/21 1:45 AM, Philippe Mathieu-Daudé wrote:
> Having the HMP/QMP commands defined in monitor.c makes the stubs
> rather complicated when SEV is not built in. To simplify, move the
> SEV functions to sev.c, and remove a layer of stubs.
>
> Also make it clearer when SEV is not built in, so dev
On 6/10/21 1:45 AM, Philippe Mathieu-Daudé wrote:
> Declarations don't require these headers, remove them.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Connor Kuehl
v_fd < 0) {
>
Brijesh, do you remember if this was added with the intent that it would
be useful in a future series?
Otherwise:
Reviewed-by: Connor Kuehl
eached() which meaning is clearer.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Connor Kuehl
On 6/10/21 1:45 AM, Philippe Mathieu-Daudé wrote:
> Commit 00b81053244 ("target-i386: Remove assert_no_error usage")
> forgot to add the "qapi/error.h", add it now.
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Connor Kuehl
;
> { "execute": "sev-inject-launch-secret",
> "arguments": { "packet-header": "mypkt", "secret": "mypass", "gpa":
> 4294959104 }
> }
> {
> "error": {
> "class": "GenericError",
> "desc": "this feature or command is not currently supported"
> }
> }
>
> Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Connor Kuehl
On 6/8/21 3:45 PM, Daniel P. Berrangé wrote:
>> Right, I am just worried that if I am the only person that shows up in
>> the get_maintainer.pl output, the submitter will have to know some other
>> way who a relevant maintainer is that can take the patches otherwise
>> they won't be CC'd. Or we'll
On 6/8/21 2:34 PM, Dr. David Alan Gilbert wrote:
>> Note: because there's no maintainer entry, when running
>> ./scripts/get_maintainers.pl on target/i386/sev.c, my name and the qemu
>> mailing list is the only thing that shows up... it doesn't even show
>> previous committers (as it would before a
On 6/8/21 3:10 PM, Daniel P. Berrangé wrote:
> On Tue, Jun 08, 2021 at 02:25:37PM -0500, Connor Kuehl wrote:
>> It may not be appropriate for me to take over as a maintainer at this time,
>> but I would consider myself familiar with AMD SEV and what this code is
>> meant to
On 6/8/21 2:25 PM, Connor Kuehl wrote:
> It may not be appropriate for me to take over as a maintainer at this time,
> but I would consider myself familiar with AMD SEV and what this code is
> meant to be doing as part of a VMM for launching SEV-protected guests.
>
> To that end, I
changes so that I am CC'd on them and can help share the review burden with
whoever does maintain this code.
Signed-off-by: Connor Kuehl
---
Note: because there's no maintainer entry, when running
./scripts/get_maintainers.pl on target/i386/sev.c, my name and the qemu
mailing list is the
| 809 +-
> tools/virtiofsd/passthrough_seccomp.c | 2 +
> 3 files changed, 667 insertions(+), 147 deletions(-)
>
For the series:
Reviewed-by: Connor Kuehl
On 6/3/21 6:30 AM, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert"
>
> Removes a whole bunch of g_free's and a goto.
>
> Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Connor Kuehl
On 4/23/21 3:08 PM, Tom Lendacky wrote:
> From: Tom Lendacky
>
> Fix some spelling and grammar mistakes in the amd-memory-encryption.txt
> file. No new information added.
>
> Signed-off-by: Tom Lendacky
For the series:
Reviewed-by: Connor Kuehl
On 5/11/21 4:37 PM, Vivek Goyal wrote:
> There is no reason to set it in label "err". We should be able to set
> it right after sending reply. It is easier to read.
>
> Signed-off-by: Vivek Goyal
> ---
> tools/virtiofsd/fuse_virtio.c | 5 +
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
d
> virtiofsd: Set req->reply_sent right after sending reply
>
> tools/virtiofsd/fuse_virtio.c | 67 +++
> 1 file changed, 21 insertions(+), 46 deletions(-)
>
With the codestyle fix to appease the bot:
Reviewed-by: Connor Kuehl
(For the series)
de ID for the submount.)
>
> Signed-off-by: Max Reitz
> ---
This is a clever way of uncovering the inode ID.
Reviewed-by: Connor Kuehl
On 5/6/21 8:12 AM, Christian Schoenebeck wrote:
> To lower the entry level for new developers, add a link to the
> 9p developer docs (i.e. qemu wiki) at the beginning of 9p source
> files, that is to: https://wiki.qemu.org/Documentation/9p
>
> Signed-off-by: Christian Schoenebeck
> ---
> hw/9pfs
ill help people locate stuff much more
> easily.
>
> Signed-off-by: Daniel P. Berrangé
> ---
This looks so much better!
Reviewed-by: Connor Kuehl
>
Just a minor question on patch 2.
Otherwise, for the series:
Reviewed-by: Connor Kuehl
On 5/5/21 7:12 AM, Daniel P. Berrangé wrote:
> [..]
> The recv_fd() method returns -1 on error, 0 on end of file, or an FD
> $ qemu-system-x86_64 -netdev bridge,br=br99,helper=/bin/true,id=ns0
> qemu-system-x86_64: -netdev bridge,br=br99,helper=/bin/true,id=ns0:
> bridge helper did not send
lake
> Cc: Paolo Bonzini
> Cc: k...@vger.kernel.org
> Reviewed-by: James Bottomley
> Tested-by: James Bottomley
> Signed-off-by: Brijesh Singh
Looks good to me!
Reviewed-by: Connor Kuehl
ggested-by: Max Reitz
[ Max: provided description of data_file_raw behavior ]
Signed-off-by: Connor Kuehl
---
John, my apologies, I failed to CC you on my last revision (v2) where I
addressed your comments.
Changes since v2:
* Pulled in Max's explanation of data_file_raw behaviors with
On 4/30/21 9:45 AM, Max Reitz wrote:
>> + ``data_file_raw``
>> +If this option is set to ``on``, QEMU will always keep the external
>> +data file consistent as a standalone read-only raw image. It does
>> +this by forwarding updates through to the raw image in addition to
>> +updat
This can help lower any margin for error when making future additions to
the list, especially if they're made out of order.
While doing so, make capitalization of ASID consistent with its usage in
the SEV firmware spec (Asid -> ASID).
Signed-off-by: Connor Kuehl
Reviewed-by: Philippe
Connor Kuehl (2):
sev: use explicit indices for mapping firmware error codes to strings
sev: add missing firmware error conditions
target/i386/sev.c | 48 ---
1 file changed, 25 insertions(+), 23 deletions(-)
--
2.30.2
ned-off-by: Connor Kuehl
---
Changes since v1:
* Clarify different behaviors with these options when using qemu-img
create vs amend (Max)
* Touch on the negative case of how the file becomes inconsistent
(John)
docs/tools/qemu-img.rst | 20
1 file changed, 20
The SEV userspace header[1] exports a couple of other error conditions that
aren't listed in QEMU's SEV implementation, so let's just round out the
list.
[1] linux-headers/linux/psp-sev.h
Signed-off-by: Connor Kuehl
Reviewed-by: Philippe Mathieu-Daudé
---
target/i386/sev.c
On 4/29/21 3:33 AM, Philippe Mathieu-Daudé wrote:
> When not explicitly select a sysemu target and building virtiofsd,
> the seccomp/cap-ng libraries are not resolved, leading to this error:
>
> $ configure --target-list=i386-linux-user --disable-tools --enable-virtiofsd
> tools/meson.build:12
On 4/28/21 9:13 AM, Mahmoud Mandour wrote:
>> I am not entirely sure if this is true. The error message before this
>> patch is applied is:
>>
>> ../tools/meson.build:12:6: ERROR: Problem encountered: virtiofsd
>> requires libcap-ng-devel and seccomp-devel
>>
>> From what I know abo
On 4/28/21 8:35 AM, Mahmoud Mandour wrote:
> Previously, on configuring with --enable-virtiofsd and specifying
> a target list that does not contain a full-system emulation target,
> a spurious error message is emitted. This patch introduces a
> meaningful error message for such case.
>
> Signed-o
The deprecation message in the expected output has technically been
wrong since the wrong version of a patch was applied to it. Because of
this, the test fails. Correct the expected output so that it passes.
Signed-off-by: Connor Kuehl
Reviewed-by: Max Reitz
Reviewed-by: Stefano Garzarella
73913
Signed-off-by: Connor Kuehl
---
v3 -> v4:
* Replace qemu_rbd_next_tok() seek loop with qemu_rbd_strchr() since
they're identical
block/rbd.c| 32 +---
tests/qemu-iotests/231 | 4
tests/qemu-iotests/231.out | 3 +++
3 file
Connor Kuehl (2):
iotests/231: Update expected deprecation message
block/rbd: Add an escape-aware strchr helper
block/rbd.c| 32 +---
tests/qemu-iotests/231 | 4
tests/qemu-iotests/231.out | 7 ---
3 files changed, 29 insertions
On 4/21/21 6:04 AM, Stefano Garzarella wrote:
>> +static char *qemu_rbd_strchr(char *src, char delim)
>> +{
>> +char *p;
>> +
>> +for (p = src; *p; ++p) {
>> +if (*p == delim) {
>> +return p;
>> +}
>> +if (*p == '\\' && p[1] != '\0') {
>> +++p
On 4/19/21 2:07 PM, Vivek Goyal wrote:
>> This is a helpful note, but it doesn't tell the whole story. I think
>> it'd be helpful to add one last note to this option which is to
>> recommend reading the virtiofsd(1) man-page for more information on
>> xattrmap rules.
>
> Is there a virtiofsd man p
series:
Reviewed-by: Connor Kuehl
lp`
> output.
>
> Carlos Venegas (2):
> virtiofsd: Allow use "-o xattrmap" without "-o xattr"
> virtiofsd: Add help for -o xattr-mapping
Good usability improvement.
For the series:
Reviewed-by: Connor Kuehl
On Wed Apr 14, 2021 at 3:12 PM CDT, Carlos Venegas wrote:
> The option is not documented in help.
>
> Add small help about the option.
>
> Signed-off-by: Carlos Venegas
> ---
> tools/virtiofsd/helper.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/tools/virtiofsd/helper.c b/tools/virt
On 4/9/21 9:27 AM, Markus Armbruster wrote:
Connor Kuehl writes:
block/rbd.c hints that:
* Configuration values containing :, @, or = can be escaped with a
* leading "\".
Right now, much of the parsing code will allow anyone to escape
_anything_ so long as it's prece
On 3/23/21 6:15 PM, John Snow wrote:
On 3/1/21 12:28 PM, Connor Kuehl wrote:
[..]
diff --git a/docs/tools/qemu-img.rst b/docs/tools/qemu-img.rst
index b615aa8419..5cc585dc27 100644
--- a/docs/tools/qemu-img.rst
+++ b/docs/tools/qemu-img.rst
@@ -866,6 +866,18 @@ Supported image file formats
On 3/26/21 4:24 AM, Max Reitz wrote:
On 01.03.21 18:28, Connor Kuehl wrote:
[..]
diff --git a/docs/tools/qemu-img.rst b/docs/tools/qemu-img.rst
index b615aa8419..5cc585dc27 100644
--- a/docs/tools/qemu-img.rst
+++ b/docs/tools/qemu-img.rst
@@ -866,6 +866,18 @@ Supported image file formats
Connor Kuehl (2):
iotests/231: Update expected deprecation message
block/rbd: Add an escape-aware strchr helper
block/rbd.c| 20 ++--
tests/qemu-iotests/231 | 4
tests/qemu-iotests/231.out | 7 ---
3 files changed, 26 insertions(+), 5 deletions
The deprecation message in the expected output has technically been
wrong since the wrong version of a patch was applied to it. Because of
this, the test fails. Correct the expected output so that it passes.
Signed-off-by: Connor Kuehl
Reviewed-by: Max Reitz
---
tests/qemu-iotests/231.out | 4
trchr to avoid mixing escaped and unescaped string
operations.
Reported-by: Han Han
Fixes: https://bugzilla.redhat.com/1873913
Signed-off-by: Connor Kuehl
---
v2 -> v3:
* Update qemu_rbd_strchr to only skip if there's a delimiter AND the
next character is not the NUL terminator
On 4/6/21 9:24 AM, Max Reitz wrote:
On 01.04.21 23:01, Connor Kuehl wrote:
[..]
diff --git a/block/rbd.c b/block/rbd.c
index 9071a00e3f..c0e4d4a952 100644
--- a/block/rbd.c
+++ b/block/rbd.c
@@ -134,6 +134,22 @@ static char *qemu_rbd_next_tok(char *src, char
delim, char **p)
return src
Hi,
block/rbd.c hints that:
* Configuration values containing :, @, or = can be escaped with a
* leading "\".
Right now, much of the parsing code will allow anyone to escape
_anything_ so long as it's preceded by '\'.
Is this the intended behavior? Or should the parser be updated to allo
trchr to avoid mixing escaped and unescaped string
operations.
Reported-by: Han Han
Fixes: https://bugzilla.redhat.com/1873913
Signed-off-by: Connor Kuehl
---
block/rbd.c| 20 ++--
tests/qemu-iotests/231 | 4
tests/qemu-iotests/231.out | 3 +++
3 files ch
The deprecation message in the expected output has technically been
wrong since the wrong version of a patch was applied to it. Because of
this, the test fails. Correct the expected output so that it passes.
Signed-off-by: Connor Kuehl
Reviewed-by: Max Reitz
---
Reworded the commit log and
Replaced the change to qemu_rbd_next_tok with a standalone escape-aware
helper for patch 2.
Connor Kuehl (2):
iotests/231: Update expected deprecation message
block/rbd: Add an escape-aware strchr helper
block/rbd.c| 20 ++--
tests/qemu-iotests/231 | 4
On 4/1/21 12:24 PM, Max Reitz wrote:
On 01.04.21 17:52, Connor Kuehl wrote:
That's qemu_rbd_unescape()'s job! No need to duplicate the labor.
Furthermore, this was causing some confusion in the parsing logic to
where the caller might test for the presence of a character to split
On 4/1/21 12:07 PM, Max Reitz wrote:
On 01.04.21 18:52, Max Reitz wrote:
On 01.04.21 17:52, Connor Kuehl wrote:
The deprecation message changed slightly at some point in the past but
the expected output wasn't updated along with it; causing it to fail.
Fix it, so it passes.
Signed-o
The deprecation message changed slightly at some point in the past but
the expected output wasn't updated along with it; causing it to fail.
Fix it, so it passes.
Signed-off-by: Connor Kuehl
---
tests/qemu-iotests/231.out | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --
e_name: bar
and its subordinate parts can be unescaped after tokenization.
So, instead of tokenizing *and* escaping all at once, do one before the
other to avoid stumbling into a segfault by confusing the parsing logic.
Reported-by: Han Han
Fixes: https://bugzilla.redhat.com/1873913
Signed-off-by
Connor Kuehl (2):
iotests/231: Update expected deprecation message
block/rbd: Don't unescape in qemu_rbd_next_tok()
block/rbd.c| 3 ---
tests/qemu-iotests/231 | 4
tests/qemu-iotests/231.out | 7 ---
3 files changed, 8 insertions(+), 6 deletions(-)
--
2.30.2
curity
Fixes: e586edcb41054 ("virtiofs: drop remapped security.capability xattr as
needed")
Signed-off-by: Dr. David Alan Gilbert
Reviewed-by: Connor Kuehl
---
tools/virtiofsd/passthrough_ll.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/tools/virtiofsd
On 3/22/21 5:18 AM, Philippe Mathieu-Daudé wrote:
Hi Connor,
On 3/15/21 3:08 PM, Connor Kuehl wrote:
On 2/18/21 9:16 AM, Connor Kuehl wrote:
Connor Kuehl (2):
sev: use explicit indices for mapping firmware error codes to strings
sev: add missing firmware error conditions
target
Oops, sorry about the churn. I can see why this would have caused a
failure but I'm surprised I can't reproduce this when I run the test
locally.
Christian, would you be willing to test this patch out as a quick sanity
check too?
Connor Kuehl (1):
iotests: fix 051.out expected ou
s pertaining to
'node-name'")
Signed-off-by: Connor Kuehl
---
tests/qemu-iotests/051.out | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tests/qemu-iotests/051.out b/tests/qemu-iotests/051.out
index de4771bcb3..db8c14b903 100644
--- a/tests/qemu-iotests/051.ou
General discussion and patch reviews take place on this list for both
virtiofsd (tools/virtiofsd/*) and the guest kernel module.
Signed-off-by: Connor Kuehl
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 25fc49d1dc..8921bc2119 100644
--- a
patches the last place it was missing from, nice!
Reviewed-by: Connor Kuehl
On 2/18/21 9:16 AM, Connor Kuehl wrote:
Connor Kuehl (2):
sev: use explicit indices for mapping firmware error codes to strings
sev: add missing firmware error conditions
target/i386/sev.c | 48 ---
1 file changed, 25 insertions(+), 23
Ping (+Kevin Wolf to CC)
Kevin, would this be appropriate for your tree?
On 3/1/21 11:28 AM, Connor Kuehl wrote:
The contents of this patch were initially developed and posted by Han
Han[1], however, it appears the original patch was not applied. Since
then, the relevant documentation has been
3.html#tag_03_170
[2]
https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/V1_chap04.html#tag_04_13
Signed-off-by: Greg Kurz
Reviewed-by: Connor Kuehl
to pull off making an entry with an empty name
However, I don't know if there will one day be future callers to
lo_do_lookup() that will depend on that flag.
If the answer to the above is no, then:
Reviewed-by: Connor Kuehl
/* Is `path` a single path component that is not "." or ".."? */
-static int is_safe_path_component(const char *path)
+static bool is_safe_path_component(const char *path)
{
if (strchr(path, '/')) {
-return 0;
+ return false;
}
return !is_dot_or_dotdot(path);
Reviewed-by: Connor Kuehl
On 3/1/21 11:28 AM, Connor Kuehl wrote:
The contents of this patch were initially developed and posted by Han
Han[1], however, it appears the original patch was not applied. Since
then, the relevant documentation has been moved and adapted to a new
format.
I've taken most of the ori
On 2/18/21 9:16 AM, Connor Kuehl wrote:
Connor Kuehl (2):
sev: use explicit indices for mapping firmware error codes to strings
sev: add missing firmware error conditions
target/i386/sev.c | 48 ---
1 file changed, 25 insertions(+), 23
Signed-off-by: Connor Kuehl
---
blockdev.c | 13 +++--
tests/qemu-iotests/245 | 6 +++---
2 files changed, 10 insertions(+), 9 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index cd438e60e3..7c7ab2b386 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1515,13 +1515,13
v2:
- Moved summary into patch #1
- Updated test cases that were missed in v1 from running 'make check'.
This time I used 'make check-block SPEED=thorough' and some more
grepping to make sure I didn't miss any.
- Rebased
Connor Kuehl (2):
block: Clarify
nderscore is actually incorrect, the parameter should be
'node-name':
S: {"error": {"class": "GenericError", "desc": "Parameter 'node_name' is
unexpected"}}
This behavior was uncovered in bz1651437, but I ended up going down a
On 3/3/21 3:53 AM, Kevin Wolf wrote:
Am 02.03.2021 um 00:36 hat Connor Kuehl geschrieben:
Some error messages contain ambiguous representations of the 'node-name'
parameter. This can be particularly confusing when exchanging QMP
messages (C = client, S = server):
C: {"execute&
Signed-off-by: Connor Kuehl
---
blockdev.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/blockdev.c b/blockdev.c
index cd438e60e3..7c7ab2b386 100644
--- a/blockdev.c
+++ b/blockdev.c
@@ -1515,13 +1515,13 @@ static void external_snapshot_prepare(BlkActionState
nderscore is actually incorrect, the parameter should be
'node-name':
S: {"error": {"class": "GenericError", "desc": "Parameter 'node_name' is
unexpected"}}
This behavior was uncovered in bz1651437[1], but I ended up going down a
Reported-by: Tingting Mao
Fixes: https://bugzilla.redhat.com/1651437
Signed-off-by: Connor Kuehl
---
block.c| 8
tests/qemu-iotests/040 | 4 ++--
tests/qemu-iotests/249.out | 2 +-
3 files changed, 7 insertions(+), 7 deletions(-)
diff --git a/block.c b/block.c
xes: https://bugzilla.redhat.com/1763105
Signed-off-by: Connor Kuehl
---
docs/tools/qemu-img.rst | 12
1 file changed, 12 insertions(+)
diff --git a/docs/tools/qemu-img.rst b/docs/tools/qemu-img.rst
index b615aa8419..5cc585dc27 100644
--- a/docs/tools/qemu-img.rst
+++ b/docs/tools/qemu-img.rst
@@ -866
1 - 100 of 123 matches
Mail list logo
