Re: [Qemu-devel] [qemu-s390x] [Bug 1753437] [NEW] qemu/pc-bios/s390-ccw/libc.c:82: bad test ?

2018-03-05 Thread Collin L. Walling
But yes, this is ugly, we should fix the function and re-define size_t to be unsigned instead... Thomas Agreed. -- - Collin L Walling

[Qemu-devel] [PATCH v2] s390/ipl: only print boot menu error if -boot menu=on was specified

2018-02-27 Thread Collin L. Walling
enu=on was provided on the commandline. Otherwise, return silently. While we're at it, remove trailing periods from error messages. Signed-off-by: Collin L. Walling --- hw/s390x/ipl.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.

Re: [Qemu-devel] [PATCH] s390-ccw: only print boot menu error if -boot menu=on was specified

2018-02-27 Thread Collin L. Walling
On 02/27/2018 02:18 PM, Cornelia Huck wrote: On Tue, 27 Feb 2018 10:19:20 -0500 "Collin L. Walling" wrote: Nit: make the prefix s390x/ipl:, as this is not directly in the bios. It is possible that certain QEMU configurations may not create an IPLB (such as when -kernel is provided

[Qemu-devel] [PATCH] s390-ccw: only print boot menu error if -boot menu=on was specified

2018-02-27 Thread Collin L. Walling
enu=on was provided on the commandline. Otherwise, return silently. Signed-off-by: Collin L. Walling --- hw/s390x/ipl.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index 798e99a..c4addb5 100644 --- a/hw/s390x/ipl.c +++ b/hw/s390x/ipl.c @@ -25

Re: [Qemu-devel] [qemu-s390x] [PULL-for-s390x 06/14] s390-ccw: parse and set boot menu options

2018-02-27 Thread Collin L. Walling
On 02/27/2018 04:22 AM, Thomas Huth wrote: On 27.02.2018 10:12, Cornelia Huck wrote: On Mon, 26 Feb 2018 14:44:45 -0500 "Collin L. Walling" wrote: On 02/26/2018 02:29 PM, Collin L. Walling wrote: On 02/26/2018 01:48 PM, Cornelia Huck wrote: On Mon, 26 Feb 2018 11:42:29 +0100 T

Re: [Qemu-devel] [qemu-s390x] [PULL-for-s390x 06/14] s390-ccw: parse and set boot menu options

2018-02-26 Thread Collin L. Walling
On 02/26/2018 02:29 PM, Collin L. Walling wrote: On 02/26/2018 01:48 PM, Cornelia Huck wrote: On Mon, 26 Feb 2018 11:42:29 +0100 Thomas Huth wrote: [...]   3 files changed, 66 insertions(+), 4 deletions(-) +static void s390_ipl_set_boot_menu(S390IPLState *ipl) +{ +    QemuOptsList *plist

Re: [Qemu-devel] [qemu-s390x] [PULL-for-s390x 06/14] s390-ccw: parse and set boot menu options

2018-02-26 Thread Collin L. Walling
On 02/26/2018 01:48 PM, Cornelia Huck wrote: On Mon, 26 Feb 2018 11:42:29 +0100 Thomas Huth wrote: From: "Collin L. Walling" Set boot menu options for an s390 guest and store them in the iplb. These options are set via the QEMU command line option: -boot menu=on|off[,spl

Re: [Qemu-devel] [PATCH v9 05/13] s390-ccw: move auxiliary IPL data to separate location

2018-02-23 Thread Collin L. Walling
On 02/23/2018 11:03 AM, Thomas Huth wrote: On 23.02.2018 16:43, Collin L. Walling wrote: The s390-ccw firmware needs some information in support of the boot process which is not available on the native machine. Examples are the netboot firmware load address and now the boot menu parameters

[Qemu-devel] [PATCH v9 09/13] s390-ccw: print zipl boot menu

2018-02-23 Thread Collin L. Walling
linux-4.13.0) 1. linux-4.13.0 2. performance 3. kvm Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/menu.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/pc-bios/s390-ccw/menu.c b/pc-bios/s390-ccw/menu.c

[Qemu-devel] [PATCH v9 12/13] s390-ccw: use zipl values when no boot menu options are present

2018-02-23 Thread Collin L. Walling
boot menu timeout=X set the timeout to X seconds To explicitly disregard any boot menu options, then menu=off or must be specified. Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- hw/s390x/ipl.c | 5 + hw/s390x/ipl.h | 1 + pc-bios/s390-ccw

[Qemu-devel] [PATCH v9 13/13] s390-ccw: interactive boot menu for scsi

2018-02-23 Thread Collin L. Walling
Interactive boot menu for scsi. This follows a similar procedure as the interactive menu for eckd dasd. An example follows: s390x Enumerated Boot Menu. 3 entries detected. Select from index 0 to 2. Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- hw/s390x/ipl.c

[Qemu-devel] [PATCH v9 07/13] s390-ccw: set up interactive boot menu parameters

2018-02-23 Thread Collin L. Walling
Reads boot menu flag and timeout values from the iplb and sets the respective fields for the menu. Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/Makefile | 2 +- pc-bios/s390-ccw/main.c | 24 pc-bios/s390-ccw/menu.c | 22

[Qemu-devel] [PATCH v9 10/13] s390-ccw: read user input for boot index via the SCLP console

2018-02-23 Thread Collin L. Walling
boot entries, then the selection will be booted. Any erroneous input will cancel the timeout and re-prompt the user. Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/menu.c | 149 +++- pc-bios/s390-ccw/s390-ccw.h | 2 + pc

[Qemu-devel] [PATCH v9 06/13] s390-ccw: parse and set boot menu options

2018-02-23 Thread Collin L. Walling
for loadparm will override all boot menu options. If loadparm=PROMPT, then the menu will be enabled without a timeout. Signed-off-by: Collin L. Walling Reviewed-by: Janosch Frank Reviewed-by: Thomas Huth --- hw/s390x/ipl.c | 52 + hw/s390x

[Qemu-devel] [PATCH v9 11/13] s390-ccw: set cp_receive mask only when needed and consume pending service irqs

2018-02-23 Thread Collin L. Walling
e at it, remove assignment of the (non control program) send and receive masks, as those are actually set by the SCLP. Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/menu.c | 5 + pc-bios/s390-ccw/s390-ccw.h | 1 + pc-bios/s390-ccw/sclp.c | 10

[Qemu-devel] [PATCH v9 01/13] s390-ccw: refactor boot map table code

2018-02-23 Thread Collin L. Walling
BootMapTable - fixup ipl_scsi to use BootMapTable (referred to as Program Table) - defined value for maximum table entries Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/bootmap.c | 60 +- pc-bios/s390-ccw/bootmap.h | 11

[Qemu-devel] [PATCH v9 08/13] s390-ccw: read stage2 boot loader data to find menu

2018-02-23 Thread Collin L. Walling
ned-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/bootmap.c | 94 ++--- pc-bios/s390-ccw/bootmap.h | 23 ++- pc-bios/s390-ccw/menu.c | 10 + pc-bios/s390-ccw/s390-ccw.h | 2 + 4 files changed, 122 insertions(+), 7

[Qemu-devel] [PATCH v9 05/13] s390-ccw: move auxiliary IPL data to separate location

2018-02-23 Thread Collin L. Walling
IPL has completed. Signed-off-by: Viktor Mihajlovski Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- hw/s390x/ipl.c | 18 +- hw/s390x/ipl.h | 25 +++-- pc-bios/s390-ccw/iplb.h | 18 -- pc-bios/s390-ccw/main.c

[Qemu-devel] [PATCH v9 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-23 Thread Collin L. Walling
e IPL'd from A loadparm other than 'prompt' will disable the menu and just boot the specified entry. If no boot options are specified, we will attempt to use the values provided by zipl (ECKD DASD only). Collin L. Walling (13): s390-ccw: refactor boot map table code s390-ccw:

[Qemu-devel] [PATCH v9 04/13] s390-ccw: update libc

2018-02-23 Thread Collin L. Walling
Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) Added C standard functions: isdigit Added non C-standard function: uitoa atoui Signed-off-by: Collin L. Walling Acked-by: Christian Borntraeger Reviewed-by: Janosch

[Qemu-devel] [PATCH v9 03/13] s390-ccw: refactor IPL structs

2018-02-23 Thread Collin L. Walling
ECKD DASDs have different IPL structures for CDL and LDL formats. The current Ipl1 and Ipl2 structs follow the CDL format, so we prepend "EckdCdl" to them. Boot info for LDL has been moved to a new struct: EckdLdlIpl1. Signed-off-by: Collin L. Walling Acked-by: Janosch Frank Reviewed-

[Qemu-devel] [PATCH v9 02/13] s390-ccw: refactor eckd_block_num to use CHS

2018-02-23 Thread Collin L. Walling
Add new cylinder/head/sector struct. Use it to calculate eckd block numbers instead of a BootMapPointer (which used eckd chs anyway). Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/bootmap.c | 28 ++-- pc-bios/s390-ccw/bootmap.h | 8

Re: [Qemu-devel] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-23 Thread Collin L. Walling
I'll respin 9 and reply to this chain. -- - Collin L Walling

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-23 Thread Collin L. Walling
On 02/23/2018 09:57 AM, Collin L. Walling wrote: On 02/23/2018 05:11 AM, Christian Borntraeger wrote: On 02/23/2018 11:07 AM, Thomas Huth wrote: On 22.02.2018 20:40, Collin L. Walling wrote: On 02/22/2018 11:45 AM, Collin L. Walling wrote: On 02/22/2018 10:44 AM, Christian Borntraeger wrote

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-23 Thread Collin L. Walling
On 02/23/2018 05:11 AM, Christian Borntraeger wrote: On 02/23/2018 11:07 AM, Thomas Huth wrote: On 22.02.2018 20:40, Collin L. Walling wrote: On 02/22/2018 11:45 AM, Collin L. Walling wrote: On 02/22/2018 10:44 AM, Christian Borntraeger wrote: On 02/22/2018 04:40 PM, Collin L. Walling wrote

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-22 Thread Collin L. Walling
On 02/22/2018 11:45 AM, Collin L. Walling wrote: On 02/22/2018 10:44 AM, Christian Borntraeger wrote: On 02/22/2018 04:40 PM, Collin L. Walling wrote: On 02/22/2018 07:23 AM, Viktor Mihajlovski wrote: On 22.02.2018 12:51, Christian Borntraeger wrote: Series Acked-by: Christian Borntraeger

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-22 Thread Collin L. Walling
On 02/22/2018 10:44 AM, Christian Borntraeger wrote: On 02/22/2018 04:40 PM, Collin L. Walling wrote: On 02/22/2018 07:23 AM, Viktor Mihajlovski wrote: On 22.02.2018 12:51, Christian Borntraeger wrote: Series Acked-by: Christian Borntraeger Thanks!!! menu on scsi and dasd bootmaps

Re: [Qemu-devel] [qemu-s390x] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-22 Thread Collin L. Walling
together. Shall I whip something up and post what I have as a reply to this email chain? -- - Collin L Walling

[Qemu-devel] [PATCH v8 11/13] s390-ccw: set cp_receive mask only when needed and consume pending service irqs

2018-02-21 Thread Collin L. Walling
e at it, remove assignment of the (non control program) send and receive masks, as those are actually set by the SCLP. Signed-off-by: Collin L. Walling --- pc-bios/s390-ccw/menu.c | 5 + pc-bios/s390-ccw/s390-ccw.h | 1 + pc-bios/s390-ccw/sclp.c | 10 -- 3 files changed, 10 i

[Qemu-devel] [PATCH v8 06/13] s390-ccw: parse and set boot menu options

2018-02-21 Thread Collin L. Walling
for loadparm will override all boot menu options. If loadparm=PROMPT, then the menu will be enabled without a timeout. Signed-off-by: Collin L. Walling Reviewed-by: Janosch Frank --- hw/s390x/ipl.c | 44 hw/s390x/ipl.h | 9

[Qemu-devel] [PATCH v8 05/13] s390-ccw: move auxiliary IPL data to separate location

2018-02-21 Thread Collin L. Walling
IPL has completed. Signed-off-by: Viktor Mihajlovski Signed-off-by: Collin L. Walling --- hw/s390x/ipl.c | 18 +- hw/s390x/ipl.h | 25 +++-- pc-bios/s390-ccw/iplb.h | 18 -- pc-bios/s390-ccw/main.c | 6 +- 4 files changed

[Qemu-devel] [PATCH v8 12/13] s390-ccw: use zipl values when no boot menu options are present

2018-02-21 Thread Collin L. Walling
boot menu timeout=X set the timeout to X seconds To explicitly disregard any boot menu options, then menu=off or must be specified. Signed-off-by: Collin L. Walling --- hw/s390x/ipl.c | 5 + hw/s390x/ipl.h | 1 + pc-bios/s390-ccw/iplb.h | 1 + pc-bios/s390

[Qemu-devel] [PATCH v8 00/13] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-21 Thread Collin L. Walling
menu and just boot the specified entry. If no boot options are specified, we will attempt to use the values provided by zipl (ECKD DASD only). Collin L. Walling (13): s390-ccw: refactor boot map table code s390-ccw: refactor eckd_block_num to use CHS s390-ccw: refactor IPL structs s390-ccw: up

[Qemu-devel] [PATCH v8 09/13] s390-ccw: print zipl boot menu

2018-02-21 Thread Collin L. Walling
linux-4.13.0) 1. linux-4.13.0 2. performance 3. kvm Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/menu.c | 33 - 1 file changed, 32 insertions(+), 1 deletion(-) diff --git a/pc-bios/s390-ccw/menu.c b/pc-bios/s390-ccw/menu.c

[Qemu-devel] [PATCH v8 01/13] s390-ccw: refactor boot map table code

2018-02-21 Thread Collin L. Walling
BootMapTable - fixup ipl_scsi to use BootMapTable (referred to as Program Table) - defined value for maximum table entries Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/bootmap.c | 60 +- pc-bios/s390-ccw/bootmap.h | 11

[Qemu-devel] [PATCH v8 13/13] s390-ccw: interactive boot menu for scsi

2018-02-21 Thread Collin L. Walling
Interactive boot menu for scsi. This follows a similar procedure as the interactive menu for eckd dasd. An example follows: s390x Enumerated Boot Menu. 3 entries detected. Select from index 0 to 2. Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- hw/s390x/ipl.c

[Qemu-devel] [PATCH v8 08/13] s390-ccw: read stage2 boot loader data to find menu

2018-02-21 Thread Collin L. Walling
ned-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/bootmap.c | 94 ++--- pc-bios/s390-ccw/bootmap.h | 23 ++- pc-bios/s390-ccw/menu.c | 5 +++ pc-bios/s390-ccw/s390-ccw.h | 1 + 4 files changed, 116 insertions(+), 7

[Qemu-devel] [PATCH v8 07/13] s390-ccw: set up interactive boot menu parameters

2018-02-21 Thread Collin L. Walling
Reads boot menu flag and timeout values from the iplb and sets the respective fields for the menu. Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/Makefile | 2 +- pc-bios/s390-ccw/main.c | 24 pc-bios/s390-ccw/menu.c | 27

[Qemu-devel] [PATCH v8 03/13] s390-ccw: refactor IPL structs

2018-02-21 Thread Collin L. Walling
ECKD DASDs have different IPL structures for CDL and LDL formats. The current Ipl1 and Ipl2 structs follow the CDL format, so we prepend "EckdCdl" to them. Boot info for LDL has been moved to a new struct: EckdLdlIpl1. Signed-off-by: Collin L. Walling Acked-by: Janosch Frank Reviewed-

[Qemu-devel] [PATCH v8 04/13] s390-ccw: update libc

2018-02-21 Thread Collin L. Walling
Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) Added C standard functions: isdigit Added non C-standard function: uitoa atoui Signed-off-by: Collin L. Walling Acked-by: Christian Borntraeger Reviewed-by: Janosch

[Qemu-devel] [PATCH v8 02/13] s390-ccw: refactor eckd_block_num to use CHS

2018-02-21 Thread Collin L. Walling
Add new cylinder/head/sector struct. Use it to calculate eckd block numbers instead of a BootMapPointer (which used eckd chs anyway). Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/bootmap.c | 28 ++-- pc-bios/s390-ccw/bootmap.h | 8

[Qemu-devel] [PATCH v8 10/13] s390-ccw: read user input for boot index via the SCLP console

2018-02-21 Thread Collin L. Walling
boot entries, then the selection will be booted. Any erroneous input will cancel the timeout and re-prompt the user. Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/menu.c | 149 +++- pc-bios/s390-ccw/s390-ccw.h | 2 + pc

Re: [Qemu-devel] [PATCH v7 06/12] s390-ccw: parse and set boot menu options

2018-02-19 Thread Collin L. Walling
On 02/19/2018 10:52 AM, Viktor Mihajlovski wrote: On 16.02.2018 23:07, Collin L. Walling wrote: [...] diff --git a/hw/s390x/ipl.h b/hw/s390x/ipl.h index 74469b1..f632c59 100644 --- a/hw/s390x/ipl.h +++ b/hw/s390x/ipl.h @@ -60,6 +60,9 @@ typedef struct IplBlockQemuScsi IplBlockQemuScsi

Re: [Qemu-devel] [qemu-s390x] [PATCH v7 04/12] s390-ccw: update libc

2018-02-19 Thread Collin L. Walling
On 02/19/2018 11:19 AM, Collin L. Walling wrote: On 02/19/2018 11:00 AM, Thomas Huth wrote: On 19.02.2018 16:40, Collin L. Walling wrote: On 02/17/2018 02:48 AM, Thomas Huth wrote: On 16.02.2018 23:07, Collin L. Walling wrote: [...] +/** + * uitoa: + * @num: an integer (base 10) to be

Re: [Qemu-devel] [qemu-s390x] [PATCH v7 04/12] s390-ccw: update libc

2018-02-19 Thread Collin L. Walling
On 02/19/2018 11:00 AM, Thomas Huth wrote: On 19.02.2018 16:40, Collin L. Walling wrote: On 02/17/2018 02:48 AM, Thomas Huth wrote: On 16.02.2018 23:07, Collin L. Walling wrote: [...] +/** + * uitoa: + * @num: an integer (base 10) to be converted. + * @str: a pointer to a string to store the

Re: [Qemu-devel] [PATCH v7 11/12] s390-ccw: set cp_receive mask only when needed and consume pending service irqs

2018-02-19 Thread Collin L. Walling
On 02/19/2018 09:17 AM, Christian Borntraeger wrote: On 02/19/2018 03:15 PM, Christian Borntraeger wrote: On 02/16/2018 11:07 PM, Collin L. Walling wrote: It is possible while waiting for multiple types of external interrupts that we might have pending irqs remaining between irq consumption

Re: [Qemu-devel] [PATCH v7 11/12] s390-ccw: set cp_receive mask only when needed and consume pending service irqs

2018-02-19 Thread Collin L. Walling
On 02/19/2018 09:15 AM, Christian Borntraeger wrote: On 02/16/2018 11:07 PM, Collin L. Walling wrote: It is possible while waiting for multiple types of external interrupts that we might have pending irqs remaining between irq consumption and irq-type disabling. Those interrupts could

Re: [Qemu-devel] [qemu-s390x] [PATCH v7 04/12] s390-ccw: update libc

2018-02-19 Thread Collin L. Walling
On 02/17/2018 02:48 AM, Thomas Huth wrote: On 16.02.2018 23:07, Collin L. Walling wrote: [...] +/** + * uitoa: + * @num: an integer (base 10) to be converted. + * @str: a pointer to a string to store the conversion. + * @len: the length of the passed string. + * + * Given an integer @num

[Qemu-devel] [PATCH v7 08/12] s390-ccw: read stage2 boot loader data to find menu

2018-02-16 Thread Collin L. Walling
ned-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/bootmap.c | 94 +++--- pc-bios/s390-ccw/bootmap.h | 23 +++- pc-bios/s390-ccw/menu.c| 5 +++ pc-bios/s390-ccw/menu.h| 1 + 4 files changed, 116 insertions(+), 7 deletion

[Qemu-devel] [PATCH v7 09/12] s390-ccw: print zipl boot menu

2018-02-16 Thread Collin L. Walling
fault (linux-4.13.0) 1. linux-4.13.0 2. performance 3. kvm Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/menu.c | 49 - 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/pc-bios/s390-ccw/menu.c b/pc

[Qemu-devel] [PATCH v7 10/12] s390-ccw: read user input for boot index via the SCLP console

2018-02-16 Thread Collin L. Walling
boot entries, then the selection will be booted. Any erroneous input will cancel the timeout and re-prompt the user. Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/menu.c | 146 +++- pc-bios/s390-ccw/s390-ccw.h | 2 + pc

[Qemu-devel] [PATCH v7 11/12] s390-ccw: set cp_receive mask only when needed and consume pending service irqs

2018-02-16 Thread Collin L. Walling
al measure, once we've disabled/cleared the control program's receive mask, we will print an empty string in order to consume any pending service interrupt. Signed-off-by: Collin L. Walling --- pc-bios/s390-ccw/menu.c | 5 + pc-bios/s390-ccw/s390-ccw.h | 1 + pc-bios/s390

[Qemu-devel] [PATCH v7 04/12] s390-ccw: update libc

2018-02-16 Thread Collin L. Walling
Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) Added C standard functions: isdigit Added non C-standard function: uitoa atoui Signed-off-by: Collin L. Walling Acked-by: Christian Borntraeger Reviewed-by: Janosch

[Qemu-devel] [PATCH v7 07/12] s390-ccw: set up interactive boot menu parameters

2018-02-16 Thread Collin L. Walling
Reads boot menu flag and timeout values from the iplb and sets the respective fields for the menu. Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/Makefile | 2 +- pc-bios/s390-ccw/main.c | 24 pc-bios/s390-ccw/menu.c | 26

[Qemu-devel] [PATCH v7 12/12] s390-ccw: interactive boot menu for scsi

2018-02-16 Thread Collin L. Walling
Interactive boot menu for scsi. This follows a similar procedure as the interactive menu for eckd dasd. An example follows: s390x Enumerated Boot Menu. 3 entries detected. Select from index 0 to 2. Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw

[Qemu-devel] [PATCH v7 05/12] s390-ccw: move auxiliary IPL data to separate location

2018-02-16 Thread Collin L. Walling
IPL has completed. Signed-off-by: Viktor Mihajlovski Signed-off-by: Collin L. Walling --- hw/s390x/ipl.c | 19 ++- hw/s390x/ipl.h | 19 +-- pc-bios/s390-ccw/iplb.h | 20 ++-- pc-bios/s390-ccw/main.c | 6 +- 4 files changed, 58

[Qemu-devel] [PATCH v7 01/12] s390-ccw: refactor boot map table code

2018-02-16 Thread Collin L. Walling
BootMapTable - fixup ipl_scsi to use BootMapTable (referred to as Program Table) - defined value for maximum table entries Signed-off-by: Collin L. Walling --- pc-bios/s390-ccw/bootmap.c | 60 +- pc-bios/s390-ccw/bootmap.h | 11 - 2 files changed, 37

[Qemu-devel] [PATCH v7 06/12] s390-ccw: parse and set boot menu options

2018-02-16 Thread Collin L. Walling
for loadparm will override all boot menu options. If loadparm=PROMPT, then the menu will be enabled without a timeout. The absence of any boot options on the command line will flag to later use the zipl boot loader values. Signed-off-by: Collin L. Walling Reviewed-by: Janosch Frank Reviewed-by

[Qemu-devel] [PATCH v7 03/12] s390-ccw: refactor IPL structs

2018-02-16 Thread Collin L. Walling
ECKD DASDs have different IPL structures for CDL and LDL formats. The current Ipl1 and Ipl2 structs follow the CDL format, so we prepend "EckdCdl" to them. Boot info for LDL has been moved to a new struct: EckdLdlIpl1. Signed-off-by: Collin L. Walling Acked-by: Janosch Frank Reviewed-

[Qemu-devel] [PATCH v7 02/12] s390-ccw: refactor eckd_block_num to use CHS

2018-02-16 Thread Collin L. Walling
Add new cylinder/head/sector struct. Use it to calculate eckd block numbers instead of a BootMapPointer (which used eckd chs anyway). Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/bootmap.c | 28 ++-- pc-bios/s390-ccw/bootmap.h | 8

[Qemu-devel] [PATCH v7 00/12] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-16 Thread Collin L. Walling
e the values provided by zipl (ECKD DASD only). Collin L. Walling (12): s390-ccw: refactor boot map table code s390-ccw: refactor eckd_block_num to use CHS s390-ccw: refactor IPL structs s390-ccw: update libc s390-ccw: move auxiliary IPL data to separate location s390-ccw: parse and

Re: [Qemu-devel] [qemu-s390x] [PATCH v6 06/12] s390-ccw: parse and set boot menu options

2018-02-16 Thread Collin L. Walling
-uint8_t reserved2[16]; +uint8_t reserved2[14]; } QEMU_PACKED; typedef struct QemuIplParameters QemuIplParameters; Thomas -- - Collin L Walling

Re: [Qemu-devel] [qemu-s390x] [PATCH v6 06/12] s390-ccw: parse and set boot menu options

2018-02-16 Thread Collin L. Walling
On 02/16/2018 11:20 AM, Thomas Huth wrote: On 15.02.2018 23:54, Collin L. Walling wrote: Set boot menu options for an s390 guest and store them in the iplb. These options are set via the QEMU command line option: -boot menu=on|off[,splash-time=X] or via the libvirt domain xml

Re: [Qemu-devel] [qemu-s390x] [PATCH v6 04/12] s390-ccw: update libc

2018-02-16 Thread Collin L. Walling
On 02/16/2018 11:05 AM, Thomas Huth wrote: On 15.02.2018 23:54, Collin L. Walling wrote: Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) What happened to the renames of _strlen to strlen and _memcmp to memcmp? The hunks

Re: [Qemu-devel] [PATCH v6 10/12] s390-ccw: read user input for boot index via the SCLP console

2018-02-16 Thread Collin L. Walling
On 02/16/2018 10:03 AM, David Hildenbrand wrote: On 15.02.2018 23:54, Collin L. Walling wrote: [...] + static int get_boot_index(int entries) { -return 0; /* Implemented next patch */ +int boot_index; +bool retry = false; +char tmp[5]; + +do { +boot_menu_prompt

Re: [Qemu-devel] [qemu-s390x] [PATCH v6 01/12] s390-ccw: refactor boot map table code

2018-02-16 Thread Collin L. Walling
On 02/16/2018 07:19 AM, Viktor Mihajlovski wrote: On 16.02.2018 11:42, Thomas Huth wrote: On 15.02.2018 23:54, Collin L. Walling wrote: Some ECKD bootmap code was using structs designed for SCSI. Even though this works, it confuses readability. Add a new BootMapTable struct to assist with

[Qemu-devel] [PATCH v6 11/12] s390-ccw: set cp_receive mask only when needed and consume pending service irqs

2018-02-15 Thread Collin L. Walling
al measure, once we've disabled/cleared the control program's receive mask, we will print an empty string in order to consume any pending service interrupt. Signed-off-by: Collin L. Walling --- pc-bios/s390-ccw/menu.c | 5 + pc-bios/s390-ccw/s390-ccw.h | 1 + pc-bios/s390

[Qemu-devel] [PATCH v6 08/12] s390-ccw: read stage2 boot loader data to find menu

2018-02-15 Thread Collin L. Walling
ned-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/bootmap.c | 94 +++--- pc-bios/s390-ccw/bootmap.h | 23 +++- pc-bios/s390-ccw/menu.c| 5 +++ pc-bios/s390-ccw/menu.h| 1 + 4 files changed, 116 insertions(+), 7 deletion

[Qemu-devel] [PATCH v6 02/12] s390-ccw: refactor eckd_block_num to use CHS

2018-02-15 Thread Collin L. Walling
Add new cylinder/head/sector struct. Use it to calculate eckd block numbers instead of a BootMapPointer (which used eckd chs anyway). Signed-off-by: Collin L. Walling --- pc-bios/s390-ccw/bootmap.c | 28 ++-- pc-bios/s390-ccw/bootmap.h | 8 ++-- 2 files changed, 20

[Qemu-devel] [PATCH v6 12/12] s390-ccw: interactive boot menu for scsi

2018-02-15 Thread Collin L. Walling
Interactive boot menu for scsi. This follows a similar procedure as the interactive menu for eckd dasd. An example follows: s390x Enumerated Boot Menu. 3 entries detected. Select from index 0 to 2. Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw

[Qemu-devel] [PATCH v6 00/12] Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-15 Thread Collin L. Walling
e IPL'd from A loadparm other than 'prompt' will disable the menu and just boot the specified entry. If no boot options are specified, we will attempt to use the values provided by zipl (ECKD DASD only). Collin L. Walling (12): s390-ccw: refactor boot map table code s390-ccw:

[Qemu-devel] [PATCH v6 06/12] s390-ccw: parse and set boot menu options

2018-02-15 Thread Collin L. Walling
for loadparm will override all boot menu options. If loadparm=PROMPT, then the menu will be enabled without a timeout. The absence of any boot options on the command line will flag to later use the zipl boot loader values. Signed-off-by: Collin L. Walling Reviewed-by: Janosch Frank Reviewed-by

[Qemu-devel] [PATCH v6 07/12] s390-ccw: set up interactive boot menu parameters

2018-02-15 Thread Collin L. Walling
Reads boot menu flag and timeout values from the iplb and sets the respective fields for the menu. Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/Makefile | 2 +- pc-bios/s390-ccw/main.c | 24 pc-bios/s390-ccw/menu.c | 26

[Qemu-devel] [PATCH v6 10/12] s390-ccw: read user input for boot index via the SCLP console

2018-02-15 Thread Collin L. Walling
boot entries, then the selection will be booted. Any erroneous input will cancel the timeout and re-prompt the user. Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/menu.c | 146 +++- pc-bios/s390-ccw/s390-ccw.h | 2 + pc

[Qemu-devel] [PATCH v6 09/12] s390-ccw: print zipl boot menu

2018-02-15 Thread Collin L. Walling
fault (linux-4.13.0) 1. linux-4.13.0 2. performance 3. kvm Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/menu.c | 49 - 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/pc-bios/s390-ccw/menu.c b/pc

[Qemu-devel] [PATCH v6 03/12] s390-ccw: refactor IPL structs

2018-02-15 Thread Collin L. Walling
ECKD DASDs have different IPL structures for CDL and LDL formats. The current Ipl1 and Ipl2 structs follow the CDL format, so we prepend "EckdCdl" to them. Boot info for LDL has been moved to a new struct: EckdLdlIpl1. Signed-off-by: Collin L. Walling Acked-by: Janosch Frank Reviewed-

[Qemu-devel] [PATCH v6 05/12] s390-ccw: move auxiliary IPL data to separate location

2018-02-15 Thread Collin L. Walling
The s390-ccw firmware needs some information in support of the boot process which is not available on the native machine. Examples are the netboot firmware load address and now the boot menu parameters. While storing that data in unused fields of the IPL parameter block works, that approach could

[Qemu-devel] [PATCH v6 01/12] s390-ccw: refactor boot map table code

2018-02-15 Thread Collin L. Walling
BootMapTable - fixup ipl_scsi to use BootMapTable (referred to as Program Table) - defined value for maximum table entries Signed-off-by: Collin L. Walling --- pc-bios/s390-ccw/bootmap.c | 60 +- pc-bios/s390-ccw/bootmap.h | 14 +-- 2 files changed, 39

[Qemu-devel] [PATCH v6 04/12] s390-ccw: update libc

2018-02-15 Thread Collin L. Walling
Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) Added C standard functions: isdigit Added non C-standard function: uitoa atoui Signed-off-by: Collin L. Walling Acked-by: Christian Borntraeger Reviewed-by: Janosch

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 11/12] s390-ccw: clear pending irqs

2018-02-15 Thread Collin L. Walling
On 02/15/2018 02:04 AM, Thomas Huth wrote: On 14.02.2018 16:33, Collin L. Walling wrote: On 02/14/2018 05:57 AM, David Hildenbrand wrote: [...] 1. CKC interrupts can be cleared by resetting the CKC 2. SCLP interrupts can be cleared only via delivery (apart from CPU reset) So if you have CKC

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 06/12] s390-ccw: parse and set boot menu options

2018-02-14 Thread Collin L. Walling
documenting in qemu-options.hx that s390 treats "splash-time" as the menu-timeout. Thoughts? On 02/05/2018 03:57 PM, Collin L. Walling wrote: Set boot menu options for an s390 guest and store them in the iplb. These options are set via the QEMU command line option: -boot menu=on|o

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 11/12] s390-ccw: clear pending irqs

2018-02-14 Thread Collin L. Walling
On 02/14/2018 05:57 AM, David Hildenbrand wrote: On 05.02.2018 21:57, Collin L. Walling wrote: It is possible while waiting for multiple types of external interrupts that we might have pending irqs remaining between irq consumption and irq disabling. Those interrupts could propagate to the

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 05/12] s390-ccw: move auxiliary IPL data to separate location

2018-02-14 Thread Collin L. Walling
On 02/06/2018 05:13 AM, Viktor Mihajlovski wrote: On 06.02.2018 10:23, Thomas Huth wrote: On 05.02.2018 21:57, Collin L. Walling wrote: [...] diff --git a/pc-bios/s390-ccw/main.c b/pc-bios/s390-ccw/main.c index e857ce4..825a1a3 100644 --- a/pc-bios/s390-ccw/main.c +++ b/pc-bios/s390-ccw/main.c

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 04/12] s390-ccw: update libc

2018-02-06 Thread Collin L. Walling
On 02/06/2018 01:14 AM, Thomas Huth wrote: On 05.02.2018 21:57, Collin L. Walling wrote: Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) Added C standard functions: isdigit Added non C-standard function: itostr

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 05/12] s390-ccw: move auxiliary IPL data to separate location

2018-02-06 Thread Collin L. Walling
On 02/06/2018 05:13 AM, Viktor Mihajlovski wrote: On 06.02.2018 10:23, Thomas Huth wrote: On 05.02.2018 21:57, Collin L. Walling wrote: [...] diff --git a/hw/s390x/ipl.c b/hw/s390x/ipl.c index 0d06fc1..3e3c3b8 100644 --- a/hw/s390x/ipl.c +++ b/hw/s390x/ipl.c @@ -399,6 +399,20 @@ void

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 01/12] s390-ccw: refactor boot map table code

2018-02-06 Thread Collin L. Walling
On 02/06/2018 12:52 AM, Thomas Huth wrote: On 05.02.2018 21:57, Collin L. Walling wrote: - replace ScsiMbr in ECKD code with BootMapTable - fix read_block messages to reflect BMT - reduce ipl_scsi code with BMT struct Signed-off-by: Collin L. Walling --- [...] @@ -449,10 +451,8 @@ static

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 11/12] s390-ccw: clear pending irqs

2018-02-06 Thread Collin L. Walling
On 02/06/2018 05:07 AM, Thomas Huth wrote: On 05.02.2018 21:57, Collin L. Walling wrote: It is possible while waiting for multiple types of external interrupts that we might have pending irqs remaining between irq consumption and irq disabling. Those interrupts could propagate to the guest

Re: [Qemu-devel] [qemu-s390x] [PATCH v5 00/12]Interactive Boot Menu for DASD and SCSI Guests on s390x

2018-02-05 Thread Collin L. Walling
: error: comparison of unsigned expression >= 0 is always true [-Werror=type-limits] IPL_assert(num >= 0, "itostr: cannot convert negative values"); ^~ -- - Collin L Walling

[Qemu-devel] [PATCH v5 12/12] s390-ccw: interactive boot menu for scsi

2018-02-05 Thread Collin L. Walling
Interactive boot menu for scsi. This follows a similar procedure as the interactive menu for eckd dasd. An example follows: s390x Enumerated Boot Menu. 3 entries detected. Select from index 0 to 2. Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw

[Qemu-devel] [PATCH v5 10/12] s390-ccw: read user input for boot index via the SCLP console

2018-02-05 Thread Collin L. Walling
boot entries, then the selection will be booted. Any erroneous input will cancel the timeout and re-prompt the user. Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/menu.c | 150 +++- pc-bios/s390-ccw/s390-ccw.h | 3 + pc

[Qemu-devel] [PATCH v5 08/12] s390-ccw: read stage2 boot loader data to find menu

2018-02-05 Thread Collin L. Walling
ned-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/bootmap.c | 94 +++--- pc-bios/s390-ccw/bootmap.h | 23 +++- pc-bios/s390-ccw/menu.c| 5 +++ pc-bios/s390-ccw/menu.h| 1 + 4 files changed, 116 insertions(+), 7 deletion

[Qemu-devel] [PATCH v5 11/12] s390-ccw: clear pending irqs

2018-02-05 Thread Collin L. Walling
to prevent further service interrupts from ASCII events and then consume all pending irqs for a miniscule duration. Once finished, we reset the write event mask and resume business as usual. Signed-off-by: Collin L. Walling --- pc-bios/s390-ccw/menu.c | 16 pc-bios/s390-ccw/sclp.c

[Qemu-devel] [PATCH v5 01/12] s390-ccw: refactor boot map table code

2018-02-05 Thread Collin L. Walling
- replace ScsiMbr in ECKD code with BootMapTable - fix read_block messages to reflect BMT - reduce ipl_scsi code with BMT struct Signed-off-by: Collin L. Walling --- pc-bios/s390-ccw/bootmap.c | 53 ++ pc-bios/s390-ccw/bootmap.h | 9 +++- 2 files

[Qemu-devel] [PATCH v5 04/12] s390-ccw: update libc

2018-02-05 Thread Collin L. Walling
Moved: memcmp from bootmap.h to libc.h (renamed from _memcmp) strlen from sclp.c to libc.h (renamed from _strlen) Added C standard functions: isdigit Added non C-standard function: itostr atoui Signed-off-by: Collin L. Walling Acked-by: Christian Borntraeger Reviewed-by: Janosch

[Qemu-devel] [PATCH v5 07/12] s390-ccw: set up interactive boot menu parameters

2018-02-05 Thread Collin L. Walling
Reads boot menu flag and timeout values from the iplb and sets the respective fields for the menu. Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/Makefile | 2 +- pc-bios/s390-ccw/main.c | 24 pc-bios/s390-ccw/menu.c | 26

[Qemu-devel] [PATCH v5 09/12] s390-ccw: print zipl boot menu

2018-02-05 Thread Collin L. Walling
fault (linux-4.13.0) 1. linux-4.13.0 2. performance 3. kvm Signed-off-by: Collin L. Walling Reviewed-by: Thomas Huth --- pc-bios/s390-ccw/menu.c | 49 - 1 file changed, 48 insertions(+), 1 deletion(-) diff --git a/pc-bios/s390-ccw/menu.c b/pc

[Qemu-devel] [PATCH v5 02/12] s390-ccw: refactor eckd_block_num to use CHS

2018-02-05 Thread Collin L. Walling
Add new cylinder/head/sector struct. Use it to calculate eckd block numbers instead of a BootMapPointer (which used eckd chs anyway). Signed-off-by: Collin L. Walling --- pc-bios/s390-ccw/bootmap.c | 28 ++-- pc-bios/s390-ccw/bootmap.h | 8 ++-- 2 files changed, 20

[Qemu-devel] [PATCH v5 06/12] s390-ccw: parse and set boot menu options

2018-02-05 Thread Collin L. Walling
for loadparm will override all boot menu options. If loadparm=PROMPT, then the menu will be enabled without a timeout. The absence of any boot options on the command line will flag to later use the zipl boot loader values. Signed-off-by: Collin L. Walling Reviewed-by: Janosch Frank Reviewed-by

[Qemu-devel] [PATCH v5 03/12] s390-ccw: refactor IPL structs

2018-02-05 Thread Collin L. Walling
ECKD DASDs have different IPL structures for CDL and LDL formats. The current Ipl1 and Ipl2 structs follow the CDL format, so we prepend "EckdCdl" to them. Boot info for LDL has been moved to a new struct: EckdLdlIpl1. Signed-off-by: Collin L. Walling Acked-by: Janosch Frank Reviewed-

[Qemu-devel] [PATCH v5 05/12] s390-ccw: move auxiliary IPL data to separate location

2018-02-05 Thread Collin L. Walling
The s390-ccw firmware needs some information in support of the boot process which is not available on the native machine. Examples are the netboot firmware load address and now the boot menu parameters. While storing that data in unused fields of the IPL parameter block works, that approach could

  1   2   >