Re: [PATCH 1/2] i386/cpu: Rename host_cpu_instance_init() to apply_host_vendor()

2025-07-01 Thread Claudio Fontana
Hello Xiaoyao, I did not find a better name at the time. The meaning of 'host' there has nothing to do with the cpu type called "host", but rather identifies common code between kvm and hvf, which both use the host cpuid(), See accel_uses_host_cpuid(), host_cpuid(), host_cpu_vendor_fms(). Maybe

hints for debugging vdagent issues

2025-03-26 Thread Claudio Fontana
line, and that gets me to: 2972153@1743002351.233130:vdagent_open 2972192@1743002362.649762:vdagent_close 2972192@1743002362.649771:vdagent_disconnect Apparently the vdagent connection is closed after 11 seconds, but I have no idea why.. Thanks for any suggestions, Claudio -- Claudio Fontana Engineering Manager Virtualization, SUSE Labs Core SUSE Software Solutions Italy Srl

Re: [PATCH] target/ppc: Fix lxvx/stxvx facility check

2024-09-19 Thread Claudio Fontana
ping, adding Richard. We will need to include this downstream because of the breakage its lack causes. It is already reviewed by me, but some TCG maintainer indicating it will be included in some queue would help, Thanks, Claudio On 9/18/24 17:11, Claudio Fontana wrote: > Adding Ilya

Re: [PATCH] target/ppc: Fix lxvx/stxvx facility check

2024-09-18 Thread Claudio Fontana
Adding Ilya FYI. Ciao, Claudio On 9/11/24 18:19, Claudio Fontana wrote: > On 9/11/24 16:16, Fabiano Rosas wrote: >> The XT check for the lxvx/stxvx instructions is currently >> inverted. This was introduced during the move to decodetree. >> >> From the ISA: &g

Re: [PATCH] Remove unnecessary code in the interface accel_system_init_ops_interfaces

2024-09-11 Thread Claudio Fontana
On 9/9/24 12:07, Claudio Fontana wrote: > On 9/9/24 11:54, Daniel Henrique Barboza wrote: >> >> >> On 9/9/24 12:17 AM, Andrew.Yuan wrote: >>> The code 'ops = ACCEL_OPS_CLASS(module_object_class_by_name(ops_name));' is >>> unnecessary; >

Re: [PATCH] target/ppc: Fix lxvx/stxvx facility check

2024-09-11 Thread Claudio Fontana
tx, arg_X *a, bool store, bool paired) > { > - if (paired || a->rt >= 32) { > +if (paired || a->rt < 32) { > REQUIRE_VSX(ctx); > } else { > REQUIRE_VECTOR(ctx); Reviewed-by: Claudio Fontana

Re: [PATCH] Remove unnecessary code in the interface accel_system_init_ops_interfaces

2024-09-09 Thread Claudio Fontana
On 9/9/24 11:54, Daniel Henrique Barboza wrote: > > > On 9/9/24 12:17 AM, Andrew.Yuan wrote: >> The code 'ops = ACCEL_OPS_CLASS(module_object_class_by_name(ops_name));' is >> unnecessary; >> >> And, the following code : >> 1.has the same functionality; >> 2.includes error checking; >> >> Signed-

Re: [PATCH v2 1/1] module: Move local_err initialization to the loop in module_load_qom_all()

2024-08-12 Thread Claudio Fontana
Reviewed-by: Claudio Fontana On 8/12/24 10:57, Alexander Ivanov wrote: > Move local_err initialization inside the loop in the module_load_qom_all() > function. This change ensures that the error variable is reset to NULL for > each iteration of the loop. This prevents triggering ass

Re: [PATCH 1/1] module: Prevent crash by resetting local_err in module_load_qom_all()

2024-08-09 Thread Claudio Fontana
(module_load("", modinfo->name, &local_err) < 0) { > error_report_err(local_err); > +local_err = NULL; > } > } > module_loaded_qom_all = true; Reviewed-by: Claudio Fontana

Re: [PATCH v3 2/2] kvm: refactor core virtual machine creation into its own function

2024-08-09 Thread Claudio Fontana
gltm, thanks! Reviewed-by: Claudio Fontana On 8/9/24 07:10, Ani Sinha wrote: > Refactoring the core logic around KVM_CREATE_VM into its own separate function > so that it can be called from other functions in subsequent patches. There is > no functional change in this patch. >

Re: [PATCH v2] kvm: refactor core virtual machine creation into its own function

2024-08-08 Thread Claudio Fontana
Hello, as a suggestion you could adjust the names of the functions to match the existing pattern in this module. It is modulename_method ie kvm_* , so: On 8/8/24 13:38, Ani Sinha wrote: > Refactoring the core logic around KVM_CREATE_VM into its own separate function > so that it can be called f

Re: assert fails in s390x TCG

2024-06-12 Thread Claudio Fontana
a partial match ... Add a check for this. While at it, fold a number of explicitly handled special cases into the generic logic. Cc: qemu-sta...@nongnu.org Reported-by: Claudio Fontana Closes: https://lists.gnu.org/archive/html/qemu-devel/2023-08/msg00633.htm

Re: [PATCH v2] qemu-options: Deprecate "-runas" and introduce "-run-with user=..." instead

2024-05-08 Thread Claudio Fontana
On 5/6/24 13:20, Thomas Huth wrote: > The old "-runas" option has the disadvantage that it is not visible > in the QAPI schema, so it is not available via the normal introspection > mechanisms. We've recently introduced the "-run-with" option for exactly > this purpose, which is meant to handle the

Re: [PATCH-for-9.1 00/27] accel/tcg: Introduce TCGCPUOps::get_cpu_state() handler

2024-03-19 Thread Claudio Fontana
Thanks Philippe, I fear I am unable to really be uptodate, but it's great to see all the cleanup you and others have done! Ciao, Claudio On 3/19/24 16:48, Philippe Mathieu-Daudé wrote: > (Forgot to Cc Claudio to keep him updated) > > On 19/3/24 16:42, Philippe Mathieu-Daudé wrote: >> Hi, >> >>

qemu-img: very bad performance with the default number of coroutines (8) in presence of compression. Fixed adding "-m 1" to the cmdline.

2024-03-18 Thread Claudio Fontana
Hello, pretty much the $Subject. We had reports of very bad performance with the default options when running: $ time qemu-img convert -c -p -O qcow2 file.qcow2 file.disk real7m13.220s user6m56.682s sys 0m13.038s I studied this and noticed that for every coroutine a thread was creat

Re: [PATCH v2] target/s390x: improve cpu compatibility check error message

2024-03-15 Thread Claudio Fontana
On 3/15/24 17:59, Nina Schoetterl-Glausch wrote: > On Thu, 2024-03-14 at 22:37 +0100, Claudio Fontana wrote: >> some users were confused by this message showing under TCG: >> >> Selected CPU generation is too new. Maximum supported model >> in the configuration: &

[PATCH v2] target/s390x: improve cpu compatibility check error message

2024-03-14 Thread Claudio Fontana
est trying different accel, QEMU and kernel versions. Signed-off-by: Claudio Fontana --- target/s390x/cpu_models.c | 22 +++--- 1 file changed, 15 insertions(+), 7 deletions(-) diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c index 1a1c096122..8ed3bb6a27 100644 --

Re: [PATCH] target/s390x: improve cpu compatibility check error message

2024-03-14 Thread Claudio Fontana
On 3/14/24 21:10, Claudio Fontana wrote: > On 3/14/24 20:44, Nina Schoetterl-Glausch wrote: >> On Thu, 2024-03-14 at 20:00 +0100, Claudio Fontana wrote: >>> some users were confused by this message showing under TCG: >>> >>> Selected CPU generation is too new

Re: [PATCH] target/s390x: improve cpu compatibility check error message

2024-03-14 Thread Claudio Fontana
On 3/14/24 20:44, Nina Schoetterl-Glausch wrote: > On Thu, 2024-03-14 at 20:00 +0100, Claudio Fontana wrote: >> some users were confused by this message showing under TCG: >> >> Selected CPU generation is too new. Maximum supported model >> in the configuration: 'xy

[PATCH] target/s390x: improve cpu compatibility check error message

2024-03-14 Thread Claudio Fontana
eration is too new. Maximum supported model in the accelerator 'tcg' configuration: 'xyz' Signed-off-by: Claudio Fontana --- target/s390x/cpu_models.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/target/s390x/cpu_models.c b/target/s390x

Re: question on s390x topology: KVM only, or also TCG?

2024-03-14 Thread Claudio Fontana
On 3/14/24 17:44, Nina Schoetterl-Glausch wrote: > On Thu, 2024-03-14 at 16:54 +0100, Thomas Huth wrote: >> On 14/03/2024 16.49, Claudio Fontana wrote: >>> Hello Pierre, Ilya, >>> >>> I have a question on the s390x "topology" feature and examples. >

[PATCH] docs/s390: clarify even more that cpu-topology is KVM-only

2024-03-14 Thread Claudio Fontana
-by: Claudio Fontana --- docs/system/introduction.rst | 2 ++ docs/system/s390x/cpu-topology.rst | 14 -- 2 files changed, 10 insertions(+), 6 deletions(-) diff --git a/docs/system/introduction.rst b/docs/system/introduction.rst index 51ac132d6c..746707eb00 100644 --- a/docs

question on s390x topology: KVM only, or also TCG?

2024-03-14 Thread Claudio Fontana
0,core-id=14 \ \ -device gen16b-s390x-cpu,core-id=4,dedicated=on,entitlement=high " We received questions about this, so I hope you can shed some light, maybe it would be good to just update the web page to include -accel kvm or -enable-kvm everywhere for clarity? Thanks for your hel

Re: [PATCH v4 00/34] migration: File based migration with multifd and fixed-ram

2024-02-23 Thread Claudio Fontana
On 2/23/24 03:59, Peter Xu wrote: > On Tue, Feb 20, 2024 at 07:41:04PM -0300, Fabiano Rosas wrote: >> Latest numbers >> == >> >> => guest: 128 GB RAM - 120 GB dirty - 1 vcpu in tight loop dirtying memory >> => host: 128 CPU AMD EPYC 7543 - 2 NVMe disks in RAID0 (8586 MiB/s) - xfs >> =>

Re: [GIT PULL 5/8] util: Add write-only "node-affinity" property for ThreadContext

2024-02-05 Thread Claudio Fontana
wrote: > On 05.02.24 11:14, Claudio Fontana wrote: >> Hi, > > Hi Claudio, > >> >> turning pages back in time, >> >> noticed that in recent qemu-img binaries we include an ELF dependency on >> libnuma.so that seems unused. >&

Re: [GIT PULL 5/8] util: Add write-only "node-affinity" property for ThreadContext

2024-02-05 Thread Claudio Fontana
Hi, turning pages back in time, noticed that in recent qemu-img binaries we include an ELF dependency on libnuma.so that seems unused. I think it stems from this commit: commit 10218ae6d006f76410804cc4dc690085b3d008b5 Author: David Hildenbrand Date: Fri Oct 14 15:47:17 2022 +0200 util:

Re: [PATCH v3 03/70] RAMBlock/guest_memfd: Enable KVM_GUEST_MEMFD_ALLOW_HUGEPAGE

2023-12-01 Thread Claudio Fontana
On 11/30/23 18:51, Daniel P. Berrangé wrote: > On Thu, Nov 30, 2023 at 05:54:26PM +0100, David Hildenbrand wrote: >> On 30.11.23 17:01, Sean Christopherson wrote: >>> On Thu, Nov 30, 2023, David Hildenbrand wrote: On 30.11.23 08:32, Xiaoyao Li wrote: > On 11/20/2023 5:26 PM, David Hildenbr

Re: [PATCH] accel: Do not set CPUState::can_do_io in non-TCG accels

2023-11-30 Thread Claudio Fontana
On 11/30/23 14:31, Philippe Mathieu-Daudé wrote: > Hi Claudio, > > On 30/11/23 13:48, Claudio Fontana wrote: >> Hi Philippe, >> >> took a quick look with >> >> grep -R can_do_io >> >> and this seems to be in include/hw/core/cpu.h as well as cpu-

Re: [PATCH] accel: Do not set CPUState::can_do_io in non-TCG accels

2023-11-30 Thread Claudio Fontana
Hi Philippe, took a quick look with grep -R can_do_io and this seems to be in include/hw/core/cpu.h as well as cpu-common.c, maybe there is more meat to address to fully solve this? Before we had stuff for reset in cpu-common.c under a if (tcg_enabled()) { } but now we have cpu_exec_reset_ho

Re: [PATCH for-8.2] accel/tcg: Remove CF_LAST_IO

2023-11-14 Thread Claudio Fontana
Reviewed-by: Claudio Fontana On 11/10/23 18:08, Richard Henderson wrote: > In cpu_exec_step_atomic, we did not set CF_LAST_IO, which can > lead to a loop with cpu_io_recompile. > > But since 18a536f1f8 ("Always require can_do_io") we no longer need > a flag to indicate

Re: [SeaBIOS] [PATCH v5] limit physical address space size

2023-11-10 Thread Claudio Fontana
#x27;t handle a very high > PCI space, then a workaround in the PCI code might make it more clear > what is occurring.) > > Cheers, > -Kevin > > >> >> Cc: Claudio Fontana >> Signed-off-by: Gerd Hoffmann Hi, I thought about this, and I am not sure it&#

Re: [PULL 4/6] seabios: update binaries to git snapshot

2023-11-07 Thread Claudio Fontana
On 11/7/23 12:49, Gerd Hoffmann wrote: >> Hi, thanks for the response, >> >> just to be sure, this is a regression (it worked fine prior to the seabios >> update). > > Yes. > >> Address sizes: 43 bits physical, 48 bits virtual > > OK. > >> [0.881472] pci :00:01.0:

Re: [PULL 4/6] seabios: update binaries to git snapshot

2023-11-07 Thread Claudio Fontana
On 11/7/23 11:35, Gerd Hoffmann wrote: > Hi, > >> Trying to install a simple centos7 iso for testing as in: >> >> IMAGESDIR=/images >> ISO=${IMAGESDIR}/CentOS-7-x86_64-Minimal-2009.iso > > Oh, you are running a software museum ;) > >> ===

Re: Wshadow: Better name for 'optarg'?

2023-10-05 Thread Claudio Fontana
On 10/4/23 12:05, Philippe Mathieu-Daudé wrote: > Hi, > > I'm getting a bunch of errors for 'optarg' declared in : > > NAME > getopt – get option character from command line argument list > > LIBRARY > Standard C Library (libc, -lc) > > SYNOPSIS > #include > > extern c

Re: [PATCH 00/13] misc: Rename 'softmmu' -> 'system'

2023-10-04 Thread Claudio Fontana
On 10/4/23 14:37, Thomas Huth wrote: > On 04/10/2023 14.33, Daniel P. Berrangé wrote: >> On Wed, Oct 04, 2023 at 11:06:15AM +0200, Philippe Mathieu-Daudé wrote: >>> This series finishes the cleanup which remove the confusion >>> of using 'softmmu' when we really mean 'system emulation', >>> as oppo

Re: [PATCH 0/5] accel: Restrict tcg_exec_[un]realizefn() to TCG

2023-10-03 Thread Claudio Fontana
On 10/3/23 16:04, Richard Henderson wrote: > On 10/2/23 23:44, Philippe Mathieu-Daudé wrote: >> On 15/9/23 21:00, Philippe Mathieu-Daudé wrote: >>> - Add missing accel_cpu_unrealize() >>> - Add AccelClass::[un]realize_cpu handlers >>> - Use tcg_exec_[un]realizefn as AccelClass handlers >>> >>> Phil

Re: [PATCH v2 0/7] accel: Restrict tcg_exec_[un]realizefn() to TCG

2023-10-03 Thread Claudio Fontana
Nice. I build-tested and make checked this as well, Reviewed-by: Claudio Fontana Tested-by: Claudio Fontana On 10/3/23 14:30, Philippe Mathieu-Daudé wrote: > Since v1: > - Use 'target'/'common' in function names (Claudio) > - Added Claudio R-b tags

Re: [PATCH 5/5] accel/tcg: Restrict tcg_exec_[un]realizefn() to TCG

2023-10-03 Thread Claudio Fontana
-Daudé Reviewed-by: Claudio Fontana > --- > accel/tcg/internal.h | 3 +++ > include/exec/cpu-all.h | 2 -- > accel/tcg/tcg-all.c| 2 ++ > cpu.c | 8 > 4 files changed, 5 insertions(+), 10 deletions(-) > > diff --git a/accel/tcg/internal

Re: [PATCH 4/5] accel/tcg: Have tcg_exec_realizefn() return a boolean

2023-10-03 Thread Claudio Fontana
thieu-Daudé Reviewed-by: Claudio Fontana > --- > include/exec/cpu-all.h | 2 +- > accel/tcg/cpu-exec.c | 4 +++- > 2 files changed, 4 insertions(+), 2 deletions(-) > > diff --git a/include/exec/cpu-all.h b/include/exec/cpu-all.h > index c2c62160c6..1e5c530ee1 100644 >

Re: [PATCH 3/5] accel: Declare AccelClass::[un]realize_cpu() handlers

2023-10-03 Thread Claudio Fontana
On 9/15/23 21:00, Philippe Mathieu-Daudé wrote: > Currently accel_cpu_realize() only performs target-specific > realization. Introduce the [un]realize_cpu fields in the > base AccelClass to be able to perform target-agnostic > [un]realization of vCPUs. > > Signed-off-by: Philippe Mathieu-Daudé J

Re: [PATCH 1/5] accel: Rename accel_cpu_realizefn() -> accel_cpu_realize()

2023-10-03 Thread Claudio Fontana
Reviewed-by: Claudio Fontana On 9/15/23 21:00, Philippe Mathieu-Daudé wrote: > We use the '*fn' suffix for handlers, this is a public method. > Drop the suffix. > > Signed-off-by: Philippe Mathieu-Daudé > --- > include/qemu/accel.h | 4 ++-- > accel/acce

migration maintenance, governance [Was: Re: [PATCH V4 0/2] migration file URI]

2023-09-27 Thread Claudio Fontana
On 9/13/23 15:00, Claudio Fontana wrote: > On 8/30/23 15:09, Claudio Fontana wrote: >> On 8/22/23 15:25, Philippe Mathieu-Daudé wrote: >>> Hi Claudio, >>> >>> On 22/8/23 14:00, Claudio Fontana wrote: >>>> Hello, >>>> >>>> th

Re: [PATCH V5 0/2] migration file URI

2023-09-13 Thread Claudio Fontana
Hi, this is the first step towards faster migration to disk that we care about the most, can it be merged? Thanks, Claudio On 9/8/23 16:22, Steve Sistare wrote: > Add the migration URI "file:filename[,offset=offset]". > > Fabiano Rosas has submitted the unit tests in the series > migration:

Re: [PATCH V4 0/2] migration file URI

2023-09-13 Thread Claudio Fontana
On 8/30/23 15:09, Claudio Fontana wrote: > On 8/22/23 15:25, Philippe Mathieu-Daudé wrote: >> Hi Claudio, >> >> On 22/8/23 14:00, Claudio Fontana wrote: >>> Hello, >>> >>> this series is all reviewed, >>> >>> and is needed a

Re: [PATCH] arm64: Restore trapless ptimer access

2023-09-04 Thread Claudio Fontana
On 9/4/23 13:07, Andrew Jones wrote: > On Mon, Sep 04, 2023 at 10:18:05AM +0200, Claudio Fontana wrote: >> Hi, >> >> I think this discussion from ~2015 could potentially be be historically >> relevant for context, >> at the time we had the problem with CNTV

Re: [PATCH] arm64: Restore trapless ptimer access

2023-09-04 Thread Claudio Fontana
Hi, I think this discussion from ~2015 could potentially be be historically relevant for context, at the time we had the problem with CNTVOFF IIRC so KVM_REG_ARM_TIMER_CNT being read and rewritten causing time warps in the guest: https://patchwork.kernel.org/project/linux-arm-kernel/patch/14351

Re: [PATCH V4 0/2] migration file URI

2023-08-30 Thread Claudio Fontana
On 8/22/23 15:25, Philippe Mathieu-Daudé wrote: > Hi Claudio, > > On 22/8/23 14:00, Claudio Fontana wrote: >> Hello, >> >> this series is all reviewed, >> >> and is needed as a precondition for further work to improve dramatically the >> performance o

Re: [PATCH v2 0/4] migration/ram: Merge zero page handling

2023-08-22 Thread Claudio Fontana
Hello, this series is all reviewed, and is needed as a precondition for further work to improve dramatically the performance of virsh save, virsh restore when migrating to disk, can it be merged? Thanks, Claudio On 8/16/23 20:28, Fabiano Rosas wrote: > For v2 I fixed patch 3 which had a hunk

Re: [PATCH v2 4/4] migration/ram: Merge save_zero_page functions

2023-08-22 Thread Claudio Fontana
Apologies, already reviewed, will ping for the merge of the series momentarily, Claudio On 8/22/23 14:18, Claudio Fontana wrote: > Hello, > > this patch would still need a review, > > and is needed as a precondition for further work to improve dramatically the > perform

Re: [PATCH v2 4/4] migration/ram: Merge save_zero_page functions

2023-08-22 Thread Claudio Fontana
Hello, this patch would still need a review, and is needed as a precondition for further work to improve dramatically the performance of virsh save, virsh restore when migrating to disk, since Peter Xu already reviewed PATCH 1, 2, 3, maybe it makes sense to look at 4 too? Thanks, Claudio On

Re: [PATCH] migration/ram: Refactor precopy ram loading code

2023-08-22 Thread Claudio Fontana
Hello, this patch is reviewed, and is needed as a precondition for further work to improve dramatically the performance of virsh save, virsh restore when migrating to disk, can it be merged? Thanks, Claudio On 7/25/23 15:26, Fabiano Rosas wrote: > From: Nikolay Borisov > > Extract the rambl

Re: [PATCH v5 0/6] migration: Test the new "file:" migration

2023-08-22 Thread Claudio Fontana
Hello, this series is all reviewed, and is needed as a precondition for further work to improve dramatically the performance of virsh save, virsh restore when migrating to disk, can it be merged? Thanks, Claudio On 7/12/23 21:07, Fabiano Rosas wrote: > Based-on: > [PATCH V4 0/2] migration fil

Re: [PATCH V4 0/2] migration file URI

2023-08-22 Thread Claudio Fontana
Hello, this series is all reviewed, and is needed as a precondition for further work to improve dramatically the performance of virsh save, virsh restore when migrating to disk, can it be merged? Thanks, Claudio On 6/30/23 16:25, Steve Sistare wrote: > Add the migration URI "file:filename[,of

Re: [PATCH v2 00/10] block: Make raw_co_get_allocated_file_size asynchronous

2023-08-22 Thread Claudio Fontana
Hi all, we currently have to maintain something downstream for this, since the current behavior can compound problems on top of existing bad NFS latency, could someone continue to help reviewing this work? Thanks, Claudio On 6/9/23 22:19, Fabiano Rosas wrote: > Hi, > > The major change from

Re: [PATCH 3/3] tests/tcg/s390x: Test VSTRS

2023-08-17 Thread Claudio Fontana
On 8/5/23 01:03, Ilya Leoshkevich wrote: > Add a small test to prevent regressions. > > Signed-off-by: Ilya Leoshkevich Something seems off in the wiring of the make check target? I built with: ./configure --target-list=s390x-linux-user,s390x-softmmu make -j make -j check-help ... Individua

Re: [PATCH 1/3] linux-user/elfload: Enable vxe2 on s390x

2023-08-17 Thread Claudio Fontana
_VECTOR, HWCAP_S390_VXRS); > GET_FEATURE(S390_FEAT_VECTOR_ENH, HWCAP_S390_VXRS_EXT); > +GET_FEATURE(S390_FEAT_VECTOR_ENH2, HWCAP_S390_VXRS_EXT2); > > return hwcap; > } Reviewed-by: Claudio Fontana

Re: [PATCH] block-migration: Ensure we don't crash during migration cleanup

2023-08-09 Thread Claudio Fontana
On 8/8/23 19:08, Stefan Hajnoczi wrote: > On Mon, Jul 31, 2023 at 05:33:38PM -0300, Fabiano Rosas wrote: >> We can fail the blk_insert_bs() at init_blk_migration(), leaving the >> BlkMigDevState without a dirty_bitmap and BlockDriverState. Account >> for the possibly missing elements when doing cle

Re: [PATCH] block-migration: Ensure we don't crash during migration cleanup

2023-08-08 Thread Claudio Fontana
added Kevin and Hanna for block, since this seems still untouched? Thanks, Claudio On 7/31/23 22:33, Fabiano Rosas wrote: > We can fail the blk_insert_bs() at init_blk_migration(), leaving the > BlkMigDevState without a dirty_bitmap and BlockDriverState. Account > for the possibly missing elemen

Re: [PATCH 3/3] tests/tcg/s390x: Test VSTRS

2023-08-07 Thread Claudio Fontana
On 8/7/23 10:08, Ilya Leoshkevich wrote: > On Sun, 2023-08-06 at 13:05 +0200, Claudio Fontana wrote: >> On 8/5/23 01:03, Ilya Leoshkevich wrote: >>> Add a small test to prevent regressions. >>> >>> Signed-off-by: Ilya Leoshkevich >>> --- >>>

Re: [PATCH 2/3] target/s390x: Fix the "ignored match" case in VSTRS

2023-08-06 Thread Claudio Fontana
re can not be a > partial match ... > > Add a check for this. While at it, fold a number of explicitly handled > special cases into the generic logic. > > Cc: qemu-sta...@nongnu.org > Reported-by: Claudio Fontana > Closes: https://lists.gnu.org/archive/html/qemu-devel/2023

Re: [PATCH 3/3] tests/tcg/s390x: Test VSTRS

2023-08-06 Thread Claudio Fontana
On 8/5/23 01:03, Ilya Leoshkevich wrote: > Add a small test to prevent regressions. > > Signed-off-by: Ilya Leoshkevich > --- > tests/tcg/s390x/Makefile.target | 1 + > tests/tcg/s390x/vxeh2_vstrs.c | 88 + > 2 files changed, 89 insertions(+) > create mode 100

Re: Issue with s390 TCG and libc __strstr_arch13

2023-08-04 Thread Claudio Fontana
On 8/4/23 11:20, Thomas Huth wrote: > On 04/08/2023 11.00, Claudio Fontana wrote: >> Hi, >> >> On 7/21/23 11:08, Claudio Fontana wrote: >>> >>> Hello Cornelia, Richard, >>> >>> I had some strange behavior in an s390x TCG VM that I am de

Issue with s390 TCG and libc __strstr_arch13 [Was: Re: assert fails in s390x TCG]

2023-08-04 Thread Claudio Fontana
Hi, On 7/21/23 11:08, Claudio Fontana wrote: > > Hello Cornelia, Richard, > > I had some strange behavior in an s390x TCG VM that I am debugging, > > and configured latest upstream QEMU with --enable-debug --enable-debug-tcg > > and I am running the qemu binary wi

Re: [RFC PATCH 05/19] kvm: Enable KVM_SET_USER_MEMORY_REGION2 for memslot

2023-08-01 Thread Claudio Fontana
On 7/31/23 18:21, Xiaoyao Li wrote: > From: Chao Peng > > Switch to KVM_SET_USER_MEMORY_REGION2 when supported by KVM. > > With KVM_SET_USER_MEMORY_REGION2, QEMU can set up memory region that > backen'ed both by hva-based shared memory and gmem fd based private > memory. > > Signed-off-by: Chao

Re: [RFC PATCH 04/19] memory: Introduce memory_region_can_be_private()

2023-08-01 Thread Claudio Fontana
On 8/1/23 18:48, Claudio Fontana wrote: > On 7/31/23 18:21, Xiaoyao Li wrote: >> Signed-off-by: Xiaoyao Li >> --- >> include/exec/memory.h | 9 + >> softmmu/memory.c | 5 + >> 2 files changed, 14 insertions(+) >> >> diff --git a/

Re: [RFC PATCH 04/19] memory: Introduce memory_region_can_be_private()

2023-08-01 Thread Claudio Fontana
On 7/31/23 18:21, Xiaoyao Li wrote: > Signed-off-by: Xiaoyao Li > --- > include/exec/memory.h | 9 + > softmmu/memory.c | 5 + > 2 files changed, 14 insertions(+) > > diff --git a/include/exec/memory.h b/include/exec/memory.h > index 61e31c7b9874..e119d3ce1a1d 100644 > --- a/inc

Re: assert fails in s390x TCG

2023-07-31 Thread Claudio Fontana
On 7/31/23 13:31, Claudio Fontana wrote: > On 7/21/23 11:08, Claudio Fontana wrote: >> >> Hello Cornelia, Richard, >> >> I had some strange behavior in an s390x TCG VM that I am debugging, >> >> and configured latest upstream QEMU with --enable-debug --enab

Re: assert fails in s390x TCG

2023-07-31 Thread Claudio Fontana
On 7/21/23 11:08, Claudio Fontana wrote: > > Hello Cornelia, Richard, > > I had some strange behavior in an s390x TCG VM that I am debugging, > > and configured latest upstream QEMU with --enable-debug --enable-debug-tcg > > and I am running the qemu binary with -d uni

Re: [PATCH] target/s390x: Move trans_exc_code update to do_program_interrupt

2023-07-29 Thread Claudio Fontana
e exception has been raised, > we will have unwound the pages locked for translation and the > problem does not arise. There are plenty of other updates to > LowCore while delivering an interrupt/exception; trans_exc_code > does not need to be special. > > Reported-by: Claudio

Re: assert fails in s390x TCG

2023-07-28 Thread Claudio Fontana
On 7/28/23 16:28, Richard Henderson wrote: > On 7/28/23 07:23, Claudio Fontana wrote: >>> It is a test environment for building packages, so the guest at the time of >>> the error is running ./configure for the package swig-v4.1.1.tar.gz >>> >>> checking bui

Re: assert fails in s390x TCG

2023-07-28 Thread Claudio Fontana
On 7/28/23 16:40, Claudio Fontana wrote: > On 7/28/23 16:28, Richard Henderson wrote: >> On 7/28/23 07:23, Claudio Fontana wrote: >>>> It is a test environment for building packages, so the guest at the time >>>> of the error is running ./configure f

Re: assert fails in s390x TCG

2023-07-28 Thread Claudio Fontana
On 7/28/23 15:45, Claudio Fontana wrote: > On 7/28/23 15:33, Richard Henderson wrote: >> On 7/28/23 06:29, Claudio Fontana wrote: >>> On 7/27/23 19:41, Richard Henderson wrote: >>>> On 7/21/23 02:08, Claudio Fontana wrote: >>>>> Thread 3 "

Re: assert fails in s390x TCG

2023-07-28 Thread Claudio Fontana
On 7/27/23 19:41, Richard Henderson wrote: > On 7/21/23 02:08, Claudio Fontana wrote: >> Thread 3 "qemu-system-s39" received signal SIGABRT, Aborted. >> [Switching to Thread 0x753516c0 (LWP 215975)] >> (gdb) bt >> #0 0x7730dabc in __pthread_kill_im

Re: assert fails in s390x TCG

2023-07-28 Thread Claudio Fontana
On 7/28/23 15:33, Richard Henderson wrote: > On 7/28/23 06:29, Claudio Fontana wrote: >> On 7/27/23 19:41, Richard Henderson wrote: >>> On 7/21/23 02:08, Claudio Fontana wrote: >>>> Thread 3 "qemu-system-s39" received signal SIGABRT, Aborted. >>>

Re: assert fails in s390x TCG

2023-07-24 Thread Claudio Fontana
.. adding Alex, maybe something related to multithreaded TCG? On 7/21/23 11:08, Claudio Fontana wrote: > > Hello Cornelia, Richard, > > I had some strange behavior in an s390x TCG VM that I am debugging, > > and configured latest upstream QEMU with --enable-debug --enable-de

assert fails in s390x TCG

2023-07-21 Thread Claudio Fontana
Hello Cornelia, Richard, I had some strange behavior in an s390x TCG VM that I am debugging, and configured latest upstream QEMU with --enable-debug --enable-debug-tcg and I am running the qemu binary with -d unimp,guest_errors . I get: /usr/bin/qemu-system-s390x -nodefaults -no-reboot -nogr

Re: x86 custom apicid assignments [Was: Re: [PATCH v7 0/2] Remove EPYC mode apicid decode and use generic decode]

2023-07-17 Thread Claudio Fontana
On 7/17/23 12:37, Igor Mammedov wrote: > On Mon, 17 Jul 2023 10:32:33 +0200 > Claudio Fontana wrote: > >> Hello Igor, >> >> thanks for getting back to me on this, >> >> On 7/14/23 11:51, Igor Mammedov wrote: >>> On Wed, 5 Jul 2023 10:12:40 +020

Re: x86 custom apicid assignments [Was: Re: [PATCH v7 0/2] Remove EPYC mode apicid decode and use generic decode]

2023-07-17 Thread Claudio Fontana
On 7/17/23 10:32, Claudio Fontana wrote: > Hello Igor, > > thanks for getting back to me on this, > > On 7/14/23 11:51, Igor Mammedov wrote: >> On Wed, 5 Jul 2023 10:12:40 +0200 >> Claudio Fontana wrote: >> >>> Hi all, partially resurrecting an

Re: x86 custom apicid assignments [Was: Re: [PATCH v7 0/2] Remove EPYC mode apicid decode and use generic decode]

2023-07-17 Thread Claudio Fontana
Hello Igor, thanks for getting back to me on this, On 7/14/23 11:51, Igor Mammedov wrote: > On Wed, 5 Jul 2023 10:12:40 +0200 > Claudio Fontana wrote: > >> Hi all, partially resurrecting an old thread. >> >> I've seen how for Epyc something special was done in

x86 custom apicid assignments [Was: Re: [PATCH v7 0/2] Remove EPYC mode apicid decode and use generic decode]

2023-07-05 Thread Claudio Fontana
Hi all, partially resurrecting an old thread. I've seen how for Epyc something special was done in the past in terms of apicid assignments based on topology, which was then reverted apparently, but I wonder if something more general would be useful to all? The QEMU apicid assignments first of al

Re: [PATCH] hw/ppc/spapr: Test whether TCG is enabled with tcg_enabled()

2023-06-20 Thread Claudio Fontana
On 6/20/23 09:48, Philippe Mathieu-Daudé wrote: > Although the PPC target only supports the TCG and KVM > accelerators, QEMU supports more. We can no assume that > '!kvm == tcg', so test for the correct accelerator. This > also eases code review, because here we don't care about > KVM, we really wa

Re: [RFC PATCH 4/6] Convert query-block/info_block to coroutine

2023-05-24 Thread Claudio Fontana
On 5/24/23 11:24, Lin Ma wrote: > The query-named-block-nodes is only availabe for qmp, not support hmp yet. > > Lin Ok, makes sense.

Re: [RFC PATCH 6/6] block: Add a thread-pool version of fstat

2023-05-24 Thread Claudio Fontana
AIO_ZONE_MGMT0x0200 > #define QEMU_AIO_ZONE_APPEND 0x0400 > +#define QEMU_AIO_FSTAT0x0800 > #define QEMU_AIO_TYPE_MASK \ > (QEMU_AIO_READ | \ > QEMU_AIO_WRITE | \ > @@ -42,7 +43,8 @@ > QEMU_AIO_TRUNCATE | \ > QEMU_AIO_ZONE_REPORT | \ > QEMU_AIO_ZONE_MGMT | \ > - QEMU_AIO_ZONE_APPEND) > + QEMU_AIO_ZONE_APPEND | \ > + QEMU_AIO_FSTAT) > > /* AIO flags */ > #define QEMU_AIO_MISALIGNED 0x1000 Reviewed-by: Claudio Fontana

Re: [RFC PATCH 4/6] Convert query-block/info_block to coroutine

2023-05-24 Thread Claudio Fontana
On 5/23/23 23:39, Fabiano Rosas wrote: > From: Lin Ma > > Sometimes the query-block performs time-consuming I/O(say waiting for > the fstat of NFS complete), So let's make this QMP handler runs in a > coroutine. > > The following patch moves the fstat() into a thread pool. > > Signed-off-by: Li

Re: [RFC PATCH 3/6] Convert query-block/info_block to coroutine

2023-05-24 Thread Claudio Fontana
On 5/23/23 23:39, Fabiano Rosas wrote: > From: Lin Ma > > Sometimes the query-block performs time-consuming I/O(say waiting for > the fstat of NFS complete), So let's make this QMP handler runs in a > coroutine. > > The following patch moves the fstat() into a thread pool. Hi, this message tal

Re: [RFC PATCH 1/6] block: Remove bdrv_query_block_node_info

2023-05-24 Thread Claudio Fontana
Error **errp); > void bdrv_query_image_info(BlockDriverState *bs, > ImageInfo **p_info, > bool flat, Reviewed-by: Claudio Fontana

Re: [RFC PATCH v1 00/26] migration: File based migration with multifd and fixed-ram

2023-04-07 Thread Claudio Fontana
On 4/6/23 18:46, Fabiano Rosas wrote: > Peter Xu writes: > >> On Tue, Apr 04, 2023 at 05:10:52PM +0200, Claudio Fontana wrote: >>> On 4/4/23 16:53, Peter Xu wrote: >>>> On Tue, Apr 04, 2023 at 10:00:16AM +0200, Claudio Fontana wrote: >>>>> Hi Peter

Re: [RFC PATCH v1 00/26] migration: File based migration with multifd and fixed-ram

2023-04-04 Thread Claudio Fontana
On 4/4/23 16:53, Peter Xu wrote: > On Tue, Apr 04, 2023 at 10:00:16AM +0200, Claudio Fontana wrote: >> Hi Peter, > > Hi, Claudio, > >> >> On 4/3/23 21:26, Peter Xu wrote: >>> Hi, Claudio, >>> >>> Thanks for the context. >>> &

Re: [RFC PATCH v1 00/26] migration: File based migration with multifd and fixed-ram

2023-04-04 Thread Claudio Fontana
Hi Peter, On 4/3/23 21:26, Peter Xu wrote: > Hi, Claudio, > > Thanks for the context. > > On Mon, Apr 03, 2023 at 09:47:26AM +0200, Claudio Fontana wrote: >> Hi, not sure if what is asked here is context in terms of the previous >> upstream discussions or our specifi

Re: [RFC PATCH v1 00/26] migration: File based migration with multifd and fixed-ram

2023-04-03 Thread Claudio Fontana
On 3/31/23 23:52, Peter Xu wrote: > On Fri, Mar 31, 2023 at 03:18:37PM -0300, Fabiano Rosas wrote: >> Peter Xu writes: >> >>> On Fri, Mar 31, 2023 at 05:10:16PM +0100, Daniel P. Berrangé wrote: On Fri, Mar 31, 2023 at 11:55:03AM -0400, Peter Xu wrote: > On Fri, Mar 31, 2023 at 12:30:45PM

Re: [PATCH 03/10] accel/tcg: move i386 halt handling to sysemu_ops

2023-03-21 Thread Claudio Fontana
On 3/20/23 16:34, Philippe Mathieu-Daudé wrote: > On 20/3/23 16:23, Claudio Fontana wrote: >> Hi Alex, all, >> >> again, this moves TCG-only code to common code, no? > > Oh, good point. > >> Even if this happens to work, the idea is to avoid adding unnee

Re: [PATCH 03/10] accel/tcg: move i386 halt handling to sysemu_ops

2023-03-20 Thread Claudio Fontana
Hi Alex, all, again, this moves TCG-only code to common code, no? Even if this happens to work, the idea is to avoid adding unneeded accel TCG code to a KVM-only binary. We need to keep in mind all dimensions when we do refactorings: user-mode vs sysemu, the architecture, the accel, in particu

Re: [PATCH 02/10] accel/tcg: move cpu_reloading_memory_map into cpu-exec-softmmu

2023-03-20 Thread Claudio Fontana
On 3/20/23 14:32, Alex Bennée wrote: > > Claudio Fontana writes: > >> How is this conditional on CONFIG_TCG? To me it looks like this breaks >> !CONFIG_TCG. >> Careful, the meson.build in accel/tcg/meson.build is always recursed. > > Surely it shouldn't b

Re: [PATCH 02/10] accel/tcg: move cpu_reloading_memory_map into cpu-exec-softmmu

2023-03-20 Thread Claudio Fontana
How is this conditional on CONFIG_TCG? To me it looks like this breaks !CONFIG_TCG. Careful, the meson.build in accel/tcg/meson.build is always recursed. This code was in tcg_ss before, why not simply add it to tcg_ss and then to specific_ss along with the other tcg pieces? Ciao, C On 3/20/2

Re: [PATCH v3 00/14] File-based migration support and fixed-ram features

2023-03-20 Thread Claudio Fontana
(adding Fabiano to the thread) On 2/10/23 16:35, Daniel P. Berrangé wrote: > On Thu, Feb 09, 2023 at 02:32:01PM +0100, Claudio Fontana wrote: >> Hello Daniel and all, >> >> resurrecting this series from end of last year, >> >> do we think that this is the right

Re: [PATCH v3 10/14] migration/ram: Introduce 'fixed-ram' migration stream capability

2023-03-20 Thread Claudio Fontana
Added Fabiano to the thread, CLaudio On 3/20/23 12:05, Claudio Fontana wrote: > On 2/10/23 18:11, Daniel P. Berrangé wrote: >> On Fri, Oct 28, 2022 at 01:39:10PM +0300, Nikolay Borisov wrote: >>> Implement 'fixed-ram' feature. The core of the feature is to ensure t

Re: [PATCH v3 10/14] migration/ram: Introduce 'fixed-ram' migration stream capability

2023-03-20 Thread Claudio Fontana
On 2/10/23 18:11, Daniel P. Berrangé wrote: > On Fri, Oct 28, 2022 at 01:39:10PM +0300, Nikolay Borisov wrote: >> Implement 'fixed-ram' feature. The core of the feature is to ensure that >> each ram page of the migration stream has a specific offset in the >> resulting migration stream. The reason

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Claudio Fontana
On 1/30/23 12:44, Thomas Huth wrote: > Testing 32-bit host OS support takes a lot of precious time during the QEMU > contiguous integration tests, and considering that many OS vendors stopped > shipping 32-bit variants of their OS distributions and most hardware from > the past >10 years is capable

Re: [RFC PATCH] docs/about/deprecated: Deprecate 32-bit host systems

2023-02-17 Thread Claudio Fontana
On 2/17/23 11:36, Markus Armbruster wrote: > I feel the discussion petered out without a conclusion. > > I don't think letting the status quo win by inertia is a good outcome > here. > > Which 32-bit hosts are still useful, and why? Hi Markus, if the question is very very general, my opinion i

Re: [RFC v5 0/3] migration: reduce time of loading non-iterable vmstate

2023-02-15 Thread Claudio Fontana
On 1/17/23 12:55, Chuang Xu wrote: > In this version: > > - rename rcu_read_locked() to rcu_read_is_locked(). > - adjust the sanity check in address_space_to_flatview(). > - improve some comments. > > The duration of loading non-iterable vmstate accounts for a significant > portion of downtime (s

  1   2   3   4   5   6   7   8   9   10   >