On Mon, Apr 21, 2025 at 11:19 AM Jason Wang wrote:
>
> On Thu, Apr 17, 2025 at 6:25 PM Cindy Lu wrote:
> >
> > For VDPA devices, Allow configurations where the hardware MAC address
> > is non-zero while the MAC address in the QEMU command line is zero.
> > I
On Mon, Apr 21, 2025 at 11:22 AM Jason Wang wrote:
>
> On Thu, Apr 17, 2025 at 6:26 PM Cindy Lu wrote:
> >
> > For VDPA devices, Allow configurations where both the hardware MAC address
> > and QEMU command line MAC address are zero.
> > In this case, QEMU will a
: Cindy Lu
---
hw/net/virtio-net.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 808a2fe4d4..2d4ac20ee0 100644
--- a/hw/net/virtio-net.c
+++ b/hw/net/virtio-net.c
@@ -3772,7 +3772,18 @@ static bool virtio_net_check_vdpa_mac(VirtIONet
For VDPA devices, Allow configurations where the hardware MAC address
is non-zero while the MAC address in the QEMU command line is zero.
In this case, QEMU will use the hardware MAC address from the device.
Signed-off-by: Cindy Lu
---
hw/net/virtio-net.c | 14 ++
1 file changed, 14
vdpa0,check-mac=true\
-device virtio-net-pci,netdev=vhost-vdpa0\
To disable this check:
-netdev
type=vhost-vdpa,vhostdev=/dev/vhost-vdpa-0,id=vhost-vdpa0,check-mac=false\
-device virtio-net-pci,netdev=vhost-vdpa0\
Signed-off-by: Cindy Lu
---
include/net/net.h | 1 +
net/vhost-vdpa.c
2. Address comments and rebase with the latest QEMU
Cindy Lu (4):
vhost_vdpa : Add a new parameter to enable check mac address
virtio_net: Add the check for vdpa's mac address
virtio_net: Add second acceptable configuration for MAC setup
virtio_net: Add third acceptable configuration for
When using a VDPA device, it is important to ensure that the MAC
address is correctly set. The MAC address in the hardware should
match the MAC address from the QEMU command line. This is a recommended
configuration and will allow the system to boot.
Signed-off-by: Cindy Lu
---
hw/net/virtio
On Tue, Apr 8, 2025 at 2:38 PM Jason Wang wrote:
>
> On Tue, Apr 8, 2025 at 2:13 PM Cindy Lu wrote:
> >
> > When using a VDPA device, it's important to ensure that the MAC
> > address is correctly set.
> > Add a new parameter in qemu cmdline to enable thi
On Tue, Apr 8, 2025 at 2:48 PM Jason Wang wrote:
>
> On Tue, Apr 8, 2025 at 2:14 PM Cindy Lu wrote:
> >
> > For VDPA devices, Allow configurations where both the hardware MAC address
> > and QEMU command line MAC address are zero.
> >
>
> Let's explain w
On Tue, Apr 8, 2025 at 2:46 PM Jason Wang wrote:
>
> On Tue, Apr 8, 2025 at 2:13 PM Cindy Lu wrote:
> >
> > When using a VDPA device, it is important to ensure that the MAC
> > address is correctly set. The MAC address in the hardware should
> > match the MAC addr
On Tue, Apr 8, 2025 at 2:48 PM Jason Wang wrote:
>
> On Tue, Apr 8, 2025 at 2:13 PM Cindy Lu wrote:
> >
> > For VDPA devices, Allow configurations where the hardware MAC address
> > is non-zero while the MAC address in the QEMU command line is zero.
> &g
t-pci,netdev=vhost-vdpa0\
Signed-off-by: Cindy Lu
---
include/net/net.h | 1 +
net/vhost-vdpa.c | 4
qapi/net.json | 5 +
3 files changed, 10 insertions(+)
diff --git a/include/net/net.h b/include/net/net.h
index cdd5b109b0..fac1951b6e 100644
--- a/include/net/net.h
+++ b/includ
For VDPA devices, Allow configurations where the hardware MAC address
is non-zero while the MAC address in the QEMU command line is zero.
Signed-off-by: Cindy Lu
---
hw/net/virtio-net.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
parameter's name to check-mac
2. change the comment and make it more clear
change in v5
1.These patches haven't been merged for a while, so I rebased
them with the latest code and resubmitted
change in v6
1. Address comments
2. Rebase with the latest QEMU
Cindy Lu (4):
vhost_vdpa :
When using a VDPA device, it is important to ensure that the MAC
address is correctly set. The MAC address in the hardware should
match the MAC address from the QEMU command line. This is a recommended
configuration and will allow the system to boot.
Signed-off-by: Cindy Lu
---
hw/net/virtio
For VDPA devices, Allow configurations where both the hardware MAC address
and QEMU command line MAC address are zero.
Signed-off-by: Cindy Lu
---
hw/net/virtio-net.c | 12
1 file changed, 12 insertions(+)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 45b63eb9de
On Fri, Mar 21, 2025 at 12:29 PM Konstantin Shkolnyy wrote:
>
> On 3/20/2025 20:22, Jason Wang wrote:
> > On Fri, Mar 21, 2025 at 12:45 AM Konstantin Shkolnyy
> > wrote:
> >>
> >> On 3/19/2025 19:58, Jason Wang wrote:
> >>> On Thu, Mar 20, 2025 at 12:34 AM Konstantin Shkolnyy
> >>> wrote:
> >>
t-pci,netdev=vhost-vdpa0\
Signed-off-by: Cindy Lu
---
include/net/net.h | 1 +
net/vhost-vdpa.c | 4
qapi/net.json | 5 +
3 files changed, 10 insertions(+)
diff --git a/include/net/net.h b/include/net/net.h
index cdd5b109b0..fac1951b6e 100644
--- a/include/net/net.h
+++ b/includ
On Thu, Apr 3, 2025 at 12:35 AM Michael S. Tsirkin wrote:
>
> On Wed, Mar 26, 2025 at 09:19:32PM +0800, Cindy Lu wrote:
> > For VDPA devices, Allow configurations where the hardware MAC address
> > is non-zero while the MAC address in the QEMU command line is zero.
> >
>
On Thu, Apr 3, 2025 at 12:34 AM Michael S. Tsirkin wrote:
>
> On Wed, Mar 26, 2025 at 09:19:31PM +0800, Cindy Lu wrote:
> > When using a VDPA device, it is important to ensure that the MAC
> > address is correctly set. The MAC address in the hardware should
> > match the M
On Thu, Apr 3, 2025 at 12:36 AM Michael S. Tsirkin wrote:
>
> On Wed, Mar 26, 2025 at 09:19:33PM +0800, Cindy Lu wrote:
> > For VDPA devices, Allow configurations where both the hardware MAC address
> > and QEMU command line MAC address are zero.
> >
> > Signed-off
When using a VDPA device, it is important to ensure that the MAC
address is correctly set. The MAC address in the hardware should
match the MAC address from the QEMU command line. This is a recommended
configuration and will allow the system to boot.
Signed-off-by: Cindy Lu
---
hw/net/virtio
For VDPA devices, Allow configurations where both the hardware MAC address
and QEMU command line MAC address are zero.
Signed-off-by: Cindy Lu
---
hw/net/virtio-net.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index 1fd0403d5d
parameter's name to check-mac
2. change the comment and make it more clear
change in v5
1.These patches haven't been merged for a while, so I rebased
them with the latest code and resubmitted
Cindy Lu (4):
vhost_vdpa : Add a new parameter to enable check mac address
virtio_net: Add the
For VDPA devices, Allow configurations where the hardware MAC address
is non-zero while the MAC address in the QEMU command line is zero.
Signed-off-by: Cindy Lu
---
hw/net/virtio-net.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
Hi Konstantin
yes, we have found this kind of issue in this upstream
So here is a fix for this problem in kernel
https://lore.kernel.org/kvm/caclfguuyny6-1cyabsgs+qtdzo+mkp3o09t_gt-bmm4jgdp...@mail.gmail.com/T/
vdpa: support set mac address from vdpa tool
This tool allows the user to change the M
t-pci,netdev=vhost-vdpa0\
Signed-off-by: Cindy Lu
---
include/net/net.h | 1 +
net/vhost-vdpa.c | 4
qapi/net.json | 5 +
3 files changed, 10 insertions(+)
diff --git a/include/net/net.h b/include/net/net.h
index cdd5b109b0..fac1951b6e 100644
--- a/include/net/net.h
+++ b/includ
For VDPA devices, Allow configurations where both the hardware MAC address
and QEMU command line MAC address are zero.
Signed-off-by: Cindy Lu
---
hw/net/virtio-net.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index f74aa4f8db
When using a VDPA device, it is important to ensure that the MAC
address is correctly set. The MAC address in the hardware should
match the MAC address from the QEMU command line. This is a recommended
configuration and will allow the system to boot.
Signed-off-by: Cindy Lu
---
hw/net/virtio
For VDPA devices, Allow configurations where the hardware MAC address
is non-zero while the MAC address in the QEMU command line is zero.
Signed-off-by: Cindy Lu
---
hw/net/virtio-net.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
name to check-mac
2. change the comment and make it more clear
Cindy Lu (4):
vhost_vdpa : Add a new parameter to enable check mac address
virtio_net: Add the check for vdpa's mac address
virtio_net: Add second acceptable configuration for MAC setup
virtio_net: Add third
On Wed, Nov 6, 2024 at 5:25 PM Michael S. Tsirkin wrote:
>
> On Sat, Oct 26, 2024 at 03:59:59PM +0800, Cindy Lu wrote:
> > When using a VDPA device, it's important to ensure that the MAC
> > address is correctly set.
> > Add a new parameter in qemu cmdline to ena
When using a VDPA device, the following situations are
also acceptable: the hardware MAC address is not 0,
and the MAC address in the QEMU command line is 0.
Signed-off-by: Cindy Lu
---
hw/net/virtio-net.c | 14 ++
1 file changed, 14 insertions(+)
diff --git a/hw/net/virtio-net.c b
While the hardware MAC address is 0 and the MAC address in
the QEMU command line is also 0, this configuration is
acceptable.
Signed-off-by: Cindy Lu
---
hw/net/virtio-net.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index
When using a VDPA device, it is important to ensure that the MAC
address is correctly set. The MAC address in the hardware should
match the MAC address from the QEMU command line. This is a recommended
configuration and will allow the system to boot.
Signed-off-by: Cindy Lu
---
hw/net/virtio
o-net-pci,netdev=vhost-vdpa0\
Signed-off-by: Cindy Lu
---
include/net/net.h | 1 +
net/vhost-vdpa.c | 4
qapi/net.json | 5 +
3 files changed, 10 insertions(+)
diff --git a/include/net/net.h b/include/net/net.h
index c8f679761b..e00651a97b 100644
--- a/include/net/net.h
,vhostdev=/dev/vhost-vdpa-0,id=vhost-vdpa0,macstrickcheck=true\
-device virtio-net-pci,netdev=vhost-vdpa0\
tested by ConnectX-6 Dx device
change in v3
1. add a new parameter to enable the check and keep the old behavior
2. adjust the comment and make it more clear
Cindy Lu (4):
vhost_vdpa : Add a
On Wed, 9 Oct 2024 at 16:30, Jason Wang wrote:
>
> On Mon, Sep 30, 2024 at 12:01 AM Cindy Lu wrote:
> >
> > While the hardware MAC address is 0 and the MAC address in
> > the QEMU command line is also 0, this configuration is
> > acceptable.
> >
> > Si
On Wed, 9 Oct 2024 at 16:30, Jason Wang wrote:
>
> On Mon, Sep 30, 2024 at 12:01 AM Cindy Lu wrote:
> >
> > When using a VDPA device, the following situations are
> > also acceptable: the hardware MAC address is not 0,
> > and the MAC address in the QEMU command li
When using a VDPA device, it is important to ensure that the MAC
address is correctly set.
There are only three acceptable situations for MAC setup; any other
configuration will fail to boot.
tested by ConnectX-6 Dx device
Cindy Lu (3):
virtio_net: Add the check for vdpa's mac ad
When using a VDPA device, the following situations are
also acceptable: the hardware MAC address is not 0,
and the MAC address in the QEMU command line is 0.
Signed-off-by: Cindy Lu
---
hw/net/virtio-net.c | 12
1 file changed, 12 insertions(+)
diff --git a/hw/net/virtio-net.c b
While the hardware MAC address is 0 and the MAC address in
the QEMU command line is also 0, this configuration is
acceptable.
Signed-off-by: Cindy Lu
---
hw/net/virtio-net.c | 11 +++
1 file changed, 11 insertions(+)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index
When using a VDPA device, it is important to ensure that the MAC
address is correctly set. The MAC address in the hardware should
match the MAC address from the QEMU command line. This is a recommended
configuration and will allow the system to boot.
Signed-off-by: Cindy Lu
---
hw/net/virtio
On Tue, 6 Aug 2024 at 21:30, Michael S. Tsirkin wrote:
>
> On Tue, Aug 06, 2024 at 08:58:01AM +0800, Cindy Lu wrote:
> > When using a VDPA device, it is important to ensure that
> > the MAC address in the hardware matches the MAC address
> > from the QEMU command line.
On Wed, 7 Aug 2024 at 10:36, Jason Wang wrote:
> On Tue, Aug 6, 2024 at 5:44 PM Cindy Lu wrote:
> >
> > On Tue, 6 Aug 2024 at 11:07, Jason Wang wrote:
> > >
> > > On Tue, Aug 6, 2024 at 8:58 AM Cindy Lu wrote:
> > > >
> > > >
x27;t
have this kind of verification. I will double check this
Thanks
Cindy
>
> On Tue, Aug 6, 2024 at 12:45 PM Cindy Lu wrote:
> >
> > On Tue, 6 Aug 2024 at 11:07, Jason Wang wrote:
> > >
> > > On Tue, Aug 6, 2024 at 8:58 AM Cindy Lu wrote:
> > > &
On Tue, 6 Aug 2024 at 11:09, Jason Wang wrote:
>
> On Tue, Aug 6, 2024 at 8:58 AM Cindy Lu wrote:
> >
> > The vdpa device with MAC address 0 should not boot.
> > So remove the check here
> >
> > Signed-off-by: Cindy Lu
>
> Please describe what issue
On Tue, 6 Aug 2024 at 11:07, Jason Wang wrote:
>
> On Tue, Aug 6, 2024 at 8:58 AM Cindy Lu wrote:
> >
> > When using a VDPA device, it is important to ensure that
> > the MAC address in the hardware matches the MAC address
> > from the QEMU command line.
> >
fix use of a released vector")
Cc: qemu-sta...@nongnu.org
Signed-off-by: Cindy Lu
---
hw/virtio/virtio-pci.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index 592fdaa10f..dc31a37ec0 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/v
When using a VDPA device, it is important to ensure that
the MAC address in the hardware matches the MAC address
from the QEMU command line.
This will allow the device to boot.
Signed-off-by: Cindy Lu
---
hw/net/virtio-net.c | 33 +
1 file changed, 29 insertions
The vdpa device with MAC address 0 should not boot.
So remove the check here
Signed-off-by: Cindy Lu
---
hw/net/virtio-net.c | 13 -
1 file changed, 13 deletions(-)
diff --git a/hw/net/virtio-net.c b/hw/net/virtio-net.c
index c144ae2e78..8a7c743ad3 100644
--- a/hw/net/virtio-net.c
When using a VDPA device, this is another acceptable situations
The hardware MAC address is not 0, and the MAC address in the QEMU command line
is 0.
This is also acceptable
Signed-off-by: Cindy Lu
---
hw/net/virtio-net.c | 13 -
1 file changed, 12 insertions(+), 1 deletion
On Mon, 22 Jul 2024 at 15:24, Jason Wang wrote:
>
> Hi Cindy
>
> On Fri, Jul 19, 2024 at 1:25 PM Cindy Lu wrote:
> >
> > The crash was reported in MAC OS and NixOS, here is the link for this
bug
> > https://gitlab.com/qemu-project/qemu/-/issues/2334
> >
cff94d ("virtio-pci: fix use of a released vector")
Cc: qemu-sta...@nongnu.org
Signed-off-by: Cindy Lu
---
hw/virtio/virtio-pci.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index 592fdaa10f..dc31a37ec0 100644
--- a/hw/virtio/vir
On Tue, 2 Jul 2024 at 15:09, Jason Wang wrote:
>
> On Tue, Jul 2, 2024 at 10:00 AM Cindy Lu wrote:
> >
> > The crash was reported in MAC OS and NixOS, here is the link for this bug
> > https://gitlab.com/qemu-project/qemu/-/issues/2334
> > https://gitlab.com/q
On Tue, 16 Jul 2024 at 13:37, Jason Wang wrote:
>
> On Tue, Jul 16, 2024 at 9:14 AM Cindy Lu wrote:
> >
> > When using a VDPA device, it is important to ensure that the MAC address
> > in the hardware matches the MAC address from the QEMU command line.
> >
>
On Tue, 16 Jul 2024 at 09:56, Lei Yang wrote:
>
> Hi Cindy
>
> If needed, QE can help test this MR before merging into the master branch.
>
> Best Regards
> Lei
>
sure， Really thanks for your help
thanks
cindy
>
> On Tue, Jul 16, 2024 at 9:14 AM Cindy Lu wrote:
&g
addresses are not 0.
2. The hardware MAC address is not 0, and the MAC address in the QEMU command
line is 0.
In this situation, the hardware MAC address will overwrite the QEMU command
line address.
Signed-off-by: Cindy Lu
---
hw/net/virtio-net.c | 43 +--
1
On Tue, 9 Jul 2024 at 10:47, Jason Wang wrote:
>
> On Tue, Jul 9, 2024 at 10:41 AM Cindy Lu wrote:
> >
> > On Tue, 9 Jul 2024 at 10:33, Jason Wang wrote:
> > >
> > > On Tue, Jul 9, 2024 at 10:27 AM Cindy Lu wrote:
> > > >
> > > > When
On Tue, 9 Jul 2024 at 10:33, Jason Wang wrote:
>
> On Tue, Jul 9, 2024 at 10:27 AM Cindy Lu wrote:
> >
> > When using VDPA device, we should verify whether the MAC address in the
> > hardware matches the MAC address from the QEMU command line. If not,
> > we w
When using VDPA device, we should verify whether the MAC address in the
hardware matches the MAC address from the QEMU command line. If not,
we will need to update the related information.
Signed-off-by: Cindy Lu
---
hw/net/virtio-net.c | 15 +++
1 file changed, 11 insertions(+), 4
Add the return value check for kvm_virtio_pci_vector_use_one().
Since the return value of function virtio_pci_set_vector() is void,
we can do nothing here. So just add the error message here.
Signed-off-by: Cindy Lu
---
hw/virtio/virtio-pci.c | 4 +++-
1 file changed, 3 insertions(+), 1
check for kvm_virtio_pci_vector_use_one().
Since the return value of function virtio_pci_set_vector() is void,
just add the error message here.
Cindy Lu (2):
virtio-pci: Fix the use of an uninitialized irqfd
virtio-pci: Add check the return of kvm_virtio_pci_vector_use_one
hw/virtio/vir
t
../qemu-9.0.0/util/qemu-thread-posix.c:541
13 0x7c8185bcd1cf in ??? () at /usr/lib/libc.so.6
14 0x7c8185c4e504 in clone () at /usr/lib/libc.so.6
Fixes: 2ce6cff94d ("virtio-pci: fix use of a released vector")
Cc: qemu-sta...@nongnu.org
Signed-off-by: Cindy Lu
---
hw/virtio/vir
On Thu, Jun 27, 2024 at 4:55 PM Michael S. Tsirkin wrote:
>
> On Thu, Jun 27, 2024 at 04:40:33PM +0800, Cindy Lu wrote:
> > On Wed, Jun 26, 2024 at 3:45 PM Michael S. Tsirkin wrote:
> > >
> > > On Wed, Jun 26, 2024 at 10:44:31AM +0800, Cindy Lu wrote:
> > >
On Wed, Jun 26, 2024 at 3:45 PM Michael S. Tsirkin wrote:
>
> On Wed, Jun 26, 2024 at 10:44:31AM +0800, Cindy Lu wrote:
> > The crash was reported in MAC OS and NixOS, here is the link for this bug
> > https://gitlab.com/qemu-project/qemu/-/issues/2334
> > https://gitl
) at /usr/lib/libc.so.6
14 0x7c8185c4e504 in clone () at /usr/lib/libc.so.6
Fixes: 2ce6cff94d ("virtio-pci: fix use of a released vector")
Cc: qemu-sta...@nongnu.org
Signed-off-by: Cindy Lu
---
hw/virtio/virtio-pci.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
diff --git
On Mon, Jun 17, 2024 at 6:38 PM Philippe Mathieu-Daudé
wrote:
>
> Hi Cindy,
>
> On 17/6/24 11:55, Cindy Lu wrote:
> > The crash was reported in MAC OS and NixOS, here is the link for this bug
> > https://gitlab.com/qemu-project/qemu/-/issues/2334
> > https://gitlab.
leased vector")
Cc: qemu-sta...@nongnu.org
Signed-off-by: Cindy Lu
---
hw/virtio/virtio-pci.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index b1d02f4b3d..502aad28b2 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virti
On Wed, May 29, 2024 at 9:54 PM Fiona Ebner wrote:
>
> Hi,
>
> Am 22.05.24 um 07:10 schrieb Cindy Lu:
> > The crash was reported in MAC OS and NixOS, here is the link for this bug
> > https://gitlab.com/qemu-project/qemu/-/issues/2334
> > https://gitlab.com/q
: qemu-sta...@nongnu.org
Signed-off-by: Cindy Lu
---
hw/virtio/virtio-pci.c | 18 ++
1 file changed, 2 insertions(+), 16 deletions(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index b1d02f4b3d..8a9d0f6ef5 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
es: 2ce6cff94d ("virtio-pci: fix use of a released vector")
Cc: qemu-sta...@nongnu.org
Signed-off-by: Cindy Lu
---
hw/virtio/virtio-pci.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index b1d02f4b3d..a7faee5
On Thu, May 9, 2024 at 4:18 AM Michael Tokarev wrote:
>
> 15.04.2024 12:34, Michael S. Tsirkin wrote:
> > From: Cindy Lu
> >
> > During the booting process of the non-standard image, the behavior of the
> > called function in qemu is as follows:
> >
> >
On Wed, Apr 17, 2024 at 2:38 AM Michael S. Tsirkin wrote:
>
> On Tue, Apr 16, 2024 at 02:14:57PM +0100, Peter Maydell wrote:
> > On Tue, 16 Apr 2024 at 13:41, Cindy Lu wrote:
> > >
> > > On Tue, Apr 16, 2024 at 8:30 PM Peter Maydell
> > > wrote:
>
On Tue, Apr 16, 2024 at 11:21 AM Jason Wang wrote:
>
> On Mon, Apr 15, 2024 at 6:41 PM Cindy Lu wrote:
> >
> > On Mon, Apr 15, 2024 at 5:34 PM Michael S. Tsirkin wrote:
> > >
> > > From: Cindy Lu
> > >
> > > During the booting process of th
On Tue, Apr 16, 2024 at 8:22 PM Peter Maydell wrote:
>
> On Tue, 16 Apr 2024 at 12:50, Peter Maydell wrote:
> >
> > On Tue, 16 Apr 2024 at 12:05, Cindy Lu wrote:
> > >
> > > On Tue, Apr 16, 2024 at 6:01 PM Peter Maydell
> > > wrote:
> > >
On Tue, Apr 16, 2024 at 7:50 PM Peter Maydell wrote:
>
> On Tue, 16 Apr 2024 at 12:05, Cindy Lu wrote:
> >
> > On Tue, Apr 16, 2024 at 6:01 PM Peter Maydell
> > wrote:
> > > Here we pass that through to kvm_virtio_pci_vector_use_one().
> > > In kvm_vir
On Tue, Apr 16, 2024 at 8:30 PM Peter Maydell wrote:
>
> On Tue, 16 Apr 2024 at 13:29, Cindy Lu wrote:
> >
> > In function kvm_virtio_pci_vector_use_one(), in the undo label,
> > the function will get the vector incorrectly while using
> > VIRTIO_CONFIG_IRQ_IDX
&
: qemu-sta...@nongnu.org
Signed-off-by: Cindy Lu
---
hw/virtio/virtio-pci.c | 19 +++
1 file changed, 3 insertions(+), 16 deletions(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index b138fa127a..565bdb0897 100644
--- a/hw/virtio/virtio-pci.c
+++ b/hw/virtio/virtio-pci.c
On Tue, Apr 16, 2024 at 6:01 PM Peter Maydell wrote:
>
> On Mon, 15 Apr 2024 at 11:52, Michael S. Tsirkin wrote:
> >
> > From: Cindy Lu
> >
> > During the booting process of the non-standard image, the behavior of the
> > called function in qemu is as foll
On Mon, Apr 15, 2024 at 5:34 PM Michael S. Tsirkin wrote:
>
> From: Cindy Lu
>
> During the booting process of the non-standard image, the behavior of the
> called function in qemu is as follows:
>
> 1. vhost_net_stop() was triggered by guest image. This w
On Mon, Apr 15, 2024 at 5:34 PM Michael S. Tsirkin wrote:
>
> From: Cindy Lu
>
> During the booting process of the non-standard image, the behavior of the
> called function in qemu is as follows:
>
> 1. vhost_net_stop() was triggered by guest image. This w
On Mon, Apr 15, 2024 at 4:32 PM Michael S. Tsirkin wrote:
>
> On Fri, Apr 12, 2024 at 02:26:55PM +0800, Cindy Lu wrote:
> > During the booting process of the non-standard image, the behavior of the
> > called function in qemu is as follows:
> >
> > 1. vhost_net_stop(
r);
if (ret < 0) {
return;
}
...
So I move the setting vector into the function
virtio_pci_set_and_change_vector()
the other part are the same .
the sanity test is passed and the qemu qtest is also passed
Thanks
Cindy
On Fri, Apr 12, 2024 at 2:28 PM Cindy Lu wrote:
>
> During th
) at
pthread_create.c:442
23 0x7fc871512630 in clone3 () at
../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
(gdb)
Fixes: f9a09ca3ea ("vhost: add support for configure interrupt")
Cc: qemu-sta...@nongnu.org
Signed-off-by: Cindy Lu
---
hw/virtio/virtio-pci.c | 43 ++
) at
pthread_create.c:442
23 0x7fc871512630 in clone3 () at
../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
(gdb)
Fixes: f9a09ca3ea ("vhost: add support for configure interrupt")
Cc: qemu-sta...@nongnu.org
Signed-off-by: Cindy Lu
---
hw/virtio/virtio-pci.c | 29 +
On Thu, Apr 11, 2024 at 1:56 PM Michael S. Tsirkin wrote:
>
> On Thu, Apr 11, 2024 at 12:11:30PM +0800, Cindy Lu wrote:
> > During the booting process of the non-standard image, the behavior of the
> > called function in qemu is as follows:
> >
> > 1. vhost_net_stop(
) at
pthread_create.c:442
23 0x7fc871512630 in clone3 () at
../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
(gdb)
Signed-off-by: Cindy Lu
---
hw/virtio/virtio-pci.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
On Thu, Apr 11, 2024 at 12:18 AM Michael S. Tsirkin wrote:
>
> On Thu, Apr 11, 2024 at 12:12:00AM +0800, Cindy Lu wrote:
> > During the booting process of the non-standard image, the behavior of the
> > called function in qemu is as follows:
> >
> > 1. vhost_net
) at
pthread_create.c:442
23 0x7fc871512630 in clone3 () at
../sysdeps/unix/sysv/linux/x86_64/clone3.S:81
(gdb)
Signed-off-by: Cindy Lu
---
hw/virtio/virtio-pci.c | 30 ++
1 file changed, 30 insertions(+)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
On Wed, Apr 10, 2024 at 1:48 PM Jason Wang wrote:
>
> On Wed, Apr 10, 2024 at 1:29 PM Cindy Lu wrote:
> >
> > When the guest triggers vhost_stop and then virtio_reset, the vector will
> > the
> > IRQFD for this vector will be released and change to VIRTIO_NO_VEC
On Wed, Apr 10, 2024 at 1:36 PM Jason Wang wrote:
>
> On Wed, Apr 10, 2024 at 1:29 PM Cindy Lu wrote:
> >
> > When the guest triggers vhost_stop and then virtio_reset, the vector will
> > the
> > IRQFD for this vector will be released and change to VIRTIO_NO_VEC
et_stop(),
So this step will not lost during this process.
Change from V1
1.add the check for if using irqfd
2.remove the check for bool recovery, irqfd's user is enough to check status
Cindy Lu (1):
virtio-pci: Fix the crash that the vector was used after releas
640f8d731 in kvm_vcpu_thread_fn (arg=0x560642f205e0) at
../accel/kvm/kvm-accel-ops.c:51
21 0x5606411949f4 in qemu_thread_start (args=0x560642f292b0) at
../util/qemu-thread-posix.c:541
22 0x7fc87148cdcd in start_thread (arg=) at
pthread_create.c:442
23 0x7fc871512630 in clone3 () at
On Mon, Apr 8, 2024 at 12:59 PM Jason Wang wrote:
>
> On Sun, Apr 7, 2024 at 3:00 PM Cindy Lu wrote:
> >
> > On Sun, Apr 7, 2024 at 12:20 PM Jason Wang wrote:
> > >
> > > On Tue, Apr 2, 2024 at 11:02 PM Cindy Lu wrote:
> > > >
> > >
On Sun, Apr 7, 2024 at 12:20 PM Jason Wang wrote:
>
> On Tue, Apr 2, 2024 at 11:02 PM Cindy Lu wrote:
> >
> > When the guest calls virtio_stop and then virtio_reset,
>
> Guests could not call those functions directly, it is triggered by for
> example writing to some
0 is_masked 1
[msix_fire_vector_notifier] 112 called vector 0 is_masked 0
To fix this, we need to call the function "kvm_virtio_pci_vector_use_one()"
when the vector changes back from VIRTIO_NO_VECTOR
Signed-off-by: Cindy Lu
Cindy Lu (1):
virtio-pci: Fix the crash when the v
e_one()"
when the vector changes back from VIRTIO_NO_VECTOR
Signed-off-by: Cindy Lu
---
hw/virtio/virtio-pci.c | 31 ---
1 file changed, 28 insertions(+), 3 deletions(-)
diff --git a/hw/virtio/virtio-pci.c b/hw/virtio/virtio-pci.c
index e433879542..45f3ab38c3 10064
On Thu, Mar 28, 2024 at 12:12 PM Jason Wang wrote:
>
> On Wed, Mar 27, 2024 at 5:33 PM Cindy Lu wrote:
> >
> > On Wed, Mar 27, 2024 at 5:12 PM Jason Wang wrote:
> > >
> > > On Wed, Mar 27, 2024 at 4:28 PM Cindy Lu wrote:
> > > >
> >
On Thu, Mar 28, 2024 at 12:14 PM Jason Wang wrote:
>
> On Wed, Mar 27, 2024 at 5:44 PM Cindy Lu wrote:
> >
> > On Wed, Mar 27, 2024 at 5:13 PM Jason Wang wrote:
> > >
> > > On Wed, Mar 27, 2024 at 5:12 PM Jason Wang wrote:
> > > >
> &g
1 - 100 of 577 matches
Mail list logo
