Re: [PULL v2 31/82] vhost: Change the sequence of device start

On Mon, Nov 07, 2022 at 08:30:32AM -0500, Michael S. Tsirkin wrote: > On Sun, Nov 06, 2022 at 07:00:33PM +0100, Christian A. Ehrhardt wrote: > > > > Hi, > > > > On Sat, Nov 05, 2022 at 12:43:05PM -0400, Michael S. Tsirkin wrote: > > > On Sat, Nov 05, 2022 a

Re: [PULL v2 31/82] vhost: Change the sequence of device start

Hi, On Sat, Nov 05, 2022 at 12:43:05PM -0400, Michael S. Tsirkin wrote: > On Sat, Nov 05, 2022 at 05:35:57PM +0100, Bernhard Beschow wrote: > > > > > > On Wed, Nov 2, 2022 at 5:24 PM Michael S. Tsirkin wrote: > > > > From: Yajun Wu > > > > This patch is part of adding vhost-user vh

[PATCH v2] hw/acpi/erst.c: Fix memory handling issues

: f7e26ffa590 ("ACPI ERST: support for ACPI ERST feature") Tested-by: Alexander Bulekov Signed-off-by: Christian A. Ehrhardt --- hw/acpi/erst.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/acpi/erst.c b/hw/acpi/erst.c index df856b2669..aefcc03ad6 100644 ---

Re: [PATCH] hw/acpi/erst.c: Fix memset argument order

Hi, On Sat, Oct 22, 2022 at 01:37:27AM -0400, Alexander Bulekov wrote: > On 221021 1505, Alexander Bulekov wrote: > > On 221019 2115, Christian A. Ehrhardt wrote: > > > Fix memset argument order: The second argument is > > > the value, the length goes last. >

Re: [PATCH] hw/acpi/erst.c: Fix memset argument order

On Fri, Oct 21, 2022 at 06:22:50AM +0200, Markus Armbruster wrote: > "Christian A. Ehrhardt" writes: > > > Hi Markus, > > > > On Thu, Oct 20, 2022 at 08:14:32AM +0200, Markus Armbruster wrote: > >> "Christian A. Ehrhardt" writes: > >

Re: [PATCH] hw/acpi/erst.c: Fix memset argument order

Hi Markus, On Thu, Oct 20, 2022 at 08:14:32AM +0200, Markus Armbruster wrote: > "Christian A. Ehrhardt" writes: > > > Fix memset argument order: The second argument is > > the value, the length goes last. > > Impact of the bug? Well, this is a memory e

[PATCH] hw/acpi/erst.c: Fix memset argument order

Fix memset argument order: The second argument is the value, the length goes last. Cc: Eric DeVolder Cc: qemu-sta...@nongnu.org Fixes: f7e26ffa590 ("ACPI ERST: support for ACPI ERST feature") Signed-off-by: Christian A. Ehrhardt --- hw/acpi/erst.c | 2 +- 1 file changed, 1 inser

Re: [PATCH] fw_cfg: Don't set callback_opaque NULL in fw_cfg_modify_bytes_read()

Hi, Shameer: Thanks for bringing this to my attention. Some comments inline. On Tue, Aug 30, 2022 at 06:43:56AM +, Shameerali Kolothum Thodi wrote: > > > > -Original Message- > > From: Shameerali Kolothum Thodi > > Sent: 26 August 2022 13:15 > > To: 'Laszlo Ersek' ; qemu-devel@no

fwcfg: Wrong callback behaviour after fw_cfg_modify_bytes_read

Hi, there's a long story behind this (see below). However, I'll start with the result: fw_cfg_modify_bytes_read() sets the callback data of an existing fw_cfg file to NULL but leaves the actual callbacks in place. Additioanlly, this function sets ->allow_write to false for no good reason AFAICS