[Qemu-devel] [PATCH] MAINTAINERS: update Wen's email address

2017-04-17 Thread Changlong Xie
So he can get CC'ed on future patches and bugs for this feature Signed-off-by: Changlong Xie --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index c60235e..5638992 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1817,7 +1817,7

[Qemu-devel] [PATCH V1] replication: clarify permissions

2017-03-14 Thread Changlong Xie
x27;colo-disk', 'writable': true } } {"error": {"class": "GenericError", "desc": "Conflicts with use by hidden-qcow2-driver as 'backing', which does not allow 'write' on sec-qcow2-driver-for-nbd"}} CC: Zhang Hail

Re: [Qemu-devel] [PATCH RFC v2 4/6] replication: fix code logic with the new shared_disk option

2016-12-20 Thread Changlong Xie
On 12/05/2016 04:35 PM, zhanghailiang wrote: Some code logic only be needed in non-shared disk, here we adjust these codes to prepare for shared disk scenario. Signed-off-by: zhanghailiang --- block/replication.c | 47 --- 1 file changed, 28 insert

Re: [Qemu-devel] [PATCH RFC v2 3/6] replication: Split out backup_do_checkpoint() from secondary_do_checkpoint()

2016-12-20 Thread Changlong Xie
condary_disk->bs->job, &local_err); +if (local_err) { +error_propagate(errp, local_err); +break; +} secondary_do_checkpoint(s, errp); +break; + default: +abort(); } aio_context_release(aio_context); } Looks good to me Reviewed-by: Changlong Xie

Re: [Qemu-devel] [PATCH RFC v2 2/6] replication: add shared-disk and shared-disk-id options

2016-12-20 Thread Changlong Xie
On 12/05/2016 04:35 PM, zhanghailiang wrote: diff --git a/qapi/block-core.json b/qapi/block-core.json index c29bef7..52d7e0d 100644 --- a/qapi/block-core.json +++ b/qapi/block-core.json @@ -2232,12 +2232,19 @@ # node who owns the replication node chain. Must not be given in #

Re: [Qemu-devel] [PATCH RFC v2 1/6] docs/block-replication: Add description for shared-disk case

2016-12-20 Thread Changlong Xie
;: 'inet', +'data': { +'host': '0', +'port': 'yyy' + } +} + } + } +2. { 'execute': 'nbd-server-add', + 'arguments': { +'device': 'hidden_disk0', +'writable': true +} + } + +After Failover: +Primary: + { 'execute': 'x-blockdev-del', +'arguments': { +'node-name': 'rep' +} + } + +Secondary: + {'execute': 'nbd-server-stop' } + TODO: 1. Continuous block replication -2. Shared disk Looks good to me Reviewed-by: Changlong Xie

Re: [Qemu-devel] [PATCH RFC 1/7] docs/block-replication: Add description for shared-disk case

2016-11-27 Thread Changlong Xie
On 11/28/2016 01:13 PM, Hailiang Zhang wrote: On 2016/10/25 17:03, Changlong Xie wrote: On 10/20/2016 09:57 PM, zhanghailiang wrote: Introuduce the scenario of shared-disk block replication and how to use it. Signed-off-by: zhanghailiang Signed-off-by: Wen Congyang Signed-off-by: Zhang

Re: [Qemu-devel] [PATCH] docs/block-replication.txt: Introduce nbd qmp commands

2016-11-07 Thread Changlong Xie
On 11/07/2016 03:50 PM, Markus Armbruster wrote: Changlong Xie writes: Signed-off-by: Changlong Xie --- docs/block-replication.txt | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/docs/block-replication.txt b/docs/block-replication.txt index

[Qemu-devel] [PATCH] tests/.gitignore: Ignore test-char

2016-11-06 Thread Changlong Xie
Signed-off-by: Changlong Xie --- tests/.gitignore | 1 + 1 file changed, 1 insertion(+) diff --git a/tests/.gitignore b/tests/.gitignore index c0d7857..e9b182e 100644 --- a/tests/.gitignore +++ b/tests/.gitignore @@ -16,6 +16,7 @@ test-bitops test-blockjob test-blockjob-txn test-bufferiszero

[Qemu-devel] [PATCH] docs/block-replication.txt: Introduce nbd qmp commands

2016-11-06 Thread Changlong Xie
Signed-off-by: Changlong Xie --- docs/block-replication.txt | 22 +- 1 file changed, 17 insertions(+), 5 deletions(-) diff --git a/docs/block-replication.txt b/docs/block-replication.txt index 6bde673..6b9c77b 100644 --- a/docs/block-replication.txt +++ b/docs/block

Re: [Qemu-devel] [PATCH RFC 0/7] COLO block replication supports shared disk case

2016-10-25 Thread Changlong Xie
I did't review p5/p6, I think you can merge p5/p6 into a single one. Also don't forget update qapi/block-core.json with p3. Thanks -Xie On 10/20/2016 09:57 PM, zhanghailiang wrote: COLO block replication doesn't support the shared disk case, Here we try to implement it. Just as the sce

Re: [Qemu-devel] [PATCH RFC 3/7] replication: add shared-disk and shared-disk-id options

2016-10-25 Thread Changlong Xie
On 10/20/2016 09:57 PM, zhanghailiang wrote: We use these two options to identify which disk is shared Signed-off-by: zhanghailiang Signed-off-by: Wen Congyang Signed-off-by: Zhang Chen --- block/replication.c | 33 + 1 file changed, 33 insertions(+) diff -

Re: [Qemu-devel] [PATCH RFC 4/7] replication: Split out backup_do_checkpoint() from secondary_do_checkpoint()

2016-10-25 Thread Changlong Xie
On 10/20/2016 09:57 PM, zhanghailiang wrote: The helper backup_do_checkpoint() will be used for primary related codes. Here we split it out from secondary_do_checkpoint(). Besides, it is unnecessary to call backup_do_checkpoint() in replication starting and normally stop replication path. This

Re: [Qemu-devel] [PATCH RFC 3/7] replication: add shared-disk and shared-disk-id options

2016-10-25 Thread Changlong Xie
On 10/20/2016 09:57 PM, zhanghailiang wrote: We use these two options to identify which disk is shared Signed-off-by: zhanghailiang Signed-off-by: Wen Congyang Signed-off-by: Zhang Chen --- block/replication.c | 33 + 1 file changed, 33 insertions(+) diff -

Re: [Qemu-devel] [PATCH RFC 2/7] block-backend: Introduce blk_root() helper

2016-10-25 Thread Changlong Xie
I know you need blk->root in the next patch, but we strongly don't recommend your current solution. Please refer Kevin's cf2ab8fc 1409 /* XXX Ugly way to get blk->root, but that's a feature, not a bug. This 1410 * hack makes it obvious that vhdx_write_header() bypasses the BlockBacke

Re: [Qemu-devel] [PATCH RFC 1/7] docs/block-replication: Add description for shared-disk case

2016-10-25 Thread Changlong Xie
On 10/20/2016 09:57 PM, zhanghailiang wrote: Introuduce the scenario of shared-disk block replication and how to use it. Signed-off-by: zhanghailiang Signed-off-by: Wen Congyang Signed-off-by: Zhang Chen --- docs/block-replication.txt | 131 +++-- 1

Re: [Qemu-devel] [PATCH] nbd: Use CoQueue for free_sema instead of CoMutex

2016-10-24 Thread Changlong Xie
On 10/24/2016 05:36 PM, Paolo Bonzini wrote: On 24/10/2016 03:44, Changlong Xie wrote: Ping. Any comments? It's really a problem for NBD. Sorry, I haven't been sending pull requests. I'll do it this week. Thanks : ) Paolo Thanks -Xie On 10/12/2016 06:18 PM, Chan

Re: [Qemu-devel] [PATCH] nbd: Use CoQueue for free_sema instead of CoMutex

2016-10-23 Thread Changlong Xie
Ping. Any comments? It's really a problem for NBD. Thanks -Xie On 10/12/2016 06:18 PM, Changlong Xie wrote: NBD is using the CoMutex in a way that wasn't anticipated. For example, if there are N(N=26, MAX_NBD_REQUESTS=16) nbd write requests, so we will invoke nbd_client_co

Re: [Qemu-devel] [PATCH] nbd: Use CoQueue for free_sema instead of CoMutex

2016-10-12 Thread Changlong Xie
On 10/12/2016 06:18 PM, Changlong Xie wrote: time request Actions 29 15(most case) in_flight=15, Coroutine=C15, free_sema->holder=C17, mutex->locked

[Qemu-devel] [PATCH] nbd: Use CoQueue for free_sema instead of CoMutex

2016-10-12 Thread Changlong Xie
;locked=false Per Paolo's suggestion "The simplest fix is to change it to CoQueue, which is like a condition variable", this patch replaces CoMutex with CoQueue. Cc: Wen Congyang Reported-by: zhan

Re: [Qemu-devel] [PATCH] replication: interrupt failover if the main device is closed

2016-10-11 Thread Changlong Xie
-by: Paolo Bonzini Reviewed-by: Changlong Xie --- block/replication.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/block/replication.c b/block/replication.c index 3bd1cf1..5231a00 100644 --- a/block/replication.c +++ b/block/replication.c @@ -133,6 +133,9 @@ static void

[Qemu-devel] [PATCH v3] block/replication: Clarify 'top-id' parameter usage

2016-10-11 Thread Changlong Xie
The replication driver only supports the 'top-id' parameter for the secondary side; it must not be supplied for the primary side. Reviewed-by: Eric Blake Signed-off-by: Changlong Xie --- block/replication.c | 5 + qapi/block-core.json | 3 ++- 2 files changed, 7 insertions(+),

Re: [Qemu-devel] [Questions] NBD issue or CoMutex->holder issue?

2016-10-11 Thread Changlong Xie
On 10/11/2016 06:47 PM, Paolo Bonzini wrote: the free_sema->queue head, so set free_sema->holder as >revelant coroutine. NBD is using the CoMutex in a way that wasn't anticipated. The simplest fix is to change it to CoQueue, which is like a condition variable. Instead of locking if in_flight >=

Re: [Qemu-devel] [PATCH v2 2/2] block/replication: Clarify 'top-id' parameter usage

2016-10-11 Thread Changlong Xie
On 10/11/2016 10:54 PM, Eric Blake wrote: The replication driver only supports the 'top-id' parameter for the secondary side; it must not be supplied for the primary side. Will apply in next version. Thanks -Xie

Re: [Qemu-devel] [PATCH v2 1/2] block/replication: prefect the logic to acquire 'top_id'

2016-10-11 Thread Changlong Xie
On 10/11/2016 10:52 PM, Eric Blake wrote: On 10/11/2016 05:46 AM, Changlong Xie wrote: Only g_strdup(top_id) if 'top_id' is not NULL, although there is no memory leak here Signed-off-by: Changlong Xie --- block/replication.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletion

[Qemu-devel] [PATCH v2 1/2] block/replication: prefect the logic to acquire 'top_id'

2016-10-11 Thread Changlong Xie
Only g_strdup(top_id) if 'top_id' is not NULL, although there is no memory leak here Signed-off-by: Changlong Xie --- block/replication.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/replication.c b/block/replication.c index 3bd1cf1..5b432d9 100644 -

[Qemu-devel] [PATCH v2 0/2] block/replication fixes

2016-10-11 Thread Changlong Xie
V2: 1. fix typo Changlong Xie (2): block/replication: prefect the logic to acquire 'top_id' block/replication: Clarify 'top-id' parameter usage block/replication.c | 9 +++-- qapi/block-core.json | 3 ++- 2 files changed, 9 insertions(+), 3 deletions(-) -- 1.9.3

[Qemu-devel] [PATCH v2 2/2] block/replication: Clarify 'top-id' parameter usage

2016-10-11 Thread Changlong Xie
Replication driver only support 'top-id' parameter in secondary side, and it must not be supplied in primary side Signed-off-by: Changlong Xie --- block/replication.c | 5 + qapi/block-core.json | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/block/repli

Re: [Qemu-devel] [PATCH v1 2/2] block/replication: Clarify 'top-id' parameter usage

2016-10-11 Thread Changlong Xie
On 10/11/2016 02:30 PM, Fam Zheng wrote: On Tue, 10/11 13:39, Changlong Xie wrote: Replication driver only support 'top-id' parameter in secondary side, and it must not be supplied in primary side Signed-off-by: Changlong Xie --- block/replication.c | 5 + qapi/block-cor

[Qemu-devel] [Questions] NBD issue or CoMutex->holder issue?

2016-10-11 Thread Changlong Xie
Hi all Recently during test COLO, i encounter some problems. Here is the backtrace qemu-system-x86_64: util/qemu-coroutine-lock.c:148: qemu_co_mutex_unlock: Assertion `mutex->holder == self' failed. [New Thread 0x7fff0e7fc700 (LWP 20936)] Program received signal SIGABRT, Aborted. 0x75

[Qemu-devel] [PATCH v1 1/2] block/replication: prefect the logic to acquire 'top_id'

2016-10-10 Thread Changlong Xie
Only g_strdup(top_id) if 'top_id' is not NULL, although there is no memory leak here Signed-off-by: Changlong Xie --- block/replication.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/block/replication.c b/block/replication.c index 3bd1cf1..5b432d9 100644 -

[Qemu-devel] [PATCH v1 0/2] block/replication fixes

2016-10-10 Thread Changlong Xie
Changlong Xie (2): block/replication: prefect the logic to acquire 'top_id' block/replication: Clarify 'top-id' parameter usage block/replication.c | 9 +++-- qapi/block-core.json | 3 ++- 2 files changed, 9 insertions(+), 3 deletions(-) -- 1.9.3

[Qemu-devel] [PATCH v1 2/2] block/replication: Clarify 'top-id' parameter usage

2016-10-10 Thread Changlong Xie
Replication driver only support 'top-id' parameter in secondary side, and it must not be supplied in primary side Signed-off-by: Changlong Xie --- block/replication.c | 5 + qapi/block-core.json | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) diff --git a/block/repli

[Qemu-devel] [PATCH] filter-dump: add missing "["

2016-10-10 Thread Changlong Xie
Signed-off-by: Changlong Xie --- qemu-options.hx | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/qemu-options.hx b/qemu-options.hx index b1fbdb0..c209b53 100644 --- a/qemu-options.hx +++ b/qemu-options.hx @@ -3902,7 +3902,7 @@ colo secondary: -object filter-redirector,id=f2

Re: [Qemu-devel] [PATCH COLO-Frame v18 00/34] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-08-16 Thread Changlong Xie
On 08/17/2016 12:05 PM, Zhi Yong Wu wrote: HI Can you update http://wiki.qemu.org/Features/COLO and block-replication.txt? Recently i had a try, but failed. By the way, I will update both of them later. QEMU was built based on https://github.com/coloft/qemu/commits/colo-v3.1-periodic-mode.

Re: [Qemu-devel] [PATCH COLO-Frame v18 00/34] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-08-15 Thread Changlong Xie
On 08/03/2016 08:25 PM, zhanghailiang wrote: It is based on '[PATCH v24 00/12] Block replication for continuous checkpoints' series. The complete codes can be found from the link: https://github.com/coloft/qemu/commits/colo-v3.1-periodic-mode 404 NOT FOUND. Would you like to upload it again :)

Re: [Qemu-devel] [PATCH v24 11/12] support replication driver in blockdev-add

2016-08-15 Thread Changlong Xie
On 08/15/2016 04:37 PM, Kevin Wolf wrote: Am 15.08.2016 um 03:49 hat Changlong Xie geschrieben: On 08/09/2016 05:08 PM, Kevin Wolf wrote: Am 27.07.2016 um 09:01 hat Changlong Xie geschrieben: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang

Re: [Qemu-devel] [PATCH v24 11/12] support replication driver in blockdev-add

2016-08-14 Thread Changlong Xie
On 08/09/2016 05:08 PM, Kevin Wolf wrote: Am 27.07.2016 um 09:01 hat Changlong Xie geschrieben: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei Signed-off-by: zhanghailiang Signed-off-by: Gonglei Reviewed-by: Eric Blake

[Qemu-devel] [PATCH] virtio-blk: rename virtio_device_info to virtio_blk_info

2016-08-03 Thread Changlong Xie
The old one is confusing with @virtio_device_info in virtio.c, so make it more appropriate. Signed-off-by: Changlong Xie --- hw/block/virtio-blk.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/block/virtio-blk.c b/hw/block/virtio-blk.c index 475a822..a3a9e63 100644

Re: [Qemu-devel] [PATCH COLO-Frame v17 00/34] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-07-28 Thread Changlong Xie
On 07/29/2016 08:41 AM, Hailiang Zhang wrote: On 2016/7/29 3:07, Dr. David Alan Gilbert wrote: * zhanghailiang (zhang.zhanghaili...@huawei.com) wrote: This is the 17th version of COLO FT feature. Here is only COLO frame part, you can get the whole codes from github: https://github.com/coloft/q

[Qemu-devel] [PATCH v24 08/12] Introduce new APIs to do replication operation

2016-07-27 Thread Changlong Xie
please refer to replication.h Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- Makefile.objs| 1 + qapi/block-core.json | 13 replication.c| 107

[Qemu-devel] [PATCH v24 10/12] tests: add unit test case for replication

2016-07-27 Thread Changlong Xie
Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei --- tests/.gitignore | 1 + tests/Makefile.include | 4 + tests/test-replication.c | 575 +++ 3 files changed, 580 insertions(+) create mode 100644

[Qemu-devel] [PATCH v24 11/12] support replication driver in blockdev-add

2016-07-27 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei Signed-off-by: zhanghailiang Signed-off-by: Gonglei Reviewed-by: Eric Blake --- qapi/block-core.json | 23 +-- 1 file changed, 21 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH v24 12/12] MAINTAINERS: add maintainer for replication

2016-07-27 Thread Changlong Xie
As per Stefan's suggestion, add Wen and I as co-maintainers of replication. Cc: Stefan Hajnoczi Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 1d0e2c3..25b9438 100644

[Qemu-devel] [PATCH v24 03/12] Backup: export interfaces for extra serialization

2016-07-27 Thread Changlong Xie
} ret = bdrv_co_readv(); out: return ret; } Signed-off-by: Changlong Xie Signed-off-by: Wen Congyang Signed-off-by: Wang WeiWei --- block/backup.c | 41 ++--- include/block/block_backup.h | 14 ++ 2 files changed,

[Qemu-devel] [PATCH v24 07/12] configure: support replication

2016-07-27 Thread Changlong Xie
configure --(enable/disable)-replication to switch replication support on/off, and it is on by default. We later introduce replation support. Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei --- configure | 11 +++ 1 file changed, 11 insertions

[Qemu-devel] [PATCH v24 05/12] docs: block replication's description

2016-07-27 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- docs/block-replication.txt | 239 + 1 file changed, 239 insertions(+) create mode

[Qemu-devel] [PATCH v24 00/12] Block replication for continuous checkpoints

2016-07-27 Thread Changlong Xie
en if there are too many I/O requests. V4: 1. Introduce a new driver replication to avoid touch nbd and qcow2. V3: 1: use error_setg() instead of error_set() 2. Add a new block job API 3. Active disk, hidden disk and nbd target uses the same AioContext 4. Add a testcase to test new hbitmap API V2

[Qemu-devel] [PATCH v24 02/12] Backup: clear all bitmap when doing block checkpoint

2016-07-27 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block/backup.c | 18 ++ include/block/block_backup.h | 25 + 2 files changed

[Qemu-devel] [PATCH v24 06/12] auto complete active commit

2016-07-27 Thread Changlong Xie
From: Wen Congyang Auto complete mirror job in background to prevent from blocking synchronously Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei --- block/mirror.c| 13 + blockdev.c| 2 +- include/block/block_int.h

[Qemu-devel] [PATCH v24 09/12] Implement new driver for block replication

2016-07-27 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block/Makefile.objs | 1 + block/replication.c | 659 2 files changed, 660

[Qemu-devel] [PATCH v24 04/12] Link backup into block core

2016-07-27 Thread Changlong Xie
From: Wen Congyang Some programs that add a dependency on it will use the block layer directly. Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei Signed-off-by: zhanghailiang Signed-off-by: Gonglei Reviewed-by: Stefan Hajnoczi Reviewed-by: Jeff Cody

[Qemu-devel] [PATCH v24 01/12] unblock backup operations in backing file

2016-07-27 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei --- block.c | 17 + 1 file changed, 17 insertions(+) diff --git a/block.c b/block.c index 9f037db..63e4636 100644 --- a/block.c +++ b/block.c @@ -1310,6 +1310,23 @@ void

Re: [Qemu-devel] [PATCH v23 12/12] MAINTAINERS: add maintainer for replication

2016-07-26 Thread Changlong Xie
liation" is good for me. >+M: Wen Congyang >+M: Changlong Xie >+S: Supported >+F: replication* >+F: block/replication.c >+F: test/test-replication.c docs/block-replication.txt should probably be mentioned as well. Surely Max >+ > Build and test automation > - > M: Alex Bennée >

Re: [Qemu-devel] [PATCH v23 11/12] support replication driver in blockdev-add

2016-07-26 Thread Changlong Xie
On 07/27/2016 12:22 AM, Max Reitz wrote: On 26.07.2016 10:15, Changlong Xie wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei Signed-off-by: zhanghailiang Signed-off-by: Gonglei Reviewed-by: Eric Blake --- qapi/block

Re: [Qemu-devel] [PATCH v23 09/12] Implement new driver for block replication

2016-07-26 Thread Changlong Xie
On 07/27/2016 12:17 AM, Max Reitz wrote: On 26.07.2016 10:15, Changlong Xie wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block/Makefile.objs | 1 + block

[Qemu-devel] [PATCH v23 11/12] support replication driver in blockdev-add

2016-07-26 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei Signed-off-by: zhanghailiang Signed-off-by: Gonglei Reviewed-by: Eric Blake --- qapi/block-core.json | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff

[Qemu-devel] [PATCH v23 10/12] tests: add unit test case for replication

2016-07-26 Thread Changlong Xie
Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei --- tests/.gitignore | 1 + tests/Makefile.include | 4 + tests/test-replication.c | 575 +++ 3 files changed, 580 insertions(+) create mode 100644

[Qemu-devel] [PATCH v23 05/12] docs: block replication's description

2016-07-26 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- docs/block-replication.txt | 239 + 1 file changed, 239 insertions(+) create mode

[Qemu-devel] [PATCH v23 07/12] configure: support replication

2016-07-26 Thread Changlong Xie
configure --(enable/disable)-replication to switch replication support on/off, and it is on by default. We later introduce replation support. Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei --- configure | 11 +++ 1 file changed, 11 insertions

[Qemu-devel] [PATCH v23 12/12] MAINTAINERS: add maintainer for replication

2016-07-26 Thread Changlong Xie
As per Stefan's suggestion, add Wen and I as co-maintainers of replication. Cc: Stefan Hajnoczi Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index d1439a8..8fa2a25 100644

[Qemu-devel] [PATCH v23 06/12] auto complete active commit

2016-07-26 Thread Changlong Xie
From: Wen Congyang Auto complete mirror job in background to prevent from blocking synchronously Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei --- block/mirror.c| 13 + blockdev.c| 2 +- include/block/block_int.h

[Qemu-devel] [PATCH v23 09/12] Implement new driver for block replication

2016-07-26 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block/Makefile.objs | 1 + block/replication.c | 658 2 files changed, 659

[Qemu-devel] [PATCH v23 04/12] Link backup into block core

2016-07-26 Thread Changlong Xie
From: Wen Congyang Some programs that add a dependency on it will use the block layer directly. Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei Signed-off-by: zhanghailiang Signed-off-by: Gonglei Reviewed-by: Stefan Hajnoczi Reviewed-by: Jeff Cody

[Qemu-devel] [PATCH v23 08/12] Introduce new APIs to do replication operation

2016-07-26 Thread Changlong Xie
please refer to replication.h Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- Makefile.objs| 1 + qapi/block-core.json | 13 replication.c| 107

[Qemu-devel] [PATCH v23 03/12] Backup: export interfaces for extra serialization

2016-07-26 Thread Changlong Xie
} ret = bdrv_co_readv(); out: return ret; } Signed-off-by: Changlong Xie Signed-off-by: Wen Congyang Signed-off-by: Wang WeiWei --- block/backup.c | 41 ++--- include/block/block_backup.h | 14 ++ 2 files changed,

[Qemu-devel] [PATCH v23 00/12] Block replication for continuous checkpoints

2016-07-26 Thread Changlong Xie
ce a new driver replication to avoid touch nbd and qcow2. V3: 1: use error_setg() instead of error_set() 2. Add a new block job API 3. Active disk, hidden disk and nbd target uses the same AioContext 4. Add a testcase to test new hbitmap API V2: 1. Redesign the secondary qemu(use image-fleecing) 2. U

[Qemu-devel] [PATCH v23 01/12] unblock backup operations in backing file

2016-07-26 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei --- block.c | 17 + 1 file changed, 17 insertions(+) diff --git a/block.c b/block.c index 30d64e6..194a060 100644 --- a/block.c +++ b/block.c @@ -1311,6 +1311,23 @@ void

[Qemu-devel] [PATCH v23 02/12] Backup: clear all bitmap when doing block checkpoint

2016-07-26 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei Signed-off-by: zhanghailiang Signed-off-by: Gonglei --- block/backup.c | 18 ++ include/block/block_backup.h | 25 + 2 files changed

Re: [Qemu-devel] [PATCH v22 00/10] Block replication for continuous checkpoints

2016-07-25 Thread Changlong Xie
On 07/25/2016 10:34 PM, Stefan Hajnoczi wrote: On Mon, Jul 25, 2016 at 11:44:34AM +0800, Changlong Xie wrote: COLO block is the necessary prerequisite of COLO framework and COLO network, what are blocked by these patchsets now. Since v19, Stefan said he had reviewed most part of this patchsets

Re: [Qemu-devel] [PATCH v22 10/10] support replication driver in blockdev-add

2016-07-25 Thread Changlong Xie
On 07/26/2016 07:00 AM, Max Reitz wrote: On 22.07.2016 12:16, Wang WeiWei wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Eric Blake Signed-off-by: Wang WeiWei --- qapi/block-core.json

Re: [Qemu-devel] [PATCH v22 07/10] Introduce new APIs to do replication operation

2016-07-25 Thread Changlong Xie
On 07/26/2016 06:23 AM, Max Reitz wrote: +# @primary: Primary mode, the vm's state will be sent to secondary QEMU. >+# >+# @secondary: Secondary mode, receive the vm's state from primary QEMU. >+# >+# Since: 2.7 Probably 2.8 now. I'll update 2.7 to 2.8 for all these series Max

Re: [Qemu-devel] [PATCH v22 03/10] Backup: export interfaces for extra serialization

2016-07-25 Thread Changlong Xie
On 07/26/2016 05:50 AM, Max Reitz wrote: On 22.07.2016 12:16, Wang WeiWei wrote: From: Changlong Xie Normal backup(sync='none') workflow: step 1. NBD peformance I/O write from client to server qcow2_co_writev bdrv_co_writev ... bdrv_align

Re: [Qemu-devel] [PATCH v22 02/10] Backup: clear all bitmap when doing block checkpoint

2016-07-25 Thread Changlong Xie
On 07/26/2016 05:18 AM, Max Reitz wrote: On 22.07.2016 12:15, Wang WeiWei wrote: From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Signed-off-by: Wang WeiWei --- block/backup.c | 18

[Qemu-devel] [PATCH v2] hw/net/e1000e: Fix compiler warning

2016-07-24 Thread Changlong Xie
declaration of ‘e1000e_set_interrupt_cause’ was here LINK x86_64-softmmu/qemu-system-x86_64 Reviewed-by: Dmitry Fleytman Signed-off-by: Changlong Xie --- hw/net/e1000e_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index

[Qemu-devel] [PATCH] hw/net/e1000: Fix compiler warning

2016-07-24 Thread Changlong Xie
declaration of ‘e1000e_set_interrupt_cause’ was here LINK x86_64-softmmu/qemu-system-x86_64 Signed-off-by: Changlong Xie --- hw/net/e1000e_core.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/e1000e_core.c b/hw/net/e1000e_core.c index badb1fe..e0bd31c 100644 --- a

Re: [Qemu-devel] [PATCH v22 00/10] Block replication for continuous checkpoints

2016-07-24 Thread Changlong Xie
new driver replication to avoid touch nbd and qcow2. V3: 1: use error_setg() instead of error_set() 2. Add a new block job API 3. Active disk, hidden disk and nbd target uses the same AioContext 4. Add a testcase to test new hbitmap API V2: 1. Redesign the secondary qemu(use image-fleecing) 2. Use Err

Re: [Qemu-devel] [PULL 15/15] translate-all: add tb hash bucket info to 'info jit' dump

2016-07-22 Thread Changlong Xie
On 06/10/2016 10:26 PM, Richard Henderson wrote: From: "Emilio G. Cota" Examples: - Good hashing, i.e. tb_hash_func5(phys_pc, pc, flags): TB count715135/2684354 [...] TB hash buckets 388775/524288 (74.15% head buckets used) TB hash occupancy 33.04% avg chain occ. Histogram: [

[Qemu-devel] [PATCH] checkpatch: rename README to README.md

2016-07-20 Thread Changlong Xie
Since commit e5dfc5e broke the logic of @top_of_kernel_tree Cc: Pranith Kumar Cc: Paolo Bonzini Cc: Stefan Hajnoczi Signed-off-by: Changlong Xie --- scripts/checkpatch.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/checkpatch.pl b/scripts/checkpatch.pl index

Re: [Qemu-devel] [PATCH] qom/object: fix comment typo

2016-07-06 Thread Changlong Xie
On 07/06/2016 03:21 PM, Andreas Färber wrote: Am 06.07.2016 um 07:52 schrieb Changlong Xie: Would any maintainer pick this one? Please in the future use just "qom:" in the subject. How to find out? Ok git log --oneline -- include/qom/object.h Useful git command, i'll ad

[Qemu-devel] [PATCH v21 07/10] Introduce new APIs to do replication operation

2016-07-05 Thread Changlong Xie
please refer to replication.h Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- Makefile.objs| 1 + qapi/block-core.json | 13 replication.c| 107 +++ replication.h| 174

[Qemu-devel] [PATCH v21 05/10] docs: block replication's description

2016-07-05 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- docs/block-replication.txt | 239 + 1 file changed, 239 insertions(+) create mode 100644 docs/block

[Qemu-devel] [PATCH v21 06/10] auto complete active commit

2016-07-05 Thread Changlong Xie
From: Wen Congyang Auto complete mirror job in background to prevent from blocking synchronously Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- block/mirror.c| 13 + blockdev.c| 2 +- include/block/block_int.h | 3 ++- qemu-img.c

Re: [Qemu-devel] [PATCH] qom/object: fix comment typo

2016-07-05 Thread Changlong Xie
Would any maintainer pick this one? On 06/14/2016 03:27 PM, Changlong Xie wrote: Signed-off-by: Changlong Xie --- include/qom/object.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/qom/object.h b/include/qom/object.h index 99de539..925c279 100644 --- a/include

[Qemu-devel] [PATCH v21 03/10] Backup: export interfaces for extra serialization

2016-07-05 Thread Changlong Xie
} ret = bdrv_co_readv(); out: return ret; } Signed-off-by: Changlong Xie Signed-off-by: Wen Congyang --- block/backup.c | 41 ++--- include/block/block_backup.h | 14 ++ 2 files changed, 48 insertions(+), 7 deletions(-)

[Qemu-devel] [PATCH v21 09/10] tests: add unit test case for replication

2016-07-05 Thread Changlong Xie
Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- tests/.gitignore | 1 + tests/Makefile.include | 4 + tests/test-replication.c | 557 +++ 3 files changed, 562 insertions(+) create mode 100644 tests/test-replication.c diff

[Qemu-devel] [PATCH v21 10/10] support replication driver in blockdev-add

2016-07-05 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Eric Blake --- qapi/block-core.json | 20 ++-- 1 file changed, 18 insertions(+), 2 deletions(-) diff --git a/qapi/block-core.json b

[Qemu-devel] [PATCH v21 04/10] Link backup into block core

2016-07-05 Thread Changlong Xie
From: Wen Congyang Some programs that add a dependency on it will use the block layer directly. Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie Reviewed-by: Stefan Hajnoczi Reviewed-by: Jeff Cody --- block/Makefile.objs | 2

[Qemu-devel] [PATCH v21 02/10] Backup: clear all bitmap when doing block checkpoint

2016-07-05 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block/backup.c | 18 ++ include/block/block_backup.h | 3 +++ 2 files changed, 21 insertions(+) create mode 100644 include

[Qemu-devel] [PATCH v21 08/10] Implement new driver for block replication

2016-07-05 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: zhanghailiang Signed-off-by: Gonglei Signed-off-by: Changlong Xie --- block/Makefile.objs | 1 + block/replication.c | 657 2 files changed, 658 insertions(+) create mode

[Qemu-devel] [PATCH v21 00/10] Block replication for continuous checkpoints

2016-07-05 Thread Changlong Xie
lock job API 3. Active disk, hidden disk and nbd target uses the same AioContext 4. Add a testcase to test new hbitmap API V2: 1. Redesign the secondary qemu(use image-fleecing) 2. Use Error objects to return error message 3. Address the comments from Max Reitz and Eric Blake Changlong Xie (3): Ba

[Qemu-devel] [PATCH v21 01/10] unblock backup operations in backing file

2016-07-05 Thread Changlong Xie
From: Wen Congyang Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- block.c | 17 + 1 file changed, 17 insertions(+) diff --git a/block.c b/block.c index f4648e9..f7e7e43 100644 --- a/block.c +++ b/block.c @@ -1309,6 +1309,23 @@ void bdrv_set_backing_hd

Re: [Qemu-devel] [PATCH] json-streamer: fix double-free on exiting during a parse

2016-07-05 Thread Changlong Xie
eue earlier, so that it is already in place when the old one is passed to parser->emit. Reported-by: Changlong Xie Signed-off-by: Paolo Bonzini Two meta questions: Is there a reproducer and/or test case coverage? tests/qemu-iotests/071 Does qemu-stable need this? http://lists.nong

Re: [Qemu-devel] [PATCH] json-streamer: Don't leak tokens on incomplete parse

2016-07-04 Thread Changlong Xie
On 05/19/2016 05:46 AM, Eric Blake wrote: Valgrind complained about a number of leaks in tests/check-qobject-json: ==12657==definitely lost: 17,247 bytes in 1,234 blocks All of which had the same root cause: on an incomplete parse, we were abandoning the token queue without cleaning up the

Re: [Qemu-devel] [PATCH v20 Resend 09/10] tests: add unit test case for replication

2016-07-03 Thread Changlong Xie
On 06/14/2016 03:53 PM, Changlong Xie wrote: Signed-off-by: Wen Congyang Signed-off-by: Changlong Xie --- tests/.gitignore | 1 + tests/Makefile | 4 + tests/test-replication.c | 555 +++ 3 files changed, 560 insertions

Re: [Qemu-devel] [PATCH] dirty-bitmap: remove unnecessary return

2016-06-30 Thread Changlong Xie
On 07/01/2016 02:18 AM, John Snow wrote: On 06/30/2016 10:00 AM, Jeff Cody wrote: On Thu, Jun 30, 2016 at 04:45:52PM +0800, Changlong Xie wrote: On 06/30/2016 04:25 PM, Fam Zheng wrote: On Thu, 06/30 16:01, Changlong Xie wrote: Otherwise, we could never trigger assert(!bitmap->succes

Re: [Qemu-devel] [PATCH] dirty-bitmap: remove unnecessary return

2016-06-30 Thread Changlong Xie
On 06/30/2016 04:25 PM, Fam Zheng wrote: On Thu, 06/30 16:01, Changlong Xie wrote: Otherwise, we could never trigger assert(!bitmap->successor) Signed-off-by: Changlong Xie --- block/dirty-bitmap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/dirty-bitmap.c b/block/di

[Qemu-devel] [PATCH] dirty-bitmap: remove unnecessary return

2016-06-30 Thread Changlong Xie
Otherwise, we could never trigger assert(!bitmap->successor) Signed-off-by: Changlong Xie --- block/dirty-bitmap.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/dirty-bitmap.c b/block/dirty-bitmap.c index 4902ca5..e9df5ac 100644 --- a/block/dirty-bitmap.c +++ b/block/dirty-bitma

Re: [Qemu-devel] [PATCH v6 0/1] Introduce "xen-load-devices-state"

2016-06-30 Thread Changlong Xie
Would any migration maintainer pick this patch or give some comments? Thanks -Xie On 06/03/2016 05:58 PM, Changlong Xie wrote: Changelog v6: 1. Fix channel open flag v5: 1. Introduce qio channel since 8925839f v4: 1. Rebased to the lastest code v3: 1. Addressed on David's commets

[Qemu-devel] [PATCH v2 1/2] blockjob: assert(cb) when create job

2016-06-23 Thread Changlong Xie
Callback for block job should always exist Suggested-by: Paolo Bonzini Suggested-by: Kevin Wolf Signed-off-by: Changlong Xie --- block/backup.c | 1 - blockjob.c | 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/block/backup.c b/block/backup.c index 581269b..f87f8d5

  1   2   3   4   >