[PATCH v6 0/4] hw/ssi/pnv_spi: Remove PnvXferBuffer and other improvements

2025-03-03 Thread Chalapathi V
;t get caught in an infinite execution loop querying the responder for RDR match. Tested: passed make check and make check-avocado Chalapathi V (4): hw/ssi/pnv_spi: Replace PnvXferBuffer with Fifo8 structure hw/ssi/pnv_spi: Use local var seq_index instead of get_seq_index(). hw/ssi/pnv_

[PATCH v6 1/4] hw/ssi/pnv_spi: Replace PnvXferBuffer with Fifo8 structure

2025-03-03 Thread Chalapathi V
In PnvXferBuffer dynamically allocating and freeing is a process overhead. Hence used an existing Fifo8 buffer with capacity of 16 bytes. Signed-off-by: Chalapathi V --- include/hw/ssi/pnv_spi.h | 3 + hw/ssi/pnv_spi.c | 264 --- 2 files changed

[PATCH v6 2/4] hw/ssi/pnv_spi: Use local var seq_index instead of get_seq_index().

2025-03-03 Thread Chalapathi V
Use a local variable seq_index instead of repeatedly calling get_seq_index() method and open-code next_sequencer_fsm(). Signed-off-by: Chalapathi V Reviewed-by: Nicholas Piggin --- hw/ssi/pnv_spi.c | 97 ++-- 1 file changed, 52 insertions(+), 45

[PATCH v6 4/4] hw/ssi/pnv_spi: Put a limit to RDR match failures

2025-03-03 Thread Chalapathi V
There is a possibility that SPI controller can get into loop due to indefinite RDR match failures. Hence put a limit to failures and stop the sequencer. Signed-off-by: Chalapathi V Reviewed-by: Nicholas Piggin --- include/hw/ssi/pnv_spi.h | 1 + hw/ssi/pnv_spi.c | 10 ++ 2

[PATCH v6 3/4] hw/ssi/pnv_spi: Make bus names distinct for each controllers of a socket

2025-03-03 Thread Chalapathi V
] (pnv-spi) /chip0.spi.0 (SSI) /xscom-spi[0] (memory-region) /chip[1] (power10_v2.0-pnv-chip) /pib_spic[0] (pnv-spi) /chip1.spi.0 (SSI) /xscom-spi[0] (memory-region) Signed-off-by: Chalapathi V --- include/hw/ssi/pnv_spi.h | 3 ++- hw/ppc/pnv.c

Re: [PATCH v5 3/4] hw/ssi/pnv_spi: Make bus names distinct for each controllers of a socket

2025-02-28 Thread Chalapathi V
On 28-02-2025 13:15, Cédric Le Goater wrote: On 2/28/25 04:03, Chalapathi V wrote: On 27-02-2025 07:24, Nicholas Piggin wrote: On Sat Jan 4, 2025 at 2:18 AM AEST, Chalapathi V wrote: Create a spi buses with distict names on each socket so that responders are attached to correct SPI

Re: [PATCH v5 4/4] hw/ssi/pnv_spi: Put a limit to RDR match failures

2025-02-27 Thread Chalapathi V
On 27-02-2025 07:26, Nicholas Piggin wrote: On Sat Jan 4, 2025 at 2:18 AM AEST, Chalapathi V wrote: There is a possibility that SPI controller can get into loop due to indefinite RDR match failures. Hence put a limit to failures and stop the sequencer. Signed-off-by: Chalapathi V --- hw

Re: [PATCH v5 3/4] hw/ssi/pnv_spi: Make bus names distinct for each controllers of a socket

2025-02-27 Thread Chalapathi V
On 27-02-2025 07:24, Nicholas Piggin wrote: On Sat Jan 4, 2025 at 2:18 AM AEST, Chalapathi V wrote: Create a spi buses with distict names on each socket so that responders are attached to correct SPI controllers. QOM tree on a 2 socket machine: (qemu) info qom-tree /machine (powernv10-machine

Re: [PATCH v5 1/4] hw/ssi/pnv_spi: Replace PnvXferBuffer with Fifo8 structure

2025-02-27 Thread Chalapathi V
Hello Nick, Thank You for reviewing this series. On 27-02-2025 07:09, Nicholas Piggin wrote: On Sat Jan 4, 2025 at 2:18 AM AEST, Chalapathi V wrote: In PnvXferBuffer dynamically allocating and freeing is a process overhead. Hence used an existing Fifo8 buffer with capacity of 16 bytes

[PATCH v5 0/4] hw/ssi/pnv_spi: Remove PnvXferBuffer and fix CID 1558827

2025-01-03 Thread Chalapathi V
DR match failures so that SPI controller doesn't get caught in an infinite execution loop querying the responder for RDR match. Tested: passed make check and make check-avocado Chalapathi V (4): hw/ssi/pnv_spi: Replace PnvXferBuffer with Fifo8 structure hw/ssi/pnv_spi: Coverity CID 1558827:

[PATCH v5 2/4] hw/ssi/pnv_spi: Coverity CID 1558827: Use local var seq_index instead of get_seq_index().

2025-01-03 Thread Chalapathi V
Use a local variable seq_index instead of repeatedly calling get_seq_index() method and open-code next_sequencer_fsm(). Signed-off-by: Chalapathi V --- hw/ssi/pnv_spi.c | 93 +--- 1 file changed, 48 insertions(+), 45 deletions(-) diff --git a/hw/ssi

[PATCH v5 3/4] hw/ssi/pnv_spi: Make bus names distinct for each controllers of a socket

2025-01-03 Thread Chalapathi V
) /xscom-spi[0] (memory-region) /chip[1] (power10_v2.0-pnv-chip) /pib_spic[0] (pnv-spi) /chip1.pnv.spi.bus.0 (SSI) /xscom-spi[0] (memory-region) Signed-off-by: Chalapathi V --- include/hw/ssi/pnv_spi.h | 3 ++- hw/ppc/pnv.c | 2 ++ hw/ssi/pnv_spi.c

[PATCH v5 1/4] hw/ssi/pnv_spi: Replace PnvXferBuffer with Fifo8 structure

2025-01-03 Thread Chalapathi V
In PnvXferBuffer dynamically allocating and freeing is a process overhead. Hence used an existing Fifo8 buffer with capacity of 16 bytes. Signed-off-by: Chalapathi V --- include/hw/ssi/pnv_spi.h | 3 + hw/ssi/pnv_spi.c | 237 +-- 2 files changed, 81

[PATCH v5 4/4] hw/ssi/pnv_spi: Put a limit to RDR match failures

2025-01-03 Thread Chalapathi V
There is a possibility that SPI controller can get into loop due to indefinite RDR match failures. Hence put a limit to failures and stop the sequencer. Signed-off-by: Chalapathi V --- hw/ssi/pnv_spi.c | 11 +++ 1 file changed, 11 insertions(+) diff --git a/hw/ssi/pnv_spi.c b/hw/ssi

[PATCH v4 1/2] hw/ssi/pnv_spi: Replace PnvXferBuffer with Fifo8 structure

2024-11-12 Thread Chalapathi V
In PnvXferBuffer dynamically allocating and freeing is a process overhead. Hence used an existing Fifo8 buffer with capacity of 16 bytes. Signed-off-by: Chalapathi V --- include/hw/ssi/pnv_spi.h | 3 + hw/ssi/pnv_spi.c | 237 +-- 2 files changed, 81

[PATCH v4 0/2] hw/ssi/pnv_spi: Remove PnvXferBuffer and fix CID 1558827

2024-11-12 Thread Chalapathi V
er. 2. Use a local variable seq_index and use it with in while loop instead of repeatedly calling get_seq_index() and make sure s->seq_op doesn't overrun when seq_index is incremented. Tested: passed make check and make check-avocado Chalapathi V (2): hw/ssi/pnv_spi: Replace PnvXferBuff

[PATCH v4 2/2] hw/ssi/pnv_spi: Coverity CID 1558827: Use local var seq_index instead of get_seq_index().

2024-11-12 Thread Chalapathi V
Use a local variable seq_index instead of repeatedly calling get_seq_index() method and open-code next_sequencer_fsm(). Signed-off-by: Chalapathi V --- hw/ssi/pnv_spi.c | 93 +--- 1 file changed, 48 insertions(+), 45 deletions(-) diff --git a/hw/ssi

Re: [PATCH-for-9.2 v3 0/3] hw/ssi/pnv_spi: Remove PnvXferBuffer and get_seq_index()

2024-10-08 Thread Chalapathi V
On 08-10-2024 18:14, Cédric Le Goater wrote: On 10/8/24 09:43, Nicholas Piggin wrote: On Thu Sep 19, 2024 at 2:50 AM AEST, Chalapathi V wrote: Hello, v3: 1. Update the PowerNV maintainer section to include hw/ssi/pnv_spi* 2. Use of PnvXferBuffer results in a additonal process overhead due

Re: [PATCH v3 3/3] hw/ssi/pnv_spi: Use local var seq_index instead of get_seq_index().

2024-10-08 Thread Chalapathi V
On 08-10-2024 13:43, Nicholas Piggin wrote: On Thu Sep 19, 2024 at 2:50 AM AEST, Chalapathi V wrote: Use a local variable seq_index instead of repeatedly caling get_seq_index() method. Signed-off-by: Chalapathi V --- hw/ssi/pnv_spi.c | 61

Re: [PATCH v3 1/3] MAINTAINERS: Cover PowerPC SPI model in PowerNV section

2024-10-08 Thread Chalapathi V
On 08-10-2024 13:14, Nicholas Piggin wrote: On Thu Sep 19, 2024 at 2:50 AM AEST, Chalapathi V wrote: From: "Philippe Mathieu-Daudé" It is unfair to let the PowerNV SPI model to the SSI maintainers. Also include the PowerNV ones. Fixes: 29318db133 ("hw/ssi: Add SPI model&

Re: [PATCH v3 2/3] hw/ssi/pnv_spi: Replace PnvXferBuffer with Fifo8 structure

2024-10-08 Thread Chalapathi V
On 08-10-2024 13:29, Nicholas Piggin wrote: On Thu Sep 19, 2024 at 2:50 AM AEST, Chalapathi V wrote: In PnvXferBuffer dynamically allocating and freeing is a process overhead. Hence used an existing Fifo8 buffer with capacity of 16 bytes. Signed-off-by: Chalapathi V --- include/hw/ssi

[PATCH v3 3/3] hw/ssi/pnv_spi: Use local var seq_index instead of get_seq_index().

2024-09-18 Thread Chalapathi V
Use a local variable seq_index instead of repeatedly caling get_seq_index() method. Signed-off-by: Chalapathi V --- hw/ssi/pnv_spi.c | 61 1 file changed, 31 insertions(+), 30 deletions(-) diff --git a/hw/ssi/pnv_spi.c b/hw/ssi/pnv_spi.c index

[PATCH v3 2/3] hw/ssi/pnv_spi: Replace PnvXferBuffer with Fifo8 structure

2024-09-18 Thread Chalapathi V
In PnvXferBuffer dynamically allocating and freeing is a process overhead. Hence used an existing Fifo8 buffer with capacity of 16 bytes. Signed-off-by: Chalapathi V --- include/hw/ssi/pnv_spi.h | 3 + hw/ssi/pnv_spi.c | 167 +-- 2 files changed, 56

[PATCH-for-9.2 v3 0/3] hw/ssi/pnv_spi: Remove PnvXferBuffer and get_seq_index()

2024-09-18 Thread Chalapathi V
owerNV section Chalapathi V (2): hw/ssi/pnv_spi: Replace PnvXferBuffer with Fifo8 structure hw/ssi/pnv_spi: Use local var seq_index instead of get_seq_index(). MAINTAINERS | 2 + include/hw/ssi/pnv_spi.h | 3 + hw/ssi/pnv_spi.c | 228 +++---

[PATCH v3 1/3] MAINTAINERS: Cover PowerPC SPI model in PowerNV section

2024-09-18 Thread Chalapathi V
From: "Philippe Mathieu-Daudé" It is unfair to let the PowerNV SPI model to the SSI maintainers. Also include the PowerNV ones. Fixes: 29318db133 ("hw/ssi: Add SPI model") Signed-off-by: Philippe Mathieu-Daudé Signed-off-by: Chalapathi V --- MAINTAINERS | 2 ++ 1 file c

Re: [PATCH-for-9.1 v2 0/4] hw/ssi/pnv_spi: Fixes Coverity CID 1558831

2024-09-16 Thread Chalapathi V
On 13-09-2024 19:07, Cédric Le Goater wrote: Hello, On 9/13/24 15:24, Chalapathi V wrote: On 12-09-2024 22:25, Cédric Le Goater wrote: Chalapthi, On 8/7/24 22:28, Philippe Mathieu-Daudé wrote: v2: - Cover PowerNV SSI in MAINTAINERS - Use GLib API in pnv_spi_xfer_buffer_free() - Simplify

Re: [PATCH-for-9.1 v2 0/4] hw/ssi/pnv_spi: Fixes Coverity CID 1558831

2024-09-13 Thread Chalapathi V
review comments from initial v1 patchset and send the v2 patchset ASAP. Thank You, Chalapathi Chalapathi V (1):    hw/ssi/pnv_spi: Fixes Coverity CID 1558831 Philippe Mathieu-Daudé (3):    MAINTAINERS: Cover PowerPC SPI model in PowerNV section    hw/ssi/pnv_spi: Match _xfer_buffer_free(

[PATCH v1 2/2] Fixes: Coverity CID 1558831

2024-08-06 Thread Chalapathi V
In this commit the following coverity scan defect has been fixed CID 1558831: Resource leaks (RESOURCE_LEAK) Variable "rsp_payload" going out of scope leaks the storage it points to. Signed-off-by: Chalapathi V --- hw/ssi/pnv_spi.c | 1 + 1 file changed, 1 insertion(+) diff

[PATCH v1 0/2] hw/ppc: SPI model - coverity fixes

2024-08-06 Thread Chalapathi V
t;s->seq_op" of 8 bytes at byte offset 16 using index "get_seq_index(s) + 1" (which evaluates to 16). Tested: passed make check and make check-avocado Chalapathi V (2): Fixes: Coverity CID 1558827 Fixes: Coverity CID 1558831 hw/ssi/pnv_spi.c | 7 --- 1 file chan

[PATCH v1 1/2] Fixes: Coverity CID 1558827

2024-08-06 Thread Chalapathi V
In this commit the following coverity scan defect has been fixed. CID 1558827:(OVERRUN) Overrunning array "s->seq_op" of 8 bytes at byte offset 16 using index "get_seq_index(s) + 1" (which evaluates to 16). Signed-off-by: Chalapathi V --- hw/ssi/pnv_spi.c | 6 ++

[PATCH v6 2/6] hw/ssi: Add SPI model

2024-07-30 Thread Chalapathi V
is modelled which contains all SPI configuration and status registers as well as the hold registers for data to be sent or having been received. An existing QEMU SSI framework is used and SSI_BUS is created. Signed-off-by: Chalapathi V Reviewed-by: Caleb Schlossin Reviewed-by: Cédric Le Goater

[PATCH v6 5/6] hw/ppc: SPI controller wiring to P10 chip

2024-07-30 Thread Chalapathi V
) /peripheral-anon (container) /device[0] (25csm04) /WP#[0] (irq) /ssi-gpio-cs[0] (irq) (qemu) qom-get /machine/peripheral-anon /device[76] "parent_bus" "/machine/chip[0]/pib_spic[2]/pnv-spi-bus.2" Signed-off-by: Chalapathi V Reviewed-by: Glenn Miles Reviewed-

[PATCH v6 4/6] hw/block: Add Microchip's 25CSM04 to m25p80

2024-07-30 Thread Chalapathi V
where reliable and dependable nonvolatile memory storage is essential. Signed-off-by: Chalapathi V Reviewed-by: Glenn Miles Reviewed-by: Cédric Le Goater --- hw/block/m25p80.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 8dec134832..824a6c5c60 1

[PATCH v6 6/6] tests/qtest: Add pnv-spi-seeprom qtest

2024-07-30 Thread Chalapathi V
In this commit Write a qtest pnv-spi-seeprom-test to check the SPI transactions between spi controller and seeprom device. Signed-off-by: Chalapathi V Acked-by: Cédric Le Goater Reviewed-by: Caleb Schlossin --- tests/qtest/pnv-spi-seeprom-test.c | 110 + tests

[PATCH v6 1/6] ppc/pnv: Remove ppc target dependency from pnv_xscom.h

2024-07-30 Thread Chalapathi V
In this commit target specific dependency from include/hw/ppc/pnv_xscom.h has been removed so that pnv_xscom.h can be included outside hw/ppc. Signed-off-by: Chalapathi V Reviewed-by: Cédric Le Goater Reviewed-by: Caleb Schlossin --- include/hw/ppc/pnv_xscom.h | 2 +- 1 file changed, 1

[PATCH v6 0/6] hw/ppc: SPI model

2024-07-30 Thread Chalapathi V
. Test covered: make check make check-avocado Thank You, Chalapathi Chalapathi V (6): ppc/pnv: Remove ppc target dependency from pnv_xscom.h hw/ssi: Add SPI model hw/ssi: Extend SPI model hw/block: Add Microchip's 25CSM04 to m25p80 hw/ppc: SPI controller wiring to P10 chip tests/qtest:

[PATCH v6 3/6] hw/ssi: Extend SPI model

2024-07-30 Thread Chalapathi V
data transmit and data receive control of the shift engine. Signed-off-by: Chalapathi V Reviewed-by: Caleb Schlossin Reviewed-by: Glenn Miles --- include/hw/ssi/pnv_spi.h | 27 + include/hw/ssi/pnv_spi_regs.h | 68 ++- hw/ssi/pnv_spi.c | 1047

Re: [PULL 38/96] hw/ssi: Extend SPI model

2024-07-29 Thread Chalapathi V
On 29-07-2024 17:38, Cédric Le Goater wrote: On 7/26/24 01:53, Nicholas Piggin wrote: +static void transfer(PnvSpi *s, PnvXferBuffer *payload) +{ +    uint32_t tx; +    uint32_t rx; +    PnvXferBuffer *rsp_payload = NULL; + +    rsp_payload = pnv_spi_xfer_buffer_new(); +    for (int offset = 0

[PATCH v5 3/6] hw/ssi: Extend SPI model

2024-06-26 Thread Chalapathi V
data transmit and data receive control of the shift engine. Signed-off-by: Chalapathi V --- include/hw/ssi/pnv_spi.h | 27 + include/hw/ssi/pnv_spi_regs.h | 68 ++- hw/ssi/pnv_spi.c | 1045 + hw/ssi/trace-events | 15 + 4 files

[PATCH v5 4/6] hw/block: Add Microchip's 25CSM04 to m25p80

2024-06-26 Thread Chalapathi V
where reliable and dependable nonvolatile memory storage is essential. Signed-off-by: Chalapathi V Reviewed-by: Glenn Miles Reviewed-by: Cédric Le Goater --- hw/block/m25p80.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 8dec134832..824a6c5c60 1

[PATCH v5 6/6] tests/qtest: Add pnv-spi-seeprom qtest

2024-06-26 Thread Chalapathi V
In this commit Write a qtest pnv-spi-seeprom-test to check the SPI transactions between spi controller and seeprom device. Signed-off-by: Chalapathi V Acked-by: Cédric Le Goater --- tests/qtest/pnv-spi-seeprom-test.c | 110 + tests/qtest/meson.build| 1

[PATCH v5 0/6] hw/ppc: SPI model

2024-06-26 Thread Chalapathi V
ATCH5: Connect SPI controllers to p10 chip and connect cs lines. PATCH6: Write a qtest pnv-spi-seeprom-test to check the SPI transactions between spi controller and seeprom device. Test covered: make check make check-avocado Thank You, Chalapathi Chalapathi V (6): ppc/pnv: Remove ppc t

[PATCH v5 2/6] hw/ssi: Add SPI model

2024-06-26 Thread Chalapathi V
is modelled which contains all SPI configuration and status registers as well as the hold registers for data to be sent or having been received. An existing QEMU SSI framework is used and SSI_BUS is created. Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_xscom.h| 3 + include/hw/ssi

[PATCH v5 5/6] hw/ppc: SPI controller wiring to P10 chip

2024-06-26 Thread Chalapathi V
) /peripheral-anon (container) /device[0] (25csm04) /WP#[0] (irq) /ssi-gpio-cs[0] (irq) (qemu) qom-get /machine/peripheral-anon /device[76] "parent_bus" "/machine/chip[0]/pib_spic[2]/pnv-spi-bus.2" Signed-off-by: Chalapathi V Reviewed-by: Glenn Miles Reviewed-

[PATCH v5 1/6] ppc/pnv: Remove ppc target dependency from pnv_xscom.h

2024-06-26 Thread Chalapathi V
In this commit target specific dependency from include/hw/ppc/pnv_xscom.h has been removed so that pnv_xscom.h can be included outside hw/ppc. Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_xscom.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/include/hw/ppc

Re: [PATCH v4 2/5] ppc/pnv: Extend SPI model

2024-06-20 Thread Chalapathi V
n Hello Glenn, Thank You for the review and suggestions. I will address them and update in next revision ASAP. Thank You, Chalapathi On Mon, 2024-06-17 at 11:54 -0500, Chalapathi V wrote: In this commit SPI shift engine and sequencer logic is implemented. Shift engine performs seria

Re: [PATCH v4 1/5] ppc/pnv: Add SPI model

2024-06-19 Thread Chalapathi V
Hello Cedric, Thank You for reviewing this patch series. Regards, Chalapathi On 18-06-2024 21:18, Cédric Le Goater wrote: Hello Chalapathi, On 6/17/24 6:54 PM, Chalapathi V wrote: SPI controller device model supports a connection to a single SPI responder. This provide access to SPI

[PATCH v4 4/5] hw/ppc: SPI controller wiring to P10 chip

2024-06-17 Thread Chalapathi V
-machine) /peripheral-anon (container) /device[0] (25csm04) /WP#[0] (irq) /ssi-gpio-cs[0] (irq) (qemu) qom-get /machine/peripheral-anon /device[76] "parent_bus" "/machine/chip[0]/pib_spic[2]/pnv-spi-bus.2" Signed-off-by: Chalapathi V Reviewed-by: Glenn Miles Re

[PATCH v4 1/5] ppc/pnv: Add SPI model

2024-06-17 Thread Chalapathi V
is modelled which contains all SPI configuration and status registers as well as the hold registers for data to be sent or having been received. An existing QEMU SSI framework is used and SSI_BUS is created. Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_xscom.h| 5 +- include/hw/ssi

[PATCH v4 5/5] tests/qtest: Add pnv-spi-seeprom qtest

2024-06-17 Thread Chalapathi V
In this commit Write a qtest pnv-spi-seeprom-test to check the SPI transactions between spi controller and seeprom device. Signed-off-by: Chalapathi V --- tests/qtest/pnv-spi-seeprom-test.c | 110 + tests/qtest/meson.build| 1 + 2 files changed, 111

[PATCH v4 0/5] hw/ppc: SPI model

2024-06-17 Thread Chalapathi V
t SPI controllers to p10 chip and connect cs lines. PATCH5: Write a qtest pnv-spi-seeprom-test to check the SPI transactions between spi controller and seeprom device. Test covered: make check make check-avocado Thank You, Chalapathi Chalapathi V (5): ppc/pnv: Add SPI model ppc/pnv: Extend SPI

[PATCH v4 3/5] hw/block: Add Microchip's 25CSM04 to m25p80

2024-06-17 Thread Chalapathi V
where reliable and dependable nonvolatile memory storage is essential. Signed-off-by: Chalapathi V Reviewed-by: Glenn Miles Reviewed-by: Cédric Le Goater --- hw/block/m25p80.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 8dec134832..824a6c5c60 1

[PATCH v4 2/5] ppc/pnv: Extend SPI model

2024-06-17 Thread Chalapathi V
data transmit and data receive control of the shift engine. Signed-off-by: Chalapathi V --- include/hw/ssi/pnv_spi.h | 27 + hw/ssi/pnv_spi.c | 1039 ++ hw/ssi/trace-events | 15 + 3 files changed, 1081 insertions(+) diff --git a/include/hw/ssi

Re: [PATCH v3 1/5] ppc/pnv: Add SPI controller model

2024-06-14 Thread Chalapathi V
On 14-06-2024 16:57, Cédric Le Goater wrote: On 6/13/24 3:45 PM, Chalapathi V wrote: On 20-05-2024 11:19, Cédric Le Goater wrote: On 5/15/24 19:41, Chalapathi V wrote: SPI controller device model supports a connection to a single SPI responder. This provide access to SPI seeproms, TPM

Re: [PATCH v3 1/5] ppc/pnv: Add SPI controller model

2024-06-13 Thread Chalapathi V
On 20-05-2024 11:19, Cédric Le Goater wrote: On 5/15/24 19:41, Chalapathi V wrote: SPI controller device model supports a connection to a single SPI responder. This provide access to SPI seeproms, TPM, flash device and an ADC controller. All SPI function control is mapped into the SPI

Re: [PATCH v3 5/5] tests/qtest: Add pnv-spi-seeprom qtest

2024-05-20 Thread Chalapathi V
On 20-05-2024 11:43, Cédric Le Goater wrote: On 5/15/24 19:41, Chalapathi V wrote: In this commit Write a qtest pnv-spi-seeprom-test to check the SPI transactions between spi controller and seeprom device. Signed-off-by: Chalapathi V ---   tests/qtest/pnv-spi-seeprom-test.c | 129

Re: [PATCH v3 1/5] ppc/pnv: Add SPI controller model

2024-05-20 Thread Chalapathi V
Hello Cedric, Thank You for reviewing the patch v3 Regards, Chalapathi On 20-05-2024 11:19, Cédric Le Goater wrote: On 5/15/24 19:41, Chalapathi V wrote: SPI controller device model supports a connection to a single SPI responder. This provide access to SPI seeproms, TPM, flash device and

Re: [PATCH v3 1/5] ppc/pnv: Add SPI controller model

2024-05-20 Thread Chalapathi V
On 20-05-2024 11:19, Cédric Le Goater wrote: On 5/15/24 19:41, Chalapathi V wrote: SPI controller device model supports a connection to a single SPI responder. This provide access to SPI seeproms, TPM, flash device and an ADC controller. All SPI function control is mapped into the SPI

Re: [PATCH v3 2/5] ppc/pnv: Extend SPI model

2024-05-20 Thread Chalapathi V
tch 1/5 will make it big. Hence made a logical partition. On Thu, 2024-05-16 at 11:33 -0500, Chalapathi V wrote: In this commit SPI shift engine and sequencer logic is implemented. Shift engine performs serialization and de-serialization according to the control by the sequencer and according t

Re: [PATCH v3 1/5] ppc/pnv: Add SPI controller model

2024-05-20 Thread Chalapathi V
Hello Glen, Thank You for reviewing the patch. Regards, Chalapathi On 17-05-2024 21:57, Miles Glenn wrote: Hi Chalapathi, Looks good. Just some suggestions on readability and some simplifications (see below). Thanks, Glenn On Thu, 2024-05-16 at 11:33 -0500, Chalapathi V wrote: SPI

[PATCH v3 2/5] ppc/pnv: Extend SPI model

2024-05-15 Thread Chalapathi V
data transmit and data receive control of the shift engine. Signed-off-by: Chalapathi V --- include/hw/ssi/pnv_spi.h| 28 + hw/ppc/pnv_spi_controller.c | 1074 +++ hw/ppc/trace-events | 15 + 3 files changed, 1117 insertions(+) diff --git a/include

[PATCH v3 5/5] tests/qtest: Add pnv-spi-seeprom qtest

2024-05-15 Thread Chalapathi V
In this commit Write a qtest pnv-spi-seeprom-test to check the SPI transactions between spi controller and seeprom device. Signed-off-by: Chalapathi V --- tests/qtest/pnv-spi-seeprom-test.c | 129 + tests/qtest/meson.build| 1 + 2 files changed, 130

[PATCH v3 4/5] hw/ppc: SPI controller wiring to P10 chip

2024-05-15 Thread Chalapathi V
) /machine (powernv10-machine) /peripheral-anon (container) /device[0] (25csm04) /WP#[0] (irq) /ssi-gpio-cs[0] (irq) (qemu) qom-get /machine/peripheral-anon /device[76] "parent_bus" "/machine/chip[0]/pib_spic[2]/pnv-spi-bus.2" Signed-off-by: Chalapathi V

[PATCH v3 0/5] hw/ppc: SPI model

2024-05-15 Thread Chalapathi V
seeprom-test to check the SPI transactions between spi controller and seeprom device. Test covered: Ran make check. Thank You, Chalapathi Chalapathi V (5): ppc/pnv: Add SPI controller model ppc/pnv: Extend SPI model hw/block: Add Microchip's 25CSM04 to m25p80 hw/ppc: SPI cont

[PATCH v3 1/5] ppc/pnv: Add SPI controller model

2024-05-15 Thread Chalapathi V
is modelled which contains all SPI configuration and status registers as well as the hold registers for data to be sent or having been received. An existing QEMU SSI framework is used and SSI_BUS is created. Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_xscom.h| 3 + include/hw/ssi

[PATCH v3 3/5] hw/block: Add Microchip's 25CSM04 to m25p80

2024-05-15 Thread Chalapathi V
where reliable and dependable nonvolatile memory storage is essential. Signed-off-by: Chalapathi V --- hw/block/m25p80.c | 3 +++ hw/ppc/Kconfig| 1 + 2 files changed, 4 insertions(+) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 8dec134832..824a6c5c60 100644 --- a/hw/block/m25p80.c +++

Re: [PATCH v2 5/6] hw/ppc: SPI controller wiring to P10 chip and create seeprom device

2024-04-24 Thread Chalapathi V
Hello Cedric, Thank You for reviewing v2 patches. Regards, Chalapathi On 22-04-2024 20:33, Cédric Le Goater wrote: On 4/9/24 19:56, Chalapathi V wrote: In this commit Creates SPI controller on p10 chip. Create the keystore seeprom of type "seeprom-25csm04" Connect the cs of

Re: [PATCH v2 3/6] hw/ppc: SPI controller model - sequencer and shifter

2024-04-16 Thread Chalapathi V
On 16-04-2024 15:09, Cédric Le Goater wrote: Hello, Please rephrase the subject to something like:   "ppc/pnv: Extend SPI model ..." Using a verb is preferable. Sure. Will update. Thank You. On 4/9/24 19:56, Chalapathi V wrote: In this commit SPI shift engine and sequence

Re: [PATCH v2 2/6] hw/ppc: SPI controller model - registers implementation

2024-04-16 Thread Chalapathi V
On 15-04-2024 20:44, Cédric Le Goater wrote: Hello Chalapathi The subject could be rephrased to : "ppc/pnv: Add SPI controller model". On 4/9/24 19:56, Chalapathi V wrote: SPI controller device model supports a connection to a single SPI responder. This provide access to SPI see

[PATCH v2 5/6] hw/ppc: SPI controller wiring to P10 chip and create seeprom device

2024-04-09 Thread Chalapathi V
_bus" "/machine/chip[0]/pib_spic[2]/bus/pnv-spi-bus.2" Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_chip.h | 3 +++ hw/ppc/pnv.c | 36 +++- 2 files changed, 38 insertions(+), 1 deletion(-) diff --git a/include/hw/ppc/pnv_chip.h b/i

[PATCH v2 6/6] tests/qtest: Add pnv-spi-seeprom qtest

2024-04-09 Thread Chalapathi V
In this commit Write a qtest pnv-spi-seeprom-test to check the SPI transactions between spi controller and seeprom device. Signed-off-by: Chalapathi V --- tests/qtest/pnv-spi-seeprom-test.c | 126 + tests/qtest/meson.build| 1 + 2 files changed, 127

[PATCH v2 2/6] hw/ppc: SPI controller model - registers implementation

2024-04-09 Thread Chalapathi V
is modelled which contains all SPI configuration and status registers as well as the hold registers for data to be sent or having been received. An existing QEMU SSI framework is used and SSI_BUS is created. Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_spi_controller.h | 55

[PATCH v2 4/6] hw/misc: Microchip's 25CSM04 SEEPROM model

2024-04-09 Thread Chalapathi V
24288 bytes of 8 bits each (512Kbyte) and is optimized for use in consumer and industrial applications where reliable and dependable nonvolatile memory storage is essential. This seeprom device is created from a parent "ssi-peripheral". Signed-off-by: Chalapathi V --- include/hw/misc/se

[PATCH v2 0/6] hw/ppc: SPI model

2024-04-09 Thread Chalapathi V
_SPIC[2]. PATCH6: Write a qtest pnv-spi-seeprom-test to check the SPI transactions between spi controller and seeprom device. Test covered: Ran make check. Thank You, Chalapathi Chalapathi V (6): hw/ppc: remove SPI responder model hw/ppc: SPI controller model - registers implementation

[PATCH v2 3/6] hw/ppc: SPI controller model - sequencer and shifter

2024-04-09 Thread Chalapathi V
data transmit and data receive control of the shift engine. Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_spi_controller.h | 72 ++ hw/ppc/pnv_spi_controller.c | 1311 ++- 2 files changed, 1382 insertions(+), 1 deletion(-) diff --git a/include/hw/ppc

[PATCH v2 1/6] hw/ppc: remove SPI responder model

2024-04-09 Thread Chalapathi V
-- Empty commit to align the patch numbers between PATCH v1 and PATCH v2. SPI responder model is removed as pnv spi controller and seeprom is implemented using QEMU SSI framework. Signed-off-by: Chalapathi V

Re: [PATCH v1 0/5] hw/ppc: SPI model

2024-03-01 Thread Chalapathi V
On 01-03-2024 22:06, Cédric Le Goater wrote: Chalapathi, On 3/1/24 17:17, Chalapathi V wrote: Hello, I would greatly appreciate the review comments/suggestions on PATCH V1. Thank You and Regards, I didn't forget but I lacked the time in this release cycle. Sorry about that. I hav

Re: [PATCH v1 0/5] hw/ppc: SPI model

2024-03-01 Thread Chalapathi V
Hello, I would greatly appreciate the review comments/suggestions on PATCH V1. Thank You and Regards, Chalapathi On 07-02-2024 21:38, Chalapathi V wrote: Hello, In this series of patchset, SPI controller and responder models for Power10 processor are modelled. Serial peripheral interface

[PATCH v1 3/5] hw/ppc: SPI controller model - sequencer and shifter

2024-02-07 Thread Chalapathi V
data transmit and data receive control of the shift engine. Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_spi_controller.h | 58 ++ hw/ppc/pnv_spi_controller.c | 1274 ++- 2 files changed, 1331 insertions(+), 1 deletion(-) diff --git a/include/hw/ppc

[PATCH v1 4/5] hw/ppc: SPI SEEPROM model

2024-02-07 Thread Chalapathi V
24288 bytes of 8 bits each (512Kbyte) and is optimized for use in consumer and industrial applications where reliable and dependable nonvolatile memory storage is essential. Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_spi_seeprom.h | 70 +++ hw/ppc/pnv_spi_seeprom.c

[PATCH v1 1/5] hw/ppc: SPI responder model

2024-02-07 Thread Chalapathi V
that single responder is connected to bus, hence chip_select is not modelled. Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_spi_responder.h | 109 +++ hw/ppc/pnv_spi_responder.c | 166 + hw/ppc/meson.build | 1 + 3 files

[PATCH v1 0/5] hw/ppc: SPI model

2024-02-07 Thread Chalapathi V
OM registers. PATCH3: SPI controller model: implement sequencer FSM and shift engine. PATCH4: create SPI SEEPROM model. PATCH5: Connect SPI controllers to p10 chip and create keystore seeprom device on spi_bus2 of PIB_SPIC[2]. Thank You, Chalapathi Chalapathi V (5): hw/ppc: SPI resp

[PATCH v1 5/5] hw/ppc: SPI controller wiring to P10 chip and create seeprom device

2024-02-07 Thread Chalapathi V
This commit creates SPI controller to p10 chip and create the keystore seeprom device on spi_bus2 of PIB_SPIC[2]. Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_chip.h | 4 hw/ppc/pnv.c | 32 2 files changed, 36 insertions(+) diff --git a

[PATCH v1 2/5] hw/ppc: SPI controller model - registers implementation

2024-02-07 Thread Chalapathi V
is modelled which contains all SPI configuration and status registers as well as the hold registers for data to be sent or having been received. Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_spi_controller.h | 43 include/hw/ppc/pnv_xscom.h | 3 + hw/ppc/pnv_spi_controller.c

[PATCH v8 2/3] hw/ppc: Add N1 chiplet model

2023-12-08 Thread Chalapathi V
control registers are implemented. This commit also implement the read/write method for the powerbus scom registers Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_n1_chiplet.h | 32 ++ include/hw/ppc/pnv_xscom.h | 6 ++ hw/ppc/pnv_n1_chiplet.c | 173

[PATCH v8 3/3] hw/ppc: N1 chiplet wiring

2023-12-08 Thread Chalapathi V
This part of the patchset connects the nest1 chiplet model to p10 chip. Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_chip.h | 2 ++ hw/ppc/pnv.c | 15 +++ 2 files changed, 17 insertions(+) diff --git a/include/hw/ppc/pnv_chip.h b/include/hw/ppc/pnv_chip.h index

[PATCH v8 1/3] hw/ppc: Add pnv nest pervasive common chiplet model

2023-12-08 Thread Chalapathi V
ters. Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_nest_pervasive.h | 32 + include/hw/ppc/pnv_xscom.h | 3 + hw/ppc/pnv_nest_pervasive.c | 208 hw/ppc/meson.build | 1 + 4 files changed, 244 insertions(+) create mode 1

[PATCH v8 0/3] pnv N1 chiplet model

2023-12-08 Thread Chalapathi V
covered: Ran make check && make check-avocado and found no obvious issues. Thank You, Chalapathi Chalapathi V (3): hw/ppc: Add pnv nest pervasive common chiplet model hw/ppc: Add N1 chiplet model hw/ppc: N1 chiplet wiring include/hw/ppc/pnv_chip.h | 2 + includ

[PATCH v8 1/3] hw/ppc: Add pnv nest pervasive common chiplet model

2023-12-08 Thread Chalapathi V
ters. Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_nest_pervasive.h | 32 + include/hw/ppc/pnv_xscom.h | 3 + hw/ppc/pnv_nest_pervasive.c | 208 hw/ppc/meson.build | 1 + 4 files changed, 244 insertions(+) create mode 1

[PATCH v8 2/3] hw/ppc: Add N1 chiplet model

2023-12-08 Thread Chalapathi V
control registers are implemented. This commit also implement the read/write method for the powerbus scom registers Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_n1_chiplet.h | 32 ++ include/hw/ppc/pnv_xscom.h | 6 ++ hw/ppc/pnv_n1_chiplet.c | 173

[PATCH v8 3/3] hw/ppc: N1 chiplet wiring

2023-12-08 Thread Chalapathi V
This part of the patchset connects the nest1 chiplet model to p10 chip. Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_chip.h | 2 ++ hw/ppc/pnv.c | 15 +++ 2 files changed, 17 insertions(+) diff --git a/include/hw/ppc/pnv_chip.h b/include/hw/ppc/pnv_chip.h index

[PATCH v7 1/3] hw/ppc: Add pnv nest pervasive common chiplet model

2023-12-06 Thread Chalapathi V
ters. Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_nest_pervasive.h | 32 + include/hw/ppc/pnv_xscom.h | 3 + hw/ppc/pnv_nest_pervasive.c | 208 hw/ppc/meson.build | 1 + 4 files changed, 244 insertions(+) create mode 1

[PATCH v7 3/3] hw/ppc: N1 chiplet wiring

2023-12-06 Thread Chalapathi V
This part of the patchset connects the nest1 chiplet model to p10 chip. Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_chip.h | 2 ++ hw/ppc/pnv.c | 15 +++ 2 files changed, 17 insertions(+) diff --git a/include/hw/ppc/pnv_chip.h b/include/hw/ppc/pnv_chip.h index

[PATCH v7 2/3] hw/ppc: Add N1 chiplet model

2023-12-06 Thread Chalapathi V
control registers are implemented. This commit also implement the read/write method for the powerbus scom registers Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_n1_chiplet.h | 33 ++ include/hw/ppc/pnv_xscom.h | 6 ++ hw/ppc/pnv_n1_chiplet.c | 173

[PATCH v7 0/3] pnv N1 chiplet model

2023-12-06 Thread Chalapathi V
check-avocado and found no obvious issues. Thank You, Chalapathi Chalapathi V (3): hw/ppc: Add pnv nest pervasive common chiplet model hw/ppc: Add N1 chiplet model hw/ppc: N1 chiplet wiring include/hw/ppc/pnv_chip.h | 2 + include/hw/ppc/pnv_n1_chiplet.h | 33 +++

Re: [PATCH v6 2/3] hw/ppc: Add N1 chiplet model

2023-12-06 Thread Chalapathi V
On 28-11-2023 12:18, Cédric Le Goater wrote: On 11/27/23 18:13, Chalapathi V wrote: The N1 chiplet handle the high speed i/o traffic over PCIe and others. The N1 chiplet consists of PowerBus Fabric controller, nest Memory Management Unit, chiplet control unit and more. This commit creates a

[PATCH v6 1/3] hw/ppc: Add pnv nest pervasive common chiplet model

2023-11-27 Thread Chalapathi V
ters. Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_nest_pervasive.h | 36 + include/hw/ppc/pnv_xscom.h | 3 + hw/ppc/pnv_nest_pervasive.c | 219 hw/ppc/meson.build | 1 + 4 files changed, 259 insertions(+) create mode 1

[PATCH v6 2/3] hw/ppc: Add N1 chiplet model

2023-11-27 Thread Chalapathi V
control registers are implemented. This commit also implement the read/write method for the powerbus scom registers Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_n1_chiplet.h | 35 +++ include/hw/ppc/pnv_xscom.h | 6 ++ hw/ppc/pnv_n1_chiplet.c | 171

[PATCH v6 3/3] hw/ppc: N1 chiplet wiring

2023-11-27 Thread Chalapathi V
This part of the patchset connects the nest1 chiplet model to p10 chip. Signed-off-by: Chalapathi V --- include/hw/ppc/pnv_chip.h | 2 ++ hw/ppc/pnv.c | 15 +++ 2 files changed, 17 insertions(+) diff --git a/include/hw/ppc/pnv_chip.h b/include/hw/ppc/pnv_chip.h index

[PATCH v6 0/3] pnv nest1 chiplet model

2023-11-27 Thread Chalapathi V
chiplet control scoms for N1 chiplet. PATCH3: Connect N1 chiplet model to p10 chip. Test covered: These changes are tested on a single socket and 2 socket P10 machine. Thank You, Chalapathi Chalapathi V (3): hw/ppc: Add pnv nest pervasive common chiplet model hw/ppc: Add N1 chiplet model

  1   2   >