Hi Peter, just two nits, answering from the tablet so sorry if arrives with
strange formatting, hope not..
On Thursday, January 23, 2014, Peter Maydell
>
wrote:
> From: Alex Bennée
>
> This implements a subset of the AdvSIMD shift operations (namely all the
> none saturating or narrowing ones).
Sorry for noticing only now,
but there is a missing return here as well I think:
On 13 December 2013 20:17, Peter Maydell wrote:
> From: Alex Bennée
>
> Implement the non-carry forms of addition and subtraction
> (immediate, extended register and shifted register).
> This includes the code to ca
On 12 December 2013 12:45, Peter Maydell wrote:
> On 12 December 2013 11:43, Alex Bennée wrote:
>>
>> claudio.font...@linaro.org writes:
>>
>>> Hi,
>>>
>>> I saw a missing return below:
>>
+default: /* Failed decoder tree? */
+unallocated_encoding(s);
+break;
>
Hi,
I saw a missing return below:
On 11 December 2013 23:01, Peter Maydell wrote:
> From: Alex Bennée
>
> This patch support the basic load and store pair instructions and
> includes the generic helper functions:
>
> * do_gpr_st()
> * do_fp_st()
> * do_gpr_ld()
> * do_fp_ld()
> * read
On Friday, December 6, 2013, Peter Maydell wrote:
> On 5 December 2013 22:51, Richard Henderson >
> wrote:
> > On 12/06/2013 10:51 AM, Peter Maydell wrote:
> >> +switch (opcode) {
> >> +case 2: /* UDIV */
> >> +handle_div(s, FALSE, sf, rm, rn, rd);
> >> +break;
> >> +ca