[PATCH] spice-app: avoid crash when core spice module doesn't loaded

2021-02-12 Thread Bruce Rogers
eferencing and error out in a normal way. Signed-off-by: Bruce Rogers --- ui/spice-app.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/ui/spice-app.c b/ui/spice-app.c index 026124ef56..4325ac2d9c 100644 --- a/ui/spice-app.c +++ b/ui/spice-app.c @@ -129,6 +129,7 @@ s

Re: [PULL 50/55] virtfs: convert to meson

2021-01-07 Thread Bruce Rogers
On Thu, 2021-01-07 at 15:49 +0100, Paolo Bonzini wrote: > On 07/01/21 14:58, Bruce Rogers wrote: > > I noticed that for me, this broke the building of virtfs-proxy- > > helper. > > I've not yet figured out what the fix should be, but thought you'd > > want

Re: [PULL 50/55] virtfs: convert to meson

2021-01-07 Thread Bruce Rogers
On Mon, 2020-12-21 at 15:44 +0100, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini > --- >  configure | 29 - >  meson.build   | 24 ++-- >  meson_options.txt | 11 +++ >  3 files changed, 33 insertions(+), 31 deletions(-) > > d

Re: [PATCH v2] usb: fix kconfig for usb-xhci-sysbus

2020-11-20 Thread Bruce Rogers
ce to keep the ability to remove PCIe and USB from > microvm, > since thos can be disabled on the command line and therefore should > not > be included if QEMU is configured --without-default-devices. However > it's too late for 5.2 to figure out a place for the DSDT cre

Re: [PATCH v3 04/10] usb/xhci: fixup xhci kconfig deps

2020-11-19 Thread Bruce Rogers
On Tue, 2020-10-20 at 09:48 +0200, Gerd Hoffmann wrote: > USB_XHCI does not depend on PCI any more. > USB_XHCI_SYSBUS must select USB_XHCI not USB. > > Signed-off-by: Gerd Hoffmann > --- > hw/usb/Kconfig | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) > > diff --git a/hw/usb/Kconf

[PATCH] configure: fix gio_libs reference

2020-11-03 Thread Bruce Rogers
The gio library detection code no longer works, due to a missing $ in front of the gio_libs reference. Make the string be $gio_libs. Fixes: 76346b6264a ("configure: Test that gio libs from pkg-config work") Signed-off-by: Bruce Rogers --- configure | 2 +- 1 file changed, 1 inser

Re: [PATCH 00/14] ui: build spice and opengl as module.

2020-10-26 Thread Bruce Rogers
On Mon, 2020-10-19 at 09:52 +0200, Gerd Hoffmann wrote: > - Add QemuSpiceOps, reorganize spice stubs. > - Add support for module dependencies. > - Build spice-core modular, and make the existing spice > modules (audio, chardev, qxl) depend on spice-core. > - Build egl-headless display and opengl

[PATCH] roms/Makefile: Add qboot to .PHONY list

2020-10-20 Thread Bruce Rogers
Adding qboot to the .PHONY directive will allow a make -C roms qboot invocation to work as expected Signed-off-by: Bruce Rogers --- roms/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/roms/Makefile b/roms/Makefile index 1489d47350..7045e374d3 100644 --- a/roms

[PATCH] meson: Only install icons and qemu.desktop if have_system

2020-10-15 Thread Bruce Rogers
These files are not needed for a linux-user only install. Signed-off-by: Bruce Rogers --- ui/meson.build | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/ui/meson.build b/ui/meson.build index 78ad792ffb..fb36d305ca 100644 --- a/ui/meson.build +++ b/ui/meson.build

[PATCH] configure: fix handling of --docdir parameter

2020-10-15 Thread Bruce Rogers
: ca8c0909f01 ("configure: build docdir like other suffixed directories") Signed-off-by: Bruce Rogers --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index f839c2a557..07acd01a25 100755 --- a/configure +++ b/configure @@ -971,7 +971,7

Re: [PATCH] configure: fix handling of --docdir parameter

2020-10-15 Thread Bruce Rogers
On Thu, 2020-10-15 at 13:02 -0600, Bruce Rogers wrote: > Commit ca8c0909f01 changed qemu_docdir to be docdir, then later uses > the > qemu_docdir name in the final assignment. Unfortunately, one instance > of > qemu_docdir was missed: the one which comes from the --docdir > param

[PATCH] configure: fix handling of --docdir parameter

2020-10-15 Thread Bruce Rogers
: ca8c0909f01 ("configure: build docdir like other suffixed directories") Signed-off-by: Bruce Rogers --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index f839c2a557..07acd01a25 100755 --- a/configure +++ b/configure @@ -971,7 +971,7

[PATCH] meson.build: don't condition iconv detection on library detection

2020-10-14 Thread Bruce Rogers
It isn't necessarily the case that use of iconv requires an additional library. For that reason we shouldn't conditionalize iconv detection on libiconv.found. Fixes: 5285e593c33 (configure: Fixes ncursesw detection under msys2/mingw by convert them to meson) Signed-off-by: Br

Re: [PULL 5/9] configure: Fixes ncursesw detection under msys2/mingw by convert them to meson

2020-10-14 Thread Bruce Rogers
1:17 PM To: Bruce Rogers Cc: Gerd Hoffmann; qemu-level; Stefan Weil Subject: Re: [PULL 5/9] configure: Fixes ncursesw detection under msys2/mingw by convert them to meson If iconv installed then it's the meson's probme that didn't found the iconv properly On Thu, Oct 15, 202

Re: [PULL 5/9] configure: Fixes ncursesw detection under msys2/mingw by convert them to meson

2020-10-14 Thread Bruce Rogers
On Wed, 2020-10-14 at 10:21 +0200, Gerd Hoffmann wrote: > From: Yonggang Luo > > The mingw pkg-config are showing following absolute path and contains > : as the separator, > > -D_XOPEN_SOURCE=600 -D_POSIX_C_SOURCE=199506L -IC:/CI- > Tools/msys64/mingw64/include/ncursesw:-I/usr/include/ncursesw:

Re: [RFC PATCH 16/21] contrib/gitdm: Add SUSE to the domain map

2020-10-04 Thread Bruce Rogers
On Sun, 2020-10-04 at 20:04 +0200, Philippe Mathieu-Daudé wrote: > There is a number of contributors from this domain, > add its own entry to the gitdm domain map. > > Cc: Andreas Färber > Cc: Bo Yang > Cc: Bruce Rogers > Cc: Charles Arnold > Cc: Chunyan Liu > Cc:

Re: [PATCH] meson: install ivshmem-client and ivshmem-server

2020-09-04 Thread Bruce Rogers
On Fri, 2020-09-04 at 11:20 +0200, Markus Armbruster wrote: > Paolo Bonzini writes: > > > On 04/09/20 09:24, Markus Armbruster wrote: > > > > Ah, via the tools variable in configure. Nice maze. I've > > > > queued the patch. > > > Please don't. > > > > > > These programs are examples to help p

Re: [PATCH] meson: install ivshmem-client and ivshmem-server

2020-09-03 Thread Bruce Rogers
On Thu, 2020-09-03 at 16:49 +0100, Daniel P. Berrangé wrote: > On Thu, Sep 03, 2020 at 05:44:25PM +0200, Paolo Bonzini wrote: > > On 03/09/20 17:35, Bruce Rogers wrote: > > > Turn on the meson install flag for these executables > > > > > > Signed-off-by: Br

[PATCH] meson: install ivshmem-client and ivshmem-server

2020-09-03 Thread Bruce Rogers
Turn on the meson install flag for these executables Signed-off-by: Bruce Rogers --- contrib/ivshmem-client/meson.build | 2 +- contrib/ivshmem-server/meson.build | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/contrib/ivshmem-client/meson.build b/contrib/ivshmem-client

[PATCH] meson: remove linkage of sdl to baum

2020-09-03 Thread Bruce Rogers
ake system, and with the switch to meson it has now become a hard requirement, which now causes chardev-baum.so to not be produced if sdl is not configured. Remove this bogus linkage. Signed-off-by: Bruce Rogers --- chardev/meson.build | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) di

[PATCH] meson: Fix chardev-baum.so name

2020-08-24 Thread Bruce Rogers
Somehow in the conversion to meson, the module named chardev-baum got renamed to chardev-brlapi. Change it back. Signed-off-by: Bruce Rogers --- chardev/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/chardev/meson.build b/chardev/meson.build index a46a6237be

[PATCH] meson: Fix meson build with --enable-libdaxctl

2020-08-24 Thread Bruce Rogers
The daxctl library needs to be linked against when daxctl is asked for in configure. Signed-off-by: Bruce Rogers --- configure | 1 + meson.build | 6 +- 2 files changed, 6 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 67832e3bab..15de7d10de 100755 --- a/configure

[PATCH] meson: Fix shell script syntax in qemu-version.sh

2020-08-24 Thread Bruce Rogers
There needs to be a space before the closing bracket. Signed-off-by: Bruce Rogers --- scripts/qemu-version.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/scripts/qemu-version.sh b/scripts/qemu-version.sh index 4847385e42..03128c56a2 100755 --- a/scripts/qemu-version.sh

[PATCH] virtio-mem: Correct format specifier mismatch for RISC-V

2020-07-30 Thread Bruce Rogers
user message. Since this particular usage of the underlying data seems unique to this file, the simple fix is to just cast QEMU_VMALLOC_ALIGN to uint32_t, which corresponds to the format specifier used. Signed-off-by: Bruce Rogers --- hw/virtio/virtio-mem.c | 2 +- 1 file changed, 1 insertion(+), 1 del

Re: [PATCH] virtio-mem: Work around format specifier mismatch for RISC-V

2020-07-30 Thread Bruce Rogers
On Thu, 2020-07-30 at 10:12 +0200, David Hildenbrand wrote: > On 30.07.20 09:58, Stefano Garzarella wrote: > > On Thu, Jul 30, 2020 at 09:51:19AM +0200, David Hildenbrand wrote: > > > On 30.07.20 09:49, Stefano Garzarella wrote: > > > > On Wed, Jul 29, 2020 at 06:54:

[PATCH] virtio-mem: Work around format specifier mismatch for RISC-V

2020-07-29 Thread Bruce Rogers
user message. Since this particular usage of the underlying data seems unique, the simple fix is to just cast it to the corresponding format specifier. Signed-off-by: Bruce Rogers --- hw/virtio/virtio-mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio-mem.c

Re: [PATCH for-5.1 1/2] block: Fix bdrv_aligned_p*v() for qiov_offset != 0

2020-07-28 Thread Bruce Rogers
bbecc0705c > Fixes: 28c4da28695bdbe04b336b2c9c463876cc3aaa6d > Reported-by: Claudio Fontana > Reported-by: Bruce Rogers > Cc: qemu-sta...@nongnu.org > Signed-off-by: Max Reitz > --- > block/io.c | 10 ++ > 1 file changed, 6 insertions(+), 4 deletions(-) > &

Re: migration: broken snapshot saves appear on s390 when small fields in migration stream removed

2020-07-28 Thread Bruce Rogers
On Tue, 2020-07-28 at 11:43 +0300, Vladimir Sementsov-Ogievskiy wrote: > 28.07.2020 02:09, Bruce Rogers wrote: > > On Tue, 2020-07-21 at 10:22 +0200, Claudio Fontana wrote: > > > On 7/20/20 8:24 PM, Claudio Fontana wrote: > > > > I have now been able to

Re: migration: broken snapshot saves appear on s390 when small fields in migration stream removed

2020-07-27 Thread Bruce Rogers
On Tue, 2020-07-21 at 10:22 +0200, Claudio Fontana wrote: > On 7/20/20 8:24 PM, Claudio Fontana wrote: > > I have now been able to reproduce this on X86 as well. > > > > It happens much more rarely, about once every 10 times. > > > > I will sort out the data and try to make it even more reproduci

Re: [PULL 40/41] vhost-vdpa: introduce vhost-vdpa backend

2020-07-07 Thread Bruce Rogers
On Fri, 2020-07-03 at 05:05 -0400, Michael S. Tsirkin wrote: > From: Cindy Lu > > Currently we have 2 types of vhost backends in QEMU: vhost kernel and > vhost-user. The above patch provides a generic device for vDPA > purpose, > this vDPA device exposes to user space a non-vendor-specific > conf

Re: [PATCH 00/78] Patch Round-up for stable 4.2.1, freeze on 2020-06-22

2020-06-20 Thread Bruce Rogers
Hi Michael, Our upcoming SLE15-SP2 and Leap 15.2 releases have a qemu package which is based on v4.2.0. In addition to some of the patches already mentioned, here is a list of others we have backported as being stable material. I threw a little wider net this time than usual, so feel free to give

[PATCH] audio: fix wavcapture segfault

2020-05-21 Thread Bruce Rogers
w_read(). Fixes: 571a8c522e (audio: split ctl_* functions into enable_* and volume_*) Signed-off-by: Bruce Rogers --- audio/audio.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/audio/audio.c b/audio/audio.c index 7a9e680355..08a067722b 100644 --- a/audio/audio.c +++ b

[PATCH] module: increase dirs array size by one

2020-04-10 Thread Bruce Rogers
With the module upgrades code change, the statically sized dirs array can now overflow. Increase it's size by one, according to the new maximum possible usage. Fixes: bd83c861c0 ("modules: load modules from versioned /var/run dir") Signed-off-by: Bruce Rogers --- util/module.c

Re: [PATCH v11 03/16] s390x: protvirt: Support unpack facility

2020-03-20 Thread Bruce Rogers
On Thu, 2020-03-19 at 09:19 -0400, Janosch Frank wrote: > The unpack facility provides the means to setup a protected guest. A > protected guest cannot be introspected by the hypervisor or any > user/administrator of the machine it is running on. > > Protected guests are encrypted at rest and need

Re: [PATCH 00/55] Patch Round-up for stable 4.1.1, freeze on 2019-11-12

2019-11-12 Thread Bruce Rogers
On Tue, 2019-11-05 at 14:51 -0600, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v4.1.1: > > https://github.com/mdroth/qemu/commits/stable-4.1-staging > > The release is tentatively planned for 2019-11-14: > > https://wiki.qemu.org/Planning/4.1

Re: [Resend PATCH 0/3] Add CPU model for intel processor Cooper Lake

2019-11-11 Thread Bruce Rogers
On Wed, 2019-10-23 at 23:52 -0300, Eduardo Habkost wrote: > On Tue, Oct 22, 2019 at 03:35:25PM +0800, Cathy Zhang wrote: > > This patchset is to add CPU model for intel processor Cooper Lake. > > It > > will inherit features from the existing CPU model Cascadelake- > > Server, > > meanwhile, add th

Re: [Resend PATCH 3/3] i386: Add new CPU model Cooperlake

2019-10-24 Thread Bruce Rogers
XSAVE_XGETBV1, > +.features[FEAT_6_EAX] = > + CPUID_6_EAX_ARAT, > +.xlevel = 0x8008, > +.model_id = "Intel Xeon Processor (Cooperlake)", > +}, > +{ > .name = "Icelake-Client", > .level = 0xd, > .vendor = CPUID_VENDOR_INTEL, Looks fine to me. Reviewed-by: Bruce Rogers - Bruce

Re: [PATCH] iotests: Remove 130 from the "auto" group

2019-10-18 Thread Bruce Rogers
On Fri, 2019-10-18 at 18:10 +0200, Thomas Huth wrote: > Peter hit a "Could not open 'TEST_DIR/t.IMGFMT': Failed to get shared > 'write' lock - Is another process using the image > [TEST_DIR/t.IMGFMT]?" > error with 130 already twice. Looks like this test is a little bit > shaky, and currently nobod

Re: [Qemu-devel] current QEMU can't start pc-q35-2.12 SEV guest

2019-08-15 Thread Bruce Rogers
On Thu, 2019-08-15 at 15:43 -0300, Eduardo Habkost wrote: > On Thu, Aug 15, 2019 at 12:49:58AM +0000, Bruce Rogers wrote: > > Hi, > > > > I ran into a case where a guest on a SEV capable host, which was > > enabled to use SEV and using an older machine type was no long

[Qemu-devel] current QEMU can't start pc-q35-2.12 SEV guest

2019-08-14 Thread Bruce Rogers
Hi, I ran into a case where a guest on a SEV capable host, which was enabled to use SEV and using an older machine type was no longer able to run when the QEMU version had been updated. Specifically, when the guest was installed and running under a v2.12 QEMU, set up for SEV (ok it was v2.11 with

Re: [Qemu-devel] [Qemu-stable] [PATCH 00/36] Patch Round-up for stable 3.1.1, freeze on 2019-07-29

2019-07-29 Thread Bruce Rogers
On Tue, 2019-07-23 at 12:00 -0500, Michael Roth wrote: > Hi > everyone, > > > The following new patches are queued for QEMU stable v3.1.1: > > https://github.com/mdroth/qemu/commits/stable-3.1-staging

Re: [Qemu-devel] Fixing Snowridge CPU model name and features

2019-07-29 Thread Bruce Rogers
On Tue, 2019-07-16 at 08:58 -0700, Paul Lai wrote: > Changing the name to Snowridge from SnowRidge-Server. > There is no client model of Snowridge, so "-Server" is unnecessary. > > Removing CPUID_EXT_VMX from Snowridge cpu feature list. > > Signed-off-by: Paul Lai > Tested-by: Tao3 Xu > --- >

Re: [Qemu-devel] [PULL 6/6] ati-vga: switch to vgabios-ati.bin

2019-07-02 Thread Bruce Rogers
On Fri, 2019-06-28 at 12:39 +0200, Gerd Hoffmann wrote: > Signed-off-by: Gerd Hoffmann > Tested-by: BALATON Zoltan > Message-id: 20190620151104.2678-4-kra...@redhat.com > Signed-off-by: Gerd Hoffmann > --- > hw/display/ati.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --gi

Re: [Qemu-devel] Recent python-sphinx errors out building doc

2019-06-18 Thread Bruce Rogers
>>> On 6/18/2019 at 6:11 PM, John Snow wrote: > > On 6/18/19 7:37 PM, Bruce Rogers wrote: >> Hi, >> >> (Resent with correct address for John) >> I build recent upstream qemu in the openSUSE Build Service, and for >> the Factory repository there, pyt

[Qemu-devel] Recent python-sphinx errors out building doc

2019-06-18 Thread Bruce Rogers
Hi, (Resent with correct address for John) I build recent upstream qemu in the openSUSE Build Service, and for the Factory repository there, python-sphinx was recently updated to version 2.1.1. This caused the build to fail as follows: /home/abuild/rpmbuild/BUILD/qemu-4.0.50/docs/interop/bitmaps.

[Qemu-devel] Recent python-sphinx errors out building doc

2019-06-18 Thread Bruce Rogers
Hi, I build recent upstream qemu in the openSUSE Build Service, and for the Factory repository there, python-sphinx was recently updated to version 2.1.1. This caused the build to fail as follows: /home/abuild/rpmbuild/BUILD/qemu-4.0.50/docs/interop/bitmaps.rst:202:Could not lex literal_block as

Re: [Qemu-devel] [PATCH] hw/smbios: handle both file formats regardless of machine type

2019-05-09 Thread Bruce Rogers
>>> On 4/11/2019 at 11:51 AM, Bruce Rogers wrote: > It's easy enough to handle either per‑spec or legacy smbios structures > in the smbios file input without regard to the machine type used, by > simply applying the basic smbios formatting rules. then depending on >

[Qemu-devel] [PATCH] scsi-disk: assert positive value to avoid compiler warning

2019-05-01 Thread Bruce Rogers
g_malloc (gsize n_bytes) G_GNUC_MALLOC G_GNUC_ALLOC_SIZE(1); Asserting that len is positive avoids this diagnostic. This assert is reasonable since the error case of scsi_cdb_length() has already been handled by a previous call to that function. Signed-off-by: Bruce Rogers --- hw/scsi/scsi

Re: [Qemu-devel] [PATCH v2] scsi-disk: handle invalid cdb length

2019-05-01 Thread Bruce Rogers
>>> On 4/30/2019 at 2:40 PM, John Snow wrote: > > On 4/30/19 9:19 AM, Bruce Rogers wrote: >> While investigating link-time-optimization, the compiler flagged this >> case of not handling the error return from scsi_cdb_length(). Handle >> this error case with a t

[Qemu-devel] [PATCH v2] scsi-disk: handle invalid cdb length

2019-04-30 Thread Bruce Rogers
While investigating link-time-optimization, the compiler flagged this case of not handling the error return from scsi_cdb_length(). Handle this error case with a trace report. Signed-off-by: Bruce Rogers --- hw/scsi/scsi-disk.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/scsi

Re: [Qemu-devel] [PATCH] scsi-disk: handle invalid cdb length

2019-04-29 Thread Bruce Rogers
>>> On 4/29/2019 at 7:37 PM, Eric Blake wrote: > On 4/29/19 6:51 PM, Bruce Rogers wrote: >> While investigating link-time-optimization, the compiler flagged this >> case of not handling the error return from scsi_cdb_length(). Handle >> this error case with a trac

[Qemu-devel] [PATCH] scsi-disk: handle invalid cdb length

2019-04-29 Thread Bruce Rogers
While investigating link-time-optimization, the compiler flagged this case of not handling the error return from scsi_cdb_length(). Handle this error case with a trace report. Signed-off-by: Bruce Rogers --- hw/scsi/scsi-disk.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/scsi

[Qemu-devel] [PATCH] hw/smbios: handle both file formats regardless of machine type

2019-04-11 Thread Bruce Rogers
cific processing. Signed-off-by: Bruce Rogers --- hw/smbios/smbios.c | 43 +++ 1 file changed, 39 insertions(+), 4 deletions(-) diff --git a/hw/smbios/smbios.c b/hw/smbios/smbios.c index 47be9071fa..d4b95ebc84 100644 --- a/hw/smbios/smbios.c +++ b/hw/smbios/smb

Re: [Qemu-devel] [Bug 1813165] Re: KVM internal error. Suberror: 1 emulation failure

2019-02-22 Thread Bruce Rogers
I've been trying to get down to the bottom of this. It looks like you've got it. I can confirm that this fixes the issue for me. Thanks! Tested-by: Bruce Rogers > -- > You received this bug notification because you are a member of qemu- > devel-ml, which is subscribed to QE

Re: [Qemu-devel] [PATCH 00/113] Patch Round-up for stable 2.11.2, freeze on 2018-06-22

2018-06-19 Thread Bruce Rogers
>>> On 6/18/2018 at 7:41 PM, Michael Roth wrote: > Hi everyone, > > The following new patches are queued for QEMU stable v2.11.2: > > https://github.com/mdroth/qemu/commits/stable-2.11-staging > > The release is planned for 2018-06-22: > > https://wiki.qemu.org/Planning/2.11 > > Please

Re: [Qemu-devel] [PATCH 1/2] xen: add xen disk naming for use in monitor

2018-06-13 Thread Bruce Rogers
>>> On 6/13/2018 at 5:46 AM, Anthony PERARD wrote: > On Tue, Jun 12, 2018 at 05:51:02PM ‑0600, Bruce Rogers wrote: >> Provide monitor naming of xen disks, including associating an >> attached dev_id for a BlockBackend which has legacy_dev set. >> Currently, only xe

[Qemu-devel] [PATCH 2/2] xen: add block resize support for xen disks

2018-06-12 Thread Bruce Rogers
In the context of a monitor based disk resize, provide notification of the new size to the front end xen block driver via a xenstore update. Signed-off-by: Bruce Rogers --- block/block-backend.c | 7 +++ blockdev.c | 8 hw/block/xen_disk.c

[Qemu-devel] [PATCH 1/2] xen: add xen disk naming for use in monitor

2018-06-12 Thread Bruce Rogers
Provide monitor naming of xen disks, including associating an attached dev_id for a BlockBackend which has legacy_dev set. Currently, only xen disks have legacy_dev set to true. Signed-off-by: Bruce Rogers --- block/block-backend.c | 5 - hw/block/xen_disk.c | 15 +++ include

[Qemu-devel] [PATCH 0/2] xen: add block resize infrastructure

2018-06-12 Thread Bruce Rogers
quot;info block" and "block_resize" commands to help identify and then resize a Xen qdisk. It is anticipated that Xen's libxl will be extended to handle qdisk resizing without resorting to using the human monitor in this way, with libvirt support eventually building on top of that

Re: [Qemu-devel] [PATCH 0/3] ahci: fix completion race condition

2018-05-31 Thread Bruce Rogers
>>> On 5/31/2018 at 7:06 AM, Philippe Mathieu-Daudé wrote: > Hi Bruce, > > On 05/31/2018 09:21 AM, Bruce Rogers wrote: >>>>> On 5/30/2018 at 6:43 PM, John Snow wrote: >>> Commit d759c951f changed the main thread lock release/reacquisition, >>&

Re: [Qemu-devel] [PATCH 0/3] ahci: fix completion race condition

2018-05-31 Thread Bruce Rogers
>>> On 5/30/2018 at 6:43 PM, John Snow wrote: > Commit d759c951f changed the main thread lock release/reacquisition, > and in so doing apparently jostled loose a race condition in the AHCI > code. > > Patch 2 should be sufficient to fix this, and patches 1 and 3 are just > little trivial fixes. >

[Qemu-devel] [Bug 1769189] Re: Issue with qemu 2.12.0 + SATA

2018-05-25 Thread Bruce Rogers
I can confirm that for me commit d759c951 does cause / expose the issue. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1769189 Title: Issue with qemu 2.12.0 + SATA Status in QEMU: New Bug descr

[Qemu-devel] [Bug 1769189] Re: Issue with qemu 2.12.0 + SATA

2018-05-23 Thread Bruce Rogers
I've tried bisecting a few times, but since my reproducer wasn't reliable enough, I didn't identify the issue. (I see a bisect reported on qemu ML which seems like a bogus result, similar to mine). In my case, after the "hang", Windows 10 resets the ahci device after 2 minutes and it continues on

[Qemu-devel] [PATCH] sys_membarrier: fix up include directives

2018-03-29 Thread Bruce Rogers
Our rule right now is to use <> for external headers only. util/sys_membarrier.c violates that. Fix it up. Signed-off-by: Bruce Rogers --- util/sys_membarrier.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/util/sys_membarrier.c b/util/sys_membarrier.c

[Qemu-devel] [PATCH] make: switch language file build to be gtk module aware

2018-03-07 Thread Bruce Rogers
Now that gtk support builds as a module, CONFIG_GTK changed from y to m. Adjust Makefile correspondingly. Signed-off-by: Bruce Rogers --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 9a75c48ae0..026fa17dc0 100644 --- a/Makefile +++ b

Re: [Qemu-devel] [qemu-web PATCH] Add a blog post documenting Spectre/Meltdown options for QEMU 2.11.1

2018-02-13 Thread Bruce Rogers
On 2/13/2018 at 5:11 PM, Michael Roth wrote: > This blog entry is intended as a follow‑up to the original entry in > January regarding Spectre/Meltdown and the proposed changes to address > them in the upcoming 2.11.1 release. > > This entry is meant to accompany the 2.11.1 release (planned for >

Re: [Qemu-devel] [PATCH v6 00/23] x86: Secure Encrypted Virtualization (AMD)

2018-02-06 Thread Bruce Rogers
>>> On 1/29/2018 at 10:41 AM, wrote: > This patch series provides support for AMD's new Secure Encrypted > Virtualization (SEV) feature. > > SEV is an extension to the AMD‑V architecture which supports running > multiple VMs under the control of a hypervisor. The SEV feature allows > the memory

Re: [Qemu-devel] [Qemu-stable] [PATCH 00/79] Patch Round-up for stable 2.9.1, freeze on 2017-09-04

2017-09-01 Thread Bruce Rogers
which seem to be stable material: d54fddea xhci: only update dequeue ptr on completed transfers 04bf2526 exec: use qemu_ram_ptr_length to access guest ram This second patch has a follow on due to negatively affecting xen usage: f5aa69bd exec: Add locking parameter to qemu_ram_ptr_length Thanks. Bruce Rogers

[Qemu-devel] [PATCH] 9pfs: local: remove: use correct path component

2017-06-19 Thread Bruce Rogers
Commit a0e640a8 introduced a path processing error. Pass fstatat the dirpath based path component instead of the entire path. Signed-off-by: Bruce Rogers --- hw/9pfs/9p-local.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/9pfs/9p-local.c b/hw/9pfs/9p-local.c index

[Qemu-devel] [PATCH v2] ACPI: don't call acpi_pcihp_device_plug_cb on xen

2017-04-28 Thread Bruce Rogers
following error report: "Unsupported bus. Bus doesn't have property 'acpi-pcihp-bsel' set". Signed-off-by: Bruce Rogers --- hw/acpi/piix4.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index a553a7e..c409374 1

Re: [Qemu-devel] [PATCH] ACPI: don't call acpi_pcihp_device_plug_cb on xen

2017-04-27 Thread Bruce Rogers
>>> On 4/27/2017 at 03:09 PM, Stefano Stabellini >>> wrote: > On Thu, 27 Apr 2017, Bruce Rogers wrote: >> Commit f0c9d64a exposed the issue that with a xenfv machine using >> pci passthrough, acpi cpi hotplug code was being executed by mistake. >> Guard

[Qemu-devel] [PATCH] ACPI: don't call acpi_pcihp_device_plug_cb on xen

2017-04-27 Thread Bruce Rogers
that the bus doesn't have the acpi-pcihp-bsel property set. Signed-off-by: Bruce Rogers --- hw/acpi/piix4.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/hw/acpi/piix4.c b/hw/acpi/piix4.c index a553a7e..c409374 100644 --- a/hw/acpi/piix4.c +++ b/hw/acpi/pi

Re: [Qemu-devel] [PATCH] ACPI: call acpi_set_pci_info when only acpi enabled

2017-04-27 Thread Bruce Rogers
>>> On 4/27/2017 at 12:08 PM, Stefano Stabellini >>> wrote: > On Thu, 27 Apr 2017, Igor Mammedov wrote: >> On Thu, 27 Apr 2017 10:51:23 -0600 >> "Bruce Rogers" wrote: >> >> > >> > >> > >>> On 4/

Re: [Qemu-devel] [PATCH] ACPI: call acpi_set_pci_info when only acpi enabled

2017-04-27 Thread Bruce Rogers
>>> On 4/27/2017 at 10:08 AM, Igor Mammedov wrote: > On Thu, 27 Apr 2017 09:44:31 -0600 > "Bruce Rogers" wrote: > >> >>> On 4/27/2017 at 03:11 AM, Igor Mammedov wrote: >> > On Wed, 26 Apr 2017 13:07:02 -0600 >> > Bruce Rogers

Re: [Qemu-devel] [PATCH] ACPI: call acpi_set_pci_info when only acpi enabled

2017-04-27 Thread Bruce Rogers
>>> On 4/27/2017 at 10:08 AM, Igor Mammedov wrote: > On Thu, 27 Apr 2017 09:44:31 -0600 > "Bruce Rogers" wrote: > >> >>> On 4/27/2017 at 03:11 AM, Igor Mammedov wrote: >> > On Wed, 26 Apr 2017 13:07:02 -0600 >> > Bruce Rogers

Re: [Qemu-devel] [PATCH] ACPI: call acpi_set_pci_info when only acpi enabled

2017-04-27 Thread Bruce Rogers
>>> On 4/27/2017 at 03:11 AM, Igor Mammedov wrote: > On Wed, 26 Apr 2017 13:07:02 -0600 > Bruce Rogers wrote: > >> Commit f0c9d64a exposed an issue with the code order in acpi_setup. >> As of that commit, a xenfv machine type guest will no longer start >> if

[Qemu-devel] [PATCH] ACPI: call acpi_set_pci_info when only acpi enabled

2017-04-26 Thread Bruce Rogers
change I can again use pci passthrough and xenfv together. Signed-off-by: Bruce Rogers --- hw/i386/acpi-build.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c index 2073108..1ec072f 100644 --- a/hw/i386/acpi-build.c

Re: [Qemu-devel] [RFC PATCH] configure: remove --enable-replication/--disable-replication

2017-03-03 Thread Bruce Rogers
>>> On 2/6/2017 at 4:57 AM, wrote: > * Paolo Bonzini (pbonz...@redhat.com) wrote: >> >> >> On 03/02/2017 07:00, Stefan Hajnoczi wrote: >> > On Thu, Feb 02, 2017 at 07:05:30AM ‑0800, Paolo Bonzini wrote: >> >> The replication feature is a small amount of code, does not >> >> require any external

Re: [Qemu-devel] [PATCH] linux-user: Exclude more cpu model code when building s390x linux-user

2017-03-02 Thread Bruce Rogers
>>> On 3/2/2017 at 12:53 PM, wrote: > Am 02.03.2017 um 20:50 schrieb David Hildenbrand: >> Am 02.03.2017 um 20:33 schrieb Bruce Rogers: >>> Currently qemu-s390x segfaults. Avoid cpu model code which doesn't >>> apply in linux user case. >> &g

[Qemu-devel] [PATCH] linux-user: Exclude more cpu model code when building s390x linux-user

2017-03-02 Thread Bruce Rogers
Currently qemu-s390x segfaults. Avoid cpu model code which doesn't apply in linux user case. Signed-off-by: Bruce Rogers --- target/s390x/cpu_models.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c index 2a894

[Qemu-devel] [PATCH] tests: check path to avoid a failing qga/get-vcpus test

2017-03-02 Thread Bruce Rogers
The qga/get-vcpus test fails in a simple chroot environment, as used in an openSUSE Build Service local build, so first check that the sysfs based path exists in order to avoid calling this test in an environment where it won't work right. Signed-off-by: Bruce Rogers --- tests/test-qga.

[Qemu-devel] [PATCH] linux-user: Exclude more cpu model code when building s390x linux-user

2017-03-02 Thread Bruce Rogers
Currently qemu-s390x segfaults. Avoid cpu model code which doesn't apply in linux user case. --- target/s390x/cpu_models.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/target/s390x/cpu_models.c b/target/s390x/cpu_models.c index 2a894eec65..97e4e75f68 100644 --- a/targe

[Qemu-devel] [PATCH] display: cirrus: ignore source pitch value as needed in blit_is_unsafe

2017-01-09 Thread Bruce Rogers
SLES 11 SP4 guest gui failed to initialize properly. Signed-off-by: Bruce Rogers --- hw/display/cirrus_vga.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/hw/display/cirrus_vga.c b/hw/display/cirrus_vga.c index bdb092ee9d..379910db2d 100644 --- a/hw/display

Re: [Qemu-devel] [PATCH 00/56] Patch Round-up for stable 2.6.1, freeze on 2016-08-12

2016-08-09 Thread Bruce Rogers
Michael, Please add 0968c91 Xen PCI passthrough: fix passthrough failure when no interrupt pin to the list for 2.6.1. Thanks! Bruce Rogers >>> Michael Roth 8/8/2016 3:03 PM >>> Hi everyone, The following new patches are queued for QEMU stable v2.6.1: https://gith

Re: [Qemu-devel] [PATCH for-2.7] Xen PCI passthrough: fix passthrough failure when no interrupt pin

2016-08-01 Thread Bruce Rogers
7/27/2016 11:30 PM, Bruce Rogers wrote: > Commit 5a11d0f7 mistakenly converted a log message into an error > condition when no pin interrupt is found for the pci device being > passed through. Revert that part of the commit. > > Signed-off-by: Bruce Rogers > --- > hw/xen/xen_pt.c

[Qemu-devel] [PATCH for-2.7] Xen PCI passthrough: fix passthrough failure when no interrupt pin

2016-07-27 Thread Bruce Rogers
Commit 5a11d0f7 mistakenly converted a log message into an error condition when no pin interrupt is found for the pci device being passed through. Revert that part of the commit. Signed-off-by: Bruce Rogers --- hw/xen/xen_pt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a

[Qemu-devel] [PATCH] pic: fix typo in error message: KVM_GET_IRQCHIP -> KVM_SET_IRQCHIP

2016-06-17 Thread Bruce Rogers
Signed-off-by: Bruce Rogers --- hw/i386/kvm/i8259.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/i386/kvm/i8259.c b/hw/i386/kvm/i8259.c index 2b207de..11d1b72 100644 --- a/hw/i386/kvm/i8259.c +++ b/hw/i386/kvm/i8259.c @@ -92,7 +92,7 @@ static void kvm_pic_put

Re: [Qemu-devel] [PATCH] crypto: fix nettle config check for running pbkdf test

2016-04-04 Thread Bruce Rogers
>>> On 4/4/2016 at 09:24 AM, "Daniel P. Berrange" wrote: > The pbkdf test is being built based on a check for CONFIG_NETTLE. > As of fff2f982ab6ac0dd2b641d30303f72270a019f28, it should be > instead checking CONFIG_NETTLE_KDF > > Reported-by: "Dr. David Ala

Re: [Qemu-devel] [PATCH] crypto: do an explicit check for nettle pbkdf functions

2016-03-31 Thread Bruce Rogers
>>> On 3/29/2016 at 08:50 AM, "Daniel P. Berrange" wrote: > Support for the PBKDF functions in nettle was not introduced > until version 2.6. Some distros QEMU targets have older > versions and thus lack PBKDF support. Address this by doing > a check in configure for the desired function and then

[Qemu-devel] [PATCH] acpi: remove no longer used acpi-dsdt.aml

2016-03-19 Thread Bruce Rogers
This file is no longer used. Remove it from pc-bios/ and from the list of blobs to install. Signed-off-by: Bruce Rogers --- Makefile | 1 - pc-bios/acpi-dsdt.aml | Bin 4405 -> 0 bytes 2 files changed, 1 deletion(-) delete mode 100644 pc-bios/acpi-dsdt.aml diff --git a/Makef

Re: [Qemu-devel] ivshmem property size should be a size, not a string

2015-11-23 Thread Bruce Rogers
>>> On 11/20/2015 at 09:07 AM, Markus Armbruster wrote: > Everybody's favourite device model has "size" property. It's declared > as *string* > > DEFINE_PROP_STRING("size", IVShmemState, sizearg), > > which gets converted to a size manually in the realize method: > > } else if (s->siz

Re: [Qemu-devel] [PATCH] bios-tables-test: handle false-positive smbios signature matches

2015-03-31 Thread Bruce Rogers
; +} > + > +if (!memcmp(sig, "_SM_", sizeof sig)) { > +/* signature match, but is this a valid entry point? */ > +data->smbios_ep_addr = off; > +if (smbios_ep_table_ok(data)) { > +break; > +} > + } > +} > + > +g_assert_cmphex(off, <, 0x10); > } > > static inline bool smbios_single_instance(uint8_t type) > @@ -767,8 +780,7 @@ static void test_acpi_one(const char *params, test_data > *data) > } > } > > -test_smbios_ep_address(data); > -test_smbios_ep_table(data); > +test_smbios_entry_point(data); > test_smbios_structs(data); > > qtest_quit(global_qtest); I tried this out in my case which previously failed - worked great. Thanks! Bruce Tested-by: Bruce Rogers

Re: [Qemu-devel] [SeaBIOS] [PATCH] smbios: ensure comparison SMBIOS string can't be paragraph aligned

2015-03-31 Thread Bruce Rogers
>>> On 3/31/2015 at 10:46 AM, Kevin O'Connor wrote: > On Tue, Mar 31, 2015 at 12:37:30PM -0400, Gabriel L. Somlo wrote: >> On Tue, Mar 31, 2015 at 08:49:58AM -0600, Bruce Rogers wrote: >> > >>> On 3/30/2015 at 10:02 PM, Kevin O'Connor wrote: &

Re: [Qemu-devel] [SeaBIOS] [PATCH] smbios: ensure comparison SMBIOS string can't be paragraph aligned

2015-03-31 Thread Bruce Rogers
>>> On 3/30/2015 at 10:02 PM, Kevin O'Connor wrote: > On Mon, Mar 30, 2015 at 05:06:30PM -0600, Bruce Rogers wrote: >> The SMBIOS anchor string _SM_ is stored within SeaBIOS to validate >> an SMBIOS entry point structure. There is the possibility (observed) >>

Re: [Qemu-devel] [PATCH for-2.1] pc: fix qemu exiting with error when -m X < 128 with old machines types

2014-07-17 Thread Bruce Rogers
;slots|maxmem'" is not supported by: isapc > > Set maxram_size to initial memory value before parsing > 'maxmem' option allows to keep maxmem in sync with initial > memory size if no maxmem option was specified. > > Signed-off-by: Igor Mammedov > CC: Bruce Rog

Re: [Qemu-devel] [PATCH for-2.1] pc: fix qemu exiting with error when -m X < 128 with old machines types

2014-07-17 Thread Bruce Rogers
gt;> >> $QEMU -m 16 -M isapc >> qemu-system-i386: "-memory 'slots|maxmem'" is not supported by: isapc >> >> Set maxram_size to initial memory value before parsing >> 'maxmem' option allows to keep maxmem in sync with initial >&

Re: [Qemu-devel] [PATCH] vl.c: Keep maxram_size and ram_size consistent unless specified otherwise

2014-07-09 Thread Bruce Rogers
>>> On 7/8/2014 at 07:23 AM, wrote: > On Mon, 7 Jul 2014 17:05:22 -0600 > Bruce Rogers wrote: > >> When using a memory size less than the default amount with older pc >> machine types, a failure occurs because of the way maxram_size and >> ram_size g

[Qemu-devel] [PATCH] vl.c: Keep maxram_size and ram_size consistent unless specified otherwise

2014-07-07 Thread Bruce Rogers
When using a memory size less than the default amount with older pc machine types, a failure occurs because of the way maxram_size and ram_size get initialized. Keep maxram_size and ram_size the same, except when maxmem is specified on the command line. Signed-off-by: Bruce Rogers --- vl.c | 2

[Qemu-devel] [Bug 1320360] Re: usb passthrough not working anymore

2014-05-19 Thread Bruce Rogers
Martin, The OBS Virtualization/qemu project doesn't build QEMU v2.0 with libusb support for openSUSE 13.1, because the version provided in that distro was 1.0.9, and QEMU's configure requires 1.0.13. Bruce -- You received this bug notification because you are a member of qemu- devel-ml, which

[Qemu-devel] [PATCH] gtk: Add handling for the xfree86 keycodes

2014-04-30 Thread Bruce Rogers
Currently only evdev keycodes are handled by the gtk-ui. SDL has code to handle both. This patch adds similar processing so that both keycode types will be handled via the gtk-ui. Signed-off-by: Bruce Rogers --- ui/gtk.c | 36 +++- 1 file changed, 35 insertions

  1   2   >