Re: [Qemu-devel] [RFC] [PATCH 0/5] Add horizontal wheel support to mice, where possible

2010-06-02 Thread Brad Jorsch
On Wed, Jun 02, 2010 at 08:30:11AM -0500, Anthony Liguori wrote: > > I think instead of adding an additional parameter for horizontal > wheel, we should look at making the API capable of > accepting/generating arbitrary button presses. > > Really, we should just drop dz and treat vertical wheel a

[Qemu-devel] [PATCH 2/2] Count "logo" keys as modifier keys

2010-05-05 Thread Brad Jorsch
These are often mapped to Meta on Linux. And I for one use Meta-Tab as the equivalent of Windows's Alt-Tab, so not having it marked as a modifier leaves the guest thinking it's permanently pressed. Signed-off-by: Brad Jorsch --- sdl.c |2 ++ 1 files changed, 2 insertions(+), 0

[Qemu-devel] [PATCH 0/2] Release modifier keys (including Meta) on loss of focus

2010-05-05 Thread Brad Jorsch
I got tired of my guests thinking that the logo key was being constantly held down whenever I used Meta-Tab to switch away from the qemu window. It turns out that both the "clear modifiers on focus loss" feature in the SDL front-end was broken and Meta (i.e. the "logo" keys) wasn't being considere

[Qemu-devel] [PATCH 1/2] Fix clearing modifiers on focus loss

2010-05-05 Thread Brad Jorsch
It seems there is an intention to clear all modifier keys (in the SDL front-end) when the window loses focus, but it seems that it doesn't work right. Let's just explicitly do it when we lose input focus. Signed-off-by: Brad Jorsch --- sdl.c |3 +++ 1 files changed, 3 insert

[Qemu-devel] [RFC] [PATCH 0/5] Add horizontal wheel support to mice, where possible

2010-05-04 Thread Brad Jorsch
The emulated mice should emulate a horizontal wheel when possible. This patch series does that for the USB mouse and tablet and the ExPS/2 mouse. As far as I can tell the vmmouse protocol doesn't handle a horizontal wheel, and I have no idea if emulating a wheel might make sense for any of the othe

[Qemu-devel] [PATCH 5/5] Add a horizontal wheel to the exps/2 mouse

2010-05-04 Thread Brad Jorsch
Have the emulated mouse report horizontal wheel events when in exps/2 mode. Signed-off-by: Brad Jorsch --- hw/ps2.c | 56 +++- 1 files changed, 43 insertions(+), 13 deletions(-) diff --git a/hw/ps2.c b/hw/ps2.c index db5605d..09e4365 100644

[Qemu-devel] [PATCH 4/5] Add a horizontal wheel to the USB mouse and tablet

2010-05-04 Thread Brad Jorsch
Adjust the USB report descriptors to indicate that the mouse and tablet have horizontal wheels, and then report the delta when polled. Signed-off-by: Brad Jorsch --- hw/usb-hid.c | 44 1 files changed, 36 insertions(+), 8 deletions(-) diff --git a

[Qemu-devel] [PATCH 3/5] Pass hwheel events from the front-ends

2010-05-04 Thread Brad Jorsch
SDL seems to report hwheel events as SDL_BUTTON_X1 and SDL_BUTTON_X2. VNC I am guessing is similar, and online docs indicate that Cocoa reports hwheel deltas in deltaX for NSScrollWheel. Signed-off-by: Brad Jorsch --- cocoa.m |2 +- sdl.c | 12 ++-- vnc.c | 11 --- 3

[Qemu-devel] [PATCH 1/5] Add function parameters for hwheel

2010-05-04 Thread Brad Jorsch
Add a parameter for the hwheel delta to QEMUPutMouseEntry and kbd_mouse_event, and adjust all users of those to match. At the moment, all calls to kbd_mouse_event will pass 0 for the delta. Signed-off-by: Brad Jorsch --- cocoa.m |6 +++--- console.h |4 ++-- hw

[Qemu-devel] [PATCH 2/5] Add hwheel to monitor mouse_move

2010-05-04 Thread Brad Jorsch
Adds a parameter to the monitor's mouse_move command to specify the hwheel delta. Signed-off-by: Brad Jorsch --- monitor.c |8 ++-- qemu-monitor.hx |4 ++-- 2 files changed, 8 insertions(+), 4 deletions(-) diff --git a/monitor.c b/monitor.c index 520d48d..baff2cf 100644