[PATCH v4] migration: using trace_ to replace DPRINTF

Signed-off-by: Bihong Yu --- migration/block.c | 36 ++-- migration/page_cache.c | 13 +++-- migration/trace-events | 13 + 3 files changed, 34 insertions(+), 28 deletions(-) diff --git a/migration/block.c b/migration/block.c index

[PATCH v3] migration: using trace_ to replace DPRINTF

Signed-off-by: Bihong Yu --- migration/block.c | 36 ++-- migration/page_cache.c | 13 +++-- migration/trace-events | 13 + 3 files changed, 34 insertions(+), 28 deletions(-) diff --git a/migration/block.c b/migration/block.c index

Re: [PATCH v2] migration: using trace_ to replace DPRINTF

OK, thank you for your help. On 2020/10/20 15:18, Philippe Mathieu-Daudé wrote: > On 10/20/20 9:07 AM, Bihong Yu wrote: >> >> >> On 2020/10/20 14:54, Philippe Mathieu-Daudé wrote: >>> On 10/20/20 8:42 AM, Bihong Yu wrote: >>>> Signed-off-by: Bihong Yu &g

Re: [PATCH v2] migration: using trace_ to replace DPRINTF

On 2020/10/20 14:54, Philippe Mathieu-Daudé wrote: > On 10/20/20 8:42 AM, Bihong Yu wrote: >> Signed-off-by: Bihong Yu >> --- >>   migration/block.c  | 36 ++-- >>   migration/page_cache.c | 13 +++-- >&

[PATCH v2] migration: using trace_ to replace DPRINTF

Signed-off-by: Bihong Yu --- migration/block.c | 36 ++-- migration/page_cache.c | 13 +++-- migration/trace-events | 13 + 3 files changed, 34 insertions(+), 28 deletions(-) diff --git a/migration/block.c b/migration/block.c index

[PATCH v3 8/8] migration: Delete redundant spaces

Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index ca4d315..00eac34 100644 --- a/migration/rdma.c +++ b/migration/rdma.c

[PATCH v3 2/8] migration: Don't use '#' flag of printf format

Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/block.c | 2 +- migration/ram.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/migration/block.c b/migration/block.c index 4b8576b..273392b 100644 --- a/migration

[PATCH v3 5/8] migration: Add braces {} for if statement

Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 0aea78f..09178cc 100644 --- a/migration/ram.c +++ b/migration/ram.c

[PATCH v3 7/8] migration: Open brace '{' following function declarations go on the next line

Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/rdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index 0eb42b7..ca4d315 100644 --- a/migration/rdma.c +++ b/migration/rdma.c

[PATCH v3 3/8] migration: Add spaces around operator

Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/migration.c| 4 ++-- migration/postcopy-ram.c | 2 +- migration/ram.c | 2 +- migration/savevm.c | 2 +- migration/vmstate.c | 10 +- 5 files changed, 10

[PATCH v3 4/8] migration: Open brace '{' following struct go on the same line

Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/migration.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/migration/migration.h b/migration/migration.h index deb411a..99784b4 100644 --- a/migration/migration.h +++ b

[PATCH v3 6/8] migration: Do not initialise statics and globals to 0 or NULL

Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/ram.c| 2 +- migration/savevm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 09178cc..2da2b62 100644 --- a/migration/ram.c

[PATCH v3 0/8] Fix some style problems in migration

;VMStateDescription * []" to "VMStateDescription *[]" Bihong Yu (8): migration: Do not use C99 // comments migration: Don't use '#' flag of printf format migration: Add spaces around operator migration: Open brace '{' following struct go on the same

[PATCH v3 1/8] migration: Do not use C99 // comments

Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng Reviewed-by: Dr. David Alan Gilbert --- migration/block.c | 2 +- migration/rdma.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/block.c b/migration/block.c index 737b649..4b8576b 100644 --- a/migration

Re: [PATCH v2 3/8] migration: Add spaces around operator

OK, I will change it to "VMStateDescription *[]". Thank you for your review. On 2020/10/19 19:59, Markus Armbruster wrote: > Bihong Yu writes: > >> Yes, I used to think "const VMStateDescription *[]" was right, but when I >> search >> similar expr

Re: [PATCH v2 3/8] migration: Add spaces around operator

So, I keep the same style. Should I change it to "const VMStateDescription *[]"? On 2020/10/19 16:24, Markus Armbruster wrote: > "Dr. David Alan Gilbert" writes: > >> * Bihong Yu (yubih...@huawei.com) wrote: >>> Signed-off-by: Bihong Yu >>>

Re: [PATCH v1] migration: using trace_ to replace DPRINTF

Thank you for your review.OK ,I will adapt them. On 2020/10/17 17:57, Philippe Mathieu-Daudé wrote: > On 10/17/20 11:35 AM, Bihong Yu wrote: >> Signed-off-by: Bihong Yu >> --- >>   migration/block.c  | 36 ++-- >>  

[PATCH v1] migration: using trace_ to replace DPRINTF

Signed-off-by: Bihong Yu --- migration/block.c | 36 ++-- migration/page_cache.c | 13 +++-- migration/trace-events | 13 + 3 files changed, 34 insertions(+), 28 deletions(-) diff --git a/migration/block.c b/migration/block.c index

Re: [PATCH v2 1/8] migration: Do not use C99 // comments

OK, I will modify it later. On 2020/10/14 9:29, Zheng Chuan wrote: > Also DEBUG_CACHE in migration/page_cache.c is need to rebase on trace_calls. > > On 2020/10/13 21:20, Bihong Yu wrote: >> Thank you for your review. OK, I will try to rewrite the DPRINTF to use >> trace_ i

Re: [PATCH v2 1/8] migration: Do not use C99 // comments

Thank you for your review. OK, I will try to rewrite the DPRINTF to use trace_ instead. On 2020/10/13 17:39, Dr. David Alan Gilbert wrote: > * Bihong Yu (yubih...@huawei.com) wrote: >> Signed-off-by: Bihong Yu >> Reviewed-by: Chuan Zheng > > Reviewed-by: Dr. David Alan

Re: [PATCH v1 2/8] migration: Don't use '#' flag of printf format

Thank you for your review. OK,I have fixed the problem in v2. On 2020/10/12 2:19, Peter Maydell wrote: > On Sun, 11 Oct 2020 at 14:52, Bihong Yu wrote: >> @@ -998,7 +998,7 @@ static int block_load(QEMUFile *f, void *opaque, int >> version_id) >> (addr

[PATCH v2 7/8] migration: Open brace '{' following function declarations go on the next line

Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng --- migration/rdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index 0eb42b7..ca4d315 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -273,7 +273,8 @@ static uint64_t htonll

[PATCH v2 6/8] migration: Do not initialise statics and globals to 0 or NULL

Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng --- migration/ram.c| 2 +- migration/savevm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 09178cc..2da2b62 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -2743,7

[PATCH v2 5/8] migration: Add braces {} for if statement

Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng --- migration/ram.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 0aea78f..09178cc 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -101,14 +101,16 @@ static struct

[PATCH v2 4/8] migration: Open brace '{' following struct go on the same line

Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng --- migration/migration.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/migration/migration.h b/migration/migration.h index deb411a..99784b4 100644 --- a/migration/migration.h +++ b/migration/migration.h @@ -124,8 +124,7

[PATCH v2 8/8] migration: Delete redundant spaces

Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng --- migration/rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index ca4d315..00eac34 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -855,7 +855,7 @@ static int

[PATCH v2 0/8] Fix some style problems in migration

Recently I am reading migration related code, find some style problems in migration directory while using checkpatch.pl to check migration code. Fix the error style problems. v2: - fix Signed-off-by error - fix printf format error: "%0x" -> "0x%x" Bihong Yu (8): mi

[PATCH v2 3/8] migration: Add spaces around operator

Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng --- migration/migration.c| 4 ++-- migration/postcopy-ram.c | 2 +- migration/ram.c | 2 +- migration/savevm.c | 2 +- migration/vmstate.c | 10 +- 5 files changed, 10 insertions(+), 10 deletions(-) diff

[PATCH v2 1/8] migration: Do not use C99 // comments

Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng --- migration/block.c | 2 +- migration/rdma.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/block.c b/migration/block.c index 737b649..4b8576b 100644 --- a/migration/block.c +++ b/migration/block.c @@ -40,7

[PATCH v2 2/8] migration: Don't use '#' flag of printf format

Signed-off-by: Bihong Yu Reviewed-by: Chuan Zheng --- migration/block.c | 2 +- migration/ram.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/migration/block.c b/migration/block.c index 4b8576b..273392b 100644 --- a/migration/block.c +++ b/migration/block.c

[PATCH v1 5/8] migration: Add braces {} for if statement

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/ram.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 90b277b..12e7296 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -101,14 +101,16

[PATCH v1 4/8] migration: Open brace '{' following struct go on the same line

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/migration.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/migration/migration.h b/migration/migration.h index deb411a..99784b4 100644 --- a/migration/migration.h +++ b/migration

[PATCH v1 6/8] migration: Do not initialise statics and globals to 0 or NULL

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/ram.c| 2 +- migration/savevm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 12e7296..f71ff2b 100644 --- a/migration/ram.c +++ b

[PATCH v1 2/8] migration: Don't use '#' flag of printf format

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/block.c | 2 +- migration/ram.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/migration/block.c b/migration/block.c index 4b8576b..399dfb8 100644 --- a/migration/block.c +++ b

[PATCH v1 3/8] migration: Add spaces around operator

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/migration.c| 4 ++-- migration/postcopy-ram.c | 2 +- migration/ram.c | 2 +- migration/savevm.c | 2 +- migration/vmstate.c | 10 +- 5 files changed, 10 insertions

[PATCH v1 1/8] migration: Do not use C99 // comments

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/block.c | 2 +- migration/rdma.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/block.c b/migration/block.c index 737b649..4b8576b 100644 --- a/migration/block.c +++ b

[PATCH v1 0/8] Fix some style problems in migration

Recently I am reading migration related code, find some style problems in migration directory while using checkpatch.pl to check migration code. Fix the error style problems. Bihong Yu (8): migration: Do not use C99 // comments migration: Don't use '#' flag of printf format

[PATCH v1 5/8] migration: Add braces {} for if statement

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/ram.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 90b277b..12e7296 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -101,14 +101,16

[PATCH v1 0/8] Fix some style problems in migration

Recently I am reading migration related code, find some style problems in migration directory while using checkpatch.pl to check migration code. Fix the error style problems. Bihong Yu (8): migration: Do not use C99 // comments migration: Don't use '#' flag of printf format

[PATCH v1 6/8] migration: Do not initialise statics and globals to 0 or NULL

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/ram.c| 2 +- migration/savevm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 12e7296..f71ff2b 100644 --- a/migration/ram.c +++ b

[PATCH v1 8/8] migration: Delete redundant spaces

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index ca4d315..00eac34 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -855,7 +855,7

[PATCH v1 7/8] migration: Open brace '{' following function declarations go on the next line

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/rdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index 0eb42b7..ca4d315 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -273,7 +273,8

[PATCH v1 4/8] migration: Open brace '{' following struct go on the same line

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/migration.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/migration/migration.h b/migration/migration.h index deb411a..99784b4 100644 --- a/migration/migration.h +++ b/migration

[PATCH v1 1/8] migration: Do not use C99 // comments

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/block.c | 2 +- migration/rdma.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/block.c b/migration/block.c index 737b649..4b8576b 100644 --- a/migration/block.c +++ b

[PATCH v1 4/8] migration: Open brace '{' following struct go on the same line

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/migration.h | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/migration/migration.h b/migration/migration.h index deb411a..99784b4 100644 --- a/migration/migration.h +++ b/migration

[PATCH v1 2/8] migration: Don't use '#' flag of printf format

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/block.c | 2 +- migration/ram.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/migration/block.c b/migration/block.c index 4b8576b..399dfb8 100644 --- a/migration/block.c +++ b

[PATCH v1 1/8] migration: Do not use C99 // comments

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/block.c | 2 +- migration/rdma.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/block.c b/migration/block.c index 737b649..4b8576b 100644 --- a/migration/block.c +++ b

[PATCH v1 2/8] migration: Don't use '#' flag of printf format

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/block.c | 2 +- migration/ram.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/migration/block.c b/migration/block.c index 4b8576b..399dfb8 100644 --- a/migration/block.c +++ b

[PATCH v1 7/8] migration: Open brace '{' following function declarations go on the next line

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/rdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index 0eb42b7..ca4d315 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -273,7 +273,8

[PATCH v1 8/8] migration: Delete redundant spaces

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index ca4d315..00eac34 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -855,7 +855,7

[PATCH v1 0/8] Fix some style problems in migration

Recently I am reading migration related code, find some style problems in migration directory while using checkpatch.pl to check migration code. Fix the error style problems. Bihong Yu (8): migration: Do not use C99 // comments migration: Don't use '#' flag of printf format

[PATCH v1 8/8] migration: Delete redundant spaces

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/rdma.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index ca4d315..00eac34 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -855,7 +855,7

[PATCH v1 6/8] migration: Do not initialise statics and globals to 0 or NULL

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/ram.c| 2 +- migration/savevm.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 12e7296..f71ff2b 100644 --- a/migration/ram.c +++ b

[PATCH v1 5/8] migration: Add braces {} for if statement

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/ram.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/migration/ram.c b/migration/ram.c index 90b277b..12e7296 100644 --- a/migration/ram.c +++ b/migration/ram.c @@ -101,14 +101,16

[PATCH v1 3/8] migration: Add spaces around operator

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/migration.c| 4 ++-- migration/postcopy-ram.c | 2 +- migration/ram.c | 2 +- migration/savevm.c | 2 +- migration/vmstate.c | 10 +- 5 files changed, 10 insertions

[PATCH v1 3/8] migration: Add spaces around operator

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/migration.c| 4 ++-- migration/postcopy-ram.c | 2 +- migration/ram.c | 2 +- migration/savevm.c | 2 +- migration/vmstate.c | 10 +- 5 files changed, 10 insertions

[PATCH v1 7/8] migration: Open brace '{' following function declarations go on the next line

Signed-off-by:Bihong Yu Reviewed-by: Chuan Zheng Signed-off-by: Bihong Yu --- migration/rdma.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/migration/rdma.c b/migration/rdma.c index 0eb42b7..ca4d315 100644 --- a/migration/rdma.c +++ b/migration/rdma.c @@ -273,7 +273,8