Am 09.03.2011 09:47, schrieb ext Kevin Wolf:
Am 09.03.2011 00:04, schrieb Peter Lieven:
Am 07.10.2010 um 13:27 schrieb Kevin Wolf:
Am 06.09.2010 16:42, schrieb Bernhard Kohl:
If these messages are not handled correctly the guest driver may hang.
Always mandatory:
- ABORT
- BUS DEVICE RESET
which is called right after init during the
first boot and afterwards during each reboot.
Signed-off-by: Bernhard Kohl
---
hw/wdt_i6300esb.c | 39 +--
1 files changed, 21 insertions(+), 18 deletions(-)
diff --git a/hw/wdt_i6300esb.c b/hw/wdt_i6300esb.c
index
Am 17.11.2010 17:30, schrieb ext Michael S. Tsirkin:
On Wed, Nov 17, 2010 at 05:12:12PM +0100, Bernhard Kohl wrote:
I will fix the guest and inform you after testing.
Then we can skip this patch.
OK, that's best,
Yes, the guest is fixed now. Only dword accesses to
Am 17.11.2010 15:12, schrieb ext Michael S. Tsirkin:
On Tue, Nov 16, 2010 at 05:43:06PM +0100, Bernhard Kohl wrote:
Am 16.11.2010 14:14, schrieb m...@redhat.com:
Although explicitly disallowed by the PCI spec, some guests read a
single byte or word from mmio. Likely a guest OS bug
Am 16.11.2010 14:14, schrieb m...@redhat.com:
Although explicitly disallowed by the PCI spec, some guests read a
single byte or word from mmio. Likely a guest OS bug, but I have an OS
which reads single bytes and it works fine on real hardware.
Signed-off-by: Bernhard Kohl
Signed-off-by
We have an OS which writes to port 0x400 when probing for special hardware.
This causes an exit of the VM. With SeaBIOS this port isn't used anyway.
Signed-off-by: Bernhard Kohl
---
Changes v1 -> v2:
Keep the ports silent. Don't print debug output if DEBUG_BIOS is enabled
w
Am 15.11.2010 12:48, schrieb Bernhard Kohl:
With the latest git versions, e.g. 1.7.2.3, git still prints out
the tag info in addition to the requested format. So let's simply
fetch the first line from the output.
In addition I use the --pretty option instead of --format which
is not recog
Am 15.11.2010 11:42, schrieb ext Michael S. Tsirkin:
On Thu, Aug 19, 2010 at 02:56:51PM +0200, Bernhard Kohl wrote:
It's legal that the guest reads a single byte or word from mmio.
Interesting. The spec seems to say this:
For all accesses to MSI-X Table and MSI-X PBA f
Am 15.11.2010 11:09, schrieb ext Alexander Graf:
On 15.11.2010, at 10:53, Bernhard Kohl wrote:
Am 01.09.2010 16:44, schrieb Bernhard Kohl:
We have an OS which writes to port 0x400 when probing for special hardware.
This causes an exit of the VM. With SeaBIOS this port isn't
5.5.6.
Tested with git versions 1.5.5.6 and 1.7.2.3.
Signed-off-by: Bernhard Kohl
---
kvm/scripts/make-release |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/kvm/scripts/make-release b/kvm/scripts/make-release
index 56302c3..2d050fc 100755
--- a/kvm/scripts/make-release
+++
This is necessary because during reboot of a VM the assigned devices
continue DMA transfers which causes memory corruption.
Signed-off-by: Thomas Ostler
Signed-off-by: Bernhard Kohl
---
Sorry for for the long delay. Finally we added Alex' suggestions
and rebased the patch.
Thanks
Ber
Am 01.09.2010 16:44, schrieb Bernhard Kohl:
We have an OS which writes to port 0x400 when probing for special hardware.
This causes an exit of the VM. With SeaBIOS this port isn't used anyway.
Signed-off-by: Bernhard Kohl
---
hw/pc.c |2 --
1 files changed, 0 insertions(+), 2 dele
Am 22.08.2010 23:34, schrieb ext Anthony Liguori:
On 08/19/2010 07:56 AM, Bernhard Kohl wrote:
It's legal that the guest reads a single byte or word from mmio.
I have an OS which reads single bytes and it works fine on real
hardware. Maybe this happens due to casting.
Signed-o
Am 26.10.2010 15:07, schrieb ext Gleb Natapov:
On Tue, Oct 26, 2010 at 02:40:51PM +0200, Bernhard Kohl wrote:
Am 26.10.2010 12:48, schrieb ext Gleb Natapov:
This is current sate of the patch series for people to comment on.
I dropped ioport double reservation checking from isa-bus
Am 26.10.2010 12:48, schrieb ext Gleb Natapov:
This is current sate of the patch series for people to comment on.
I dropped ioport double reservation checking from isa-bus and added
bus_id field for IDE bus since as Markus pointed out unit has different
meaning there.
This patch series produce n
Am 11.10.2010 12:18, schrieb ext Gleb Natapov:
Currently if VM is started with multiple disks it is almost impossible to
guess which one of them will be used as boot device especially if there
is a mix of ATA/virtio/SCSI devices. Essentially BIOS decides the order
and without looking into the cod
Am 19.09.2010 18:07, schrieb ext Michael S. Tsirkin:
On Tue, Sep 14, 2010 at 05:46:55PM +0200, Bernhard Kohl wrote:
> This patch was motivated by the following use case: In our system
> the VMs usually have 4 NICs, any combination of virtio-net-pci and
> pci-assign NIC devices
Am 17.09.2010 14:30, schrieb ext Jan Kiszka:
Am 17.09.2010 14:26, Peter Lieven wrote:
Am 17.09.2010 um 13:36 schrieb Bernhard Kohl:
Am 16.09.2010 15:57, schrieb ext Peter Lieven:
Hi,
I found the following assertion in my log files after a system reset was
executed
kvm
Am 16.09.2010 15:57, schrieb ext Peter Lieven:
Hi,
I found the following assertion in my log files after a system reset
was executed
kvm: lsi_scsi: error: ORDERED queue not implemented
last message repeated 5 times
kvm: lsi_scsi: error: Unimplemented message 0x0d
kvm: lsi_scsi: error: Unimple
en if there are more NICs of the same type.
Without using the boot=on|off parameter the current behaviour
does not change.
Signed-off-by: Thomas Ostler
Signed-off-by: Bernhard Kohl
---
hw/pci.c|8 +++-
hw/pci.h|1 +
hw/qdev.c |6 ++
hw/qdev.h
Am 07.09.2010 04:04, schrieb ext Christoph Hellwig:
On Mon, Sep 06, 2010 at 05:39:00PM +0200, Alexander Graf wrote:
On 06.09.2010, at 17:06, Bernhard Kohl wrote:
From: Bernhard Kohl
Allow symbolic links which point to /dev/sgX devices.
Couldn't you send an SG_IO test
From: Bernhard Kohl
Allow symbolic links which point to /dev/sgX devices.
Signed-off-by: Bernhard Kohl
---
block/raw-posix.c | 10 --
1 files changed, 8 insertions(+), 2 deletions(-)
diff --git a/block/raw-posix.c b/block/raw-posix.c
index 72fb8ce..4544a57 100644
--- a/block/raw
For the RESERVE and RELEASE commands the length must be zero
and xfer_mode must be SCSI_XFER_NONE.
Signed-off-by: Bernhard Kohl
---
hw/scsi-bus.c |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/hw/scsi-bus.c b/hw/scsi-bus.c
index 7aa0bcd..5a3fd4b 100644
--- a/hw/scsi
If these messages are not handled correctly the guest driver may hang.
Always mandatory:
- ABORT
- BUS DEVICE RESET
Mandatory if tagged queuing is implemented (which disks usually do):
- ABORT TAG
- CLEAR QUEUE
Signed-off-by: Bernhard Kohl
---
hw/lsi53c895a.c | 57
Ensure that pending requests of a SCSI generic device are purged on
system reset. This also avoids calling a NULL function in lsi53c895a.
The lsi code was recently changed to call the .qdev.reset function.
Signed-off-by: Bernhard Kohl
---
hw/scsi-generic.c | 21 +++--
1 files
)
Signed-off-by: Bernhard Kohl
---
hw/scsi-disk.c | 36 +++-
1 files changed, 35 insertions(+), 1 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index b80c9bd..1446ca6 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -892,6 +892,12 @@ static int
Am 06.09.2010 11:33, schrieb ext Kevin Wolf:
Sorry to request another version, but this patch is corrupted by line
wraps. I think it was right when you sent the first version, did you
change anything?
No I didn't change anything. I did 'git commit -s --amend' and
'git format-patch' and then
Am 02.09.2010 16:45, schrieb ext Kevin Wolf:
I suspect the real fix is to add a reset handler to scsi-generic. It
should probably remove the requests like it's currently done in
scsi_destroy. The same change was made for scsi-disk in e9447f35.
Yes, I agree. Let's skip this patch. I'll send
)
Signed-off-by: Bernhard Kohl
---
hw/scsi-disk.c | 36 +++-
1 files changed, 35 insertions(+), 1 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index b80c9bd..1446ca6 100644
--- a/hw/scsi-disk.c
+++ b/hw/scsi-disk.c
@@ -892,6 +892,12 @@ static int
Am 03.09.2010 17:41, schrieb ext Kevin Wolf:
Am 02.09.2010 15:11, schrieb Bernhard Kohl:
I use a legacy OS which depends on some optional SCSI commands.
In fact this implementation does nothing special, but provides minimum
support for the following commands:
REZERO UNIT
WRITE AND VERIFY
Am 02.09.2010 16:32, schrieb ext Kevin Wolf:
Can we add a comment why len can become< 0 and that this is a
workaround for buggy drivers? It's in your commit message, but I prefer
this kind of things to be explained in the code.
Yes I will do that, if we decide to apply this patch (see belo
In scsi-generic the reset() function is not available.
Signed-off-by: Bernhard Kohl
---
hw/lsi53c895a.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
index 5eaf69e..01ff028 100644
--- a/hw/lsi53c895a.c
+++ b/hw/lsi53c895a.c
ned-off-by: Bernhard Kohl
---
hw/scsi-generic.c |6 +-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/hw/scsi-generic.c b/hw/scsi-generic.c
index 9538027..836678c 100644
--- a/hw/scsi-generic.c
+++ b/hw/scsi-generic.c
@@ -169,7 +169,11 @@ static void scsi_read_complete(void * o
I use a legacy OS which depends on some optional SCSI commands.
In fact this implementation does nothing special, but provides minimum
support for the following commands:
REZERO UNIT
WRITE AND VERIFY(10)
WRITE AND VERIFY(12)
WRITE AND VERIFY(16)
MODE SELECT(6)
MODE SELECT(10)
SEEK(6)
SEEK(10)
---
We have an OS which writes to port 0x400 when probing for special hardware.
This causes an exit of the VM. With SeaBIOS this port isn't used anyway.
Signed-off-by: Bernhard Kohl
---
hw/pc.c |2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/hw/pc.c b/hw/pc.c
index 69
Some of them are not compile clean.
Signed-off-by: Bernhard Kohl
---
hw/lsi53c895a.c |4 ++--
hw/scsi-disk.c|8
hw/scsi-generic.c | 18 ++
3 files changed, 20 insertions(+), 10 deletions(-)
diff --git a/hw/lsi53c895a.c b/hw/lsi53c895a.c
index bd7b661
Am 31.08.2010 14:29, schrieb ext Kevin Wolf:
> [PATCH v3 1/6] scsi-disk: fix the mode data length field returned by
the MODE SENSE command
> [PATCH v3 2/6] scsi-disk: fix the mode data header returned by the
MODE SENSE(10) command
> [PATCH v3 3/6] scsi-disk: respect the page control (PC) field
ion. A DBD bit of one
specifies that the target shall not return any block descriptors in the
returned MODE SENSE data."
Signed-off-by: Bernhard Kohl
---
hw/scsi-disk.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 44f99b0.
tp://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.2.10
In mode_sense_page() this patch also avoids multiple hard coded
definitions of the same mode page length. Instead I use the varable
p[1]. In fact the returned length of the mode pages 4 and 5 were wrong
(2 bytes less).
Signed-off-by: Bernha
This series fixes some issues with the MODE SENSE command.
I have an OS which fails during this command. It works fine with
real SCSI disk hardware.
Changes v2 -> v3:
2/6: fixed the mode data length, added a comment
[PATCH v3 1/6] scsi-disk: fix the mode data length field returned by the MODE
The MODE DATA LENGTH field indicates the length in bytes of the following
data that is available to be transferred. The mode data length does not include
the number of bytes in the MODE DATA LENGTH field.
Signed-off-by: Bernhard Kohl
---
hw/scsi-disk.c |2 +-
1 files changed, 1 insertions
s and shall set the sense key to ILLEGAL REQUEST
and the additional sense code to INVALID FIELD IN CDB."
Signed-off-by: Bernhard Kohl
---
hw/scsi-disk.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index e085d5b..44f99b0 100644
---
um to which the density code and block length fields apply. A value
of zero indicates that all of the remaining logical blocks of the logical
unit shall have the medium characteristics specified."
Signed-off-by: Bernhard Kohl
---
hw/scsi-disk.c |3 +--
1 files changed, 1 insertions(+), 2
The header for the MODE SENSE(10) command is 8 bytes long.
Signed-off-by: Bernhard Kohl
---
hw/scsi-disk.c | 38 --
1 files changed, 32 insertions(+), 6 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index b627ffe..3e727b9 100644
--- a/hw/scsi
Am 31.08.2010 12:26, schrieb ext Kevin Wolf:
Am 31.08.2010 11:22, schrieb Bernhard Kohl:
> The MODE DATA LENGTH field indicates the length in bytes of the
following
> data that is available to be transferred. The mode data length does
not include
> the number of bytes in the MODE DA
Am 31.08.2010 11:47, schrieb ext Kevin Wolf:
Am 31.08.2010 11:22, schrieb Bernhard Kohl:
> The header for the MODE SENSE(10) command is 8 bytes long.
>
> Signed-off-by: Bernhard Kohl
> ---
> hw/scsi-disk.c | 33 +++--
> 1 files changed, 2
um to which the density code and block length fields apply. A value
of zero indicates that all of the remaining logical blocks of the logical
unit shall have the medium characteristics specified."
Signed-off-by: Bernhard Kohl
---
hw/scsi-disk.c |3 +--
1 files changed, 1 insertions(+), 2
This series fixes some issues with the MODE SENSE command.
I have an OS which fails during this command. It works fine with
real SCSI disk hardware.
Changes v1 -> v2:
Applied all review comments from Kevin.
1/6: unchanged
2/6: Kevin's comments
3/6: Kevin's comments, renamed the subject of the p
The MODE DATA LENGTH field indicates the length in bytes of the following
data that is available to be transferred. The mode data length does not include
the number of bytes in the MODE DATA LENGTH field.
Signed-off-by: Bernhard Kohl
---
hw/scsi-disk.c |2 +-
1 files changed, 1 insertions
tp://ldkelley.com/SCSI2/SCSI2/SCSI2-08.html#8.2.10
In mode_sense_page() this patch also avoids multiple hard coded
definitions of the same mode page length. Instead I use the varable
p[1]. In fact the returned length of the mode pages 4 and 5 were wrong
(2 bytes less).
Signed-off-by: Bernha
The header for the MODE SENSE(10) command is 8 bytes long.
Signed-off-by: Bernhard Kohl
---
hw/scsi-disk.c | 33 +++--
1 files changed, 27 insertions(+), 6 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index b627ffe..942ae96 100644
--- a/hw/scsi
s and shall set the sense key to ILLEGAL REQUEST
and the additional sense code to INVALID FIELD IN CDB."
Signed-off-by: Bernhard Kohl
---
hw/scsi-disk.c |2 ++
1 files changed, 2 insertions(+), 0 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index aef9199..0041038 100644
---
ion. A DBD bit of one
specifies that the target shall not return any block descriptors in the
returned MODE SENSE data."
Signed-off-by: Bernhard Kohl
---
hw/scsi-disk.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 0041038.
Am 16.08.2010 19:12, schrieb ext Kevin Wolf:
> @@ -654,7 +656,8 @@ static int
scsi_disk_emulate_mode_sense(SCSIRequest *req, uint8_t *outbuf)
> p += 8;
> }
>
> -switch (page) {
> +/* Don't return pages if Changeable Values (1) are requested. */
> +if (page_control !=
Am 16.08.2010 19:34, schrieb ext Kevin Wolf:
The patch itself looks okay. However, it made me wonder what this line
wants to tell us:
if ((~dbd) & nb_sectors) {
Is it just me or doesn't this make any sense at all? dbd is a single
bit, 0x8 if set or 0x0 otherwise. nb_sectors is the number o
Am 16.08.2010 19:02, schrieb ext Kevin Wolf:
> +if (bdrv_get_type_hint(s->bs) == BDRV_TYPE_CDROM ||
> +bdrv_is_read_only(s->bs)) {
This looks like a mismerge. The check for CDROMs was removed when they
became read-only by definition. Please don't reintroduce it.
OK, I will remove
It's legal that the guest reads a single byte or word from mmio.
I have an OS which reads single bytes and it works fine on real
hardware. Maybe this happens due to casting.
Signed-off-by: Bernhard Kohl
---
hw/msix.c | 20
1 files changed, 16 insertions(+), 4 dele
. The only useful version
of this command is Command 0xfe.
(For MCA, replace 3-0 by 1-0 in the above.)
Command 0xfe: System reset
Pulse bit 0 of the output port P2 of the keyboard controller.
This will reset the CPU.
Signed-off-by: Bernhard Kohl
---
hw/pckbd.c | 23 ---
1 fil
Am 16.08.2010 19:39, schrieb ext Kevin Wolf:
Am 02.08.2010 17:31, schrieb Bernhard Kohl:
> This series fixes some issues with the MODE SENSE command.
>
> I have an OS which fails during this command. It works fine with
> real SCSI disk hardware.
In general this series looks fine
The header for the MODE SENSE(10) command is 8 bytes long.
Signed-off-by: Bernhard Kohl
---
hw/scsi-disk.c | 35 ---
1 files changed, 28 insertions(+), 7 deletions(-)
diff --git a/hw/scsi-disk.c b/hw/scsi-disk.c
index 57439f4..927df54 100644
--- a/hw/scsi
which the density code and block length fields apply. A value of zero
indicates that all of the remaining logical blocks of the logical unit shall
have the medium characteristics specified.
Signed-off-by: Bernhard Kohl
---
hw/scsi-disk.c |3 +--
1 files changed, 1 insertions(+), 2 deletions
The MODE DATA LENGTH field indicates the length in bytes of the following
data that is available to be transferred. The mode data length does not include
the number of bytes in the MODE DATA LENGTH field.
Signed-off-by: Bernhard Kohl
---
hw/scsi-disk.c |2 +-
1 files changed, 1 insertions
If the page control (PC) field in the MODE SENSE command defines Changeable
Values to be returned in the mode pages, don't return any mode page as there
is no support to change any values.
Signed-off-by: Bernhard Kohl
---
hw/scsi-disk.c |9 ++---
1 files changed, 6 insertions(
This series fixes some issues with the MODE SENSE command.
I have an OS which fails during this command. It works fine with
real SCSI disk hardware.
Thanks
Bernhard
It's legal that the guest reads a single byte or word from mmio.
I have an OS which reads single bytes and it works fine on real
hardware. Maybe this happens due to casting.
Signed-off-by: Bernhard Kohl
---
hw/msix.c | 20
1 files changed, 16 insertions(+), 4 dele
. The only useful version
of this command is Command 0xfe.
(For MCA, replace 3-0 by 1-0 in the above.)
Command 0xfe: System reset
Pulse bit 0 of the output port P2 of the keyboard controller.
This will reset the CPU.
Signed-off-by: Bernhard Kohl
---
hw/pckbd.c | 23 ---
1 fil
Hi,
recently there was a patch "Update SeaBIOS",
commit 8c929e1e41e61f6287b1770fe821d3d823b021b1.
Now I cannot update my seabios submodule.
I'm using http://git.qemu.org/git/seabios.git.
Is there another seabios repository which is more up-to-date?
$ git submodule status
+7d09d0e3ba11310e973d43
Hi,
could you please run "git update-server-info" on the server
and enable the hooks? At least seabios.git and vgabios.git
cannot be accessed via http://.
And the cgit does not show any tags for all repositories on
http://git.qemu.org/
Thanks,
Bernhard
Am 06.05.2010 15:55, schrieb Bernhard Kohl:
Implementation of the optimized code for these two functions.
This is necessary for virtio which reads and writes VirtQueue index
fields using these functions. The assumption is that this are atomic
operations, which is not the case, if the memcpy
Am 05.05.2010 18:17, schrieb Bernhard Kohl:
Implementation of the optimized code for these two functions.
This is necessary for virtio which reads and writes VirtQueue index
fields using these functions. The assumption is that this are atomic
operations, which is not the case, if the memcpy
code does single byte copying. This happens
for example with an older WindRiver glibc.
Signed-off-by: Bernhard Kohl
---
RESEND: This message did not reach the gmane archive and maybe others.
---
exec.c | 67
+--
1 files changed, 60
I use a legacy guest OS which sends the command 0xfd to the keyboard
controller during initialization. To get rid of the message
"qemu: unsupported keyboard cmd=0x%02x\n" I added support for
the pulse output bit commands.
Signed-off-by: Bernhard Kohl
---
hw/pckb
code does single byte copying. This happens
for example with an older WindRiver glibc.
Signed-off-by: Bernhard Kohl
---
exec.c | 67
+--
1 files changed, 60 insertions(+), 7 deletions(-)
diff --git a/exec.c b/exec.c
index 14d1fd7
I use a legacy guest OS which sends the command 0xfd to the keyboard
controller during initialization. To get rid of the message
"qemu: unsupported keyboard cmd=0x%02x\n" I added support for
the pulse output bit commands.
Signed-off-by: Bernhard Kohl
---
hw/pckb
It's legal that the guest reads a single byte or word from mmio.
Signed-off-by: Bernhard Kohl
---
hw/msix.c | 20
1 files changed, 16 insertions(+), 4 deletions(-)
diff --git a/hw/msix.c b/hw/msix.c
index 2ca0900..773bbbd 100644
--- a/hw/msix.c
+++ b/hw/m
75 matches
Mail list logo