Re: [PATCH 1/2] hw: usb: xhci: Add property to support writing ERSTBA in high-low order

2025-07-17 Thread Bernhard Beschow
Am 16. Juli 2025 20:07:25 UTC schrieb Guenter Roeck : >On Wed, Jul 16, 2025 at 07:59:16PM +0000, Bernhard Beschow wrote: >> >> >> Am 13. April 2025 16:03:16 UTC schrieb Guenter Roeck : >> >On 4/11/25 00:40, Nicholas Piggin wrote: >> >> On Sun Apr 6,

Re: [PATCH v1] PCIE-Host Support 64Bit resource for DesignwarePCIEHost

2025-07-17 Thread Bernhard Beschow
Am 17. Juli 2025 00:51:28 UTC schrieb zhangzhijie : > > >在 2025/7/17 1:53, Bernhard Beschow 写道: >> >> >> Am 15. Juli 2025 06:44:00 UTC schrieb zhangzhijie : >>> 0. DW pcie support 64bit resource >>> 1. DW version type using Linux kernel >

Re: [PATCH 1/2] hw: usb: xhci: Add property to support writing ERSTBA in high-low order

2025-07-16 Thread Bernhard Beschow
Am 13. April 2025 16:03:16 UTC schrieb Guenter Roeck : >On 4/11/25 00:40, Nicholas Piggin wrote: >> On Sun Apr 6, 2025 at 12:00 AM AEST, Guenter Roeck wrote: >>> According to the XHCI specification, ERSTBA should be written in Low-High >>> order. The Linux kernel writes the high word first. This

Re: [PATCH v1] PCIE-Host Support 64Bit resource for DesignwarePCIEHost

2025-07-16 Thread Bernhard Beschow
Am 15. Juli 2025 06:44:00 UTC schrieb zhangzhijie : >0. DW pcie support 64bit resource >1. DW version type using Linux kernel Which machines in QEMU require this change? > >Signed-off-by: zhangzhijie >--- > hw/pci-host/designware.c | 12 +--- > include/hw/pci-host/designware.h

Re: [PATCH] meson: Add most 3rd-party includes as system includes

2025-07-16 Thread Bernhard Beschow
Am 15. Juli 2025 13:45:08 UTC schrieb "Daniel P. Berrangé" : >On Fri, Jul 11, 2025 at 12:00:24PM +0100, Daniel P. Berrangé wrote: >> On Fri, Jul 11, 2025 at 11:45:08AM +0100, Peter Maydell wrote: >> > On Tue, 17 Jun 2025 at 21:35, Bernhard Beschow wrote: >&

Re: [PATCH v2 0/3] DTB build housekeeping

2025-07-14 Thread Bernhard Beschow
Am 8. Juli 2025 20:48:03 UTC schrieb Bernhard Beschow : >This series removes the bundled device tree blobs from the repository which are >redundant to the bundled device tree sources. To make this work, the device >tree >compiler 'dtc' is now required whenever libfdt is

Re: [PATCH] meson: Add most 3rd-party includes as system includes

2025-07-14 Thread Bernhard Beschow
Am 11. Juli 2025 10:45:08 UTC schrieb Peter Maydell : >On Tue, 17 Jun 2025 at 21:35, Bernhard Beschow wrote: >> >> When compiling QEMU against fuse3-3.17.1 with --enable-werror the build fails >> with: >> >> In file included from ../src/block/export/fuse.c:3

Re: [PATCH] meson: Add most 3rd-party includes as system includes

2025-07-10 Thread Bernhard Beschow
Am 3. Juli 2025 06:25:11 UTC schrieb Bernhard Beschow : > > >Am 17. Juni 2025 20:34:35 UTC schrieb Bernhard Beschow : >>When compiling QEMU against fuse3-3.17.1 with --enable-werror the build fails >>with: >> >> In file included from ../src/block/export/fuse.c:

Re: [PATCH] rust/bindings: allow unnecessary_transmutes (1.88)

2025-07-09 Thread Bernhard Beschow
case, > non_upper_case_globals, >+unnecessary_transmutes, > unsafe_op_in_unsafe_fn, > clippy::pedantic, > clippy::restriction, > >--- >base-commit: c77283dd5d79149f4e7e9edd00f65416c648ee59 >change-id: 20250703-rust_bindings_allow_unnecessary_transmutes-d614db4517a4 > >-- >γαῖα πυρί μιχθήτω > > FWIW: Reviewed-by: Bernhard Beschow

Re: [PATCH] rust: Fix compilation with rustc v1.88

2025-07-09 Thread Bernhard Beschow
Am 9. Juli 2025 06:22:11 UTC schrieb Manos Pitsidianakis : >Hi Bernhard, > >Thanks for your patch! > >There was an identical patch last week on the list: >https://lore.kernel.org/qemu-rust/20250703-rust_bindings_allow_unnecessary_transmutes-v1-1-692ca210d...@linaro.org/ > Oh, I missed it. I ju

Re: [PATCH 1/2] hw/arm/fsl-imx8mp: Wire VIRQ and VFIQ

2025-07-08 Thread Bernhard Beschow
Am 30. Juni 2025 08:59:22 UTC schrieb "Philippe Mathieu-Daudé" : >On 29/6/25 22:48, Bernhard Beschow wrote: >> Allows to run KVM guests inside the imx8mp-evk machine. >> >> Fixes: a4eefc69b237 ("hw/arm: Add i.MX 8M Plus EVK board") >> CC:

[PATCH v2 1/3] hw/microblaze: Add missing FDT dependency

2025-07-08 Thread Bernhard Beschow
These boards ship with a bundled DTB, and dtc will be required for generating these from device tree sources. Prepare for that by adding an FDT dependency. Signed-off-by: Bernhard Beschow --- hw/microblaze/Kconfig | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw

[PATCH v2 0/3] DTB build housekeeping

2025-07-08 Thread Bernhard Beschow
2: * Allow building dtc from bundled libfdt (Paolo) * Find dtc iff libfdt is used (Paolo) * Remove dtc configure option (now obsolete) Bernhard Beschow (3): hw/microblaze: Add missing FDT dependency configure: Ensure existance of dtc when libfdt is used pc-bios/dtb: Remove device

[PATCH v2 2/3] configure: Ensure existance of dtc when libfdt is used

2025-07-08 Thread Bernhard Beschow
The next patch relies on dtc for boards with a bundled DTB. These boards depend on libfdt already. Make sure that there is a dtc iff libfdt is used such that the DTBs can be generated. Co-developed-by: Paolo Bonzini Signed-off-by: Bernhard Beschow --- meson.build

[PATCH v2 3/3] pc-bios/dtb: Remove device tree blobs

2025-07-08 Thread Bernhard Beschow
Now that the existance of a device tree compiler is enusred, it is possible to always generate the DTBs from sources. This avoids checked in DTBs to become inconsistent with their sources. Signed-off-by: Bernhard Beschow --- MAINTAINERS | 2 +- pc-bios/dtb/bamboo.dtb

[PATCH] rust: Fix compilation with rustc v1.88

2025-07-08 Thread Bernhard Beschow
he lint in the generated code by adding it to the allow list. Signed-off-by: Bernhard Beschow --- rust/qemu-api/src/bindings.rs | 1 + 1 file changed, 1 insertion(+) diff --git a/rust/qemu-api/src/bindings.rs b/rust/qemu-api/src/bindings.rs index 057de4b646..3cdad0f0ec 100644 --- a/rust/qemu-

Re: [PATCH 2/2] hw/arm/imx8mp-evk: Add KVM support

2025-07-08 Thread Bernhard Beschow
Am 30. Juni 2025 21:03:06 UTC schrieb Peter Maydell : >On Mon, 30 Jun 2025 at 21:22, Bernhard Beschow wrote: >> >> >> >> Am 30. Juni 2025 09:09:31 UTC schrieb Peter Maydell >> : >> >On Sun, 29 Jun 2025 at 21:49, Bernhard Beschow wrote: >> >&

Re: [PATCH v3 14/14] hw/i386: move isapc machine to separate isapc.c file

2025-07-08 Thread Bernhard Beschow
de_iobase[i], ide_iobase2[i], >-ide_irq[i], >- hd[MAX_IDE_DEVS * i], hd[MAX_IDE_DEVS * i + 1]); >-/* >- * The ide bus name is ide.0 for the first bus and ide.1 for the >- * second one. >- */ >-busname[4] = '0' + i; >-pcms->idebus[i] = qdev_get_child_bus(DEVICE(dev), busname); >-} >-} >-#endif >- > #ifdef CONFIG_XEN > static void pc_xen_hvm_init_pci(MachineState *machine) > { >@@ -839,43 +728,6 @@ static void pc_i440fx_machine_2_6_options(MachineClass *m) > > DEFINE_I440FX_MACHINE(2, 6); > >-#ifdef CONFIG_ISAPC >-static void isapc_machine_options(MachineClass *m) >-{ >-static const char * const valid_cpu_types[] = { >-X86_CPU_TYPE_NAME("486"), >-X86_CPU_TYPE_NAME("athlon"), >-X86_CPU_TYPE_NAME("kvm32"), >-X86_CPU_TYPE_NAME("pentium"), >-X86_CPU_TYPE_NAME("pentium2"), >-X86_CPU_TYPE_NAME("pentium3"), >-X86_CPU_TYPE_NAME("qemu32"), >-X86_CPU_TYPE_NAME("max"), >-NULL >-}; >-PCMachineClass *pcmc = PC_MACHINE_CLASS(m); >- >-m->desc = "ISA-only PC"; >-m->max_cpus = 1; >-m->option_rom_has_mr = true; >-m->rom_file_has_mr = false; >-pcmc->pci_enabled = false; >-pcmc->has_acpi_build = false; >-pcmc->smbios_defaults = false; >-pcmc->gigabyte_align = false; >-pcmc->smbios_legacy_mode = true; >-pcmc->has_reserved_memory = false; >-m->default_nic = "ne2k_isa"; >-m->default_cpu_type = X86_CPU_TYPE_NAME("486"); >-m->valid_cpu_types = valid_cpu_types; >-m->no_floppy = !module_object_class_by_name(TYPE_ISA_FDC); >-m->no_parallel = !module_object_class_by_name(TYPE_ISA_PARALLEL); >-} >- >-DEFINE_PC_MACHINE(isapc, "isapc", pc_init_isa, >- isapc_machine_options); >-#endif >- > #ifdef CONFIG_XEN > static void xenfv_machine_4_2_options(MachineClass *m) > { With above comments addressed: Reviewed-by: Bernhard Beschow shen...@gmail.com>

Re: [PATCH] meson: Add most 3rd-party includes as system includes

2025-07-02 Thread Bernhard Beschow
Am 17. Juni 2025 20:34:35 UTC schrieb Bernhard Beschow : >When compiling QEMU against fuse3-3.17.1 with --enable-werror the build fails >with: > > In file included from ../src/block/export/fuse.c:33: > /usr/include/fuse3/fuse.h:959:5: error: redundant r

Re: [PATCH 2/2] hw/arm/imx8mp-evk: Add KVM support

2025-06-30 Thread Bernhard Beschow
Am 30. Juni 2025 08:58:22 UTC schrieb "Philippe Mathieu-Daudé" : >Hi, > >On 29/6/25 22:48, Bernhard Beschow wrote: >> Allows the imx8mp-evk machine to be run with KVM acceleration as a guest. >> >> Signed-off-by: Bernhard Beschow >> -

Re: [PATCH 2/2] hw/arm/imx8mp-evk: Add KVM support

2025-06-30 Thread Bernhard Beschow
Am 30. Juni 2025 09:09:31 UTC schrieb Peter Maydell : >On Sun, 29 Jun 2025 at 21:49, Bernhard Beschow wrote: >> >> Allows the imx8mp-evk machine to be run with KVM acceleration as a guest. >> >> Signed-off-by: Bernhard Beschow >> --- >> docs/system/arm

[PATCH 0/2] KVM Support for imx8mp-evk Machine

2025-06-29 Thread Bernhard Beschow
ecure=on,virtualization=on,gic-version=4 \ -cpu cortex-a72 -smp 4 -accel tcg` and `qemu-system-aarch64 -M imx8mp-evk \ -accel tcg -smp 4" Bernhard Beschow (2): hw/arm/fsl-imx8mp: Wire VIRQ and VFIQ hw/arm/imx8mp-evk: Add KVM support docs/system/arm/imx8mp-evk.rst | 7 +++

[PATCH 1/2] hw/arm/fsl-imx8mp: Wire VIRQ and VFIQ

2025-06-29 Thread Bernhard Beschow
Allows to run KVM guests inside the imx8mp-evk machine. Fixes: a4eefc69b237 ("hw/arm: Add i.MX 8M Plus EVK board") CC: qemu-stable Signed-off-by: Bernhard Beschow --- hw/arm/fsl-imx8mp.c | 4 1 file changed, 4 insertions(+) diff --git a/hw/arm/fsl-imx8mp.c b/hw/arm/fsl-imx8

[PATCH 2/2] hw/arm/imx8mp-evk: Add KVM support

2025-06-29 Thread Bernhard Beschow
Allows the imx8mp-evk machine to be run with KVM acceleration as a guest. Signed-off-by: Bernhard Beschow --- docs/system/arm/imx8mp-evk.rst | 7 +++ hw/arm/fsl-imx8mp.c| 33 - hw/arm/imx8mp-evk.c| 11 +++ hw/arm/Kconfig

Re: [PATCH v2 12/12] hw/i386: move isapc machine to separate isapc.c file

2025-06-23 Thread Bernhard Beschow
Am 18. Juni 2025 11:27:17 UTC schrieb Mark Cave-Ayland : >Now that pc_init_isa() is independent of any PCI initialisation, move it into a >separate isapc.c file. This enables us to finally fix the dependency of ISAPC >on >I440FX in hw/i386/Kconfig. > >Note that as part of the move to a separat

Re: [PATCH v2 10/12] hw/i386/pc_piix.c: assume pcmc->pci_enabled is always false in pc_init_isa()

2025-06-23 Thread Bernhard Beschow
Am 18. Juni 2025 11:27:15 UTC schrieb Mark Cave-Ayland : >By definition PCI can never be enabled on an isapc machine so hardcode the >relevant values >set via pcmc->pci_enabled. The inverse should be true now for pc-i440fx, so a similar patch is needed there as well. Best regards, Bernhard

[PATCH] meson: Add most 3rd-party includes as system includes

2025-06-17 Thread Bernhard Beschow
. While at it mark every 3rd-party dependency as system dependency to prevent similar issues in the future but skip glib since that results in glib include paths to be omitted from bindgen in case of a Rust build. Signed-off-by: Bernhard Beschow --- meson.build | 160

[PATCH v3 0/4] Initial logging support for Rust

2025-06-15 Thread Bernhard Beschow
for the logging categories in PascalCase as suggested by Paolo Bernhard Beschow (4): rust/qemu-api: Add initial logging support based on C API rust/hw/char/pl011/src/device: Implement logging rust/hw/char/pl011/src/device: Add missing logging to match C version rust/qemu-api:

[PATCH v3 2/4] rust/hw/char/pl011/src/device: Implement logging

2025-06-15 Thread Bernhard Beschow
Now that there is logging support in Rust for QEMU, use it in the pl011 device. Signed-off-by: Bernhard Beschow --- rust/hw/char/pl011/src/device.rs | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/rust/hw/char/pl011/src/device.rs b/rust/hw/char/pl011/src

[PATCH v3 3/4] rust/hw/char/pl011/src/device: Add missing logging to match C version

2025-06-15 Thread Bernhard Beschow
Co-developed-by: Paolo Bonzini Signed-off-by: Bernhard Beschow --- rust/hw/char/pl011/src/device.rs | 6 ++ 1 file changed, 6 insertions(+) diff --git a/rust/hw/char/pl011/src/device.rs b/rust/hw/char/pl011/src/device.rs index fa591c3ef6..48b4bca6b8 100644 --- a/rust/hw/char/pl011/src

[PATCH v3 1/4] rust/qemu-api: Add initial logging support based on C API

2025-06-15 Thread Bernhard Beschow
suffice for the current use case of Rust in QEMU. Signed-off-by: Bernhard Beschow --- docs/devel/rust.rst | 1 + rust/wrapper.h | 2 + rust/qemu-api/meson.build| 1 + rust/qemu-api/src/lib.rs | 1 + rust/qemu-api/src/log.rs | 78

[PATCH v3 4/4] rust/qemu-api: Fix clippy lint `missing_const_for_fn`

2025-06-15 Thread Bernhard Beschow
Signed-off-by: Bernhard Beschow --- rust/qemu-api/src/cell.rs | 2 +- rust/qemu-api/src/qom.rs | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/rust/qemu-api/src/cell.rs b/rust/qemu-api/src/cell.rs index 27063b049d..851573f8ef 100644 --- a/rust/qemu-api/src/cell.rs +++ b

Re: [PATCH 4/5] configure: Add dtc option

2025-06-12 Thread Bernhard Beschow
Am 12. Juni 2025 05:46:03 UTC schrieb Paolo Bonzini : >On 6/12/25 07:12, Paolo Bonzini wrote: >> I'll send a patch to the upstream dtc project and you can add it to QEMU via >> diff_files (see commit 64644bc4eab2f for an example). >This is the patch, backported to QEMU's version of the dtc subp

Re: [PATCH v2 1/2] rust/qemu-api: Add initial logging support based on C API

2025-06-12 Thread Bernhard Beschow
Am 11. Juni 2025 12:17:57 UTC schrieb Manos Pitsidianakis : >On Wed, Jun 11, 2025 at 2:05 PM Paolo Bonzini wrote: >> >> On Wed, Jun 11, 2025 at 12:57 PM Manos Pitsidianakis >> wrote: >> >> > Maybe we could take this chance to remove the requirement for trailing >> > newline? Not urgent, and a

Re: [PATCH v2 1/2] rust/qemu-api: Add initial logging support based on C API

2025-06-12 Thread Bernhard Beschow
Am 11. Juni 2025 12:17:57 UTC schrieb Manos Pitsidianakis : >On Wed, Jun 11, 2025 at 2:05 PM Paolo Bonzini wrote: >> >> On Wed, Jun 11, 2025 at 12:57 PM Manos Pitsidianakis >> wrote: >> >> > Maybe we could take this chance to remove the requirement for trailing >> > newline? Not urgent, and a

Re: [PATCH v2 2/2] rust/hw/char/pl011/src/device: Implement logging

2025-06-11 Thread Bernhard Beschow
Am 11. Juni 2025 07:55:20 UTC schrieb Paolo Bonzini : >On 6/10/25 22:21, Bernhard Beschow wrote: >> Now that there is logging support in Rust for QEMU, use it in the pl011 >> device. >Adding also this to match the C code: > >diff --git a/rust/hw/char/pl011/src/device.r

Re: [PATCH v2 1/2] rust/qemu-api: Add initial logging support based on C API

2025-06-11 Thread Bernhard Beschow
Am 11. Juni 2025 07:56:23 UTC schrieb Paolo Bonzini : >On 6/10/25 22:21, Bernhard Beschow wrote: >> +/// A macro to log messages conditionally based on a provided mask. >> +/// >> +/// The `log_mask` macro checks whether the given mask matches the current >> l

Re: Embed QEMU terminal into GUI application (Cubic - Custom Ubuntu ISO Creator)

2025-06-10 Thread Bernhard Beschow
Am 9. Juni 2025 17:22:32 UTC schrieb PJ Singh : >Hello Everyone, > >I want to embed a QEMU window directly in my GUI application. Are Python >APIs available to embed QEMU into a GNOME GUI application? > >I am the developer of Cubic (Custom Ubuntu ISO Creator), a tool which >allows users to custo

Re: [PATCH 1/2] rust/qemu-api: Add initial logging support based on C API

2025-06-10 Thread Bernhard Beschow
Am 12. Mai 2025 15:32:08 UTC schrieb Paolo Bonzini : >Hi, now that GSoC selection is over I'm back. Sorry for the delay; >Tanish Desai will work mostly on tracing, so logging can remain yours. > >On Tue, Apr 8, 2025 at 10:59 PM Bernhard Beschow wrote: >> >Currently

Re: [PULL 36/58] pc-bios: Move device tree files in their own subdir

2025-06-10 Thread Bernhard Beschow
Am 4. Juni 2025 09:59:44 UTC schrieb Bernhard Beschow : > > >Am 3. Juni 2025 11:38:59 UTC schrieb Thomas Huth : >>On 03/06/2025 08.39, Bernhard Beschow wrote: >>> >>> >>> Am 2. Juni 2025 08:12:39 UTC schrieb "Philippe Mathieu-Daudé" >>

[PATCH 2/5] pc-bios/dtb/meson: Prefer target name to be outfile, not infile

2025-06-10 Thread Bernhard Beschow
Makes this custom_target() usage consistent with other ones in QEMU. Fixes: 6e0dc9d2a88a ("meson: compile bundled device trees") Signed-off-by: Bernhard Beschow --- pc-bios/dtb/meson.build | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pc-bios/dtb/meson.build b/p

[PATCH 0/5] DTB build housekeeping

2025-06-10 Thread Bernhard Beschow
d it to be too over-engineered. Last but not least two inconsistencies regarding QEMU_FILE_TYPE_DTB are fixed which seem to be latent bugs (one of which materializes in my e500-fdt branch). Bernhard Beschow (5): hw: Fix type constant for DTB files pc-bios/dtb/meson: Prefer target name to be out

[PATCH 1/5] hw: Fix type constant for DTB files

2025-06-10 Thread Bernhard Beschow
onstant for DTB files") Signed-off-by: Bernhard Beschow --- hw/arm/boot.c | 2 +- hw/ppc/e500.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/arm/boot.c b/hw/arm/boot.c index 79afb51b8a..64040504a1 100644 --- a/hw/arm/boot.c +++ b/hw/arm/boot.c @@ -527,7 +527,7 @@ int

[PATCH 4/5] configure: Add dtc option

2025-06-10 Thread Bernhard Beschow
The next patch will make dtc mandatory for boards with a bundled DTB, causing these boards to be omitted when dtc is missing. Allow packagers to force the build of those boards by providing an option. Signed-off-by: Bernhard Beschow --- meson.build | 12

[PATCH 3/5] scripts/meson-buildoptions: Sort coroutine_backend choices lexicographically

2025-06-10 Thread Bernhard Beschow
When changing meson_options.txt, this script gets updated automatically by QEMU tooling which sorts the choices lexicographically. Fix this in preparation of the ext patch. Fixes: ccc403ed5844 ("meson: Add wasm build in build scripts") Signed-off-by: Bernhard Beschow --- scr

[PATCH 5/5] configure: Require dtc for boards with bundled device trees

2025-06-10 Thread Bernhard Beschow
Avoid having generated DTBs checked in which can become inconsistent with their sources. Note that when dtc is not found, the boards with bundled DTBs will be omitted from the build. Finding dtc, and thus building these boards, can be enforced with the `dtc` build option. Signed-off-by: Bernhard

[PATCH v2 1/2] rust/qemu-api: Add initial logging support based on C API

2025-06-10 Thread Bernhard Beschow
for the current use case of Rust in QEMU. Signed-off-by: Bernhard Beschow --- docs/devel/rust.rst | 1 + rust/wrapper.h| 2 ++ rust/qemu-api/meson.build | 1 + rust/qemu-api/src/lib.rs | 1 + rust/qemu-api/src/log.rs | 76 +++ 5 files

[PATCH v2 2/2] rust/hw/char/pl011/src/device: Implement logging

2025-06-10 Thread Bernhard Beschow
Now that there is logging support in Rust for QEMU, use it in the pl011 device. Signed-off-by: Bernhard Beschow --- rust/hw/char/pl011/src/device.rs | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/rust/hw/char/pl011/src/device.rs b/rust/hw/char/pl011/src

[PATCH v2 0/2] Initial logging support for Rust

2025-06-10 Thread Bernhard Beschow
se as suggested by Paolo Bernhard Beschow (2): rust/qemu-api: Add initial logging support based on C API rust/hw/char/pl011/src/device: Implement logging docs/devel/rust.rst | 1 + rust/wrapper.h | 2 + rust/hw/char/pl011/src/device.rs | 12 +++-- rust/qem

Re: Controlling time in QEMU

2025-06-10 Thread Bernhard Beschow
Am 6. Juni 2025 19:03:32 UTC schrieb Pierrick Bouvier : >Hi, > >I recently needed to slow down time within a virtual machine, due to a timeout >being hit because my QEMU binary which was not fast enough (gcov debug build >if you're curious about the use case). > >Currently, people tend to use

Re: [PULL 36/58] pc-bios: Move device tree files in their own subdir

2025-06-04 Thread Bernhard Beschow
Am 3. Juni 2025 11:38:59 UTC schrieb Thomas Huth : >On 03/06/2025 08.39, Bernhard Beschow wrote: >> >> >> Am 2. Juni 2025 08:12:39 UTC schrieb "Philippe Mathieu-Daudé" >> : >>> On 30/5/25 02:54, BALATON Zoltan wrote: >>>> On Thu, 29

Re: [PULL 36/58] pc-bios: Move device tree files in their own subdir

2025-06-02 Thread Bernhard Beschow
Am 2. Juni 2025 08:12:39 UTC schrieb "Philippe Mathieu-Daudé" : >On 30/5/25 02:54, BALATON Zoltan wrote: >> On Thu, 29 May 2025, Bernhard Beschow wrote: >>> Am 25. April 2025 15:28:20 UTC schrieb "Philippe Mathieu-Daudé" >>> : >>>> F

Re: [PATCH 2/3] hw/net/fsl_etsec: Set default MAC address

2025-05-29 Thread Bernhard Beschow
t; eTSEC*etsec = ETSEC_COMMON(dev); > >+qemu_macaddr_default_if_unset(&etsec->conf.macaddr); > etsec->nic = qemu_new_nic(&net_etsec_info, &etsec->conf, > object_get_typename(OBJECT(dev)), dev->id, > &dev->mem_reentrancy_guard, etsec); Reviewed-by: Bernhard Beschow

Re: [PATCH 0/3] Misc ppc/e500 patches

2025-05-29 Thread Bernhard Beschow
machine class > hw/net/fsl_etsec: Set default MAC address > >Bernhard Beschow (1): > hw/ppc/e500: Use SysBusDevice API to access TYPE_CCSR's internal >resources > > hw/net/fsl_etsec/etsec.c | 1 + > hw/pci-host/ppce500.c| 8 > hw/ppc/e500.c

Re: [PULL 36/58] pc-bios: Move device tree files in their own subdir

2025-05-29 Thread Bernhard Beschow
Am 25. April 2025 15:28:20 UTC schrieb "Philippe Mathieu-Daudé" : >From: BALATON Zoltan > >We have several device tree files already and may have more in the >future so add a new dtb subdirectory and move device tree files there >so they are not mixed with ROM binaries. > >Signed-off-by: BALAT

[PATCH v2] hw/i386/pc_piix: Fix RTC ISA IRQ wiring of isapc machine

2025-05-26 Thread Bernhard Beschow
ves: https://gitlab.com/qemu-project/qemu/-/issues/2961 Fixes: 56b1f50e3c10 ("hw/i386/pc: Wire RTC ISA IRQs in south bridges") cc: qemu-stable Signed-off-by: Bernhard Beschow Reviewed-by: Mark Cave-Ayland --- v2: * add ISA_DEVICE() QOM cast as a safety check (Mark) --- hw/i386/pc_piix

Re: Using parallel port on the Pegasos 2

2025-05-26 Thread Bernhard Beschow
Am 25. Mai 2025 00:03:15 UTC schrieb BALATON Zoltan : >On Sun, 28 Jul 2024, BALATON Zoltan wrote: >> On Sun, 28 Jul 2024, quan wrote: >>> I am playing around with the parallel port on the pegasos 2 and I noticed >>> the following issue: >>> The parallel port on startup is set to iobase 0x378, th

[PATCH 3/3] hw/ppc/e500: Use SysBusDevice API to access TYPE_CCSR's internal resources

2025-05-23 Thread Bernhard Beschow
From: Bernhard Beschow Rather than accessing the attributes of TYPE_CCSR directly, use the SysBusDevice API which exists exactly for that purpose. Furthermore, registering the memory region with the SysBusDevice API makes it show up in QMP's `info qom-tree` command. Signed-off-by: Ber

Re: [PATCH] hw/i386/pc_piix: Fix RTC ISA IRQ wiring of isapc machine

2025-05-15 Thread Bernhard Beschow
Am 13. Mai 2025 09:02:56 UTC schrieb Mark Cave-Ayland : >On 12/05/2025 22:09, Bernhard Beschow wrote: > >> Commit 56b1f50e3c10 ("hw/i386/pc: Wire RTC ISA IRQs in south bridges") >> attempted to refactor RTC IRQ wiring which was previously done in >> pc_basic_

[PATCH] hw/i386/pc_piix: Fix RTC ISA IRQ wiring of isapc machine

2025-05-12 Thread Bernhard Beschow
ves: https://gitlab.com/qemu-project/qemu/-/issues/2961 Fixes: 56b1f50e3c10 ("hw/i386/pc: Wire RTC ISA IRQs in south bridges") cc: qemu-stable Signed-off-by: Bernhard Beschow --- hw/i386/pc_piix.c | 5 + 1 file changed, 5 insertions(+) diff --git a/hw/i386/pc_piix.c b/hw/i386/pc_pii

[PATCH] hw/i2c/imx_i2c: Always set interrupt status bit if interrupt condition occurs

2025-05-07 Thread Bernhard Beschow
ned-off-by: Bernhard Beschow --- hw/i2c/imx_i2c.c | 11 +-- 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hw/i2c/imx_i2c.c b/hw/i2c/imx_i2c.c index 91f84c2ad7..d26177c85d 100644 --- a/hw/i2c/imx_i2c.c +++ b/hw/i2c/imx_i2c.c @@ -79,13 +79,12 @@ static void imx_i2c_reset(D

Re: [PATCH 1/3] hw/pci-host/designware: Remove unused include

2025-05-01 Thread Bernhard Beschow
Am 1. Mai 2025 19:02:35 UTC schrieb "Philippe Mathieu-Daudé" : >On 1/5/25 20:34, Bernhard Beschow wrote: >> The DEFINE_TYPES() macro doesn't need the qemu/module.h include. >> >> Fixes: 13a07eb146c8 ("hw/pci-host/designware: Declare CPU QOM types usin

Re: [PATCH-for-10.0? v2] tests/functional: Add test for imx8mp-evk board with USDHC coverage

2025-05-01 Thread Bernhard Beschow
Am 23. April 2025 11:31:31 UTC schrieb "Philippe Mathieu-Daudé" : >Hi Thomas, > >On 23/4/25 11:40, Thomas Huth wrote: >> On 23/04/2025 11.31, Bernhard Beschow wrote: >>> >>> >>> Am 10. April 2025 06:05:35 UTC schrieb Thomas Hut

[PATCH 1/3] hw/pci-host/designware: Remove unused include

2025-05-01 Thread Bernhard Beschow
The DEFINE_TYPES() macro doesn't need the qemu/module.h include. Fixes: 13a07eb146c8 ("hw/pci-host/designware: Declare CPU QOM types using DEFINE_TYPES() macro") Signed-off-by: Bernhard Beschow --- hw/pci-host/designware.c | 1 - 1 file changed, 1 deletion(-) diff --gi

[PATCH 2/3] hw/pci-host/designware: Fix viewport configuration

2025-05-01 Thread Bernhard Beschow
re: Use deposit/extract API") Signed-off-by: Bernhard Beschow --- hw/pci-host/designware.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/pci-host/designware.c b/hw/pci-host/designware.c index b4bff14579..f6e49ce9b8 100644 --- a/hw/pci-host/designware.c +++ b/hw/p

[PATCH 0/3] i.MX fixes

2025-05-01 Thread Bernhard Beschow
. Bernhard Beschow (3): hw/pci-host/designware: Remove unused include hw/pci-host/designware: Fix viewport configuration hw/gpio/imx_gpio: Fix interpretation of GDIR polarity hw/gpio/imx_gpio.c | 2 +- hw/pci-host/designware.c | 5 ++--- 2 files changed, 3 insertions(+), 4 deletions

[PATCH 3/3] hw/gpio/imx_gpio: Fix interpretation of GDIR polarity

2025-05-01 Thread Bernhard Beschow
condition. Fix this by returning early when the bit is set. Fixes: f44272809779 ("i.MX: Add GPIO device") cc: qemu-stable Signed-off-by: Bernhard Beschow --- hw/gpio/imx_gpio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/gpio/imx_gpio.c b/hw/gpio/imx_gp

Re: [PATCH-for-10.0? v2] tests/functional: Add test for imx8mp-evk board with USDHC coverage

2025-04-23 Thread Bernhard Beschow
Am 10. April 2025 06:05:35 UTC schrieb Thomas Huth : >On 09/04/2025 22.26, Bernhard Beschow wrote: >> Introduce a functional test which boots Debian 12 on the imx8mp-evk board. >> Since >> the root filesystem resides on an SD card, the test also verifies the basic >

Re: [PATCH v6 3/3] hw/ppc/e500: Add Freescale eSDHC to e500plat

2025-04-20 Thread Bernhard Beschow
t; firmware images to access SD cards. >>> >>> Signed-off-by: Bernhard Beschow >>> Message-Id: <20221018210146.193159-8-shen...@gmail.com> >>> [PMD: Simplify using create_unimplemented_device("esdhc")] >>> Signed-off-by: Philippe Mathieu-D

Re: [PATCH v2 1/3] hw/misc/aspeed_otp: Add Aspeed OTP memory device model

2025-04-17 Thread Bernhard Beschow
Am 17. April 2025 03:09:53 UTC schrieb Kane Chen via : >From: Kane-Chen-AS > >This introduces a new model for the ASPEED OTP (One-Time Programmable) >memory. The device is implemented as a `SysBusDevice` and provides an >abstracted interface for OTP read, write (program), and default value >ini

Re: [PATCH 0/2] Add property to support writing ERSTBA in high-low order

2025-04-10 Thread Bernhard Beschow
/hcd-dwc3: Set erstba-hi-lo property > > hw/usb/hcd-dwc3.c | 1 + > hw/usb/hcd-xhci.c | 8 +++- > hw/usb/hcd-xhci.h | 1 + > 3 files changed, 9 insertions(+), 1 deletion(-) Series: Reviewed-by: Bernhard Beschow

Re: [PATCH 0/2] Add property to support writing ERSTBA in high-low order

2025-04-10 Thread Bernhard Beschow
Am 11. April 2025 03:53:27 UTC schrieb Guenter Roeck : >On 4/8/25 14:56, Bernhard Beschow wrote: > >>>>> Tt turns out that sabrelite has the same problem. >>>> >>>> Did it work with QEMU 9.2? >>>> >>> >>> No, the pcie

[PATCH-for-10.0? v2] tests/functional: Add test for imx8mp-evk board with USDHC coverage

2025-04-09 Thread Bernhard Beschow
Introduce a functional test which boots Debian 12 on the imx8mp-evk board. Since the root filesystem resides on an SD card, the test also verifies the basic operation of the USDHC. Signed-off-by: Bernhard Beschow -- v2: * Make test file executable (Thomas) * Omit fetch() (Thomas) * Omit "-

Re: [PATCH 0/2] Add property to support writing ERSTBA in high-low order

2025-04-08 Thread Bernhard Beschow
Am 8. April 2025 20:31:58 UTC schrieb Guenter Roeck : >On 4/8/25 12:57, Bernhard Beschow wrote: >> >> >> Am 8. April 2025 16:09:58 UTC schrieb Guenter Roeck : >>> On 4/6/25 11:08, Bernhard Beschow wrote: >>> [ .. ] >>> >>>>>>

Re: [PATCH 1/2] rust/qemu-api: Add initial logging support based on C API

2025-04-08 Thread Bernhard Beschow
Am 1. April 2025 10:51:06 UTC schrieb Bernhard Beschow : > > >Am 31. März 2025 09:53:41 UTC schrieb Paolo Bonzini : >>On 3/30/25 22:58, Bernhard Beschow wrote: >>> A qemu_log_mask!() macro is provided which expects similar arguments as the >>> C >>>

Re: [PATCH-for-10.0 0/3] More imx8mp-evk improvements

2025-04-08 Thread Bernhard Beschow
Am 8. April 2025 18:57:45 UTC schrieb "Philippe Mathieu-Daudé" : >On 5/4/25 23:48, Bernhard Beschow wrote: > >> Guenter Roeck (2): >>hw/arm/imx8mp-evk: Remove unimplemented cpu-idle-states properties >> from devicetree >>hw/arm/imx8mp-evk: R

Re: [PATCH preview 0/3] rust: update build system for Meson 1.8.0

2025-04-08 Thread Bernhard Beschow
Am 5. April 2025 10:06:00 UTC schrieb Paolo Bonzini : >Meson 1.7.0 and 1.8.0 include improved support for Rust, namely: >* support for "objects" in Rust executables >* support for doctest targets Using Meson 1.7.2 (shipped with my distro) I didn't succeed with either of these. If just applying

Re: [PATCH 0/2] Add property to support writing ERSTBA in high-low order

2025-04-08 Thread Bernhard Beschow
Am 8. April 2025 16:09:58 UTC schrieb Guenter Roeck : >On 4/6/25 11:08, Bernhard Beschow wrote: >[ .. ] > >>>> Yeah, it works with Buildroot as described in the handbook. When I append >>>> `-netdev user,id=net0 -device virtio-net-pci,netdev=net0`

Re: [PATCH 0/2] Add property to support writing ERSTBA in high-low order

2025-04-08 Thread Bernhard Beschow
/hcd-dwc3: Set erstba-hi-lo property > > hw/usb/hcd-dwc3.c | 1 + > hw/usb/hcd-xhci.c | 8 +++- > hw/usb/hcd-xhci.h | 1 + > 3 files changed, 9 insertions(+), 1 deletion(-) Series: Tested-by: Bernhard Beschow ... on imx8mp-evk board with 6.14 defconfig kernel. It indeed helps to get USB working with this kernel. Best regards, Bernhard

Re: [PATCH-for-10.0 1/3] tests/functional: Add test for imx8mp-evk board with USDHC coverage

2025-04-08 Thread Bernhard Beschow
Am 7. April 2025 05:38:28 UTC schrieb Thomas Huth : > Hi! > >On 05/04/2025 23.48, Bernhard Beschow wrote: >> Introduce a functional test which boots Debian 12 on the imx8mp-evk board. >> Since >> the root filesystem resides on an SD card, the test also verifies th

Re: [PATCH 0/2] Add property to support writing ERSTBA in high-low order

2025-04-06 Thread Bernhard Beschow
Am 6. April 2025 15:30:42 UTC schrieb Guenter Roeck : >On 4/6/25 04:03, Bernhard Beschow wrote: >> >> >> Am 6. April 2025 01:31:49 UTC schrieb Guenter Roeck : >>> On 4/5/25 12:28, Bernhard Beschow wrote: >>>> >>>> >>>> Am 5.

Re: [PATCH 0/2] Add property to support writing ERSTBA in high-low order

2025-04-06 Thread Bernhard Beschow
Am 6. April 2025 01:31:49 UTC schrieb Guenter Roeck : >On 4/5/25 12:28, Bernhard Beschow wrote: >> >> >> Am 5. April 2025 17:26:14 UTC schrieb Guenter Roeck : >>> On 4/5/25 07:25, Philippe Mathieu-Daudé wrote: >>>> Hi Guenter, >>>> >&g

[PATCH-for-10.0 1/3] tests/functional: Add test for imx8mp-evk board with USDHC coverage

2025-04-05 Thread Bernhard Beschow
Introduce a functional test which boots Debian 12 on the imx8mp-evk board. Since the root filesystem resides on an SD card, the test also verifies the basic operation of the USDHC. Signed-off-by: Bernhard Beschow --- MAINTAINERS | 1 + tests/functional

[PATCH-for-10.0 0/3] More imx8mp-evk improvements

2025-04-05 Thread Bernhard Beschow
boot is resolved by also automatically removing an offending device node. Supersedes: 20250330094139.11948-1-shen...@gmail.com Bernhard Beschow (1): tests/functional: Add test for imx8mp-evk board with USDHC coverage Guenter Roeck (2): hw/arm/imx8mp-evk: Remove unimplemented cpu-idle-states

[PATCH-for-10.0 3/3] hw/arm/imx8mp-evk: Remove unimplemented nxp, imx8mp-fspi node from devicetree

2025-04-05 Thread Bernhard Beschow
From: Guenter Roeck The nxp,imx8mp-fspi node triggers a warning backtrace. Remove it from the devicetree file. Signed-off-by: Guenter Roeck Inspired-by: commit bf1da4b308 ("hw/arm/raspi4b: Temporarily disable unimplemented rpi4b devices") Signed-off-by: Bernhard Beschow [Bernhard: s

[PATCH-for-10.0 2/3] hw/arm/imx8mp-evk: Remove unimplemented cpu-idle-states properties from devicetree

2025-04-05 Thread Bernhard Beschow
From: Guenter Roeck The cpu-idle-states property causes a hard boot hang. Rather than documenting the workaround, perform the removal from the devicetree automatically. Signed-off-by: Guenter Roeck Signed-off-by: Bernhard Beschow [Bernhard: split patch, update documentation, adapt commit

Re: [PATCH 0/2] Add property to support writing ERSTBA in high-low order

2025-04-05 Thread Bernhard Beschow
Am 5. April 2025 17:26:14 UTC schrieb Guenter Roeck : >On 4/5/25 07:25, Philippe Mathieu-Daudé wrote: >> Hi Guenter, >> >> On 5/4/25 16:00, Guenter Roeck wrote: >>> This series is needed to support the USB interface on imx8mp-evk when >>> booting the Linux kernel. >>> >>> According to the XHCI

[PATCH 1/2] rust/qemu-api: Add initial logging support based on C API

2025-04-05 Thread Bernhard Beschow
suffice for the current use case of Rust in QEMU. Signed-off-by: Bernhard Beschow --- docs/devel/rust.rst | 1 + rust/wrapper.h| 2 ++ rust/qemu-api/meson.build | 1 + rust/qemu-api/src/lib.rs | 1 + rust/qemu-api/src/log.rs | 55 +++ 5

Re: [PATCH 2/2] rust/hw/char/pl011/src/device: Implement logging

2025-04-05 Thread Bernhard Beschow
Am 31. März 2025 09:18:05 UTC schrieb "Daniel P. Berrangé" : >On Sun, Mar 30, 2025 at 10:58:57PM +0200, Bernhard Beschow wrote: >> Now that there is logging support in Rust for QEMU, use it in the pl011 >> device. >> >> Signed-off-by: Bernhard Besch

Re: [PATCH 2/2] rust/hw/char/pl011/src/device: Implement logging

2025-04-03 Thread Bernhard Beschow
Am 2. April 2025 13:27:53 UTC schrieb "Daniel P. Berrangé" : >On Wed, Apr 02, 2025 at 09:33:16AM +0000, Bernhard Beschow wrote: >> >> >> Am 31. März 2025 09:18:05 UTC schrieb "Daniel P. Berrangé" >> : >> >On Sun, Mar 30, 2025 at 10:58:

Re: [PATCH 1/2] rust/qemu-api: Add initial logging support based on C API

2025-04-01 Thread Bernhard Beschow
Am 31. März 2025 09:53:41 UTC schrieb Paolo Bonzini : >On 3/30/25 22:58, Bernhard Beschow wrote: >> A qemu_log_mask!() macro is provided which expects similar arguments as the C >> version. However, the formatting works as one would expect from Rust. >> >> To maxim

[PATCH 2/2] rust/hw/char/pl011/src/device: Implement logging

2025-03-30 Thread Bernhard Beschow
Now that there is logging support in Rust for QEMU, use it in the pl011 device. Signed-off-by: Bernhard Beschow --- rust/hw/char/pl011/src/device.rs | 12 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/rust/hw/char/pl011/src/device.rs b/rust/hw/char/pl011/src

[PATCH 0/2] Initial logging support for Rust

2025-03-30 Thread Bernhard Beschow
;t be silenced by users. Note that this is my first Rust contribution, so please check if the usage of `unsafe` is sound. Bernhard Beschow (2): rust/qemu-api: Add initial logging support based on C API rust/hw/char/pl011/src/device: Implement logging docs/devel/rust.rst | 1 +

Re: Plea for advice with PCIe on QEMU for iMX6 and plan to add FlexCAN controller support

2025-03-30 Thread Bernhard Beschow
Am 2. Oktober 2024 15:06:01 UTC schrieb Pavel Pisa : >Dear Nikita and other, > >my student Matyas Bobek has chosen to work >on QEMU CAN support in a frame of his study >final project. > >We have identified iMX6 FlexCAN as the next interesting >CAN controller for emulation. I'd be interested in

Re: [PATCH v3 0/3] i.MX 8M Plus EVK Fixes

2025-03-30 Thread Bernhard Beschow
Am 27. März 2025 16:19:32 UTC schrieb "Philippe Mathieu-Daudé" : > >> Bernhard Beschow (3): >>hw/arm/imx8mp-evk: Fix reference count of SoC object >>hw/arm/fsl-imx8mp: Derive struct FslImx8mpState from >> TYPE_SYS_BUS_DEVICE >>hw/arm

[PATCH] tests/functional: Add test for imx8mp-evk board with USDHC coverage

2025-03-30 Thread Bernhard Beschow
Introduce a functional test which boots Debian 12 on the imx8mp-evk board. Since the root filesystem resides on an SD card, the test also verifies the basic operation of the USDHC. Signed-off-by: Bernhard Beschow --- MAINTAINERS | 1 + tests/functional

Re: [PATCH-for-10.0 10/12] hw/rtc: Categorize and add description

2025-03-27 Thread Bernhard Beschow
Am 25. März 2025 22:43:08 UTC schrieb "Philippe Mathieu-Daudé" : >Signed-off-by: Philippe Mathieu-Daudé >--- > hw/rtc/ds1338.c | 2 ++ > hw/rtc/m41t80.c | 2 ++ > hw/rtc/rs5c372.c | 2 ++ For rs5c372: Acked-by: Bernhard Beschow > 3 files changed, 6 insertio

Re: [PATCH v3 1/3] hw/arm/imx8mp-evk: Fix reference count of SoC object

2025-03-26 Thread Bernhard Beschow
Am 19. März 2025 18:06:14 UTC schrieb Peter Maydell : >On Tue, 18 Mar 2025 at 20:57, Bernhard Beschow wrote: >> >> TYPE_FSL_IMX8MP is created using object_new(), so must be realized with >> qdev_realize_and_unref() to keep the reference counting intact. >> >>

Re: [PATCH v2] tests/qtest: Unit test for pcf8563_rtc

2025-03-26 Thread Bernhard Beschow
Am 10. März 2025 11:36:35 UTC schrieb Ilya Chichkov : >Add a unit test for pcf8563_rtc module > >- Check default value after initialization >- Check set/get time >- Check minute alarm >- Check hour alarm >- Check day alarm >- Check wday alarm >- Check minute & hour alarm >- Check minute & day al

Re: [PATCH v2] hw/rtc: Add RTC PCF8563 module

2025-03-22 Thread Bernhard Beschow
Am 10. März 2025 11:36:34 UTC schrieb Ilya Chichkov : >Add PCF8563 a real-time clock with calendar and I2C interface. >This commit adds support for interfacing with it and implements >functionality of setting timer, alarm, reading and writing time. > >Signed-off-by: Ilya Chichkov >--- >v1->v2 >

  1   2   3   4   5   6   7   8   9   10   >