gcc can check the format string for correctness even when debugging output is
not enabled.
Have to make sure arguments are always available. They are optimized out if
unneeded.
Signed-off-by: Benjamin Poirier
Cc: Igor V. Kovalenko
---
hw/rtl8139.c |9 ++---
1 files changed, 6
‘target_phys_addr_t’
make[1]: *** [rtl8139.o] Error 1
Signed-off-by: Benjamin Poirier
Cc: Igor V. Kovalenko
---
hw/rtl8139.c | 15 +--
1 files changed, 9 insertions(+), 6 deletions(-)
diff --git a/hw/rtl8139.c b/hw/rtl8139.c
index d545933..9a759e7 100644
--- a/hw/rtl8139.c
+++ b/hw/rtl8139.c
On 07/04/11 05:35 PM, Michael Walle wrote:
> Am Mittwoch 06 April 2011, 16:13:58 schrieb Benjamin Poirier:
>> Works as usual.
>> The problem I'm facing stems from linking to libGL and memory
>> protection issues. The particular system I ran this on has the binary
>>
On Mon, Apr 4, 2011 at 6:13 PM, Michael Walle wrote:
> Hi Benjamin,
>
>> Let me know if you need more info.
>
> what happens if you configure with
>
> ./configure --target-list=x86_64-softmmu --disable-opengl
>
Works as usual.
The problem I'm facing stems from linking to libGL and memory
protecti
Hello,
commit 20ff075bb3340c5278a0da38ad1f4d602565aa06
Author: Michael Walle
Date: Mon Mar 7 23:32:39 2011 +0100
configure: add opengl detection
This patch introduce a new config option CONFIG_OPENGL.
Signed-off-by: Michael Walle
Signed-off-by: Edgar E. Iglesias
introduces
Add support to the emulated hardware to insert vlan tags in packets
going from the guest to the network.
Signed-off-by: Benjamin Poirier
Cc: Igor V. Kovalenko
Cc: Jason Wang
Cc: Michael S. Tsirkin
Cc: Blue Swirl
---
hw/rtl8139.c | 75
Hello,
Here is version 7 of my patchset to add vlan support to the emulated rtl8139
nic.
Changes since v6:
* added check against guest requesting tagging on frames with len < 12
* simplified tag extraction in receive function. dot1q_buf arg removed
from rtl8139_do_receiv
Add support to the emulated hardware to extract vlan tags in packets
going from the network to the guest.
Signed-off-by: Benjamin Poirier
Cc: Igor V. Kovalenko
Cc: Jason Wang
Cc: Michael S. Tsirkin
Cc: Blue Swirl
--
AFAIK, extraction is optional to get vlans working. The driver
requests rx
clean out ifdef's around ethernet checksum calculation
Signed-off-by: Benjamin Poirier
Acked-by: Igor V. Kovalenko
Cc: Jason Wang
Cc: Michael S. Tsirkin
Cc: Blue Swirl
---
hw/rtl8139.c | 20 +++-
1 files changed, 3 insertions(+), 17 deletions(-)
diff --git a/hw/rtl8
Add support to the emulated hardware to extract vlan tags in packets
going from the network to the guest.
Signed-off-by: Benjamin Poirier
Cc: Igor V. Kovalenko
Cc: Jason Wang
Cc: Michael S. Tsirkin
Cc: Blue Swirl
--
AFAIK, extraction is optional to get vlans working. The driver
requests rx
Add support to the emulated hardware to insert vlan tags in packets
going from the guest to the network.
Signed-off-by: Benjamin Poirier
Cc: Igor V. Kovalenko
Cc: Jason Wang
Cc: Michael S. Tsirkin
Cc: Blue Swirl
---
hw/rtl8139.c | 57
Here is version 6 of my patchset to add vlan support to the emulated rtl8139
nic.
Changes since v5:
* moved all receive changes to "add vlan tag extraction"
* fixed checkpatch.pl style issues
* fixed bugs in receive case related to small buffers and loopback
mode.
clean out ifdef's around ethernet checksum calculation
Signed-off-by: Benjamin Poirier
Cc: Igor V. Kovalenko
Cc: Jason Wang
Cc: Michael S. Tsirkin
Cc: Blue Swirl
---
hw/rtl8139.c | 20 +++-
1 files changed, 3 insertions(+), 17 deletions(-)
diff --git a/hw/rtl8139.c
Add support to the emulated hardware to extract vlan tags in packets
going from the network to the guest.
Signed-off-by: Benjamin Poirier
Cc: Igor V. Kovalenko
Cc: Jason Wang
Cc: Michael S. Tsirkin
Cc: Blue Swirl
--
AFAIK, extraction is optional to get vlans working. The driver
requests rx
Add support to the emulated hardware to insert vlan tags in packets
going from the guest to the network.
Signed-off-by: Benjamin Poirier
Cc: Igor V. Kovalenko
Cc: Jason Wang
Cc: Michael S. Tsirkin
Cc: Blue Swirl
---
hw/rtl8139.c | 107
clean out ifdef's around ethernet checksum calculation
Signed-off-by: Benjamin Poirier
Cc: Igor V. Kovalenko
Cc: Jason Wang
Cc: Michael S. Tsirkin
Cc: Blue Swirl
---
hw/rtl8139.c | 20 +++-
1 files changed, 3 insertions(+), 17 deletions(-)
diff --git a/hw/rtl8139.c
Here is version 5 of my patchset to add vlan support to the emulated rtl8139
nic.
Changes since v4:
* removed alloca(), for real. Thanks to the reviewers for their
patience. This patchset now has more versions than the vlan header
has bytes!
* corrected the unli
Add support to the emulated hardware to extract vlan tags in packets
going from the network to the guest.
Signed-off-by: Benjamin Poirier
Cc: Igor V. Kovalenko
Cc: Jason Wang
Cc: Michael S. Tsirkin
--
AFAIK, extraction is optional to get vlans working. The driver
requests rx detagging but
Add support to the emulated hardware to insert vlan tags in packets
going from the guest to the network.
Signed-off-by: Benjamin Poirier
Cc: Igor V. Kovalenko
Cc: Jason Wang
Cc: Michael S. Tsirkin
---
hw/rtl8139.c | 102 ++
1 files
I've tested v4 with x86_64 host/guest. I used the same testing procedure as
before. I've tested a plain configuration as well as one with tso + vlan
offload, successfully.
I had to hack around the Linux 8139cp driver to be able to enable tso on vlan
which leads me to wonder, can someone with acces
Add support to the emulated hardware to extract vlan tags in packets
going from the network to the guest.
Signed-off-by: Benjamin Poirier
Cc: Igor V. Kovalenko
Cc: Jason Wang
Cc: Michael S. Tsirkin
--
AFAIK, extraction is optional to get vlans working. The driver
requests rx detagging but
Add support to the emulated hardware to insert vlan tags in packets
going from the guest to the network.
Signed-off-by: Benjamin Poirier
Cc: Igor V. Kovalenko
Cc: Jason Wang
Cc: Michael S. Tsirkin
---
hw/rtl8139.c | 123 +-
1 files
I've posted v2 of these patches back in november
http://article.gmane.org/gmane.comp.emulators.qemu/84252
Changes since v2:
insertion:
* moved insertion later in the process, to handle tso
* use qemu_sendv_packet() to insert the tag for us
* added dot1q_buf parameter to rt
Signed-off-by: Benjamin Poirier
---
net.c | 28 ++--
1 files changed, 6 insertions(+), 22 deletions(-)
diff --git a/net.c b/net.c
index ec4745d..15ed40b 100644
--- a/net.c
+++ b/net.c
@@ -36,6 +36,7 @@
#include "qemu-common.h"
#include "qemu_socket.h
On 16/11/10 03:06 PM, Anthony Liguori wrote:
> On 11/08/2010 07:46 PM, Benjamin Poirier wrote:
>> Add support to the emulated hardware to add vlan tags in packets going
>> from the guest to the network.
>>
>> Signed-off-by: Benjamin Poirier
>> Cc: Igor V. Kov
Add support to the emulated hardware to remove vlan tags in packets
going from the network to the guest.
Signed-off-by: Benjamin Poirier
Cc: Igor V. Kovalenko
---
Changes since v1:
* moved the debug print statement inside the if block and reworded
accordingly. (as suggested by Igor)
AFAIK
Add support to the emulated hardware to add vlan tags in packets going
from the guest to the network.
Signed-off-by: Benjamin Poirier
Cc: Igor V. Kovalenko
---
Changes since v1:
* moved the debug print statement inside the if block and reworded
accordingly. (as suggested by Igor)
hw/rtl8139
On 08/11/10 11:34 AM, Stefan Hajnoczi wrote:
> On Sun, Nov 7, 2010 at 9:25 PM, Benjamin Poirier
> wrote:
>> Add support to the emulated hardware to add vlan tags in packets going
>> from the guest to the network.
>>
>> Signed-off-by: Benjamin Poirier
>>
Add support to the emulated hardware to remove vlan tags in packets
going from the network to the guest.
Signed-off-by: Benjamin Poirier
Cc: Igor V. Kovalenko
--
AFAIK, extraction is optional to get vlans working. The driver
requests rx detagging but should not assume that it was done. Under
Add support to the emulated hardware to add vlan tags in packets going
from the guest to the network.
Signed-off-by: Benjamin Poirier
Cc: Igor V. Kovalenko
---
hw/rtl8139.c | 46 +++---
1 files changed, 35 insertions(+), 11 deletions(-)
diff --git a
30 matches
Mail list logo
