In ga_get_win_product_name() a handle to Registry key was open
but not closed.
In this patch the handle is closed as part of the free routine.
Buglink: https://bugzilla.redhat.com/show_bug.cgi?id=1929144
Signed-off-by: Basil Salman
Signed-off-by: Basil Salman
---
qga/commands-win32.c | 8
/show_bug.cgi?id=1909073
Signed-off-by: Basil Salman
Signed-off-by: Basil Salman
---
qga/vss-win32/requester.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/vss-win32/requester.cpp b/qga/vss-win32/requester.cpp
index 5378c55d23..940a2c8f55 100644
--- a/qga/vss-win32/requester.cpp
On the current error path of build_guest_fsinfo(), a non existent
handle is passed to CloseHandle().
This patch add initialization of hLocalDiskHandle to INVALID_HANDLE_VALUE,
and checks for handle validity before the handle is closed.
Signed-off-by: Basil Salman
Signed-off-by: Basil Salman
From: Basil Salman
On one hand "guest-fsfreeze-freeze" command, "COM+ System Application service"
is
stopped, on the other hand "guest-fsfreeze-thaw" stops QGA VSS Provider service
from
"COM+ Application Admin Catalog".
Invoking a series of freeze and th
Ping
On Thu, Apr 30, 2020 at 3:11 PM Basil Salman wrote:
> From: Basil Salman
>
> This patch handles the case where unmounted volumes exist,
> where in that case GetVolumePathNamesForVolumeName returns
> empty path, GetVolumeInformation will use the current working
> directo
From: Basil Salman
This patch handles the case where unmounted volumes exist,
where in that case GetVolumePathNamesForVolumeName returns
empty path, GetVolumeInformation will use the current working
directory instead.
This patch fixes the issue by opening a handle to the volumes,
and using
This patch series addresses serveral issues with qga-win please review
them and share your thoughts.
Basil Salman (2):
qga: Installer: Wait for installation to finish
qga-win: prevent crash when executing guest-file-read with large count
Sameeh Jubran (1):
qga-win: Handle
client accordingly.
Signed-off-by: Basil Salman
---
qga/commands-win32.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 9c744d6405..b49920e201 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -343,7 +343,13
From: Sameeh Jubran
This patch handles the case where VSS Provider is already registered,
where in such case qga uninstalls the provider and registers it again.
Signed-off-by: Sameeh Jubran
Signed-off-by: Basil Salman
---
qga/vss-win32/install.cpp | 11 +++
1 file changed, 11
Installation might fail if we don't wait for the provider
unregisteration process to finish.
Signed-off-by: Sameeh Jubran
Signed-off-by: Basil Salman
---
qga/installer/qemu-ga.wxs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/installer/qemu-ga.wxs b/qga/installer
PING
On Thu, Oct 17, 2019 at 3:34 PM Basil Salman wrote:
> From: Basil Salman
>
> "guest-get-memory-block-info" is enabled according to "get-info" output,
> while the command is only supported for linux with sysfs.
>
> "guest-get-memory-block-info
From: Basil Salman
"guest-get-memory-block-info" is enabled according to "get-info" output,
while the command is only supported for linux with sysfs.
"guest-get-memory-block-info" command was added to blacklist.
Basil Salman (1):
qga: Add "guest-get-me
From: Basil Salman
Memory block commands are only supported for linux with sysfs,
"guest-get-memory-block-info" was not in blacklist for other
cases.
Reported on:
https://bugzilla.redhat.com/show_bug.cgi?id=1751431
Signed-off-by: Basil Salman
---
qga/commands-posix.c | 3 ++-
qg
From: Sameeh Jubran
This patch handles the case where VSS Provider is already registered,
where in such case qga uninstalls the provider and registers it again.
Signed-off-by: Sameeh Jubran
Signed-off-by: Basil Salman
---
qga/vss-win32/install.cpp | 11 +++
1 file changed, 11
Installation might fail if we don't wait for the provider
unregisteration process to finish.
Signed-off-by: Sameeh Jubran
Signed-off-by: Basil Salman
---
qga/installer/qemu-ga.wxs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/installer/qemu-ga.wxs b/qga/installer
client accordingly.
Signed-off-by: Basil Salman
---
qga/commands-win32.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 62e1b51dfe..4260faa573 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -345,7 +345,13
.
Signed-off-by: Basil Salman
---
qga/main.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/qga/main.c b/qga/main.c
index 87a0711c14..964275c40c 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -561,6 +561,8 @@ static void process_command(GAState *s, QDict *req)
{
QDict *rsp
This patch series addresses serveral issues with qga-win please review
them and share your thoughts.
Basil Salman (3):
qga-win: prevent crash when executing guest-file-read with large count
qga: fix send_response error handling
qga: Installer: Wait for installation to finish
Sameeh Jubran
client accordingly.
Signed-off-by: Basil Salman
---
qga/commands-win32.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/qga/commands-win32.c b/qga/commands-win32.c
index 62e1b51dfe..4260faa573 100644
--- a/qga/commands-win32.c
+++ b/qga/commands-win32.c
@@ -345,7 +345,13
.
Signed-off-by: Basil Salman
---
qga/main.c | 13 +
1 file changed, 13 insertions(+)
diff --git a/qga/main.c b/qga/main.c
index 87a0711c14..964275c40c 100644
--- a/qga/main.c
+++ b/qga/main.c
@@ -561,6 +561,8 @@ static void process_command(GAState *s, QDict *req)
{
QDict *rsp
From: Sameeh Jubran
This patch handles the case where VSS Provider is already registered,
where in such case qga uninstalls the provider and registers it again.
Signed-off-by: Sameeh Jubran
Signed-off-by: Basil Salman
---
qga/vss-win32/install.cpp | 10 ++
1 file changed, 10
This patch series addresses serveral issues with qga-win please review
them and share your thoughts.
Basil Salman (3):
qga-win: prevent crash when executing guest-file-read with large count
qga: fix send_response error handling
qga: Installer: Wait for installation to finish
Sameeh Jubran
Installation might fail if we don't wait for the provider
unregisteration process to finish.
Signed-off-by: Sameeh Jubran
Signed-off-by: Basil Salman
---
qga/installer/qemu-ga.wxs | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/qga/installer/qemu-ga.wxs b/qga/installer
23 matches
Mail list logo
