On Thu, 17 Jul 2025, Xiaoyao Li wrote:
On 7/17/2025 1:28 AM, Philippe Mathieu-Daudé wrote:
Developers are custom to read RWX, not RWE.
"accustomed to"
Replace E -> X.
Reported-by: Alex Bennée
Signed-off-by: Philippe Mathieu-Daudé
Reviewed-by: Xiaoyao Li
---
accel/hvf/hvf-all.c | 2
ashed in patch 13.
Regards,
BALATON Zoltan
SocketAddress *socket;
bool send_queued; /* all sends are queued */
uint32_t wait_time; /* timeout for message replies */
necessary casts to functions
that can be called a lot.
Regards,
BALATON Zoltan
if (!event_notifier_test_and_clear(&vdev->intx.interrupt)) {
return;
@@ -127,7 +128,7 @@ static void vfio_intx_interrupt(void *opaque)
trace_vfio_intx_interrupt(vdev->vbasedev.name, 'A
Add field for the south bridge in machine state to have both north and
south bridges in it.
Signed-off-by: BALATON Zoltan
Reviewed-by: Philippe Mathieu-Daudé
---
hw/ppc/pegasos2.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c
index
Move the chipset reset which is pegasos2 specific out from machine
reset to a separate function and move parts not specific to pegasos2
form build_fdt in machine reset so now build_fdt contains pegasos2
specific parts and renamed accordingly.
Signed-off-by: BALATON Zoltan
---
hw/ppc/pegasos2.c
Store the bus frequency in the machine state and set it from instance
init method.
Signed-off-by: BALATON Zoltan
---
hw/ppc/pegasos2.c | 25 -
1 file changed, 16 insertions(+), 9 deletions(-)
diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c
index f7999520e4
These are not needed any more now that VOF can handle it.
Signed-off-by: BALATON Zoltan
---
hw/ppc/pegasos2.c | 17 -
1 file changed, 17 deletions(-)
diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c
index e15cf96427..73995624e5 100644
--- a/hw/ppc/pegasos2.c
+++ b/hw/ppc
more generic.
Signed-off-by: BALATON Zoltan
---
hw/ppc/pegasos2.c| 292 +++
pc-bios/dtb/meson.build | 1 +
pc-bios/dtb/pegasos2.dtb | Bin 0 -> 1701 bytes
pc-bios/dtb/pegasos2.dts | 167 ++
4 files changed, 220 insertions(+),
-off-by: BALATON Zoltan
---
hw/ppc/pegasos2.c | 170 +-
1 file changed, 124 insertions(+), 46 deletions(-)
diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c
index ae3f01231d..a88d93ae04 100644
--- a/hw/ppc/pegasos2.c
+++ b/hw/ppc/pegasos2.c
@@ -1,5 +1,5
Add a more general DEFINE_MACHINE_EXTENDED macro and define simpler
versions with less parameters based on that. This is inspired by how
the OBJECT_DEFINE macros do this in a similar way to allow using the
shortened definition in more complex cases too.
Signed-off-by: BALATON Zoltan
---
include
2 which is how it
identifies the machine.
Signed-off-by: BALATON Zoltan
Reviewed-by: Alexey Kardashevskiy
---
hw/ppc/vof.c | 50 +-
1 file changed, 33 insertions(+), 17 deletions(-)
diff --git a/hw/ppc/vof.c b/hw/ppc/vof.c
index f14efa3a7c..
DEFINE_MACHINE macro that is later
used for more easily define the abstract machine type and hide most of
the QOM boiler plate.
Regards,
BALATON Zoltan
v2:
- rebase on master
- added some R-b tags from Philippe
- move first patch later (was first to allow merging separately)
- clarify blurb above
Rename machine state struct to PegasosMachineState as it will be used
for pegasos1 too.
Signed-off-by: BALATON Zoltan
---
hw/ppc/pegasos2.c | 66 ---
1 file changed, 34 insertions(+), 32 deletions(-)
diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c
Use more generic name for the field used to store the north bridge in
the machine state.
Signed-off-by: BALATON Zoltan
Reviewed-by: Philippe Mathieu-Daudé
---
hw/ppc/pegasos2.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/hw/ppc/pegasos2.c b/hw/ppc
When running without firmware ROM using Virtual Open Firmware we need
to do some hardware initialisation and provide the device tree as the
machine firmware would normally do.
Signed-off-by: BALATON Zoltan
---
MAINTAINERS | 1 +
hw/ppc/pegasos2.c| 140
Collect steps of setting up PCI IRQ routing in one function.
Signed-off-by: BALATON Zoltan
---
hw/ppc/pegasos2.c | 66 +++
1 file changed, 33 insertions(+), 33 deletions(-)
diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c
index 66bceec5ef
The machine class has a field for storing the fdt so we don't need our
own and can use that instead.
Signed-off-by: BALATON Zoltan
---
hw/ppc/pegasos2.c | 7 ++-
1 file changed, 2 insertions(+), 5 deletions(-)
diff --git a/hw/ppc/pegasos2.c b/hw/ppc/pegasos2.c
index 646755a3cc..7dc78
The mmcfg field in PCIHostState is only used by raven for the PCI
config direct access but is not actually needed as the memory region
lifetime can be managed by the object given during init so use that
and remove the unused field from PCIHostState.
Signed-off-by: BALATON Zoltan
---
hw/pci-host
discontiguous IO addresses.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c| 9 -
hw/ppc/prep.c | 3 +++
hw/ppc/prep_systemio.c | 14 --
3 files changed, 11 insertions(+), 15 deletions(-)
diff --git a/hw/pci-host/raven.c b/hw/pci-host/raven.c
index
the address space that is used later in a
callback.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c | 37 ++---
1 file changed, 18 insertions(+), 19 deletions(-)
diff --git a/hw/pci-host/raven.c b/hw/pci-host/raven.c
index bf4f4b7f71..ebf0c511dc 100644
--- a
No need to use an or-irq to map interrupt lines to a single IRQ as the
PCI code can handle this internally so simplify by dropping the or-irq.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c | 39 +++
hw/ppc/prep.c | 5 -
2 files changed, 19
Use ctz instead of an open coded version and rename function to better
show what it does.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/hw/pci-host/raven.c b/hw/pci-host/raven.c
index a400a22df3
Export memory regions as sysbus mmio regions and let the board code
map them similar to how it is done in grackle.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c | 37 -
hw/ppc/prep.c | 11 +--
2 files changed, 21 insertions(+), 27
The PCI configuration direct access region occupies 8 MiB at offset
0x80 in PCI IO space so model that accordingly.
Signed-off-by: BALATON Zoltan
Reviewed-by: Philippe Mathieu-Daudé
---
hw/pci-host/raven.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/pci-host
Convert to using DEFINE_TYPES macro and move raven_pcihost_class_init
so methods of each object are grouped together.
Signed-off-by: BALATON Zoltan
Reviewed-by: Philippe Mathieu-Daudé
---
hw/pci-host/raven.c | 57 +
1 file changed, 26 insertions
Instead of passing unneeded enclosing objects to the config direct
access ops that only need the bus we can pass that directly thus
simplifying the functions.
Signed-off-by: BALATON Zoltan
Reviewed-by: Philippe Mathieu-Daudé
---
hw/pci-host/raven.c | 14 +++---
1 file changed, 7
The raven PCI device does not need a state struct as it has no data to
store there any more, so we can remove that to simplify code.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c | 30 +-
1 file changed, 1 insertion(+), 29 deletions(-)
diff --git a/hw/pci
Rename memory io ops implementing PCI configuration direct access to
mmcfg which describes better what these are for.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/hw/pci-host/raven.c b/hw/pci-host
bit which was there but did not work as it
was not connected but apparently it's not really used by any guest so
that wasn't noticed.
Regards,
BALATON Zoltan
v2:
- rebase on master
- add R-b tags from Philippe
BALATON Zoltan (14):
hw/pci-host/raven: Simplify PCI facing part
hw/pci-
Instead of doing it manually use pci_register_root_bus() to create and
register the PCI bus.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/hw/pci-host/raven.c b/hw/pci-host/raven.c
index e0f98afebf
enabling/disabling the discontiguous
region as needed.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c | 88 -
1 file changed, 22 insertions(+), 66 deletions(-)
diff --git a/hw/pci-host/raven.c b/hw/pci-host/raven.c
index bb0be40eb4..bf4f4b7f71
Use OBJECT_DECLARE_SIMPLE_TYPE macro instead of open coding it.
Signed-off-by: BALATON Zoltan
Reviewed-by: Philippe Mathieu-Daudé
---
hw/pci-host/raven.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/pci-host/raven.c b/hw/pci-host/raven.c
index 172f01694c
node characters
(e.g., +--, |--), is a better approach.
As BALATON Zoltan pointed out, retaining space-based indentation for displaying
memory region (mr) nodes helps ensure that the output remains easily parseable
by other programs. This also provides better compatibility with existing tools
and
On Mon, 16 Jun 2025, Philippe Mathieu-Daudé wrote:
On 11/3/25 13:58, Nicholas Piggin wrote:
From: BALATON Zoltan
Add support for -kernel, -initrd and -append command line options.
Signed-off-by: BALATON Zoltan
Reviewed-by: Nicholas Piggin
Message-ID
depends: precache_all,
command: [python, '-c', ''])
Should I send a v4 of my patch?
I think it would help if you can send a v4 also fixing up the commit
message as was discussed so Stefan does not have to do it. Generally more
than trivial fixup needs a new version of the patch sent by the author,
only fixing simple typos might not need a resend. Ideally maintainers
should not need to do any fixup just take the latest patch version.
Regards,
BALATON Zoltan
On Thu, 12 Jun 2025, Paolo Bonzini wrote:
On 6/11/25 13:45, BALATON Zoltan wrote:
On Wed, 11 Jun 2025, Daniel P. Berrangé wrote:
On Wed, Jun 11, 2025 at 02:37:08AM +0200, BALATON Zoltan wrote:
On Tue, 10 Jun 2025, Bernhard Beschow wrote:
The next patch will make dtc mandatory for boards with
On Wed, 11 Jun 2025, Stefan Hajnoczi wrote:
On Wed, Jun 11, 2025 at 3:25 PM BALATON Zoltan wrote:
On Wed, 11 Jun 2025, Stefan Hajnoczi wrote:
From: oltolm
Sorry, I forgot to cc the maintainers.
Do we want comments like this end up in git log? This could have been
fixed before a pull
gards,
BALATON Zoltan
The build failed when run on Windows. I replaced calls to Unix programs
like ´cat´, ´sed´ and ´true´ with calls to ´python´. I wrapped calls to
´os.path.relpath´ in try-except because it can fail when the two paths
are on different drives. I made sure to convert the Windows pat
On Wed, 11 Jun 2025, Daniel P. Berrangé wrote:
On Wed, Jun 11, 2025 at 02:37:08AM +0200, BALATON Zoltan wrote:
On Tue, 10 Jun 2025, Bernhard Beschow wrote:
The next patch will make dtc mandatory for boards with a bundled DTB, causing
these boards to be omitted when dtc is missing. Allow
nown
working dtc to compile with. Why isn't that used when we already have it
for libfdt?
Regards,
BALATON Zoltan
Signed-off-by: Bernhard Beschow
---
meson.build | 12
Kconfig.host | 3 +++
meson_options.txt | 3 +++
pc-bios/d
On Tue, 10 Jun 2025, Bernhard Beschow wrote:
When changing meson_options.txt, this script gets updated automatically by QEMU
tooling which sorts the choices lexicographically. Fix this in preparation of
the ext patch.
Typo: next patch
Fixes: ccc403ed5844 ("meson: Add wasm build in build scrip
On Tue, 10 Jun 2025, Philippe Mathieu-Daudé wrote:
Hi Zoltan,
On 2/5/25 01:20, BALATON Zoltan wrote:
Add a more general DEFINE_MACHINE_EXTENDED macro and define simpler
versions with less parameters based on that. This is inspired by how
the OBJECT_DEFINE macros do this in a similar way to
On Mon, 9 Jun 2025, BALATON Zoltan wrote:
On Mon, 9 Jun 2025, Tanish Desai wrote:
Moved the logic for timestamped logging (~6 lines) from
a_nocheck__trace_foo(header) into a new qemu_log_timestamp() function in
util/log.c. This avoids code duplication across binaries and enables reuse
as a
build time or
disk space but I could be wrong.
Regards,
BALATON Zoltan
Signed-off-by: Tanish Desai
---
include/qemu/log-for-trace.h | 3 +++
scripts/tracetool/backend/log.py | 13 +
util/log.c | 18 ++
3 files changed, 22 insertions(+), 12
On Thu, 5 Jun 2025, Philippe Mathieu-Daudé wrote:
tpm_emulator_ctrlcmd() is not in hot path.
Use the heap instead of the stack, removing
the g_alloca() call.
Typo in subject L -> :
Regards,
BALATON Zoltan
Signed-off-by: Philippe Mathieu-Daudé
---
backends/tpm/tpm_emulator.c | 4 ++--
1 f
On Tue, 3 Jun 2025, Philippe Mathieu-Daudé wrote:
On 4/5/25 18:01, BALATON Zoltan wrote:
Export memory regions as sysbus mmio regions and let the board code
map them.
Why? The mapping belong to the host bridge, not the board...
I took inspiration from grackle that does it the same way
On Tue, 3 Jun 2025, Philippe Mathieu-Daudé wrote:
Hi Zoltan,
On 4/5/25 18:01, BALATON Zoltan wrote:
The raven PCI device does not need a state struct as it has no data to
store there any more so we can remove that to simplify code.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c | 30
On Tue, 3 Jun 2025, Philippe Mathieu-Daudé wrote:
On 4/5/25 18:01, BALATON Zoltan wrote:
The mmcfg field in PCIHostState is only used by raven for the PCI
config direct access but is not actually needed as the memory region
lifetime can be managed by the object given during init so use that
and
On Tue, 3 Jun 2025, Bernhard Beschow wrote:
Am 2. Juni 2025 08:12:39 UTC schrieb "Philippe Mathieu-Daudé"
:
On 30/5/25 02:54, BALATON Zoltan wrote:
On Thu, 29 May 2025, Bernhard Beschow wrote:
Am 25. April 2025 15:28:20 UTC schrieb "Philippe Mathieu-Daudé"
:
From: BALA
On Fri, 23 May 2025, BALATON Zoltan wrote:
On Fri, 2 May 2025, BALATON Zoltan wrote:
This series changes how the fdt for VOF is generated in pegasos2 by
moving the static parts to a dtb and only generate the changing parts
such as memory size and PCI devices programmatically. This simplifies
On Fri, 23 May 2025, BALATON Zoltan wrote:
On Sun, 4 May 2025, BALATON Zoltan wrote:
Hello,
This series cleans up and simplifies the raven model which does some
strange stuff that no other pci-host is doing and does it in a
convoluted way and also has some legacy bits that can be removed
On Mon, 2 Jun 2025, Philippe Mathieu-Daudé wrote:
On 30/5/25 02:54, BALATON Zoltan wrote:
On Thu, 29 May 2025, Bernhard Beschow wrote:
Am 25. April 2025 15:28:20 UTC schrieb "Philippe Mathieu-Daudé"
:
From: BALATON Zoltan
We have several device tree files already and may have m
On Thu, 29 May 2025, Bernhard Beschow wrote:
Am 25. April 2025 15:28:20 UTC schrieb "Philippe Mathieu-Daudé"
:
From: BALATON Zoltan
We have several device tree files already and may have more in the
future so add a new dtb subdirectory and move device tree files there
so they are
On Mon, 26 May 2025, Bernhard Beschow wrote:
Am 25. Mai 2025 00:03:15 UTC schrieb BALATON Zoltan :
On Sun, 28 Jul 2024, BALATON Zoltan wrote:
On Sun, 28 Jul 2024, quan wrote:
I am playing around with the parallel port on the pegasos 2 and I noticed
the following issue:
The parallel port on
On Sun, 28 Jul 2024, BALATON Zoltan wrote:
On Sun, 28 Jul 2024, quan wrote:
I am playing around with the parallel port on the pegasos 2 and I noticed
the following issue:
The parallel port on startup is set to iobase 0x378, then later it gets
remapped to iobase 0x3bc.
When I tried writing to
On Fri, 23 May 2025, Bernhard Beschow wrote:
From: Bernhard Beschow
This was meant to be only here but somehow it alse overwrote the ream
From that should have been my address. Sorry for that, but patch is still
correct.
Regards,
BALATON Zoltan
Rather than accessing the attributes of
Some small patches to e500 related parts. Also includes a patch from
Bernhard that is rebased on current version.
Regards,
BALATON Zoltan
BALATON Zoltan (2):
hw/ppc/e500: Move clock and TB frequency to machine class
hw/net/fsl_etsec: Set default MAC address
Bernhard Beschow (1):
hw/ppc
Use default MAC address if none is specified by property as done by
most other network interface models.
Signed-off-by: BALATON Zoltan
---
hw/net/fsl_etsec/etsec.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/hw/net/fsl_etsec/etsec.c b/hw/net/fsl_etsec/etsec.c
index d14cb2a101
Different machines have different frequencies so make this
configurable in machine class instead of using a hard coded constant.
Signed-off-by: BALATON Zoltan
---
hw/ppc/e500.c | 18 +-
hw/ppc/e500.h | 4
hw/ppc/e500plat.c | 2 ++
hw/ppc/mpc8544ds.c | 2 ++
4
On Sun, 4 May 2025, BALATON Zoltan wrote:
Hello,
This series cleans up and simplifies the raven model which does some
strange stuff that no other pci-host is doing and does it in a
convoluted way and also has some legacy bits that can be removed.
Apart from making the model much more readable
On Fri, 2 May 2025, BALATON Zoltan wrote:
This series changes how the fdt for VOF is generated in pegasos2 by
moving the static parts to a dtb and only generate the changing parts
such as memory size and PCI devices programmatically. This simplifies
the code and allows simply adding emulation of
me. Maybe rephrase?
Regards,
BALATON Zoltan
After this change, everything related to venus fencing starts making
sense. Confirmed this via guest and host side perfetto tracing.
Cc: qemu-sta...@nongnu.org
Fixes: 94d0ea1c1928 ("virtio-gpu: Support Venus context")
Signed-off-by: Yiwei Zhang
-
On Thu, 15 May 2025, Zhao Liu wrote:
On Wed, May 14, 2025 at 06:24:03PM +0200, BALATON Zoltan wrote:
Date: Wed, 14 May 2025 18:24:03 +0200
From: BALATON Zoltan
Subject: Re: [PATCH 8/9] target/s390x/kvm/pv: Consolidate
OBJECT_DEFINE_SIMPLE_TYPE_WITH_INTERFACES
On Wed, 14 May 2025, Zhao Liu
On Wed, 7 May 2025, BALATON Zoltan wrote:
On Wed, 7 May 2025, Christian Schoenebeck wrote:
On Tuesday, May 6, 2025 4:34:42 PM CEST BALATON Zoltan wrote:
On Tue, 8 Apr 2025, Volker Rümelin wrote:
Am 08.04.25 um 14:55 schrieb Christian Schoenebeck:
On Friday, April 4, 2025 1:34:27 PM CEST
ne
under ( but with 4 spaces then you can fit it in two lines but lines over
90 chars are undesirable.
Regards,
BALATON Zoltan
Reviewed-by: David Hildenbrand
Thanks!
Regards,
Zhao
On Wed, 14 May 2025, Zhao Liu wrote:
On Wed, May 14, 2025 at 02:06:14PM +0200, BALATON Zoltan wrote:
Date: Wed, 14 May 2025 14:06:14 +0200
From: BALATON Zoltan
Subject: Re: [PATCH 2/9] docs/devel/qom: Fix the doc about
OBJECT_DECLARE_SIMPLE_TYPE
On Wed, 14 May 2025, Zhao Liu wrote
On Wed, 14 May 2025, Zhao Liu wrote:
Hi BALATON,
In case you did not know:
https://en.wikipedia.org/wiki/Name_order#Hungary
On Wed, May 14, 2025 at 02:02:48PM +0200, BALATON Zoltan wrote:
Date: Wed, 14 May 2025 14:02:48 +0200
From: BALATON Zoltan
Subject: Re: [PATCH 1/9] qom/object
: BALATON Zoltan
E not
OBJECT_DEFINE_SIMPLE_TYPE_WITH_INTERFACES so change commit message to
match the patch.
Regards,
BALATON Zoltan
the type, then there's no need for class definition.
Cc: Yoshinori Sato
Cc: Magnus Damm
Cc: "Marc-André Lureau"
Cc: Paolo Bonzini
Signed-off-by: Zhao Liu
---
hw/char/sh_serial.c | 4 +-
s to be declared separately.
If the type requires virtual functions to be declared in the class
struct, then the alternative OBJECT_DECLARE_TYPE() macro can be
Maybe you need to adjust the text here about OBJECT_DECLARE_TYPE here and
show how to define Class sturct?
Regards,
BALATON Zoltan
choice" is
simpler.
Regards,
BALATON Zoltan
*/
#define OBJECT_DEFINE_SIMPLE_TYPE_WITH_INTERFACES(ModuleObjName, \
module_obj_name, \
On Wed, 14 May 2025, BALATON Zoltan wrote:
On Wed, 14 May 2025, Zhao Liu wrote:
The QOM type of PefGuest is declared by OBJECT_DECLARE_SIMPLE_TYPE,
which means it doesn't need the class!
Therefore, use OBJECT_DEFINE_SIMPLE_TYPE_WITH_INTERFACES to implement
the type, then there's n
an I still specify a scale factor to scale it up to usable size? That's a
use case I care about which might be unusual but does exist.
Regards,
BALATON Zoltan
Thanks for your suggestion. Sounds like code could be simplified and be
much easier to understand in this way. I will investigate it
hardcoded
USER_CREATABLE interface here so if such variant is added it would clash.
Better call this something that shows this is PEF specific or just use the
appropriate macro from qemu/object.h to define it.
Regards,
BALATON Zoltan
static void pef_guest_class_init(ObjectClass *oc, const void *data)
{
On Tue, 13 May 2025, Weifeng Liu wrote:
Hi,
On Tue, 2025-05-13 at 11:52 +0200, BALATON Zoltan wrote:
On Tue, 13 May 2025, Weifeng Liu wrote:
Hi,
On Tue, 2025-05-13 at 00:37 +, Kim, Dongwon wrote:
Hi,
Subject: [PATCH 8/9] ui/gtk-gl-area: Render guest content with
padding in
fixed-scale
On Tue, 13 May 2025, Alexey Kardashevskiy wrote:
On Wed, 30 Apr 2025, at 21:21, BALATON Zoltan wrote:
On Wed, 23 Apr 2025, BALATON Zoltan wrote:
The FDT does not normally store name properties but reconstructs it
from path but Open Firmware specification says each node should at
least have
behaviour so it seems some prefer one or the other and just zoom-to-fit
can't set both.
Regards,
BALATON Zoltan
ating between QEMU
versions or for testing. It might have some uses and maybe that's the
reason why people would like these to go through deprecation instead of
just dropping them. Marking some properties not exposed would get the same
resistance then so may not solve the issue.
Regards,
BALATON Zoltan
eded. A property is just like an accessor function with additional
complexity to expose it to other interfaces so it's externally settable
and introspectable but we don't need those for internal properties so we
can drop that complexity and get back to the accessor function at the
bottom of it.
Regards,
BALATON Zoltan
On Wed, 7 May 2025, Christian Schoenebeck wrote:
On Tuesday, May 6, 2025 4:34:42 PM CEST BALATON Zoltan wrote:
On Tue, 8 Apr 2025, Volker Rümelin wrote:
Am 08.04.25 um 14:55 schrieb Christian Schoenebeck:
On Friday, April 4, 2025 1:34:27 PM CEST BALATON Zoltan wrote:
On Fri, 4 Apr 2025
the change you want, isn't it?
We have "false by default" properties so it unfortunately does not work.
Then make the code make "absent" mean what you need it to mean. Just
like the code from ide_dev_initfn() I quoted above.
This would change the value for false as
On Tue, 8 Apr 2025, Volker Rümelin wrote:
Am 08.04.25 um 14:55 schrieb Christian Schoenebeck:
On Friday, April 4, 2025 1:34:27 PM CEST BALATON Zoltan wrote:
On Fri, 4 Apr 2025, Christian Schoenebeck wrote:
On Monday, March 31, 2025 3:05:24 PM CEST BALATON Zoltan wrote:
On Sun, 23 Mar 2025
the address space that is used later in a
callback.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c | 37 ++---
1 file changed, 18 insertions(+), 19 deletions(-)
diff --git a/hw/pci-host/raven.c b/hw/pci-host/raven.c
index 476ae5bc65..68d64e3a97 100644
--- a
No need to use an or-irq to map interrupt lines to a single IRQ as the
PCI code can handle this internally so simplify by dropping the or-irq.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c | 39 +++
hw/ppc/prep.c | 5 -
2 files changed, 19
Convert to using DEFINE_TYPES macro and move raven_pcihost_class_init
so methods of each object are grouped together.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c | 57 +
1 file changed, 26 insertions(+), 31 deletions(-)
diff --git a/hw/pci
The mmcfg field in PCIHostState is only used by raven for the PCI
config direct access but is not actually needed as the memory region
lifetime can be managed by the object given during init so use that
and remove the unused field from PCIHostState.
Signed-off-by: BALATON Zoltan
---
hw/pci-host
The PCI configuration direct access region occupies 8 MiB at offset
0x80 in PCI IO space so model that accordingly.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/pci-host/raven.c b/hw/pci-host/raven.c
index
Export memory regions as sysbus mmio regions and let the board code
map them.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c | 37 -
hw/ppc/prep.c | 11 +--
2 files changed, 21 insertions(+), 27 deletions(-)
diff --git a/hw/pci-host
Instead of doing it manually use pci_register_root_bus() to create and
register the PCI bus.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c | 18 +++---
1 file changed, 7 insertions(+), 11 deletions(-)
diff --git a/hw/pci-host/raven.c b/hw/pci-host/raven.c
index e0f98afebf
Use ctz instead of an open coded version and rename function to better
show what it does.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c | 15 ---
1 file changed, 4 insertions(+), 11 deletions(-)
diff --git a/hw/pci-host/raven.c b/hw/pci-host/raven.c
index a400a22df3
Instead of passing unneeded enclosing objects to the config direct
access ops that only need the bus we can pass that directly thus
simplifying the functions.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/hw
Rename memory io ops implementing PCI configuration direct access to
mmcfg which describes better what these are for.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c | 17 -
1 file changed, 8 insertions(+), 9 deletions(-)
diff --git a/hw/pci-host/raven.c b/hw/pci-host
Use OBJECT_DECLARE_SIMPLE_TYPE macro instead of open coding it.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/hw/pci-host/raven.c b/hw/pci-host/raven.c
index 172f01694c..878c915de5 100644
--- a/hw/pci-host/raven.c
bit which was there but did not work as it
was not connected but apparently it's not really used by any guest so
that wasn't noticed.
Regards,
BALATON Zoltan
BALATON Zoltan (16):
hw/pci-host/raven: Remove is-legacy-prep property
hw/pci-host/raven: Revert "raven: Move BIOS loa
enabling/disabling the discontiguous
region as needed.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c | 88 -
1 file changed, 22 insertions(+), 66 deletions(-)
diff --git a/hw/pci-host/raven.c b/hw/pci-host/raven.c
index 318400c595..476ae5bc65
discontinuous IO addresses.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c| 9 -
hw/ppc/prep.c | 3 +++
hw/ppc/prep_systemio.c | 14 --
3 files changed, 11 insertions(+), 15 deletions(-)
diff --git a/hw/pci-host/raven.c b/hw/pci-host/raven.c
index
This was a workaround for the prep machine that was removed 5 years
ago so this is no longer needed.
Fixes: b2ce76a073 (hw/ppc/prep: Remove the deprecated "prep" machine
and the OpenHackware BIOS)
Signed-off-by: BALATON Zoltan
---
hw/pci-host/ra
has nothing to do with ROM so it is not a
good place for this.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c | 55 -
hw/ppc/prep.c | 27 --
2 files changed, 25 insertions(+), 57 deletions(-)
diff --git a/hw/pci-host
The raven PCI device does not need a state struct as it has no data to
store there any more so we can remove that to simplify code.
Signed-off-by: BALATON Zoltan
---
hw/pci-host/raven.c | 30 +-
1 file changed, 1 insertion(+), 29 deletions(-)
diff --git a/hw/pci
ent,
- int is_extended, int size);
+void * get_reg_ref(CPUX86State *env, int reg, int rex_present,
+int is_extended, int size);
Stray space after *, checkpatch should have cought it.
Regards,
BALATON Zoltan
1 - 100 of 1482 matches
Mail list logo
