On 15/07/2025 12:08, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 7/8/25 10:34, Avihai Horon wrote:
On 24/06/2025 20:51, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
Thi
that it is loaded as part of
the non-iterables:
This property allows configuring whether to start the config load only
after all iterables were loaded, during non-iterables loading phase.
(We can also mention this in docs/code comment)
Anyway:
Reviewed-by: Avihai Horon
Such interlocking i
ej S. Szmigiero
Reviewed-by: Avihai Horon
ned-off-by: Maciej S. Szmigiero
Reviewed-by: Avihai Horon
But do we really need both x-migration-max-queued-buffers and
x-migration-max-queued-buffers-size?
I think one is sufficient.
I vote for x-migration-max-queued-buffers-size as the actual memory
limit won't change depending on
On 20/03/2025 13:18, Joao Martins wrote:
External email: Use caution opening links or attachments
On 20/03/2025 11:13, Avihai Horon wrote:
On 19/03/2025 14:21, Joao Martins wrote:
External email: Use caution opening links or attachments
On 18/03/2025 09:54, Cédric Le Goater wrote
On 18/03/2025 11:53, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
Gather all VFIO migration related declarations into "migration.h" to
reduce exposure of VFIO internals in "hw/vfio/vfio-common.h".
Reviewed-by: Avihai Horon
Two nits
On 19/03/2025 14:21, Joao Martins wrote:
External email: Use caution opening links or attachments
On 18/03/2025 09:54, Cédric Le Goater wrote:
Rename these routines :
vfio_devices_all_device_dirty_tracking_started ->
vfio_dirty_tracking_devices_is_started_all
vfio_devices_all_dirty_t
On 24/03/2025 17:25, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 3/24/25 16:14, Avihai Horon wrote:
On 24/03/2025 14:33, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
VFIO uses migration_file_set_error() in a
On 24/03/2025 14:33, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
VFIO uses migration_file_set_error() in a couple of places where an
'Error **' parameter is not provided. In MemoryListener handlers :
vfio_listener_region_add
vfio_listener_log_global
On 20/03/2025 13:56, Joao Martins wrote:
External email: Use caution opening links or attachments
On 20/03/2025 11:45, Avihai Horon wrote:
On 20/03/2025 13:18, Joao Martins wrote:
External email: Use caution opening links or attachments
On 20/03/2025 11:13, Avihai Horon wrote:
On 19/03
On 18/03/2025 11:54, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
"hw/vfio/vfio-common.h" has been emptied of most of its declarations
by the previous changes and the only declarations left are related to
VFIODevice. Rename it to "hw/vfio/vfio-device.h" and
On 18/03/2025 11:53, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
The migration core subsytem makes uses of the VFIO migration API to
collect statistics on the number of bytes transferred. These services
are declared in "hw/vfio/vfio-common.h" which also co
On 18/03/2025 11:53, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
vfio_mig_active() is part of the VFIO migration API. Move the
definitions where VFIO migration is implemented.
Signed-off-by: Cédric Le Goater
Reviewed-by: Avihai Horon
One nit below
On 18/03/2025 11:53, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
Enforce a 'vfio_mig_' prefix for the VFIO migration API to better
reflect the namespace these routines belong to.
Signed-off-by: Cédric Le Goater
Reviewed-by: Avihai Horon
S
On 11/03/2025 18:05, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 3/11/25 17:01, Avihai Horon wrote:
On 11/03/2025 17:45, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 3/11/25 15:57, Avihai Horon wrote:
On 11
On 05/03/2025 0:03, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
Implement the multifd device state transfer via additional per-device
thread inside save_live_complete_precopy_thread handler.
Switch between doing the data t
On 11/03/2025 17:45, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 3/11/25 15:57, Avihai Horon wrote:
On 11/03/2025 15:04, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 3/7/25 14:45, Maciej S. Szmigiero wrote
On 11/03/2025 15:04, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 3/7/25 14:45, Maciej S. Szmigiero wrote:
On 7.03.2025 13:03, Cédric Le Goater wrote:
On 3/7/25 11:57, Maciej S. Szmigiero wrote:
From: "Maciej S. Szmigiero"
There's already a max in-f
evice state transfer support -
received buffers queuing")
Fixes: 6d644baef203 ("vfio/migration: Multifd device state transfer support - send
side")
Signed-off-by: Maciej S. Szmigiero
Reviewed-by: Avihai Horon
Thanks.
---
hw/vfio/migration-multifd.c | 15 ++-
On 06/03/2025 16:13, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
On 6.03.2025 14:37, Avihai Horon wrote:
On 06/03/2025 12:32, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 3/6/25 11:15, Maciej S. Szmigiero
On 06/03/2025 12:32, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 3/6/25 11:15, Maciej S. Szmigiero wrote:
On 6.03.2025 07:47, Avihai Horon wrote:
On 05/03/2025 0:03, Maciej S. Szmigiero wrote:
External email: Use caution opening links or
On 05/03/2025 19:45, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 3/5/25 10:29, Cédric Le Goater wrote:
Hello,
On 3/4/25 23:03, Maciej S. Szmigiero wrote:
From: "Maciej S. Szmigiero"
This is an updated v6 patch series of the v5 series located here:
On 05/03/2025 11:35, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 3/5/25 10:33, Avihai Horon wrote:
On 05/03/2025 11:29, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
Hello,
On 3/4/25 23:03, Maciej S. Szmigiero
On 05/03/2025 11:29, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
Hello,
On 3/4/25 23:03, Maciej S. Szmigiero wrote:
From: "Maciej S. Szmigiero"
This is an updated v6 patch series of the v5 series located here:
https://lore.kernel.org/qemu-devel/cover.1
On 04/03/2025 0:16, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
On 2.03.2025 15:15, Avihai Horon wrote:
On 19/02/2025 22:34, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
On 04/03/2025 0:17, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
On 2.03.2025 15:48, Avihai Horon wrote:
On 19/02/2025 22:34, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero&qu
On 02/03/2025 16:59, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
On 2.03.2025 15:54, Maciej S. Szmigiero wrote:
On 2.03.2025 15:53, Avihai Horon wrote:
On 19/02/2025 22:34, Maciej S. Szmigiero wrote:
External email: Use caution opening links or
On 19/02/2025 22:34, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
Allow capping the maximum count of in-flight VFIO device state buffers
queued at the destination, otherwise a malicious QEMU source could
theoretically cause
On 19/02/2025 22:34, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
This property allows configuring at runtime whether to transfer the
IIUC, in this patch it's not configurable at runtime, so let's drop "at
runtime".
pa
On 19/02/2025 22:34, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
Implement the multifd device state transfer via additional per-device
thread inside save_live_complete_precopy_thread handler.
Switch between doing the data
On 19/02/2025 22:34, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
Load device config received via multifd using the existing machinery
behind vfio_load_device_config_state().
Also, make sure to process the relevant main mig
On 26/02/2025 15:49, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 2/19/25 21:34, Maciej S. Szmigiero wrote:
From: "Maciej S. Szmigiero"
Since it's important to finish loading device state transferred via the
main migration channel (via save_live_itera
On 19/02/2025 22:34, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
Maybe add a sentence talking about the load thread itself first? E.g.:
Add a thread which loads the VFIO device state buffers that were
received and via mu
On 19/02/2025 22:34, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
The multifd received data needs to be reassembled since device state
packets sent via different multifd channels can arrive out-of-order.
Therefore, each VFI
On 19/02/2025 22:34, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
Add VFIOStateBuffer(s) types and the associated methods.
These store received device state buffers and config state waiting to get
loaded into the device.
S
On 19/02/2025 22:33, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
A new function multifd_queue_device_state() is provided for device to queue
its state for transmission via a multifd channel.
Reviewed-by: Peter Xu
Signed-o
Hi Maciej,
Sorry for the long delay, I have been busy with other tasks.
I got some small comments for the series.
On 19/02/2025 22:33, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
Add a basic support for receiving device sta
Add a flag to VFIOContainerBase that indicates whether dirty tracking
has been started for the container or not.
This will be used in the following patches to allow dirty page syncs
only if dirty tracking has been started.
Signed-off-by: Avihai Horon
Reviewed-by: Joao Martins
---
include/hw
calc-dirty-rate. (Joao)
* Added comment to VFIODevice->dirty_tracking that states it's protected
by BQL.
* Added R-b/A-b tags.
Thanks.
[1]
https://lore.kernel.org/qemu-devel/20241024213056.1395400-1-pet...@redhat.com/
[2]
https://lore.kernel.org/qemu-devel/20241216094638.26406-1-avih...@nvid
tus, add a comment that states how it's protected.
Signed-off-by: Avihai Horon
---
include/hw/vfio/vfio-common.h | 2 +-
hw/vfio/common.c | 17 -
2 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/
.
To accommodate this, and since the same functionality can be achieved
with migration_is_running(), use it instead of migration_is_active().
Signed-off-by: Avihai Horon
Reviewed-by: Hyman Huang
---
system/dirtylimit.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/system
After being removed from VFIO and dirty limit, migration_is_active() no
longer has any users outside the migration subsystem, and in fact, it's
only used in migration.c.
Unexport it and also relocate it so it can be made static.
Signed-off-by: Avihai Horon
Reviewed-by: Cédric Le Goater
After being removed from VFIO, migration_is_device() no longer has any
users. Drop it.
Signed-off-by: Avihai Horon
Reviewed-by: Cédric Le Goater
Acked-by: Peter Xu
---
include/migration/misc.h | 1 -
migration/migration.c| 7 ---
2 files changed, 8 deletions(-)
diff --git a/include
ned-off-by: Avihai Horon
---
include/hw/vfio/vfio-common.h | 4 ++--
hw/vfio/common.c | 40 +++
hw/vfio/container.c | 2 +-
3 files changed, 11 insertions(+), 35 deletions(-)
diff --git a/include/hw/vfio/vfio-common.h b/include/hw/vfio/vfi
code clearer as there are already several
helpers with similar names.
Signed-off-by: Avihai Horon
Reviewed-by: Joao Martins
---
hw/vfio/common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index 2831f674ff..d113d8f4f5 100644
--- a
On 17/12/2024 5:01, Yong Huang wrote:
*External email: Use caution opening links or attachments*
On Mon, Dec 16, 2024 at 5:47 PM Avihai Horon wrote:
vcpu_dirty_rate_stat_collect() uses migration_is_active() to detect
whether migration is running or not, in order to get the
On 16/12/2024 23:43, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 12/16/24 10:46, Avihai Horon wrote:
Hello,
This follows up on Peter's series [1] to simplify migration status API
to a single migration_is_running() function.
Peter's serie
On 16/12/2024 17:58, Joao Martins wrote:
External email: Use caution opening links or attachments
On 16/12/2024 14:55, Avihai Horon wrote:
On 16/12/2024 14:45, Joao Martins wrote:
External email: Use caution opening links or attachments
On 16/12/2024 09:46, Avihai Horon wrote:
During
On 16/12/2024 21:53, Joao Martins wrote:
External email: Use caution opening links or attachments
On 16/12/2024 16:05, Joao Martins wrote:
On 16/12/2024 15:52, Joao Martins wrote:
On 16/12/2024 14:52, Avihai Horon wrote:
On 16/12/2024 14:32, Joao Martins wrote:
External email: Use
On 16/12/2024 14:57, Joao Martins wrote:
External email: Use caution opening links or attachments
On 16/12/2024 09:46, Avihai Horon wrote:
There is no need for vfio_dma_unmap_dirty_sync_needed(), as it simply
calls vfio_devices_all_dirty_tracking_started().
Drop
On 16/12/2024 14:45, Joao Martins wrote:
External email: Use caution opening links or attachments
On 16/12/2024 09:46, Avihai Horon wrote:
During DMA unmap with vIOMMU, vfio_devices_all_running_and_mig_active()
is used to check whether a dirty page log sync of the unmapped pages is
required
On 16/12/2024 14:32, Joao Martins wrote:
External email: Use caution opening links or attachments
On 16/12/2024 09:46, Avihai Horon wrote:
During dirty page log sync, vfio_devices_all_dirty_tracking() is used to
check if dirty tracking has been started in order to avoid errors. The
current
On 16/12/2024 14:15, Joao Martins wrote:
External email: Use caution opening links or attachments
On 16/12/2024 09:46, Avihai Horon wrote:
Add a flag to VFIOContainerBase that indicates whether dirty tracking
has been started for the container or not.
This will be used in the following
On 16/12/2024 14:00, Joao Martins wrote:
External email: Use caution opening links or attachments
On 16/12/2024 09:46, Avihai Horon wrote:
Hello,
This follows up on Peter's series [1] to simplify migration status API
to a single migration_is_running() function.
Peter's serie
Add a flag to VFIOContainerBase that indicates whether dirty tracking
has been started for the container or not.
This will be used in the following patches to allow dirty page syncs
only if dirty tracking has been started.
Signed-off-by: Avihai Horon
---
include/hw/vfio/vfio-container-base.h
41024213056.1395400-1-pet...@redhat.com/
Avihai Horon (9):
vfio/container: Add dirty tracking started flag
vfio/migration: Refactor vfio_devices_all_dirty_tracking() logic
vfio/migration: Refactor vfio_devices_all_running_and_mig_active()
logic
vfio/migration: Add vfio_devices_all_dirty_trackin
simplify the migration
status API and reduce it to a single migration_is_running() function.
To accommodate this, refactor vfio_devices_all_dirty_tracking() logic so
it won't use migration_is_active() and migration_is_device(). Instead,
use internal VFIO dirty tracking flags.
Signed-off-by: A
.
To accommodate this, and since the same functionality can be achieved
with migration_is_running(), use it instead of migration_is_active().
Signed-off-by: Avihai Horon
---
system/dirtylimit.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/system/dirtylimit.c b/system
code clearer as there are already several
helpers with similar names.
Signed-off-by: Avihai Horon
---
hw/vfio/common.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/vfio/common.c b/hw/vfio/common.c
index 6e4654218a..dd8c5c52b5 100644
--- a/hw/vfio/common.c
+++ b/hw
g the logic to check if migration is running and dirty
tracking has been started. This should be equivalent to the previous
logic because when the guest is stopped there shouldn't be DMA unmaps
coming from it. Also rename the function properly.
Signed-off-by: Avihai Horon
---
include/hw
After being removed from VFIO and dirty limit, migration_is_active() no
longer has any users outside the migration subsystem, and in fact, it's
only used in migration.c.
Unexport it and also relocate it so it can be made static.
Signed-off-by: Avihai Horon
---
include/migration/misc.h
After being removed from VFIO, migration_is_device() no longer has any
users. Drop it.
Signed-off-by: Avihai Horon
---
include/migration/misc.h | 1 -
migration/migration.c| 7 ---
2 files changed, 8 deletions(-)
diff --git a/include/migration/misc.h b/include/migration/misc.h
index
There is no need for vfio_dma_unmap_dirty_sync_needed(), as it simply
calls vfio_devices_all_dirty_tracking_started().
Drop vfio_dma_unmap_dirty_sync_needed(), export
vfio_devices_all_dirty_tracking_started() and use it instead.
Signed-off-by: Avihai Horon
---
include/hw/vfio/vfio-common.h | 3
vfio_devices_all_dirty_tracking() and vfio_dma_unmap_dirty_sync_needed()
share the same code that checks if dirty page tracking has been started.
Extract it to a common helper vfio_devices_all_dirty_tracking_started().
Signed-off-by: Avihai Horon
---
hw/vfio/common.c | 25
On 11/12/2024 1:06, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
On 9.12.2024 10:28, Avihai Horon wrote:
On 17/11/2024 21:20, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmi
On 11/12/2024 1:04, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
On 3.12.2024 16:09, Avihai Horon wrote:
On 29/11/2024 19:15, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
On 29.11.2024 15:08, Cédric Le Goater
On 11/12/2024 1:06, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
Hi Avihai,
On 9.12.2024 10:13, Avihai Horon wrote:
Hi Maciej,
On 17/11/2024 21:20, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Mac
On 17/11/2024 21:20, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
Implement the multifd device state transfer via additional per-device
thread inside save_live_complete_precopy_thread handler.
Switch between doing the data
Hi Maciej,
On 17/11/2024 21:20, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
The multifd received data needs to be reassembled since device state
packets sent via different multifd channels can arrive out-of-order.
Therefore
On 29/11/2024 19:15, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
On 29.11.2024 15:08, Cédric Le Goater wrote:
On 11/17/24 20:20, Maciej S. Szmigiero wrote:
From: "Maciej S. Szmigiero"
It's possible for load_cleanup SaveVMHandler to get called withou
On 17/11/2024 21:20, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
Since device state transfer via multifd channels requires multifd
channels with packets and is currently not compatible with multifd
compression add an approp
On 17/11/2024 21:20, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
Some drivers might want to make use of auxiliary helper threads during VM
state loading, for example to make sure that their blocking (sync) I/O
operations do
Hi Maciej,
On 17/11/2024 21:19, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
Migration code wants to manage device data sending threads in one place.
QEMU has an existing thread pool implementation, however it is limited
to
On 04/11/2024 16:00, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
On 4.11.2024 09:08, Avihai Horon wrote:
On 01/11/2024 0:17, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
Hi Avihai,
On 31.10.2024 15:21
On 01/11/2024 0:17, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
Hi Avihai,
On 31.10.2024 15:21, Avihai Horon wrote:
Hi Maciej,
On 29/10/2024 16:58, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "M
Hi Maciej,
On 29/10/2024 16:58, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
This way both the start and end points of migrating a particular VFIO
device are known.
Add also a vfio_save_iterate_empty_hit trace event so it is
On 28/10/2024 21:06, Peter Xu wrote:
External email: Use caution opening links or attachments
On Mon, Oct 28, 2024 at 07:20:27PM +0200, Avihai Horon wrote:
On 28/10/2024 18:58, Peter Xu wrote:
External email: Use caution opening links or attachments
On Mon, Oct 28, 2024 at 06:41:42PM
On 28/10/2024 18:58, Peter Xu wrote:
External email: Use caution opening links or attachments
On Mon, Oct 28, 2024 at 06:41:42PM +0200, Avihai Horon wrote:
On 28/10/2024 17:45, Peter Xu wrote:
External email: Use caution opening links or attachments
On Mon, Oct 28, 2024 at 09:43:16AM
On 28/10/2024 17:45, Peter Xu wrote:
External email: Use caution opening links or attachments
On Mon, Oct 28, 2024 at 09:43:16AM +0200, Avihai Horon wrote:
On 25/10/2024 0:30, Peter Xu wrote:
External email: Use caution opening links or attachments
We have two outside users of this API
On 25/10/2024 0:30, Peter Xu wrote:
External email: Use caution opening links or attachments
We have two outside users of this API, so it's exported.
Is it really necessary? Does it matter whether it must be
ACTIVE/POSTCOPY_ACTIVE/DEVICE? I guess no.
Actually for VFIO it does matter, bec
;s working now. We can move to other things (e.g. RCU) whenever
necessary in the future but it's an overkill if we have BQL anyway in
most/all existing callers.
When at it, update some comments, e.g. migrate_announce_params() is
exported from options.c now.
Cc: Cédric Le Goater
Cc: Avihai Hor
On 22/10/2024 16:24, Cédric Le Goater wrote:
External email: Use caution opening links or attachments
On 10/22/24 11:38, Avihai Horon wrote:
On 21/10/2024 19:54, Peter Xu wrote:
External email: Use caution opening links or attachments
On Mon, Oct 21, 2024 at 06:43:13PM +0200, Cédric Le
On 21/10/2024 19:54, Peter Xu wrote:
External email: Use caution opening links or attachments
On Mon, Oct 21, 2024 at 06:43:13PM +0200, Cédric Le Goater wrote:
Hello,
IIUC the migration thread should always see valid migration object, as it
takes one refcount at the entrance of migration_t
This small series contains some bug fixes and cleanups.
Reviews are welcome.
Thanks.
Avihai Horon (3):
vfio/migration: Report only stop-copy size in
vfio_state_pending_exact()
vfio/migration: Refactor vfio_vmstate_change/_prepare() error
reporting
vfio/migration: Change trace
ertion `mutex->initialized' failed.
Fix this by not setting migration file error in the shut down flow.
Fixes: 20c64c8a51a4 ("migration: migration_file_set_error")
Signed-off-by: Avihai Horon
---
hw/vfio/migration.c | 31 +--
1 file changed, 21 ins
above, current implementation is wrong -- it reports
extra overlapping data because pre-copy size is already contained in
stop-copy size. Fix it by reporting only stop-copy size.
Fixes: eda7362af959 ("vfio/migration: Add VFIO migration pre-copy support")
Signed-off-by: Avihai Horon
--
events.
Signed-off-by: Avihai Horon
---
hw/vfio/trace-events | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/hw/vfio/trace-events b/hw/vfio/trace-events
index c475c273fd..29789e8d27 100644
--- a/hw/vfio/trace-events
+++ b/hw/vfio/trace-events
@@ -151,7 +151,7
On 09/09/2024 21:07, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
On 9.09.2024 13:41, Avihai Horon wrote:
On 27/08/2024 20:54, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmi
On 09/09/2024 21:06, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
On 9.09.2024 10:55, Avihai Horon wrote:
On 27/08/2024 20:54, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero&q
On 09/09/2024 21:05, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
On 5.09.2024 18:47, Avihai Horon wrote:
On 27/08/2024 20:54, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero&quo
On 09/09/2024 18:11, Peter Xu wrote:
External email: Use caution opening links or attachments
On Mon, Sep 09, 2024 at 03:52:39PM +0300, Avihai Horon wrote:
On 05/09/2024 21:31, Peter Xu wrote:
External email: Use caution opening links or attachments
On Thu, Sep 05, 2024 at 07:45:43PM
On 09/09/2024 21:04, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
On 5.09.2024 15:08, Avihai Horon wrote:
Hi Maciej,
On 27/08/2024 20:54, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmi
On 05/09/2024 21:31, Peter Xu wrote:
External email: Use caution opening links or attachments
On Thu, Sep 05, 2024 at 07:45:43PM +0300, Avihai Horon wrote:
Does it also mean then that the currently reported stop-size - precopy-size
will be very close to the constant non-iterable data size
On 27/08/2024 20:54, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
Implement the multifd device state transfer via additional per-device
thread inside save_live_complete_precopy_thread handler.
Switch between doing the data
On 27/08/2024 20:54, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
The multifd received data needs to be reassembled since device state
packets sent via different multifd channels can arrive out-of-order.
Therefore, each VFI
On 27/08/2024 20:54, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
Add a basic support for receiving device state via multifd channels -
channels that are shared with RAM transfers.
To differentiate between a device state an
On 05/09/2024 19:23, Peter Xu wrote:
External email: Use caution opening links or attachments
On Thu, Sep 05, 2024 at 07:07:28PM +0300, Avihai Horon wrote:
So I wonder why stop-size can change from a driver, and whether that can be
reported in a more predictable fashion. Otherwise I see
On 05/09/2024 18:17, Peter Xu wrote:
External email: Use caution opening links or attachments
On Thu, Sep 05, 2024 at 02:41:09PM +0300, Avihai Horon wrote:
On 04/09/2024 19:16, Peter Xu wrote:
External email: Use caution opening links or attachments
On Wed, Sep 04, 2024 at 06:41:03PM
On 27/08/2024 20:54, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
load_finish SaveVMHandler allows migration code to poll whether
a device-specific asynchronous device state loading operation had finished.
In order to avoid
On 27/08/2024 20:54, Maciej S. Szmigiero wrote:
External email: Use caution opening links or attachments
From: "Maciej S. Szmigiero"
qemu_loadvm_load_state_buffer() and its load_state_buffer
SaveVMHandler allow providing device state buffer to explicitly
specified device via its idstr and i
1 - 100 of 676 matches
Mail list logo
