Hi Daniel,
Thank you so much for the review.
On Thu, Jul 17, 2025 at 05:32:14PM +0100, Daniel P. Berrangé wrote:
> On Thu, Jul 17, 2025 at 06:07:25AM +0530, Arun Menon wrote:
> > This is an incremental step in converting vmstate loading
> > code to report error via Error obj
On Thu, Jul 17, 2025 at 12:26:16PM +0900, Akihiko Odaki wrote:
> On 2025/07/17 9:37, Arun Menon wrote:
> > This is an incremental step in converting vmstate loading
> > code to report error via Error objects instead of directly
> > printing it to console/monitor.
&
Hi Akihiko,
Thanks for the review.
On Thu, Jul 17, 2025 at 12:34:21PM +0900, Akihiko Odaki wrote:
> On 2025/07/17 9:37, Arun Menon wrote:
> > This is an incremental step in converting vmstate loading
> > code to report error via Error objects instead of directly
> > p
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that qemu_load_device_state() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration/colo.c | 5
qemu will not display
any errors before going into the postcopy pause state.
Signed-off-by: Arun Menon
---
migration/migration.c | 2 +-
migration/savevm.c| 10 --
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that loadvm_postcopy_handle_listen() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that loadvm_handle_cmd_packaged() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration/savevm.c
exclusion from their counterparts,
to prevent conflicts during the transition.
- New impls should preferentally use 'errp' variants of
these methods, and existing impls incrementally converted.
The variants without 'errp' are intended to be removed
once all usage is c
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that loadvm_handle_recv_bitmap() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration/savevm.c
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that qemu_loadvm_section_part_end() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that qemu_loadvm_state() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration/migration.c | 5
explicitly.
Signed-off-by: Arun Menon
---
migration/colo.c | 5 +++--
migration/savevm.c | 23 +--
migration/savevm.h | 3 ++-
3 files changed, 18 insertions(+), 13 deletions(-)
diff --git a/migration/colo.c b/migration/colo.c
index
e0f713c837f5da25d67afbd02ceb6c54024ca3af
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that ram_postcopy_incoming_init() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration/postcopy
the TPM backend.
- It can then be retrieved using QMP command:
{"execute" : "query-migrate"}
Buglink: https://issues.redhat.com/browse/RHEL-82826
Reviewed-by: Stefan Berger
Signed-off-by: Arun Menon
---
backends/tpm/tpm_emulator.c | 39 -
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
Signed-off-by: Arun Menon
---
migration/savevm.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/migration
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that loadvm_process_enable_colo() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
include/migration
This is an incremental step in converting vmstate loading code to report
error via Error objects instead of directly printing it to console/monitor.
It is ensured that loadvm_postcopy_handle_switchover_start() must report
an error in errp, in case of failure.
Signed-off-by: Arun Menon
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that loadvm_postcopy_ram_handle_discard() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that loadvm_process_command() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration/savevm.c
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that loadvm_postcopy_handle_advise() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that loadvm_postcopy_handle_run() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration/savevm.c
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that qemu_loadvm_section_start_full() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that vmstate_load_state() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
hw/display/virtio-gpu.c
previously returned an integer now capture
errors in the Error object, enabling other modules to adopt the
post_load_errp hook in the future.
One such change previously attempted:
https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg01727.html
Resolves: https://issues.redhat.com/browse/RHEL-82
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that vmstate_load() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration/savevm.c | 8
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that qemu_loadvm_state_header() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration/savevm.c
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that vmstate_subsection_load() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration/vmstate.c
-0300, Fabiano Rosas wrote:
> Arun Menon writes:
>
> > Hello,
> >
> > Currently, when a migration of a VM with an encrypted vTPM
> > fails on the destination host (e.g., due to a mismatch in secret values),
> > the error message displayed on the source host is g
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that loadvm_postcopy_handle_listen() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that loadvm_postcopy_handle_advise() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration
exclusion from their counterparts,
to prevent conflicts during the transition.
- New impls should preferentally use 'errp' variants of
these methods, and existing impls incrementally converted.
The variants without 'errp' are intended to be removed
once all usage is c
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that loadvm_handle_cmd_packaged() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration/savevm.c
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that loadvm_handle_recv_bitmap() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration/savevm.c
the TPM backend.
- It can then be retrieved using QMP command:
{"execute" : "query-migrate"}
Buglink: https://issues.redhat.com/browse/RHEL-82826
Reviewed-by: Stefan Berger
Signed-off-by: Arun Menon
---
backends/tpm/tpm_emulator.c | 39 -
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that vmstate_load() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration/savevm.c | 8
explicitly.
Signed-off-by: Arun Menon
---
migration/colo.c | 5 +++--
migration/savevm.c | 23 +--
migration/savevm.h | 3 ++-
3 files changed, 18 insertions(+), 13 deletions(-)
diff --git a/migration/colo.c b/migration/colo.c
index
e0f713c837f5da25d67afbd02ceb6c54024ca3af
qemu will not display
any errors before going into the postcopy pause state.
Signed-off-by: Arun Menon
---
migration/migration.c | 2 +-
migration/savevm.c| 10 --
2 files changed, 9 insertions(+), 3 deletions(-)
diff --git a/migration/migration.c b/migration/migration.c
index
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that qemu_loadvm_section_start_full() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that loadvm_postcopy_handle_run() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration/savevm.c
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
Signed-off-by: Arun Menon
---
migration/savevm.c | 14 --
1 file changed, 4 insertions(+), 10 deletions(-)
diff --git a/migration
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that loadvm_process_command() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration/savevm.c
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that vmstate_subsection_load() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration/vmstate.c
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that ram_postcopy_incoming_init() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration/postcopy
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that qemu_loadvm_section_part_end() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that qemu_loadvm_state() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration/migration.c | 5
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that qemu_load_device_state() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration/colo.c | 5
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that loadvm_process_enable_colo() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
include/migration
This is an incremental step in converting vmstate loading code to report
error via Error objects instead of directly printing it to console/monitor.
It is ensured that loadvm_postcopy_handle_switchover_start() must report
an error in errp, in case of failure.
Signed-off-by: Arun Menon
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that vmstate_load_state() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
hw/display/virtio-gpu.c
previously returned an integer now capture
errors in the Error object, enabling other modules to adopt the
post_load_errp hook in the future.
One such change previously attempted:
https://lists.gnu.org/archive/html/qemu-devel/2021-02/msg01727.html
Resolves: https://issues.redhat.com/browse/RHEL-82
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that loadvm_postcopy_ram_handle_discard() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration
This is an incremental step in converting vmstate loading
code to report error via Error objects instead of directly
printing it to console/monitor.
It is ensured that qemu_loadvm_state_header() must report an error
in errp, in case of failure.
Signed-off-by: Arun Menon
---
migration/savevm.c
Hi Markus,
Thanks for the review.
On Wed, Jul 02, 2025 at 03:01:51PM +0200, Markus Armbruster wrote:
> Arun Menon writes:
>
> > - This is an incremental step in converting vmstate loading
> > code to report errors.
> > - Minimal changes to the signature a
Hi Daniel,
Thanks for the review.
On Wed, Jul 02, 2025 at 01:08:51PM +0100, Daniel P. Berrangé wrote:
> On Wed, Jul 02, 2025 at 05:06:50PM +0530, Arun Menon wrote:
> > - This is an incremental step in converting vmstate loading
> > code to report errors.
> > - Minimal cha
Hi Marc-André,
Thank you for the review.
On Tue, Jul 01, 2025 at 04:21:23PM +0400, Marc-André Lureau wrote:
> Hi
>
> On Tue, Jun 24, 2025 at 4:26 PM Arun Menon wrote:
> >
> > - Introduce a new post_load_with_error() hook that will
> > take in the Error object as a
erger
Signed-off-by: Arun Menon
---
backends/tpm/tpm_emulator.c | 39 ---
1 file changed, 20 insertions(+), 19 deletions(-)
diff --git a/backends/tpm/tpm_emulator.c b/backends/tpm/tpm_emulator.c
index
4a234ab2c0b19b2604bf
discussed here : https://issues.redhat.com/browse/RHEL-82826
Signed-off-by: Arun Menon
---
include/migration/vmstate.h | 1 +
migration/vmstate.c | 4 +++-
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/include/migration/vmstate.h b/include/migration/vmstate.h
index
ries does not necessarily have to be applied in 1 go. Each patch
can be compiled and tested separately.
Resolves: https://issues.redhat.com/browse/RHEL-82826
Signed-off-by: Arun Menon
---
Changes in v3:
- Split the 2nd patch into 2. Introducing post_load_with_error() hook
has been separated fro
: Arun Menon
---
hw/display/virtio-gpu.c | 2 +-
hw/pci/pci.c| 2 +-
hw/s390x/virtio-ccw.c | 2 +-
hw/scsi/spapr_vscsi.c | 2 +-
hw/vfio/pci.c | 2 +-
hw/virtio/virtio-mmio.c | 2 +-
hw/virtio/virtio-pci.c | 2 +-
hw/virtio
Wed, Jun 25, 2025 at 09:15:53AM -0400, Peter Xu wrote:
> On Wed, Jun 25, 2025 at 05:24:10PM +0530, Arun Menon wrote:
> > Hi Peter,
>
> Hi, Arun,
>
> [...]
>
> > > > static void vmstate_save_old_style(QEMUFile *f, SaveStateEntry *se,
&g
: Arun Menon
---
hw/display/virtio-gpu.c | 2 +-
hw/pci/pci.c| 2 +-
hw/s390x/virtio-ccw.c | 2 +-
hw/scsi/spapr_vscsi.c | 2 +-
hw/vfio/pci.c | 2 +-
hw/virtio/virtio-mmio.c | 2 +-
hw/virtio/virtio-pci.c | 2 +-
hw/virtio
om/browse/RHEL-82826
Reviewed-by: Stefan Berger
Signed-off-by: Arun Menon
---
backends/tpm/tpm_emulator.c | 39 ---
include/migration/vmstate.h | 1 +
migration/vmstate.c | 4 +++-
3 files changed, 24 insertions(+), 20 deletions(-)
diff --git a/backend
he series does not necessarily have to be applied in 1 go. Each patch
can be compiled and tested separately.
Resolves: https://issues.redhat.com/browse/RHEL-82826
Signed-off-by: Arun Menon
---
Changes in v2:
- Combine the first two changes into one, focusing on passing the
Error object (errp)
Hi Peter,
Thank you so much for the review.
I shall squash patches 1 and 2 and add error_prepend()
where I missed them; also adding a null check.
On Tue, Jun 24, 2025 at 09:46:48AM -0400, Peter Xu wrote:
> Hi, Arun,
>
> On Tue, Jun 24, 2025 at 05:53:04PM +0530, Arun Menon wrote:
>
he series does not necessarily have to be applied in 1 go. Each patch
can be compiled and tested separately.
Resolves: https://issues.redhat.com/browse/RHEL-82826
Signed-off-by: Arun Menon
---
Arun Menon (3):
migration: Pass error object to report it to the caller
migration: Use erro
- This is an incremental step in converting vmstate
loading code to report error via Error object.
- error_report() has been replaced with error_setg();
and in places where error has been already set,
error_prepend() is used to not lose information.
Signed-off-by: Arun Menon
---
migration
()
- qemu_loadvm_section_start_full()
- qemu_loadvm_section_part_end()
- qemu_loadvm_state_header()
- qemu_loadvm_state_main()
Signed-off-by: Arun Menon
---
hw/display/virtio-gpu.c | 2 +-
hw/pci/pci.c| 2 +-
hw/s390x/virtio-ccw.c | 2 +-
hw/scsi/spapr_vscsi.c
om/browse/RHEL-82826
Signed-off-by: Arun Menon
---
backends/tpm/tpm_emulator.c | 39 ---
include/migration/vmstate.h | 1 +
migration/vmstate.c | 4 +++-
3 files changed, 24 insertions(+), 20 deletions(-)
diff --git a/backends/tpm/tpm_emula
68 matches
Mail list logo
