Re: [Qemu-devel] [Qemu-trivial] [PATCH] vmdk: Fix cylinders number during convert

2014-10-31 Thread Arthur Gautier
On Thu, Oct 30, 2014 at 06:27:20PM +0800, Fam Zheng wrote: > On Thu, 10/30 10:09, Arthur Gautier wrote: > > On Wed, Oct 29, 2014 at 09:28:52AM +0800, Fam Zheng wrote: > > > On Tue, 10/28 16:00, Stefan Hajnoczi wrote: > > > > On Thu, Oct 23, 2014 at 10:03:25AM

Re: [Qemu-devel] [Qemu-trivial] [PATCH] vmdk: Fix cylinders number during convert

2014-10-30 Thread Arthur Gautier
On Wed, Oct 29, 2014 at 09:28:52AM +0800, Fam Zheng wrote: > On Tue, 10/28 16:00, Stefan Hajnoczi wrote: > > On Thu, Oct 23, 2014 at 10:03:25AM +0200, Markus Armbruster wrote: > > > Michael Tokarev writes: > > > > > > > On 10/22/2014 05:25 PM, Arthur Gau

[Qemu-devel] [PATCH] vmdk: Fix cylinders number during convert

2014-10-22 Thread Arthur Gautier
We can not rely on int cast to get a correct number of cylinders. The cylinders information was wrong in 49.% of cases. This ensures the cylinders always gets the ceiling value. Reviewed-by: William Dauchy Signed-off-by: Arthur Gautier --- block/vmdk.c | 4 +-- tests/qemu