[PATCH v2 0/2] FM-API Physical switch command set support

2025-07-14 Thread Arpit Kumar
/Finding: The assert-deassert and reset PPB operation fails when downstream ports are connected to a CXLType3 device as it would mean device reset instead of switch port reset. The patches are generated against the Johnathan's tree https://gitlab.com/jic23/qemu.git and branch cxl-2025-03-20. Si

[PATCH v2 1/2] hw/cxl: Refactored Identify Switch Device & Get Physical Port State

2025-07-14 Thread Arpit Kumar
-Storing physical ports info during enumeration. -Refactored changes using physical ports info for Identify Switch Device (Opcode 5100h) & Get Physical Port State (Opcode 5101h) physical switch FM-API command set. Signed-off-by: Arpit Kumar --- hw/cxl/cxl-mailbox-utils.c|

[PATCH v2 2/2] hw/cxl: Add Physical Port Control (Opcode 5102h)

2025-07-14 Thread Arpit Kumar
-added assert-deassert PERST implementation for physical ports (both USP and DSP's). -assert PERST involves bg operation for holding 100ms. -reset PPB implementation for physical ports. Signed-off-by: Arpit Kumar --- hw/cxl/cxl-mailbox-utils.c

Re: [PATCH 3/3] hw/cxl: Add Physical Port Control (Opcode 5102h)

2025-06-17 Thread Arpit Kumar
On 10/06/25 03:45PM, Jonathan Cameron wrote: On Mon, 2 Jun 2025 19:29:42 +0530 Arpit Kumar wrote: Very interesting to see support for this. It will enable a load of additional test cases. added assert-deassert PERST implementation, reset PPB for physical port. Added okay Please also

Re: [PATCH 1/3] hw/cxl: Storing physical ports info during enumeration

2025-06-17 Thread Arpit Kumar
On 10/06/25 03:21PM, Jonathan Cameron wrote: On Mon, 2 Jun 2025 19:29:40 +0530 Arpit Kumar wrote: Physical ports info is stored for both mailbox cci & mctp based cci type as per spec CXL r3.2 Table 8-230: Physical Switch Signed-off-by: Arpit Kumar Hi Arpit, Sorry for slow response. I

Re: [PATCH 2/3] hw/cxl: Simplified Identify Switch Device & Get Physical Port State

2025-06-17 Thread Arpit Kumar
On 10/06/25 03:29PM, Jonathan Cameron wrote: On Mon, 2 Jun 2025 19:29:41 +0530 Arpit Kumar wrote: Modified Identify Switch Device (Opcode 5100h) & Get Physical Port State(Opcode 5101h) using physical ports info stored during enumeration Signed-off-by: Arpit Kumar A few additional comm

[PATCH 3/3] hw/cxl: Add Physical Port Control (Opcode 5102h)

2025-06-02 Thread Arpit Kumar
added assert-deassert PERST implementation, reset PPB for physical port. Signed-off-by: Arpit Kumar --- hw/cxl/cxl-mailbox-utils.c | 128 include/hw/cxl/cxl_device.h | 8 +++ 2 files changed, 136 insertions(+) diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw

[PATCH 2/3] hw/cxl: Simplified Identify Switch Device & Get Physical Port State

2025-06-02 Thread Arpit Kumar
Modified Identify Switch Device (Opcode 5100h) & Get Physical Port State(Opcode 5101h) using physical ports info stored during enumeration Signed-off-by: Arpit Kumar --- hw/cxl/cxl-mailbox-utils.c | 133 +++-- 1 file changed, 24 insertions(+), 109 delet

[PATCH 1/3] hw/cxl: Storing physical ports info during enumeration

2025-06-02 Thread Arpit Kumar
Physical ports info is stored for both mailbox cci & mctp based cci type as per spec CXL r3.2 Table 8-230: Physical Switch Signed-off-by: Arpit Kumar --- hw/cxl/cxl-mailbox-utils.c | 166 include/hw/cxl/cxl_device.h | 28 ++ 2 files changed,

[PATCH 0/3] FM-API Physical switch command set update

2025-06-02 Thread Arpit Kumar
u.git and branch cxl-2025-03-20. Signed-off-by: Arpit Kumar Arpit Kumar (3): hw/cxl: Storing physical ports info during enumeration hw/cxl: Simplified Identify Switch Device & Get Physical Port State hw/cxl: Add Physical Port Control (Opcode 5102h) hw/cxl/cxl-mailbox-u

Re: [PATCH qemu 7/8] hw/cxl/cxl-mailbox-utils: Added support for Get Log Capabilities (Opcode 0402h)

2025-06-01 Thread Arpit Kumar
On 28/05/25 01:38PM, Jonathan Cameron wrote: On Wed, 28 May 2025 13:31:06 +0100 Jonathan Cameron wrote: On Fri, 16 May 2025 19:12:45 +0530 Arpit Kumar wrote: > On 12/05/25 05:40PM, Jonathan Cameron wrote: > >On Mon, 12 May 2025 09:37:07 -0400 > >"Michael S. Tsirkin"

Re: [PATCH qemu 7/8] hw/cxl/cxl-mailbox-utils: Added support for Get Log Capabilities (Opcode 0402h)

2025-05-16 Thread Arpit Kumar
On 12/05/25 05:40PM, Jonathan Cameron wrote: On Mon, 12 May 2025 09:37:07 -0400 "Michael S. Tsirkin" wrote: On Mon, May 12, 2025 at 04:42:41AM -0400, Michael S. Tsirkin wrote: > On Wed, Mar 05, 2025 at 09:24:58AM +, Jonathan Cameron wrote: > > From: Arpit Kumar &

Re: [PATCH v2 0/3] CXL CCI Log Commands implementation

2025-02-24 Thread Arpit Kumar
On 20/02/25 04:08PM, Jonathan Cameron wrote: On Tue, 18 Feb 2025 14:27:28 +0530 Arpit Kumar wrote: CXL CCI log commands implmented as per CXL Specification 3.2 8.2.10.5 1) get_log_capabilities (Opcode 0402h) 2) clear_log (Opcode 0403h) 3) populate_log (Opcode 0404h) This v2 patch addresses

[PATCH v2 3/3] hw/cxl/cxl-mailbox-utils.c: Added support for Populate Log (Opcode 0404h)

2025-02-18 Thread Arpit Kumar
CXL spec 3.2 section 8.2.10.5.5 describes populate log. It populates the contents of the specified log and can run as a background operation. Signed-off-by: Arpit Kumar --- hw/cxl/cxl-mailbox-utils.c | 28 1 file changed, 28 insertions(+) diff --git a/hw/cxl/cxl

[PATCH v2 0/3] CXL CCI Log Commands implementation

2025-02-18 Thread Arpit Kumar
support of clear & populate log command for command effect log The patches are generated against the Johnathan's tree https://gitlab.com/jic23/qemu.git and branch cxl-2024-11-27. Arpit Kumar (3): hw/cxl/cxl-mailbox-utils.c: Added support for Get Log Capabilities (Opcode 0402h) h

[PATCH v2 2/3] hw/cxl/cxl-mailbox-utils.c: Added support for Clear Log (Opcode 0403h)

2025-02-18 Thread Arpit Kumar
CXL spec 3.2 section 8.2.10.5.4 describes clear log. It clears the content of the specified log. Signed-off-by: Arpit Kumar --- hw/cxl/cxl-mailbox-utils.c | 27 +++ 1 file changed, 27 insertions(+) diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c

[PATCH v2 1/3] hw/cxl/cxl-mailbox-utils.c: Added support for Get Log Capabilities (Opcode 0402h)

2025-02-18 Thread Arpit Kumar
CXL spec 3.2 section 8.2.10.5.3 describes Get Log Capabilities. It provides log capabilities supported by specified log. Signed-off-by: Arpit Kumar --- hw/cxl/cxl-mailbox-utils.c | 45 include/hw/cxl/cxl_device.h | 20 include/hw/cxl

Re: [PATCH 3/3] hw/cxl/cxl-mailbox-utils.c: Added support for Populate Log (Opcode 0404h) as background operation

2025-02-12 Thread Arpit Kumar
On 04/02/25 10:58AM, Jonathan Cameron wrote: On Mon, 3 Feb 2025 11:29:50 +0530 Arpit Kumar wrote: Signed-off-by: Arpit Kumar Reviewed-by: Alok Rathore Reviewed-by: Krishna Kanth Reddy Likewise, the CEL isn't a dynamic thing. Asking to populate it makes little sense so th

Re: [PATCH 1/3] hw/cxl/cxl-mailbox-utils.c: Added support for Get Log Capabilities (Opcode 0402h)

2025-02-12 Thread Arpit Kumar
On 04/02/25 10:28AM, Jonathan Cameron wrote: On Mon, 3 Feb 2025 11:29:48 +0530 Arpit Kumar wrote: Please add some descriptive teext here. Sure, will append here in V2 patch. Signed-off-by: Arpit Kumar Reviewed-by: Alok Rathore Reviewed-by: Krishna Kanth Reddy Hi Arpit, Whilst it is

Re: [PATCH 2/3] hw/cxl/cxl-mailbox-utils.c: Added support for Clear Log (Opcode 0403h)

2025-02-12 Thread Arpit Kumar
On 04/02/25 10:53AM, Jonathan Cameron wrote: On Mon, 3 Feb 2025 11:29:49 +0530 Arpit Kumar wrote: Add some description of what is being added here. Key issue in here is that clearing the CEL doesn't make sense. It is a description of what the device supports, there is no state to clear

[PATCH 2/3] hw/cxl/cxl-mailbox-utils.c: Added support for Clear Log (Opcode 0403h)

2025-02-03 Thread Arpit Kumar
Signed-off-by: Arpit Kumar Reviewed-by: Alok Rathore Reviewed-by: Krishna Kanth Reddy --- hw/cxl/cxl-mailbox-utils.c | 36 1 file changed, 36 insertions(+) diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox-utils.c index 3d66a425a9..5fd7f850c4

[PATCH 3/3] hw/cxl/cxl-mailbox-utils.c: Added support for Populate Log (Opcode 0404h) as background operation

2025-02-03 Thread Arpit Kumar
Signed-off-by: Arpit Kumar Reviewed-by: Alok Rathore Reviewed-by: Krishna Kanth Reddy --- hw/cxl/cxl-mailbox-utils.c | 95 + include/hw/cxl/cxl_device.h | 2 + 2 files changed, 97 insertions(+) diff --git a/hw/cxl/cxl-mailbox-utils.c b/hw/cxl/cxl-mailbox

[PATCH 0/3] CXL CCI Log Commands implementation

2025-02-03 Thread Arpit Kumar
d-off-by: Arpit Kumar Reviewed-by: Alok Rathore Reviewed-by: Krishna Kanth Reddy Arpit Kumar (3): hw/cxl/cxl-mailbox-utils.c: Added support for Get Log Capabilities (Opcode 0402h) hw/cxl/cxl-mailbox-utils.c: Added support for Clear Log (Opcode 0403h) hw/cxl/cxl-mailbox-utils.c: Added su

[PATCH 1/3] hw/cxl/cxl-mailbox-utils.c: Added support for Get Log Capabilities (Opcode 0402h)

2025-02-03 Thread Arpit Kumar
Signed-off-by: Arpit Kumar Reviewed-by: Alok Rathore Reviewed-by: Krishna Kanth Reddy --- hw/cxl/cxl-mailbox-utils.c | 55 include/hw/cxl/cxl_device.h | 31 include/hw/cxl/cxl_mailbox.h | 5 3 files changed, 91 insertions