Sure
On 6/27/25 11:12 AM, Matthew Rosato wrote:
AFAICT this portion of the handler including mutex should be moved out of ap.c
into chsc_sei_nt0_get_event(). When vfio_ap is not in use, we can't call into
it. Can't you also build without VFIO_AP? I didn't try it but that sure seems
like it
such circumstance. Also added the
following to hw/s390x/meson.build if CONFIG_VFIO_AP is
false, it will use the stub file.
Signed-off-by: Rorie Reyes
Reviewed-by: Anthony Krowiak
Reviewed-by: Cédric Le Goater
FYI, this patch (or some part of this series) breaks hotplug for PCI devices on
s390
On 6/6/25 2:37 PM, Rorie Reyes wrote:
These functions can be invoked by the function that handles interception
of the CHSC SEI instruction for requests indicating the accessibility of
one or more adjunct processors has changed.
Signed-off-by: Rorie Reyes
Reviewed-by: Anthony Krowiak
-off-by: Rorie Reyes
See comment below. With that change made:
Reviewed-by: Anthony Krowiak
---
hw/vfio/ap.c | 12
1 file changed, 12 insertions(+)
diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index 93c74ebedb..fc435f5c5b 100644
--- a/hw/vfio/ap.c
+++ b/hw/vfio/ap.c
@@ -41,6 +41,13
On 6/5/25 1:57 PM, Rorie Reyes wrote:
On 6/4/25 9:47 AM, Anthony Krowiak wrote:
On 6/3/25 4:30 PM, Cédric Le Goater wrote:
On 6/3/25 20:01, Rorie Reyes wrote:
On 6/3/25 10:21 AM, Cédric Le Goater wrote:
On 6/3/25 14:58, Rorie Reyes wrote:
Hey Cedric,
You mentioned the following in
On 6/3/25 4:30 PM, Cédric Le Goater wrote:
On 6/3/25 20:01, Rorie Reyes wrote:
On 6/3/25 10:21 AM, Cédric Le Goater wrote:
On 6/3/25 14:58, Rorie Reyes wrote:
Hey Cedric,
You mentioned the following in my v9 patches
"In that case, let's keep it simple (no mutex) and add a
assert(bql_lo
On 5/26/25 4:43 AM, Cédric Le Goater wrote:
On 5/22/25 20:55, Anthony Krowiak wrote:
On 5/22/25 9:30 AM, Cédric Le Goater wrote:
On 5/12/25 20:02, Rorie Reyes wrote:
These functions can be invoked by the function that handles
interception
of the CHSC SEI instruction for requests
to hw/s390x/meson.build if CONFIG_VFIO_AP is
false, it will use the stub file.
Signed-off-by: Rorie Reyes
Reviewed-by: Anthony Krowiak
Reviewed-by: Cédric Le Goater
---
MAINTAINERS | 1 +
hw/s390x/ap-stub.c| 25 +
hw/s390x/meson.build | 1 +
target/
On 5/23/25 12:47 AM, Rorie Reyes wrote:
These functions can be invoked by the function that handles interception
of the CHSC SEI instruction for requests indicating the accessibility of
one or more adjunct processors has changed.
Signed-off-by: Rorie Reyes
---
hw/vfio/ap.c
On 5/22/25 9:30 AM, Cédric Le Goater wrote:
On 5/12/25 20:02, Rorie Reyes wrote:
These functions can be invoked by the function that handles interception
of the CHSC SEI instruction for requests indicating the accessibility of
one or more adjunct processors has changed.
Signed-off-by: Rorie
On 5/22/25 1:17 PM, Rorie Reyes wrote:
On 5/22/25 9:30 AM, Cédric Le Goater wrote:
On 5/12/25 20:02, Rorie Reyes wrote:
These functions can be invoked by the function that handles
interception
of the CHSC SEI instruction for requests indicating the
accessibility of
one or more adjunct pr
On 5/22/25 9:35 AM, Cédric Le Goater wrote:
On 5/12/25 20:02, Rorie Reyes wrote:
These functions can be invoked by the function that handles interception
of the CHSC SEI instruction for requests indicating the accessibility of
one or more adjunct processors has changed.
Signed-off-by: Rorie
On 5/12/25 2:02 PM, Rorie Reyes wrote:
These functions can be invoked by the function that handles interception
of the CHSC SEI instruction for requests indicating the accessibility of
one or more adjunct processors has changed.
Signed-off-by: Rorie Reyes
Reviewed-by: Anthony Krowiak
s390x/meson.build if CONFIG_VFIO_AP is
false, it will use the stub file.
Signed-off-by: Rorie Reyes
Reviewed-by: Anthony Krowiak
---
MAINTAINERS | 1 +
hw/s390x/ap-stub.c| 25 +
hw/s390x/meson.build | 1 +
target/s390x/ioinst.c | 11 +-
-off-by: Rorie Reyes
Reviewed-by: Anthony Krowiak
---
hw/vfio/ap.c | 12
1 file changed, 12 insertions(+)
diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index 3d0af7a54a..5ea5dd9cca 100644
--- a/hw/vfio/ap.c
+++ b/hw/vfio/ap.c
@@ -41,6 +41,13 @@ struct VFIOAPDevice
On 4/30/25 3:39 PM, John Levon wrote:
Add a helper similar to vfio_device_get_region_info() and use it
everywhere.
Replace a couple of needless allocations with stack variables.
As a side-effect, this fixes a minor error reporting issue in the call
from vfio_msix_early_setup().
Reviewed-by
On 3/10/25 11:35 AM, Rorie Reyes wrote:
Creates an object indicating that an AP configuration change event
has been received and stores it in a queue. These objects will later
be used to store event information for an AP configuration change
when the CHSC instruction is intercepted.
Signed-o
-off-by: Rorie Reyes
Reviewed-by: Anthony Krowiak
---
hw/vfio/ap.c | 12
1 file changed, 12 insertions(+)
diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index 3614657218..3fa986ca45 100644
--- a/hw/vfio/ap.c
+++ b/hw/vfio/ap.c
@@ -41,6 +41,13 @@ struct VFIOAPDevice
On 3/11/25 11:16 AM, Rorie Reyes wrote:
These functions can be invoked by the function that handles interception
of the CHSC SEI instruction for requests indicating the accessibility of
one or more adjunct processors has changed.
Signed-off-by: Rorie Reyes
Reviewed-by: Anthony Krowiak
On 3/10/25 11:35 AM, Rorie Reyes wrote:
Register an event notifier handler to process AP configuration
change events by queuing the event and generating a CRW to let
the guest know its AP configuration has changed
Signed-off-by: Rorie Reyes
LGTM:
Reviewed-by: Anthony Krowiak
---
hw
On 3/10/25 11:35 AM, Rorie Reyes wrote:
These functions can be invoked by the function that handles interception
of the CHSC SEI instruction for requests indicating the accessibility of
one or more adjunct processors has changed.
Signed-off-by: Rorie Reyes
---
hw/vfio/ap.c
On 2/4/25 12:07 PM, Rorie Reyes wrote:
Register an event notifier handler to process AP configuration
change events by queuing the event and generating a CRW to let
the guest know its AP configuration has changed
Signed-off-by: Rorie Reyes
---
hw/vfio/ap.c | 29 +++
On 2/4/25 12:07 PM, Rorie Reyes wrote:
Creates an object indicating that an AP configuration change event
has been received and stores it in a queue. These objects will later
be used to store event information for an AP configuration change
when the CHSC instruction is intercepted.
Signed-of
;);
+#ifdef CONFIG_IOMMUFD
+object_class_property_set_description(klass, /* 9.0 */
+ "iommufd",
+ "Set host IOMMUFD backend device");
+#endif
}
static const TypeInfo vfio_ap_info = {
For ap.c:
Reviewed-by: Anthony Krowiak
-off-by: Rorie Reyes
Reviewed-by: Anthony Krowiak
Tested-by: Anthony Krowiak
---
hw/vfio/ap.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index 533cadb2dd..508c6eed7a 100644
--- a/hw/vfio/ap.c
+++ b/hw/vfio/ap.c
@@ -41,6 +41,13 @@ struct
-off-by: Rorie Reyes
Reviewed-by: Anthony Krowiak
Tested-by: Anthony Krowiak
---
hw/vfio/ap.c | 10 ++
1 file changed, 10 insertions(+)
diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index 533cadb2dd..508c6eed7a 100644
--- a/hw/vfio/ap.c
+++ b/hw/vfio/ap.c
@@ -41,6 +41,13 @@ struct
On 1/7/25 1:43 PM, Rorie Reyes wrote:
Register an event notifier handler to process AP configuration
change events by queuing the event and generating a CRW to let
the guest know its AP configuration has changed
Signed-off-by: Rorie Reyes
Reviewed-by: Anthony Krowiak
Tested-by: Anthony
On 7/22/24 5:18 AM, Joao Martins wrote:
On 22/07/2024 08:07, Zhenzhong Duan wrote:
mdevs aren't "physical" devices and when asking for backing IOMMU info,
it fails the entire provisioning of the guest. Fix that by setting
vbasedev->mdev true so skipping HostIOMMUDevice initialization in the
pr
-634,7 +634,7 @@ int vfio_device_get_name(VFIODevice *vbasedev, Error **errp)
}
}
-return 0;
+return true;
}
For the two functions above:
Reviewed-by: Anthony Krowiak
snip ...
On 5/15/24 4:20 AM, Zhenzhong Duan wrote:
This is to follow the coding standand in qapi/error.h to return bool
for bool-valued functions.
Suggested-by: Cédric Le Goater
Signed-off-by: Zhenzhong Duan
---
include/hw/vfio/vfio-common.h | 4 ++--
hw/vfio/ap.c | 8 +++
On 5/22/24 1:01 PM, Cédric Le Goater wrote:
Use the 'Error **errp' argument of s390_ccw_realize() instead and
remove the error_propagate() call.
Signed-off-by: Cédric Le Goater
Reviewed-by: Anthony Krowiak
---
hw/s390x/s390-ccw.c | 13 +
1 file changed, 5
Le Goater
Reviewed-by: Anthony Krowiak
---
include/hw/s390x/s390-ccw.h | 2 +-
hw/s390x/s390-ccw.c | 7 ---
hw/vfio/ccw.c | 3 +--
3 files changed, 6 insertions(+), 6 deletions(-)
diff --git a/include/hw/s390x/s390-ccw.h b/include/hw/s390x/s390-c
Goater
Reviewed-by: Anthony Krowiak
---
hw/vfio/ap.c | 2 +-
hw/vfio/ccw.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index
c12531a7886a2fe87598be0861fba5923bd2c206..0c4354e3e70169ec072e16da0919936647d1d351
100644
--- a/hw/vfio
Reviewed-by: Anthony Krowiak
---
hw/s390x/ccw-device.h | 2 +-
hw/s390x/ccw-device.c | 3 ++-
hw/s390x/s390-ccw.c | 3 +--
3 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/hw/s390x/ccw-device.h b/hw/s390x/ccw-device.h
index
6dff95225df11c63f9b66975019026
Signed-off-by: Cédric Le Goater
Reviewed-by: Anthony Krowiak
---
hw/vfio/ccw.c | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/hw/vfio/ccw.c b/hw/vfio/ccw.c
index
9a8e052711fe2f7c067c52808b2af30d0ebfee0c..a468fa2342b97e0ee36bd5fb8443025cc90a0453
100644
--- a
On 5/22/24 1:01 PM, Cédric Le Goater wrote:
Since s390_ccw_get_dev_info() takes an 'Error **' argument, best
practices suggest to return a bool. See the qapi/error.h Rules
section. While at it, modify the call in s390_ccw_realize().
Signed-off-by: Cédric Le Goater
Reviewed-b
On 4/25/24 5:02 AM, Cédric Le Goater wrote:
Signed-off-by: Cédric Le Goater
---
hw/vfio/ap.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
LGTM
Reviewed-by: Anthony Krowiak
diff --git a/hw/vfio/ap.c b/hw/vfio/ap.c
index
7c4caa5938636937680fec87e999249ac84a4498
On 4/24/24 8:54 AM, Cédric Le Goater wrote:
Also change the return value of vfio_ap_register_irq_notifier() to be
a bool since it takes and 'Error **' argument. See the qapi/error.h
Rules section.
LGTM
Signed-off-by: Anthony Krowiak
Signed-off-by: Cédric Le Goater
---
hw
On 2/29/24 12:30 PM, Thomas Huth wrote:
On 29/02/2024 15.39, Zhao Liu wrote:
From: Zhao Liu
As the comment in qapi/error, passing @errp to error_prepend() requires
ERRP_GUARD():
* = Why, when and how to use ERRP_GUARD() =
*
* Without ERRP_GUARD(), use of the @errp parameter is restricted:
.
For the vfio-ap bus driver IRQ index mapping:
Reviewed-by: Tony Krowiak
On 7/9/23 5:23 PM, Cédric Le Goater wrote:
Signed-off-by: Cédric Le Goater
---
include/standard-headers/drm/drm_fourcc.h | 43 ++
include/standard-headers/linux/const.h| 2 +-
include/standard-head
On 7/3/23 12:31 PM, Cédric Le Goater wrote:
On 6/2/23 16:11, Tony Krowiak wrote:
Note: This is a placeholder patch that includes unmerged uapi changes.
Signed-off-by: Tony Krowiak
Link:
https://lore.kernel.org/qemu-devel/20230530225544.280031-1-akrow...@linux.ibm.com/
I am preparing a vf
On 6/2/23 10:28 AM, Cédric Le Goater wrote:
Hello Tony,
On 6/2/23 16:11, Tony Krowiak wrote:
Let's wire up the device request notifier interface to handle device
unplug
requests for AP.
Signed-off-by: Tony Krowiak
Link:
https://lore.kernel.org/qemu-devel/20230530225544.280031-1-akrow...@
On 5/31/23 9:07 AM, Cornelia Huck wrote:
On Wed, May 31 2023, Anthony Krowiak wrote:
On 5/30/23 8:56 PM, Matthew Rosato wrote:
On 5/30/23 6:55 PM, Tony Krowiak wrote:
Signed-off-by: Tony Krowiak
---
linux-headers/linux/vfio.h | 9 +
1 file changed, 9 insertions(+)
Worth
On 5/31/23 9:07 AM, Matthew Rosato wrote:
On 5/31/23 8:52 AM, Anthony Krowiak wrote:
On 5/30/23 8:56 PM, Matthew Rosato wrote:
On 5/30/23 6:55 PM, Tony Krowiak wrote:
Signed-off-by: Tony Krowiak
---
linux-headers/linux/vfio.h | 9 +
1 file changed, 9 insertions(+)
Worth
On 5/30/23 8:56 PM, Matthew Rosato wrote:
On 5/30/23 6:55 PM, Tony Krowiak wrote:
Signed-off-by: Tony Krowiak
---
linux-headers/linux/vfio.h | 9 +
1 file changed, 9 insertions(+)
Worth nothing here that linux-headers patches should be generated using
scripts/update-linux-heade
The required kernel changes associated with the patch are here:
https://lore.kernel.org/linux-s390/20230530223538.279198-1-akrow...@linux.ibm.com/
On 5/30/23 6:55 PM, Tony Krowiak wrote:
When a user attempts to remove a vfio-ap mediated device attached to a
guest, the operation hangs until the
46 matches
Mail list logo
