Re: [RFC PATCH 01/11] acpi: hmp/qmp: Add hmp/qmp support for system_sleep

2023-12-22 Thread Annie.li
On 12/22/2023 7:37 AM, Markus Armbruster wrote: "Annie.li" writes: Hi Markus, On 12/5/2023 3:34 PM, Markus Armbruster wrote: You neglected to cc: QAPI schema maintainers. I found it by chance. Next time :) Yep, should have cc to the maintainers. Annie Li writes: Followi

Re: [RFC PATCH 01/11] acpi: hmp/qmp: Add hmp/qmp support for system_sleep

2023-12-05 Thread Annie.li
Hi Markus, On 12/5/2023 3:34 PM, Markus Armbruster wrote: You neglected to cc: QAPI schema maintainers. I found it by chance. Next time :) Yep, should have cc to the maintainers. Annie Li writes: Following hmp/qmp commands are implemented for pressing virtual sleep button, hmp: system_sl

Re: [RFC PATCH 01/11] acpi: hmp/qmp: Add hmp/qmp support for system_sleep

2023-12-05 Thread Annie.li
Hi Philippe, On 12/5/2023 4:44 AM, Philippe Mathieu-Daudé wrote: Hi Annie, On 5/12/23 01:23, Annie Li wrote: Following hmp/qmp commands are implemented for pressing virtual sleep button, hmp: system_sleep qmp: { "execute": "system_sleep" } These commands put the guest into suspend or other p

Re: [Qemu-devel] [PATCH] acpi: Add emulated sleep button

2023-08-01 Thread Annie.li
Hi Igor, On 7/14/2023 10:04 AM, Igor Mammedov wrote: On Fri, 7 Jul 2023 13:43:36 -0400 "Annie.li" wrote: Hi Igor, Revisiting this thread and have more questions, please clarify, thank you! On 9/20/2021 3:53 AM, Igor Mammedov wrote: On Fri, 6 Aug 2021 16:18:09 -0400 "A

Re: [Qemu-devel] [PATCH] acpi: Add emulated sleep button

2023-07-07 Thread Annie.li
Hi Igor, Revisiting this thread and have more questions, please clarify, thank you! On 9/20/2021 3:53 AM, Igor Mammedov wrote: On Fri, 6 Aug 2021 16:18:09 -0400 "Annie.li" wrote: Hello Igor, This is an old patch, but it does what we need. I am getting a little bit lost

Re: [PATCH v2 0/3] contrib/elf2dmp: Windows Server 2022 support

2023-03-06 Thread Annie.li
Hello Viktor, This patch set looks good to me, thank you! On 2/22/2023 4:12 PM, Viktor Prutyanov wrote: Hi, For now, elf2dmp is unable to convert ELF-dump to DMP-dump made of Windows Server 2022 guest. This patch series fixes it. v1: improve code-style fix v2: don't remove data directory entr

Re: [PATCH v1 3/3] contrib/elf2dmp: add PE name check and Windows Server 2022 support

2023-02-22 Thread Annie.li
On 11/29/2022 7:03 PM, Viktor Prutyanov wrote: Since its inception elf2dmp has checked MZ signatures within an address space above IDT[0] interrupt vector and took first PE image found as Windows Kernel. But in Windows Server 2022 memory dump this address space range is full of invalid PE fragm

Re: [PATCH v1 2/3] contrib/elf2dmp: move PE dir search to pe_get_data_dir_entry

2023-02-22 Thread Annie.li
Hello Viktor, See my following comments inline, On 11/29/2022 7:03 PM, Viktor Prutyanov wrote: Move out PE directory search functionality to be reused not only for Debug Directory processing but for arbitrary PE directory. Signed-off-by: Viktor Prutyanov --- contrib/elf2dmp/main.c | 66

Re: [PATCH 1/1] pcie: Do not set power state for some hot-plugged devices

2021-12-16 Thread Annie.li
Hello Gerd, On 12/16/2021 1:11 AM, Gerd Hoffmann wrote: Hi, Maybe we should just not set DeviceState->hotplugged = true for devices added in VM_STATE_PRELAUNCH? It's not actual hotplug (i.e. device added while the system is running) after all ... Simply not setting "DeviceState->hotplugge

Re: [PATCH 1/1] pcie: Do not set power state for some hot-plugged devices

2021-12-15 Thread Annie.li
On 12/15/2021 1:05 AM, Gerd Hoffmann wrote: On Tue, Dec 14, 2021 at 09:53:12PM +, Annie Li wrote: After the PCIe device is hot-plugged, the device's power state is initialized as ON. However, the device isn't powered on yet, i.e. the PCI_EXP_SYSCTL_PCC bit isn't set to PCI_EXP_SLTCTL_PWR_O

Re: Failure of hot plugging secondary virtio_blk into q35 Windows 2019

2021-11-19 Thread Annie.li
On 11/10/2021 1:12 PM, Annie.li wrote: On 11/9/2021 1:32 PM, Daniel P. Berrangé wrote: On Tue, Nov 09, 2021 at 12:01:30PM -0500, Annie.li wrote: On 11/9/2021 6:19 AM, Daniel P. Berrangé wrote: On Tue, Nov 09, 2021 at 04:40:10PM +0530, Ani Sinha wrote: On Tue, Nov 9, 2021 at 3:23 PM Daniel

Re: Failure of hot plugging secondary virtio_blk into q35 Windows 2019

2021-11-10 Thread Annie.li
On 11/9/2021 1:32 PM, Daniel P. Berrangé wrote: On Tue, Nov 09, 2021 at 12:01:30PM -0500, Annie.li wrote: On 11/9/2021 6:19 AM, Daniel P. Berrangé wrote: On Tue, Nov 09, 2021 at 04:40:10PM +0530, Ani Sinha wrote: On Tue, Nov 9, 2021 at 3:23 PM Daniel P. Berrangé wrote: On Tue, Nov 09

Re: Failure of hot plugging secondary virtio_blk into q35 Windows 2019

2021-11-09 Thread Annie.li
On 11/9/2021 6:19 AM, Daniel P. Berrangé wrote: On Tue, Nov 09, 2021 at 04:40:10PM +0530, Ani Sinha wrote: On Tue, Nov 9, 2021 at 3:23 PM Daniel P. Berrangé wrote: On Tue, Nov 09, 2021 at 12:41:39PM +0530, Ani Sinha wrote: +gerd On Mon, 8 Nov 2021, Annie.li wrote: Update: I've teste

Re: Failure of hot plugging secondary virtio_blk into q35 Windows 2019

2021-11-08 Thread Annie.li
Update: I've tested q35 guest w/o OVMF, the APCI PCI hot-plugging works well in q35 guest. Seems this issue only happens in q35 guest w/ OVMF. Looks that there is already a bug filed against this hotplug issue in q35 guest w/ OVMF, https://bugzilla.redhat.com/show_bug.cgi?id=2004829 In thi

Re: Failure of hot plugging secondary virtio_blk into q35 Windows 2019

2021-11-08 Thread Annie.li
r hotplug/unplug failures, for example, deleted virtio disks still show in q35 Windows guest. I am wondering if anyone has seen this kind of errors with ACPI PCI hotplug in q35 guests with latest QEMU version? Thanks Annie On 11/1/2021 10:06 AM, Annie.li wrote: Hello, I've found an

Failure of hot plugging secondary virtio_blk into q35 Windows 2019

2021-11-01 Thread Annie.li
Hello, I've found an issue when hot-plugging the secondary virtio_blk device into q35 Windows guest(2019) with upstream qemu 6.1.0(+1 patch). The first disk can be hot-plugged successfully. The qemu options for PCIe root port is,  -device pcie-root-port,port=2,chassis=2,id=pciroot2,bus=pcie

Re: [Qemu-devel] [PATCH] acpi: Add emulated sleep button

2021-08-06 Thread Annie.li
Hello Igor, This is an old patch, but it does what we need. I am getting a little bit lost about not implementing fixed hardware sleep button, can you please clarify? thank you! On 7/20/2017 10:59 AM, Igor Mammedov wrote: On Thu, 20 Jul 2017 11:31:26 +0200 Stefan Fritsch wrote: From: Stefan