Re: [PATCH 2/8] acpi: cpuhp: introduce 'firmware performs eject' status/control bits

2020-12-07 Thread Ankur Arora
On 2020-12-07 4:48 a.m., Igor Mammedov wrote: On Mon, 7 Dec 2020 00:47:13 -0800 Ankur Arora wrote: On 2020-12-06 10:31 p.m., Ankur Arora wrote: On 2020-12-04 9:09 a.m., Igor Mammedov wrote: Adds bit #4 to status/control field of CPU hotplug MMIO interface. New bit will be used OSPM to mark

Re: [PATCH 2/8] acpi: cpuhp: introduce 'firmware performs eject' status/control bits

2020-12-07 Thread Ankur Arora
On 2020-12-06 10:31 p.m., Ankur Arora wrote: On 2020-12-04 9:09 a.m., Igor Mammedov wrote: Adds bit #4 to status/control field of CPU hotplug MMIO interface. New bit will be used OSPM to mark CPUs as pending for removal by firmware, when it calls _EJ0 method on CPU device node. Later on, when

Re: [PATCH 2/8] acpi: cpuhp: introduce 'firmware performs eject' status/control bits

2020-12-06 Thread Ankur Arora
On 2020-12-04 9:09 a.m., Igor Mammedov wrote: Adds bit #4 to status/control field of CPU hotplug MMIO interface. New bit will be used OSPM to mark CPUs as pending for removal by firmware, when it calls _EJ0 method on CPU device node. Later on, when firmware sees this bit set, it will perform CPU

Re: [PATCH 5/8] x86: acpi: let the firmware handle pending "CPU remove" events in SMM

2020-12-06 Thread Ankur Arora
On 2020-12-06 10:20 p.m., Ankur Arora wrote: On 2020-12-04 9:09 a.m., Igor Mammedov wrote: if firmware and QEMU negotiated CPU hotunplug support, generate _EJ0 method so that it will mark CPU for removal by firmware and pass control to it by triggering SMI. Signed-off-by: Igor Mammedov

Re: [PATCH 5/8] x86: acpi: let the firmware handle pending "CPU remove" events in SMM

2020-12-06 Thread Ankur Arora
On 2020-12-04 9:09 a.m., Igor Mammedov wrote: if firmware and QEMU negotiated CPU hotunplug support, generate _EJ0 method so that it will mark CPU for removal by firmware and pass control to it by triggering SMI. Signed-off-by: Igor Mammedov --- include/hw/acpi/cpu.h | 1 + hw/acpi/cpu.c

Re: [RFC] ich9:cpuhp: add support for cpu hot-unplug with SMI broadcast enabled

2020-11-30 Thread Ankur Arora
On 2020-11-30 8:58 a.m., Laszlo Ersek wrote: On 11/28/20 00:48, Ankur Arora wrote: It is possible that there are CPUs with bits for both is_inserting and is_removing. In that case QemuCpuhpCollectApicIds() would put them in the PluggedApicIds array and the unplug eventually happens in the next

Re: [RFC] ich9:cpuhp: add support for cpu hot-unplug with SMI broadcast enabled

2020-11-27 Thread Ankur Arora
On 2020-11-27 7:19 a.m., Laszlo Ersek wrote: On 11/27/20 05:10, Ankur Arora wrote: Yeah I was wondering what would happen for simultaneous hot add and remove. I guess we would always do remove first and then the add, unless we hit the break due to max_cpus_per_pass and switch to hot-add mode

Re: [RFC] ich9:cpuhp: add support for cpu hot-unplug with SMI broadcast enabled

2020-11-27 Thread Ankur Arora
On 2020-11-27 3:47 a.m., Igor Mammedov wrote: On Thu, 26 Nov 2020 20:10:59 -0800 Ankur Arora wrote: On 2020-11-26 12:38 p.m., Igor Mammedov wrote: On Thu, 26 Nov 2020 12:17:27 +0100 Laszlo Ersek wrote: On 11/24/20 13:25, Igor Mammedov wrote: If firmware negotiates

Re: [RFC] ich9:cpuhp: add support for cpu hot-unplug with SMI broadcast enabled

2020-11-27 Thread Ankur Arora
On 2020-11-27 7:02 a.m., Laszlo Ersek wrote: On 11/27/20 12:33, Igor Mammedov wrote: On Thu, 26 Nov 2020 19:35:30 -0800 Ankur Arora wrote: On 2020-11-26 4:46 a.m., Laszlo Ersek wrote: On 11/26/20 11:24, Ankur Arora wrote: On 2020-11-24 4:25 a.m., Igor Mammedov wrote: If firmware

Re: [RFC] ich9:cpuhp: add support for cpu hot-unplug with SMI broadcast enabled

2020-11-26 Thread Ankur Arora
On 2020-11-26 12:38 p.m., Igor Mammedov wrote: On Thu, 26 Nov 2020 12:17:27 +0100 Laszlo Ersek wrote: On 11/24/20 13:25, Igor Mammedov wrote: If firmware negotiates ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT feature, OSPM on CPU eject will set bit #4 in CPU hotplug block for to be ejected CPU to mark

Re: [RFC] ich9:cpuhp: add support for cpu hot-unplug with SMI broadcast enabled

2020-11-26 Thread Ankur Arora
On 2020-11-26 11:50 a.m., Igor Mammedov wrote: On Thu, 26 Nov 2020 13:46:32 +0100 Laszlo Ersek wrote: On 11/26/20 11:24, Ankur Arora wrote: On 2020-11-24 4:25 a.m., Igor Mammedov wrote: If firmware negotiates ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT feature, OSPM on CPU eject will set bit #4 in

Re: [RFC] ich9:cpuhp: add support for cpu hot-unplug with SMI broadcast enabled

2020-11-26 Thread Ankur Arora
On 2020-11-26 4:46 a.m., Laszlo Ersek wrote: On 11/26/20 11:24, Ankur Arora wrote: On 2020-11-24 4:25 a.m., Igor Mammedov wrote: If firmware negotiates ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT feature, OSPM on CPU eject will set bit #4 in CPU hotplug block for to be ejected CPU to mark it for removal

Re: [RFC] ich9:cpuhp: add support for cpu hot-unplug with SMI broadcast enabled

2020-11-26 Thread Ankur Arora
On 2020-11-24 4:25 a.m., Igor Mammedov wrote: If firmware negotiates ICH9_LPC_SMI_F_CPU_HOT_UNPLUG_BIT feature, OSPM on CPU eject will set bit #4 in CPU hotplug block for to be ejected CPU to mark it for removal by firmware and trigger SMI upcall to let firmware do actual eject. Signed-off-by: I