Re: [Qemu-devel] [PATCH] target-i386: fix segment limit check in ljmp

2018-08-20 Thread Andrew Oates
On Mon, Aug 20, 2018 at 6:06 AM Paolo Bonzini wrote: > > On 17/08/2018 20:04, Andrew Oates wrote: > >>> [1] this is an invalid configuration (in protected mode the L bit is > >>> reserved and should be set to zero), but qemu doesn't enforce that. > > >

Re: [Qemu-devel] [PATCH] target-i386: fix segment limit check in ljmp

2018-08-17 Thread Andrew Oates
On Fri, Aug 17, 2018 at 1:38 PM Paolo Bonzini wrote: > On 16/08/2018 03:19, and...@andrewoates.com wrote: > > From: Andrew Oates > > > > The current implementation has three bugs, > > * segment limits are not enforced in protected mode if the L bit is set &

Re: [Qemu-devel] [PATCH v3] slirp: fix ICMP handling on macOS hosts

2018-08-15 Thread Andrew Oates via Qemu-devel
On Wed, Aug 15, 2018 at 7:03 AM Samuel Thibault wrote: > Andrew Oates, le mar. 14 août 2018 22:35:21 -0400, a ecrit: > > On Linux, SOCK_DGRAM+IPPROTO_ICMP sockets give only the ICMP packet when > > read from. On macOS, however, the socket acts like a SOCK_RAW socket > >

[Qemu-devel] [PATCH v3] slirp: fix ICMP handling on macOS hosts

2018-08-14 Thread Andrew Oates via Qemu-devel
ICMP sockets aren't supported on other BSDs, but we enable this behavior for them as well to treat the sockets the same as raw sockets. Signed-off-by: Andrew Oates --- v2: check validity of inner_hlen and update len appropriately v3: CONFIG_DARWIN -> CONFIG_BSD; add comment explainin

Re: [Qemu-devel] [PULL 1/1] slirp: fix ICMP handling on macOS hosts

2018-08-14 Thread Andrew Oates via Qemu-devel
On Tue, Aug 14, 2018 at 11:52 AM Peter Maydell wrote: > On 12 August 2018 at 04:11, Andrew Oates wrote: > > Ping --- would you like me to resubmit the patch using CONFIG_BSD? > > Yes, that seems our best option. Could you please also include > a comment that summarises th

Re: [Qemu-devel] [PATCH] target-i386: Fix lcall to call gate in IA-32e mode

2018-08-12 Thread Andrew Oates via Qemu-devel
On Sun, Aug 12, 2018 at 6:17 AM Paolo Bonzini wrote: > On 12/08/2018 05:07, Andrew Oates via Qemu-devel wrote: > > Currently call gates are always treated as 32-bit gates. In IA-32e mode > > (either compatibility or 64-bit submode), system segment descriptors are > > alw

Re: [Qemu-devel] [PULL 1/1] slirp: fix ICMP handling on macOS hosts

2018-08-11 Thread Andrew Oates via Qemu-devel
Ping --- would you like me to resubmit the patch using CONFIG_BSD? Cheers, ~Andrew On Wed, Aug 1, 2018 at 10:39 AM Andrew Oates wrote: > > > > On Wed, Aug 1, 2018 at 6:10 AM Peter Maydell > wrote: > >> On 1 August 2018 at 00:25, Andrew Oates wrote: >> > Bot

[Qemu-devel] [PATCH] target-i386: Fix lcall to call gate in IA-32e mode

2018-08-11 Thread Andrew Oates via Qemu-devel
checks for non-canonical addresses in this code elsewhere. I've left the raise_exception_err_ra lines unwapped at 80 columns to match the style in the rest of the file. Signed-off-by: Andrew Oates --- target/i386/seg_helper.c | 145 --- 1 file changed,

Re: [Qemu-devel] [PULL 1/1] slirp: fix ICMP handling on macOS hosts

2018-08-01 Thread Andrew Oates via Qemu-devel
On Wed, Aug 1, 2018 at 6:10 AM Peter Maydell wrote: > On 1 August 2018 at 00:25, Andrew Oates wrote: > > Both CONFIG_BSD and not-CONFIG_LINUX work on macOS. I unfortunately > don't > > have access to any other BSDs to test them, though. > > Is there an easy way t

Re: [Qemu-devel] [PULL 1/1] slirp: fix ICMP handling on macOS hosts

2018-07-31 Thread Andrew Oates via Qemu-devel
On Tue, Jul 31, 2018 at 6:22 AM Peter Maydell wrote: > On 31 July 2018 at 02:16, Andrew Oates wrote: > > Yeah, I suspect (but haven't tested) that this applies to all BSDs. We > > could switch CONFIG_DARWIN to CONFIG_BSD (happy to resend the patch, just > > LMK). &g

Re: [Qemu-devel] [PULL 1/1] slirp: fix ICMP handling on macOS hosts

2018-07-30 Thread Andrew Oates via Qemu-devel
s configuration. ~Andrew On Mon, Jul 30, 2018 at 6:38 AM Peter Maydell wrote: > On 29 July 2018 at 15:35, Samuel Thibault > wrote: > > From: Andrew Oates > > > > On Linux, SOCK_DGRAM+IPPROTO_ICMP sockets give only the ICMP packet when > > read from. On macOS,

Re: [Qemu-devel] [PATCH] slirp: fix ICMP handling on macOS hosts

2018-07-28 Thread Andrew Oates via Qemu-devel
On Sat, Jul 28, 2018, 13:53 Samuel Thibault wrote: > Hello, > > aoa...@google.com, le mer. 25 juil. 2018 21:08:12 -0400, a ecrit: > > From: Andrew Oates > > > > On Linux, SOCK_DGRAM+IPPROTO_ICMP sockets give only the ICMP packet when > > read from. On macOS

[Qemu-devel] [Bug 1503031] Re: 32-to-64-bit call gate unsupported in IA32e mode

2015-10-06 Thread Andrew Oates
I also suspect that qemu will incorrectly allow calls through 32-bit call gates in compatibility mode (rather than raising a GP fault --- see Intel manuals volume 3A 5-21). And I doubt 64-to-64-bit call gates work either. I haven't actually tested either of those scenarios, though, this is just f

[Qemu-devel] [Bug 1503031] [NEW] 32-to-64-bit call gate unsupported in IA32e mode

2015-10-06 Thread Andrew Oates
Public bug reported: In particular, the lcall implementation doesn't support the 64-bit TSS. helper_lcall_protected (target-i386/seg_helper.c:1884) calls get_ss_esp_from_tss() on a call gate to a lower privilege level, which tries to extract a 32-bit ESP and 16-bit SS from the TSS. In IA32e mode

[Qemu-devel] [Bug 1267520] Re: Keyboard input not working when the "-k en-us" argument is specified.

2015-10-06 Thread Andrew Oates
Yes, that's exactly the issue. If you run qemu in a directory with a file or subdir called 'common' then the keymap won't load. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1267520 Title: Keyboar

[Qemu-devel] [PATCH] input (curses): mask keycodes to remove modifier bits

2014-05-23 Thread Andrew Oates
Without the mask, control bits are passed on in the keycode, generating incorrect PS/2 sequences when SHIFT, ALT, etc are held down. Signed-off-by: Andrew Oates --- ui/curses.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/curses.c b/ui/curses.c index b044790