Re: [Qemu-devel] ivshmem property size should be a size, not a string

2015-11-23 Thread Andrew James
hmem itself. QEMU 2.1 through 2.4.1 have worked well for our use-case. >> Why is this a single device model? > > No idea, but I agree it would make sense to have two different devices. FWIW, I support splitting the device into memdev and doorbell varieties as long as a compatibility device is available too. Thanks, -- Andrew James

Re: [Qemu-devel] [PATCH 1/3] virtio: introduce virtqueue_unmap_sg()

2015-09-24 Thread Andrew James
elem->out_sg[i].iov_len, >0, elem->out_sg[i].iov_len); > +} > + > +void virtqueue_fill(VirtQueue *vq, const VirtQueueElement *elem, > +unsigned int len, unsigned int idx) > +{ > +trace_virtqueue_fill(vq, elem, len, idx); > + > +virtqueue_unmap_sg(vq, elem, len); > > idx = (idx + vring_used_idx(vq)) % vq->vring.num; > > Thanks, -- Andrew James

Re: [Qemu-devel] [PATCH 1/3] virtio: introduce virtqueue_unmap_sg()

2015-09-24 Thread Andrew James
elem->out_sg[i].iov_len, >0, elem->out_sg[i].iov_len); > +} > + > +void virtqueue_fill(VirtQueue *vq, const VirtQueueElement *elem, > +unsigned int len, unsigned int idx) > +{ > +trace_virtqueue_fill(vq, elem, len, idx); > + > +virtqueue_unmap_sg(vq, elem, len); > > idx = (idx + vring_used_idx(vq)) % vq->vring.num; > > Thanks, -- Andrew James