Re: [PATCH v3] linux-user/s390x: Use the guest pointer for the sigreturn stub

2021-03-25 Thread Andreas Krebbel
On 3/25/21 8:55 PM, Laurent Vivier wrote: > Le 24/03/2021 à 19:51, Andreas Krebbel a écrit : >> When setting up the pointer for the sigreturn stub in the return >> address register (r14) we currently use the host frame address instead >> of the guest frame address. >>

[PATCH v3] linux-user/s390x: Use the guest pointer for the sigreturn stub

2021-03-24 Thread Andreas Krebbel
defaults to 0 hiding the actual problem. Signed-off-by: Andreas Krebbel --- linux-user/s390x/signal.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index ecfa2a14a9..7107c5fb53 100644 --- a/linux-user/s390x/signal.c +++ b

Re: [PATCH v2] linux-user/s390x: Use the guest pointer for the sigreturn stub

2021-03-24 Thread Andreas Krebbel
On 3/24/21 6:53 PM, Laurent Vivier wrote: > Le 24/03/2021 à 16:55, Andreas Krebbel a écrit : >> When setting up the pointer for the sigreturn stub in the return >> address register (r14) we have to use the guest frame pointer instead >> of the host frame pointer. >>

[PATCH v2] linux-user/s390x: Use the guest pointer for the sigreturn stub

2021-03-24 Thread Andreas Krebbel
to 0 hiding the actual problem. Signed-off-by: Andreas Krebbel --- linux-user/s390x/signal.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/linux-user/s390x/signal.c b/linux-user/s390x/signal.c index ecfa2a14a9..e9bf865074 100644 --- a/linux-user/s390x/signal.c +++ b/linux

Re: [PATCH 1/1] linux-user/s390x: Apply h2g to address of sigreturn stub

2021-03-24 Thread Andreas Krebbel
On 3/24/21 2:06 PM, Laurent Vivier wrote: > Le 24/03/2021 à 12:26, Andreas Krebbel a écrit : >> On 3/24/21 11:28 AM, Laurent Vivier wrote: >>> Le 24/03/2021 à 10:17, David Hildenbrand a écrit : >>>> On 24.03.21 09:51, Andreas Krebbel wrote: >>>>> T

[PATCH 1/1] linux-user/s390x: Apply h2g to address of sigreturn stub

2021-03-24 Thread Andreas Krebbel
: This only caused problems if Qemu has been built with --disable-pie (as it is in distros nowadays). Otherwise guest_base defaults to 0 hiding the actual problem. Signed-off-by: Andreas Krebbel --- linux-user/s390x/signal.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a

Re: [PATCH 1/1] linux-user/s390x: Apply h2g to address of sigreturn stub

2021-03-24 Thread Andreas Krebbel
On 3/24/21 11:28 AM, Laurent Vivier wrote: > Le 24/03/2021 à 10:17, David Hildenbrand a écrit : >> On 24.03.21 09:51, Andreas Krebbel wrote: >>> The sigreturn SVC is put onto the stack by the emulation code.  Hence >>> the address of it should not be subject to guest_b