Re: [Qemu-devel] [PATCH v2] use _Static_assert in QEMU_BUILD_BUG_ON

2017-03-14 Thread Andreas Grapentin
The missing ! is because I generated the error messages by inverting the condition and then forgot to change it back. I can send a v3 if you like. Thanks for being patient with me. -A On Tue, Mar 14, 2017 at 12:43:56PM -0500, Eric Blake wrote: > On 03/14/2017 11:59 AM, Andreas Grapentin wr

[Qemu-devel] [PATCH v2] use _Static_assert in QEMU_BUILD_BUG_ON

2017-03-14 Thread Andreas Grapentin
gt; ‘atomic_load_acquire’ > atomic_load_acquire(ptr) > ^~~ > /qemu/qga/commands.c:160:21: note: in expansion of macro ‘atomic_mb_read’ > bool finished = atomic_mb_read(&gei->finished); > ^~ Signed-off-by: Andreas Grapentin

[Qemu-devel] [PATCH 1/1] added configure check for _Static_assert and updated QEMU_BUILD_BUG_ON(...) accordingly

2017-03-14 Thread Andreas Grapentin
--- configure | 18 ++ include/qemu/compiler.h | 4 +++- 2 files changed, 21 insertions(+), 1 deletion(-) diff --git a/configure b/configure index 75c7c3526c..e9b33d9cf8 100755 --- a/configure +++ b/configure @@ -4725,6 +4725,20 @@ if compile_prog "" "" ; then fi

[Qemu-devel] [PATCH 0/1] Developer Conveniences - check for _Static_assert and use in QEMU_BUILD_BUG_ON

2017-03-14 Thread Andreas Grapentin
gt; sizeof(void *)); \ > ^ > /home/andi/research/qemu-shared-memory/qemu/include/qemu/atomic.h:417:5: > note: in expansion of macro ‘atomic_load_acquire’ > atomic_load_acquire(ptr) > ^~~ > /home/andi/research/qemu-shared-memory/qemu/qg

[Qemu-devel] [PATCH 1/1] major / minor macros are to be included from

2017-03-14 Thread Andreas Grapentin
--- hw/9pfs/9p.c | 1 + qga/commands-posix.c | 1 + 2 files changed, 2 insertions(+) diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c index 76c9247c77..d9cfa8900e 100644 --- a/hw/9pfs/9p.c +++ b/hw/9pfs/9p.c @@ -12,6 +12,7 @@ */ #include "qemu/osdep.h" +#include #include #include "hw/vir

[Qemu-devel] [PATCH 0/1] major / minor macros are to be included from

2017-03-14 Thread Andreas Grapentin
quot;, include > directly. If you did not intend to use a system-defined macro > "major", you should undefine it after including . [-Werror] > *devmajor = major(st.st_rdev); > ^~ A trivial fix is to #include in the respective f

[Qemu-devel] Requesting Edit Access to the wiki

2017-03-14 Thread Andreas Grapentin
Hello, I wanted to update a link on the wiki on this page: http://wiki.qemu-project.org/Contribute/SubmitAPatch#Use_git_format-patch the page contains this outdated link: http://lxr.free-electrons.com/source/Documentation/email-clients.txt its target has been moved to: http://lxr.free-electrons