Re: [PATCH] virtio-rng: block max-bytes=0

2024-07-24 Thread Amit Shah
negative, " > +    if (vrng->conf.max_bytes == 0 || > +    vrng->conf.max_bytes > INT64_MAX) { > +    error_setg(errp, "'max-bytes' parameter must be positive, " >     "and less than 2^63"); > return; > } Reviewed-by: Amit Shah

Re: [PATCH v3 0/9] virtio-console: notify about the terminal size

2023-10-23 Thread Amit Shah
On Mon, 2023-10-23 at 05:12 +0200, Filip Hejsek wrote: > I have found this 3 year old patch adding virtio console resize > support, which seems to have been forgotten at that time. I would like > to see this feature merged. > > Szymon, you have originally submitted this patch, would you be willing

Re: [RFC PATCH 0/1] Implement entropy leak reporting for virtio-rng

2023-04-14 Thread Amit Shah
> the content is safe. > > > > > > > > On Tue, Apr 11, 2023 at 6:19 PM Amit Shah wrote: > > > Hey Babis, > > > > > > On Mon, 2023-04-03 at 12:52 +0200, Babis Chalios wrote: > > > > This patchset implements the entropy leak reporting fe

Re: [RFC PATCH 0/1] Implement entropy leak reporting for virtio-rng

2023-04-11 Thread Amit Shah
Hey Babis, On Mon, 2023-04-03 at 12:52 +0200, Babis Chalios wrote: > This patchset implements the entropy leak reporting feature proposal [1] > for virtio-rng devices. > > Entropy leaking (as defined in the specification proposal) typically > happens when we take a snapshot of a VM or while we re

Re: [PATCH v3] virtio-serial-bus: Plug memory leak on realize() error paths

2020-03-09 Thread Amit Shah
sdb/backup/qemu/util/main-loop.c:532 > > #4 0x56273d52e62e in virtser_port_device_realize > > /mnt/sdb/backup/qemu/hw/char/virtio-serial-bus.c:946 > > #5 0x56273dcc5040 in device_set_realized > > /mnt/sdb/backup/qemu/hw/core/qdev.c:891 > > #6 0

Re: [PATCH v2] virtio-serial-bus: do cleanup on the error path in realize() to avoid memleaks

2020-03-05 Thread Amit Shah
> /mnt/sdb/backup/qemu/hw/char/virtio-serial-bus.c:946 > #5 0x56273dcc5040 in device_set_realized > /mnt/sdb/backup/qemu/hw/core/qdev.c:891 > #6 0x56273e5ebbce in property_set_bool > /mnt/sdb/backup/qemu/qom/object.c:2238 > #7 0x56273e5e5a9c in object_property_set > /mnt/sdb/backup/qemu/qo

Re: [RFC 0/2] virtio-rng: add a control queue

2020-01-24 Thread Amit Shah
On Thu, 2020-01-23 at 16:16 +0100, Laurent Vivier wrote: > The kernel needs sometime to be able to cancel an ongoing command. > > For instance, if the virtio-rng device uses the egd backend > and this backend doesn't provide data, the buffer provided by the > kernel is kept as long as it is needed

Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer

2019-12-06 Thread Amit Shah
On Fri, 2019-12-06 at 10:17 +0800, Pan Nengyuan wrote: > On 2019/12/6 0:45, Amit Shah wrote: > > On Wed, 2019-12-04 at 15:31 +0800, pannengy...@huawei.com wrote: > > > From: Pan Nengyuan > > > > Shouldn't this be From: mst? > > > > I didn't fi

Re: [PATCH v2 1/3] virtio: add ability to delete vq through a pointer

2019-12-05 Thread Amit Shah
On Wed, 2019-12-04 at 15:31 +0800, pannengy...@huawei.com wrote: > From: Pan Nengyuan Shouldn't this be From: mst? I didn't find a ref to the original patch to confirm if you had to adapt it in any way, though. > Devices tend to maintain vq pointers, allow deleting them trough a vq > pointer. >

Re: [PATCH] virtio-serial-bus: fix memory leak while attach virtio-serial-bus

2019-12-03 Thread Amit Shah
On Tue, 2019-12-03 at 00:37 -0500, Michael S. Tsirkin wrote: > On Tue, Dec 03, 2019 at 08:53:42AM +0800, pannengyuan wrote: > > > > > > On 2019/12/2 21:58, Laurent Vivier wrote: > > > On 02/12/2019 12:15, pannengy...@huawei.com wrote: > > > > From: PanNengyuan > > > > > > > > ivqs/ovqs/c_ivq/c_

Re: [Qemu-devel] [PATCH] MAINTAINERS: update virtio-rng and virtio-serial maintainer

2019-09-10 Thread Amit Shah
On Mon, 2019-09-09 at 20:05 +0200, Laurent Vivier wrote: > As discussed with Amit, I volunteer to maintain virtio-rng and > virtio-serial > previously maintained by Amit. > > Signed-off-by: Laurent Vivier Acked-by: Amit Shah > --- > MAINTAINERS | 6 -- > 1 fi

Re: [Qemu-devel] [PATCH v7 0/4] rng-builtin: add an RNG backend that uses qemu_guest_getrandom()

2019-07-03 Thread Amit Shah
On Tue, 2019-07-02 at 18:48 +0200, Laurent Vivier wrote: > On 02/07/2019 15:21, Michael S. Tsirkin wrote: > > On Wed, May 29, 2019 at 04:31:02PM +0200, Laurent Vivier wrote: > > > Add a new RNG backend using QEMU builtin getrandom function. > > > > > > v7: rebase on master > > > Make rng-built

Re: [Qemu-devel] [RFC] virtio-rng: add a watchdog

2019-06-14 Thread Amit Shah
On Thu, 2019-06-13 at 10:53 +0200, Laurent Vivier wrote: > On 12/06/2019 09:03, Amit Shah wrote: > > On Tue, 2019-06-11 at 19:20 +0200, Laurent Vivier wrote: > > > The virtio-rng linux driver can be stuck in virtio_read() on a > > > wait_for_completion_killable() call

Re: [Qemu-devel] [RFC] virtio-rng: add a watchdog

2019-06-12 Thread Amit Shah
On Tue, 2019-06-11 at 19:20 +0200, Laurent Vivier wrote: > The virtio-rng linux driver can be stuck in virtio_read() on a > wait_for_completion_killable() call if the virtio-rng device in QEMU > doesn't provide data. > > It's a problem, because virtio_read() is called from rng_get_data() > with >

Re: [Qemu-devel] [PATCH v2] rng-builtin: add an RNG backend that uses qemu_guest_getrandom()

2019-05-13 Thread Amit Shah
On (Fri) 10 May 2019 [17:19:12], Markus Armbruster wrote: > Laurent Vivier writes: > > > On 10/05/2019 14:27, Markus Armbruster wrote: > >> Laurent Vivier writes: > >> > >>> Add a new RNG backend using QEMU builtin getrandom function. > >>> > >>> It can be created and used with something like: >

[Qemu-devel] [Bug 1811758] Re: virtio-rng backend should use getentropy() syscall when available

2019-04-17 Thread Amit Shah
Yes, using getrandom() in qemu by default on systems that support it will be an improvement, and is the right approach. -- You received this bug notification because you are a member of qemu- devel-ml, which is subscribed to QEMU. https://bugs.launchpad.net/bugs/1811758 Title: virtio-rng backe

Re: [Qemu-devel] virtio-console downgrade the virtio-pci-blk performance

2018-10-15 Thread Amit Shah
On (Thu) 11 Oct 2018 [18:15:41], Feng Li wrote: > Add Amit Shah. > > After some tests, we found: > - the virtio serial port number is inversely proportional to the iSCSI > virtio-blk-pci performance. > If we set the virio-serial ports to 2(" type='virtio-serial&

Re: [Qemu-devel] [PATCH v2 17/29] virtio-serial: use DIV_ROUND_UP

2017-07-16 Thread Amit Shah
On (Thu) 13 Jul 2017 [18:32:07], Marc-André Lureau wrote: > I used the clang-tidy qemu-round check to generate the fix: > https://github.com/elmarco/clang-tools-extra > > Signed-off-by: Marc-André Lureau Reviewed-by: Amit Shah Amit -- http://log.amitshah.net/

Re: [Qemu-devel] [PATCH v4 11/13] virtio-console: chardev hotswap support

2017-07-03 Thread Amit Shah
On (Mon) 03 Jul 2017 [14:50:07], Anton Nefedov wrote: > On 06/29/2017 01:02 PM, Marc-André Lureau wrote: > > Hi > > > > Looks good, but please write something in the commit message about what > > needs to be done for be-change (what this patch does). > > > > thanks > > > > Hi, > > thank you!

Re: [Qemu-devel] [PATCH v2 0/2] migration: fix virtio-rng

2017-04-17 Thread Amit Shah
gt; can be run for minutes. > > I've been able to reproduce the problem locally on a host, > by adding network latency with "tc". Another condition is > to have an rng daemon running in the guest to generate > events in the virtio-rng device. Acked-by: Amit Shah Amit -- http://log.amitshah.net/

Re: [Qemu-devel] [PATCH] virtio-serial-bus: Delete timer from list before free it

2017-03-07 Thread Amit Shah
On (Mon) 06 Mar 2017 [11:29:31], zhanghailiang wrote: > Signed-off-by: zhanghailiang Reviewed-by: Amit Shah Michael, please pick this up. Amit -- http://log.amitshah.net/

[Qemu-devel] [PATCH] MAINTAINERS: update my email address

2017-02-03 Thread Amit Shah
I'm leaving my job at Red Hat, this email address will stop working next week. Update it to one that I will have access to later. Signed-off-by: Amit Shah --- MAINTAINERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/MAINTAINERS b/MAINTAINERS index 4382bcc..d6

[Qemu-devel] [PATCH] migration: remove myself as maintainer

2017-02-03 Thread Amit Shah
I'm switching jobs, and I'm not sure I can continue maintaining migration. Signed-off-by: Amit Shah --- MAINTAINERS | 1 - 1 file changed, 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 00b81f1..4382bcc 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -1431,7 +1431,6 @@

Re: [Qemu-devel] [for 2.9] migration/tracing: Add tracing on save

2017-01-24 Thread Amit Shah
f data is being saved. > > In vmstate_subsection_save I renamed the inner vmsd to avoid the aliasing > and be able to print both names. > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH] MAINTAINERS: Add myself as a migration submaintainer

2017-01-24 Thread Amit Shah
On (Tue) 24 Jan 2017 [10:04:37], Dr. David Alan Gilbert (git) wrote: > From: "Dr. David Alan Gilbert" > > Signed-off-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH v2] migration: Change name of live migration thread

2017-01-24 Thread Amit Shah
me 'migration/cpu#'. > > > Signed-off-by: Pankaj Gupta Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH] Change name of live migration thread

2017-01-22 Thread Amit Shah
th the name 'migration/cpu#'. Makes sense. Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PULL 0/4] migration: QTAILQ migration

2017-01-12 Thread Amit Shah
On (Fri) 06 Jan 2017 [12:10:22], Peter Maydell wrote: > On 5 January 2017 at 16:32, Amit Shah wrote: > > The following changes since commit dbe2b65566e76d3c3a0c3358285c0336ac61e757: > > > > Merge remote-tracking branch > > 'remotes/vivier/tags/m68k-for-2.9-pul

[Qemu-devel] [PULL 4/4] migration: add error_report

2017-01-05 Thread Amit Shah
From: Jianjun Duan Added error_report where version_ids do not match in vmstate_load_state. Signed-off-by: Jianjun Duan Reviewed-by: Dr. David Alan Gilbert Message-id: 1481224870-18247-5-git-send-email-du...@linux.vnet.ibm.com Signed-off-by: Amit Shah --- migration/vmstate.c | 6 ++ 1

[Qemu-devel] [PULL 2/4] migration: migrate QTAILQ

2017-01-05 Thread Amit Shah
: Amit Shah --- include/migration/vmstate.h | 20 + include/qemu/queue.h| 60 +++ migration/trace-events | 4 +++ migration/vmstate.c | 69 + 4 files changed, 153 insertions(+) diff

[Qemu-devel] [PULL 0/4] migration: QTAILQ migration

2017-01-05 Thread Amit Shah
The following changes since commit dbe2b65566e76d3c3a0c3358285c0336ac61e757: Merge remote-tracking branch 'remotes/vivier/tags/m68k-for-2.9-pull-request' into staging (2016-12-28 17:11:11 +) are available in the git repository at: https://git.kernel.org/pub/scm/virt/qemu/amit/migration.

[Qemu-devel] [PULL 1/4] migration: extend VMStateInfo

2017-01-05 Thread Amit Shah
Gilbert Message-id: 1481224870-18247-2-git-send-email-du...@linux.vnet.ibm.com Signed-off-by: Amit Shah --- hw/display/virtio-gpu.c | 8 +++- hw/intc/s390_flic_kvm.c | 8 +++- hw/net/vmxnet3.c| 24 +++--- hw/nvram/eeprom93xx.c | 8 +++- hw/nvram/fw_cfg.c

[Qemu-devel] [PULL 3/4] tests/migration: Add test for QTAILQ migration

2017-01-05 Thread Amit Shah
From: Jianjun Duan Add a test for QTAILQ migration to tests/test-vmstate.c. Signed-off-by: Jianjun Duan Reviewed-by: Dr. David Alan Gilbert Message-id: 1481224870-18247-4-git-send-email-du...@linux.vnet.ibm.com Signed-off-by: Amit Shah --- tests/test-vmstate.c | 147

Re: [Qemu-devel] [PATCH 0/2] pcspk migration compatibility

2016-11-28 Thread Amit Shah
If this is too late for 2.8 then I suggest we take the 1st > of these two patches, which just makes it a property to flip > for those of us who need it. Adding the 2nd patch after 2.8 > might cause problems for people using 2.8 with 2.7 machine > type. Reviewed-by: A

Re: [Qemu-devel] [PATCH for-2.8] migration: Fix return code of ram_save_iterate()

2016-11-08 Thread Amit Shah
On (Fri) 04 Nov 2016 [14:10:17], Thomas Huth wrote: > qemu_savevm_state_iterate() expects the iterators to return 1 > when they are done, and 0 if there is still something left to do. > However, ram_save_iterate() does not obey this rule and returns > the number of saved pages instead. This causes

[Qemu-devel] [PULL 18/18] MAINTAINERS: Add maintainer for COLO framework related files

2016-10-30 Thread Amit Shah
From: zhanghailiang Add myself as co-maintainer of COLO framework, so that I can get CC'ed on future patches and bugs for this feature. Signed-off-by: zhanghailiang Reviewed-by: Amit Shah Signed-off-by: Amit Shah --- MAINTAINERS | 8 1 file changed, 8 insertions(+) diff --

[Qemu-devel] [PULL 16/18] docs: Add documentation for COLO feature

2016-10-30 Thread Amit Shah
From: zhanghailiang Introduce the design of COLO, and how to test it. Signed-off-by: zhanghailiang Reviewed-by: Amit Shah Signed-off-by: Amit Shah --- docs/COLO-FT.txt | 189 +++ 1 file changed, 189 insertions(+) create mode 100644 docs

[Qemu-devel] [PULL 13/18] COLO: Introduce state to record failover process

2016-10-30 Thread Amit Shah
use the helpers to get and set the value. Signed-off-by: zhanghailiang Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Signed-off-by: Amit Shah --- include/migration/failover.h | 5 + migration/colo-failover.c| 41 + migration/colo.c

[Qemu-devel] [PULL 15/18] COLO: Implement failover work for secondary VM

2016-10-30 Thread Amit Shah
From: zhanghailiang If users require SVM to takeover work, COLO incoming thread should exit from loop while failover BH helps backing to migration incoming coroutine. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Signed-off

[Qemu-devel] [PULL 17/18] configure: Support enable/disable COLO feature

2016-10-30 Thread Amit Shah
liang Signed-off-by: Li Zhijian Signed-off-by: Gonglei Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Signed-off-by: Amit Shah --- configure| 11 +++ migration/colo.c | 2 +- 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/configure b/configure

[Qemu-devel] [PULL 06/18] COLO: Introduce checkpointing protocol

2016-10-30 Thread Amit Shah
periodic' checkpoint, for which the Secondary VM is not running, later we will support 'hybrid' mode. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Signed-off-by: Gonglei Cc: Eric Blake Cc: Markus Armbruster Cc: Dr. David Alan Gilbert Reviewed

[Qemu-devel] [PULL 07/18] COLO: Add a new RunState RUN_STATE_COLO

2016-10-30 Thread Amit Shah
Reviewed-by: Amit Shah Signed-off-by: Amit Shah --- qapi-schema.json | 5 - vl.c | 8 2 files changed, 12 insertions(+), 1 deletion(-) diff --git a/qapi-schema.json b/qapi-schema.json index cafada8..ee58fe6 100644 --- a/qapi-schema.json +++ b/qapi-schema.json @@ -175,12

[Qemu-devel] [PULL 12/18] COLO: Add 'x-colo-lost-heartbeat' command to trigger failover

2016-10-30 Thread Amit Shah
rkus Armbruster Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Signed-off-by: Amit Shah --- docs/qmp-commands.txt| 10 ++ hmp-commands.hx | 15 +++ hmp.c| 8

[Qemu-devel] [PULL 14/18] COLO: Implement the process of failover for primary VM

2016-10-30 Thread Amit Shah
wed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Signed-off-by: Amit Shah --- include/migration/colo.h | 3 +++ include/migration/failover.h | 1 + migration/colo-failover.c| 2 +- migration/colo.c | 50 4 files changed, 55

[Qemu-devel] [PULL 03/18] migration: Enter into COLO mode after migration if COLO is enabled

2016-10-30 Thread Amit Shah
ng will be handled in migration thread. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Signed-off-by: Gonglei Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Signed-off-by: Amit Shah --- include/migration/colo.h | 3 +++ migration/colo.c

[Qemu-devel] [PULL 05/18] COLO: Establish a new communicating path for COLO

2016-10-30 Thread Amit Shah
From: zhanghailiang This new communication path will be used for returning messages from Secondary side to Primary side. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Signed-off-by: Amit Shah --- migration/colo.c | 28

[Qemu-devel] [PULL 09/18] COLO: Load VMState into QIOChannelBuffer before restore it

2016-10-30 Thread Amit Shah
hould call qemu_system_reset() before load VM state, which can ensure the data is intact. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Signed-off-by: Gonglei Reviewed-by: Dr. David Alan Gilbert Cc: Dr. David Alan Gilbert Reviewed-by: Amit Shah Signed-off-by: Amit Shah --- migration/c

[Qemu-devel] [PULL 04/18] migration: Switch to COLO process after finishing loadvm

2016-10-30 Thread Amit Shah
ead for secondary VM, 'migration_incoming_co' records the original migration incoming coroutine. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Signed-off-by: Amit Shah --- include/migration/colo.h | 7 +++ incl

[Qemu-devel] [PULL 11/18] COLO: Synchronize PVM's state to SVM periodically

2016-10-30 Thread Amit Shah
From: zhanghailiang Do checkpoint periodically, the default interval is 200ms. Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Signed-off-by: Amit Shah --- migration/colo.c | 12 1 file changed, 12 insertions

[Qemu-devel] [PULL 02/18] COLO: migrate COLO related info to secondary node

2016-10-30 Thread Amit Shah
ether users configure the --enable-colo/disable-colo on the source/destination side or not; Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Signed-off-by: Gonglei Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Signed-off-by: Amit Shah --- include/migration/colo.h

[Qemu-devel] [PULL 08/18] COLO: Send PVM state to secondary side when do checkpoint

2016-10-30 Thread Amit Shah
David Alan Gilbert Cc: Dr. David Alan Gilbert Reviewed-by: Amit Shah Signed-off-by: Amit Shah --- migration/colo.c | 85 +++- migration/ram.c | 37 +--- 2 files changed, 105 insertions(+), 17 deletions(-) diff --git a/migratio

[Qemu-devel] [PULL 10/18] COLO: Add checkpoint-delay parameter for migrate-set-parameters

2016-10-30 Thread Amit Shah
. David Alan Gilbert Reviewed-by: Eric Blake Reviewed-by: Amit Shah Signed-off-by: Amit Shah --- docs/qmp-commands.txt | 2 ++ hmp.c | 8 migration/migration.c | 16 qapi-schema.json | 12 ++-- 4 files changed, 36 insertions(+), 2 deletions

[Qemu-devel] [PULL 01/18] migration: Introduce capability 'x-colo' to migration

2016-10-30 Thread Amit Shah
capabilities' to learn if colo is supported. The default value for COLO (COarse-Grain LOck Stepping) is disabled. Cc: Juan Quintela Cc: Amit Shah Cc: Eric Blake Cc: Markus Armbruster Signed-off-by: zhanghailiang Signed-off-by: Li Zhijian Signed-off-by: Gonglei Reviewed-by: Eric Blake Revi

[Qemu-devel] [PULL 00/18] migration: COLO

2016-10-30 Thread Amit Shah
From: Amit Shah The following changes since commit 5b2ecabaeabc17f032197246c4846b9ba95ba8a6: Merge remote-tracking branch 'remotes/kraxel/tags/pull-ui-20161028-1' into staging (2016-10-28 17:59:04 +0100) are available in the git repository at: https://git.kernel.org/pub/scm

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v23 18/18] MAINTAINERS: Add maintainer for COLO framework related files

2016-10-27 Thread Amit Shah
On (Thu) 27 Oct 2016 [14:43:09], zhanghailiang wrote: > Add myself as co-maintainer of COLO framework, so that > I can get CC'ed on future patches and bugs for this feature. > > Signed-off-by: zhanghailiang Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v22 17/17] configure: Support enable/disable COLO feature

2016-10-26 Thread Amit Shah
On (Wed) 26 Oct 2016 [23:42:10], zhanghailiang wrote: > configure --enable-colo/--disable-colo to switch COLO > support on/off. > > COLO feature doesn't depend on any other external librariesis, typo: libraries Amit

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v22 14/17] COLO: Implement the process of failover for primary VM

2016-10-26 Thread Amit Shah
Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian > Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v22 10/17] COLO: Add checkpoint-delay parameter for migrate-set-parameters

2016-10-26 Thread Amit Shah
off-by: zhanghailiang > Signed-off-by: Li Zhijian > Reviewed-by: Dr. David Alan Gilbert > Reviewed-by: Eric Blake Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v22 03/17] migration: Enter into COLO mode after migration if COLO is enabled

2016-10-26 Thread Amit Shah
> We reuse migration thread, so the process of checkpointing will be handled > in migration thread. > > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian > Signed-off-by: Gonglei > Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 03/17] migration: Enter into COLO mode after migration if COLO is enabled

2016-10-26 Thread Amit Shah
On (Wed) 26 Oct 2016 [21:49:10], Hailiang Zhang wrote: > On 2016/10/26 12:50, Amit Shah wrote: > >On (Tue) 18 Oct 2016 [20:09:59], zhanghailiang wrote: > >>Add a new migration state: MIGRATION_STATUS_COLO. Migration source side > >>enters this state after the first

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 05/17] COLO: Establish a new communicating path for COLO

2016-10-26 Thread Amit Shah
On (Wed) 26 Oct 2016 [22:05:22], Hailiang Zhang wrote: > On 2016/10/26 13:06, Amit Shah wrote: > >On (Tue) 18 Oct 2016 [20:10:01], zhanghailiang wrote: > >>This new communication path will be used for returning messages > >>from Secondary side to Primary side. > >&

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 17/17] configure: Support enable/disable COLO feature

2016-10-26 Thread Amit Shah
On (Wed) 26 Oct 2016 [08:42:27], Eric Blake wrote: > On 10/26/2016 01:07 AM, Amit Shah wrote: > > On (Tue) 18 Oct 2016 [20:10:13], zhanghailiang wrote: > >> configure --enable-colo/--disable-colo to switch COLO > >> support on/off. > >> COLO feature is enabled

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 00/17] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-10-26 Thread Amit Shah
On (Wed) 26 Oct 2016 [23:52:48], Hailiang Zhang wrote: > Hi Amit, > > On 2016/10/26 16:26, Amit Shah wrote: > >On (Wed) 26 Oct 2016 [14:43:30], Hailiang Zhang wrote: > >>Hi Amit, > >> > >>On 2016/10/26 14:09, Amit Shah wrote: > >>>Hello, >

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 00/17] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-10-26 Thread Amit Shah
On (Wed) 26 Oct 2016 [14:43:30], Hailiang Zhang wrote: > Hi Amit, > > On 2016/10/26 14:09, Amit Shah wrote: > >Hello, > > > >On (Tue) 18 Oct 2016 [20:09:56], zhanghailiang wrote: > >>This is the 21th version of COLO frame series. > >> > >>

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 07/17] COLO: Add a new RunState RUN_STATE_COLO

2016-10-26 Thread Amit Shah
nglei > Reviewed-by: Dr. David Alan Gilbert > Reviewed-by: Eric Blake Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 00/17] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-10-25 Thread Amit Shah
Hello, On (Tue) 18 Oct 2016 [20:09:56], zhanghailiang wrote: > This is the 21th version of COLO frame series. > > Rebase to the latest master. I've reviewed the patchset, have some minor comments, but overall it looks good. The changes are contained, and common code / existing code paths are no

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 17/17] configure: Support enable/disable COLO feature

2016-10-25 Thread Amit Shah
: Dr. David Alan Gilbert Reviewed-by: Amit Shah > v19: > - fix colo_supported() to return true > v11: > - Turn COLO on in default (Eric's suggestion) Can you recap why the suggestion was made to switch it on by default? Amit

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 16/17] docs: Add documentation for COLO feature

2016-10-25 Thread Amit Shah
On (Tue) 18 Oct 2016 [20:10:12], zhanghailiang wrote: > Introduce the design of COLO, and how to test it. > > Signed-off-by: zhanghailiang Reviewed-by: Amit Shah > + > +4. After the above steps, you will see, whenever you make changes to PVM, > SVM will be synced. > +You

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 15/17] COLO: Implement failover work for secondary VM

2016-10-25 Thread Amit Shah
eviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 14/17] COLO: Implement the process of failover for primary VM

2016-10-25 Thread Amit Shah
On (Tue) 18 Oct 2016 [20:10:10], zhanghailiang wrote: > For primary side, if COLO gets failover request from users. > To be exact, gets 'x_colo_lost_heartbeat' command. > COLO thread will exit the loop while the failover BH does the > cleanup work and resumes VM. > > Signed-off-by: zhanghailiang

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 13/17] COLO: Introduce state to record failover process

2016-10-25 Thread Amit Shah
to indicate the different stage of failover > process. > You should use the helpers to get and set the value. > > Signed-off-by: zhanghailiang > Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 12/17] COLO: Add 'x-colo-lost-heartbeat' command to trigger failover

2016-10-25 Thread Amit Shah
nghailiang > Signed-off-by: Li Zhijian > Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 11/17] COLO: Synchronize PVM's state to SVM periodically

2016-10-25 Thread Amit Shah
On (Tue) 18 Oct 2016 [20:10:07], zhanghailiang wrote: > Do checkpoint periodically, the default interval is 200ms. > > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian > Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 10/17] COLO: Add checkpoint-delay parameter for migrate-set-parameters

2016-10-25 Thread Amit Shah
On (Tue) 18 Oct 2016 [20:10:06], zhanghailiang wrote: > Add checkpoint-delay parameter for migrate-set-parameters, so that > we can control the checkpoint frequency when COLO is in periodic mode. > > Cc: Luiz Capitulino > Cc: Eric Blake > Cc: Markus Armbruster > Signed-off-by: zhanghailiang >

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 09/17] COLO: Load VMState into QIOChannelBuffer before restore it

2016-10-25 Thread Amit Shah
> load it into SVM. > > Besides, we should call qemu_system_reset() before load VM state, > which can ensure the data is intact. > > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian > Signed-off-by: Gonglei > Reviewed-by: Dr. David Alan Gilbert > Cc

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 08/17] COLO: Send PVM state to secondary side when do checkpoint

2016-10-25 Thread Amit Shah
On (Tue) 18 Oct 2016 [20:10:04], zhanghailiang wrote: > VM checkpointing is to synchronize the state of PVM to SVM, just > like migration does, we re-use save helpers to achieve migrating > PVM's state to Secondary side. > > COLO need to cache the data of VM's state in the secondary side before >

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 08/17] COLO: Send PVM state to secondary side when do checkpoint

2016-10-25 Thread Amit Shah
by: zhanghailiang > Signed-off-by: Gonglei > Signed-off-by: Li Zhijian > Reviewed-by: Dr. David Alan Gilbert > Cc: Dr. David Alan Gilbert Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 06/17] COLO: Introduce checkpointing protocol

2016-10-25 Thread Amit Shah
27;hybrid' mode. > > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian > Signed-off-by: Gonglei > Cc: Eric Blake > Cc: Markus Armbruster > Cc: Dr. David Alan Gilbert > Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit Shah > +static int colo_

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 05/17] COLO: Establish a new communicating path for COLO

2016-10-25 Thread Amit Shah
On (Tue) 18 Oct 2016 [20:10:01], zhanghailiang wrote: > This new communication path will be used for returning messages > from Secondary side to Primary side. > > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian > Reviewed-by: Dr. David Alan Gilbert Reviewed-by: Amit

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 04/17] migration: Switch to COLO process after finishing loadvm

2016-10-25 Thread Amit Shah
tion_incoming_exit_colo(void) > +{ > +colo_info.colo_requested = 0; Please use 'true' and 'false' for bools. Otherwise, Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 03/17] migration: Enter into COLO mode after migration if COLO is enabled

2016-10-25 Thread Amit Shah
On (Tue) 18 Oct 2016 [20:09:59], zhanghailiang wrote: > Add a new migration state: MIGRATION_STATUS_COLO. Migration source side > enters this state after the first live migration successfully finished > if COLO is enabled by command 'migrate_set_capability x-colo on'. > > We reuse migration thread

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 02/17] COLO: migrate COLO related info to secondary node

2016-10-25 Thread Amit Shah
t doesn't break compatibility > with migration no matter whether users configure the > --enable-colo/disable-colo > on the source/destination side or not; > > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian > Signed-off-by: Gonglei > Reviewed-by: Dr.

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v21 01/17] migration: Introduce capability 'x-colo' to migration

2016-10-25 Thread Amit Shah
apabilities' or hmp command 'info migrate_capabilities' > to learn if colo is supported. > > The default value for COLO is disabled. > > Cc: Juan Quintela > Cc: Amit Shah > Cc: Eric Blake > Cc: Markus Armbruster > Signed-off-by: zhanghailiang > Signed

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v20 00/17] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-10-05 Thread Amit Shah
On (Fri) 30 Sep 2016 [14:27:26], Hailiang Zhang wrote: > On 2016/9/30 13:53, Amit Shah wrote: > >In the meanwhile, can you check why the autobuilder fails to compile > >with your patchset? > > > > Yes, It was related to the 9th patch, where i used %lu to print value of

Re: [Qemu-devel] [PATCH 2/2] migration: send and check the devices between source and distination at the begining

2016-09-29 Thread Amit Shah
Hi, On (Thu) 29 Sep 2016 [19:06:32], Li Zhijian wrote: > Priviously, if the source and distination have different devices, source > could goto > the status "paused (postmigrate)", and the distination will exit that means > no qemu > is alive. > > After this patch, at above case, source can dect

Re: [Qemu-devel] [PATCH COLO-Frame (Base) v20 00/17] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-09-29 Thread Amit Shah
On (Thu) 29 Sep 2016 [16:46:20], zhanghailiang wrote: > This is the 20th version of COLO frame series. > > COLO Block replication and proxy (COLO compare) series are both been > merged into upstream already. And further works can be done now to > realize the full COLO feature. > > Athough there a

Re: [Qemu-devel] Migration dirty bitmap: should only mark pages as dirty after they have been sent

2016-09-29 Thread Amit Shah
On (Mon) 26 Sep 2016 [22:55:01], Chunguang Li wrote: > > > > > -原始邮件- > > 发件人: "Dr. David Alan Gilbert" > > 发送时间: 2016年9月26日 星期一 > > 收件人: "Chunguang Li" > > 抄送: qemu-devel@nongnu.org, amit.s...@redhat.com, pbonz...@redhat.com, > > stefa...@redhat.com, quint...@redhat.com > > 主题: Re: [

Re: [Qemu-devel] [PATCH] virtio-serial: virtio console emergency write support

2016-09-26 Thread Amit Shah
Hi, On (Wed) 21 Sep 2016 [14:17:48], Sascha Silbe wrote: > Add support for the virtio 1.0 "emergency write" > (VIRTIO_CONSOLE_F_EMERG_WRITE) feature. This is useful for early guest > debugging and might be used in cases where the guest crashes so badly > that it cannot use virtqueues. > > Disable

Re: [Qemu-devel] [PATCH v4] migrate: Fix bounds check for migration parameters in migration.c

2016-09-13 Thread Amit Shah
gt; -Include the commit id which caused the regression OK - I acked v1, but this is a better commit message. Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH] migrate: Fix bounds check for migration parameters in migration.c

2016-09-13 Thread Amit Shah
s, parmaters were getting set to > out-of-bounds values despite the error. > > Signed-off-by: Ashijeet Acharya Reviewed-by: Amit Shah Amit

Re: [Qemu-devel] [PATCH COLO-Frame v19 00/22] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-09-10 Thread Amit Shah
Hi, On (Fri) 09 Sep 2016 [14:45:36], Hailiang Zhang wrote: > ping ? Juan will start reviewing and picking patches soon.

Re: [Qemu-devel] [PATCH] MAINTAINERS: add virtio-* tests

2016-09-10 Thread Amit Shah
it is added to the "parent" section (aka. SCSI, Network devices, > virtio) > > Signed-off-by: Greg Kurz I'm fine with these. For places where my name appears: Reviewed-by: Amit Shah

Re: [Qemu-devel] [PATCH COLO-Frame v18 00/34] COarse-grain LOck-stepping(COLO) Virtual Machines for Non-stop Service (FT)

2016-08-25 Thread Amit Shah
On (Wed) 03 Aug 2016 [20:25:38], zhanghailiang wrote: > This is the 18th version of COLO FT feature. > > It is based on '[PATCH v24 00/12] Block replication for continuous > checkpoints' series. > The complete codes can be found from the link: > https://github.com/coloft/qemu/commits/colo-v3.1-pe

Re: [Qemu-devel] [PATCH COLO-Frame v18 02/34] migration: Introduce capability 'x-colo' to migration

2016-08-25 Thread Amit Shah
apabilities' or hmp command 'info migrate_capabilities' > to learn if colo is supported. > > Cc: Juan Quintela > Cc: Amit Shah > Cc: Eric Blake > Cc: Markus Armbruster > Signed-off-by: zhanghailiang > Signed-off-by: Li Zhijian > Signed-off-by: Gonglei

Re: [Qemu-devel] [PATCH COLO-Frame v18 01/34] configure: Add parameter for configure to enable/disable COLO support

2016-08-25 Thread Amit Shah
On (Wed) 03 Aug 2016 [20:25:39], zhanghailiang wrote: > configure --enable-colo/--disable-colo to switch COLO > support on/off. > COLO support is On by default. Can you please make this the last patch in the series - so we get the code in before we add in the config option? Better for bisection,

Re: [Qemu-devel] [PULL 2/2] e1000e: remove internal interrupt flag

2016-08-24 Thread Amit Shah
On (Tue) 23 Aug 2016 [23:12:21], Markus Armbruster wrote: > Amit Shah writes: > > > On (Mon) 22 Aug 2016 [16:09:27], Jason Wang wrote: > >> From: Cao jin > >> > >> Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, > >> E1000E_U

Re: [Qemu-devel] [PULL 2/2] e1000e: remove internal interrupt flag

2016-08-23 Thread Amit Shah
On (Mon) 22 Aug 2016 [16:09:27], Jason Wang wrote: > From: Cao jin > > Commit 66bf7d58 removed internal msi state flag E1000E_USE_MSI, > E1000E_USE_MSIX > is not necessary too, remove it now. And interrupt flag field intr_state also > can be removed now. > > CC: Dmitry Fleytman > CC: Jason Wan

[Qemu-devel] [PULL 2.7 4/4] migration/socket: fix typo in file header

2016-08-11 Thread Amit Shah
From: Cao jin Code of inet socket & unix socket is merged together. Also add some newlines, make code block well separated. Cc: Daniel P. Berrange Cc: Juan Quintela Cc: Amit Shah Reviewed-by: Daniel P. Berrange Signed-off-by: Cao jin Message-Id: <1469696074-12744-4-git-send-email

[Qemu-devel] [PULL 2.7 2/4] migration: mmap error check fix

2016-08-11 Thread Amit Shah
d be fixed. Signed-off-by: Evgeny Yakovlev Signed-off-by: Denis V. Lunev Reviewed-by: Amit Shah Reviewed-by: Dr. David Alan Gilbert CC: Juan Quintela CC: Amit Shah Message-Id: <1469785705-16670-1-git-send-email-...@openvz.org> Signed-off-by: Amit Shah --- migration/postcopy-ram.c | 3 ++-

[Qemu-devel] [PULL 2.7 3/4] migration: fix live migration failure with compression

2016-08-11 Thread Amit Shah
live migration. This should be fixed. Signed-off-by: Liang Li Reported-by: Jinshi Zhang Reviewed-by: Dr. David Alan Gilbert Message-Id: <1470702146-24399-1-git-send-email-liang.z...@intel.com> Signed-off-by: Amit Shah --- migration/qemu-file.c | 1 + 1 file changed, 1 insertion(+)

  1   2   3   4   5   6   7   8   9   10   >