[PATCH v3 2/2] vfio/spapr: Fix L2 crash with PCI device passthrough and memory > 128G

2025-04-10 Thread Amit Machhiwal
tal environments respectively. Signed-off-by: Amit Machhiwal --- hw/vfio/spapr.c | 36 +++- 1 file changed, 27 insertions(+), 9 deletions(-) diff --git a/hw/vfio/spapr.c b/hw/vfio/spapr.c index dd9207679dbe..32611096fa29 100644 --- a/hw/vfio/spapr.c +++ b/hw/vfio/

Re: [PATCH v2 1/2] vfio/spapr: Enhance error handling in vfio_spapr_create_window()

2025-04-10 Thread Amit Machhiwal
On 2025/04/08 11:46 AM, Cédric Le Goater wrote: > On 4/8/25 11:14, Amit Machhiwal wrote: > > Hi Cédric, > > > > Thanks for taking a look at this patch. Please find my responses below: > > > > On 2025/04/08 08:29 AM, Cédric Le Goater wrote: > > > Hello Am

[PATCH v2 1/2] vfio/spapr: Enhance error handling in vfio_spapr_create_window()

2025-04-10 Thread Amit Machhiwal
Introduce an Error ** parameter to vfio_spapr_create_window() to enable structured error reporting. This allows the function to propagate detailed errors back to callers. Suggested-by: Cédric Le Goater Signed-off-by: Amit Machhiwal --- hw/vfio/spapr.c | 23 --- 1 file

Re: [PATCH] vfio/spapr: Fix L2 crash with PCI device passthrough with L2 guest memory > 128G

2025-04-10 Thread Amit Machhiwal
Hi Cédric, Thanks for looking into this patch. Please find my response inline: On 2025/04/04 01:29 PM, Cédric Le Goater wrote: > On 4/4/25 11:17, Amit Machhiwal wrote: > > An L2 KVM guest fails to boot inside a pSeries LPAR when booted with a > > memory more than 128 GB

[PATCH v3 1/2] vfio/spapr: Enhance error handling in vfio_spapr_create_window()

2025-04-08 Thread Amit Machhiwal
Introduce an Error ** parameter to vfio_spapr_create_window() to enable structured error reporting. This allows the function to propagate detailed errors back to callers. Suggested-by: Cédric Le Goater Signed-off-by: Amit Machhiwal --- hw/vfio/spapr.c | 33 - 1

[PATCH v3 0/2] vfio/spapr: Fix L2 crash with PCI device passthrough

2025-04-08 Thread Amit Machhiwal
/20250407143119.1304513-1-amach...@linux.ibm.com/ * Added Error ** parameter in vfio_spapr_create_window() for enhanced error handling with error_setg() and friends v1: https://lore.kernel.org/all/20250404091721.2653539-1-amach...@linux.ibm.com/ Amit Machhiwal (2): vfio/spapr: Enhance error

Re: [PATCH v2 1/2] vfio/spapr: Enhance error handling in vfio_spapr_create_window()

2025-04-08 Thread Amit Machhiwal
Hi Cédric, Thanks for taking a look at this patch. Please find my responses below: On 2025/04/08 08:29 AM, Cédric Le Goater wrote: > Hello Amit, > > Please use --cover-letter for the next spin. Sure, will do. > > > On 4/7/25 16:31, Amit Machhiwal wrote: > > Introdu

[PATCH 2/2] vfio/spapr: Fix L2 crash with PCI device passthrough with L2 guest 1memory > 128G

2025-04-07 Thread Amit Machhiwal
tal environments respectively. Link: https://lore.kernel.org/qemu-devel/20250404091721.2653539-1-amach...@linux.ibm.com/ Signed-off-by: Amit Machhiwal --- hw/vfio/spapr.c | 36 +++- 1 file changed, 27 insertions(+), 9 deletions(-) diff --git a/hw/vfio/spapr.c b

Re: [PATCH 1/2] vfio/spapr: Enhance error handling in vfio_spapr_create_window()

2025-04-07 Thread Amit Machhiwal
Please ignore this patchset as I missed to add version information in it. I'll resend these patches shortly. Sorry for the noise. Thanks, Amit On 2025/04/07 07:53 PM, Amit Machhiwal wrote: > Introduce an Error ** parameter to vfio_spapr_create_window() to enable > structured erro

[PATCH v2 2/2] vfio/spapr: Fix L2 crash with PCI device passthrough with L2 guest memory > 128G

2025-04-07 Thread Amit Machhiwal
tal environments respectively. Link: https://lore.kernel.org/qemu-devel/20250404091721.2653539-1-amach...@linux.ibm.com/ Signed-off-by: Amit Machhiwal --- hw/vfio/spapr.c | 36 +++- 1 file changed, 27 insertions(+), 9 deletions(-) diff --git a/hw/vfio/spapr.c b

[PATCH 1/2] vfio/spapr: Enhance error handling in vfio_spapr_create_window()

2025-04-07 Thread Amit Machhiwal
Introduce an Error ** parameter to vfio_spapr_create_window() to enable structured error reporting. This allows the function to propagate detailed errors back to callers. Suggested-by: Cédric Le Goater Signed-off-by: Amit Machhiwal --- hw/vfio/spapr.c | 23 --- 1 file

[PATCH] vfio/spapr: Fix L2 crash with PCI device passthrough with L2 guest memory > 128G

2025-04-05 Thread Amit Machhiwal
tal environments respectively. Signed-off-by: Amit Machhiwal --- hw/vfio/spapr.c | 35 ++- 1 file changed, 26 insertions(+), 9 deletions(-) diff --git a/hw/vfio/spapr.c b/hw/vfio/spapr.c index 1a5d1611f2cd..07498218fea9 100644 --- a/hw/vfio/spapr.c +++ b/hw/vfio/

[PATCH] spapr: nested: Add Power11 capability support for Nested PAPR guests in TCG L0

2024-10-28 Thread Amit Machhiwal
h is based on [2]. [1] https://lore.kernel.org/all/20240221044623.1598642-1-...@ellerman.id.au/ [2] https://lore.kernel.org/all/20240731055022.696051-1-adit...@linux.ibm.com/ Signed-off-by: Amit Machhiwal --- hw/ppc/spapr_nested.c | 12 +++- include/hw/ppc/spapr_nested.h | 5

[PATCH v2] spapr: nested: Add support for DPDES SPR in GSB for TCG L0

2024-10-18 Thread Amit Machhiwal
Bora Signed-off-by: Amit Machhiwal --- Changes since v1: - Addressed Harsh's comments on v1 - Updated the patch description to more precise details of the issue - v1: https://lore.kernel.org/all/20241017110033.3929988-1-amach...@linux.ibm.com/ hw/ppc/spapr_nested.c

Re: [PATCH] spapr: nested: Add support for DPDES SPR in GSB for TCG L0

2024-10-18 Thread Amit Machhiwal
Hi Harsh, Thanks for looking into this patch. My comments are below: On 2024/10/18 02:13 PM, Harsh Prateek Bora wrote: > Hi Amit, > > On 10/18/24 10:47, Harsh Prateek Bora wrote: > > Hi Amit, > > > > On 10/17/24 16:30, Amit Machhiwal wrote: > > > The DPDE

[PATCH] spapr: nested: Add support for DPDES SPR in GSB for TCG L0

2024-10-17 Thread Amit Machhiwal
adding the required support and handling in QEMU TCG L0. [1] https://lore.kernel.org/all/20240605113913.83715-1-gau...@linux.ibm.com/ Fixes: 4a575f9a0567 ("spapr: nested: Initialize the GSB elements lookup table.") Suggested-by: Harsh Prateek Bora Reviewed-by: Vaibhav Jain Signed-of

Re: [PATCH v6 RESEND 0/5] Power11 support for QEMU [PSeries]

2024-09-01 Thread Amit Machhiwal
ic -drive file=/root/testing/debian-12-generic-ppc64el.qcow2,format=qcow2 -accel tcg -cpu Power11 Tested-by: Amit Machhiwal > * '-smp' option tested > * with compat mode: 'max-cpu-compat=power10' and 'max-cpu-compat=power9' > * with/without device &#

Re: [PATCH v6 RESEND 0/5] Power11 support for QEMU [PSeries]

2024-08-29 Thread Amit Machhiwal
Hi Aditya, On 2024/07/31 11:20 AM, Aditya Gupta wrote: > Overview > > > Split "Power11 support for QEMU" into 2 patch series: pseries & powernv. > > This patch series is for pseries support for Power11. > > As Power11 core is same as Power10, hence much of the code has been reused