[Bug 1873769] Re: SB16 audio playback freezes emulation in Windows 95 guest

2020-07-02 Thread Allan Peramaki
This is with GTK UI? Do you still have the same problem if you use Spice and remote-viewer instead? (GTK UI and Sound Blaster 16 emulation don't play well together. GTK UI does screen updates only when the main event loop becomes idle, but it never becomes idle when SB16 audio is playing due to th

Re: [PATCH] hw/audio/gus: Fix registers 32-bit access

2020-06-17 Thread Allan Peramaki
On 18/06/2020 01:25, Allan Peramaki wrote: On 17/06/2020 23:23, Peter Maydell wrote: Are these accesses all guaranteed to be correctly aligned to be 16 or 32 bit loads/stores ? Otherwise it would be better to use the ldl_p/stl_p/ldw_p/stw_p/etc accessors, which correctly handle possibly

Re: [PATCH] hw/audio/gus: Fix registers 32-bit access

2020-06-17 Thread Allan Peramaki
On 17/06/2020 23:23, Peter Maydell wrote: This patch is quite difficult to read because it mixes some whitespace only changes with some actual changes of behaviour. Sorry about that. I had to put some whitespace in the two lines I modified because of checkpatch.pl, but then the nearby lines w

[PATCH] hw/audio/gus: Fix registers 32-bit access

2020-06-15 Thread Allan Peramaki
Fix audio on software that accesses DRAM above 64k via register peek/poke and some cases when more than 16 voices are used. Fixes: 135f5ae1974c ("audio: GUSsample is int16_t") Signed-off-by: Allan Peramaki --- hw/audio/gusemu_hal.c | 6 +++--- hw/audio/gusemu_mixer.c | 8 ---