Re: [PATCH 6/6] net/vhost-user: Remove unused "err" from chr_closed_bh() (CID 1612365)

2025-07-19 Thread Peter Maydell
On Thu, 17 Jul 2025 at 18:50, Laurent Vivier wrote: > > The "err" variable was declared but never used within the > chr_closed_bh() function. This resulted in a dead code > warning (CID 1612365) from Coverity. > > Remove the unused variable and the associated error block > to resolve the issue. >

Re: [PATCH 5/6] net/passt: Initialize "error" variable in net_passt_send() (CID 1612368)

2025-07-19 Thread Peter Maydell
On Thu, 17 Jul 2025 at 18:51, Laurent Vivier wrote: > > This was flagged by Coverity as a memory illegal access. > > Initialize the pointer to NULL at declaration. > > Signed-off-by: Laurent Vivier > --- > net/passt.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/net/p

Re: [PATCH 3/6] net/passt: Remove dead code in passt_vhost_user_start error path (CID 1612371)

2025-07-19 Thread Peter Maydell
On Thu, 17 Jul 2025 at 18:50, Laurent Vivier wrote: > > In passt_vhost_user_start(), if vhost_net_init() fails, the "net" > variable is NULL and execution jumps to the "err:" label. > > The cleanup code within this label is conditioned on "if (net)", > which can never be true in this error case. T

Re: [PATCH 1/6] net/passt: Remove unused "err" from passt_vhost_user_event() (CID 1612375)

2025-07-19 Thread Peter Maydell
On Thu, 17 Jul 2025 at 18:43, Laurent Vivier wrote: > > The "err" variable was declared but never used within the > passt_vhost_user_event() function. This resulted in a dead code > warning (CID 1612375) from Coverity. > > Remove the unused variable and the associated error block > to resolve the

Re: [PATCH 2/6] net/vhost-user: Remove unused "err" from net_vhost_user_event() (CID 1612372)

2025-07-19 Thread Peter Maydell
On Thu, 17 Jul 2025 at 18:52, Laurent Vivier wrote: > > The "err" variable was declared but never used within the > net_vhost_user_event() function. This resulted in a dead code > warning (CID 1612372) from Coverity. > > Remove the unused variable and the associated error block > to resolve the is

Re: [PATCH 4/6] net/passt: Check return value of g_remove() in net_passt_cleanup() (CID 1612369)

2025-07-19 Thread Peter Maydell
On Thu, 17 Jul 2025 at 18:44, Laurent Vivier wrote: > > If g_remove() fails, use warn_report() to log an error. > > Signed-off-by: Laurent Vivier > --- > net/passt.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > Reviewed-by: Peter Maydell thanks -- PMM

Re: [PATCH v2 2/2] tests/functional/test_aarch64_rme: update image

2025-07-19 Thread Pierrick Bouvier
On 7/19/25 3:57 AM, Manos Pitsidianakis wrote: On Sat, Jul 19, 2025 at 7:00 AM Pierrick Bouvier wrote: TF-A needs to be patched to enable support for FEAT_TCR2 and FEAT_SCTLR2. This new image contains updated firmware. Signed-off-by: Pierrick Bouvier --- tests/functional/test_aarch64_rme_s

Re: [PATCH for-10.1] tcg/optimize: Don't fold INDEX_op_and_vec to extract

2025-07-19 Thread Peter Maydell
On Fri, 18 Jul 2025 at 18:46, Richard Henderson wrote: > > There is no such thing as vector extract. > > Fixes: 932522a9ddc1 ("tcg/optimize: Fold and to extract during optimize") > Resolves: https://gitlab.com/qemu-project/qemu/-/issues/3036 > Signed-off-by: Richard Henderson > --- > tcg/optimiz

Galaxy S2 in QEMU

2025-07-19 Thread Hydra
**Subject:** Add Samsung Galaxy S2 (Exynos 4210) support to QEMU Hello QEMU developers, I’m an adult exploring legacy ARM devices and interested in contributing toward Samsung Galaxy S2 (GT-i9100) emulation in QEMU. ### Current blockers: - **No NAND/BML support**: The Galaxy S2 uses bml partitio

Re: [PATCH v2 2/2] tests/functional/test_aarch64_rme: update image

2025-07-19 Thread Manos Pitsidianakis
On Sat, Jul 19, 2025 at 7:00 AM Pierrick Bouvier wrote: > > TF-A needs to be patched to enable support for FEAT_TCR2 and > FEAT_SCTLR2. This new image contains updated firmware. > > Signed-off-by: Pierrick Bouvier > --- > tests/functional/test_aarch64_rme_sbsaref.py | 64 --- > tests

Re: [PATCH RFC v3 08/13] qmp: update virtio features map to support extended features

2025-07-19 Thread Markus Armbruster
Paolo Abeni writes: > Extend the VirtioDeviceFeatures struct with an additional u64 > to track unknown features in the 64-127 bit range and decode > the full virtio features spaces for vhost and virtio devices. > > Also add entries for the soon-to-be-supported virtio net GSO over > UDP features.

Re: [PATCH] util: win32: Write hex value when can't get error message

2025-07-19 Thread Markus Armbruster
Kostiantyn Kostiuk writes: > g_win32_error_message - translate a Win32 error code > (as returned by GetLastError()) into the corresponding message. > > In the same time, we call error_setg_win32_internal with > error codes from different Windows componets like VSS or > Performance monitor that pr